Subject: Re: [bug#63542] [PATCH 12/19] gnu: python-astroquery: Use Gexp.

From: Vinicius Monego <[email-masked]>
Date: Tue, 23 May 2023 22:15:00 +0000

Em qua, 2023-05-17 às 00:23 +0100, Sharlatan Hellseher escreveu:
> * gnu/packages/astronomy.scm (python-astroquery): Use Gexp to
> simplify
> package style.
> ---
>  gnu/packages/astronomy.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index be4961b49e..5f5de193d0 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -1280,15 +1280,15 @@ (define-public python-astroquery
>          (base32
> "1vhkzsqlgn3ji5by2rdf2gwklhbyzvpzb1iglalhqjkkrdaaaz1h"))))
>      (build-system python-build-system)
> 

Astroquery contains pyproject.toml in its source code, did you attempt
to switch to pyproject-build-system here?

>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> +     (list
> +      #:phases
> +       #~(modify-phases %standard-phases
>           (add-before 'check 'writable-home
>             (lambda _                    ; some tests need a writable
> home
>               (setenv "HOME" (getcwd))))
>           (replace 'check
> -           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> +           (lambda* (#:key tests? #:allow-other-keys)
>               (when tests?
> -               (add-installed-pythonpath inputs outputs)
>                 (invoke "python" "-m" "pytest" "--pyargs"
> "astroquery"
>                         ;; Skip tests that require online data.
>                         "-m" "not remote_data")))))))

[...]

Vinicius