Subject: Re: bug#63533: test-mbrlen5.sh failure

From: Carlo Marcelo Arenas Belón <[email-masked]>
Date: Fri, 19 May 2023 12:43:17 -0700

On Thu, May 18, 2023 at 10:09:38PM +0200, Jim Meyering wrote:
> On Thu, May 18, 2023 at 2:44 PM Carlo Marcelo Arenas Belón
> <[email-masked]> wrote:
> > On Wed, May 17, 2023 at 09:09:02PM -0400, Caleb Zulawski wrote:
> > >
> > > Isn’t this test too strict, then?
> >
> > It shouldn't had been included with the release; the attached patch
> > should help with that for future releases.
> 
> Thanks for looking into this, Carlo.
> 
> However, I think we should not limit the gnulib tests that are run via
> grep just to accommodate systems with broken code, even when grep
> happens not to exercise the broken code path.

Make a good point, specially considering that it should only affect systems
that are EOL like Centos 7, Debian 9 or Ubuntu 16.04 (although some of those
might be still supported) and that would be also likely to fail for other
reasons (ex: not being Y2K38 safe).

I think though, for consistency, the attached should be applied instead.  A
snapshot build with it shows 3 failing gnulib tests when tested in
gcc45.fsffrance.org.

Carlo
>From 7ec5be02a08cc491f2b726116f7012beb977b09b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlo=20Marcelo=20Arenas=20Bel=C3=B3n?= <[email-masked]>
Date: Tue, 16 May 2023 00:11:24 -0700
Subject: [PATCH] gnulib: allow mbrtowc-tests

Since 6e319a8 (grep: improve performance for older glibc, 2014-09-14)
gnulib fixes for known bugs in mbrlen that are triggered by n == 0 (ex:
by glibc <= 2.19), among others, are not included.

Systems with that old glbc version are long EOL, so remove that filter.
---
 bootstrap.conf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index ec48c37..f7b8d17 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -17,7 +17,6 @@
 
 avoided_gnulib_modules='
   --avoid=lock-tests
-  --avoid=mbrtowc-tests
   --avoid=update-copyright-tests
 '
 
-- 
2.39.2 (Apple Git-143)