GNU bug report logs - #63527
[PATCH 0/3] Initial attempt at rumpdisk support for the Hurd.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Cc: 63527 <at> debbugs.gnu.org
Subject: [bug#63527] [PATCH 0/3] Initial attempt at rumpdisk support for the Hurd.
Date: Thu, 18 May 2023 19:17:11 +0200

Janneke Nieuwenhuizen <janneke <at> gnu.org> skribis:

> This uses the Debian Salsa rumpkernel package git as upstream as that is where
> delopment happens.  Once things have stabalized upstream may change to the
> NetBSD git from where Debian takes their snapshots.

Could you make it a comment close to the ‘origin’ form?

> * gnu/packages/hurd.scm (rumpkernel): New variable.

[…]

> +        #~(modify-phases %standard-phases

You can tell from the phases that it took of lot of sweat to get there.
:-)

Could you add a few comments while it’s fresh on your mind to explain
the various tweaks?  The ‘build’ phase is particularly intimidating.

> +      (native-inputs
> +       (list
> +        autoconf
> +        automake
> +        libgcrypt
> +        (if (%current-target-system)
> +            (let* ((cross-base (resolve-interface '(gnu packages cross-base)))
> +                   (cross-mig (module-ref cross-base 'cross-mig)))
> +              (cross-mig (%current-target-system)))
> +            mig)

I think you could #:use-module (gnu packages cross-base) and refer to
‘cross-mig’ directly.

Also, watch out the indentation.  ;-)

  (native-inputs
   (list autoconf
         automake
         …))

> +      (license (list
> +                asl2.0
> +                boost1.0

Could you add a comment above briefly stating what this list means?  (I
suppose each license applies to a specific part of the source?)

Anyhow, well done!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.