GNU bug report logs - #63527
[PATCH 0/3] Initial attempt at rumpdisk support for the Hurd.

Previous Next

Package: guix-patches;

Reported by: Janneke Nieuwenhuizen <janneke <at> gnu.org>

Date: Mon, 15 May 2023 19:36:02 UTC

Severity: normal

Tags: patch

Done: Josselin Poiret <dev <at> jpoiret.xyz>

Bug is archived. No further changes may be made.

Full log

Message #173 received at 63527 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>
Cc: 63527 <at> debbugs.gnu.org
Subject: Re: bug#63527: [PATCH 0/3] Initial attempt at rumpdisk support for
 the Hurd.
Date: Wed, 24 May 2023 11:32:35 +0200

Janneke Nieuwenhuizen <janneke <at> gnu.org> skribis:

> * gnu/bootloader/grub.scm (make-grub-configuration): When "noide" is in
> arguments, use device name "wd0" rather than "hd0".

[...]

> +        (let* ((kernel (menu-entry-multiboot-kernel entry))
> +               (arguments (menu-entry-multiboot-arguments entry))
> +               (disk (if (member "noide" arguments) "w" "h"))

Could you add a comment like:

  ;; Choose between device names as understood by Mach's built-in IDE
  ;; driver and those understood by rumpdisk (in the "noide" case).

(It’s a bit of an abstraction leak, but hey, we’ll worry about it when
we have another multiboot-compliant kernel.)

Ludo’.
This bug report was last modified 2 years and 28 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.