From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 15:25:18 2023 Received: (at submit) by debbugs.gnu.org; 15 May 2023 19:25:18 +0000 Received: from localhost ([127.0.0.1]:44445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pydor-0003rv-J5 for submit@debbugs.gnu.org; Mon, 15 May 2023 15:25:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:48898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pydoo-0003rg-AK for submit@debbugs.gnu.org; Mon, 15 May 2023 15:25:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pydod-0005Cm-Q0 for bug-guix@gnu.org; Mon, 15 May 2023 15:25:04 -0400 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pydob-0005hC-R1 for bug-guix@gnu.org; Mon, 15 May 2023 15:25:03 -0400 Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-7576516c81fso1013565885a.1 for ; Mon, 15 May 2023 12:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1684178700; x=1686770700; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VEBdcyH+gIhi1OeBS14VVE9LtnjbgQGM4Fndljc62N0=; b=l4VRj9vuRDpcUYyQwyYzvfDR8qq3/T/XgiShVDx7AXRFTr9bm7v4hvv4e/oa/N01/O rAOWa6SpJCvD5M2eyBgmR6HWB611sFFh8T3nWdkjzVIak/i/dvqWOUehdqhCZOeM8V8c H1Ma977oY+b0VeXiAKZ4QI4S5cMUEnSG+bPIRAI7wanvnO9ahllc4YI9F6uBN6hF3mgk GUwD5BHk2MJKXYvwKSGAc68ERtXM12lvU1imvyuWLXeaJvd6K7QGIi/m3mPhsVDZGU3N 3tASFpFg8r1sO/enaecnaKZDGT9u96NqWleHrO6LpMl/QqH8xVvg4ERDziOiNTn2pn9g PtLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684178700; x=1686770700; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VEBdcyH+gIhi1OeBS14VVE9LtnjbgQGM4Fndljc62N0=; b=InhsF7azl2Qv/gC9ns5L9Wp+d51tqYfSEzDtrxp3hegHnuIZ0qzAxIRbZ9DoEBkmnN d0SFJ91bUpL2rodvluWn5VOBSimi8oRNu89NozCUbxzOND/erja/7wjf0edpIzZJbzf7 PJ5lp9aTFgoV1dCvDvknPcvfu8jm29k18pE3C/cSyBU55Kl8ktBx8fdVFb4Hzjpx52AM vTvMPaS++RS6Y+ABCidnQR+Rx8QCBiuy5IkWlJHnD784eytGJXVETWspMsLW8ynB5Pf4 I9yGAF4AReX7UgdOeavig6nX2ho8T0/CWs8/o55rKRkgKaoIdrEv80STTIbKdWnWuURW sgqw== X-Gm-Message-State: AC+VfDwPBb/nfjotUjBPMmN+hWYOHWhbuvgWQA8VphxHOtHHn9zUX58y j5gFUaI6dUZ1UUsoeMC3KVKOn9lZYeY1s5TTUkdLqNJt/qQ= X-Google-Smtp-Source: ACHHUZ7pajrHKzPhomuhdtOv3jCQISl3TydSmcS9EZsiXqB45nwZ6B7+VgfHsu/QR+Lyisa1F7JAURnPr0hipcc0Zb8= X-Received: by 2002:a05:622a:1313:b0:3f5:315f:5c16 with SMTP id v19-20020a05622a131300b003f5315f5c16mr5338558qtk.4.1684178700022; Mon, 15 May 2023 12:25:00 -0700 (PDT) MIME-Version: 1.0 From: Andy Tai Date: Mon, 15 May 2023 12:24:24 -0700 Message-ID: Subject: hubbub build failure when doing guix package -u To: bug-guix@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::72d; envelope-from=lichengtai@gmail.com; helo=mail-qk1-x72d.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) key lines: COMPILE: test/tokeniser2.c COMPILE: test/tokeniser3.c COMPILE: test/tree.c COMPILE: test/tree2.c COMPILE: test/tree-buf.c test/tokeniser2.c: In function =E2=80=98token_handler=E2=80=99: test/tokeniser2.c:444:46: error: =E2=80=98t.data.character.ptr=E2=80=99 may= be used uninitialized [-Werror=3Dmaybe-uninitialized] 444 | t.data.character.ptr +=3D len; | ^~ test/tokeniser2.c:441:38: note: =E2=80=98t=E2=80=99 declared here 441 | hubbub_token t; | ^ test/tokeniser2.c:445:46: error: =E2=80=98t.data.character.len=E2=80=99 may= be used uninitialized [-Werror=3Dmaybe-uninitialized] 445 | t.data.character.len -=3D len; | ^~ test/tokeniser2.c:441:38: note: =E2=80=98t=E2=80=99 declared here 441 | hubbub_token t; | ^ test/tokeniser3.c: In function =E2=80=98token_handler=E2=80=99: test/tokeniser3.c:453:46: error: =E2=80=98t.data.character.ptr=E2=80=99 may= be used uninitialized [-Werror=3Dmaybe-uninitialized] 453 | t.data.character.ptr +=3D len; | ^~ test/tokeniser3.c:450:38: note: =E2=80=98t=E2=80=99 declared here 450 | hubbub_token t; | ^ test/tokeniser3.c:454:46: error: =E2=80=98t.data.character.len=E2=80=99 may= be used uninitialized [-Werror=3Dmaybe-uninitialized] 454 | t.data.character.len -=3D len; | ^~ test/tokeniser3.c:450:38: note: =E2=80=98t=E2=80=99 declared here 450 | hubbub_token t; | ^ LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-l= ib-shared/test_entities LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-l= ib-shared/test_csdetect LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-l= ib-shared/test_tokeniser LINK: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-l= ib-shared/test_parser cc1: all warnings being treated as errors make: *** [/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem-= 1.9/share/netsurf-buildsystem/makefiles/Makefile.top:631: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/= test_tokeniser2.o] Error 1 make: *** Waiting for unfinished jobs.... cc1: all warnings being treated as errors make: *** [/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem-= 1.9/share/netsurf-buildsystem/makefiles/Makefile.top:631: build-x86_64-unknown-linux-gnu-x86_64-unknown-linux-gnu-release-lib-shared/= test_tokeniser3.o] Error 1 Test suite failed, dumping logs. error: in phase 'check': uncaught exception: %exception #<&invoke-error program: "make" arguments: ("test" "-j" "31" "COMPONENT_TYPE=3Dlib-shared" "CC=3Dgcc" "BUILD_CC=3Dgcc" "PREFIX=3D/gnu/store/7fn6jxg1vpadm8rpa8rzbwqgipxlwync-hubbub-0.3.7" "NSSHARED=3D/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem= -1.9/share/netsurf-buildsystem") exit-status: 2 term-signal: #f stop-signal: #f> phase `check' failed after 0.2 seconds command "make" "test" "-j" "31" "COMPONENT_TYPE=3Dlib-shared" "CC=3Dgcc" "BUILD_CC=3Dgcc" "PREFIX=3D/gnu/store/7fn6jxg1vpadm8rpa8rzbwqgipxlwync-hubb= ub-0.3.7" "NSSHARED=3D/gnu/store/3jqaqf59ra550lk7hvpgpg8l5krxizra-netsurf-buildsystem= -1.9/share/netsurf-buildsystem" failed with status 2 From debbugs-submit-bounces@debbugs.gnu.org Mon May 22 02:45:12 2023 Received: (at 63526) by debbugs.gnu.org; 22 May 2023 06:45:12 +0000 Received: from localhost ([127.0.0.1]:33388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0zI8-00069p-6t for submit@debbugs.gnu.org; Mon, 22 May 2023 02:45:12 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:52303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0zI6-00069U-03 for 63526@debbugs.gnu.org; Mon, 22 May 2023 02:45:10 -0400 Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-64d24136663so2782559b3a.0 for <63526@debbugs.gnu.org>; Sun, 21 May 2023 23:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684737904; x=1687329904; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=XEGZZBbItqydqmdUeJfcqs301RNefno1+yZPalJETWw=; b=knwAaZuu4/DyHdWXOlvoy0tZA8VCIjo/N6xYogQJEy/QyJ1YXCjjK338leenl327S/ 2PFJeiu/xwNen8oWl+RcPBVixRJLZG2VddRcH3DlaOaZrLsgs8gBXCDoMG2azBs8gcG4 Ex/4Xva0i8K20RKJa8uvgj+0agJ7Y3xqNRt/VaiP5NRd16LARlIZaQ83NLk6p973LIEh J+Dn4IzcQCV1uxaCsjmsEsBCBeN1QAlKplrSmGuoR9vgy4T/PdFXsw7gha3pxdb6iTfR BVtBcnCAK5foph1XpRS8M1nZ8V05QK5Gntba4Mw3q0msZRnJdpDm/m6d4APEY6yrxadO 3kJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684737904; x=1687329904; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XEGZZBbItqydqmdUeJfcqs301RNefno1+yZPalJETWw=; b=TeH6pIQCTc52y2Ng7SZ/K74je8uTgoP4g7UcVY/EFjBfZ1TXpOGXUiesklZeCNdTVT gySW7+dAD/Cl2xwXh5vp/QnNJAkMs0H3yXBGPt3HQNx19eBw1JUDztHjLuB3y1F3m+U9 l4/StjGedjBv+jt2g2vLYm0s4pKuymk8uC1D7oGSrtoqcAdthmAI8hK1zhl6MwrOoU+v X6dYuuL8GSvxnLFFL/hFQN5I17Ww892yQszs5euT4Wxwr2M2bxipxFRoBf8zvH/+VrbR BD+hGHeniMf0v2/J67hvFHBvQRhVnMfovjTog8AY5RIacCUmvrTvbTncBAH9arQ+5bmA vfyw== X-Gm-Message-State: AC+VfDy+uPpSCx2kRtrU2XErebuYtAetC2cuOJx5YDrZYPI2wvWBWdj8 NnE3WwZ34m9hnneaZlpRvlGkWIC4AUw= X-Google-Smtp-Source: ACHHUZ5N+9cvuZikh/X1mdeZ6JNG2qNe5Uwzs/KoHZzgcgnqipUBFoCkPkNZHpRX0R2CEawSawt/eA== X-Received: by 2002:a05:6a00:1a15:b0:643:b4d5:e3db with SMTP id g21-20020a056a001a1500b00643b4d5e3dbmr13518794pfv.4.1684737903647; Sun, 21 May 2023 23:45:03 -0700 (PDT) Received: from localhost.localdomain ([98.37.226.98]) by smtp.googlemail.com with ESMTPSA id i19-20020aa787d3000000b0063d2d9990ecsm3469212pfo.87.2023.05.21.23.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 May 2023 23:45:03 -0700 (PDT) From: Andy Tai To: 63526@debbugs.gnu.org Subject: [PATCH] gnu: hubbub: Disable building tests Date: Sun, 21 May 2023 23:44:59 -0700 Message-Id: <0b33a2a18cd178f84c55db0b295b0d0010d3cbd1.1684737820.git.atai@atai.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 63526 Cc: Andy Tai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 * gnu/packages/web.scm (hubbub): [arguments] (tests): Set to #f to disable test build --- gnu/packages/web.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index fe52f673e2..203e3283cf 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -5252,7 +5252,9 @@ (define-public hubbub perl)) (propagated-inputs (list libparserutils)) ;for libhubbub.pc - (arguments netsurf-buildsystem-arguments) + (arguments + `(#:tests? #f ;build error in building tests with gcc 11; skip for now + ,@netsurf-buildsystem-arguments)) (home-page "https://www.netsurf-browser.org/projects/hubbub/") (synopsis "HTML5 compliant parsing library") (description base-commit: 3abcf1663b86bc075e29563140698d8bfae44992 -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Thu May 25 09:03:03 2023 Received: (at 63526) by debbugs.gnu.org; 25 May 2023 13:03:03 +0000 Received: from localhost ([127.0.0.1]:46239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2AcR-0005j9-BX for submit@debbugs.gnu.org; Thu, 25 May 2023 09:03:03 -0400 Received: from mail-yb1-f176.google.com ([209.85.219.176]:49227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2AcP-0005iY-0a for 63526@debbugs.gnu.org; Thu, 25 May 2023 09:03:02 -0400 Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-ba80dc46972so762938276.2 for <63526@debbugs.gnu.org>; Thu, 25 May 2023 06:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20221208.gappssmtp.com; s=20221208; t=1685019775; x=1687611775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xHrS/x1IzGguWOYcAp/jynr5jmFIernunER7tIuB+ZQ=; b=joyymUh8Mp7flp9EGnbSHjFZl58NAmF4wTVClUSJe2SQhWBJFfMVjQdoWWhiQAdF9b zULESRwEaOXECAMwSIEF0FuGGKGsY0Qie3sml1cLmhYr/6SRAEJp7v4CXWe6NKO49r+5 z9+uPo2vAnSxTp772hT+72IOvV+7bfXUCbm5Z+8CQWb8qksbIeftS6ZSGxEMbG+4/L+4 MPe1qgmAlvrD86PocIEmwNL9f4yGV33/i5+HSZiw66yn57MSBvGYyEkVZC/Uh7KCPATk OfJqDOMggYSi9/tucxCIcoIo5setoOmi1tvrOsN5kDjOFS4HxPhb0/jKlmXYwWTVt9y9 rMPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685019775; x=1687611775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xHrS/x1IzGguWOYcAp/jynr5jmFIernunER7tIuB+ZQ=; b=Y+dXIjoXYrbBalopK6eXb5Jb75ZbDyxeWrejuRMtSBw04FRGIRqhrFQtk+sOcgUEJI 8+xXanO7XAPJFhhiDfJdJVKXAB/RXYz7Noon0AVPf2/mH7KKS84MgcxRE9nsrf5ZzYX5 nOSDpa1ZcQ0+gkki04YiFzpxIqUd+m6B8CvsCdhSIgZD1Is+fZEX4fx3BxcYU8HuggNq VP26oKKmXttzCq+Zs4rMzz/Q48Z4UTSKEuKlhjCjdEHWil5PTV7ohGzIf8/m8QwGIcF7 D3pS53fxARe5xWKmmTjXtW3LeiIDZ8zthfER1CbaUFMTMTNoEHN6sLnTHFXK1QR8M//k YHVQ== X-Gm-Message-State: AC+VfDzv7SzBEKlV6SCk5g0unIXmEW4xtdi9vosfvbTjhJZlJu5gbOsC 4qgnQqrrDKYkA4IlgqCKNtPla6xYiRNMKv864rTDQWuXXeIY5i+Y X-Google-Smtp-Source: ACHHUZ6/ImcAM+qx9HJ1LOnHEWS7ixhXNJcUZu7q/s0I6xBFBIW97dZIyXv/m15G8P/zoG4vxJWhPNg34JL4r2KgbC0= X-Received: by 2002:a25:68d3:0:b0:bac:6812:88f9 with SMTP id d202-20020a2568d3000000b00bac681288f9mr3424471ybc.36.1685019775312; Thu, 25 May 2023 06:02:55 -0700 (PDT) MIME-Version: 1.0 References: <0b33a2a18cd178f84c55db0b295b0d0010d3cbd1.1684737820.git.atai@atai.org> In-Reply-To: <0b33a2a18cd178f84c55db0b295b0d0010d3cbd1.1684737820.git.atai@atai.org> From: Greg Hogan Date: Thu, 25 May 2023 09:02:44 -0400 Message-ID: Subject: Re: bug#63526: [PATCH] gnu: hubbub: Disable building tests To: Andy Tai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63526 Cc: 63526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, May 22, 2023 at 2:46=E2=80=AFAM Andy Tai wrote: > > Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63526 > > * gnu/packages/web.scm (hubbub): [arguments] (tests): Set to #f to disabl= e test build > --- > gnu/packages/web.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index fe52f673e2..203e3283cf 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -5252,7 +5252,9 @@ (define-public hubbub > perl)) > (propagated-inputs > (list libparserutils)) ;for libhubbub.pc > - (arguments netsurf-buildsystem-arguments) > + (arguments > + `(#:tests? #f ;build error in building tests with gcc 11; skip for= now > + ,@netsurf-buildsystem-arguments)) > (home-page "https://www.netsurf-browser.org/projects/hubbub/") > (synopsis "HTML5 compliant parsing library") > (description > > base-commit: 3abcf1663b86bc075e29563140698d8bfae44992 > -- > 2.40.1 Hi Andy, Disabling tests should be a last resort, especially without a process to evaluate re-enabling tests in the future. Based on the error, can we instead add "-Wno-error=3Dmaybe-uninitialized" to the configure-flags? Greg From debbugs-submit-bounces@debbugs.gnu.org Thu May 25 09:35:23 2023 Received: (at 63526) by debbugs.gnu.org; 25 May 2023 13:35:23 +0000 Received: from localhost ([127.0.0.1]:46293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2B7j-0000YM-Ia for submit@debbugs.gnu.org; Thu, 25 May 2023 09:35:23 -0400 Received: from smtpm2.myservices.hosting ([185.26.105.233]:39216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2B7i-0000YD-0y for 63526@debbugs.gnu.org; Thu, 25 May 2023 09:35:22 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm2.myservices.hosting (Postfix) with ESMTP id 6AC0220E70; Thu, 25 May 2023 15:35:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id D6676800B6; Thu, 25 May 2023 15:35:18 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BqdbnACfaKnJ; Thu, 25 May 2023 15:35:18 +0200 (CEST) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 545B8800B5; Thu, 25 May 2023 15:35:18 +0200 (CEST) Message-ID: <3c4419ef-5d5e-451f-8985-ef4b8e06d068@makinata.eu> Date: Thu, 25 May 2023 14:35:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: bug#63526: [PATCH] gnu: hubbub: Disable building tests Content-Language: en-US To: Greg Hogan , Andy Tai References: <0b33a2a18cd178f84c55db0b295b0d0010d3cbd1.1684737820.git.atai@atai.org> From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 63526 Cc: 63526@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2023-05-25 14:02, Greg Hogan wrote: > Hi Andy, > > Disabling tests should be a last resort, especially without a process > to evaluate re-enabling tests in the future. I concur. A test failure, unless it is caused by things such as “requiring network access” or is expected due to guix specifics should be considered a problem with the package. (if tests are disabled simply because they happen to fail without doing any investigation, why have tests at all?) > Based on the error, can we instead add > "-Wno-error=maybe-uninitialized" to the configure-flags? I'd report this upstream first, it can be the case that the error (which is being flagged by the compiler) is unmasking a real bug upstream. -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno. From debbugs-submit-bounces@debbugs.gnu.org Thu May 25 13:55:22 2023 Received: (at 63526) by debbugs.gnu.org; 25 May 2023 17:55:22 +0000 Received: from localhost ([127.0.0.1]:48049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2FBJ-00052x-T9 for submit@debbugs.gnu.org; Thu, 25 May 2023 13:55:22 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:51609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2FBH-00052h-Ta for 63526@debbugs.gnu.org; Thu, 25 May 2023 13:55:20 -0400 Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f6b2f1a04bso13535551cf.3 for <63526@debbugs.gnu.org>; Thu, 25 May 2023 10:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1685037314; x=1687629314; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zcWHt/fJTHcYgqM9kzCPWQis7p/7V651TP2WdwvvpJ0=; b=M2KV8whu2QIHKXhg18l/hhq2FkUI4tEXDAsnNS32mqO1iwU5bOrL7q76icHGuzJOcu c1IyZa4uPWi35mjQyMLe1NppKtZ1pJhFkEQTxkwlfT0cXRlpLMeZGjBMPdNPCWaX3Jc1 EWeDLUWqPdESABFzYERgUuwwz3nvqVpE+h0DLZHLm1ayD3MO4pPGiBTcS8qjbRIkvgfp NFC2b281/Rko/2Y9DRp/KoJean3DCvyyr0CyoteqtfhFqXPgnQ5g5jbG3ktI3x3EO6je DGhB/NjIyOv6zg0oVpGHeZ1FgmjXJiyjZmNQsQNX9ISfQl1OxHovti01jt34Ljn7gtkg s//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685037314; x=1687629314; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zcWHt/fJTHcYgqM9kzCPWQis7p/7V651TP2WdwvvpJ0=; b=FmVwnKWFPyh0gl737P/OcVFch7p2vMlqiqwvelKLijqLyshAVca0I7yIXFItS3EJ2b SWYPQOiT1iMyrwo8VLqqIbtNAcvsY5g1KtS5u5ljTppopWAonyUVGi2PXjqox9Ban3CM i+a+P2Iti47JuVfkBTM0gE15u0MMVEF+rWxoJVV6zL+4grvyzJO+6X+RnwtUojayEcVE r+vFJD6blF/RQK3KyqCBbpjaAA4KJNDyXLxnc57mSciDYcMUHYNOYZ47ONPo3A+MYURb /kVAmjqtwB3UeQ3987EtYRsdxaGcnrI2uIxDitG0C5QWuQDi+LrMOTvg4bZCtJV9VIfQ NqsQ== X-Gm-Message-State: AC+VfDyYVZZrgIV5gsYmzOO1ExArbxemdm2O3Dzk6cSo/ippb0qVn2oK 9EhgFF0s38V6Uji9wSRetaHyzoDRtPX6MUcKokY= X-Google-Smtp-Source: ACHHUZ55uLWb2vr5PkGDCPuLE1Jb2udUxivoYRFtGa7K/h9qxhjFlqDX7oXRVbPwq/aySMpt6qnlTq/8nqxDXO7AwlM= X-Received: by 2002:ac8:5e53:0:b0:3f6:b0ee:dede with SMTP id i19-20020ac85e53000000b003f6b0eededemr393161qtx.52.1685037314078; Thu, 25 May 2023 10:55:14 -0700 (PDT) MIME-Version: 1.0 References: <0b33a2a18cd178f84c55db0b295b0d0010d3cbd1.1684737820.git.atai@atai.org> <3c4419ef-5d5e-451f-8985-ef4b8e06d068@makinata.eu> In-Reply-To: <3c4419ef-5d5e-451f-8985-ef4b8e06d068@makinata.eu> From: Andy Tai Date: Thu, 25 May 2023 10:54:37 -0700 Message-ID: Subject: Re: bug#63526: [PATCH] gnu: hubbub: Disable building tests To: Bruno Victal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 63526 Cc: 63526@debbugs.gnu.org, Greg Hogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Will do. Thanks On Thu, May 25, 2023 at 6:35=E2=80=AFAM Bruno Victal wr= ote: > > On 2023-05-25 14:02, Greg Hogan wrote: > > > Based on the error, can we instead add > > "-Wno-error=3Dmaybe-uninitialized" to the configure-flags? > > I'd report this upstream first, it can be the case that the error > (which is being flagged by the compiler) is unmasking a real bug > upstream. > From debbugs-submit-bounces@debbugs.gnu.org Sat May 27 03:29:19 2023 Received: (at 63526) by debbugs.gnu.org; 27 May 2023 07:29:19 +0000 Received: from localhost ([127.0.0.1]:51330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2oMZ-0004h3-4s for submit@debbugs.gnu.org; Sat, 27 May 2023 03:29:19 -0400 Received: from mail-pf1-f173.google.com ([209.85.210.173]:45514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2oMV-0004gl-Tp for 63526@debbugs.gnu.org; Sat, 27 May 2023 03:29:17 -0400 Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-64d2b42a8f9so1393742b3a.3 for <63526@debbugs.gnu.org>; Sat, 27 May 2023 00:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685172549; x=1687764549; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=h1OS5N2RFLBlmoBPH14MuAoU1gaXggJHM+OjOfbqyLw=; b=LTO8uaE9gcvFmfT/ISZTq2Zr58N+xYUd997U1n17KMa2VjfQix+26ZaZamWrxQuQOU UGNVEty0MaMz9iLBXiC6EjK9lefxlfXuq8jh1NPFA2fF11Y/YkR71MlA5WoVHKp656rg 2MCNbo3gSpjUqlRdOSzBlKreVx0dbZmsx9BAciqT4pG/F6ZODh+MsHDGNpBTZ+yfpelg ivvMs3JCFjTiPYtbnD2IeFl+Umn1+fhtYqJ4tjvTSZGHMrZnDatrStDdPOGdP8Nhrios ytb3geXt9+2bRMIY9IXqehFwnR4L9RxKs1DdSL2yYrhlgU3KhqMEWa7Kmszt6qIWS990 2Dqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685172549; x=1687764549; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h1OS5N2RFLBlmoBPH14MuAoU1gaXggJHM+OjOfbqyLw=; b=MSzyRd9gBRWv5u1XpwFZmqNvGpAD4rS9t9GKOoNphB5XpoKjEJTIhn4Uxiqj8kLf4T xJsTD2bWh/eh/Lukt+x1LiicM34MBMjF7r3jOG5ABgGiQW7KEQtSMZgXMkbwPpMauGJ5 nTD2Rn+hhERdHeccK9/SHR0IUAofpTLpCX1X6y8UK3YZ7I4GL4TtUmdjNovA2VJav2CA zT+8Z/Y6VVndT6qKibtxmJ9RhoX2qZcosqod9nEW1QvUH0PpX/htxQ0JkslHK2oWim0S nq2WLeoQPt7WWOUaSAMd+7hHQJJycrieVyGbnFaizUeldHxV3gdPLeDw/sbpwQrsppLQ O9gw== X-Gm-Message-State: AC+VfDxBAOmLZ4Vc2/h6yPl+vvf5fgvGy9l4BbUVvCjq4Nd8L0XVxTcF moxlBvssN/c99nLWKRd95dtb0wlXmqA= X-Google-Smtp-Source: ACHHUZ4xNA6KjWvQMXm1W3kCFjGxqh2JflggsrkWcMQ2SSGQG2fgb4lFkaJ+3IP8rn04wbuDuFHahg== X-Received: by 2002:a05:6a20:8408:b0:10b:97c8:2e16 with SMTP id c8-20020a056a20840800b0010b97c82e16mr2977299pzd.29.1685172549231; Sat, 27 May 2023 00:29:09 -0700 (PDT) Received: from localhost.localdomain ([98.37.226.98]) by smtp.googlemail.com with ESMTPSA id ck6-20020a17090afe0600b00246ba2b48f3sm7886378pjb.3.2023.05.27.00.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 May 2023 00:29:08 -0700 (PDT) From: Andy Tai To: 63526@debbugs.gnu.org, code@greghogan.com, mirai@makinata.eu Subject: [PATCH v2] gnu (hubbub): Fix build Date: Sat, 27 May 2023 00:29:04 -0700 Message-Id: <8a20497755db7ee3c2ecfa9a3fc931011718036d.1685172508.git.atai@atai.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 63526 Cc: Andy Tai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 * gnu/packages/web.scm (hubbub): [source](patches): Add patch to fix build. * gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch: New file * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 2 + ...aybe-uninitialized-build-failure-wit.patch | 40 +++++++++++++++++++ gnu/packages/web.scm | 4 +- 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch diff --git a/gnu/local.mk b/gnu/local.mk index 18e8235140..e2b42ca676 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -58,6 +58,7 @@ # Copyright © 2022 jgart # Copyright © 2023 Zheng Junjie <873216071@qq.com> # Copyright © 2023 Ivana Drazovic +# Copyright © 2023 Andy Tai # # This file is part of GNU Guix. # @@ -1349,6 +1350,7 @@ dist_patch_DATA = \ %D%/packages/patches/http-parser-CVE-2020-8287.patch \ %D%/packages/patches/htslib-for-stringtie.patch \ %D%/packages/patches/hubbub-sort-entities.patch \ + %D%/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch \ %D%/packages/patches/hueplusplus-mbedtls.patch \ %D%/packages/patches/hurd-add-without-rump-configure-option.patch \ %D%/packages/patches/hurd-fix-types-of-read-write-and-readables-methods-2.patch \ diff --git a/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch b/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch new file mode 100644 index 0000000000..6f289a770e --- /dev/null +++ b/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch @@ -0,0 +1,40 @@ +From 69d81a8a4d4c223aad67cde0fdf64d64351b9802 Mon Sep 17 00:00:00 2001 +From: Andy Tai +Date: Sat, 27 May 2023 00:01:34 -0700 +Subject: [PATCH] prevent -Werror=maybe-uninitialized build failure with gcc 11 + when building tests tokeniser2 and tokeniser3 + +--- + test/tokeniser2.c | 2 +- + test/tokeniser3.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/test/tokeniser2.c b/test/tokeniser2.c +index c8ab9c0..4caae38 100644 +--- a/test/tokeniser2.c ++++ b/test/tokeniser2.c +@@ -438,7 +438,7 @@ hubbub_error token_handler(const hubbub_token *token, void *pw) + /* Expected token only contained part of the data + * Calculate how much is left, then try again with + * the next expected token */ +- hubbub_token t; ++ hubbub_token t = { 0 }; + + t.type = HUBBUB_TOKEN_CHARACTER; + t.data.character.ptr += len; +diff --git a/test/tokeniser3.c b/test/tokeniser3.c +index e33d018..b3be901 100644 +--- a/test/tokeniser3.c ++++ b/test/tokeniser3.c +@@ -447,7 +447,7 @@ hubbub_error token_handler(const hubbub_token *token, void *pw) + /* Expected token only contained part of the data + * Calculate how much is left, then try again with + * the next expected token */ +- hubbub_token t; ++ hubbub_token t = { 0 }; + + t.type = HUBBUB_TOKEN_CHARACTER; + t.data.character.ptr += len; +-- +2.40.1 + diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index 3af4aa0b8d..387ceac058 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -5242,7 +5242,9 @@ (define-public hubbub (sha256 (base32 "1dimfyblmym98qa1b80c5jslv2zk8r44xbdrgrsrw1n9wr9y4yly")) - (patches (search-patches "hubbub-sort-entities.patch")))) + (patches (search-patches + "hubbub-sort-entities.patch" + "hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch")))) (build-system gnu-build-system) (native-inputs (list netsurf-buildsystem base-commit: b96b82bcd4bc24529941ff74a91432481f1a71b5 -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 22:53:10 2023 Received: (at control) by debbugs.gnu.org; 8 Jun 2023 02:53:10 +0000 Received: from localhost ([127.0.0.1]:55267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q75lt-0000ET-QJ for submit@debbugs.gnu.org; Wed, 07 Jun 2023 22:53:09 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:56468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q75lq-0000Dy-JU for control@debbugs.gnu.org; Wed, 07 Jun 2023 22:53:07 -0400 Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-3f86a7f3a65so1295351cf.0 for ; Wed, 07 Jun 2023 19:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1686192781; x=1688784781; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=urZFmDQnY/uQh8Tx97qsQR1M6H8vAyam3WtENzibjqE=; b=J/dEGAyuzO6ZtzxgZV6UtCwTf4PxvtdcR9kk4iQpiWYoSoh/JX5WUY0jVFKLKcxbO9 Lz7yl7TIdEmQho7k8q6Tu4Xc/vFqLXMX+T7MvmT9DWVuSGjrErAsLxM7oIayDnlfQ2MR p2PnAn2WhRCsK74nBkxxWwO1xCxNrIsIn2RvqvKM6/5cihHLaWjktn6SNoNsueWcLCmW IS7pPNJL1z74xu0WvP5pYWORrWeUdLflMvnhHU88TNKky67xRKPby/Hs7VQXiDKWsg8j +hK4M6YqKU0ghMDnygaDhDcj3NBVuNoWjZ7Nb3SWSEwmqAMOrOid30Zw/+c9Hwr4+0fr 28/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686192781; x=1688784781; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=urZFmDQnY/uQh8Tx97qsQR1M6H8vAyam3WtENzibjqE=; b=Le7VYeq2Lrxbod/NzIM8CrQEKGUqj/ToOXA9d6S09qlpjB4pn5bjTenyCpW6Za6zSl kMUTeucxUC0zsQ9mWrtCLuMMTPPQPvVzpQ4gi5HJxrnVnrd3kjpkIyUq9SPey1Dw+sKi iVUJsTQkiQo5YkGNEELTslTOwujNfRD0/a+fOxUBj4vh6LqNIUd7Yz016C+g67cp4fgT pMuyRElkthQ3P/KIHpKIRrlP95+4VgzkFHXiO+7LHeP/KY7DnMjjeyxMbrLe9czCFJBj oQY0vBiarRizFCykbCX5aHkv1wCdT7t2+WvB3meTPeagPjqSXPE92gFITRbzXg6RnSc8 IZog== X-Gm-Message-State: AC+VfDytWcOiUFDFQG0kjwLny1WcQhkbjuVdrq80LN+PV1YCnXuoLIVA Uqwr5l/3RIXXGw454NEyl6omtjmTQD0aCgoNMTUyxpR5gkg= X-Google-Smtp-Source: ACHHUZ7GrlHRKSONf7r7JwRAMA2RnEj0ErvNf7ldLHYGqLKV0uYwwiHM4Iy6Bt53wzECLrsA213LidTrz7WxzXY7nhQ= X-Received: by 2002:ac8:5989:0:b0:3f7:f961:d8db with SMTP id e9-20020ac85989000000b003f7f961d8dbmr6732497qte.14.1686192780868; Wed, 07 Jun 2023 19:53:00 -0700 (PDT) MIME-Version: 1.0 From: Andy Tai Date: Wed, 7 Jun 2023 19:52:24 -0700 Message-ID: Subject: To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: block 63526 by 63592 Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lichengtai[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.160.180 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.160.180 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: block 63526 by 63592 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.160.180 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.160.180 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lichengtai[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager block 63526 by 63592 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 23:35:40 2023 Received: (at control) by debbugs.gnu.org; 8 Jun 2023 03:35:40 +0000 Received: from localhost ([127.0.0.1]:55282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q76R1-0003mq-S4 for submit@debbugs.gnu.org; Wed, 07 Jun 2023 23:35:40 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:50308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q76R0-0003ma-87 for control@debbugs.gnu.org; Wed, 07 Jun 2023 23:35:39 -0400 Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-3f9b5ec058aso1344931cf.0 for ; Wed, 07 Jun 2023 20:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1686195332; x=1688787332; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=TlHlP9tpuSZczBPkP4bz9MJApkeCXpWDaWGhiEaMfSk=; b=uK/Yb+qBKaahpOrZ7vLpUjnynOQewkNuKUvy0kr6tP5e/8lGPFnG/oGT7tQTw4om7X Q4hunydzy6P2Z8/FHyMj6kICFhq+tXnPNwAjhfr6yHkqhaHHiCSlQkP05YeHfbpZG9cg IEY9g8qf1RsrjZG3gEbMjKIN5og697bCTrEQHT/Zu9cucgdmodIQcf8z53rihUtvcvQY IGrDUteqO8Bz6D1/9oTaXiBtZyE1HNSALCCXgiNfW3zhEJq4R+jgSfGCTPizBF7Fi6Fp EtP76SFjRrxcF63Bn1MdMafCnZZrcCwSll8jU6EmccLLh6VJAKSNmTUubpogrDOTQgsb KMOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686195332; x=1688787332; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TlHlP9tpuSZczBPkP4bz9MJApkeCXpWDaWGhiEaMfSk=; b=WEJedhrwO99b/rNbx2ca9DA7iC9N6YaR6h42fympF3lL1PaXKjJTid63wWmGUVfm0H rKAnRqScR0upJkd12iX4N2312fp6HEXizjJjfesXRL3zXo6vLtGo3RapSArcuygkz1Q1 COWxdQkHTMtuQWtSNy3Yc1nsaB80l3kyug2e0Cixrbbm+sK1E4TTsO2uGW9Lwe1AOxUk eZ0lEsGxz7pDjecsJKv3CNQmyr9YVFJWUXucbS1ud/X3A+NiTkNU/yp5KmFu9nfMLJ4i u/m2Fz2TOm/c/uOQy3gbZB1Q4CULGXkanV1B6KtiecJR+UroBGJVwl9aY+v7FgRghCzr z62w== X-Gm-Message-State: AC+VfDyyUMFh6Ylfip8PX1IG7lJN9h4oMkU0qapUSebVrx7mc6qHTy+C eDoOUo6BGp8iVB0IBELoKU+VwVKVMKzWhhoeP5x7HWDf/Go= X-Google-Smtp-Source: ACHHUZ7Snxfkcob2TG9IruzXonagsyI03nDTXHi41V6mJ1fUx4NO5JeUcm5erUJIihhx1ubsoCnk0KVhjrHjxJbKqc8= X-Received: by 2002:a05:622a:18c:b0:3f3:8e79:5742 with SMTP id s12-20020a05622a018c00b003f38e795742mr5914013qtw.19.1686195332314; Wed, 07 Jun 2023 20:35:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Tai Date: Wed, 7 Jun 2023 20:34:56 -0700 Message-ID: Subject: Re: To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) unblock 63526 by 63592 block 63526 by 63952 From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 07:07:40 2023 Received: (at 63526-done) by debbugs.gnu.org; 9 Jun 2023 11:07:40 +0000 Received: from localhost ([127.0.0.1]:58461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Zxz-000410-Uw for submit@debbugs.gnu.org; Fri, 09 Jun 2023 07:07:40 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:53740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Zxy-00040h-5n; Fri, 09 Jun 2023 07:07:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7B9732A2; Fri, 9 Jun 2023 13:07:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gwRfxlV6JGfv; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 931EC9E; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Date: Fri, 9 Jun 2023 13:07:30 +0200 From: Andreas Enge To: Andy Tai Subject: Re: ping on a build fix for a build failure (main branch) Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63526-done Cc: guix-devel@gnu.org, 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Andy, Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > Hi, following previous comments (thanks) I have submitted a patch to > correctly fix a build failure due to compiler warnings, instead of > avoiding not building tests, on this Guix bug issue: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 > Please review the patch (which shall be a simple and low risk fix). Thanks! I have reworked a bit the punctuation of the commit message, shortened the patch file name and pushed. By this I am closing the two corresponding bug reports (it would have been enough to send a second version of the patch to the first bug). Did you contact upstream? Looking at the test, it looked wrong before and after your patch... if (len < token->data.character.len) { hubbub_token t = { 0 }; t.type = HUBBUB_TOKEN_CHARACTER; t.data.character.ptr += len; t.data.character.len -= len; ... Adding to a previously undefined, now 0 pointer .ptr raised a warning for a reason, I think; and it looks like the t.data maybe should be token->data. But it is quite possible that this branch is not even reached by the test. Andreas From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 13:29:11 2023 Received: (at 63526-done) by debbugs.gnu.org; 9 Jun 2023 17:29:11 +0000 Received: from localhost ([127.0.0.1]:60288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7fvC-0002mS-W9 for submit@debbugs.gnu.org; Fri, 09 Jun 2023 13:29:11 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:50177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7fvB-0002m8-8F; Fri, 09 Jun 2023 13:29:10 -0400 Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f9b5ec058aso17725691cf.0; Fri, 09 Jun 2023 10:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1686331742; x=1688923742; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=A8pH/fXGfYsyrmjrTGjPyqENv6ybcRmpbgIKJBmIhUFRfzDhLh9LHMwo8oC1My9smM 26P/QmnVwg7B/VKWVWTJM9QCkzh8wqA1YDJ7pjSen1KdzVx4jiSqvfM78SV6zkCAtD6C rxbl382B4oZJrwM1YjXyExC3ymCzInxMu1wuMOxb9GaKcoB8N/FinovyWgiXWGF8BmlX hl0JPLut9SgN72g3uUFxekylftHZAeprphnu60huz949k3Slt0SuQjNpykmX1JutE9er ftZ7FgCROCWGgtQ4X5/3FsCKavHHlM2gPy/95WG0lSaQz0qEvxyiSOTGYKYobKqN9b4v 83Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686331742; x=1688923742; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=eKWQ1xXA/VUX8uhXgxAghIYL15NfKLJUUXmlNexI5mAkOkPccsPSMdpO6Hx2MlEQAw zNdQFEc9unbdpNKy/6jOKiSyiL6Q69MxsTgiRjT37p93lZe8YhlB8Wv6ZK2NKXMcJbtL FXHgfvbCwFFcPS5rxJbddWsohiHM4m/OsTFBqoP605p8RLDd1T5rIRx2GbzFjTw6oaE3 TTOm2/PUzNvcZjZEuC0w3/Wu+XBvFXy/36ubO3xC1de+x2+5b+I25MPzXnr5Byj4bOiK WMp6xcIB4CmFO75k+Js+07tSGUIogedxHQTG8kMHBTdgSWih+heJRZOuSsa1WuiUK4r3 0SMw== X-Gm-Message-State: AC+VfDxM0Fjt+2emEi13nRmIEMVJ7jtJmbrI4Hv6X5nxxZpWJJvwgYR4 T8MN+quCyhEde7xrl96zFs8BcCfZCEhzc2KkwUM= X-Google-Smtp-Source: ACHHUZ5Jvx3I2rC1srkLU8IfKa7oDhQBVCQ7SUxGD+9Pc6V177FaDzQqxs0RTm24k+bwD86XPXcITktGH9IJyDBGrNo= X-Received: by 2002:ac8:7d0e:0:b0:3f3:8819:67eb with SMTP id g14-20020ac87d0e000000b003f3881967ebmr3040241qtb.6.1686331741931; Fri, 09 Jun 2023 10:29:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Tai Date: Fri, 9 Jun 2023 10:28:25 -0700 Message-ID: Subject: Re: ping on a build fix for a build failure (main branch) To: Andreas Enge Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 63526-done Cc: guix-devel@gnu.org, 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I did contact upstream, no response On Fri, Jun 9, 2023 at 4:07=E2=80=AFAM Andreas Enge wrote= : > > Hello Andy, > > Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > > Hi, following previous comments (thanks) I have submitted a patch to > > correctly fix a build failure due to compiler warnings, instead of > > avoiding not building tests, on this Guix bug issue: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63526 > > Please review the patch (which shall be a simple and low risk fix). Th= anks! > > I have reworked a bit the punctuation of the commit message, shortened > the patch file name and pushed. By this I am closing the two correspondin= g > bug reports (it would have been enough to send a second version of the > patch to the first bug). > > Did you contact upstream? Looking at the test, it looked wrong before and > after your patch... > if (len < token->data.character.len) { > hubbub_token t =3D { 0 }; > t.type =3D HUBBUB_TOKEN_CHARACTER; > t.data.character.ptr +=3D len; > t.data.character.len -=3D len; > ... > Adding to a previously undefined, now 0 pointer .ptr raised a warning > for a reason, I think; and it looks like the t.data maybe should be > token->data. But it is quite possible that this branch is not even > reached by the test. > > Andreas > --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andyta= i1010 Year 2023 =E6=B0=91=E5=9C=8B112=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD From unknown Mon Sep 08 10:54:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Jul 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator