GNU bug report logs - #63470
[PATCH] Use faster option for running vc-hg status

Previous Next

Full log

Message #35 received at 63470 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 63470 <at> debbugs.gnu.org
Subject: Re: bug#63470: [PATCH] Use faster option for running vc-hg status
Date: Wed, 17 May 2023 07:47:09 -0400

[Message part 1 (text/plain, inline)]

On Wed, May 17, 2023, 07:39 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Spencer Baugh <sbaugh <at> janestreet.com>
> > Cc: Dmitry Gutov <dmitry <at> gutov.dev>,  63470 <at> debbugs.gnu.org
> > Date: Tue, 16 May 2023 16:39:49 -0400
> >
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> > >> Date: Fri, 12 May 2023 23:10:05 +0300
> > >> Cc: 63470 <at> debbugs.gnu.org
> > >> From: Dmitry Gutov <dmitry <at> gutov.dev>
> > >>
> > >> On 12/05/2023 22:57, Spencer Baugh wrote:
> > >> >
> > >> > I could add a user option to revert to the old behavior, if you
> want.
> > >>
> > >> We could cache it like we do with vc-git--program-version. That's a
> > >> simple memoization that doesn't take the host into account (though
> that
> > >> could be implemented, too).
> > >
> > > Yes, that'd be a good-enough solution.
> > >
> > >> But it'd really make things easier if we're just allowed to rely on
> some
> > >> new enough versions of Git and Hg.
> > >
> > > It isn't easy to be backward-compatible, but we should strive at doing
> > > that.
> >
> > OK, revised backwards-compatible patch attached.
>
> Thanks, but I'd prefer to call the new function only once, and record
> the result in some variable.  We do such things in umpteen other
> places, so it looks strange to test the version each time only in this
> case.
>

Isn't that what I'm doing? I record the version in a variable and only
compute it once.

Also, the way I'm doing it exactly matches how vc-git does it.

Do you mean a variable that controls whether to use the new argument
method? Should the result be computed at load time or at first use of the
variable?

>
> If you are afraid that somehow the version could change while the
> Emacs session runs, we could add a command to recompute the version.
> I think it's reasonable to ask the user to do this by hand, since
> installing a new version of Mercurial should be something users are
> aware of.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.