From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: rudalics@gmx.at, juri@linkov.net, dgutov@yandex.ru, bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 01:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 63455@debbugs.gnu.org Cc: rudalics@gmx.at, juri@linkov.net, dgutov@yandex.ru X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: rudalics@gmx.at, juri@linkov.net, dgutov@yandex.ru Received: via spool by submit@debbugs.gnu.org id=B.168385357925390 (code B ref -1); Fri, 12 May 2023 01:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 May 2023 01:06:19 +0000 Received: from localhost ([127.0.0.1]:53667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxHEh-0006bS-3k for submit@debbugs.gnu.org; Thu, 11 May 2023 21:06:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:43552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxHEf-0006bL-Eh for submit@debbugs.gnu.org; Thu, 11 May 2023 21:06:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxHEf-0005Sf-5K for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 21:06:17 -0400 Received: from mout.web.de ([217.72.192.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxHEZ-0006F4-LV for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 21:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1683853568; i=michael_heerdegen@web.de; bh=KXLiJprhzhB36DIdmdHFiBXt0tblk8X1i1xQV0ZsrxI=; h=X-UI-Sender-Class:From:To:Subject:Date; b=ppJEA9fCXPKzBSFrj7CDuvuCOImF64RzkC3iH17bIbkNnI88cBLwLhFar/igkdpyz 0RfDvTostj6L8zXxEx3V7E1qZK2gjaUdBUcC43QsYB3um1g+Troor1ymYCuEccrtHG gFeZtWPFKWtfWOxB/86HRaKTiql/J0xkIFTDSaRr3UGPtlfnt/pFdpMfYG+VmdGz+y cbWDcQ87WrAR/gdxAk+sChyPCtOjAoobQcUJMKUEvuYsfNZA55GSpcIieqkHBpVhJG FUEH4sPNNkGonZXiO07h1bXQ86vUI9j14UUWY7N7dc5E2Ob3TSOrC6w+wKkO2waEtf PEFmgn7dHXNOQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MNfU1-1pZPsq3mJP-00P8Aw for ; Fri, 12 May 2023 03:06:07 +0200 From: Michael Heerdegen Date: Fri, 12 May 2023 03:06:07 +0200 Message-ID: <87fs82z7cw.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:C7yocT0fxB0Bqdzn36Y3A6KD0nbGOWpLLdaGkAnU3LyOZEUmJk+ 3DvllEEkJqilM3HlX+oy/qzLIEtqKQNVTg1acUfSIqfo5zeb+yhMH0SWAnxuzYv+7tqWQM6 9Eg46t74Ms9CtUmZ0fDpE17KYziVWLfNNL5SHdUmhc7X9kSj/IwlVD2PNDjM56PBkDRD+8y cftqduo0BA+ElYAy1KFBw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6CeaGeO31I4=;zzUCIE0/f0HWNGoM1oOWVKaHsln F3iH9WJ6zvmk3mvg8PpYnNAEyUQtcTrji1aDf/wUZ/UPI547yEyDXhzG16baZDNbCbbafjqKu XuLnTxmYhx8fom24XvAkC95dRuR0bkAGF/f5IZIigY64DSGZ2dERCliKMKOaTYs3NVw3n1603 Aes0pYarLWv23vC5ed4y4G4Nt1OfWw6JRHrTcmJvyOLl9yNEagV0cg8m0mk0kEKlCatT+s1LQ xNjP8l72aCv/i3RnBgPzOO/HZ4IH1v4lHsGbntS7PHwGiEBmNkrS9r9+YYwxtHjGz3Fw0222N ialmYEL+6RPe+Ld/HN4d99e7ukEEFTCLm0hAjlmi1MHSvxIy8MgRpDvEPdyD1Y7jQ2EBtreKd J4VwmqFflkZkbT6SI4vsd9LQDe2hH7AakIuzLYlIqOx7YGAWlLxWXqgEhLN6XnEtdXyn8/moH 1OYCKYpmmTgKy7o2JtZs/AI37Sthbe04RjmGuW44fRrf3udf6VyIOq+Z60/OK0ho5ib9gJoMq dfrlJWfbBt/8SkQre9cvZ3KS+3+DuvbJSxADEuTijrN3vfc4HCyzlDzVRieMES0R3guY11YbP q9RI8YVjuzN/14psXG96SBO5ZY216zTPeb5BL862U2etFhEw9GF8yPnZTM3oLlFMbj0s0F9PY oJfG84VLsqSN3n3933L+/hKSXOIb3WtffXohTFVwy+AbRiBKcfzrRDcBpxfxVxq6a1zkennDN f9evfBOZ8P7W84G3Inh4koek6bFnuGoQdymgowTe9gGUDtDXp+QsWlFcNe3+U/tsY8NvmJbkL 83c//6/37cPf3beEpNDA0DIYfioegScIO3Gz4v7Wrr4XK1y3rMZVR386kpF92IVZkne1qdac7 01qDE8CKoCkeUYoIzRIPjf1i4IAivAb/1QPywaWh9OACC2MiyC2jyPVj8bom3cyJFZI23MlYJ 13JCZ/d48ajgUI4mCs1TRIqfdTI= Received-SPF: pass client-ip=217.72.192.78; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) X-Debbugs-CC: rudalics@gmx.at, juri@linkov.net, dgutov@yandex.ru Hello, (info "(elisp) Buffer Display Action Alists") says near the end: | If no =E2=80=98window-height=E2=80=99, =E2=80=98window-width=E2=80=99 = or =E2=80=98window-size=E2=80=99 entry was | specified, the window may still be resized automatically when the buffer | is temporary and =E2=80=98temp-buffer-resize-mode=E2=80=99 has been enabl= ed, *note | Temporary Displays::. In that case, the CDR of a =E2=80=98window-height= =E2=80=99, | =E2=80=98window-width=E2=80=99 or =E2=80=98window-size=E2=80=99 entry can= be used to inhibit or override | the default behavior of =E2=80=98temp-buffer-resize-mode=E2=80=99 for spe= cific buffers | or invocations of =E2=80=98display-buffer=E2=80=99. OTOH, the action `display-buffer-in-direction' _always_ resizes the window no matter what buffer is current. Try e.g. #+begin_src emacs-lisp (display-buffer (current-buffer) '((display-buffer-in-direction) . ((direction . top)))) #+end_src from any window or buffer. This is handled by this part of the implementation of `display-buffer-in-direction': #+begin_src emacs-lisp (setq alist (append alist `(,(if temp-buffer-resize-mode '(window-height . resize-temp-buffer-window) '(window-height . fit-window-to-buffer)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t)))))) #+end_src Looking at that it doesn't seem to be intended as a general behavior, and the behavior is not a good default IMO - even if it can be suppressed by adding a (window-height . nil) entry to the `display-buffer' call. I guess that Bug#45945 could be a symptom of this problem. TIA, Michael. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 07:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen , 63455@debbugs.gnu.org Cc: dgutov@yandex.ru, juri@linkov.net Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16838771912215 (code B ref 63455); Fri, 12 May 2023 07:40:02 +0000 Received: (at 63455) by debbugs.gnu.org; 12 May 2023 07:39:51 +0000 Received: from localhost ([127.0.0.1]:53957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNNX-0000Zf-CL for submit@debbugs.gnu.org; Fri, 12 May 2023 03:39:51 -0400 Received: from mout.gmx.net ([212.227.17.22]:46301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNNV-0000ZS-G5 for 63455@debbugs.gnu.org; Fri, 12 May 2023 03:39:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1683877182; i=rudalics@gmx.at; bh=Wd0/r03+GBue3pizsqZ29N1kkWrJdJTjPaxWd+42VFo=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=FZ7bxmLl7+2pQf91I1TFQUkUMwg5zOFlUD2Lawa2spLtw0zP8ubjB1e+W2nx+7wKV sCWy0kLxe8aMBVbSzCPmCe07Y3s70QYtxCI/WitKIUWoiwGmXS64mJ3mBsRXJ8pUv8 jTbXszUY5pPjWPlTXMzKVwjwu00qeRwJgGhwdyFrxXd4/tJxTlrwbTCqRJQDoyWp/z saBYdWf+Qd8wufTAHpksETMt3vY3e9li8MVI32SlffO0Yhs9b1uvN4l5S6i+MHUH1u VnnyKpMrqUpA6FF/iVWA6cYyaIT2aKokFE/OnXmJ+/E68/vUUr9DRHObYxZg08HDpW cvJcmU6ulmJAQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([212.95.5.175]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hvb-1qMhqb2eox-011jqk; Fri, 12 May 2023 09:39:42 +0200 Message-ID: <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> Date: Fri, 12 May 2023 09:39:40 +0200 MIME-Version: 1.0 Content-Language: en-US References: <87fs82z7cw.fsf@web.de> From: martin rudalics In-Reply-To: <87fs82z7cw.fsf@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:HS6k0i7XhGINYspODjOtPKVaghkFjz7VBKb9OzRbvl0Le2JSpEj zfZl8ZEM1iQjbogTNV7CLfZ06k1fBjTlAN/aBIChPJxJ87phpPV7CSn3b+0AkQ8HxNaP+vZ tB37KNNMeVwU4pkqNI6OKAck3dLFsJBztizEewXruPL8jAyr8/z2us8Gi44Ej0OfyFueCD0 8vy1KIFDZOy0cn4hIE3Yg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:WWhKt8Y+Uu0=;TGF2guqxVdVTtQCa4cdKEwWzAFV fy6XzkfBKOkNWS5DtlPnPcb/tdDXumc3XJHnWrI4+T8LhIRABv24PJ0ejiVNKG27nEx3+Hg5C XZrvY0bkq+6D/V9kD/qITCXeX5AonvSmVSD85goE1KAwWRn7Z/Uj7Dyo9xnT3qyPCTfVZfDyt 7VGCfpgHqof4bwzXz/DCvHwcaqTYOf2WlKjH2UWwEUBJwSQ0VfRIunJ+ZOZexXcMhRrld1Qd8 x/Sr+0DdJeVzadIlaz6N2xEzVVaKZkGg+FalnJOaSKyA4HYYCkGHl5XdbMf3VEAAY613GPYWy 6cVfHglF6WCe/dUhm9Yr4C27Dgp8JHMTyZpa6Os1Lf72GGbmSELUVstYT+pxnxJ7UKROT4uPG 4lsYCXBnGLvo+i73YluOS2R3TIEAXVR+woDFae4E4PqVkErLjACERQrdf57gjaohNy5s7jaZc a0fN7SMR5SKhzo6RtQrfGskAmzQNkjT6+PmNmz/FEq6stOengmxvg8mWWHdnfhf6iRXNahXnW ROs62AceGru/D1VrPnrLcmEsnW6YPGOzaDpNAWAhfGjdVYlYolFOyC3KID+8Cnf7eNZfOG3Lr 0m84QPiBbPU8/Sz6+E883R8WuhY4pBj+AY0HNEUQ9p7u37A6eE0tSRN35TG9WBVcwlyzZbW2Q 7VX5n051B9VKerod2bX8tCJum/LUE8LvleYLkxwXtRSXpv9vZJyaNPteq9iobUWfWacEXib8t USZIGipJ5BSD4PqgRMzfMGuv/dUlkhjA5PaGJzn3HaN5cPCpU08SshCi8lpiid1b/64/jRUKD hPMWYzvWJokVUjOEKtZMOFanNSW9Dm20Q1q4TRlSXqGUT0vjyTU9bh2cchGY0h3fBRXmiYHLa m3SWDqJMtTVHA0KI7bi4q0OuxLXtCSU7vjZD4Sah00/Ja7GpH5xonYrpzrVf/Ph97mB/DlTtk 68s9HxfpzhqgbdGA2Zm5+85z5Ig= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > OTOH, the action `display-buffer-in-direction' _always_ resizes the > window no matter what buffer is current. Try e.g. > > #+begin_src emacs-lisp > (display-buffer (current-buffer) > '((display-buffer-in-direction) . ((direction . top)))) > #+end_src > > from any window or buffer. > > This is handled by this part of the implementation of > `display-buffer-in-direction': > > #+begin_src emacs-lisp > (setq alist > (append alist > `(,(if temp-buffer-resize-mode > '(window-height . resize-temp-buffer-window) > '(window-height . fit-window-to-buffer)) > ,(when temp-buffer-resize-mode > '(preserve-size . (nil . t)))))) > #+end_src > > Looking at that it doesn't seem to be intended as a general behavior, > and the behavior is not a good default IMO - even if it can be > suppressed by adding a (window-height . nil) entry to the > `display-buffer' call. > > I guess that Bug#45945 could be a symptom of this problem. I think you're right. In my local Emacs I removed both incarnations of that code (the other one being in 'display-buffer--maybe-at-bottom') long ago. I can only shortly sketch how I manage things here: The end of 'help--window-setup' has become (help-window-setup (setq window (temp-buffer-window-show (current-buffer) nil t))) (help-make-xrefs (current-buffer)) (when (and window temp-buffer-resize-mode) (let (resize-temp-buffer-window-inhibit) (resize-temp-buffer-window window))))))) 'temp-buffer-window-show' has a third argument NO-RESIZE and its last lines are rewritten as (with-selected-window window (run-hooks 'temp-buffer-window-show-hook) (when (and (not no-resize) temp-buffer-resize-mode) (resize-temp-buffer-window window))) ;; Return the window. window)))) Maybe Juri can make heads or tails of this. martin From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: rudalics@gmx.at, 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16839124852840 (code B ref 63455); Fri, 12 May 2023 17:29:02 +0000 Received: (at 63455) by debbugs.gnu.org; 12 May 2023 17:28:05 +0000 Received: from localhost ([127.0.0.1]:60946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxWYm-0000jk-Mm for submit@debbugs.gnu.org; Fri, 12 May 2023 13:28:04 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxWYl-0000j9-0X for 63455@debbugs.gnu.org; Fri, 12 May 2023 13:28:04 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A261440007; Fri, 12 May 2023 17:27:54 +0000 (UTC) From: Juri Linkov In-Reply-To: <87fs82z7cw.fsf@web.de> (Michael Heerdegen's message of "Fri, 12 May 2023 03:06:07 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> Date: Fri, 12 May 2023 20:11:00 +0300 Message-ID: <86v8gxmq57.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > #+begin_src emacs-lisp > (setq alist > (append alist > `(,(if temp-buffer-resize-mode > '(window-height . resize-temp-buffer-window) > '(window-height . fit-window-to-buffer)) > ,(when temp-buffer-resize-mode > '(preserve-size . (nil . t)))))) > #+end_src > > Looking at that it doesn't seem to be intended as a general behavior, > and the behavior is not a good default IMO - even if it can be > suppressed by adding a (window-height . nil) entry to the > `display-buffer' call. > > I guess that Bug#45945 could be a symptom of this problem. Indeed, an unusual default. Is it possible to change this default now given there is code that might rely on it already? In the Emacs source tree most of calls already override the default: 're-builder', 'proced-with-processes-buffer', 'widget-choose', 'xref-show-definitions-buffer-at-bottom' (fixed in bug#45945 as you noted). But 'ediff-setup-windows-plain-compare' uses the current default. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16839124882857 (code B ref 63455); Fri, 12 May 2023 17:29:02 +0000 Received: (at 63455) by debbugs.gnu.org; 12 May 2023 17:28:08 +0000 Received: from localhost ([127.0.0.1]:60949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxWYq-0000k0-08 for submit@debbugs.gnu.org; Fri, 12 May 2023 13:28:08 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxWYo-0000jF-NM for 63455@debbugs.gnu.org; Fri, 12 May 2023 13:28:07 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 175F0C0004; Fri, 12 May 2023 17:27:58 +0000 (UTC) From: Juri Linkov In-Reply-To: <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> (martin rudalics's message of "Fri, 12 May 2023 09:39:40 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> Date: Fri, 12 May 2023 20:16:20 +0300 Message-ID: <86zg69lb6v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I think you're right. In my local Emacs I removed both incarnations of > that code (the other one being in 'display-buffer--maybe-at-bottom') > long ago. There are 3 uses of 'display-buffer--maybe-at-bottom' in the Emacs source tree: 'project-kill-buffers' and 'save-buffers-kill-emacs' override the default. But 'hack-local-variables-confirm' depends on the current default value. > I can only shortly sketch how I manage things here: The end > of 'help--window-setup' has become > > (help-window-setup > (setq window (temp-buffer-window-show (current-buffer) nil t))) > (help-make-xrefs (current-buffer)) > (when (and window temp-buffer-resize-mode) > (let (resize-temp-buffer-window-inhibit) > (resize-temp-buffer-window window))))))) > > 'temp-buffer-window-show' has a third argument NO-RESIZE and its last > lines are rewritten as > > (with-selected-window window > (run-hooks 'temp-buffer-window-show-hook) > (when (and (not no-resize) temp-buffer-resize-mode) > (resize-temp-buffer-window window))) > ;; Return the window. > window)))) > > Maybe Juri can make heads or tails of this. Are these changes intended to completely remove these lines from 'display-buffer-in-direction' and 'display-buffer--maybe-at-bottom'? `(,(if temp-buffer-resize-mode '(window-height . resize-temp-buffer-window) '(window-height . fit-window-to-buffer)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t)))) I expected that only 1 line should be removed to change this to: `(,(when temp-buffer-resize-mode '(window-height . resize-temp-buffer-window)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t)))) But if all lines should be removed, then how to use it? I tried with your patch, but this doesn't resize the window: (setq temp-buffer-resize-mode t) (display-buffer (current-buffer) '((display-buffer-in-direction) . ((direction . top)))) From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2023 05:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: rudalics@gmx.at, 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168395578230074 (code B ref 63455); Sat, 13 May 2023 05:30:02 +0000 Received: (at 63455) by debbugs.gnu.org; 13 May 2023 05:29:42 +0000 Received: from localhost ([127.0.0.1]:35335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxhp8-0007p0-8U for submit@debbugs.gnu.org; Sat, 13 May 2023 01:29:42 -0400 Received: from mout.web.de ([212.227.17.12]:49805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxhp6-0007on-2q for 63455@debbugs.gnu.org; Sat, 13 May 2023 01:29:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1683955773; i=michael_heerdegen@web.de; bh=SsTgtPTmuXQxQwYfX2YCY3sPFlH9Rd/Bo9ctLpqsCW0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Fmp3smTCxz1v/V21AT+rZOeZRPKTCQ/8CRKWGu190ZMDPvT6g7BacNOG7nrppT1Y4 BykgZw9c916/rjEtozb+x/JFtx+bVL+VCUzWyaBvVP4g5lXsqpJQtRmER6NwHbUHSU vyGwgTzvINyDm0zewbA/l4HQebBeBSWGqYZqoue04rFYePanKraIQzfnAswWvNBqzK vxx+YH0DwGjs1nKg37GPMdSciImFuBq996l/z34KzZwa2qdwq5mo8bUNonl7B51Pt5 ogORIwEeGIDHFjlc0wCT9MlM1nOhjIQYYfpQrVpfyudH4Hc+GVoMlkJhNEjFT/HiaG O/xuD5jV03jzA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MUUAM-1powOb1sVE-00QV43; Sat, 13 May 2023 07:29:33 +0200 From: Michael Heerdegen In-Reply-To: <86v8gxmq57.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 12 May 2023 20:11:00 +0300") References: <87fs82z7cw.fsf@web.de> <86v8gxmq57.fsf@mail.linkov.net> Date: Sat, 13 May 2023 07:29:32 +0200 Message-ID: <877ctc2403.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:lAdE2wH59E4r5THOrA+nC6FUl8axMhuOqfDg1RwvP7SorVqNsA0 P7+ufS+sTiLO0HuAvHQ67c0C9Jq3ITh3nImVH3QblMETu4dpC/DoAKiTiP2vUnUmTzc7ymL pEKZ/NXWJYVZlNF9dAmIlYfxJs9n2RJUJQazLqQFDTURrZJBiJTVG5Kg+q+dDOjEOLcmGzh HQGh0mGFEEbr7oTx7i9JA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:LlQPxQhOH1k=;B3VPzGoeUAAffEwW6Usm+W6BEtc xESkv8zi8V+bxHFj/2RwqRUhsAkLXQz23z7qj0xSQp0AgZ+ef7HWgXGfY0h6Jwkok+JSGutvJ wP+SYJW1t28uLljqW8KDf5PYenj+fa2vsT8dXwSIOqPvhIb+q2FrpuPY2AHI2gG+O0s2feUY7 gWT5aLdhoXvddrRZJpMfCID/zTDEYwTrJN2AuTt7eRn6P1SejHfC+xU1LVucKXGLps57UQwn9 1nRhj7etiP8nFCqEx97kDsQk2H0XRt8P5j9t7uOwSaPkgbSLMGTm0sWChkQ90TIo+711ozUbm tK2eSVlvJUvCYx4y8D7S/RAXZUyrYVb012V+Wh1t4js3NouFDuZr5fAUJ0VFs9nj5fsjRH1s7 R9Kl9kFt84c/XdMrjgYlohqgB0gKPQuxUJsWs5zKjxLvji5kkBYI8vi2cReJykROTyyYf+m1P cp7kd7tHxSAofyJW+KG2Qnx45cRT75CM1Quo+X0M5EPbzqY1NpDGly80oLNRVDAe8zJY2Cq8g tybY7yjsFZhUC41jrtEeRyBzG2a15kzhLIAGC/yt/iqrNF95oH/BfDy5z2vDc1X83wYwr/CfC Gyt9AOWWZzsFEu/mFX9/REXZf0Exd+eCM8X1r0vAkdIpqOnPvW8b7iBux9AudUTIs/zHaOW99 Zc8jam+I+wJIpG76O7KC5tO13OCK1RtF8SUOozByjN8KBsqxPnfO0dVKtO9Qk7yklfgDwUxrx XWJR5kgE7r0szzqffTn533b0vQsRmGZraYF8zs7jviNyQbov9zAAbCMY4EyhC8sgR13iuKYep ttO1vcGDAtX+Jt/UwYNuf6hSw5WzNskHn5qV0hzaeaC/OAs0HsOzzcV/pbUelQU8nmmKsWfjU kadw+0ysG+LzsAR5YVE/COZ6GmBDaPt/GKqvKMDuGulQ1i30565DXIRh4mRrPW/o5lDp1ptOs T807Iw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Indeed, an unusual default. Is it possible to change this default now > given there is code that might rely on it already? I don't know, but the alternative is to live with a confusingly inconsistent behavior. Code relying on that behavior relies on something undocumented. The only other alternative I see is to provide the documented behavior under a new name. We could in addition rename the current defun to something containing "--temp" and keep the old name as an obsolete alias. Michael. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2023 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168396819321198 (code B ref 63455); Sat, 13 May 2023 08:57:02 +0000 Received: (at 63455) by debbugs.gnu.org; 13 May 2023 08:56:33 +0000 Received: from localhost ([127.0.0.1]:35870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxl3I-0005Vq-KA for submit@debbugs.gnu.org; Sat, 13 May 2023 04:56:33 -0400 Received: from mout.gmx.net ([212.227.17.22]:59527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxl3G-0005Vd-D1 for 63455@debbugs.gnu.org; Sat, 13 May 2023 04:56:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1683968183; i=rudalics@gmx.at; bh=hOUxWJpQp69SA9Ax7pZgwRIX/fwategTwVzzd54+goA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=FnV1hveDOsKyiaLr211eTIfHBn75wi30+XUx5Tftar8kdiQ6zmb4PChqc3gk1jTp+ qWGzizEfD/tddBhtN34Vt5phnphAyXUNHnGk7l3Spv5RX9690KXFELRxTmI9t5sHbi Tf4Sa8QRRXvwRSxH5k62N5FR3/9wELWb+BjVzJSrLmN/6/lL/p2v545/geY6l+Mx/a 4z+zXOfJN4JD40zXxrrITyaFG9Hb8m4cVLiT3U1AXGN8M+pAW9vgGaixnl/6NM5VKc TbKv/ZG38iD9Z49KYFMFipye6Se1uOepV5M6/bJ+EWhvDomDH5zHmCIjAjjw0ziS2Y ws/5pDQPnwd/Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([212.95.5.250]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4b1y-1pw79d0Iuk-001hNM; Sat, 13 May 2023 10:56:23 +0200 Message-ID: <8f609c16-2302-2dca-0c5a-b740da6e1686@gmx.at> Date: Sat, 13 May 2023 10:56:16 +0200 MIME-Version: 1.0 Content-Language: en-US References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86zg69lb6v.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86zg69lb6v.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:uJZklcEmln6O+q3UEgOOkyHcKyP8puJ0AZTWwlDYPnfUF9m9z5W bvKLDsgISzT1DkZVnBkoOF2t08V9IxPwzPJoA4Tqr8ukNK+AgtMADABf2CLiMLD988A6r2d cyCFhNP2HH/e0Bx4tnlcPCoLPynNptC1n6E6b6qyBKOUAXYOs8gQwbUyXL9MXX/wLDpfIwK MBb5WQeyXj4StsXsZTVmA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:RdeTeHEGieo=;YDWZN9rYbxCHCAsC9Z36m2ngNqY n2XeCR4HmPRJULPhuD6lfLcINyTdeV4b3ChgZi0vITlzBOWWGjqL3iG6H1ogDd43JqLhiD9El sVEhg+KPIuPcjEU3EVyNw9Kltr+WFsavbEm24FJO3QsPMVbNHpqPgtcAB8GHjH+44PObkQvIN VkOgJGQix9PRyv04kluvk8vmUGlJLSB3ofwj1/q7BQmdpsGKR/FPmF0xXIytktftyJmt5t4ub +XFVph1QIWwLMb8qnC/DL+g/xCq2C1BPm80gC8Y/WXuE8GJFXU4UVI4s8/wbveHSCI62NiJEz MXlGRUawDoYYXYjKdzgKAHznb4s7iDqRqxgoXUFp54G8ZfgVtoY1cpaTXgmIsCXl9jiUpTdO0 dSqHYC0YglZhjPVM2HZZUCvqOz/vC2J2dNPD2rdED3YQkn+G9ucRiu7dcIPOKU1s90SEyb8r8 3kpWpVbox0ViimwJoeWk6+9GTgGTRr8vSydHrtRQVFkjalr7Fly40bpQo2w/7U5ulnvqhy7j6 5qrf+7JcGmvMKIBUlja0PRMwVbmfePmywfpNs7ogHRY4uGCucHWm9P+mG/442N56rk3Crn8TB u88bsdTEQsKoozZaHVF8Ofp4yyl5mh0iYF3YA2i6GLImnGqRWtlfTSxsHvQIABWZ+eG/1Um2m zQTo5UnDUh5jTZbXMZHnogI1t9ShIR3+6M/Q5HuXbMxJZ4/sfaPK0zP+U8477wY2yhm/fAgC2 Rd+IgBIWVX+e+QtGVUOX/vrWdPzY/DM1uYEuSNdBcI33HtMz3YMU8ldQDttGqpdB8OwERw5qv 3o0QBrbDnrT1LTFJqjBcBrsDbkzVHkHQPcXgGosejbI7eP7+5u7DNdrtiqPfBh76iCksNBkoQ i9292bO/3wlY6u6BTbvnhHNVmADM7obzNg+ycU3tG2KGpyUOC17JvYWi76v/5KDKlVSZ8dn1X GRjjQg== X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > There are 3 uses of 'display-buffer--maybe-at-bottom' in the Emacs > source tree: 'project-kill-buffers' and 'save-buffers-kill-emacs' > override the default. But 'hack-local-variables-confirm' > d [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.250 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.22 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.22 listed in wl.mailspike.net] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > There are 3 uses of 'display-buffer--maybe-at-bottom' in the Emacs > source tree: 'project-kill-buffers' and 'save-buffers-kill-emacs' > override the default. But 'hack-local-variables-confirm' > d [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.22 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.250 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.22 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > There are 3 uses of 'display-buffer--maybe-at-bottom' in the Emacs > source tree: 'project-kill-buffers' and 'save-buffers-kill-emacs' > override the default. But 'hack-local-variables-confirm' > depends on the current default value. In 'hack-local-variables-confirm' I'm using (pop-to-buffer buf '(display-buffer--maybe-at-bottom (window-height . (fit-window-to-buffer)))) > Are these changes intended to completely remove these lines from > 'display-buffer-in-direction' and 'display-buffer--maybe-at-bottom'? > > `(,(if temp-buffer-resize-mode > '(window-height . resize-temp-buffer-window) > '(window-height . fit-window-to-buffer)) > ,(when temp-buffer-resize-mode > '(preserve-size . (nil . t)))) Yes. > I expected that only 1 line should be removed to change this to: > > `(,(when temp-buffer-resize-mode > '(window-height . resize-temp-buffer-window)) > ,(when temp-buffer-resize-mode > '(preserve-size . (nil . t)))) That wouldn't help. Try with (defun display-buffer--maybe-at-bottom (buffer alist) (let ((alist (append alist `(,(when temp-buffer-resize-mode '(window-height . resize-temp-buffer-window)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t))))))) (or (display-buffer--maybe-same-window buffer alist) (display-buffer-reuse-window buffer alist) (display-buffer--maybe-pop-up-frame buffer alist) (display-buffer-at-bottom buffer alist)))) (setq temp-buffer-resize-mode t) (pop-to-buffer (get-buffer-create "*foo*") '(display-buffer--maybe-at-bottom)) 'temp-buffer-resize-mode' is a global variable. Once a user customized it to t, _any_ buffer that passes through one of these functions will be resized, regardless of whether it is a temporary buffer or an "ordinary" one. > But if all lines should be removed, then how to use it? > I tried with your patch, but this doesn't resize the window: > > (setq temp-buffer-resize-mode t) > (display-buffer (current-buffer) > '((display-buffer-in-direction) . ((direction . top)))) Right. You can use, for example, (setq temp-buffer-resize-mode t) (temp-buffer-window-show (current-buffer) '((display-buffer-in-direction) . ((direction . top)))) which obviously makes the current buffer temporary with all its consequences. But 'temp-buffer-resize-mode' _is_ about temporary buffers. Note that when 'temp-buffer-resize-mode' is set, the way Emacs handles this currently is wrong for _two_ reasons: - When 'display-buffer' calls one of these functions it will resize the window regardless of whether it should be resized or not - that's the subject of the present bug. - When the user customizes 'display-buffer-alist' to call another display action, say 'display-buffer-below-selected', the window will not be resized. Try without and with the first form evaluated: (setq display-buffer-alist '(("*foo*" display-buffer-below-selected))) (pop-to-buffer (get-buffer-create "*foo*") '(display-buffer--maybe-at-bottom)) We could add a buffer-local variable say 'temporary' which the temporary buffer functions would set and 'display-buffer' would always obey in conjunction with 'temp-buffer-resize-mode'. Then a program or the user could set or reset that variable to obtain the desired behavior with plain 'display-buffer' calls as well. Whether such an option is clean is another question. martin From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168417033722683 (code B ref 63455); Mon, 15 May 2023 17:06:02 +0000 Received: (at 63455) by debbugs.gnu.org; 15 May 2023 17:05:37 +0000 Received: from localhost ([127.0.0.1]:44257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pybdh-0005tn-EA for submit@debbugs.gnu.org; Mon, 15 May 2023 13:05:37 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pybdf-0005tF-Ft for 63455@debbugs.gnu.org; Mon, 15 May 2023 13:05:36 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A300F60006; Mon, 15 May 2023 17:05:27 +0000 (UTC) From: Juri Linkov In-Reply-To: <8f609c16-2302-2dca-0c5a-b740da6e1686@gmx.at> (martin rudalics's message of "Sat, 13 May 2023 10:56:16 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86zg69lb6v.fsf@mail.linkov.net> <8f609c16-2302-2dca-0c5a-b740da6e1686@gmx.at> Date: Mon, 15 May 2023 20:01:49 +0300 Message-ID: <86ttwdjzpe.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > - When the user customizes 'display-buffer-alist' to call another > display action, say 'display-buffer-below-selected', the window will > not be resized. Try without and with the first form evaluated: > > (setq display-buffer-alist > '(("*foo*" display-buffer-below-selected))) > > (pop-to-buffer (get-buffer-create "*foo*") > '(display-buffer--maybe-at-bottom)) I tried with your patch, and it works correctly. I guess this change is for master, not the release branch? > We could add a buffer-local variable say 'temporary' which the temporary > buffer functions would set and 'display-buffer' would always obey in > conjunction with 'temp-buffer-resize-mode'. Then a program or the user > could set or reset that variable to obtain the desired behavior with > plain 'display-buffer' calls as well. Whether such an option is clean > is another question. Maybe temporary buffers should resize windows by default? Then such an option should be able to override the default behavior. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: rudalics@gmx.at, 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168417034222699 (code B ref 63455); Mon, 15 May 2023 17:06:02 +0000 Received: (at 63455) by debbugs.gnu.org; 15 May 2023 17:05:42 +0000 Received: from localhost ([127.0.0.1]:44260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pybdl-0005u3-NU for submit@debbugs.gnu.org; Mon, 15 May 2023 13:05:41 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:40485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pybdk-0005tX-9U for 63455@debbugs.gnu.org; Mon, 15 May 2023 13:05:40 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3AECF20007; Mon, 15 May 2023 17:05:31 +0000 (UTC) From: Juri Linkov In-Reply-To: <877ctc2403.fsf@web.de> (Michael Heerdegen's message of "Sat, 13 May 2023 07:29:32 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <86v8gxmq57.fsf@mail.linkov.net> <877ctc2403.fsf@web.de> Date: Mon, 15 May 2023 20:02:46 +0300 Message-ID: <86jzx9jznt.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Indeed, an unusual default. Is it possible to change this default now >> given there is code that might rely on it already? > > I don't know, but the alternative is to live with a confusingly > inconsistent behavior. Code relying on that behavior relies on > something undocumented. Agreed that better to make this consistent. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: michael_heerdegen@web.de, rudalics@gmx.at, 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16841748827782 (code B ref 63455); Mon, 15 May 2023 18:22:01 +0000 Received: (at 63455) by debbugs.gnu.org; 15 May 2023 18:21:22 +0000 Received: from localhost ([127.0.0.1]:44353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pycoz-00021S-LU for submit@debbugs.gnu.org; Mon, 15 May 2023 14:21:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pycox-00021C-Ga for 63455@debbugs.gnu.org; Mon, 15 May 2023 14:21:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pycor-0000gW-ME; Mon, 15 May 2023 14:21:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z9Y2/FOpYdlF50Lb947IAYdYFCOwgPsHjFirB43/QZE=; b=P4Wf5JvCu3kx eZb7Df4KMOtsGmVZF9p4Q45AH8roulJjkXXDrL0v6MsrYw3IENHN2ZLlH/zyHh41OHrPXbpJ4rc/N 7QopK/QtTjHOAKhyCc2FEkACgDGcjzYzvuGM8EC+rlsGNqLVm94sY99tiuWLdwPavUCM9tLJh8YTZ CmZ/MY1qKbKPtCAhVfO8r8Glc9YYupaNIXK5/9ZPb93wZ1pynVUAMqc1Dz6IevsVghYmTgW6J554p zIiRU4JxYQGdK+hYoCCTCPr+2YECriRKA2+gRdXVeof43WjnvdiAo6opUQlcQtd07ui+Hgmko5Lhl N+Hh7qrJCpdC8IF5jRE7sg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pycoj-0002BJ-4w; Mon, 15 May 2023 14:21:08 -0400 Date: Mon, 15 May 2023 21:21:10 +0300 Message-Id: <838rdp1mnd.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86ttwdjzpe.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 15 May 2023 20:01:49 +0300) References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86zg69lb6v.fsf@mail.linkov.net> <8f609c16-2302-2dca-0c5a-b740da6e1686@gmx.at> <86ttwdjzpe.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Michael Heerdegen , 63455@debbugs.gnu.org, > dgutov@yandex.ru > From: Juri Linkov > Date: Mon, 15 May 2023 20:01:49 +0300 > > > - When the user customizes 'display-buffer-alist' to call another > > display action, say 'display-buffer-below-selected', the window will > > not be resized. Try without and with the first form evaluated: > > > > (setq display-buffer-alist > > '(("*foo*" display-buffer-below-selected))) > > > > (pop-to-buffer (get-buffer-create "*foo*") > > '(display-buffer--maybe-at-bottom)) > > I tried with your patch, and it works correctly. I guess > this change is for master, not the release branch? The release branch should now accept only very simple and safe fixes or very urgent ones for grave problems. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 07:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168422158130520 (code B ref 63455); Tue, 16 May 2023 07:20:02 +0000 Received: (at 63455) by debbugs.gnu.org; 16 May 2023 07:19:41 +0000 Received: from localhost ([127.0.0.1]:45053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyoyC-0007wC-Ls for submit@debbugs.gnu.org; Tue, 16 May 2023 03:19:40 -0400 Received: from mout.gmx.net ([212.227.17.20]:43971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyoy8-0007vw-MB for 63455@debbugs.gnu.org; Tue, 16 May 2023 03:19:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684221570; i=rudalics@gmx.at; bh=iiOOlPSuCqKyZ3VonxIV3sBCidhkhAeete3yzHcFU0w=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=PGtcF77StAGa6S+BA6TEz12oAdbej0WX5VYdE1omft6EAmZ+bfCmYWqs5IjXGL+56 3DXuufjYBXjTSBAm66A7H1abyFsk6Ipj3TVZhPHg8n2muKtF+eZhEITmQv747/pHEx MiBQVBRG+HIhuW6MF9CHJ7FldXJDq/2/ArWRop0DoiX8o/IdDOSHOBZC+ss3htYMn3 st5O2luwyRERVzBkZW4Kw8Ghs9oKtSEMERNachfJmoUIMI+li/AUPGtBV2jvbvqnGz HwhzLyh5xVOFjlwflQbPVXvyTzlihSmX5hAVUxeMaGoyiyGmNMAQ3qOaHqYg+4/BR0 hWMcwQGyEKO6w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.96.152]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQe5u-1pmFfQ0a3C-00NkTj; Tue, 16 May 2023 09:19:30 +0200 Message-ID: <19e3fde1-f2d1-2383-8433-1e63bf5d57a7@gmx.at> Date: Tue, 16 May 2023 09:19:28 +0200 MIME-Version: 1.0 Content-Language: en-US References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86zg69lb6v.fsf@mail.linkov.net> <8f609c16-2302-2dca-0c5a-b740da6e1686@gmx.at> <86ttwdjzpe.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86ttwdjzpe.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:PIBi9csuwj77bEhM3RcAsX9WT0J77fgliBO2mIX3FrUAJzZQ2IG Z9ATLNlVDzCGr5yuExu+IBCjrRCa6r73i1bBaX1GbEx7UvaY4faCQxLhDlO8HZRGQYXp4nw 2Wst6icSdCBeqnXTCgSLCFWgPkVXUJVOiq273QLqeVnwOqEyJZhaZEVBU/Wnc5Gn+u7Dro5 QvSDkArkn+szLHG1Pv+uw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qN3Y7451fGU=;5vRslOxWZiMGkucWfOW+OaFQfdr TLe5EG+d19Yhp7uSy7h2kIBtAjwzCBzpQzzLGcUTB/Xr393LAA3x2c3/gsJR0cYXjXvuKSjHe FEIA8x+wJhYQBcqDNDJ4LWx1tfMUQbT0f/0BpB6ppTNY/B8zGPERIE9MakhiFVOxcis5a1jPz E7v0OIlM7WaCrxG/s5VCA0y3Ci1sHZXSFuRitpcv8lVHiuFVLZddp5NhYOUAN58+0fzJ+Payp QuCCxYhK9pGz6Izy+6xvsQhfwthgLQm2B/VKk5sL5cI4ada7YlSbXk2/Amh3XIQQWrQlB3FC5 HcoSimC//XuaGgt+8Iv0LOWO54jXaAyWYJMJIOCaVKRi0VkvD8SWP5ZQkqaDuDiDT0RK0Wd9k wX1n0LholXoPqMKZX0ObJiVLy0F7L93Re4+/ZYjBQRzeHzG18I2X2ohm8G0VPaaPVJI36MW9G /yLP02FE0ChoNtgsPvV0t35+5UfYzzPUZa2Bk+vNzYbJyQSuaXLlBFKcOrnL9xS2TNpZpiLfW 8HgRj4KvcM1mK5km7MJuR2OsTOAHKJJb9rr6n4va0Y7P1aqEDsrHDTzx/UpD9EVJDIVlfROyV yh4cN27ecfStNlVzGoXtLXP6mOSWHTf6SDhA3bGlcYbqEZhZYIusApHtutBH8cp5DYP2x50yq A5L9o7Ew/0zohoeeOYHs88XLiQtrS8DnD31aS+GolQwt4esij3cJmaSlkzQH9Xn4SAYYJ+O5s Dn78wQNojaBKYmXUhfKBpR4lldYjGKoIq9OQqIS2GJlS5vPgzwjyv/rDmN+/x0EJbJjyZ/gcz Px9NkmUwG0CVwUlCj2jNOdWp4wuGdZoe/hYqkdaVQzKnMWunlrBiCDqIx9rPPhQCJYPB6NEqO /PW1bNOUoRVH6GOWDuWQu3846OoSnaX+vsP7NR4O5WeZeZyYsg7rCkYkD3wxFxF0xeAT6HCq5 L4d52wHIdO1/rBiclkfNbJ8wOGc= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Maybe temporary buffers should resize windows by default? > Then such an option should be able to override the default behavior. We could write a function similar to 'completions--fit-window-to-buffer' (do you know what the &rest _ args there are used for?) like (defun maybe-fit-window-to-buffer (&optional window) "Fit WINDOW to buffer if 'temp-buffer-resize-mode' is on." (when temp-buffer-resize-mode (resize-temp-buffer-window window))) and use that in all occasions where we want to resize a window outside the scope of 'with-temp-buffer-window' when 'temp-buffer-resize-mode' was turned on by the user (leaving alone the behavior of the earlier mentioned 're-builder' etc. which apparently work without complaints). martin From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 16:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168425593127473 (code B ref 63455); Tue, 16 May 2023 16:53:03 +0000 Received: (at 63455) by debbugs.gnu.org; 16 May 2023 16:52:11 +0000 Received: from localhost ([127.0.0.1]:47210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyxuF-000792-Ax for submit@debbugs.gnu.org; Tue, 16 May 2023 12:52:11 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyxuB-00078P-WF for 63455@debbugs.gnu.org; Tue, 16 May 2023 12:52:09 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 86E1B1BF20D; Tue, 16 May 2023 16:51:58 +0000 (UTC) From: Juri Linkov In-Reply-To: <19e3fde1-f2d1-2383-8433-1e63bf5d57a7@gmx.at> (martin rudalics's message of "Tue, 16 May 2023 09:19:28 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86zg69lb6v.fsf@mail.linkov.net> <8f609c16-2302-2dca-0c5a-b740da6e1686@gmx.at> <86ttwdjzpe.fsf@mail.linkov.net> <19e3fde1-f2d1-2383-8433-1e63bf5d57a7@gmx.at> Date: Tue, 16 May 2023 19:35:59 +0300 Message-ID: <864joc4l80.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > We could write a function similar to 'completions--fit-window-to-buffer' > (do you know what the &rest _ args there are used for?) like Looks like the &rest _ args is defensive programming. > (defun maybe-fit-window-to-buffer (&optional window) > "Fit WINDOW to buffer if 'temp-buffer-resize-mode' is on." > (when temp-buffer-resize-mode > (resize-temp-buffer-window window))) > > and use that in all occasions where we want to resize a window outside > the scope of 'with-temp-buffer-window' when 'temp-buffer-resize-mode' > was turned on by the user (leaving alone the behavior of the earlier > mentioned 're-builder' etc. which apparently work without complaints). This helper could be useful. Maybe it should be added when such need arises. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 17:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16843440019365 (code B ref 63455); Wed, 17 May 2023 17:20:04 +0000 Received: (at 63455) by debbugs.gnu.org; 17 May 2023 17:20:01 +0000 Received: from localhost ([127.0.0.1]:50875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoi-0002Qz-Dl for submit@debbugs.gnu.org; Wed, 17 May 2023 13:20:00 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:58411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoh-0002QP-89 for 63455@debbugs.gnu.org; Wed, 17 May 2023 13:19:59 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 54BF520003; Wed, 17 May 2023 17:19:50 +0000 (UTC) From: Juri Linkov In-Reply-To: <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> (martin rudalics's message of "Fri, 12 May 2023 09:39:40 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> Date: Wed, 17 May 2023 19:56:56 +0300 Message-ID: <86jzx6lvxz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > 'temp-buffer-window-show' has a third argument NO-RESIZE and its last > lines are rewritten as > > (with-selected-window window > (run-hooks 'temp-buffer-window-show-hook) > (when (and (not no-resize) temp-buffer-resize-mode) > (resize-temp-buffer-window window))) > ;; Return the window. > window)))) > > Maybe Juri can make heads or tails of this. Does your complete patch look like this? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=bug_63455.patch diff --git a/lisp/files.el b/lisp/files.el index 148f47cbc97..b3962145e79 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -3772,7 +3772,8 @@ hack-local-variables-confirm ;; Display the buffer and read a choice. (save-window-excursion - (pop-to-buffer buf '(display-buffer--maybe-at-bottom)) + (pop-to-buffer buf '(display-buffer--maybe-at-bottom + (window-height . fit-window-to-buffer))) (let* ((exit-chars '(?y ?n ?\s)) (prompt (format "Please type %s%s: " (if offer-save diff --git a/lisp/help.el b/lisp/help.el index 6f55136049b..676c18f2411 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -2175,7 +2175,8 @@ help--window-setup (setq-local help-mode--current-data nil) (buffer-disable-undo) (let ((inhibit-read-only t) - (inhibit-modification-hooks t)) + (inhibit-modification-hooks t) + window) (erase-buffer) (delete-all-overlays) (prog1 @@ -2186,7 +2187,12 @@ help--window-setup (help-make-xrefs (current-buffer)) ;; This must be done after the buffer has been completely ;; generated, since `temp-buffer-resize-mode' may be enabled. - (help-window-setup (temp-buffer-window-show (current-buffer))))))) + (help-window-setup + (setq window (temp-buffer-window-show (current-buffer) nil t))) + (help-make-xrefs (current-buffer)) + (when (and window temp-buffer-resize-mode) + (let (resize-temp-buffer-window-inhibit) + (resize-temp-buffer-window window))))))) ;; Called from C, on encountering `help-char' when reading a char. ;; Don't print to *Help*; that would clobber Help history. diff --git a/lisp/window.el b/lisp/window.el index aa7520f30fa..b816d10298a 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -110,7 +110,7 @@ temp-buffer-window-setup ;; Defined in help.el. (defvar resize-temp-buffer-window-inhibit) -(defun temp-buffer-window-show (buffer &optional action) +(defun temp-buffer-window-show (buffer &optional action no-resize) "Show temporary buffer BUFFER in a window. Return the window showing BUFFER. Pass ACTION as action argument to `display-buffer'." @@ -139,7 +139,7 @@ temp-buffer-window-show (set-window-hscroll window 0) (with-selected-window window (run-hooks 'temp-buffer-window-show-hook) - (when temp-buffer-resize-mode + (when (and (not no-resize) temp-buffer-resize-mode) (resize-temp-buffer-window window))) ;; Return the window. window)))) @@ -8300,14 +8305,6 @@ display-buffer-in-direction (t (setq direction 'below))) - (setq alist - (append alist - `(,(if temp-buffer-resize-mode - '(window-height . resize-temp-buffer-window) - '(window-height . fit-window-to-buffer)) - ,(when temp-buffer-resize-mode - '(preserve-size . (nil . t)))))) - (setq windows (windows-sharing-edge window direction within)) (dolist (other windows) (cond @@ -8384,15 +8381,10 @@ display-buffer-below-selected (window--display-buffer buffer window 'reuse alist))))) (defun display-buffer--maybe-at-bottom (buffer alist) - (let ((alist (append alist `(,(if temp-buffer-resize-mode - '(window-height . resize-temp-buffer-window) - '(window-height . fit-window-to-buffer)) - ,(when temp-buffer-resize-mode - '(preserve-size . (nil . t))))))) - (or (display-buffer--maybe-same-window buffer alist) + (or (display-buffer--maybe-same-window buffer alist) (display-buffer-reuse-window buffer alist) (display-buffer--maybe-pop-up-frame buffer alist) - (display-buffer-at-bottom buffer alist)))) + (display-buffer-at-bottom buffer alist))) ;; This should be rewritten as ;; (display-buffer-in-direction buffer (cons '(direction . bottom) alist)) diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el index eb903f093f9..c6ce1b78e52 100644 --- a/lisp/vc/ediff-wind.el +++ b/lisp/vc/ediff-wind.el @@ -433,7 +433,8 @@ ediff-setup-windows-plain-compare (select-window (display-buffer-in-direction control-buffer - '((direction . bottom)))) + '((direction . bottom) + (window-height . fit-window-to-buffer)))) (ediff-setup-control-buffer control-buffer) )) --=-=-=-- From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16843985968771 (code B ref 63455); Thu, 18 May 2023 08:30:02 +0000 Received: (at 63455) by debbugs.gnu.org; 18 May 2023 08:29:56 +0000 Received: from localhost ([127.0.0.1]:51939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzZ1I-0002HO-4O for submit@debbugs.gnu.org; Thu, 18 May 2023 04:29:56 -0400 Received: from mout.gmx.net ([212.227.17.22]:53849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzZ1G-0002Gz-1M for 63455@debbugs.gnu.org; Thu, 18 May 2023 04:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684398587; i=rudalics@gmx.at; bh=t97EN0oudwTitW8iZ+A/tz2sAvyz7ZUGicaKrmK8vvE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=mp5c+SbvOckfDYn3NM+3xrpv7x+ZIngZGXc12UVQOElLvwyl5M4k9bRI8JmMFXO6s cFvsP1sNX/v177O3pHQ62nL1tQR96hj5nJzp+87djfIK6r0D/C62j4c/4I2wfBTgu9 T5jj3x2oT6wR5X3ycGi7zBqnyvF0O/EXqaiLdJ4V2pUnhATENLzo7wglXhStCRM7y2 bx6WR7N5tQyQ//hE0FL4cR1qV0WUqNPgQYrqKnprTdtdRrjST6Z+YY0ZbKWJ5ocOcK VHbZwQi6oblqGdoLlXwxwSeC944PL5vIiDOK2QwbnilSdIU6MNQljM8cPYyAcMnxFj r95yZpGLaweow== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.161]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgvvJ-1qdsRS1inN-00hL3G; Thu, 18 May 2023 10:29:47 +0200 Message-ID: Date: Thu, 18 May 2023 10:29:46 +0200 MIME-Version: 1.0 Content-Language: en-US References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86jzx6lvxz.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:3rKtWR8Rwez96ih7Ry1Tgwjv5yWM8olH/0+IyMxFi5t956xiSwV CJEgs4sNCkhS2kl2Cgg5LqRYGSjB15N/Y+j7XE6BIqMm9doRUtGrsmwYyDK+TA7IkDSfoW6 /Ny+dlPrHMkrEpoB98JL+ujQoEZBLuYV2yoHQEgtgReqPtJ+TkFwpLg2ip+AjE2Us9LQqeE TPVjcd/Mv9LSJcR0Yfyrw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:aT2lEddS9lo=;lPip5gGrmR91sWiWI6bEFBcY0eJ gCRsqoz1J05wvraUSyEXYBZAz7JvsDDhE2Cl0ZrZ2inAK5xKwE2mt0WBX5EIlcnfyzaC2Twze K11vljFuFv/MjY+bZe56GZHW+K/72ykNRqAHtsRhYs5jbnO/8snu37+AqttxE/rTsll4VQlUm sTeuUkcZzU1+zoMV77aduA0P1GyS8MrlvllTJtrzVtRfssugiqkUILx4oa/P/hw++gstvE6ft Q95N0mudzbcEti/jMkSD4Bjkok1Uvv/JZsuJinLbpizHeIWI3bjIVAzmLqXkodAucbizEQ4Nb xbEagNjLy3T/fkcaRGTeTawgNKcdarTgOeYSEjjItrh5B6+Aob5O7fL5oqGOHvlNtHKxpGkLs PYYXROAHG9uZaQI79y38gSFrxbyKFO/+hfdRmv0UIExbThiM80YtWZv9BFM8qVbnt37dP5/Lu vtRs1Tnt7gPJF0SLrKlZy9LqbxoGi+kML0P2NsKurpKnTjdrlSKM26o4FqY6WKxMtHwanuidn K6rbkJKqDqs8UetESfE/Zx/HVFREVoGxL8uz2bJxOFbgvODb6o8kp1kcL0E+6f9dEaJl/Cq8u z5jcnXbL6VQ1BRAJKW8zqMLNt5/M+wfa/0EDgb1NmuIf1sGx4SP29j8mexipKwWOacQG5jFq/ UtlosUIEkSH9GSUjRqmIXG9wHn2ZrEJZ7YEKCR0Jq3pPUFm5NyKfYSbUpz/3kOAZdvDsWlLAq YzdNwXfVe5KN7hnjMOT+9Lhbasy5a2mTPMohKIub6wx4jc5Bpd9Bz270m7X+foCNz3FekTFC2 /DZHNBkJUYFGPCRKY8nX2vHLd4+E1JCpqURAu9g7DAED2w3bKDahTE1GtvEWyFUXesu01CvTp 7XaiDr+Q63DFXre6OuEVQ+Ry/rZ1DK8B5jsg4iiA3HwuQpU/QErZrxEER2oyndVOBv5J+7B9W kalpcA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Does your complete patch look like this? Almost (I had to make 'ediff-setup-windows-plain-compare' do what your patch does). But as I mentioned earlier, you might want to replace 'fit-window-to-buffer' with something conditioned on whether the user has customized 'temp-buffer-resize-mode' - some users simply might not want their windows to auto-resize. martin From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 16:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168442569227202 (code B ref 63455); Thu, 18 May 2023 16:02:03 +0000 Received: (at 63455) by debbugs.gnu.org; 18 May 2023 16:01:32 +0000 Received: from localhost ([127.0.0.1]:54258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzg4J-00074g-RI for submit@debbugs.gnu.org; Thu, 18 May 2023 12:01:32 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:47369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzg4F-00073x-5v for 63455@debbugs.gnu.org; Thu, 18 May 2023 12:01:27 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id ADB8020002; Thu, 18 May 2023 16:01:19 +0000 (UTC) From: Juri Linkov In-Reply-To: (martin rudalics's message of "Thu, 18 May 2023 10:29:46 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> Date: Thu, 18 May 2023 18:54:52 +0300 Message-ID: <86v8gp1voz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Does your complete patch look like this? > > Almost (I had to make 'ediff-setup-windows-plain-compare' do what your > patch does). But as I mentioned earlier, you might want to replace > 'fit-window-to-buffer' with something conditioned on whether the user > has customized 'temp-buffer-resize-mode' - some users simply might not > want their windows to auto-resize. This function should be added instead of your changes in help--window-setup and temp-buffer-window-show? From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168448147717866 (code B ref 63455); Fri, 19 May 2023 07:32:02 +0000 Received: (at 63455) by debbugs.gnu.org; 19 May 2023 07:31:17 +0000 Received: from localhost ([127.0.0.1]:55312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzua5-0004e6-Gs for submit@debbugs.gnu.org; Fri, 19 May 2023 03:31:17 -0400 Received: from mout.gmx.net ([212.227.17.22]:44037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzua1-0004do-92 for 63455@debbugs.gnu.org; Fri, 19 May 2023 03:31:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684481466; i=rudalics@gmx.at; bh=g3vDJZf4rHOAUriNXBboQ2I1q7mIxykcg5uE/RTKKdY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=c4b6fFX3LS6ZyV7cuKgCSmWfSFc6Q8QevVD65cV7BepMktK2BvDKIroiWqZ4X+eKB dCx1CNE0U7Lt8SX213XFc670CRX8WhHGXX+Y6i4HRSH3yP/KmjHdtHNEUVOQpJGtvN Jz3s+Pk0xke6WxhBQJg/fM9xyfbjQFMnVEMx1c4OdEGdRsia2X01pol3jWU5lnpUg+ sHopbyVEZA/012NnZ3N8YvJ3Uw6ubfuxcn8AkJbxL4pBE2a8RKMcGuSNCm1NiUk7CM JRidxMyUHL29tYrec4IeTZujr8z3JDsN9/0G/S87K5+DKZRqA8N+vP+Zby5Wz9hjKL piRQOlKePUfjw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([46.125.249.114]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mr9G2-1qTB2i2tao-00oDOE; Fri, 19 May 2023 09:31:06 +0200 Message-ID: <334ee702-f627-ce8b-ccb2-d0b7c4251c3f@gmx.at> Date: Fri, 19 May 2023 09:31:05 +0200 MIME-Version: 1.0 Content-Language: en-US References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> <86v8gp1voz.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86v8gp1voz.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:cia6xUCiFFBJgAHfczTYJncNoObXyoSlbowWMrm9zQt0r8sNL20 23kuBrP0xPM1C0/HH2IHtEvjKzQaRuYiEh2x0GPf/+vYrFwquI05eHWj/Jc9p5zVwWvFmTN f+q/dNU6GXCw6GE1NBqTpuKc1c5urBGJZMtWHUrhUFBd174qzFRMltRgt50bXAs/bffbjEV KL1zVQ98+xIo97sYpr7LA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:C4frb94FiTg=;AvsKwe9AzfWSv9CiXgDI9x/ufFC 9AJhlO6s+KlfbmYmnoVWk7B3xV1A57N5R3D0clQnVfeoxUxO8r7te/15Zi0zeMw8gjSJPB0oQ pP3dQIUn5CqH4aRDSU+fPOxS5dqa7RIKiyBrHdYfKbGtTfX3Kf3TKy7KBIovCY3HMgcvUhgBd UtCIn/1c0XHp1WTNoyWk6qAodj60Z0CMISM0/7k5x9tvKdIqoFwwL3TAO3fJZ82H7xQfJA4/y YDolvIdNHWTofBpnqzmO8/av3MNg7rhcCRXTZcVKEB7fZIqtPcS57wE+tXcS6ChX0u66x13Vv ME9t2aOjMVBx0Obv9ruSZOQ8U1/c8HNaerzluuDhSpofyYnP7OlUt0V38AKZ2wkUtUuEGi9uN gw40ZXCvrJKk+z7qHNJbcpvedR4y7Tucgb8BXqpswrOgxh/G3xw4lRFwguvwy6oFWM8pnsGS6 NX2s6+zyOFk111cy6oHTJcDS25T/roTCEaAVmCxW0dKEKbuXoBAaHssmK+/bK3rfqrFtKgZ/f c2MKKwPDMZIfXPvZSvOKLPhBsx4Srfu35X4TO+jkw5GECB8oHnpBqOh38mtdGvhvooxC6zkBi CohnomHnb9nnwWOt5cxm9tGlrHt5IMp43M7ZHC24LQvtvFmi8kptNcEj9Ff9oV+0jQ9eLuNIm nb31IDnnGIbpcSWx5BZx8AGnW82ZxOcfzqu78ngloB0i3c0vpZITWXP2C11AjIdFbi8aDq23F 5ntWFmH3IsFYlRDjHmP4pvn6nwxpHWoiSQDAEwOjrT8EnSC1ZHtXjvJPk07M1iDjv2Ix+3IzI 6dX0TPpmsKiI+j+JRUavwZxE6AMm2Rr14SV2pARixJXkcjzXt6qbGg//9ecExrzntanvIssb5 tR0lCuVcrVFfrFikiZNyI7IXOBpRLapIOf9LB8KxOUFJ2Xdn2h4aH+BDP7pXPKWG0Im4faWjC wo5ymyWRmtlvTS2rJgBLFRZOJfQ= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > This function should be added instead of your changes in > help--window-setup and temp-buffer-window-show? IIRC 'help--window-setup' wants us to (1) show the window via 'display-buffer' (2) call 'help-make-xrefs' which may change the buffer size and (3) only then fit the window to the buffer, something "this function" cannot accomplish. BTW, this is a special case the NO-RESIZE argument might not handle correctly in the queer case where a user has 'temp-buffer-resize-mode' enabled but does _not_ want to fit help windows to their buffer and added a special rule for *Help* buffers. So conceptually "this function" should be used only in functions like 'hack-local-variables-confirm' where we do something temporary buffer likish without calling 'with-temp-buffer-window' explicitly. martin From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168452020432247 (code B ref 63455); Fri, 19 May 2023 18:17:02 +0000 Received: (at 63455) by debbugs.gnu.org; 19 May 2023 18:16:44 +0000 Received: from localhost ([127.0.0.1]:57367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04eh-0008O3-Nz for submit@debbugs.gnu.org; Fri, 19 May 2023 14:16:43 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04ef-0008Nc-VB for 63455@debbugs.gnu.org; Fri, 19 May 2023 14:16:42 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1C58F1C0004; Fri, 19 May 2023 18:16:33 +0000 (UTC) From: Juri Linkov In-Reply-To: (martin rudalics's message of "Thu, 18 May 2023 10:29:46 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> Date: Fri, 19 May 2023 20:54:09 +0300 Message-ID: <86o7mgb4z2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Does your complete patch look like this? > > Almost (I had to make 'ediff-setup-windows-plain-compare' do what your > patch does). But as I mentioned earlier, you might want to replace > 'fit-window-to-buffer' with something conditioned on whether the user > has customized 'temp-buffer-resize-mode' - some users simply might not > want their windows to auto-resize. I still don't understand the need to add a new function. When users don't want their windows to auto-resize, then they can simply do: (add-to-list 'display-buffer-alist '("*Help*" nil ;; Inhibit resizing Help buffers (window-height . nil))) From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 May 2023 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16845712746524 (code B ref 63455); Sat, 20 May 2023 08:28:02 +0000 Received: (at 63455) by debbugs.gnu.org; 20 May 2023 08:27:54 +0000 Received: from localhost ([127.0.0.1]:57828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0HwQ-0001h9-9V for submit@debbugs.gnu.org; Sat, 20 May 2023 04:27:54 -0400 Received: from mout.gmx.net ([212.227.15.18]:36041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0HwN-0001gv-Mv for 63455@debbugs.gnu.org; Sat, 20 May 2023 04:27:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684571265; i=rudalics@gmx.at; bh=HCRwX6PEuBIwutY+jUwmgLp/RtPkxU8CPr3YAEEsEsM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=YQl36V8zybPweWz9/UoW3p6IugqYKgWY4+G8/CFckFYOiIPc9pmCys0Ah4YFib7I7 ACFlb5bBjs8Bp7EhsQ3Zn3ECQ2D+eft7epPxazq7U4tWkyA/Z8gesXJhS8keqj/5lb v6yzZPL7ipkSy3+cmwLS78RtIjoJvwTaXGUwJDW6XeSBXhS5Gb4m+AiDLu6qaAxLcn m2jKJrJZMW42gPMFv26wcGAmtlRpWYziNPTt6PHsCzfeuzVMLBW5IRep87IVKbOG6m 5BRvJOZJRIeYCoLQqJT721SQu1PCF1qJuWHb4QByChmnuaM717QJ6KowRqG1FWhewd 9zSbONIx+Mo+A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.96.55]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N1fn0-1q6rVY3tsG-011xeM; Sat, 20 May 2023 10:27:45 +0200 Message-ID: Date: Sat, 20 May 2023 10:27:41 +0200 MIME-Version: 1.0 Content-Language: en-US References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> <86o7mgb4z2.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86o7mgb4z2.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:W9ggDbbCe1B6mCussN6xFuC9Y6IVKAlWPkPk715uAZoVwMJuUmH chcjnSFrFVzZlTJ5iYmMLIoFZVn9c3ZNbLbUiH3K52BZDjSF0E/OMiYWgTPRzwpEPmWc8iI WYeYexvnECXJVaAnJH7w8bL30F6Dy0XYtL+sDwoM5s7NGtKwBWuFbIg8kQVczso1q9YCBug LqJTq9if8dxCxUjTgFggQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hG7xg78fjRg=;gDgUtZETaEKSC+FXsPeIIpcXxJ4 IIObfqf6qJk1UvRMXL5UVmvUC0R1Z4Hz2yq0uELnVxSIlnqRirOMWs9D9pd0n5aLy8X/yL/xm A3cS2OJpW5tiqkncbEzLfRAxhHhg3l33toxLLWujdgaX8DawLzO29PkYkP7mESGnlCopTgFvh KYhd7YYwJP9FI3i9JdA4Bxy9hNLMV3dkP2QF/qIUbJOtVS6Q1XLwVto//AeGayfoC6K1Wtvoj UqY6eDtmG+TcJhprJvrYznzfGEm6RnspX/rG+PCkQPfHmc8UfF84VZYH6vimX83EpnPO4YA+u c2u/OCbo3ilX7KZ7ZEOtlP5wPTSah8kn7v/v7oNHUOdoIMv5wwWJYmAQ1ESxz9NDy/59SKB0I 2ZmyNmSITre0G7ZbQD8QdHIwI9BZqmUunR15cRSiYwZrwKi6XDVZqjFkjYXC4zEkV2pU8dCJV DUwpTr373nRN2eU/iNFf2grqbNoUW6l0qL3NpV4JNKNqUO2Y8PqsgWpQTEDzxuvjCfqY52Vd0 8g5ZxCOWAlZo3uM0VC/uFL9Ae7AlVt7NeZln3gQDjpfFbXypjr7C61wehDX7mVhyoY1izv66u a+wpJe5HZ8kodcOgzWSdM4zndjcUHEuSG6ImqkWmd/OiZ+7MxEV7JswfJn5Jg7I8z8T4Sxdno vreWIZWjtiP5Q6bR3jTdW6bsSP5wJWFsJK8jKDhSqic1/1gYQjcPdeT/vPTyimGk+ft4HCDXx ptRPi20D4R6rw1gKpxRahEO//f4nO0hW6Xha/2bEAODRLQcQWUoxZKg/Y8vay6ekhNLZuT0+D En0sdy1UvlZAlJBJNBYXOumJVb77GSKPDZuK08Y1Ci0xZ9m4aRsEz6cf+8RnyQJQzUpyLo6c+ Mm8elUJ5HwwllxShP+Rp1+wRWfis/E77k9SEWAH6t1zDjunOZ0YasGy2BA6VoWbA1yhdCxgna 9HJgiHP5/VbvVi++xC41g29tk3A= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Almost (I had to make 'ediff-setup-windows-plain-compare' do what your >> patch does). But as I mentioned earlier, you might want to replace >> 'fit-window-to-buffer' with something conditioned on whether the user >> has customized 'temp-buffer-resize-mode' - some users simply might not >> want their windows to auto-resize. > > I still don't understand the need to add a new function. The new function would serve, for example, in 'ediff-setup-windows-plain-compare' (select-window (display-buffer-in-direction control-buffer '((direction . bottom) (window-height . fit-window-to-buffer)))) to make sure the window is fit iff 'temp-buffer-resize-mode' is enabled. > When users don't want their windows to auto-resize, > then they can simply do: > > (add-to-list 'display-buffer-alist > '("*Help*" nil > ;; Inhibit resizing Help buffers > (window-height . nil))) A user who has not set 'temp-buffer-resize-mode' does not want auto-resizing to happen and probably does not want to deal with 'display-buffer-alist' either. In either case, the new function is not relevant to your example. That setup doesn't work with 'temp-buffer-resize-mode' turned on because 'help--window-setup' ignores 'display-buffer-alist' when it does (when (and window temp-buffer-resize-mode) (let (resize-temp-buffer-window-inhibit) (resize-temp-buffer-window window))))))) All this has become very contrived because of 'help-make-xrefs'. I suppose we have to (1) make 'temp-buffer-windo-show' return the function 'display-buffer' would have used to resize the window if NO-RESIZE had allowed it to do so and (2) have 'help--window-setup' apply the return value, if non-nil, to resize the window after calling 'help-make-xrefs'. If worse comes to worst, 'help--window-setup' may have to investigate the current value of 'resize-temp-buffer-window-inhibit' too ... martin From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168477923715288 (code B ref 63455); Mon, 22 May 2023 18:14:02 +0000 Received: (at 63455) by debbugs.gnu.org; 22 May 2023 18:13:57 +0000 Received: from localhost ([127.0.0.1]:36339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1A2e-0003yV-UV for submit@debbugs.gnu.org; Mon, 22 May 2023 14:13:57 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1A2b-0003yH-Oq for 63455@debbugs.gnu.org; Mon, 22 May 2023 14:13:55 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6E58C40002; Mon, 22 May 2023 18:13:45 +0000 (UTC) From: Juri Linkov In-Reply-To: (martin rudalics's message of "Sat, 20 May 2023 10:27:41 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> <86o7mgb4z2.fsf@mail.linkov.net> Date: Mon, 22 May 2023 21:03:58 +0300 Message-ID: <86bkicckfl.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Almost (I had to make 'ediff-setup-windows-plain-compare' do what your >>> patch does). But as I mentioned earlier, you might want to replace >>> 'fit-window-to-buffer' with something conditioned on whether the user >>> has customized 'temp-buffer-resize-mode' - some users simply might not >>> want their windows to auto-resize. >> >> I still don't understand the need to add a new function. > > The new function would serve, for example, in > 'ediff-setup-windows-plain-compare' > > (select-window (display-buffer-in-direction > control-buffer > '((direction . bottom) > (window-height . fit-window-to-buffer)))) > > to make sure the window is fit iff 'temp-buffer-resize-mode' is enabled. Maybe a good name for the new function would be 'fit-window-to-temp-buffer'? From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 May 2023 02:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: martin rudalics , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16848090628182 (code B ref 63455); Tue, 23 May 2023 02:32:02 +0000 Received: (at 63455) by debbugs.gnu.org; 23 May 2023 02:31:02 +0000 Received: from localhost ([127.0.0.1]:37504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1Hni-00027j-0n for submit@debbugs.gnu.org; Mon, 22 May 2023 22:31:02 -0400 Received: from mout.web.de ([212.227.17.11]:56017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1Hne-00027H-Ty for 63455@debbugs.gnu.org; Mon, 22 May 2023 22:31:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1684809051; i=michael_heerdegen@web.de; bh=7f8kQJSK3rQOm70O4LxvMoCasJhzp5zDrYQFjlObKVM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=OQvg8ihLgiD2I6i8x9h5q839G0Z9toeuSSxFkBWTv4Hbou5uCIFcRhdGuvB3a/65Q geSHXmNINrkQTiihCKQqDfQ0CAI+DZ5RLjroDnK76VyzUuzuQFevxj4iC9BsX+q2oA jN9OWGK7GHC4RDZKBQNwpTEE/lRYEUAy3DABFZsPdVwrvaxQN3gtoZ6XeLZ6nzlXq5 /VxU0pSAFtDGsqNXDiFXHxXohvMSxw4wGrZpUbBd85tvQQuyjMT2a85ULcr7tzU5FI 1XMwyv3QDJf1JSg0SpqZYpFlsQbyT57GGVJwuZrFRdM5qN8GQwGAiBeujQ7XPH/4qV 1duYCztlX7ELg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MCol0-1psS6t27Ky-008ty1; Tue, 23 May 2023 04:30:51 +0200 From: Michael Heerdegen In-Reply-To: <86bkicckfl.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 22 May 2023 21:03:58 +0300") References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> <86o7mgb4z2.fsf@mail.linkov.net> <86bkicckfl.fsf@mail.linkov.net> Date: Tue, 23 May 2023 04:30:50 +0200 Message-ID: <87ttw34w4l.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:NqiHuzQYS2Qk4zsCA42D50xSi61qg5wLOUn+ZtWj/fEJ0VYxpo5 NgZo+WAJrHyTfs6K/u1mnKMvCCxMjnfQ+LDJnfrtFv4ysSmXdVMGsDK5X7UwHg477t2Bk7o xibNz7L2ngpjub4lksT/S7qwFbhOAZVkNl08fQ4oV6nM3rDNqlf6E1aIlJZjd940r14QRkS u9DeZhcK+s4ZpSuf07nsA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:CSRzlxhQSb8=;6IUyNC/EtB/c1CJS6EFX43gygJo LwOlxYp0snVlMMazFm616Ft+osYu9nJA3uqXWqEzO+wuys4UKWGlCmtoiPQ+ev+FN0HNIucMd a+wX/u+lbmK45wNeNv2HgZPtkUpKTLDz3qIidr7z8AVUKYMBInShsFhq+hUG/+C66bzL7P5NF /24o5HFSWYIxuDv97f4T6tNSLc52CixRc0vZ6bxc+6HdgBtsR14M9sFBmpITLBrdhvZagGXcA J0mi4TXVMdzJO6rMsRSFZNdBWBxL39vW6JT+pWGJKKxcXQ2fTd4fAq5MraDJM8vw2nPjPEoaJ vzozA7NngQdTYr4RQrqzd4vbBFVkLRtqmiuNTc96U1Zc3mgbCht9MrnHAL2hkNDJPHcTXnJj2 WNM3P9JEGkd3zaU4IYbe1SN/kyoFlWf5tTKkhDdp0AW/lslSfAVlalwzhpDYqLZOxM7Kql0Bg Ov22ZWL6Bsj3VvZhzkCq9v4ydV6Jh9MsC9OYjWbOXbDRGKGfgAnk9U6edyly1g5jznXbuAtJK nkdxnKjS/pejok1bSXnsP58USYgFNMZaxGSCMp3XVfJPmSf9wkpwtHDsO7HHaPAOH3EWqUkqg wXgoFy5uF88/7WRggrFM0D7H3qonFTlFxA2EkJ5oigdLiIJPseop2S7Wt1FYzg44KRA940O3R chiQNI6OuC4HDJsMP+ZrpwY2SAhojD6kMaZ5f8Zpjp93qQ6HbfCmv4tfjdSqAbJp4uXxVi4kc JTTurqpXLIvd1VX9nERs/CkbVR9G6jsc8QohzzOys1EUPnG9rdUuZSEjzW7udmEYc/cLAofp1 92LD0ly2JLdl573JojqcJp/B0I5B+hmjkLMBFVOaNn3dUM4LYJq6WKlF1+EBCqn+V0GiwvdZy V4SaNrjjDssvtkHLLDItdNSU9bWyxyq/almPTaL9g250mj5TFmNepnlV5PuAnasMeNjelHkJI hgiSBqBpHOISLaIKLoTsMkCCVF4= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Maybe a good name for the new function would be > 'fit-window-to-temp-buffer'? Sorry to come up with this now, but: I think "temp-buffer" is a misnomer here. AFAIU it is used for *Help* buffers. Those are not more temporary than a lot of other buffers (doesn't the *Help* buffer live more or less the whole session if you don't kill it?), and the way Help buffers are displayed has not much or not only to do with how long they live. I always found that naming confusing. It makes me think of `with-temp-buffer', helper buffers, not of *Help*. Do you find the naming appropriate, having the use cases in mind? Michael. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 May 2023 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: martin rudalics , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168486635324954 (code B ref 63455); Tue, 23 May 2023 18:26:01 +0000 Received: (at 63455) by debbugs.gnu.org; 23 May 2023 18:25:53 +0000 Received: from localhost ([127.0.0.1]:40409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1Whk-0006UQ-PK for submit@debbugs.gnu.org; Tue, 23 May 2023 14:25:52 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1Whj-0006UD-6a for 63455@debbugs.gnu.org; Tue, 23 May 2023 14:25:52 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id BFB9660002; Tue, 23 May 2023 18:25:43 +0000 (UTC) From: Juri Linkov In-Reply-To: <87ttw34w4l.fsf@web.de> (Michael Heerdegen's message of "Tue, 23 May 2023 04:30:50 +0200") Organization: LINKOV.NET References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> <86o7mgb4z2.fsf@mail.linkov.net> <86bkicckfl.fsf@mail.linkov.net> <87ttw34w4l.fsf@web.de> Date: Tue, 23 May 2023 21:25:11 +0300 Message-ID: <867csy6h2w.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Maybe a good name for the new function would be >> 'fit-window-to-temp-buffer'? > > Sorry to come up with this now, but: I think "temp-buffer" is a > misnomer here. AFAIU it is used for *Help* buffers. Those are not > more temporary than a lot of other buffers (doesn't the *Help* buffer > live more or less the whole session if you don't kill it?), and the way > Help buffers are displayed has not much or not only to do with how long > they live. > > I always found that naming confusing. It makes me think of > `with-temp-buffer', helper buffers, not of *Help*. Do you find the > naming appropriate, having the use cases in mind? According to (info "(emacs) Temporary Displays") maybe a better name would be "view-buffer" because it's intended for non-editable buffers. From unknown Sat Jun 14 05:25:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2023 02:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: martin rudalics , 63455@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.168489653214052 (code B ref 63455); Wed, 24 May 2023 02:49:02 +0000 Received: (at 63455) by debbugs.gnu.org; 24 May 2023 02:48:52 +0000 Received: from localhost ([127.0.0.1]:40786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1eYV-0003ea-HB for submit@debbugs.gnu.org; Tue, 23 May 2023 22:48:51 -0400 Received: from mout.web.de ([212.227.15.3]:52219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1eYP-0003eG-4f for 63455@debbugs.gnu.org; Tue, 23 May 2023 22:48:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1684896518; i=michael_heerdegen@web.de; bh=UXHZhQjVyRQKjQpQN0MlKubpKbXOtKE/zyRJ4SBdcZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=DLbl9C3AvGtdbJ4ZelQh/jkCpSvnCkGyucPiVIUt1YtykPr/ytWxbB7TKBxboalxu UVu2yzVT4oUzL/Tc1Cf56jtX7LrZgQXAR8QqAAG8EE/kLhz3q6DmMBm7I1LcXc8t4f vbkJL1ulQmr7qK+hJyEfr7E2sOn9MUWsre5j1CSOrOIuOcYgZTZ7/UklePoECewSea MuvXAgbyjUMeekE5FV17OTBmy2SluVYq7Xc930zdTRUjNSLsjjPbCBzGIP0UCmCvmj 9k6HAOFZtesHgx0rBdy+2umGKKddiQQvEMZqT6c6/6uCz0BwwgIyJw3ouIhhZDzX7t koy0p/dmgMCfA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MHVen-1pwvTD1opN-00DUsj; Wed, 24 May 2023 04:48:38 +0200 From: Michael Heerdegen In-Reply-To: <867csy6h2w.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 23 May 2023 21:25:11 +0300") References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> <86jzx6lvxz.fsf@mail.linkov.net> <86o7mgb4z2.fsf@mail.linkov.net> <86bkicckfl.fsf@mail.linkov.net> <87ttw34w4l.fsf@web.de> <867csy6h2w.fsf@mail.linkov.net> Date: Wed, 24 May 2023 04:48:37 +0200 Message-ID: <87353m8mwq.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:BM+v+87FFYwV7uMVGi5Bnl69iHUQfi/J3erw/crDuBE+tObZGwP fNnRb1rf+BN8iKcHzt4cMJJLsKrFBD1qc28XihZd62F/CcUcYtaV5TNRe5oLf+vALIIb0Im ZKTbqwPR882PuHJ3RQiCOInQhU78NR0ZaSaqlhpKUqLUmB+L+r5YwLbgiQ/AMeg8RCXDVcD Giourc+Wh02fCStgvBRcQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xa8KMr9H8Ew=;6OHV6M/GaUol2/XtklZSklkgsAw JfEOb3OeVyX/8Oo2rEXwRs5BzRvTDJp2p4perVii/ahgtq/sXviCiqIJ6vyqKCw47IaXN5GdL j2kHSdnwBxkJ0diYKn3FFBWLbC9rillGdAeU0D6dMSCviswMny99VWfvud8CyBUMkWdWDMBU5 bcPLD30oMmjMNYD6U3Lpp3K7/0nVM0pMZlc2SvoD8/D6gD2ftst7Pv1PuPWiG8mae1Ze+/+43 oUiXVZApoGtHapr3N1szZxGdhBUNI1mBlbE1p0vBFKG2rMaSYrG0RH0LAswD+gD6jeM/RECYA WuQyYaCMdJAELArPf2vDG8pmazwfK+0WlVRv9H/s2Qxd9/nGHKcxDdSAtGjmimERi0vYYd0HM 3tnTn6oOHHOZucbFqM0soFhJWbZWGl6hZVuZG8e7DuQmPwS+q1CysFdTD+NWX8FvJuJ4Y1Yjb Fwm+qPhDZ1O9QjejAAlKtSFuHxq3+8y7m1gjIpZLXPdXoCfTlvo+AiHzhlHuA8xOCC3uAFTmn 7wyYhdrW1gGG4V3/URcoVlYFTtJ0+EyYxXzvoYbp199NPdRxrvy8PqKKqxfyFSWEKizPw6JNy wlncYP4nEv+gx/hI+0wmwpvbVLevZftInrVXVcQXRLOeIHdH4EbgJ14RKT7Xf312LZOdp3qVh WTjw4g3zX64IkieDIzzogb0p2ULAroRd4uldkwINIGCRhnte9Jo+k7bairQa8f5K7joTV4Z42 asASyudlrUSqK4ZUpZDV/r2ahIgi2ZQz2Dy/Ku5Nprxde6V2BzDy9/rqgb2021lSydQbyG3Hj CkI03TNGdFPPCqnmUypQCur1C+VBkeRcsAfKx3YnfbOyyZX2cP8fStI33zA5QULkcbNdIY2aE hHtTxQ5Sda/QpHlyawlLZ2N1MBUF9ETFP9qkBYBrZQHsBB0yKsgvnssSnnpbJVt3QjyzRYeX3 /D0k6Q== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > > I always found that naming confusing. It makes me think of > > `with-temp-buffer', helper buffers, not of *Help*. Do you find the > > naming appropriate, having the use cases in mind? > > According to (info "(emacs) Temporary Displays") > maybe a better name would be "view-buffer" because > it's intended for non-editable buffers. Hmm - I think that name sounds a bit too general to me. I don't know - it's all a bit messy. `with-output-to-temp-buffer' displays the buffer. That's also a bit surprising. (info "(elisp) Temporary Displays") says: -- User Option: temp-buffer-show-function If this variable is non-=E2=80=98nil=E2=80=99, =E2=80=98with-output-to= -temp-buffer=E2=80=99 calls it as a function to do the job of displaying a help buffer. ^^^^ The name "temp" is everywhere. And it is, in the context of buffer display (in the wider sense), more or less synonymous with "help buffer" (in the wider sense again). If it's too late to change all of the related names, maybe we should describe the naming habits more explicitly so that it is less confusing and more discoverable. Michael.