Subject: Re: Add vcmi 1.2.1 to games.scm

From: Liliana Marie Prikler <[email-masked]>
Date: Fri, 12 May 2023 03:47:26 +0200

Am Donnerstag, dem 11.05.2023 um 16:07 -0700 schrieb Vagrant Cascadian:

> +(define-public vcmi
> +  (package
> +    (name "vcmi")
> +    (version "1.2.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/vcmi/vcmi")
> +                    (commit version)
> +                    (recursive? #t)))
Can we do without the recursive checkout?
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "1nx3i078cxkak2ci514pf4pgi5269mp08njynsg35pin4yp3fn0p"))
> +              (patches (search-patches "vcmi-disable-privacy-
> breach.patch"))))
IIRC the reproducible builds patch is still missing, right?

> +    (native-inputs (list boost
Guix style is, like, a suggestion that can be wrong.  You are allowed
to fight it when the result of doing so is demonstrably better.

Cheers