GNU bug report logs - #63395
HiDPI/GTK: menubar height scaled twice in xg_update_frame_menubar()

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63395: closed (HiDPI/GTK: menubar height scaled twice in
 xg_update_frame_menubar())
Date: Sat, 22 Feb 2025 12:30:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 22 Feb 2025 21:29:05 +0900
with message-id <87ikp2upri.fsf <at> gmail.com>
and subject line Re: bug#63395: HiDPI/GTK: menubar height scaled twice in xg_update_frame_menubar()
has caused the debbugs.gnu.org bug report #63395,
regarding HiDPI/GTK: menubar height scaled twice in xg_update_frame_menubar()
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63395: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63395
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tobias Bading <tbading <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: HiDPI/GTK: menubar height scaled twice in xg_update_frame_menubar()
Date: Tue, 9 May 2023 20:22:53 +0200

It looks like

--- %< ---

commit 401ccb0b9c697fd3af026a72b6621a692e206aea
Author:     Po Lu <luangruo <at> yahoo.com>
AuthorDate: Wed Jan 26 13:53:20 2022 +0800
Commit:     Po Lu <luangruo <at> yahoo.com>
CommitDate: Wed Jan 26 13:53:20 2022 +0800

    Fix GTK menu bar height reporting when scaled

    * src/gtkutil.c (xg_update_frame_menubar): Multiply requisition
    height by GDK scale.

M       src/gtkutil.c

--- >% ---

tried to correct a problem that was already fixed by

--- %< ---

commit a05bafffdcb88df74408a8402cafc9829407c1e5
Author:     Tobias Bading <tbading <at> web.de>
AuthorDate: Wed Nov 27 16:51:26 2019 +0100
Commit:     Robert Pluim <rpluim <at> gmail.com>
CommitDate: Tue Dec 3 08:54:31 2019 +0100

    Fix incorrect GTK menus on HiDPI monitors with scaling factor > 1

    This should fix Bug#31223, Bug#28106, Bug#23672 as well as Ubuntu bug
    https://bugs.launchpad.net/ubuntu/+source/emacs25/+bug/1695228

    Also fixes the formerly unscaled Y value returned by
    frame-monitor-workarea (and display-monitor-attributes-list).

    For details on why some GTK menus were empty please see thread
    https://lists.gnu.org/archive/html/emacs-devel/2019-11/msg01061.html

    * src/gtkutil.c (menubar_map_cb, xg_update_frame_menubar): Scale up
    req.height so that the menu bar's height is in device pixels as
    expected.
    (xg_event_is_for_menubar): Scale down rec.x and rec.y so that
    gtk_widget_intersect() works as intended.
    * src/xfns.c (Fx_display_monitor_attributes_list): Scale work.x and
    work.y up to be in device pixels.

    Copyright-paperwork-exempt: yes

M       src/gtkutil.c
M       src/xfns.c

--- >% ---

In emacs-29 as well as master req.height in xg_update_frame_menubar() is now
multiplied with xg_get_scale(f) twice. As a result my window manager (Compiz
from Ubuntu 20.04.6 LTS) assumes that the Emacs frame wouldn’t fit into the
monitor’s workarea and ignores my requested position.

Reverting 401ccb0b9c697fd3af026a72b6621a692e206aea fixes this for me.

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Tobias Bading <tbading <at> web.de>, 63395-done <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#63395: HiDPI/GTK: menubar height scaled twice in
 xg_update_frame_menubar()
Date: Sat, 22 Feb 2025 21:29:05 +0900

Hi,

Po Lu <luangruo <at> yahoo.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Po Lu, could you please take a look at the below bug report?
>
> Yes.  Tobin, I corrected this on master; would you please try again?

Assuming this is fixed; as committed in
241616831024c9c9fe2b2378b611db0a560b9675, found in master and the
emacs-30 branch.

Closing.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.