From unknown Sun Jun 22 17:11:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63390 <63390@debbugs.gnu.org> To: bug#63390 <63390@debbugs.gnu.org> Subject: Status: 29.0.90; c-ts-mode fails to recognize functions in xterm.c Reply-To: bug#63390 <63390@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:11:07 +0000 retitle 63390 29.0.90; c-ts-mode fails to recognize functions in xterm.c reassign 63390 emacs submitter 63390 Eli Zaretskii severity 63390 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 08:02:15 2023 Received: (at submit) by debbugs.gnu.org; 9 May 2023 12:02:15 +0000 Received: from localhost ([127.0.0.1]:42592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwM2o-0006Pn-Ht for submit@debbugs.gnu.org; Tue, 09 May 2023 08:02:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:37008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwM2i-0006PX-TU for submit@debbugs.gnu.org; Tue, 09 May 2023 08:02:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwM2f-0001Cm-VJ for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 08:02:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwM2f-00069L-Mo for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 08:02:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=DKJUBg4AGPl41sxwt66sv7sJ1cIYn1/wLrVRZBOOw+Y=; b=DUrBfpnX7IQc9W EB28y1xFMR+ynzEXl7kUxetHzA+ixKxjVTeysu7BiGHVv82a2SfUSD+rfpPUYv+wuzTr5E8gnNbbN pDkxJk7S6T+bpH+hiFyJhjLIUP5Pdr97OjLz0Oc/S7r+d0eQk8/xZsdgnhbto9HkAKnMUIu5DkBc8 QhOPC3gaPr2GqtqqxrkNw+W9S9z98rhxru2mreNH/iZDiW3o/9JjvECnxtbYR/q97rNen/2stFG0N ql1a0qj7z/I8yseql4ykw893aTfBbI3CxnCVz+JAvpTRf/gGgzdQiTHFlQEW47lIznFf8bogA8PjI BxtjBsWDMWljB6IIvyyQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwM2f-0005Ki-6N for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 08:02:05 -0400 Date: Tue, 09 May 2023 15:03:08 +0300 Message-Id: <837cthbtkz.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 29.0.90; c-ts-mode fails to recognize functions in xterm.c X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) To reproduce: emacs -Q M-x load-library RET c-ts-mode RET C-x C-f src/xterm.c C-u 8290 M-g g Observe that the name of the function x_draw_glyph_string_foreground is not fontified in font-lock-function-name-face, but in the default face. Starting treesit-explore-mode seems to indicate that tree-sitter interprets this as a function declaration, not a function definition: (function_declarator declarator: (identifier) parameters: (parameter_list ( (parameter_declaration type: (struct_specifier struct name: (type_identifier)) declarator: (pointer_declarator * declarator: (identifier))) ))) Same with the next function, x_draw_composite_glyph_string_foreground. But the function after that, x_draw_glyphless_glyph_string_foreground, is again recognized as function definition. I wonder if the preprocessor conditionals around there have something to do with that. Btw, function declarations in a header file are recognized as such, but the names of the functions there are still correctly fontified. In GNU Emacs 29.0.90 (build 88, i686-pc-mingw32) of 2023-05-09 built on HOME-C4E4A596F7 Repository revision: 387ddc0ccc1b21f612b9106bafec63170ede30e6 Repository branch: emacs-29 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: C/* Minor modes in effect: bug-reference-prog-mode: t treesit-explore-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git diff-mode easy-mmode vc-dispatcher bug-reference byte-opt gv bytecomp byte-compile c-ts-mode c-ts-common treesit cl-seq thingatpt cl-loaddefs cl-lib find-func rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 97345 9002) (symbols 48 7923 0) (strings 16 22587 2046) (string-bytes 1 609997) (vectors 16 12738) (vector-slots 8 179418 12186) (floats 8 31 52) (intervals 40 6159 809) (buffers 888 12)) From debbugs-submit-bounces@debbugs.gnu.org Fri May 12 07:10:14 2023 Received: (at 63390) by debbugs.gnu.org; 12 May 2023 11:10:14 +0000 Received: from localhost ([127.0.0.1]:54184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxQf8-0006ju-Ac for submit@debbugs.gnu.org; Fri, 12 May 2023 07:10:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxQf7-0006jf-Jr for 63390@debbugs.gnu.org; Fri, 12 May 2023 07:10:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxQf2-0008JT-Cn; Fri, 12 May 2023 07:10:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eZsrC3NuCwqMIeIu/jV1+vYO0gOZVtkopT4WJpemdMc=; b=LCZvFRDQ+DoT 61xj0cTInohMt6hbFpbZ8YwIv0bwpHWP/moxsiqXYbCKBtkYUbK1RWN4vb9Xfbq8ln9g1CX1VeuHE L1nq8uHMeF+9X2CIqzmS+/p8FihKMQk2PsSeAnYwvfy8Pz4+ZmIDPQLye53j98/IekDVjgDHe3Et/ LG24wWp1zhbTZpI1paksHSQT+JUKagdYHBrJt4a9PeT7SgD6msYWYkgZaSdlRtF2xU1xQlJ7V/nIC b5O3CJpKyz9VLSRBZn5m572PlwuY64ptmpIh5z46i9FtDYJAOCQsMadvV7xprfJ+6YqCxYEnBtZga 72IyzuXS0LPhHj6HrK47wg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxQf0-0006Si-Tl; Fri, 12 May 2023 07:10:08 -0400 Date: Fri, 12 May 2023 14:11:18 +0300 Message-Id: <83ttwh3iuh.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <837cthbtkz.fsf@gnu.org> (message from Eli Zaretskii on Tue, 09 May 2023 15:03:08 +0300) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c References: <837cthbtkz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Yuan, could you please look into this? > Date: Tue, 09 May 2023 15:03:08 +0300 > From: Eli Zaretskii > > To reproduce: > > emacs -Q > M-x load-library RET c-ts-mode RET > C-x C-f src/xterm.c > C-u 8290 M-g g > > Observe that the name of the function x_draw_glyph_string_foreground > is not fontified in font-lock-function-name-face, but in the default > face. > > Starting treesit-explore-mode seems to indicate that tree-sitter > interprets this as a function declaration, not a function definition: > > (function_declarator declarator: (identifier) > parameters: > (parameter_list ( > (parameter_declaration > type: (struct_specifier struct name: (type_identifier)) > declarator: (pointer_declarator * declarator: (identifier))) > ))) > > Same with the next function, x_draw_composite_glyph_string_foreground. > But the function after that, x_draw_glyphless_glyph_string_foreground, > is again recognized as function definition. I wonder if the > preprocessor conditionals around there have something to do with that. > > Btw, function declarations in a header file are recognized as such, > but the names of the functions there are still correctly fontified. > > In GNU Emacs 29.0.90 (build 88, i686-pc-mingw32) of 2023-05-09 built on > HOME-C4E4A596F7 > Repository revision: 387ddc0ccc1b21f612b9106bafec63170ede30e6 > Repository branch: emacs-29 > Windowing system distributor 'Microsoft Corp.', version 5.1.2600 > System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) > > Configured using: > 'configure -C --prefix=/d/usr --with-wide-int > --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' > > Configured features: > ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY > W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF > TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB > > Important settings: > value of $LANG: ENU > locale-coding-system: cp1255 > > Major mode: C/* > > Minor modes in effect: > bug-reference-prog-mode: t > treesit-explore-mode: t > tooltip-mode: t > global-eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > line-number-mode: t > indent-tabs-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug message mailcap yank-media puny dired > dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 > epg-config gnus-util text-property-search time-date subr-x mm-decode > mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader > sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git > diff-mode easy-mmode vc-dispatcher bug-reference byte-opt gv bytecomp > byte-compile c-ts-mode c-ts-common treesit cl-seq thingatpt cl-loaddefs > cl-lib find-func rmc iso-transl tooltip cconv eldoc paren electric > uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 > ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win > tool-bar dnd fontset image regexp-opt fringe tabulated-list replace > newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar > rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock > font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq > simple cl-generic indonesian philippine cham georgian utf-8-lang > misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms > cp51932 hebrew greek romanian slovak czech european ethiopic indian > cyrillic chinese composite emoji-zwj charscript charprop case-table > epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button > loaddefs theme-loaddefs faces cus-face macroexp files window > text-properties overlay sha1 md5 base64 format env code-pages mule > custom widget keymap hashtable-print-readable backquote threads > w32notify w32 lcms2 multi-tty make-network-process emacs) > > Memory information: > ((conses 16 97345 9002) > (symbols 48 7923 0) > (strings 16 22587 2046) > (string-bytes 1 609997) > (vectors 16 12738) > (vector-slots 8 179418 12186) > (floats 8 31 52) > (intervals 40 6159 809) > (buffers 888 12)) > > > > From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 01:47:26 2023 Received: (at 63390) by debbugs.gnu.org; 15 May 2023 05:47:26 +0000 Received: from localhost ([127.0.0.1]:42476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyR3O-0008NZ-5g for submit@debbugs.gnu.org; Mon, 15 May 2023 01:47:26 -0400 Received: from mail-pl1-f172.google.com ([209.85.214.172]:51569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyR3M-0008NL-6n for 63390@debbugs.gnu.org; Mon, 15 May 2023 01:47:24 -0400 Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1aad5245632so87259515ad.3 for <63390@debbugs.gnu.org>; Sun, 14 May 2023 22:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684129638; x=1686721638; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=benNk5lOZUmxAkeFzCsLU7b6f9E1r4QkXjBXo603RCI=; b=bplGaL512UEURC5YXZLYHcvU7NK69dNIawBleXvQdZrfuCxe/b56eDEBJMeGAcoZC5 dbCLbgrHXMlgClAwWVRmUfr9gwe94yf6YODcHGFSb/ND9WFafVvNIdGGcFvmL/fkLhxz j4vUTDpDJdGPOZuaU4UPegtBhZv6BUvJ8mYIkauW8C70ziS0xDNV14Rx24aHjQWCk6K+ Sgq3iAx9T5RT/ixcVgg2abj56Sz96TQzD2gWoBzBa0J57Fr+QmRCy3fEOpgcqiLufGad miB20Aw7WiLhgQ6j+SnmZTCIFVgV7R/mHuVKXnufX2SYxzH/9XnCitte30yVENygOvLM UxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684129638; x=1686721638; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=benNk5lOZUmxAkeFzCsLU7b6f9E1r4QkXjBXo603RCI=; b=b6LvgOorIbL9QWZEADbcFdCtEuFmpZdQraioEArOAEdw4EBJIZfJQ7DVsxsIfA7f2N XD9OJHvkIgKjJekBiVHT2VTFDlZLAmnTE0CqrCH/SfLZ6whc4mPHgRsbT6Rh9j/8jqvC GY9fkCSTSWq7U8WskFcG3pzTfky7Y6c/iV41jw35KISxI1jjRABCfmc2+FNpJSFCrw80 0hp6qE2cr/ecFskO9ClY48B5CPLC0FSU9jHEEhvWQkPTR0kbWhOGPc0HdJ3mniLg4cOZ Zxxg+f+R9NdwNdAQOxh5b11J5RdhtQ6AVGApV7ia+0eWMBZYtQkZ0/1vqabgX1b2Ujz3 p9fA== X-Gm-Message-State: AC+VfDwhON0uEx5RexzDGHRW+6oCOyIFiW0Upp6BuHCN3s49LpR3KQX0 tAEmCsaOY4lICKeygsiuIP6It7JE/f8= X-Google-Smtp-Source: ACHHUZ5Zg2ozx8OZMztrtTvVrXDltIU+p+zf6FQNv8QvMb64jBcjj8+t9ExYaSSTkX1ar/5SkF6TMg== X-Received: by 2002:a17:902:e741:b0:1a6:77b8:23e0 with SMTP id p1-20020a170902e74100b001a677b823e0mr41969191plf.60.1684129637934; Sun, 14 May 2023 22:47:17 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id h6-20020a170902b94600b001ac78ac2cafsm12423161pls.239.2023.05.14.22.47.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 May 2023 22:47:17 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c From: Yuan Fu In-Reply-To: <83ttwh3iuh.fsf@gnu.org> Date: Sun, 14 May 2023 22:47:06 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.500.231) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On May 12, 2023, at 4:11 AM, Eli Zaretskii wrote: >=20 > Yuan, could you please look into this? >=20 >> Date: Tue, 09 May 2023 15:03:08 +0300 >> From: Eli Zaretskii >>=20 >> To reproduce: >>=20 >> emacs -Q >> M-x load-library RET c-ts-mode RET >> C-x C-f src/xterm.c >> C-u 8290 M-g g >>=20 >> Observe that the name of the function x_draw_glyph_string_foreground >> is not fontified in font-lock-function-name-face, but in the default >> face. >>=20 >> Starting treesit-explore-mode seems to indicate that tree-sitter >> interprets this as a function declaration, not a function definition: >>=20 >> (function_declarator declarator: (identifier) >> parameters:=20 >> (parameter_list ( >> (parameter_declaration >> type: (struct_specifier struct name: (type_identifier)) >> declarator: (pointer_declarator * declarator: (identifier))) >> ))) >>=20 >> Same with the next function, = x_draw_composite_glyph_string_foreground. >> But the function after that, = x_draw_glyphless_glyph_string_foreground, >> is again recognized as function definition. I wonder if the >> preprocessor conditionals around there have something to do with = that. Ok, so that=E2=80=99s because there are ifdef=E2=80=99s inside the = function, which cuts the function into pieces and tree-sitter can=E2=80=99= t make out a function_definition, which is what we use to fontify the = function name. A function_declarator alone can be used in many places, = like in an argument list for function pointers, I think? I can fix this by fontifying top-level function_declaration, I think a = top-level function_declaration should always be a function definition? >>=20 >> Btw, function declarations in a header file are recognized as such, >> but the names of the functions there are still correctly fontified. They are fine because there=E2=80=99s a semicolon in the end, so the = function_decalration is wrapped in a declaration node, which we (the = fontification rules) recognize. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Mon May 15 07:13:51 2023 Received: (at 63390) by debbugs.gnu.org; 15 May 2023 11:13:51 +0000 Received: from localhost ([127.0.0.1]:42858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyW9H-0001Ej-Ac for submit@debbugs.gnu.org; Mon, 15 May 2023 07:13:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyW9F-0001EX-EM for 63390@debbugs.gnu.org; Mon, 15 May 2023 07:13:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyW99-0000ft-RS; Mon, 15 May 2023 07:13:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=EGt/qTqUioGTyhQhdaZwOonA8Wm4Z+qkc0pNElGD3ZI=; b=pGETQUT5K1R5VuYUd+dE Y7qsoghLH15LmLxLhF9Pm1+8J5R+A2zFhevcGIVNqdOuo7ZtI1mVjuWF3TIIHWtGz072Bp7I6wLcB M/cuRcMhY2a8xCtjc2mpjfCBMuwsZ8/QS/iELSb21NvTMVQ5GUvj1JjwWcNrPuIzcE+454Tt3Y/Dc k+XQHjgFWD6z8zR1zfFSkm1khTcnBLjzQNUnztfUHgEFVWQHywafkicaEUzEsr4K//W2HTcZ8TlnI LKOBV9NaVqQtXg0s982WQxDQ/t062LBUEZXtnYhBKe4RXtZZhwTyyRyjQlz+ji+Bxkdy20ST13bg8 iZFYBg6EKbFXGw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyW99-0003sv-B1; Mon, 15 May 2023 07:13:43 -0400 Date: Mon, 15 May 2023 14:13:47 +0300 Message-Id: <83o7ml26fo.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Sun, 14 May 2023 22:47:06 -0700) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sun, 14 May 2023 22:47:06 -0700 > Cc: 63390@debbugs.gnu.org > > >> (function_declarator declarator: (identifier) > >> parameters: > >> (parameter_list ( > >> (parameter_declaration > >> type: (struct_specifier struct name: (type_identifier)) > >> declarator: (pointer_declarator * declarator: (identifier))) > >> ))) > >> > >> Same with the next function, x_draw_composite_glyph_string_foreground. > >> But the function after that, x_draw_glyphless_glyph_string_foreground, > >> is again recognized as function definition. I wonder if the > >> preprocessor conditionals around there have something to do with that. > > Ok, so that’s because there are ifdef’s inside the function, which cuts the function into pieces and tree-sitter can’t make out a function_definition, which is what we use to fontify the function name. A function_declarator alone can be used in many places, like in an argument list for function pointers, I think? Does this mean that on master movement by defuns will be broken around those functions? > I can fix this by fontifying top-level function_declaration, I think a top-level function_declaration should always be a function definition? Yes, I think this would be better. > >> Btw, function declarations in a header file are recognized as such, > >> but the names of the functions there are still correctly fontified. > > They are fine because there’s a semicolon in the end, so the function_decalration is wrapped in a declaration node, which we (the fontification rules) recognize. Thanks for explaining this. From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 02:19:34 2023 Received: (at 63390) by debbugs.gnu.org; 18 May 2023 06:19:34 +0000 Received: from localhost ([127.0.0.1]:51740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzWz8-0006jq-9k for submit@debbugs.gnu.org; Thu, 18 May 2023 02:19:34 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:44244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzWz6-0006je-I8 for 63390@debbugs.gnu.org; Thu, 18 May 2023 02:19:33 -0400 Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1ae408f4d1aso13527985ad.0 for <63390@debbugs.gnu.org>; Wed, 17 May 2023 23:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684390767; x=1686982767; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n5Rl8xfvoqHneyHPTE0xNL0VUfb3GkiFWXaIJBA9LIY=; b=b3sRjk06WIsysQ2IYxDmIE3J748ZOEoRW59akYrYHv0Ir/5OLqUtoN9dngkjyJZu0v oXz6hsrbcG0o0VJ2SlzyBDc06iHQpskv7ctaMBPh5qlAENLU2Ev/fCaGSBi186N7KVmX iJJvox3EK2GuRqalUpB5IyIBwgNVRHT8B0kJpJeGBL9dd3Gz3HD39c3BEXhGWlgrFaiy JxnvqH+0oHqQTIbA+xz1zZD2PKsd77mDEgDoGAYJoCAD5n+gVH17fnmN9cVKD9TqcLvx 5ahRmYFeqI1+rdAoC0H9Tdqxi68o/8mA9p1GveJn7zb3JhcuYrBJUeJ4ZvSP7Ztrathm y8pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684390767; x=1686982767; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n5Rl8xfvoqHneyHPTE0xNL0VUfb3GkiFWXaIJBA9LIY=; b=EfkUCKkkOgIs34fc2MP2RizRZrdE6//vzggncXfMY2gTPjVG2ef4NKLCe/wb+T6VhK zSpoBO3kLLPHpc8xj4PwrZKLph8/hg+XqaE1lnttT+3I4bOplqgynb2kKhf0ZHZKtxAP H4vXb00I3FTUMlmWkXfH+mLTSSktssFe1j9vgKapzfn1ETkdXIxhgpFLgwJ7AqBFRyZE xldOzWWWUirbrQnwrjWUBsKV5SRt7PsabVAkraDBT9k/J0R560j9kN6NTc+nuHgL2mW8 /gWkk83wamf+4o3SS0x7mz8q/NMw9RJTncK/idWo1s1swUb7PXV9yWUro7AXIbCxAGhm 6NdA== X-Gm-Message-State: AC+VfDxdNCf6UWP8VmwTpOEO+Ws9h9PqKeWrH7eSXVDp+ez6OEDuQt65 xyRuqdkJkzSGsNLIlOxSWNp8r+qWTKA= X-Google-Smtp-Source: ACHHUZ6Xc/0OgMznVGxoxnarkUx5fpL/Yy9MpwSqP3wCPLWuLINo7mYxFmhJYSrSjERhqp7I0P2E9g== X-Received: by 2002:a17:903:338e:b0:1ac:6d4c:c26a with SMTP id kb14-20020a170903338e00b001ac6d4cc26amr1464668plb.14.1684390766458; Wed, 17 May 2023 23:19:26 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id v10-20020a170902b7ca00b001a9581d3ef5sm483094plz.97.2023.05.17.23.19.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2023 23:19:25 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c From: Yuan Fu In-Reply-To: <83o7ml26fo.fsf@gnu.org> Date: Wed, 17 May 2023 23:19:22 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> <83o7ml26fo.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.500.231) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On May 15, 2023, at 4:13 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sun, 14 May 2023 22:47:06 -0700 >> Cc: 63390@debbugs.gnu.org >>=20 >>>> (function_declarator declarator: (identifier) >>>> parameters:=20 >>>> (parameter_list ( >>>> (parameter_declaration >>>> type: (struct_specifier struct name: (type_identifier)) >>>> declarator: (pointer_declarator * declarator: (identifier))) >>>> ))) >>>>=20 >>>> Same with the next function, = x_draw_composite_glyph_string_foreground. >>>> But the function after that, = x_draw_glyphless_glyph_string_foreground, >>>> is again recognized as function definition. I wonder if the >>>> preprocessor conditionals around there have something to do with = that. >>=20 >> Ok, so that=E2=80=99s because there are ifdef=E2=80=99s inside the = function, which cuts the function into pieces and tree-sitter can=E2=80=99= t make out a function_definition, which is what we use to fontify the = function name. A function_declarator alone can be used in many places, = like in an argument list for function pointers, I think? >=20 > Does this mean that on master movement by defuns will be broken around > those functions? Yeah, unfortunately, I=E2=80=99ll try accommodate for it.=20 >=20 >> I can fix this by fontifying top-level function_declaration, I think = a top-level function_declaration should always be a function definition? >=20 > Yes, I think this would be better. >=20 >>>> Btw, function declarations in a header file are recognized as such, >>>> but the names of the functions there are still correctly fontified. >>=20 >> They are fine because there=E2=80=99s a semicolon in the end, so the = function_decalration is wrapped in a declaration node, which we (the = fontification rules) recognize. >=20 > Thanks for explaining this. Should I fix this on emacs-29 or master? Sorry for the delay, I was = having some distractions lately ;-) Yuan From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 02:56:11 2023 Received: (at 63390) by debbugs.gnu.org; 18 May 2023 06:56:11 +0000 Received: from localhost ([127.0.0.1]:51774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzXYZ-0007yd-D5 for submit@debbugs.gnu.org; Thu, 18 May 2023 02:56:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzXYX-0007yQ-Pd for 63390@debbugs.gnu.org; Thu, 18 May 2023 02:56:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzXYS-0004Oo-IW; Thu, 18 May 2023 02:56:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JJe6Rw25/hYoXwubb+owIfWlVEUDJOsZsegjlfzkBVY=; b=gjUAmwlDnSAspQj+/r4P Wi5nivg7vnqEfwg57QLyawK2gFQHIWmcbJ1/mXNNi6lCmMvRJWVIrJqcAh3e7CF5HjWGZD75KAsFF 9xWunjH9uPhECJIbslw+Scr3tmKTG35vtY/lXJ+sSDaY2pd1yAIv/CBcN5mUr5HM7d7KO2uYAmTZj uN5GESkVSp1+v3EtqDuQKQjv5uEIBirlNV6PZ8EUtdGrKRzLEHGcPzz6qSS1uAVfn0/H2Hl6Z2q2c A2WrzM8ZpliqnXE8PeomstD5xAliFQNa5dX2xov1IN2c0meq39gCIJgBIfWr6juqpvomZtlM20A2k IrfclBpdyBupvw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzXYS-0002UG-3t; Thu, 18 May 2023 02:56:04 -0400 Date: Thu, 18 May 2023 09:56:16 +0300 Message-Id: <83mt22w2jz.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> (message from Yuan Fu on Wed, 17 May 2023 23:19:22 -0700) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> <83o7ml26fo.fsf@gnu.org> <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Wed, 17 May 2023 23:19:22 -0700 > Cc: 63390@debbugs.gnu.org > > >> Ok, so that’s because there are ifdef’s inside the function, which cuts the function into pieces and tree-sitter can’t make out a function_definition, which is what we use to fontify the function name. A function_declarator alone can be used in many places, like in an argument list for function pointers, I think? > > > > Does this mean that on master movement by defuns will be broken around > > those functions? > > Yeah, unfortunately, I’ll try accommodate for it. > > > > >> I can fix this by fontifying top-level function_declaration, I think a top-level function_declaration should always be a function definition? > > > > Yes, I think this would be better. > > > >>>> Btw, function declarations in a header file are recognized as such, > >>>> but the names of the functions there are still correctly fontified. > >> > >> They are fine because there’s a semicolon in the end, so the function_decalration is wrapped in a declaration node, which we (the fontification rules) recognize. > > > > Thanks for explaining this. > > Should I fix this on emacs-29 or master? Sorry for the delay, I was having some distractions lately ;-) No need to apologize. We all have our lives, with their "disasters". If the fix is relatively simple and safe, I'd prefer this to be fixed on emacs-29. But if not, we can fix it later; after all, on emacs-29 this is a relatively rare issue, since we don't use tree-sitter for movement by defuns there. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 19:13:58 2023 Received: (at 63390-done) by debbugs.gnu.org; 19 May 2023 23:13:58 +0000 Received: from localhost ([127.0.0.1]:57585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q09IL-0002Qe-Pe for submit@debbugs.gnu.org; Fri, 19 May 2023 19:13:58 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:45502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q09IJ-0002QQ-O8 for 63390-done@debbugs.gnu.org; Fri, 19 May 2023 19:13:56 -0400 Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-64d2b42a8f9so1521326b3a.3 for <63390-done@debbugs.gnu.org>; Fri, 19 May 2023 16:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684538030; x=1687130030; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=61fbd+pNcN1gYMzNkpt/Au5+eIJc2OnhwQy5gtn7lEE=; b=QzRdSvOuW5U87Qe9Ym2sYAbxsc2V2l30MVigHRXMPYngGxYNKW3wbJgJiJ6m2TWHUl KcWEsEsLZIGx4PV2ysegbwRU6BHgNbtg1+2EDcFYkE3UwoPE5x+794dZVvVuEkzHZVuq v8ZDD9aCWlhhbR9wsMGChnyukool27maF6ZR4WKx+xl0OD34khhVC+5F10KLSLHSFGWu ZGtDTP/xMgT1uBsS8wugY8sklze9T1+9fwH9McaY2BNd5WMjndyLanFVZnsHEoh8sg5f M+rPvsovGI/Mq2z00WGmFXBomWN+09sGIM7b9iKKNvgCMvHhr2TDa2zzF/TkoJmXlAwq QV8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684538030; x=1687130030; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=61fbd+pNcN1gYMzNkpt/Au5+eIJc2OnhwQy5gtn7lEE=; b=Ks3bpO9Jt7mwtcU/rEDf7nlaW0hhHGN0CnJpyl9sw6srDtjBHAMXTvUUTA2Y+1o91Y v2+oj4rpsbBrELaDDyokCq/jWVpEXaoYRApN4iGqxLRLiiEFLt3UcZENslpa5kG7ev5S N3MFvWZ3wat/iVtSAumisJvnzh7sPA5Tx2R+9Oc2qaEje5vtQMVWpbC+s7zIKoQMX4jn ujSWEO2/lYo2jfvWFLCXEApnuxNGdOZJ/7zycr7LELrt52nPbbTbWXUS2PYTr34FwexW pj9bAz5DvQ8V8NUITiDSIPVLENZJgU38LoTZXaPIeC3xgtXg+mMaAijRVyvckw67DK9I 8y8Q== X-Gm-Message-State: AC+VfDzOtw+0sq8DqPzkV/YB6MQS8DPngaLiqFg2pQy7fVqXBOMAUCQ8 UNNS6Zw8+qB+GK6NH6EQw/Q= X-Google-Smtp-Source: ACHHUZ7Wl+WAAGpFEfPUOusd3vyyZt9Du1TLo967fiVZrYykL3MwFwW8LPFLfPGTy2oOV+r16azJmQ== X-Received: by 2002:a05:6a21:980f:b0:100:49d1:6fc7 with SMTP id ue15-20020a056a21980f00b0010049d16fc7mr2906030pzb.34.1684538029552; Fri, 19 May 2023 16:13:49 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id y8-20020aa78048000000b0063b7c42a072sm213338pfm.13.2023.05.19.16.13.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2023 16:13:49 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c From: Yuan Fu In-Reply-To: <83mt22w2jz.fsf@gnu.org> Date: Fri, 19 May 2023 16:13:36 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <43A50DDE-2E59-450C-933E-B2B67B33760B@gmail.com> References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> <83o7ml26fo.fsf@gnu.org> <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> <83mt22w2jz.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.500.231) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63390-done Cc: 63390-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On May 17, 2023, at 11:56 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Wed, 17 May 2023 23:19:22 -0700 >> Cc: 63390@debbugs.gnu.org >>=20 >>>> Ok, so that=E2=80=99s because there are ifdef=E2=80=99s inside the = function, which cuts the function into pieces and tree-sitter can=E2=80=99= t make out a function_definition, which is what we use to fontify the = function name. A function_declarator alone can be used in many places, = like in an argument list for function pointers, I think? >>>=20 >>> Does this mean that on master movement by defuns will be broken = around >>> those functions? >>=20 >> Yeah, unfortunately, I=E2=80=99ll try accommodate for it.=20 >>=20 >>>=20 >>>> I can fix this by fontifying top-level function_declaration, I = think a top-level function_declaration should always be a function = definition? >>>=20 >>> Yes, I think this would be better. >>>=20 >>>>>> Btw, function declarations in a header file are recognized as = such, >>>>>> but the names of the functions there are still correctly = fontified. >>>>=20 >>>> They are fine because there=E2=80=99s a semicolon in the end, so = the function_decalration is wrapped in a declaration node, which we (the = fontification rules) recognize. >>>=20 >>> Thanks for explaining this. >>=20 >> Should I fix this on emacs-29 or master? Sorry for the delay, I was = having some distractions lately ;-) >=20 > No need to apologize. We all have our lives, with their "disasters". >=20 > If the fix is relatively simple and safe, I'd prefer this to be fixed > on emacs-29. But if not, we can fix it later; after all, on emacs-29 > this is a relatively rare issue, since we don't use tree-sitter for > movement by defuns there. >=20 > Thanks. I pushed a fix for it to emacs-29. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 01:42:13 2023 Received: (at 63390) by debbugs.gnu.org; 20 May 2023 05:42:13 +0000 Received: from localhost ([127.0.0.1]:57740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0FM4-0005Rv-OA for submit@debbugs.gnu.org; Sat, 20 May 2023 01:42:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0FM3-0005RU-38 for 63390@debbugs.gnu.org; Sat, 20 May 2023 01:42:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0FLx-00079s-96; Sat, 20 May 2023 01:42:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ie1U6sEKCJAfoA0G90joPhsqxNZvSe8XsHTUhK63Qn0=; b=oA8S2/Qykpt2 6v7cSSO2jybTW62052/ZyKAJ/FDf8eXwNLnfPmG5zJx5TzrRsQtlLM1e5K8zGb2bwpx8nnsOGO3i7 EuEFQ0fVKIjtjcm637B2juRimNFj0y9TrVL4/vc54g0OBcoStonKQhPiLV2eLI+lNPAw0g/T7p71K ktadgQeYFjMICOAUFVJZRVucZHA7hSXsoK1FSnEW+c3lWBV0f/pHu3vOmwFz44uNjhRJO89OWi9XR NeMOhvYShauyL44JPXCKg5/X/9IYwBtmx4JluI9ZmRiwBGWyGmmdbgeKZ+GPokMdNv4YrE5fAr66R WGuc+zV7EI0j+xvkJ3njPw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0FLw-00010d-HG; Sat, 20 May 2023 01:42:04 -0400 Date: Sat, 20 May 2023 08:42:20 +0300 Message-Id: <83353rtv7n.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <43A50DDE-2E59-450C-933E-B2B67B33760B@gmail.com> (message from Yuan Fu on Fri, 19 May 2023 16:13:36 -0700) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> <83o7ml26fo.fsf@gnu.org> <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> <83mt22w2jz.fsf@gnu.org> <43A50DDE-2E59-450C-933E-B2B67B33760B@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Fri, 19 May 2023 16:13:36 -0700 > Cc: 63390-done@debbugs.gnu.org > > > On May 17, 2023, at 11:56 PM, Eli Zaretskii wrote: > > > > If the fix is relatively simple and safe, I'd prefer this to be fixed > > on emacs-29. But if not, we can fix it later; after all, on emacs-29 > > this is a relatively rare issue, since we don't use tree-sitter for > > movement by defuns there. > > > > Thanks. > > I pushed a fix for it to emacs-29. Thanks, but this leads to: ELC progmodes/c-ts-mode.elc In end of data: progmodes/c-ts-mode.el:770:11: Warning: the function `treesit-node-match-p' is not known to be defined. The function treesit-node-match-p is only available on master, AFAICT. From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 04:17:57 2023 Received: (at 63390) by debbugs.gnu.org; 20 May 2023 08:17:57 +0000 Received: from localhost ([127.0.0.1]:57824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0Hmn-0001T8-75 for submit@debbugs.gnu.org; Sat, 20 May 2023 04:17:57 -0400 Received: from mail-pl1-f180.google.com ([209.85.214.180]:50336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0Hml-0001Sv-Fu for 63390@debbugs.gnu.org; Sat, 20 May 2023 04:17:55 -0400 Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1ae51b07338so28676185ad.0 for <63390@debbugs.gnu.org>; Sat, 20 May 2023 01:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684570670; x=1687162670; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=om3r8rOnT6NqtSE0c+64AQdsWpWh9UPbda5r6HSqqFw=; b=G3VUEeaG8vJYTDqF9KU3cHI0Hbb2SJw0vt2cfWdq+vfUrey8fgarTIFgsdg/6SdH96 serPlsP167QwFsgjTJqVGx/yCXsvTPX5taWdOiLfJeTzAZL7hgb1PiMWFIf/DnICzS6X kVQxpbkw2shC0JkW84b8i5KJ1P/L+1jjIOMl3xdsoonwDHqlS/OROKkLirEwlLhMgm5H OGDpp+6p2z6TDY+Q7xpM0/ZZbEqlUoI5b0IA457al69ExZHQ55egRHsc424VCr56sBOr FXaSO0UyVKJtPkgaOSGXQ58x582W0aeQyTooruy9bZGqtUkiramnBQ10Dt1uDt2tSTLe qTBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684570670; x=1687162670; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=om3r8rOnT6NqtSE0c+64AQdsWpWh9UPbda5r6HSqqFw=; b=PnhTfNj/YdOlVyGbJPQX1itre/ZePC5YABDAsIJF4ZWHyZi6mK+ov8qO9DjuW8uNaz 0AyCrWrB9wUG7hIrF8IbXd91jL5AGwQF9sovznl/uWZXzYLUMuNm1cdWDrPtgVGIovv5 TmfTyZxDjUBmxwjidqmgG6SjfPCRjiGE89EIktPEOCEKDQYiwM9sEBbo/VAd/l2XNkk6 HJjOjWrkmPEkciMLomqr+e5W7Z6YBLQYVmwOHvb6fdbu7pkuXRwAUaBPr+E7rX+6ErtN zlg8HWx7zambl+Byw3Eifkdf4YYAaJYDu9VpHX4ANZRjU6CSAXJeCjqNaLhVGjWaB/3J guJA== X-Gm-Message-State: AC+VfDz4FBESFrzZVYsl6ahAgbFNBH+HNoz8iFofNJ7+uXoDHIrEypBK WjZSvOzOp6FDrv8i7LRZ5Uc= X-Google-Smtp-Source: ACHHUZ4BY5hTuoL0gQw0Zz/5h8Uy+Lcbm/nJeSOgcpToJiZd2ZqUsVP/uLti8iHMe4kFI8GcVAkqAQ== X-Received: by 2002:a17:903:2444:b0:1aa:f203:781c with SMTP id l4-20020a170903244400b001aaf203781cmr6100861pls.44.1684570669589; Sat, 20 May 2023 01:17:49 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id w7-20020a170902d70700b001ab0a30c895sm908688ply.202.2023.05.20.01.17.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 May 2023 01:17:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c From: Yuan Fu In-Reply-To: <83353rtv7n.fsf@gnu.org> Date: Sat, 20 May 2023 01:17:37 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> <83o7ml26fo.fsf@gnu.org> <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> <83mt22w2jz.fsf@gnu.org> <43A50DDE-2E59-450C-933E-B2B67B33760B@gmail.com> <83353rtv7n.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.500.231) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On May 19, 2023, at 10:42 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Fri, 19 May 2023 16:13:36 -0700 >> Cc: 63390-done@debbugs.gnu.org >>=20 >>> On May 17, 2023, at 11:56 PM, Eli Zaretskii wrote: >>>=20 >>> If the fix is relatively simple and safe, I'd prefer this to be = fixed >>> on emacs-29. But if not, we can fix it later; after all, on = emacs-29 >>> this is a relatively rare issue, since we don't use tree-sitter for >>> movement by defuns there. >>>=20 >>> Thanks. >>=20 >> I pushed a fix for it to emacs-29. >=20 > Thanks, but this leads to: >=20 > ELC progmodes/c-ts-mode.elc >=20 > In end of data: > progmodes/c-ts-mode.el:770:11: Warning: the function = `treesit-node-match-p' is not known to be defined. >=20 > The function treesit-node-match-p is only available on master, AFAICT. Ah! My bad, now fixed. Yuan From debbugs-submit-bounces@debbugs.gnu.org Sat May 20 05:38:22 2023 Received: (at 63390) by debbugs.gnu.org; 20 May 2023 09:38:22 +0000 Received: from localhost ([127.0.0.1]:57878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0J2c-0003i2-F1 for submit@debbugs.gnu.org; Sat, 20 May 2023 05:38:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0J2a-0003hq-W4 for 63390@debbugs.gnu.org; Sat, 20 May 2023 05:38:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0J2V-0004uL-F0; Sat, 20 May 2023 05:38:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8QjR+Vqa2NuxLJUXp1U3nYWOjBOBFCjfgHbQ9DLRS84=; b=X3/oHVTpQcyp 3F//3ZMLPAReSnhs7mkoj3RnexOVc4xnFAI4EiAT5GbLjgqB84RLd8Q/fgIsnzdjAjmMYERM0eike nfeKvLZl28xnXCrZ3BfkBMK3AQwAENDUSXqO8dJCuKNlJHKN3oojlI1UA547FpWxm0fkiRqsI+slK 61xEvdKBGlqVHZB6sHrI5yMM5CdaFEB8bLH1maaRXvDgPofTJBJ+sS7c1nRU5WG6Si0rGFuzr8kb6 uyCACRxxOGPLxhrKw/YtqGR/Bi7wqHMHhvjAAqKXr/lDsBz8qn+Lx3imhd+ZdNDTv4EJZlg6eSdFV TIeLp35vuUjqwRTNxMb5bQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0J2U-0004ZH-Ua; Sat, 20 May 2023 05:38:15 -0400 Date: Sat, 20 May 2023 12:38:31 +0300 Message-Id: <83sfbrs5pk.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Sat, 20 May 2023 01:17:37 -0700) Subject: Re: bug#63390: 29.0.90; c-ts-mode fails to recognize functions in xterm.c References: <837cthbtkz.fsf@gnu.org> <83ttwh3iuh.fsf@gnu.org> <83o7ml26fo.fsf@gnu.org> <5DD50A1C-F069-4FA8-8F2B-F273409310AE@gmail.com> <83mt22w2jz.fsf@gnu.org> <43A50DDE-2E59-450C-933E-B2B67B33760B@gmail.com> <83353rtv7n.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63390 Cc: 63390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 20 May 2023 01:17:37 -0700 > Cc: 63390@debbugs.gnu.org > > > ELC progmodes/c-ts-mode.elc > > > > In end of data: > > progmodes/c-ts-mode.el:770:11: Warning: the function `treesit-node-match-p' is not known to be defined. > > > > The function treesit-node-match-p is only available on master, AFAICT. > > Ah! My bad, now fixed. Thanks. From unknown Sun Jun 22 17:11:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Jun 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator