Subject: Re: bug#63388: [PATCH] gnu: guile-gnutls: Update to 3.7.12.

From: Christopher Baines <[email-masked]>
Date: Wed, 10 May 2023 11:45:05 +0100

Ludovic Courtès <[email-masked]> writes:

> Hi Christopher,
>
> Christopher Baines <[email-masked]> skribis:
>
>> * gnu/packages/tls.scm (guile-gnutls): Update to 3.7.12.
>> [source]: Switch to a tarball, to avoid a circular dependency if guile-gnutls
>> is used in git-download.
>> [arguments]: Remove phase changes for building from Git.
>> [native-inputs]: Remove autoconf and automake as they're now unnecessary.
>
> Excellent!  (Thanks, Simon!)
>
>>      (source (origin
>> -              (method git-fetch)
>> -              (uri (git-reference
>> -                    (url home-page)
>> -                    (commit (string-append "v" version))))
>> +              (method url-fetch)
>
> Please add a comment stating why we’re using ‘url-fetch’, with a
> reference to <https://issues.guix.gnu.org/63331>.

Done.

>> +              (uri
>> +               (string-append
>
> Rather on the same line maybe?  :-)

Sure, I've moved it up.

> Thanks for working on it!

No problem, I've pushed this to master as
5e1e67442188ccca8db8c1dd092efbc6fc2c33dc.