GNU bug report logs - #63370
[PATCH] gnu: Add emacs-framemove.

Previous Next

Full log

Message #8 received at 63370 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fabio Natali <me <at> fabionatali.com>
Cc: 63370 <at> debbugs.gnu.org
Subject: Re: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Mon, 08 May 2023 18:15:38 +0200

Hello,

Fabio Natali <me <at> fabionatali.com> writes:
>
> * gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.

Thank you.

> Signed-off-by: Fabio Natali <me <at> fabionatali.com>

In Guix, you don't sign your own commits.

> +       (uri "https://www.emacswiki.org/emacs/download/framemove.el")

This is an issue, because the URI is not stable. Please use GitHub
repository instead: <https://github.com/emacsmirror/framemove>.

> +    (description "@code{emacs-framemove} is similar to the
> @code{windmove.el}

Nicpicks: @code{emacs-framemove} -> Framemove and @code{windmove.el} -> Windmove.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.