GNU bug report logs - #63370
[PATCH] gnu: Add emacs-framemove.

Previous Next

Package: guix-patches;

Reported by: Fabio Natali <me <at> fabionatali.com>

Date: Mon, 8 May 2023 13:07:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Fabio Natali <me <at> fabionatali.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 63370 <at> debbugs.gnu.org
Subject: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Mon, 08 May 2023 20:15:04 +0100
Hey Nicolas, thanks for getting back to me so quickly. An updated
version of the patch should be arriving in a minute.

On 2023-05-08, 18:15 +0200, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
> In Guix, you don't sign your own commits.

Ooops, sorry. Fixed in the new patch.

>> +       (uri "https://www.emacswiki.org/emacs/download/framemove.el")
>
> This is an issue, because the URI is not stable. Please use GitHub
> repository instead: <https://github.com/emacsmirror/framemove>.

Fixed.

>> +    (description "@code{emacs-framemove} is similar to the
>> @code{windmove.el}
>
> Nicpicks: @code{emacs-framemove} -> Framemove and @code{windmove.el} -> Windmove.

This is also fixed.

Thanks Nicolas, should you spot anything else, I'm very glad to keep
working on it.

Cheers, Fabio.




This bug report was last modified 2 years and 7 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.