From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 02 20:03:46 2010 Received: (at submit) by debbugs.gnu.org; 3 Jun 2010 00:03:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJxuT-0007P2-PP for submit@debbugs.gnu.org; Wed, 02 Jun 2010 20:03:46 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJxuS-0007Ou-Nm for submit@debbugs.gnu.org; Wed, 02 Jun 2010 20:03:45 -0400 Received: from lists.gnu.org ([199.232.76.165]:55906) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OJxuO-00066m-RF for submit@debbugs.gnu.org; Wed, 02 Jun 2010 20:03:40 -0400 Received: from [140.186.70.92] (port=43307 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJxuN-0006nI-C7 for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2010 20:03:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJxuK-0008CX-B5 for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2010 20:03:39 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:38622) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJxuK-0008C6-5Q for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2010 20:03:36 -0400 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5303XE2026469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Jun 2010 00:03:34 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o52NJ6WO015498 for ; Thu, 3 Jun 2010 00:03:33 GMT Received: from abhmt005.oracle.com by acsmt353.oracle.com with ESMTP id 317706331275523411; Wed, 02 Jun 2010 17:03:31 -0700 Received: from dradamslap1 (/141.144.80.77) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 02 Jun 2010 17:03:31 -0700 From: "Drew Adams" To: Subject: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks Date: Wed, 2 Jun 2010 17:03:30 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcsCsDLGtC4V863XQc2Dm+pL8uap/Q== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 X-Auth-Type: Internal IP X-Source-IP: rcsinet13.oracle.com [148.87.113.125] X-CT-RefId: str=0001.0A090202.4C06F156.01FE:SCFMA4539811,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) The doc for `define-minor-mode' is incomplete regarding the mode hooks, and it has apparently been like this since the beginning (Emacs 21). The doc (doc string and Elisp manual) speaks about the MODE-hook, where MODE is the name of the minor mode. But it does not mention that there is also a `MODE-on-hook' and a `MODE-off-hook'. That is, if you define those hook variables they to will be processed by the mode command. The exact behavior should be defined: The MODE-hook, if any, is run first, then the MODE-on-hook or MODE-off-hook is run, depending on whether the mode is being turned on or off. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-05-23 on G41R2F1 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include' From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 02 21:56:36 2010 Received: (at 6337) by debbugs.gnu.org; 3 Jun 2010 01:56:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJzff-00089O-PL for submit@debbugs.gnu.org; Wed, 02 Jun 2010 21:56:36 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJzfe-00089J-1V for 6337@debbugs.gnu.org; Wed, 02 Jun 2010 21:56:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAI6oBkxFpYiT/2dsb2JhbACeI3LAFoUWBIxW X-IronPort-AV: E=Sophos;i="4.53,350,1272859200"; d="scan'208";a="67127515" Received: from 69-165-136-147.dsl.teksavvy.com (HELO pastel.home) ([69.165.136.147]) by ironport2-out.pppoe.ca with ESMTP; 02 Jun 2010 21:56:30 -0400 Received: by pastel.home (Postfix, from userid 20848) id 26FAA81F8; Wed, 2 Jun 2010 21:56:30 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks Message-ID: References: Date: Wed, 02 Jun 2010 21:56:30 -0400 In-Reply-To: (Drew Adams's message of "Wed, 2 Jun 2010 17:03:30 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6337 Cc: 6337@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > The doc (doc string and Elisp manual) speaks about the MODE-hook, where > MODE is the name of the minor mode. But it does not mention that there > is also a `MODE-on-hook' and a `MODE-off-hook'. That is, if you define > those hook variables they to will be processed by the mode command. They're only supported for historical reasons. We could/should probably get rid of them. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 18:11:36 2011 Received: (at 6337) by debbugs.gnu.org; 13 Jul 2011 22:11:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7eV-0002uI-ST for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:11:35 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7eL-0002ti-LE for 6337@debbugs.gnu.org; Wed, 13 Jul 2011 18:11:26 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh7e8-00065S-76; Thu, 14 Jul 2011 00:11:08 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks In-Reply-To: (Stefan Monnier's message of "Wed, 02 Jun 2010 21:56:30 -0400") Date: Thu, 14 Jul 2011 00:10:58 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: David Byrne and Brian Eno's _My Life In The Bush Of Ghosts_: "Mea Culpa" X-Hashcash: 1:23:110713:6337@debbugs.gnu.org::WsLWAiPt3RmI0R6Q:000000000000000000000000000000000000000003jQ8 X-Hashcash: 1:23:110713:drew.adams@oracle.com::5RYp/hhwy8K6UJHn:00000000000000000000000000000000000000007qTu X-Hashcash: 1:23:110713:monnier@iro.umontreal.ca::EjAEBuZJlSyfYMte:0000000000000000000000000000000000000Otnb MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh7e8-00065S-76 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311199868.29857@dc52tjMy+jWRGtg+0t4Gsw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6337 Cc: 6337@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: >> The doc (doc string and Elisp manual) speaks about the MODE-hook, where >> MODE is the name of the minor mode. But it does not mention that there >> is also a `MODE-on-hook' and a `MODE-off-hook'. That is, if you define >> those hook variables they to will be processed by the mode command. > > They're only supported for historical reasons. We could/should probably > get rid of them. This doesn't seem like a bug, then, so I'm closing this report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 18:11:14 2011 Received: (at control) by debbugs.gnu.org; 13 Jul 2011 22:11:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7eE-0002tZ-9w for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:11:14 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7eC-0002tN-Pf for control@debbugs.gnu.org; Wed, 13 Jul 2011 18:11:13 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh7e1-000652-Sq for control@debbugs.gnu.org; Thu, 14 Jul 2011 00:11:01 +0200 Date: Thu, 14 Jul 2011 00:11:01 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #6337 X-MailScanner-ID: 1Qh7e1-000652-Sq X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311199862.04151@6RMYfwcqyOchAzq4J74TtA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 6337 notabug close 6337 From unknown Mon Jun 23 07:47:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Aug 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator