GNU bug report logs - #63362
Bug+fix for eshell-hist-ignore-dups 'erase

Previous Next

Package: emacs;

Reported by: Alexander Kozhevnikov <mentalisttraceur <at> gmail.com>

Date: Mon, 8 May 2023 07:24:05 UTC

Severity: normal

Merged with 63360

Fixed in version 30.1

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Jim Porter <jporterbugs <at> gmail.com>
To: Alexander Kozhevnikov <mentalisttraceur <at> gmail.com>, 63362 <at> debbugs.gnu.org
Subject: bug#63362: Bug+fix for eshell-hist-ignore-dups 'erase
Date: Sun, 14 May 2023 21:46:32 -0700
On 5/7/2023 11:38 AM, Alexander Kozhevnikov wrote:
> I think the ideal fix here is a refactor that makes the big picture
> clearer (I can provide one if asked, but that would almost certainly
> have enough creative substance to require copyright assignment, and
> would need to wait on the paperwork).

Thanks for this analysis. I'll try and take a look at this in more 
detail, and perhaps refactor things a bit in this part of the code as 
you suggest. (I've wanted to clean up the Eshell history logic a bit 
already, since I'd like to make it a bit more usable when you have 
multiple Eshell buffers.)

First step though is for me to write up a few regression tests, I think. 
That should make it easier to do some refactoring without breaking anything.




This bug report was last modified 1 year and 272 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.