From unknown Sun Aug 17 10:26:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63355] [PATCH] gnu: kodi: Fix build with latest glibc. Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 May 2023 04:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63355 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63355@debbugs.gnu.org Cc: rekado@elephly.net, Eric Bavier X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168352115312789 (code B ref -1); Mon, 08 May 2023 04:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 May 2023 04:45:53 +0000 Received: from localhost ([127.0.0.1]:38816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvsky-0003KC-Pv for submit@debbugs.gnu.org; Mon, 08 May 2023 00:45:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:56404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvskw-0003K2-On for submit@debbugs.gnu.org; Mon, 08 May 2023 00:45:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvskv-00005O-NV for guix-patches@gnu.org; Mon, 08 May 2023 00:45:50 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvskr-00027X-G4 for guix-patches@gnu.org; Mon, 08 May 2023 00:45:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 079DF240271 for ; Mon, 8 May 2023 06:45:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683521140; bh=n5ENVrOSXwjzwQLY+jNztIS81BmCP2jCSDpdU2tLymY=; h=From:To:Cc:Subject:Date:From; b=KLRy5b+2Sy/BZgm5rqhJBU6hqHCl4xtWPKB4f/3aiuchky4Ym5ljyXmsdfRYar7TL 4phaDTS5qbetPR4y3m4pvTD4K00DIdbA6B9NHMgtnzSUQQ5zBHPyh/sqM1BF4SIDOL xSJXVRD9X+utrVDWsnacIGqLM4UKjMzD6JKMytxdGxSvysu6+yEV3WALDGlzpUA+Jw kV7X/0FiyamHjw9XVcjDNCXn+wxRA2CNGAu/e1f9D3MS3MlNECdbkSDxhntt4h6j+T 0+NaqG0M/aTyaS456/2LXqJC0NocuChZ4AblhGkBS453cDF52viSa9ZjB+mEOTR2Wx lB6isXRlTdBfQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QF7yV5FX2z9rxF; Mon, 8 May 2023 06:45:38 +0200 (CEST) From: Eric Bavier Date: Mon, 8 May 2023 04:45:02 +0000 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=bavier@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Currently, kodi's dependency `spdlog`, via spdlog-for-kodi, fails to build, primarily due to a failure in building its tests; its bundled copy of "check.h" cannot compile against latest glibc whose `MINSIGSTKSZ` is no longer a constant. See e.g. https://github.com/catchorg/Catch2/issues/2178 The `spdlog-for-kodi` variable was added at the same time as the kodi update to 19.5, but it seems to compile and run fine with the most recent spdlog and fmt packages, which have been adapted to the glibc change. Ricardo, do you recall why this special package was added? or forsee anything wrong with the change? `~Eric * gnu/packages/kodi.scm (kodi)[inputs]: Use most recent 'fmt' and 'spdlog' packages. * gnu/packages/logging.scm (spdlog-for-kodi): Delete. --- gnu/packages/kodi.scm | 4 ++-- gnu/packages/logging.scm | 14 -------------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/gnu/packages/kodi.scm b/gnu/packages/kodi.scm index 739d293a57..e0710c9fc2 100644 --- a/gnu/packages/kodi.scm +++ b/gnu/packages/kodi.scm @@ -415,7 +415,7 @@ (define-public kodi ffmpeg-4 flac flatbuffers - fmt-6 + fmt fontconfig freetype fribidi @@ -456,7 +456,7 @@ (define-public kodi python rapidjson samba - spdlog-for-kodi + spdlog sqlite taglib tinyxml diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm index 550caf7be1..61b3d6ccc5 100644 --- a/gnu/packages/logging.scm +++ b/gnu/packages/logging.scm @@ -252,20 +252,6 @@ (define-public spdlog-1.10 (sha256 (base32 "02xz017ba9fssm1rp1fcfld7h79awbr6fqai9dxaqp02akp3davk")))))) -(define-public spdlog-for-kodi - (package - (inherit spdlog) - (version "1.5.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/gabime/spdlog") - (commit (string-append "v" version)))) - (file-name (git-file-name "spdlog" version)) - (sha256 - (base32 "0dn44r3xbw1w0bk9yflnxkh3rzdq2bpxkks44skfmqig0rsj1f1x")))))) - (define-public rsyslog (package (name "rsyslog") base-commit: 7a0a186a32524d4156bf96786d708fab323cebff -- 2.39.2 From unknown Sun Aug 17 10:26:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63355] [PATCH] gnu: kodi: Fix build with latest glibc. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 May 2023 06:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63355 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Eric Bavier Cc: 63355@debbugs.gnu.org Received: via spool by 63355-submit@debbugs.gnu.org id=B63355.168352731125413 (code B ref 63355); Mon, 08 May 2023 06:29:01 +0000 Received: (at 63355) by debbugs.gnu.org; 8 May 2023 06:28:31 +0000 Received: from localhost ([127.0.0.1]:38984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvuMJ-0006bo-Gu for submit@debbugs.gnu.org; Mon, 08 May 2023 02:28:31 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]:21740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvuMG-0006bc-Ef for 63355@debbugs.gnu.org; Mon, 08 May 2023 02:28:30 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1683527304; cv=none; d=zohomail.com; s=zohoarc; b=RUSewga1VHBjLMZG+JUUfG24eDiymd8m+8fvtqtVMF7m6X7lygsNBQmcQx24nznP97Ekr+FGkYi7zxQapNVb5j2o393FP/ADyX6NzSFUg/8kHHUIDzWg9eD9TMLLsaavfzf62mjrfl4NdL3Ioxc+xtOXQY3SIhMz4KBUq/YumxI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683527304; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=E1iorFuFLDzmdwUJbMW73eBldIqYdqp/RIMpWJV5pJQ=; b=B0U01QknssXGsNfsjKpijk3+9hqGrA02djLbIp15W9KMP38hOCzj/M+gnHYMPtMsXevJulQgLmZJwq5eQbg0a3uWBeIFMWO4ybQc/SBKHBZp5kJAO7Z9q1yrVKXNPTOfBBBHjd0NvKmYfueLvp9LBI+SB+uqHzncL/WSkIc97lI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683527304; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=E1iorFuFLDzmdwUJbMW73eBldIqYdqp/RIMpWJV5pJQ=; b=fJXEMKIEdEgtXr0H8GGuvLIEjLDbYXxgIpGf27/V+zb1C0eukO9SIb0JIb5ga+9f R9pOo6lR/1Rxo5oAUVFtw26vasLINZcHAQKHOEAxNNotBoogFDmpDms2zKt0V0iTxC5 M+NfaniTRsMevuCCGOWXjlpfBz0ZTYnESREbzorY= Received: from localhost (196-109-142-46.pool.kielnet.net [46.142.109.196]) by mx.zohomail.com with SMTPS id 1683527303721132.2758292808703; Sun, 7 May 2023 23:28:23 -0700 (PDT) References: User-agent: mu4e 1.10.2; emacs 28.2 From: Ricardo Wurmus Date: Mon, 08 May 2023 08:27:24 +0200 In-reply-to: Message-ID: <874jonxrp8.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eric, > Ricardo, do you > recall why this special package was added? or forsee anything wrong with = the > change? =E2=80=9CNo=E2=80=9D to both questions. This looks good to me. --=20 Ricardo From unknown Sun Aug 17 10:26:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eric Bavier Subject: bug#63355: closed (Re: [PATCH] gnu: kodi: Fix build with latest glibc.) Message-ID: References: <710418abcc41260650a0cf33f31c1379dba55886.camel@posteo.net> X-Gnu-PR-Message: they-closed 63355 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63355@debbugs.gnu.org Date: Wed, 10 May 2023 19:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1683745322-29322-1" This is a multi-part message in MIME format... ------------=_1683745322-29322-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63355: [PATCH] gnu: kodi: Fix build with latest glibc. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63355@debbugs.gnu.org. --=20 63355: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63355 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1683745322-29322-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63355-done) by debbugs.gnu.org; 10 May 2023 19:01:39 +0000 Received: from localhost ([127.0.0.1]:49039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwp4B-0007cF-AC for submit@debbugs.gnu.org; Wed, 10 May 2023 15:01:38 -0400 Received: from mout02.posteo.de ([185.67.36.66]:54823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwp45-0007bx-WD for 63355-done@debbugs.gnu.org; Wed, 10 May 2023 15:01:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DFD8024010B for <63355-done@debbugs.gnu.org>; Wed, 10 May 2023 21:01:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683745283; bh=bifQgjxOdewHeE3mvK5EKgWnVqRDY8GUhT1EFGA8tUA=; h=Subject:From:To:Cc:Date:From; b=XxOtKWjMeWZfm6ACW+/CJc8W/pZKCmvJDXwIJSm/YBrhkGnR+WNwllaNuRHXFMbVr KR0fOfDj/TXqSaruy66+owCBwuHT+AJm3Fi36juROtRGJAtax5U7/fcQbs2vizCaoO XKLlxImVkfx8fKhagSTkCAa2AYPhO4Jgpfgxnj1JxXRo+jbCLoqE2VNLRgav9Biw+C 0oZjkV2wzuiTOiulyYYGj4f3rNFToih/zZPQ/88GY3TCB6C0xISMevocVWS9/3AJMJ ZwwfwqC6Ye2tGJgN9VMLJxoMw8c/E4ZlLsRlZU5FpZTaHlW3h//3o1e4mtIoYJhIZ8 PCWz2opMcHeMQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QGkry56kTz9rxG; Wed, 10 May 2023 21:01:22 +0200 (CEST) Message-ID: <710418abcc41260650a0cf33f31c1379dba55886.camel@posteo.net> Subject: Re: [PATCH] gnu: kodi: Fix build with latest glibc. From: Eric Bavier To: Ricardo Wurmus Date: Wed, 10 May 2023 19:01:17 +0000 In-Reply-To: <874jonxrp8.fsf@elephly.net> References: <874jonxrp8.fsf@elephly.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63355-done Cc: 63355-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mon, 2023-05-08 at 08:27 +0200, Ricardo Wurmus wrote: > Hi Eric, >=20 > > Ricardo, do you > > recall why this special package was added? or forsee anything wrong wit= h the > > change? >=20 > =E2=80=9CNo=E2=80=9D to both questions. This looks good to me. >=20 Great, thanks! This patch was pushed in 7e152870558e. A follow-up commit in b4e5844700b2 responds to a recent mesa update.=20 Probably a kodi update would also have worked, but a backport of the immediate fix was more expedient. `~Eric ------------=_1683745322-29322-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 May 2023 04:45:53 +0000 Received: from localhost ([127.0.0.1]:38816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvsky-0003KC-Pv for submit@debbugs.gnu.org; Mon, 08 May 2023 00:45:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:56404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvskw-0003K2-On for submit@debbugs.gnu.org; Mon, 08 May 2023 00:45:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvskv-00005O-NV for guix-patches@gnu.org; Mon, 08 May 2023 00:45:50 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvskr-00027X-G4 for guix-patches@gnu.org; Mon, 08 May 2023 00:45:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 079DF240271 for ; Mon, 8 May 2023 06:45:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683521140; bh=n5ENVrOSXwjzwQLY+jNztIS81BmCP2jCSDpdU2tLymY=; h=From:To:Cc:Subject:Date:From; b=KLRy5b+2Sy/BZgm5rqhJBU6hqHCl4xtWPKB4f/3aiuchky4Ym5ljyXmsdfRYar7TL 4phaDTS5qbetPR4y3m4pvTD4K00DIdbA6B9NHMgtnzSUQQ5zBHPyh/sqM1BF4SIDOL xSJXVRD9X+utrVDWsnacIGqLM4UKjMzD6JKMytxdGxSvysu6+yEV3WALDGlzpUA+Jw kV7X/0FiyamHjw9XVcjDNCXn+wxRA2CNGAu/e1f9D3MS3MlNECdbkSDxhntt4h6j+T 0+NaqG0M/aTyaS456/2LXqJC0NocuChZ4AblhGkBS453cDF52viSa9ZjB+mEOTR2Wx lB6isXRlTdBfQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QF7yV5FX2z9rxF; Mon, 8 May 2023 06:45:38 +0200 (CEST) From: Eric Bavier To: guix-patches@gnu.org Subject: [PATCH] gnu: kodi: Fix build with latest glibc. Date: Mon, 8 May 2023 04:45:02 +0000 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=bavier@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: rekado@elephly.net, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Currently, kodi's dependency `spdlog`, via spdlog-for-kodi, fails to build, primarily due to a failure in building its tests; its bundled copy of "check.h" cannot compile against latest glibc whose `MINSIGSTKSZ` is no longer a constant. See e.g. https://github.com/catchorg/Catch2/issues/2178 The `spdlog-for-kodi` variable was added at the same time as the kodi update to 19.5, but it seems to compile and run fine with the most recent spdlog and fmt packages, which have been adapted to the glibc change. Ricardo, do you recall why this special package was added? or forsee anything wrong with the change? `~Eric * gnu/packages/kodi.scm (kodi)[inputs]: Use most recent 'fmt' and 'spdlog' packages. * gnu/packages/logging.scm (spdlog-for-kodi): Delete. --- gnu/packages/kodi.scm | 4 ++-- gnu/packages/logging.scm | 14 -------------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/gnu/packages/kodi.scm b/gnu/packages/kodi.scm index 739d293a57..e0710c9fc2 100644 --- a/gnu/packages/kodi.scm +++ b/gnu/packages/kodi.scm @@ -415,7 +415,7 @@ (define-public kodi ffmpeg-4 flac flatbuffers - fmt-6 + fmt fontconfig freetype fribidi @@ -456,7 +456,7 @@ (define-public kodi python rapidjson samba - spdlog-for-kodi + spdlog sqlite taglib tinyxml diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm index 550caf7be1..61b3d6ccc5 100644 --- a/gnu/packages/logging.scm +++ b/gnu/packages/logging.scm @@ -252,20 +252,6 @@ (define-public spdlog-1.10 (sha256 (base32 "02xz017ba9fssm1rp1fcfld7h79awbr6fqai9dxaqp02akp3davk")))))) -(define-public spdlog-for-kodi - (package - (inherit spdlog) - (version "1.5.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/gabime/spdlog") - (commit (string-append "v" version)))) - (file-name (git-file-name "spdlog" version)) - (sha256 - (base32 "0dn44r3xbw1w0bk9yflnxkh3rzdq2bpxkks44skfmqig0rsj1f1x")))))) - (define-public rsyslog (package (name "rsyslog") base-commit: 7a0a186a32524d4156bf96786d708fab323cebff -- 2.39.2 ------------=_1683745322-29322-1--