GNU bug report logs - #63346
[PATCH] Makefile.am: Use --add flag to "git config".

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mekeor Melire <mekeor <at> posteo.de>
Subject: bug#63346: closed (Re: bug#63346: [PATCH] Makefile.am: Use --add
 flag to "git config".)
Date: Sun, 07 May 2023 13:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#63346: [PATCH] Makefile.am: Use --add flag to "git config".

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 63346 <at> debbugs.gnu.org.

-- 
63346: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63346
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mekeor Melire <mekeor <at> posteo.de>
Cc: 63346-done <at> debbugs.gnu.org
Subject: Re: bug#63346: [PATCH] Makefile.am: Use --add flag to "git config".
Date: Sun, 07 May 2023 09:20:22 -0400

Hi,

Mekeor Melire <mekeor <at> posteo.de> writes:

> Without the "--add" flag to "git config include.path ...", the command fails
> if the user already has a configuration entry of "include.path".
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 8af69f88ac..13718e4353 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1121,7 +1121,7 @@ cuirass-jobs: $(GOBJECTS)
>  
>  .git/config: etc/git/gitconfig
>  	$(AM_V_at)if command -v git >/dev/null && test -d .git; then \
> -	git config include.path ../etc/git/gitconfig; \
> +	git config --add include.path ../etc/git/gitconfig; \
>  	fi

Installed, thank you!

-- 
Thanks,
Maxim

[Message part 3 (message/rfc822, inline)]

From: Mekeor Melire <mekeor <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] Makefile.am: Use --add flag to "git config".
Date: Sun,  7 May 2023 10:43:41 +0000

Without the "--add" flag to "git config include.path ...", the command fails
if the user already has a configuration entry of "include.path".
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 8af69f88ac..13718e4353 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1121,7 +1121,7 @@ cuirass-jobs: $(GOBJECTS)
 
 .git/config: etc/git/gitconfig
 	$(AM_V_at)if command -v git >/dev/null && test -d .git; then \
-	git config include.path ../etc/git/gitconfig; \
+	git config --add include.path ../etc/git/gitconfig; \
 	fi
 
 nodist_noinst_DATA = .git/hooks/pre-push .git/config

base-commit: fccb48d2cec6bcf47647c82914f31e2dff617f9c
-- 
2.39.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.