GNU bug report logs - #63343
30.0.50; generated mode function will error if mode name contains '%'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Subject: bug#63343: closed (Re: bug#63343: 30.0.50; generated mode
 function will error if mode name contains '%')
Date: Sun, 07 May 2023 13:39:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#63343: 30.0.50; generated mode function will error if mode name contains '%'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 63343 <at> debbugs.gnu.org.

-- 
63343: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63343
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 63343-done <at> debbugs.gnu.org, iarchivedmywholelife <at> gmail.com
Subject: Re: bug#63343: 30.0.50; generated mode function will error if mode
 name contains '%'
Date: Sun, 07 May 2023 16:39:06 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: No Wayman <iarchivedmywholelife <at> gmail.com>,  63343 <at> debbugs.gnu.org
> Date: Sun, 07 May 2023 09:30:57 -0400
> 
> >> -			(message ,(format "%s %%sabled%%s" pretty-name)
> >> +			(message "%s %sabled%s" ,pretty-name
> 
> Ugh!
> 
> > Stefan, any objections to installing this on the release branch?
> 
> Not at all.

Thanks, installed on emacs-29, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; generated mode function will error if mode name contains '%'
Date: Sat, 06 May 2023 23:46:10 -0400

[Message part 4 (text/plain, inline)]

Mode functions generated via `define-minor-mode' will signal an 
error when messaging a mode's "pretty" name contains "%".

To reproduce:

1. eval: (define-minor-mode 100%-failure-mode "oops")
2. enable or disable the mode.

The line responsible for the error is:

(message ,(format "%s %%sabled%%s" pretty-name) 
        (if ,getter "en" "dis") local)))))

The attached patch fixes the issue for me.

[0001-define-minor-mode-sanitize-mode-function-messages.patch (text/x-patch, attachment)]

[Message part 6 (text/plain, inline)]

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.37, cairo version 1.17.8) of 2023-04-14 built on nbook
Repository revision: dc842a71ed035dab1115f2e67d35dd07410e18be
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 
11.0.12101008
System Description: Arch Linux

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.