From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 00:09:31 2023 Received: (at submit) by debbugs.gnu.org; 7 May 2023 04:09:31 +0000 Received: from localhost ([127.0.0.1]:36145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvViF-0003TU-9q for submit@debbugs.gnu.org; Sun, 07 May 2023 00:09:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:43516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvViA-0003TK-9f for submit@debbugs.gnu.org; Sun, 07 May 2023 00:09:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvViA-0008Pa-4T for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 00:09:26 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvVi6-0006p1-FP for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 00:09:24 -0400 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-61b72fd8cc0so16768786d6.3 for ; Sat, 06 May 2023 21:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683432561; x=1686024561; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=rrWkjXgOxne6WGYVku74DLmny6QpNPUm4K0XXeOpmo4=; b=mV5RcbgyPsBWuiGe/1lgJMosnzrWQAPmS7B5BYW6FKROgFaMl571NCBdji5zQ2c4U2 d4jR0uszCLaVh9L5lwzZ/Ne3L4r5qc3k10l46zVU0+N0gyk0yPdCIo/lf4kQk3NJarGw vbVxPtTne5zybh8rWoJDssPb27vri+7HP+rs3TkYQY7AULgMVPHMIEM7A4OqTSA0m5RF 4dwy2H4GAp57sx7tMBtsWmS6X5s2gQjyJq7z1w6tv2Li/tlsM+q8ZLwzAVwbHU7Si+OT LztkTeojgSMS86v/fzXH/rws3TVC1l/+EsEgpkPcbDKKNlUg0QLPmCJmcyiknPGLOT8E 8fOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683432561; x=1686024561; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rrWkjXgOxne6WGYVku74DLmny6QpNPUm4K0XXeOpmo4=; b=aO4tD3K9WkaPXINUz2ehn98M7MvQW6+PLNOP/hgwsBWcTIZoEIodlhufsEOitscLKS xBKgZkUcm2P3aq8ebvWMaoIsQzw2FNI5L8NIS6+Z8m3g4rD2Izb8mZ8WZxtD8wQNE+m8 mu1EGG7LqB1GtzIa2FNlgZA7W01FBfPpW6MfVF/dVgyop38QZ5yTS1ywUI2D2Lwjnd2E oF6U7PP0i9YcGuryDfanpY0TTnm7X/OxwV0sVGjeX1ok3Nzipjod+1QNHOzmknfITr4v J8xCLis35q77xRphIzaoPdwtFA7AysEBSMd7UJ4DT3F3sXKmDJdTe7w2AA/b4ITpdVuQ uQ2g== X-Gm-Message-State: AC+VfDzxQiyMaSjVkEKNLBpxMmADeYUoSG6EKrXG5lC5TKaBGaZCq2zR DDiMn40ocNyZMETJn/SQhcpe4E2qZ/c= X-Google-Smtp-Source: ACHHUZ4piOCENmorvf/xJwiP+m7FlKuHZFNhT/8rVldY4y4KvcvJ98c70lxKVjmHpniZQb52UhR9/w== X-Received: by 2002:a05:6214:410d:b0:5ef:33af:762 with SMTP id kc13-20020a056214410d00b005ef33af0762mr8444424qvb.37.1683432560538; Sat, 06 May 2023 21:09:20 -0700 (PDT) Received: from nbook ([2601:84:847f:c697:8a6b:6703:a961:212b]) by smtp.gmail.com with ESMTPSA id d10-20020a0ce44a000000b005ef493c6bebsm743304qvm.77.2023.05.06.21.09.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 21:09:19 -0700 (PDT) User-agent: mu4e 1.11.4; emacs 30.0.50 From: No Wayman To: bug-gnu-emacs@gnu.org Subject: 30.0.50; generated mode function will error if mode name contains '%' Date: Sat, 06 May 2023 23:46:10 -0400 Message-ID: <87zg6gpypm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qv1-xf30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed Mode functions generated via `define-minor-mode' will signal an error when messaging a mode's "pretty" name contains "%". To reproduce: 1. eval: (define-minor-mode 100%-failure-mode "oops") 2. enable or disable the mode. The line responsible for the error is: (message ,(format "%s %%sabled%%s" pretty-name) (if ,getter "en" "dis") local))))) The attached patch fixes the issue for me. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-define-minor-mode-sanitize-mode-function-messages.patch >From eb3b41cb4237352aca68e5b14e528cb854c4ab5a Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Sun, 7 May 2023 00:06:18 -0400 Subject: [PATCH] define-minor-mode: sanitize mode function messages * emacs-lisp/easy-mmode.el (define-minor-mode): Ensure mode's pretty name is not interprted as a message formatting string. e.g. if the mode name contains a '%'. --- lisp/emacs-lisp/easy-mmode.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el index 84e131147cd..3c6a215c9dc 100644 --- a/lisp/emacs-lisp/easy-mmode.el +++ b/lisp/emacs-lisp/easy-mmode.el @@ -391,7 +391,7 @@ define-minor-mode (not (equal ,last-message (current-message)))) (let ((local ,(if globalp "" " in current buffer"))) - (message ,(format "%s %%sabled%%s" pretty-name) + (message "%s %sabled%s" ,pretty-name (if ,getter "en" "dis") local))))) ,@(when after-hook `(,after-hook))) (force-mode-line-update) -- 2.40.0 --=-=-= Content-Type: text/plain; format=flowed In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.17.8) of 2023-04-14 built on nbook Repository revision: dc842a71ed035dab1115f2e67d35dd07410e18be Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Arch Linux --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 01:38:07 2023 Received: (at 63343) by debbugs.gnu.org; 7 May 2023 05:38:07 +0000 Received: from localhost ([127.0.0.1]:36201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvX5z-00065f-GJ for submit@debbugs.gnu.org; Sun, 07 May 2023 01:38:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvX5x-000659-5x for 63343@debbugs.gnu.org; Sun, 07 May 2023 01:38:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvX5r-0007to-VG; Sun, 07 May 2023 01:37:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0VI7WTpa+Hy3KZAiU9f3+cwi6xFsujXWEWddE+3c2OU=; b=MClNAoqxIF3P CUHvuB1VXPXb990GAUYsnxsYfgp1ijdfj0CAFO/KgsSWQXwJes797BXjTz5yCzu4PcBdd7iYwr942 cpH+yXcryHWRbOS5LlfdetAm62SVU/RDObBtfyRfRrLB5ht2noUftGZ87uzjVobD7FsBFH1Ebf5TH yMrGN0L5lVbD2NsJw0sU78Snmgk2E4HiW6djaQOxmDPcMoMNHG/dq3icYdO/A7Plrf/0OlEnvzeVz NSvL5o3Hf+lJs8mLJqDEQLPpmgbXYyfJPvkqRFxa6ODBs38Ov4/UxEEmV7y5iGKJJaEd5ekjLMgvJ 2FkVD0hjpleOkyBMv3QvAw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvX5r-00051K-F3; Sun, 07 May 2023 01:37:59 -0400 Date: Sun, 07 May 2023 08:38:57 +0300 Message-Id: <83wn1kem4u.fsf@gnu.org> From: Eli Zaretskii To: No Wayman , Stefan Monnier In-Reply-To: <87zg6gpypm.fsf@gmail.com> (message from No Wayman on Sat, 06 May 2023 23:46:10 -0400) Subject: Re: bug#63343: 30.0.50; generated mode function will error if mode name contains '%' References: <87zg6gpypm.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63343 Cc: 63343@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: No Wayman > Date: Sat, 06 May 2023 23:46:10 -0400 > > Mode functions generated via `define-minor-mode' will signal an > error when messaging a mode's "pretty" name contains "%". > > To reproduce: > > 1. eval: (define-minor-mode 100%-failure-mode "oops") > 2. enable or disable the mode. > > The line responsible for the error is: > > (message ,(format "%s %%sabled%%s" pretty-name) > (if ,getter "en" "dis") local))))) > > The attached patch fixes the issue for me. > > >From eb3b41cb4237352aca68e5b14e528cb854c4ab5a Mon Sep 17 00:00:00 2001 > From: Nicholas Vollmer > Date: Sun, 7 May 2023 00:06:18 -0400 > Subject: [PATCH] define-minor-mode: sanitize mode function messages > > * emacs-lisp/easy-mmode.el (define-minor-mode): Ensure mode's pretty > name is not interprted as a message formatting string. e.g. if the > mode name contains a '%'. > --- > lisp/emacs-lisp/easy-mmode.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el > index 84e131147cd..3c6a215c9dc 100644 > --- a/lisp/emacs-lisp/easy-mmode.el > +++ b/lisp/emacs-lisp/easy-mmode.el > @@ -391,7 +391,7 @@ define-minor-mode > (not (equal ,last-message > (current-message)))) > (let ((local ,(if globalp "" " in current buffer"))) > - (message ,(format "%s %%sabled%%s" pretty-name) > + (message "%s %sabled%s" ,pretty-name > (if ,getter "en" "dis") local))))) > ,@(when after-hook `(,after-hook))) > (force-mode-line-update) > -- Thanks. Stefan, any objections to installing this on the release branch? From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 09:31:07 2023 Received: (at 63343) by debbugs.gnu.org; 7 May 2023 13:31:07 +0000 Received: from localhost ([127.0.0.1]:36732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveTj-0005Ds-BE for submit@debbugs.gnu.org; Sun, 07 May 2023 09:31:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveTh-0005DY-P1 for 63343@debbugs.gnu.org; Sun, 07 May 2023 09:31:06 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 19D8B80937; Sun, 7 May 2023 09:31:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DD0C6807AF; Sun, 7 May 2023 09:30:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683466258; bh=BsgllzWXZY4aWGxXgDdxvcZ6Yn7jrPT+vjUPdNM+c6o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Se3HhYwWdBbNIRF+5ZMMXEZWQ5EqgJyPDqAMdZSrBxnSzZ7eRpcpgsR65IKSA3Gxo oAxNR8Bceocc9u468uhQIdgMgfeex/8ytyVjePQoGLCgPUxMow0QWAo+51srVmeytn G6yrWfgEw/GXfhmL1ks+pKbyYX6dEC4QTPUjIXf+6VsYjwLbqshab0r9IXtMJUyl9P q5N1fNyBQYGouKeXgiXxCy8uuZpI0yVEMC8EzcShVzAFdbWpP0V2Cq90c9MlmhWdg2 HBJrL/rtiLr6EDFC5GKxUJc4plil8eda/HBwZK4XEVx6/CpQxeZoCMNiph/I71P5Xy VKb0rNP/JV6PA== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8AA781204E9; Sun, 7 May 2023 09:30:58 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#63343: 30.0.50; generated mode function will error if mode name contains '%' In-Reply-To: <83wn1kem4u.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 May 2023 08:38:57 +0300") Message-ID: References: <87zg6gpypm.fsf@gmail.com> <83wn1kem4u.fsf@gnu.org> Date: Sun, 07 May 2023 09:30:57 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63343 Cc: 63343@debbugs.gnu.org, No Wayman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - (message ,(format "%s %%sabled%%s" pretty-name) >> + (message "%s %sabled%s" ,pretty-name Ugh! > Stefan, any objections to installing this on the release branch? Not at all. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 09:38:16 2023 Received: (at 63343-done) by debbugs.gnu.org; 7 May 2023 13:38:16 +0000 Received: from localhost ([127.0.0.1]:36737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveae-0005OJ-6m for submit@debbugs.gnu.org; Sun, 07 May 2023 09:38:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveab-0005O6-Oq for 63343-done@debbugs.gnu.org; Sun, 07 May 2023 09:38:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveaW-0003fX-60; Sun, 07 May 2023 09:38:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n7zIvPhIREZrDN9JsTD5f400i56ScLhVL4X0Qvp6YDo=; b=qhpIT4th8fWk lKEd8dwWAkqfIslEJwIq592cwLnPkqNzvMbMo8kc2rDqF9opKx+QiIuN4i/AU/DFlCr/eQHRW1Rgt 0so4INc988kz0EEl6KU1fpRYWFY06Wwd+7LcZsVE2c4T2gE7jQfnGvxPiBntJlrdTtr9iiX/Noqd2 MClKFzzknYtxIqRB0IOwH/P9BB5pzLp97VOxlPwWA9mQQE/kThuTkF0L3PVnc2pDPboXo3Q4ayR/j 8w+h5thgRlcDTWnVVp5q+K575rZx9CKYTDVvg1gOhGcHCHuoYnXmkmhu8rnoTYnQsqsPZHqJ2Y/o4 s+CKzB7iUQK+AWNwVYztBA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveaV-0004rK-M4; Sun, 07 May 2023 09:38:07 -0400 Date: Sun, 07 May 2023 16:39:06 +0300 Message-Id: <83bkiwdzwl.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 07 May 2023 09:30:57 -0400) Subject: Re: bug#63343: 30.0.50; generated mode function will error if mode name contains '%' References: <87zg6gpypm.fsf@gmail.com> <83wn1kem4u.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63343-done Cc: 63343-done@debbugs.gnu.org, iarchivedmywholelife@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: No Wayman , 63343@debbugs.gnu.org > Date: Sun, 07 May 2023 09:30:57 -0400 > > >> - (message ,(format "%s %%sabled%%s" pretty-name) > >> + (message "%s %sabled%s" ,pretty-name > > Ugh! > > > Stefan, any objections to installing this on the release branch? > > Not at all. Thanks, installed on emacs-29, and closing the bug. From unknown Sun Jun 22 07:58:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Jun 2023 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator