GNU bug report logs - #63333
[PATCH] Add hurd-amd64 support

Previous Next

Package: diffutils;

Reported by: Samuel Thibault <samuel.thibault <at> ens-lyon.org>

Date: Sat, 6 May 2023 18:34:02 UTC

Severity: normal

Tags: fixed, patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-diffutils <at> gnu.org, bug-grep <at> gnu.org, bug-hurd <at> gnu.org
Cc: "bug-gnulib <at> gnu.org List" <bug-gnulib <at> gnu.org>, 63333 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#63333: [PATCH] Add hurd-amd64 support
Date: Mon, 8 May 2023 12:30:49 +0200
On Sat, May 6, 2023 at 8:34 PM Samuel Thibault
<samuel.thibault <at> ens-lyon.org> wrote:
> This adds SIGSEGV_FAULT_STACKPOINTER for the hurd-amd64 case
>
> --- ./lib/sigsegv.c.original    2023-05-05 10:45:54.673751100 +0000
> +++ ./lib/sigsegv.c     2023-05-05 10:48:47.903577554 +0000
> @@ -351,6 +351,17 @@
>     "old esp, if trapped from user".  */
>  #  define SIGSEGV_FAULT_STACKPOINTER  scp->sc_uesp
>
> +# elif defined __x86_64__
> +
> +/* scp points to a 'struct sigcontext' (defined in
> +   glibc/sysdeps/mach/hurd/x86_64/bits/sigcontext.h).
> +   The registers of this struct get pushed on the stack through
> +   gnumach/x86_64/i386/locore.S:trapall.  */
> +/* Both sc_rsp and sc_ursp appear to have the same value.
> +   It appears more reliable to use sc_ursp because it is labelled as
> +   "old rsp, if trapped from user".  */
> +#  define SIGSEGV_FAULT_STACKPOINTER  scp->sc_ursp
> +
>  # endif
>
>  #endif

Hi Samuel, thanks. This belongs in gnulib, so cc'ing that list.




This bug report was last modified 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.