Subject: Re: bug#63330: [PATCH 0/4] Functional programming? In my C++?! It's more likely than you think!

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 07 May 2023 11:34:10 -0400

Hi Liliana,

Liliana Marie Prikler <[email-masked]> writes:

> * gnu/packages/cpp.scm (lager): New variable.
> ---
>  gnu/packages/cpp.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 0ab7d0785b..fe6a0edd31 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -101,6 +101,7 @@ (define-module (gnu packages cpp)
>    #:use-module (gnu packages web)
>    #:use-module (gnu packages xml)
>    #:use-module (gnu packages xorg)
> +  #:autoload   (gnu packages serialization) (cereal)
>    #:use-module (ice-9 match))

Does autoload buys us something here?  Otherwise I'd stick with the
conventional use-module, to avoid future instances of cargo-culting :-).

In my opinion, that's a direction that should be pursued in Guile
(autoloading modules by default when declarative modules (no side
effects allowed) are used) rather than in every Guile applications out
there.

Otherwise this series LGTM, with the minor comments I left earlier taken
into account.

-- 
Thanks,
Maxim