Subject: bug#63325: closed (Re: [bug#63325] [PATCH] gnu: vulkan-loader: Only run tests on x86.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 15 May 2023 19:05:02 +0000

Your bug report

#63325: [PATCH] gnu: vulkan-loader: Only run tests on x86.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
63325: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63325
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#63325] [PATCH] gnu: vulkan-loader: Only run tests on x86.
From: Efraim Flashner <[email-masked]>
To: Simon Tournier <[email-masked]>
Cc: [email-masked], Christopher Baines <[email-masked]>, Simon South <[email-masked]>
Date: Mon, 15 May 2023 22:04:37 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

On Thu, May 11, 2023 at 02:59:57PM +0200, Simon Tournier wrote:
> Hi,
> 
> On mar., 09 mai 2023 at 16:53, Simon South <[email-masked]> wrote:
> 
> > https://issues.guix.gnu.org/63400
> 
> I am in favor to close this submission and consider #63400.  Chris,
> WDYT?

Having come to basically the same patch (sorry Chris!) and having pushed
it, I'm going to close this patch and we can continue in 63400, which so
far has us skipping enough tests to pass on aarch64 but still fail on
other architectures.

-- 
Efraim Flashner   <[email-masked]>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH] gnu: vulkan-loader: Only run tests on x86.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Date: Sat, 6 May 2023 10:04:18 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/vulkan.scm (vulkan-loader)[arguments]: Only run tests on x86.
---
 gnu/packages/vulkan.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index b0d968938b..f03c3dbc6f 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -228,8 +228,10 @@ (define-public vulkan-loader
     (build-system cmake-build-system)
     (arguments
      (list
-      #:tests? (not (or (%current-target-system)
-                        (target-riscv64?)))
+      ;; TODO: Some tests seem to assume running on x86,
+      ;; e.g. TryLoadWrongBinaries
+      #:tests? (and (target-x86?)
+                    (not (%current-target-system)))
       #:configure-flags
       #~(list (string-append "-DVULKAN_HEADERS_INSTALL_DIR="
                              (dirname (dirname

base-commit: 64086a4fa449a9f6d2f835fcdf5498222b309e3a
-- 
2.39.1