From unknown Fri Aug 15 20:02:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63318: Variable ediff-auto-refine doesn't always default to "on" Resent-From: Peter Oliver Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 20:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 63318@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168331812825185 (code B ref -1); Fri, 05 May 2023 20:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 May 2023 20:22:08 +0000 Received: from localhost ([127.0.0.1]:57621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1wK-0006Y1-LA for submit@debbugs.gnu.org; Fri, 05 May 2023 16:22:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:50990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1wG-0006XY-4v for submit@debbugs.gnu.org; Fri, 05 May 2023 16:22:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv1wF-0004SY-O7 for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:21:59 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv1wD-00028H-6d for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:21:59 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f19323259dso22558535e9.3 for ; Fri, 05 May 2023 13:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; t=1683318113; x=1685910113; h=mime-version:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=DRIvNO60KV7QqmCk0TE5/E6e/i9b9X+/zLxIdKQU6tQ=; b=qKDmPiuq7m4YWLSN0D+2R8gwCQeN9jDEzRX96wrEeevuTl/qRNxqY4qbpvmvhvw/fd /BFsopvEPQAU3x1/HEkqootjcp6cqmvvrHAQYbsl9CkZ71w7JsmrBTW78ufEOgaFDkSS BuaIJ4RkMaV/fHCGEHpujInRKltlv8yp3vePI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683318113; x=1685910113; h=mime-version:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DRIvNO60KV7QqmCk0TE5/E6e/i9b9X+/zLxIdKQU6tQ=; b=kAHxdzxJt70bH8AotWpFS7CKTrEnFtAIxMjcfrCqov2UyMBnwT0yAlAIFZRHzkbpOY +8kQF4u1vMthcwqjGUi3g+RtPr1tIYUxASu1EwJQ/c6dxwlK1ICEF27iItA7OKh+YK/I 87yGX+UFDDVWXB8C84EtVMOqHtsF5uXNgMJj91ZZpRqW2OmPbgN0nugFJ2M3NBHsyof/ yRwQN3LiruP+gm7GLi+ezagvN/Kg0ol4ZBm7Rx5vJfIq6IcW1oJjgNiUixrx+wHazQHE W6vNm7y60AifBPdhO6kf0bedfoHBd2zNKIycYksuzGn6EybjX6/5POcTsRSAdEKiEcQv IZHg== X-Gm-Message-State: AC+VfDw4rmOgKl/NBvVSM9Viut8McnBcN5yYXCyZh61E3cl8f7evxD6M KdVpvwTfSX0VrsWPxsusG7NUjL0rWh77D0G4fes= X-Google-Smtp-Source: ACHHUZ7IcV8ZR//L2SMUEGY2FU4Ncbri45qCG76lP09OaN8EQVhUZ++tD+V2HUwKdc+aRNuLg25+YA== X-Received: by 2002:adf:de05:0:b0:307:8126:5e30 with SMTP id b5-20020adfde05000000b0030781265e30mr1977500wrm.38.1683318112821; Fri, 05 May 2023 13:21:52 -0700 (PDT) Received: from froglet.home.mavit.org.uk (dudl-14-b2-v4wan-165814-cust1925.vm31.cable.virginm.net. [82.34.135.134]) by smtp.gmail.com with ESMTPSA id d3-20020adfef83000000b0030469635629sm3326558wro.62.2023.05.05.13.21.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 13:21:52 -0700 (PDT) Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.17.1/8.17.1) with ESMTPS id 345KLp8H028132 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Fri, 5 May 2023 21:21:51 +0100 Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.17.1/8.17.1/Submit) with ESMTP id 345KLocS028129 for ; Fri, 5 May 2023 21:21:51 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs Date: Fri, 5 May 2023 21:21:50 +0100 (BST) From: Peter Oliver Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811583-111199027-1683318111=:5270" Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=p.d.oliver@mavit.org.uk; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-111199027-1683318111=:5270 Content-Type: text/plain; format=flowed; charset=US-ASCII Severity: minor Tags: patch Document that variable ediff-auto-refine doesn't always default to "on". -- Peter Oliver ---1463811583-111199027-1683318111=:5270 Content-Type: text/plain; charset=UTF-8; name=0001-Variable-ediff-auto-refine-doesn-t-always-default-to.patch Content-Transfer-Encoding: BASE64 Content-ID: <9b70eb0e-63cd-92d2-29dd-5f856a7b0ea1@froglet.home.mavit.org.uk> Content-Description: Content-Disposition: attachment; filename=0001-Variable-ediff-auto-refine-doesn-t-always-default-to.patch RnJvbSAyOGIxMzUwNTI3YWRjOWE5YmEzNTc1Mzc4Y2JhYzMxNzExZmZhMDU2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogRnJpLCA1IE1heSAyMDIzIDIx OjE2OjUxICswMTAwDQpTdWJqZWN0OiBbUEFUQ0hdIFZhcmlhYmxlIGVkaWZm LWF1dG8tcmVmaW5lIGRvZXNuJ3QgYWx3YXlzIGRlZmF1bHQgdG8gIm9uIg0K TUlNRS1WZXJzaW9uOiAxLjANCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsg Y2hhcnNldD1VVEYtOA0KQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJp dA0KDQoqIGRvYy9taXNjL2VkaWZmLnRleGkgKFJlZmluZW1lbnQgb2YgRGlm ZmVyZW5jZSBSZWdpb25zKTogbWVudGlvbiB0aGF0DQrigJxvbuKAnSBpcyB0 aGUgZGVmYXVsdCBmb3IgZWRpZmYtYXV0by1yZWZpbmUgb25seSBvbiBzdWl0 YWJsZSBkaXNwbGF5cy4NCi0tLQ0KIGRvYy9taXNjL2VkaWZmLnRleGkgfCAy ICstDQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9kb2MvbWlzYy9lZGlmZi50ZXhpIGIv ZG9jL21pc2MvZWRpZmYudGV4aQ0KaW5kZXggY2U2Y2I4YzliZDYuLjgyYmIw M2ZlMjAxIDEwMDY0NA0KLS0tIGEvZG9jL21pc2MvZWRpZmYudGV4aQ0KKysr IGIvZG9jL21pc2MvZWRpZmYudGV4aQ0KQEAgLTE3ODMsNyArMTc4Myw3IEBA IFJlZmluZW1lbnQgb2YgRGlmZmVyZW5jZSBSZWdpb25zDQogQHZpbmRleCBl ZGlmZi1hdXRvLXJlZmluZQ0KIFRoaXMgdmFyaWFibGUgY29udHJvbHMgd2hl dGhlciBmaW5lIGRpZmZlcmVuY2VzIHdpdGhpbiByZWdpb25zIGFyZQ0KIGhp Z2hsaWdodGVkIGF1dG9tYXRpY2FsbHkgKGBgYXV0by1yZWZpbmluZycnKS4g IFRoZSBkZWZhdWx0IGlzIHllcw0KLShAc2FtcHtvbn0pLg0KKyhAc2FtcHtv bn0pIG9uIHN1aXRhYmxlIGRpc3BsYXlzLg0KIA0KIE9uIGEgc2xvdyBtYWNo aW5lLCBhdXRvbWF0aWMgcmVmaW5lbWVudCBtYXkgYmUgcGFpbmZ1bC4gIElu IHRoYXQgY2FzZSwNCiB5b3UgY2FuIHR1cm4gYXV0by1yZWZpbmluZyBvbiBv ciBvZmYgaW50ZXJhY3RpdmVseSBieSB0eXBpbmcNCi0tIA0KMi40MC4xDQoN Cg== ---1463811583-111199027-1683318111=:5270-- From unknown Fri Aug 15 20:02:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63318: Variable ediff-auto-refine doesn't always default to "on" Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 06:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Peter Oliver Cc: 63318@debbugs.gnu.org Received: via spool by 63318-submit@debbugs.gnu.org id=B63318.16833537997194 (code B ref 63318); Sat, 06 May 2023 06:17:02 +0000 Received: (at 63318) by debbugs.gnu.org; 6 May 2023 06:16:39 +0000 Received: from localhost ([127.0.0.1]:58051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvBDj-0001ry-Fy for submit@debbugs.gnu.org; Sat, 06 May 2023 02:16:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvBDh-0001rl-N2 for 63318@debbugs.gnu.org; Sat, 06 May 2023 02:16:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvBDc-0000Zv-9A; Sat, 06 May 2023 02:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hWVZ3q9L3nYtKJh+vK86IebMRtblFYzQqdTN0S1h3MI=; b=CiJW7Ozj+au0 GCPe6QgjKR4uDw6DRmToctWuz3njWconbB6wc6fFbaUT9tCNS9Li1Yb+ZSsamqByci2QMG2n+8H2T yQrD3I7VPnVajT7xmtM8JizNkaL26s0LqgctZ4T75jUvfvGA/UI4MZhm2X+uGqbxLVTHeHJ0G8iP+ FbsEobvOMbvDaBNGCO/RaCs4XLlUpd9opbFDvqsBiHUOmU+UC2s6sfIf95cdTb/bgCSCHqgHpBDkd P0fMsCz76OKN/MbissXL0EhEEZ9CCfNgO8LF0EsosY/lC6WGhdKF3Slj/0ab/OrZMhJ8lm56y83CZ xLQYauETnGdCLxyWDaZiZg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvBDb-0008Lu-Ef; Sat, 06 May 2023 02:16:32 -0400 Date: Sat, 06 May 2023 09:17:27 +0300 Message-Id: <83pm7egf0o.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Peter Oliver on Fri, 5 May 2023 21:21:50 +0100 (BST)) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 5 May 2023 21:21:50 +0100 (BST) > From: Peter Oliver > > Document that variable ediff-auto-refine doesn't always default to "on". Wouldn't it be better to instead fix this, so that the default is always "on"? Why doesn't Ediff turn on ediff-auto-refine for all terminals? AFAICT, it only needs faces (basically, colors), and we support that on all terminals nowadays? So I think we should simply change the default value (which will also solve bug#63317). Or what am I missing? From unknown Fri Aug 15 20:02:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63318: Variable ediff-auto-refine doesn't always default to "on" Resent-From: Peter Oliver Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 May 2023 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 63318@debbugs.gnu.org Received: via spool by 63318-submit@debbugs.gnu.org id=B63318.168354161820585 (code B ref 63318); Mon, 08 May 2023 10:27:01 +0000 Received: (at 63318) by debbugs.gnu.org; 8 May 2023 10:26:58 +0000 Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvy53-0005Lx-Tk for submit@debbugs.gnu.org; Mon, 08 May 2023 06:26:58 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:45179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvy52-0005Lg-1e for 63318@debbugs.gnu.org; Mon, 08 May 2023 06:26:56 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f1950f569eso28212845e9.2 for <63318@debbugs.gnu.org>; Mon, 08 May 2023 03:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; t=1683541610; x=1686133610; h=content-id:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GztFei+LI99MG9NPr53W2yD0lI/5Q27SS4OhKt1N4DM=; b=AZz9Hjjw77YD3CNb7nad2fKg6dTumelrRyBQN03bsQr7hC0Tb362+pVC4Uf4TF6oAv GplYSWPg0fTVfojGeM43Dym4Iz8nd3EzF4GnJHXT8P7KmiWFqYlty20MUqQK+PXHF99F 7qfNASn1GAcALIgjRNDJdOdsCubufUm07mtHM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683541610; x=1686133610; h=content-id:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GztFei+LI99MG9NPr53W2yD0lI/5Q27SS4OhKt1N4DM=; b=AQjilXfYaw0rbd+qIYAZoc2APg3JguQFs+fohho1y1wDe6NYooAvgWxsU0DgP7iwYA Lx+tso3YluCwj31hCpYCy1Mg3/nH9gu1aAMZbt7cyDvYO5Bu9ewyvJv9vYDJbxLnS8ah fQc8zrBl3zFneLGFhYDmCyjdxCnLx2kunTJXwlM0dgY4k7Vpno6/o8vhkZkYwbbM28U9 ZRyWHA2LgUuDxuGZX6evSHw3cWRF/LL6jRQiIep4WjoI/aFdkHIjnNElrZO3dgaX9DO6 YfqfIL1S52hyM8Pi5RVc0b6DaBL+b3UjqNrz5jaON21m+MkVZHZZORxnATxC+h2JCXZ/ SGvw== X-Gm-Message-State: AC+VfDyR1D+6Cnl+FVWA0NpRCvsOynNJOCzwLe53Sdy1I7Z66ZmEeYCr thmTv8S9+XLw/HKw5N/Dp3cK+A== X-Google-Smtp-Source: ACHHUZ7MA2Tdh0sZnmjX/S6eg/rEQireo9V1cVGemsWGWDr/Pfj5FcvC4eVhA+JSPElVdSNt6we+NQ== X-Received: by 2002:a7b:cb57:0:b0:3f1:7a4a:7f9 with SMTP id v23-20020a7bcb57000000b003f17a4a07f9mr6801604wmj.7.1683541610096; Mon, 08 May 2023 03:26:50 -0700 (PDT) Received: from froglet.home.mavit.org.uk (dudl-14-b2-v4wan-165814-cust1925.vm31.cable.virginm.net. [82.34.135.134]) by smtp.gmail.com with ESMTPSA id c20-20020a7bc014000000b003ef64affec7sm16357670wmb.22.2023.05.08.03.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 03:26:49 -0700 (PDT) Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.17.1/8.17.1) with ESMTPS id 348AQmWT007610 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 8 May 2023 11:26:48 +0100 Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.17.1/8.17.1/Submit) with ESMTP id 348AQlst007607; Mon, 8 May 2023 11:26:47 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs Date: Mon, 8 May 2023 11:26:47 +0100 (BST) From: Peter Oliver In-Reply-To: <83pm7egf0o.fsf@gnu.org> Message-ID: References: <83pm7egf0o.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-1463811583-1042395094-1683455828=:3752" Content-ID: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-1042395094-1683455828=:3752 Content-Type: text/plain; CHARSET=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Content-ID: <7fd3f068-4384-1679-fe9a-6f37b3ccb798@froglet.home.mavit.org.uk> On Sat, 6 May 2023, Eli Zaretskii wrote: >> Date: Fri, 5 May 2023 21:21:50 +0100 (BST) >> From: Peter Oliver >> >> Document that variable ediff-auto-refine doesn't always default to "on". > > Wouldn't it be better to instead fix this, so that the default is > always "on"? > > Why doesn't Ediff turn on ediff-auto-refine for all terminals? > AFAICT, it only needs faces (basically, colors), and we support that > on all terminals nowadays? So I think we should simply change the > default value (which will also solve bug#63317). Or what am I > missing? I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable. If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me. Attached is a patch to do that instead. -- Peter Oliver ---1463811583-1042395094-1683455828=:3752 Content-Type: text/plain; charset=US-ASCII; name=0001-Always-default-ediff-auto-refine-to-on.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Always-default-ediff-auto-refine-to-on.patch RnJvbSA1MDA4NTBhODJlMDc5NjFkZDk4MTg3NDI4YTVhMTc2OGY1ZTc3Njgy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogTW9uLCA4IE1heSAyMDIzIDEx OjI0OjUzICswMTAwDQpTdWJqZWN0OiBbUEFUQ0hdIEFsd2F5cyBkZWZhdWx0 IGVkaWZmLWF1dG8tcmVmaW5lIHRvICdvbg0KDQoqIGxpc3AvdmMvZWRpZmYt ZGlmZi5lbCAoZWRpZmYtYXV0by1yZWZpbmUpOiBhbHdheXMgZGVmYXVsdCB0 byAnb24uDQotLS0NCiBsaXNwL3ZjL2VkaWZmLWRpZmYuZWwgfCAyICstDQog MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p DQoNCmRpZmYgLS1naXQgYS9saXNwL3ZjL2VkaWZmLWRpZmYuZWwgYi9saXNw L3ZjL2VkaWZmLWRpZmYuZWwNCmluZGV4IDgzMmUzOTMzZGY5Li4wZWU5NzNh NGRlNiAxMDA2NDQNCi0tLSBhL2xpc3AvdmMvZWRpZmYtZGlmZi5lbA0KKysr IGIvbGlzcC92Yy9lZGlmZi1kaWZmLmVsDQpAQCAtMTQyLDcgKzE0Miw3IEBA IGVkaWZmLWRpZmYtc3RhdHVzDQogDQogOzs7IEZpbmUgZGlmZmVyZW5jZXMN CiANCi0oZWRpZmYtZGVmdmFyLWxvY2FsIGVkaWZmLWF1dG8tcmVmaW5lIChp ZiAoZWRpZmYtaGFzLWZhY2Utc3VwcG9ydC1wKSAnb24gJ25peCkNCisoZWRp ZmYtZGVmdmFyLWxvY2FsIGVkaWZmLWF1dG8tcmVmaW5lICdvbikNCiAgICJJ ZiBgb24nLCBFZGlmZiBhdXRvLWhpZ2hsaWdodHMgZmluZSBkaWZmcyBmb3Ig dGhlIGN1cnJlbnQgZGlmZiByZWdpb24uDQogSWYgYG9mZicsIGF1dG8taGln aGxpZ2h0aW5nIGlzIG5vdCB1c2VkLiAgSWYgYG5peCcsIG5vIGZpbmUgZGlm ZnMgYXJlIHNob3duDQogYXQgYWxsLCB1bmxlc3MgdGhlIHVzZXIgZm9yY2Ut cmVmaW5lcyB0aGUgcmVnaW9uIGJ5IGhpdHRpbmcgYConLg0KLS0gDQoyLjQw LjENCg0K ---1463811583-1042395094-1683455828=:3752-- From unknown Fri Aug 15 20:02:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Peter Oliver Subject: bug#63318: closed (Re: bug#63318: Variable ediff-auto-refine doesn't always default to "on") Message-ID: References: <83o7mo9vo9.fsf@gnu.org> X-Gnu-PR-Message: they-closed 63318 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 63318@debbugs.gnu.org Date: Sat, 13 May 2023 14:03:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1683986582-21078-1" This is a multi-part message in MIME format... ------------=_1683986582-21078-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63318: Variable ediff-auto-refine doesn't always default to "on" which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63318@debbugs.gnu.org. --=20 63318: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63318 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1683986582-21078-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63318-done) by debbugs.gnu.org; 13 May 2023 14:02:23 +0000 Received: from localhost ([127.0.0.1]:39196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxppH-0005Sw-1T for submit@debbugs.gnu.org; Sat, 13 May 2023 10:02:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxppF-0005Sg-41 for 63318-done@debbugs.gnu.org; Sat, 13 May 2023 10:02:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxpp9-0006RM-Ji; Sat, 13 May 2023 10:02:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2ve+J9htaqdfjiMZENZ/KwHczsVXRRBOSHI9t7K9bZg=; b=Ir3Fyj6Avdd35yo6pgFa /LLdz7PXGejLWfXajCD8ddCGSa0vfET4okk0q0TSLzmqmUE/M5eQFJtHVFcR4n2GSOgZkhyq1/zPO UAR/zsn361382tGkIFUU+UUPHwGGPeiS7ho/274aQOpTzZ7BOvm6IA+YIqpzqNrb91v5YVly4ZkXO K5Ivb+w4cSxT8fcr1jNQyTNxNfdiQQO5q+8/y5gGimkibRG/8449HUP23nxkNeRoJMF3R50nEMxfP N2K+vBbtC1k7NVJkLzK9k0oC0wKAsySZrnhb/laxvUr/nsAB5Bq225qjTeZVhSnIiE04lAh4/7SPI 4s3N91KPFIxCow==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxpp8-0002ZG-93; Sat, 13 May 2023 10:02:15 -0400 Date: Sat, 13 May 2023 17:02:14 +0300 Message-Id: <83o7mo9vo9.fsf@gnu.org> From: Eli Zaretskii To: Peter Oliver In-Reply-To: (message from Peter Oliver on Mon, 8 May 2023 11:26:47 +0100 (BST)) Subject: Re: bug#63318: Variable ediff-auto-refine doesn't always default to "on" References: <83pm7egf0o.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63318-done Cc: 63318-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 8 May 2023 11:26:47 +0100 (BST) > From: Peter Oliver > cc: 63318@debbugs.gnu.org > > > Why doesn't Ediff turn on ediff-auto-refine for all terminals? > > AFAICT, it only needs faces (basically, colors), and we support that > > on all terminals nowadays? So I think we should simply change the > > default value (which will also solve bug#63317). Or what am I > > missing? > > I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable. > > If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me. Attached is a patch to do that instead. Thanks, installed on the master branch (after applying the necessary fix). Closing the bug. ------------=_1683986582-21078-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 May 2023 20:22:08 +0000 Received: from localhost ([127.0.0.1]:57621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1wK-0006Y1-LA for submit@debbugs.gnu.org; Fri, 05 May 2023 16:22:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:50990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv1wG-0006XY-4v for submit@debbugs.gnu.org; Fri, 05 May 2023 16:22:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv1wF-0004SY-O7 for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:21:59 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv1wD-00028H-6d for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:21:59 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f19323259dso22558535e9.3 for ; Fri, 05 May 2023 13:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; t=1683318113; x=1685910113; h=mime-version:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=DRIvNO60KV7QqmCk0TE5/E6e/i9b9X+/zLxIdKQU6tQ=; b=qKDmPiuq7m4YWLSN0D+2R8gwCQeN9jDEzRX96wrEeevuTl/qRNxqY4qbpvmvhvw/fd /BFsopvEPQAU3x1/HEkqootjcp6cqmvvrHAQYbsl9CkZ71w7JsmrBTW78ufEOgaFDkSS BuaIJ4RkMaV/fHCGEHpujInRKltlv8yp3vePI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683318113; x=1685910113; h=mime-version:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DRIvNO60KV7QqmCk0TE5/E6e/i9b9X+/zLxIdKQU6tQ=; b=kAHxdzxJt70bH8AotWpFS7CKTrEnFtAIxMjcfrCqov2UyMBnwT0yAlAIFZRHzkbpOY +8kQF4u1vMthcwqjGUi3g+RtPr1tIYUxASu1EwJQ/c6dxwlK1ICEF27iItA7OKh+YK/I 87yGX+UFDDVWXB8C84EtVMOqHtsF5uXNgMJj91ZZpRqW2OmPbgN0nugFJ2M3NBHsyof/ yRwQN3LiruP+gm7GLi+ezagvN/Kg0ol4ZBm7Rx5vJfIq6IcW1oJjgNiUixrx+wHazQHE W6vNm7y60AifBPdhO6kf0bedfoHBd2zNKIycYksuzGn6EybjX6/5POcTsRSAdEKiEcQv IZHg== X-Gm-Message-State: AC+VfDw4rmOgKl/NBvVSM9Viut8McnBcN5yYXCyZh61E3cl8f7evxD6M KdVpvwTfSX0VrsWPxsusG7NUjL0rWh77D0G4fes= X-Google-Smtp-Source: ACHHUZ7IcV8ZR//L2SMUEGY2FU4Ncbri45qCG76lP09OaN8EQVhUZ++tD+V2HUwKdc+aRNuLg25+YA== X-Received: by 2002:adf:de05:0:b0:307:8126:5e30 with SMTP id b5-20020adfde05000000b0030781265e30mr1977500wrm.38.1683318112821; Fri, 05 May 2023 13:21:52 -0700 (PDT) Received: from froglet.home.mavit.org.uk (dudl-14-b2-v4wan-165814-cust1925.vm31.cable.virginm.net. [82.34.135.134]) by smtp.gmail.com with ESMTPSA id d3-20020adfef83000000b0030469635629sm3326558wro.62.2023.05.05.13.21.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 13:21:52 -0700 (PDT) Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.17.1/8.17.1) with ESMTPS id 345KLp8H028132 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Fri, 5 May 2023 21:21:51 +0100 Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.17.1/8.17.1/Submit) with ESMTP id 345KLocS028129 for ; Fri, 5 May 2023 21:21:51 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs Date: Fri, 5 May 2023 21:21:50 +0100 (BST) From: Peter Oliver To: bug-gnu-emacs@gnu.org Subject: Variable ediff-auto-refine doesn't always default to "on" Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811583-111199027-1683318111=:5270" Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=p.d.oliver@mavit.org.uk; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-111199027-1683318111=:5270 Content-Type: text/plain; format=flowed; charset=US-ASCII Severity: minor Tags: patch Document that variable ediff-auto-refine doesn't always default to "on". -- Peter Oliver ---1463811583-111199027-1683318111=:5270 Content-Type: text/plain; charset=UTF-8; name=0001-Variable-ediff-auto-refine-doesn-t-always-default-to.patch Content-Transfer-Encoding: BASE64 Content-ID: <9b70eb0e-63cd-92d2-29dd-5f856a7b0ea1@froglet.home.mavit.org.uk> Content-Description: Content-Disposition: attachment; filename=0001-Variable-ediff-auto-refine-doesn-t-always-default-to.patch RnJvbSAyOGIxMzUwNTI3YWRjOWE5YmEzNTc1Mzc4Y2JhYzMxNzExZmZhMDU2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogUGV0ZXIgT2xpdmVy IDxnaXRAbWF2aXQub3JnLnVrPg0KRGF0ZTogRnJpLCA1IE1heSAyMDIzIDIx OjE2OjUxICswMTAwDQpTdWJqZWN0OiBbUEFUQ0hdIFZhcmlhYmxlIGVkaWZm LWF1dG8tcmVmaW5lIGRvZXNuJ3QgYWx3YXlzIGRlZmF1bHQgdG8gIm9uIg0K TUlNRS1WZXJzaW9uOiAxLjANCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsg Y2hhcnNldD1VVEYtOA0KQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJp dA0KDQoqIGRvYy9taXNjL2VkaWZmLnRleGkgKFJlZmluZW1lbnQgb2YgRGlm ZmVyZW5jZSBSZWdpb25zKTogbWVudGlvbiB0aGF0DQrigJxvbuKAnSBpcyB0 aGUgZGVmYXVsdCBmb3IgZWRpZmYtYXV0by1yZWZpbmUgb25seSBvbiBzdWl0 YWJsZSBkaXNwbGF5cy4NCi0tLQ0KIGRvYy9taXNjL2VkaWZmLnRleGkgfCAy ICstDQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9kb2MvbWlzYy9lZGlmZi50ZXhpIGIv ZG9jL21pc2MvZWRpZmYudGV4aQ0KaW5kZXggY2U2Y2I4YzliZDYuLjgyYmIw M2ZlMjAxIDEwMDY0NA0KLS0tIGEvZG9jL21pc2MvZWRpZmYudGV4aQ0KKysr IGIvZG9jL21pc2MvZWRpZmYudGV4aQ0KQEAgLTE3ODMsNyArMTc4Myw3IEBA IFJlZmluZW1lbnQgb2YgRGlmZmVyZW5jZSBSZWdpb25zDQogQHZpbmRleCBl ZGlmZi1hdXRvLXJlZmluZQ0KIFRoaXMgdmFyaWFibGUgY29udHJvbHMgd2hl dGhlciBmaW5lIGRpZmZlcmVuY2VzIHdpdGhpbiByZWdpb25zIGFyZQ0KIGhp Z2hsaWdodGVkIGF1dG9tYXRpY2FsbHkgKGBgYXV0by1yZWZpbmluZycnKS4g IFRoZSBkZWZhdWx0IGlzIHllcw0KLShAc2FtcHtvbn0pLg0KKyhAc2FtcHtv bn0pIG9uIHN1aXRhYmxlIGRpc3BsYXlzLg0KIA0KIE9uIGEgc2xvdyBtYWNo aW5lLCBhdXRvbWF0aWMgcmVmaW5lbWVudCBtYXkgYmUgcGFpbmZ1bC4gIElu IHRoYXQgY2FzZSwNCiB5b3UgY2FuIHR1cm4gYXV0by1yZWZpbmluZyBvbiBv ciBvZmYgaW50ZXJhY3RpdmVseSBieSB0eXBpbmcNCi0tIA0KMi40MC4xDQoN Cg== ---1463811583-111199027-1683318111=:5270-- ------------=_1683986582-21078-1--