GNU bug report logs - #63314
[PATCH 0/2] Add PAM shepherd requirements

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 63314 <at> debbugs.gnu.org
Subject: [bug#63314] [PATCH 0/2] Add PAM shepherd requirements
Date: Mon, 08 May 2023 11:46:14 +0200

Josselin Poiret <dev <at> jpoiret.xyz> skribis:

> From: Josselin Poiret <dev <at> jpoiret.xyz>
>
> * gnu/services/desktop.scm (pam-extension-procedure): Add the elogind shepherd
> requirement to the PAM extender.
> ---
>  gnu/services/desktop.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 3adcfe8e5d..d62536a27e 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -1192,7 +1192,8 @@ (define (pam-extension-procedure config)
>            (lambda (pam)
>              (pam-service
>               (inherit pam)
> -             (session (cons pam-elogind (pam-service-session pam)))))))))
> +             (session (cons pam-elogind (pam-service-session pam))))))
> +         (shepherd-requirements '(elogind)))))

LGTM.

Should we add a greetd system test that catches the bug?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.