GNU bug report logs - #63312
29.0.90; set-frame-parameter sometimes called with dead frame when quitting ediff

Previous Next

Full log

Message #23 received at 63312 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tobias Bading <tbading <at> web.de>, 63312 <at> debbugs.gnu.org
Subject: Re: bug#63312: 29.0.90; set-frame-parameter sometimes called with
 dead frame when quitting ediff
Date: Sat, 06 May 2023 19:12:51 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sat, 6 May 2023 12:10:33 +0200
>> Cc: 63312 <at> debbugs.gnu.org
>> From: Tobias Bading <tbading <at> web.de>
>> 
>> > Does the patch below give good results?
>> >
>> > diff --git a/lisp/x-dnd.el b/lisp/x-dnd.el
>> > index 9286a18..acfbbed 100644
>> > --- a/lisp/x-dnd.el
>> > +++ b/lisp/x-dnd.el
>> > @@ -609,8 +609,9 @@ x-dnd-init-xdnd-for-frame
>> >  (defun x-dnd-after-move-frame (frame)
>> >    "Handle FRAME moving to a different position.
>> >  Clear any cached root window position."
>> > -  (set-frame-parameter frame 'dnd-root-window-position
>> > -                       nil))
>> > +  (and (frame-live-p frame)
>> > +       (set-frame-parameter frame 'dnd-root-window-position
>> > +                            nil)))
>> >
>> >  (add-hook 'move-frame-functions #'x-dnd-after-move-frame)
>> 
>> It probably would, because for testing purposes I already patched
>> handle-move-frame like this:
>
> Not really, because there could be other functions on the hook
> variable, which do deal well with a dead frame.
>
> Po Lu, any objections to installing my proposed change?

Please install on emacs-29, thanks.  This hook should not be called with
a dead frame though, and Martin proposed a fix for that which was
installed last year, so I will continue to investigate on master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.