GNU bug report logs - #63295
[PATCH] Update csvkit to 1.1.1

Previous Next

Package: guix-patches;

Reported by: Alice BRENON <alice.brenon <at> ens-lyon.fr>

Date: Fri, 5 May 2023 10:27:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alice BRENON <alice.brenon <at> ens-lyon.fr>
Subject: bug#63295: closed (Re: bug#62418: [PATCH 0/6] Update csvkit.)
Date: Sun, 14 May 2023 21:01:03 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#63295: [PATCH] Update csvkit to 1.1.1

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 63295 <at> debbugs.gnu.org.

-- 
63295: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63295
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 62418-done <at> debbugs.gnu.org, Alice BRENON <alice.brenon <at> ens-lyon.fr>,
 63295-done <at> debbugs.gnu.org
Subject: Re: bug#62418: [PATCH 0/6] Update csvkit.
Date: Sun, 14 May 2023 23:00:35 +0200
Hi Greg and Alice,

Greg Hogan <code <at> greghogan.com> skribis:

> python-leather, python-agate, and csvkit were failing to build for me on
> the core-updates branch.
>
> Greg Hogan (6):
>   gnu: python-leather: Update to 0.3.4.
>   gnu: python-agate-dbf: Update to 0.2.2.
>   gnu: python-agate-sql: Update to 0.5.9.
>   gnu: Add python-agate-locales.
>   gnu: python-agate: Update to 1.7.1
>   gnu: csvkit: Update to 1.1.1.

It’s been two months but I’ve finally applies this patch series.
Apologies for the delay!

Alice, if you see any further changes that should be made, please send
them as a separate patch on top of this.

Thank you!

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Alice BRENON <alice.brenon <at> ens-lyon.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update csvkit to 1.1.1
Date: Fri, 5 May 2023 12:26:36 +0200
[Message part 4 (text/plain, inline)]
Hello guix,

I use csvkit and noticed it broke after the upgrade to python 3.10

http://ci.guix.gnu.org/build/1263118/details

Updating it and a couple dependencies fixed it so here's a patch. I also
converted the `*-inputs` fields to new style while I was at it.

The addition of `(gnu package base)` among dependencies is because of
`python-agate` now wanting `glibc-locales` for one of its tests. I hate to have
had to write the previous sentence because a `((gnu package base) #:select
(glibc-locales))` would have carried exactly as much information and remained in
the code where it could be useful in the future while this email will be
long-forgotten when someone needs it. But the rest of the imports are implicit
(don't want to break the convention) and someone recently argued again against
explicit imports on the chan. I therefore merely point out another situation
where implicit would have saved the day to be sure not to waste evidence, should
the community want to weigh the benefits and drawbacks of each approach some
day.

Nice day to you all,

Alice
[0001-gnu-csvkit-Update-to-1.1.1.patch (text/x-patch, attachment)]

This bug report was last modified 2 years and 11 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.