GNU bug report logs - #63290
30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...))

Previous Next

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>
Cc: 63290 <at> debbugs.gnu.org
Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...))
Date: Tue, 15 Aug 2023 19:46:35 -0300

[Message part 1 (text/plain, inline)]

Hi Thomas,

Thomas Fitzsimmons <fitzsim <at> fitzsim.org> writes:

> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>>> Can you try this patch with: M-x package-install RET excorporate
>>> RET Then: M-x customize-variable RET excorporate-configuration RET
>>> then select "Value Menu" and 3, which is "EWS URL OAuth 2.0
>>> settings (no autodiscovery)".  With your wis-edit.el patch applied
>>> I still get empty values for:     INS DEL Argument
>>> name:             Argument value:  and:     INS DEL OAuth 2.0
>>> setting name:             OAuth 2.0 setting value:  and when I
>>> apply the setting the value contains:   (... (... (#1# . #1#))
>>> (#1# . #1#)) Maybe this is a more complicated case than the test
>>> case I provided (which does now work for me with your patch)?
>> I think this ammended patch fixes it.  Since we want
>> widget-list-default-get to respect a nil :value property, the alist
>> widget needs to be modified so that its default value is nil.
>
> With the updated patch, when I select "EWS URL OAuth 2.0 settings (no
> autodiscovery)", all the widgets are disabled.  The blank values are
> no longer added though.  However, if I then set the value, without
> configuring anything, excorporate-configuration stays nil. So I don't
> think the patch is correct yet.

So, in case the :value is missing for the alist widget, we want to
compute the default-value with the :options, and without including the
editable-list.

Hopefully the attached patch is 100% correct now.  I did try it with
excorporate-configuration and I think it works OK, but please give it
yourself a try.  And thank you for your patience.

[0001-Specialize-default-get-for-alist-widgets-Bug-63290.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.