From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 02:03:02 2023 Received: (at submit) by debbugs.gnu.org; 5 May 2023 06:03:02 +0000 Received: from localhost ([127.0.0.1]:52956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puoWz-0006uR-PN for submit@debbugs.gnu.org; Fri, 05 May 2023 02:03:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:37670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puoWy-0006u6-6L for submit@debbugs.gnu.org; Fri, 05 May 2023 02:03:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puoWx-0001Wo-Pn for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:02:59 -0400 Received: from mail.fitzsim.org ([69.165.165.189]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puoWv-0003RF-Ka for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PCTnbxONXELjr0ysB6pWSUJT+CkWImkz4szTn+UpDKs=; b=KKXjZy4K6bcUAiqNg0QC/c5P/A P74jpHPFAMTLpioMjaUimQ5ZUCk+fHF3wEfeoxsipPuGAy5NDmeSFIJ873gCcLi1pswwjzd3tX00l l5P+kPkNFkq0mFMNS4o3n/8N0VzAzVJxs0e2OZdNFGqedl4gvpqko3+HX1jv6bFwn0LYYa6iAtDks wBt6UbINB0mLyjr/FmHeDI+bEmbtKzs+rGVfAAAFk9d6C6lCDX+RoyXn4KUoytbLpwDaozNvuXBGd SKuRiH1qt5ABaCiDqw1LcDXA9TqiC+fTahrp7QLCATRiaa5RvajwIXWZqB1FNniLtIleiZgEjLxCa XwW7X1IA==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1puoWs-0003cA-3W for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:02:54 -0400 From: Thomas Fitzsimmons To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Date: Fri, 05 May 2023 02:02:53 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=69.165.165.189; envelope-from=fitzsim@fitzsim.org; helo=mail.fitzsim.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This test case shows the issue: (defcustom test-custom nil "" :type '(choice (alist :key-type (string :tag "key") :value-type (string :tag "value")) (const :tag "auto" nil))) (customize-variable 'test-custom) The UI first shows: Hide Test Custom: Choice: Value Menu Alist: INS State : STANDARD. Then if I choose "Value Menu", and option 1 to choose the "auto" const value, I get: Hide Test Custom: Choice: Value Menu auto State : EDITED, shown value does not take effect until you set or save it. which is fine. Then if I choose "Value Menu" again and choose 0 for the Alist, I get: Hide Test Custom: Choice: Value Menu Alist: INS DEL key: value: INS State : EDITED, shown value does not take effect until you set or save it. I wasn't expecting: INS DEL key: value: If I then save the customization, test-custom is ("" . ""). I think it should instead be nil. I noticed this on excorporate-configuration, which has: (defcustom test-custom nil "" :type '(choice (const :tag "auto" nil) (alist :key-type (string :tag "key") :value-type (string :tag "value")))) but where the alist is a large nested structure. If the user customizes, test-custom, selects the alist, and saves, the structure has degenerate ("" . ""), or (nil . nil) entries in it. To avoid this, the user would have to hit "DEL" on the empty key/value entries, which is not ideal. It seems like after a const is shown, Customize considers the variable "edited". I don't know why it is adding those extra INS/DEL key/value UI boxes though. Thomas From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 09:15:41 2023 Received: (at 63290) by debbugs.gnu.org; 16 Jul 2023 13:15:41 +0000 Received: from localhost ([127.0.0.1]:47051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL1bB-0002Mg-3U for submit@debbugs.gnu.org; Sun, 16 Jul 2023 09:15:41 -0400 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:45459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL1b6-0002MF-SR for 63290@debbugs.gnu.org; Sun, 16 Jul 2023 09:15:40 -0400 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3a04e5baffcso2669612b6e.3 for <63290@debbugs.gnu.org>; Sun, 16 Jul 2023 06:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689513331; x=1692105331; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=EuEGC0t0GuK6IWAHo8+P/T94c6+EfLfZVasRqCS5Dng=; b=JKnTuIbukP8xMA/lc8Y8m9Qx+if9hCboYrok4t5HaIwJPiJ07xL1x2gH4inJUfHSRL 0J6W4xk2JpmRXe7Mro/2pmaAyFXE5j/dtvastPiYOzBs4RTW2vJ40yLRL2+PAbIEphWy e/xx8GrPDR17J5Hc/ihqWGKJgOh+s2f8T5pGusw01CPtmZc1XUSrVkMK2qFa9BT6GzuJ Qt0JA6lal9segtl6Vng32gcex9dJc9KAy3BQlYyHOHV/Ol2nkSKkbbxN67dmuopmaDbO sFIcvVy0y1c9L52s8z6v7R2GfnHk8Ch40s1SUVjBnK3vNHBlmaYWRjHWqqL5c/gIkTHl 1fGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689513331; x=1692105331; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EuEGC0t0GuK6IWAHo8+P/T94c6+EfLfZVasRqCS5Dng=; b=IHkZISEMSdAY3Nq7+bkDDJKi+twfjuw30pA3aDwcY40hi5UhWIHZsIEvrcVRu6BGdf llMwsklIqS3IogyYtXk4IOj2XfK083Pj3DfuTJxIsH/K+8bFJX0Vbu9CONo3mVrEw6GT ljxOd+0WrXBlRDe8lYM96VhTjyCMg4lPzXA+E6OlmtdL4QFHVC+N9kKOgV+f8VTmsAqE hwomM11QRGCbQTP+PXXWK8GKW3fots04TGxubIwm+iw+wzWsYWCIPSQSymsQlFCUkUQy xAMcNGvk22gmSUBzrUWSadyMu6h2WKrxLPFavwPeYmzjbW0HMBHT6BQLV2TOd/pTxqVb 1Vbw== X-Gm-Message-State: ABy/qLYXjZx8tBKImEeGQ6GrHQ00lwol7tW9+9AdkjyTj/uSUD+InrOi Dv3xz/V/ewav32JKClycE1T0ESeZmR1reHAL X-Google-Smtp-Source: APBJJlH0HGgirP/dFcT3aEID0ZOAw8CrkfFDFjr6zgQpmQmDEWNrKsCD9Wa3jmat2nWba+f58QX5Cg== X-Received: by 2002:a05:6808:192a:b0:3a4:26d1:4a9e with SMTP id bf42-20020a056808192a00b003a426d14a9emr11809813oib.38.1689513331147; Sun, 16 Jul 2023 06:15:31 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id y14-20020a056808130e00b003a1f1933957sm5844359oiv.16.2023.07.16.06.15.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 06:15:30 -0700 (PDT) Message-ID: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Date: Sun, 16 Jul 2023 10:15:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Thomas Fitzsimmons From: Mauro Aranda Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > This test case shows the issue: > > (defcustom test-custom nil "" :type >   '(choice (alist >         :key-type (string :tag "key") >         :value-type (string :tag "value")) >            (const :tag "auto" nil))) > (customize-variable 'test-custom) > > The UI first shows: > > Hide Test Custom: Choice: Value Menu Alist: > INS >     State : STANDARD. > > Then if I choose "Value Menu", and option 1 to choose the "auto" const > value, I get: > > Hide Test Custom: Choice: Value Menu auto >     State : EDITED, shown value does not take effect until you set or save it. > > which is fine.  Then if I choose "Value Menu" again and choose 0 for the > Alist, I get: > > Hide Test Custom: Choice: Value Menu Alist: > INS DEL key: >             value: > INS >     State : EDITED, shown value does not take effect until you set or save it. > > I wasn't expecting: > > INS DEL key: >             value: > > If I then save the customization, test-custom is ("" . "").  I think it > should instead be nil. > Thanks for the bug report. > > It seems like after a const is shown, Customize considers the variable > "edited".  I don't know why it is adding those extra INS/DEL key/value > UI boxes though. The code currently ignores the value if it's present but nil. That's not good, obviously.  But it might be tricky to fix it because other widgets depend on the code ignoring it... I think it might be good to have a different property specify a default value (defaulting to :value upon creation, if not provided), and let :value be treated as of today, like the current value holder. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 22:37:31 2023 Received: (at 63290) by debbugs.gnu.org; 17 Jul 2023 02:37:31 +0000 Received: from localhost ([127.0.0.1]:48782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLE79-0004dG-Ei for submit@debbugs.gnu.org; Sun, 16 Jul 2023 22:37:31 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:54288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLE77-0004d2-47 for 63290@debbugs.gnu.org; Sun, 16 Jul 2023 22:37:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=98Vwow1CfXuK6MUk8JyNgAN8qubgZY2jH7YsoVOjuKk=; b=c0kcMbqbZjaa7phKkm8lrhPt7h hRYtwCIfyCKmDbMKwVFePOmLeBQLWP1+OtQrMil00VIodlXRc9c4v0NPWn/iI/m/bo3XeUSRuji42 CvaNI6ZDtDlZ6CENgUyQxsDbhFxJrT0nm9lfgYJW66o5WttGAhjIHc0cRwX95X2pCppT8qX2BoJsh DkWEmCCqwiyLL+iP+Hb3bbfgCitukKGcmQSjLTZEtlBOvNOlmO1lreErSdhWn+39DnEvhxenMFai0 jspcVK1aeTSJVA3yxPdb6ga1eDfBAS8QtWivRb2lwC0CGhD1uv0ZI8r5kXkfDkFW+/rGI1gTOCTzb B9YGbYzA==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qLE70-0012rV-NU; Sun, 16 Jul 2023 22:37:22 -0400 From: Thomas Fitzsimmons To: Mauro Aranda Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) In-Reply-To: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> (Mauro Aranda's message of "Sun, 16 Jul 2023 10:15:26 -0300") References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Date: Sun, 16 Jul 2023 22:37:21 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Thomas Fitzsimmons writes: [...] >> It seems like after a const is shown, Customize considers the >> variable "edited". I don't know why it is adding those extra >> INS/DEL key/value UI boxes though. > > The code currently ignores the value if it's present but > nil. That's not good, obviously. But it might be tricky to fix > it because other widgets depend on the code ignoring it... > > I think it might be good to have a different property specify a > default value (defaulting to :value upon creation, if not > provided), and let :value be treated as of today, like the > current value holder. OK, thanks for taking a look; let me know if you want me to try a patch. Sounds like a good way of maintaining backward compatibility with respect to other widgets. Or you can test it against excorporate-configuration in GNU ELPA; just search for the FIXME that mentions this bug report. Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 09 08:19:49 2023 Received: (at 63290) by debbugs.gnu.org; 9 Aug 2023 12:19:49 +0000 Received: from localhost ([127.0.0.1]:38423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTiAG-00031s-JB for submit@debbugs.gnu.org; Wed, 09 Aug 2023 08:19:48 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:61647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTiAF-00031a-6Y; Wed, 09 Aug 2023 08:19:47 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6bd0425ad4fso1562991a34.2; Wed, 09 Aug 2023 05:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691583581; x=1692188381; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XFytycnOYEKtNscKOLnKsrcwWiHs8SkjHUxz6ZHx12I=; b=Z2xhmShz/ahyl78vc/JDgRg6btZy7NSKWgZG+/KYOTaBovyX6ljzUQVyl/9EHwBc7F j6ZZ5NwVe6n+u9PPEJWBf3joA7oy97/SLjR6UQJ6u32IUFMR1395un62WcECHgYbB0Ew S6D44lYUtiI08Iv8VIWwKlbbyDeIyOHCJb0SIglhrnKU1iN1FlyAUGZHJZvgkr7afkdC ZFOnLEUbxZfun1EvdaHN/j+EjOh66FeByfd+JmsfvlsQ/IplNbNB4fb1p4opjgHvVZd/ tKdrc9vgOG8vOmF0EXn6pug00/VmN3ETMkMqZK2A2R7jXr1+6C/53FJ3XcRgILgrIyid ZD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691583581; x=1692188381; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XFytycnOYEKtNscKOLnKsrcwWiHs8SkjHUxz6ZHx12I=; b=BsF/lxXJEhWvA3Np+kwEZIZ57wyF2JzmL9SjE3vedG4rcXIocK5dIQdEqb00+Jhy16 IGoYrzMwyCv/SxbKINuT26dJ0SxPMFhDL9uUcBfOhxwNgcp8Ay4tffbpYL/pkqdTnqbV 0JojaccIHjCF75fUYoCHonpJqQN7cn9vso1ncQTV0lDJD0D6Ys0uCacssBcjKpaCBHlW aeX3P5IsilXuTxAAvIRH5CjOYcLHHPxEU2JS0Zo2VDKDmSticKr2Lz5SDs+GmHRCt7// dNuE+vaxacY6kiSHPDnK1eVRqmhZ4Mqw+hOlEAFtluKQhEhmM0zNSnjvhgK3+N/fSlE0 L1VQ== X-Gm-Message-State: AOJu0YxEfBhNhcB5HxjtFR07XEonv/aKMP2Xg6Yl9l+ChGOwkv9nhf/a CT9tGmAfORoB7xo6huTGeVyCEOAyxjQ= X-Google-Smtp-Source: AGHT+IGNO92CBW1NMppiD+cpSPa7E6mTj50v2KBy5ns2qmm2LKj1l1jcyloE9VhVnLfFY2IegJ/R7w== X-Received: by 2002:a05:6830:1e1b:b0:6bc:f5fc:ebb9 with SMTP id s27-20020a0568301e1b00b006bcf5fcebb9mr2758993otr.27.1691583581196; Wed, 09 Aug 2023 05:19:41 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id x24-20020a05683000d800b006b8bf76174fsm6862683oto.21.2023.08.09.05.19.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 05:19:40 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------rlOK46iE20fBBRee8w0WzYVR" Message-ID: Date: Wed, 9 Aug 2023 09:19:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Content-Language: en-US From: Mauro Aranda To: Thomas Fitzsimmons , 63290@debbugs.gnu.org References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> In-Reply-To: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 63290 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) This is a multi-part message in MIME format. --------------rlOK46iE20fBBRee8w0WzYVR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit tags 63290 patch quit I ended up adding a custom :default-get function for the list widget, to make it respect a nil value as the :value.  This should be backward compatible with other widgets, and should fix these "ghost" elements insertions. I also added a test for cus-edit-tests. --------------rlOK46iE20fBBRee8w0WzYVR Content-Type: text/x-patch; charset=UTF-8; name="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.patch" Content-Disposition: attachment; filename*0="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlNjRmOWM1NWUxYTFlNTdkZTM3ODNmYmJhYzFiZjIzOWFjMzBiYWJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFdlZCwgOSBBdWcgMjAyMyAwOToxNzo0MyAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIFJlc3BlY3QgdGhlIDp2YWx1ZSBwcm9wZXJ0eSBpbiBhIGxpc3Qgd2lkZ2V0IChC dWcjNjMyOTApCgoqIGxpc3Avd2lkLWVkaXQuZWwgKHdpZGdldC1saXN0LWRlZmF1bHQtZ2V0 KTogTmV3IGZ1bmN0aW9uLgoqIHRlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbCAoY3VzLWVk aXQtdGVzdC1idWctNjMyOTAtb3B0aW9uKTogTmV3CnRlc3Qgb3B0aW9uLgooY3VzLWVkaXQt dGVzdC1idWc2MzI5MCk6IE5ldyB0ZXN0LgotLS0KIGxpc3Avd2lkLWVkaXQuZWwgICAgICAg ICAgICB8IDExICsrKysrKysrKysrCiB0ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwgfCAy NCArKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3Avd2lkLWVkaXQuZWwgYi9saXNwL3dpZC1lZGl0 LmVsCmluZGV4IDQ3NTMxMTEzYmE4Li5jNjA0MjI1ZjEwYSAxMDA2NDQKLS0tIGEvbGlzcC93 aWQtZWRpdC5lbAorKysgYi9saXNwL3dpZC1lZGl0LmVsCkBAIC0zODEyLDggKzM4MTIsMTkg QEAgd2lkZ2V0LWNoYXJhY3Rlci1ub3RpZnkKIChkZWZpbmUtd2lkZ2V0ICdsaXN0ICdncm91 cAogICAiQSBMaXNwIGxpc3QuIgogICA6dGFnICJMaXN0IgorICA6ZGVmYXVsdC1nZXQgIyd3 aWRnZXQtbGlzdC1kZWZhdWx0LWdldAogICA6Zm9ybWF0ICIleyV0JX06XG4ldiIpCiAKKyhk ZWZ1biB3aWRnZXQtbGlzdC1kZWZhdWx0LWdldCAod2lkZ2V0KQorICAiUmV0dXJuIHRoZSBk ZWZhdWx0IGV4dGVybmFsIHZhbHVlIGZvciBhIGxpc3QgV0lER0VULgorCitUaGUgZGVmYXVs dCB2YWx1ZSBpcyB0aGUgb25lIHN0b3JlZCBpbiB0aGUgOnZhbHVlIHByb3BlcnR5LCBldmVu IGlmIGl0IGlzIG5pbCwKK29yIGEgbGlzdCB3aXRoIHRoZSBkZWZhdWx0IHZhbHVlIG9mIGVh Y2ggY29tcG9uZW50IG9mIHRoZSBsaXN0IFdJREdFVC4iCisgICh3aWRnZXQtYXBwbHkgd2lk Z2V0IDp2YWx1ZS10by1leHRlcm5hbAorICAgICAgICAgICAgICAgIChpZiAod2lkZ2V0LW1l bWJlciB3aWRnZXQgOnZhbHVlKQorICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWdldCB3 aWRnZXQgOnZhbHVlKQorICAgICAgICAgICAgICAgICAgKHdpZGdldC1ncm91cC1kZWZhdWx0 LWdldCB3aWRnZXQpKSkpCisKIChkZWZpbmUtd2lkZ2V0ICd2ZWN0b3IgJ2dyb3VwCiAgICJB IExpc3AgdmVjdG9yLiIKICAgOnRhZyAiVmVjdG9yIgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNw L2N1cy1lZGl0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2N1cy1lZGl0LXRlc3RzLmVsCmluZGV4 IGVjYTM1ZDdjOTZhLi43NWQ1ZjMyYzQyMSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2N1cy1l ZGl0LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbApAQCAtOTIs NSArOTIsMjkgQEAgdGVzdC1zZXRvcHQKICAgICAgICAgICAgIChidWZmZXItc3Vic3RyaW5n LW5vLXByb3BlcnRpZXMgKHBvaW50LW1pbikgKHBvaW50LW1heCkpKSkpCiAgICAgKHNob3Vs ZCAoc3RyaW5nLXNlYXJjaCAiVmFsdWUgYDpmb28nIGRvZXMgbm90IG1hdGNoIHR5cGUgbnVt YmVyIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgd2Fybi10eHQpKSkpCisKKyhkZWZj dXN0b20gY3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24gbmlsCisgICJDaG9pY2Ugb3B0 aW9uIGZvciB0ZXN0aW5nIEJ1ZyM2MzI5MC4iCisgIDp0eXBlICcoY2hvaWNlIChhbGlzdAor ICAgICAgICAgICAgICAgICAgOmtleS10eXBlIChzdHJpbmcgOnRhZyAia2V5IikKKyAgICAg ICAgICAgICAgICAgIDp2YWx1ZS10eXBlIChzdHJpbmcgOnRhZyAidmFsdWUiKSkKKyAgICAg ICAgICAgICAgICAgKGNvbnN0IDp0YWcgImF1dG8iIGF1dG8pKSkKKworKGVydC1kZWZ0ZXN0 IGN1cy1lZGl0LXRlc3QtYnVnNjMyOTAgKCkKKyAgIlRlc3QgdGhhdCBjaGFuZ2luZyBhIGNo b2ljZSB2YWx1ZSBiYWNrIHRvIGFuIGFsaXN0IHJlc3BlY3RzIGl0cyBuaWwgdmFsdWUuIgor ICAoY3VzdG9taXplLXZhcmlhYmxlICdjdXMtZWRpdC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbikK KyAgKHNlYXJjaC1mb3J3YXJkICJWYWx1ZSIpCisgIDs7IFNpbXVsYXRlIGNoYW5naW5nIHRo ZSB2YWx1ZS4KKyAgKGxldCogKChjaG9pY2UgKHdpZGdldC1hdCkpCisgICAgICAgICAoYXJn cyAod2lkZ2V0LWdldCBjaG9pY2UgOmFyZ3MpKQorICAgICAgICAgKGxpc3Qtb3B0IChjYXIg KHdpZGdldC1nZXQgY2hvaWNlIDpjaGlsZHJlbikpKQorICAgICAgICAgKGNvbnN0LW9wdCAo bnRoIDEgYXJncykpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQtY2hvaWNl IGNvbnN0LW9wdCkKKyAgICAod2lkZ2V0LXZhbHVlLXNldCBjaG9pY2UgKHdpZGdldC1kZWZh dWx0LWdldCBjb25zdC1vcHQpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQt Y2hvaWNlIGxpc3Qtb3B0KQorICAgICh3aWRnZXQtdmFsdWUtc2V0IGNob2ljZSAod2lkZ2V0 LWRlZmF1bHQtZ2V0IGxpc3Qtb3B0KSkpCisgIDs7IE5vIGVtcHR5IGtleS92YWx1ZSBwYWly cyBzaG91bGQgc2hvdyB1cC4KKyAgKHNob3VsZC1ub3QgKHNlYXJjaC1mb3J3YXJkICJrZXki IG5pbCB0KSkpCisKIChwcm92aWRlICdjdXMtZWRpdC10ZXN0cykKIDs7OyBjdXMtZWRpdC10 ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMzQuMQoK --------------rlOK46iE20fBBRee8w0WzYVR-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 09 08:53:37 2023 Received: (at 63290) by debbugs.gnu.org; 9 Aug 2023 12:53:37 +0000 Received: from localhost ([127.0.0.1]:38494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTigy-0006bi-Od for submit@debbugs.gnu.org; Wed, 09 Aug 2023 08:53:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTigx-0006bW-5O for 63290@debbugs.gnu.org; Wed, 09 Aug 2023 08:53:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTigr-0007eq-UP; Wed, 09 Aug 2023 08:53:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZX1UC4qsEzYV52pLaKYk2K1NoG15F0SuY2kvLyXIGbo=; b=hBPPmwxtSfU8SV7nnEhP u6IvDDMW2Gr5oqcPqLPd41wO7u92QRpqeYQ60SRZfDZ04pR8saIeOFbG+herqeOKii8oXNjhE7Dmu qm97j7vIncD5mwNAnhHV5HD+pblDO0yv/ki41rwdEdN17raqFMEN8dCpyuJ7bW189uwL1+hkgOfbA z9iNeHnRGvwk4i7F1CeNj/afyMQad+eR10E2pTAKIh/lVEeNBXkxyaA4Hr3Nt6Deuamjd8t79sC0b zMF8Z5UQPav1bAeBTEUcn36PnWScj+WjQ+Z8o/NLLQcPI1shs33TkYklz/4b8oVpp7u7ePZAT3mFE ipNRCPJCHvEXYg==; Date: Wed, 09 Aug 2023 15:53:39 +0300 Message-Id: <83wmy4l6lo.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Wed, 9 Aug 2023 09:19:37 -0300) Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org, fitzsim@fitzsim.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 9 Aug 2023 09:19:37 -0300 > From: Mauro Aranda > > I ended up adding a custom :default-get function for the list widget, to > make it respect a nil value as the :value.  This should be backward > compatible with other widgets, and should fix these "ghost" elements > insertions. > > I also added a test for cus-edit-tests. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 09 11:51:12 2023 Received: (at 63290) by debbugs.gnu.org; 9 Aug 2023 15:51:12 +0000 Received: from localhost ([127.0.0.1]:40359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTlSq-0003oi-C8 for submit@debbugs.gnu.org; Wed, 09 Aug 2023 11:51:12 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:59658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTlSl-0003oR-QZ for 63290@debbugs.gnu.org; Wed, 09 Aug 2023 11:51:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=34XwSHPYA/8xQeaFW6AG0ncXoFNHrfjgbF5RihVO8FM=; b=kOeCervoEam6o4cgXIXyFwHOh1 kIg59rc2mHfcra0kdcFOUnkVsuQ0vhyHdYngdo2uowDmyySRcRUf9ocAFUH4fqvHEH/SnvcU71u9C U3EIHk++AmAFEuQW4P13Tkfoiv0i+I798UbMYxewKhWtr8/eMVh18Ju2qNNzRDdF49QkU8t4LAaNH hSkwslPcI+jZLZzzbU+ue1QsD1FTYuK0smczYu1NdzucB1vtzfJzFqMXdhBS+ypRtpH5ws6OSeDqZ HeSxh8u6/PvrXQKKe4zhd4TCRE0LETRu3oA9u0T/cGqSRDYvFU2Dv+JZErGZnef6slxJAg7nSL/7P fLIViwsA==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qTlSf-001KGk-I0; Wed, 09 Aug 2023 11:51:01 -0400 From: Thomas Fitzsimmons To: Mauro Aranda Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) In-Reply-To: (Mauro Aranda's message of "Wed, 9 Aug 2023 09:19:37 -0300") References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Date: Wed, 09 Aug 2023 11:51:00 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mauro, =20 Mauro Aranda writes: > tags 63290 patch quit=20 >=20=20 > I ended up adding a custom :default-get function for the list=20 > widget, to make it respect a nil value as the :value.=C2=A0 This=20 > should be backward compatible with other widgets, and should fix=20 > these "ghost" elements insertions.=20 >=20 > I also added a test for cus-edit-tests.=20 Can you try this patch with: M-x package-install RET excorporate RET Then: M-x customize-variable RET excorporate-configuration RET then select "Value Menu" and 3, which is "EWS URL OAuth 2.0=20 settings (no autodiscovery)". With your wis-edit.el patch applied=20 I still get empty values for: INS DEL Argument name:=20 Argument value: and: =20 INS DEL OAuth 2.0 setting name:=20 OAuth 2.0 setting value: and when I apply the setting the value contains:=20 (... (... (#1# . #1#))=20 (#1# . #1#)) Maybe this is a more complicated case than the test case I=20 provided (which does now work for me with your patch)? Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 09 11:57:03 2023 Received: (at 63290) by debbugs.gnu.org; 9 Aug 2023 15:57:03 +0000 Received: from localhost ([127.0.0.1]:40363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTlYV-0003xE-4k for submit@debbugs.gnu.org; Wed, 09 Aug 2023 11:57:03 -0400 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]:50516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTlYS-0003wj-On for 63290@debbugs.gnu.org; Wed, 09 Aug 2023 11:57:01 -0400 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-56ca9a337caso4329237eaf.1 for <63290@debbugs.gnu.org>; Wed, 09 Aug 2023 08:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691596615; x=1692201415; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u/2g9zRWLuYrMUmPYCvUyEiL0TJC6YsgYK4f0EEpWh4=; b=oPgPPp1uCoUGeD2w2sVjoalv7JGGxHUn3sS9nBLjLwaWaGDYulU8Zp7SaLza6PX8fu SHr4h75WqW9ozVUfBRRS4qhbEE0IjpTjoWec7uCzCoqVgfi7YFuGMorSFvoobi8KioRu lAnhjVshxVcPxav9Yywo9MpVLBRr5+PH49YcH9h2XUISBEDiBmFne4RGN40RM6aGOHqK C5YJO5HsG2ePEsLB97MPxvhakhXS1DeROGCNyYPIptRCdG240o1XmHmHk/m2pJ9FYCtS vG+1on6p/jA44FmWIMOq3i0UN0HQYtuLgb+hbO+TtIM5FoDPEKG2Cm1/aneHtvq+hBwn RXjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691596615; x=1692201415; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u/2g9zRWLuYrMUmPYCvUyEiL0TJC6YsgYK4f0EEpWh4=; b=b+J1WQv2L17R6bdAt1O+u11J4Qi0zsz/CKq7JtePK7fCREIPSYcKCBx2tQ0NClRuWv Cf9Pxo/dGiPoDzwzajefsfyKD+IaIHtKWWEkoF2rAmfIMmRd/cVAjvi5dlWFOhXTspIT xQPRw6LQbRktPy4JsPE1T2MNbV1V+qbQf8yh85WXXh5ihZ6Xm7lPJHn3IRVclYKplYiR SgvOMndNUK8a3AGOt16jsv4X9wISEIspYFgnH/G10TAXBpWVviOA85J/QuWhXFSzGQc3 pwveLOihaocXso4TY8rgCfYCXS+B+Jfrm1c1apD+qxUpwYnF/m57LGLZM/R7zRt4P3yf ILKA== X-Gm-Message-State: AOJu0YwW3PfsJGYF4DIaLkg0qdmdO/snP5m2WBCRVbPpu/IInomcvWTu 19uEv4syXElSIrI0jc8qn6OQIn0Hsy8= X-Google-Smtp-Source: AGHT+IFRc1ZYT9Wl+kCH7dD97n/ecfj/kHLu4rOlVWnrpPPEcwqAgPvXTd4ud1qW5WczstfiZWTZ3g== X-Received: by 2002:a05:6808:f06:b0:3a3:f13f:8036 with SMTP id m6-20020a0568080f0600b003a3f13f8036mr3624258oiw.11.1691596614892; Wed, 09 Aug 2023 08:56:54 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id bd24-20020a056808221800b003a792121f47sm4622849oib.45.2023.08.09.08.56.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 08:56:54 -0700 (PDT) Message-ID: Date: Wed, 9 Aug 2023 12:56:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) To: Thomas Fitzsimmons References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) Thomas Fitzsimmons writes: > Hi Mauro, > > Mauro Aranda writes: > >> tags 63290 patch quit  I ended up adding a custom :default-get >> function for the list widget, to make it respect a nil value as the >> :value.  This should be backward compatible with other widgets, and >> should fix these "ghost" elements insertions. I also added a test >> for cus-edit-tests. > > Can you try this patch with: > > M-x package-install RET excorporate RET > > Then: > > M-x customize-variable RET excorporate-configuration RET > > then select "Value Menu" and 3, which is "EWS URL OAuth 2.0 settings > (no autodiscovery)".  With your wis-edit.el patch applied I still get > empty values for: > >    INS DEL Argument name:             Argument value: > > and: > >    INS DEL OAuth 2.0 setting name:             OAuth 2.0 setting >   value: > > and when I apply the setting the value contains:   (... (... (#1# > . #1#))    (#1# . #1#)) > > Maybe this is a more complicated case than the test case I provided > (which does now work for me with your patch)? > > Thanks, > Thomas Oh, OK.  I'll take a look at it later today or tomorrow. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 09 14:03:39 2023 Received: (at 63290) by debbugs.gnu.org; 9 Aug 2023 18:03:39 +0000 Received: from localhost ([127.0.0.1]:40480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTnWx-00047Q-6P for submit@debbugs.gnu.org; Wed, 09 Aug 2023 14:03:39 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:51255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTnWv-00047D-OI for 63290@debbugs.gnu.org; Wed, 09 Aug 2023 14:03:34 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6bd0a0a6766so68539a34.2 for <63290@debbugs.gnu.org>; Wed, 09 Aug 2023 11:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691604208; x=1692209008; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MBDcA2l/fW72ghUYYDCUdOKrv3e+amRz3AxrWxsWgns=; b=bjTjYu5XtjYo1gspZA606XP6KNGZ9O1GTPw123+PjiJ9vrU6A/TxEDJdiH5PacdSuL /isJnHQaRBZHu7VTXhIfm9PkThjpk2FJZvJSI6wJeAvCAW/YwisluaA9HY6H6m+NZuxE bEaiqEckBduHbapUjrBBQtedPAO2dpjhXI0N5V0HafbxR9ifS/etieflT8v+/0AhlJfH 6Q8AbFwVqPavRV4bRW8h36rqAuDEAfzigoxs6nPt99C73AzNYdoyGpqCXztBzBvgRzUk Rv2jHx7TRK9wDi1JbfceSXALJNUqP0gNQlRpxtkN6VJGV2zdp0X/Z3hPcPWHDbYYmLAM m1pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691604208; x=1692209008; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MBDcA2l/fW72ghUYYDCUdOKrv3e+amRz3AxrWxsWgns=; b=ko4No4hmWl5qj9gsDfOFKRhz0CxAkUQGZazPWRqJKAZxR+mLvxE3B8fo9pNDyPSCIm n26oGmpBbZGRXvBjP6CazByTbXocx1lPbQYDfVLkhgxmc8bswHdFNTF0NFFtA/WAhewm E1+3iuHplvvEL5X65JWpIbbF0+tWjiDpBwux5j8gsCaqwdGtoH0VW5QkPv9vT6LH3pOH 1eutM2/OIR/Cdt2sS1Dq3g4kdmhA5DK8fadojKcOI0LLIj0x6XOZmKIjB7CuPRKPcUfd 329nMhaR5Y44YS9RycRFE/Zm9z/x2dD6lyrJdF8HlvcmsmykC8vmnXcbQlT10tCEIsAN BvBQ== X-Gm-Message-State: AOJu0YwTktjmPCRJKBfJ5kmTB7upAT6lajx6GW2LPxUgponqnuvBznbN KcNVi5Fp9rTOyvlfgOD6odECszVyjBI= X-Google-Smtp-Source: AGHT+IHoygLnFCX2971tiqalF/sdwP3OqHwjB91C77vTwhDsvLXJJ2QrCHPam8e8w+LGxXXlb30AuA== X-Received: by 2002:a05:6830:130f:b0:6b9:72be:671f with SMTP id p15-20020a056830130f00b006b972be671fmr3839480otq.16.1691604207699; Wed, 09 Aug 2023 11:03:27 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id j21-20020a9d7f15000000b006b9ad7d0046sm7091567otq.57.2023.08.09.11.03.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 11:03:27 -0700 (PDT) Message-ID: Date: Wed, 9 Aug 2023 15:03:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Content-Language: en-US To: Thomas Fitzsimmons References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) Thomas Fitzsimmons writes: > Hi Mauro, > > Mauro Aranda writes: > >> tags 63290 patch quit  I ended up adding a custom :default-get >> function for the list widget, to make it respect a nil value as the >> :value.  This should be backward compatible with other widgets, and >> should fix these "ghost" elements insertions. I also added a test >> for cus-edit-tests. > > Can you try this patch with: > > M-x package-install RET excorporate RET > > Then: > > M-x customize-variable RET excorporate-configuration RET > > then select "Value Menu" and 3, which is "EWS URL OAuth 2.0 settings > (no autodiscovery)".  With your wis-edit.el patch applied I still get > empty values for: > >    INS DEL Argument name:             Argument value: > > and: > >    INS DEL OAuth 2.0 setting name:             OAuth 2.0 setting >   value: > > and when I apply the setting the value contains:   (... (... (#1# > . #1#))    (#1# . #1#)) > > Maybe this is a more complicated case than the test case I provided > (which does now work for me with your patch)? > > Thanks, > Thomas I took a look and this seems to have something to do with how the alist widget (and almost surely the plist widget) get created when they have :options.  I'm not sure yet, and I don't totally understand what's happening as of now, but I wanted to report back. I'll try to investigate and see how this can be fixed, but it's going to take me some time. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 10 18:58:39 2023 Received: (at 63290) by debbugs.gnu.org; 10 Aug 2023 22:58:39 +0000 Received: from localhost ([127.0.0.1]:44252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUEc2-0004JL-NH for submit@debbugs.gnu.org; Thu, 10 Aug 2023 18:58:39 -0400 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]:54552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUEby-0004J1-HC for 63290@debbugs.gnu.org; Thu, 10 Aug 2023 18:58:38 -0400 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1bff2d2c141so1123176fac.1 for <63290@debbugs.gnu.org>; Thu, 10 Aug 2023 15:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691708308; x=1692313108; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=aeL1Yxbhtw9nvFuyf2J28XuAQvR2QCBBnWyFH4UXZNM=; b=qffMWX4MU81YvAPipT7UCVTRcg6Qe2227XTd11xV1y935DK1OyHiFyITeg1d9bwnbe YWDfVaJIr8t3jYLcvf/niAm/cNgwtVpj3ZldPTMWCfEQ8NSmvDnX+HQxDub7oesyAavw CpifxzJ99mjnAdfF5OsDmWgYQZTCcU4je7VihnFHTUc6AivBrNoTda8wAK4pelvBnC1e peJQuUD95+20UjAvj36IFwJXReOibjTt9ZUM9+1ub9l9I4BgyYWQmwhaw9g/tOvoQGLg tCMx4pcwTv7fwxpRk4tNSRF+0ypWq/wevYtz+pv49kQgv/0nyvqMzt4hjIbYkq1Lw8Yl 7VzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691708308; x=1692313108; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aeL1Yxbhtw9nvFuyf2J28XuAQvR2QCBBnWyFH4UXZNM=; b=dafTVJ4n4SQmWFXYwYw7+UnC9RwYkwaX85bTCgjZvEsx1wwQBy2bj2HFzHGQiB5Tlv blTiGksxK2CjriGkp8psd05k/2UXnKVhJfUlt+Nhec1WzjzcunrhCf9pVRv5slbaKjkp y6AZ6dm05LUbHsdC7UhACZFss/D/r0VhPat4Miyg86W7yF1tZWzWPG7YB0DEY3SirBud B+4+p+JME/eKXbAufgThTQX0LAUlVaWfWWY4+T51Kxh/g3+GNrS4XRbW9hc+Ca/hqxpd n5bqh439V1jByVy/dmMJDK8WjMmzdvUPSk8DaTnBgMHFKtGB2WCiHYbUXoNFRNqynkLR kHig== X-Gm-Message-State: AOJu0YwOrpd0evU2q4e18BT7kCcJ+yEJWYUI2whpQSr2jPl6yMHxRqKo V6CYg4q0tEuvm2Bdl6Z82vnpVA4Ucg4= X-Google-Smtp-Source: AGHT+IGqWJBb5CnnPSZJdb84mU/KZmhmKkHXsKkIUX5CFbCAUszi4Adq508r6n9KLpi9jpyuWlbdhA== X-Received: by 2002:a05:6870:3328:b0:1b7:3f07:e431 with SMTP id x40-20020a056870332800b001b73f07e431mr172542oae.54.1691708308451; Thu, 10 Aug 2023 15:58:28 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id p9-20020a056830130900b006b46b913767sm1111300otq.24.2023.08.10.15.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 15:58:27 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------oHgPXDvjzeb8knj0zLBTJSV0" Message-ID: <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> Date: Thu, 10 Aug 2023 19:58:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) To: Thomas Fitzsimmons References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) This is a multi-part message in MIME format. --------------oHgPXDvjzeb8knj0zLBTJSV0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thomas Fitzsimmons writes: > Hi Mauro, > > Mauro Aranda writes: > >> I ended up adding a custom :default-get >> function for the list widget, to make it respect a nil value as the >> :value.  This should be backward compatible with other widgets, and >> should fix these "ghost" elements insertions. I also added a test >> for cus-edit-tests. > > Can you try this patch with: > > M-x package-install RET excorporate RET > > Then: > > M-x customize-variable RET excorporate-configuration RET > > then select "Value Menu" and 3, which is "EWS URL OAuth 2.0 settings > (no autodiscovery)".  With your wis-edit.el patch applied I still get > empty values for: > >    INS DEL Argument name:             Argument value: > > and: > >    INS DEL OAuth 2.0 setting name:             OAuth 2.0 setting >   value: > > and when I apply the setting the value contains:   (... (... (#1# > . #1#))    (#1# . #1#)) > > Maybe this is a more complicated case than the test case I provided > (which does now work for me with your patch)? I think this ammended patch fixes it.  Since we want widget-list-default-get to respect a nil :value property, the alist widget needs to be modified so that its default value is nil. --------------oHgPXDvjzeb8knj0zLBTJSV0 Content-Type: text/x-patch; charset=UTF-8; name="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.patch" Content-Disposition: attachment; filename*0="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1YWUxN2ZjYzQ1ZWE0MDVmNWNjMmRjNTE2ZWZhMWU5YzA1NzgyMDIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFdlZCwgOSBBdWcgMjAyMyAwOToxNzo0MyAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIFJlc3BlY3QgdGhlIDp2YWx1ZSBwcm9wZXJ0eSBpbiBhIGxpc3Qgd2lkZ2V0IChC dWcjNjMyOTApCgoqIGxpc3Avd2lkLWVkaXQuZWwgKHdpZGdldC1saXN0LWRlZmF1bHQtZ2V0 KTogTmV3IGZ1bmN0aW9uLgooYWxpc3QpOiBEZWZpbmUgbmlsIGFzIGEgZGVmYXVsdCB2YWx1 ZS4KKiB0ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwgKGN1cy1lZGl0LXRlc3QtYnVnLTYz MjkwLW9wdGlvbikKKGN1cy1lZGl0LXRlc3QtYnVnLTYzMjkwLW9wdGlvbjIpOiBOZXcgdGVz dCBvcHRpb25zLgooY3VzLWVkaXQtdGVzdC1idWc2MzI5MCk6IE5ldyB0ZXN0LgotLS0KIGxp c3Avd2lkLWVkaXQuZWwgICAgICAgICAgICB8IDEyICsrKysrKysrKysrCiB0ZXN0L2xpc3Av Y3VzLWVkaXQtdGVzdHMuZWwgfCA0MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDU1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg YS9saXNwL3dpZC1lZGl0LmVsIGIvbGlzcC93aWQtZWRpdC5lbAppbmRleCA0NzUzMTExM2Jh OC4uZDUzOGRjNDJkNTMgMTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlz cC93aWQtZWRpdC5lbApAQCAtMzgxMiw4ICszODEyLDE5IEBAIHdpZGdldC1jaGFyYWN0ZXIt bm90aWZ5CiAoZGVmaW5lLXdpZGdldCAnbGlzdCAnZ3JvdXAKICAgIkEgTGlzcCBsaXN0LiIK ICAgOnRhZyAiTGlzdCIKKyAgOmRlZmF1bHQtZ2V0ICMnd2lkZ2V0LWxpc3QtZGVmYXVsdC1n ZXQKICAgOmZvcm1hdCAiJXsldCV9OlxuJXYiKQogCisoZGVmdW4gd2lkZ2V0LWxpc3QtZGVm YXVsdC1nZXQgKHdpZGdldCkKKyAgIlJldHVybiB0aGUgZGVmYXVsdCBleHRlcm5hbCB2YWx1 ZSBmb3IgYSBsaXN0IFdJREdFVC4KKworVGhlIGRlZmF1bHQgdmFsdWUgaXMgdGhlIG9uZSBz dG9yZWQgaW4gdGhlIDp2YWx1ZSBwcm9wZXJ0eSwgZXZlbiBpZiBpdCBpcyBuaWwsCitvciBh IGxpc3Qgd2l0aCB0aGUgZGVmYXVsdCB2YWx1ZSBvZiBlYWNoIGNvbXBvbmVudCBvZiB0aGUg bGlzdCBXSURHRVQuIgorICAod2lkZ2V0LWFwcGx5IHdpZGdldCA6dmFsdWUtdG8tZXh0ZXJu YWwKKyAgICAgICAgICAgICAgICAoaWYgKHdpZGdldC1tZW1iZXIgd2lkZ2V0IDp2YWx1ZSkK KyAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDp2YWx1ZSkKKyAgICAg ICAgICAgICAgICAgICh3aWRnZXQtZ3JvdXAtZGVmYXVsdC1nZXQgd2lkZ2V0KSkpKQorCiAo ZGVmaW5lLXdpZGdldCAndmVjdG9yICdncm91cAogICAiQSBMaXNwIHZlY3Rvci4iCiAgIDp0 YWcgIlZlY3RvciIKQEAgLTM5NTIsNiArMzk2Myw3IEBAICdhbGlzdAogICA6a2V5LXR5cGUg JyhzZXhwIDp0YWcgIktleSIpCiAgIDp2YWx1ZS10eXBlICcoc2V4cCA6dGFnICJWYWx1ZSIp CiAgIDpjb252ZXJ0LXdpZGdldCAnd2lkZ2V0LWFsaXN0LWNvbnZlcnQtd2lkZ2V0CisgIDp2 YWx1ZSBuaWwKICAgOnRhZyAiQWxpc3QiKQogCiAoZGVmdmFyIHdpZGdldC1hbGlzdC12YWx1 ZS10eXBlKQk7RHluYW1pYyB2YXJpYWJsZQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2N1cy1l ZGl0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2N1cy1lZGl0LXRlc3RzLmVsCmluZGV4IGVjYTM1 ZDdjOTZhLi4zYTc4OGYxOTc0NSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2N1cy1lZGl0LXRl c3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbApAQCAtOTIsNSArOTIs NDggQEAgdGVzdC1zZXRvcHQKICAgICAgICAgICAgIChidWZmZXItc3Vic3RyaW5nLW5vLXBy b3BlcnRpZXMgKHBvaW50LW1pbikgKHBvaW50LW1heCkpKSkpCiAgICAgKHNob3VsZCAoc3Ry aW5nLXNlYXJjaCAiVmFsdWUgYDpmb28nIGRvZXMgbm90IG1hdGNoIHR5cGUgbnVtYmVyIgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgd2Fybi10eHQpKSkpCisKKyhkZWZjdXN0b20g Y3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24gbmlsCisgICJDaG9pY2Ugb3B0aW9uIGZv ciB0ZXN0aW5nIEJ1ZyM2MzI5MC4iCisgIDp0eXBlICcoY2hvaWNlIChhbGlzdAorICAgICAg ICAgICAgICAgICAgOmtleS10eXBlIChzdHJpbmcgOnRhZyAia2V5IikKKyAgICAgICAgICAg ICAgICAgIDp2YWx1ZS10eXBlIChzdHJpbmcgOnRhZyAidmFsdWUiKSkKKyAgICAgICAgICAg ICAgICAgKGNvbnN0IDp0YWcgImF1dG8iIGF1dG8pKSkKKworKGRlZmN1c3RvbSBjdXMtZWRp dC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbjIgJ3NvbWUKKyAgIkNob2ljZSBvcHRpb24gZm9yIHRl c3RpbmcgQnVnIzYzMjkwLiIKKyAgOnR5cGUgJyhjaG9pY2UKKyAgICAgICAgICAoY29uc3Qg OnRhZyAic29tZSIgc29tZSkKKyAgICAgICAgICAoYWxpc3QKKyAgICAgICAgICAgOmtleS10 eXBlIChzdHJpbmcgOnRhZyAia2V5IikKKyAgICAgICAgICAgOnZhbHVlLXR5cGUgKHN0cmlu ZyA6dGFnICJ2YWx1ZSIpKSkpCisKKyhlcnQtZGVmdGVzdCBjdXMtZWRpdC10ZXN0LWJ1ZzYz MjkwICgpCisgICJUZXN0IHRoYXQgY2hhbmdpbmcgYSBjaG9pY2UgdmFsdWUgYmFjayB0byBh biBhbGlzdCByZXNwZWN0cyBpdHMgbmlsIHZhbHVlLiIKKyAgKGN1c3RvbWl6ZS12YXJpYWJs ZSAnY3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24pCisgIChzZWFyY2gtZm9yd2FyZCAi VmFsdWUiKQorICA7OyBTaW11bGF0ZSBjaGFuZ2luZyB0aGUgdmFsdWUuCisgIChsZXQqICgo Y2hvaWNlICh3aWRnZXQtYXQpKQorICAgICAgICAgKGFyZ3MgKHdpZGdldC1nZXQgY2hvaWNl IDphcmdzKSkKKyAgICAgICAgIChsaXN0LW9wdCAoY2FyICh3aWRnZXQtZ2V0IGNob2ljZSA6 Y2hpbGRyZW4pKSkKKyAgICAgICAgIChjb25zdC1vcHQgKG50aCAxIGFyZ3MpKSkKKyAgICAo d2lkZ2V0LXB1dCBjaG9pY2UgOmV4cGxpY2l0LWNob2ljZSBjb25zdC1vcHQpCisgICAgKHdp ZGdldC12YWx1ZS1zZXQgY2hvaWNlICh3aWRnZXQtZGVmYXVsdC1nZXQgY29uc3Qtb3B0KSkK KyAgICAod2lkZ2V0LXB1dCBjaG9pY2UgOmV4cGxpY2l0LWNob2ljZSBsaXN0LW9wdCkKKyAg ICAod2lkZ2V0LXZhbHVlLXNldCBjaG9pY2UgKHdpZGdldC1kZWZhdWx0LWdldCBsaXN0LW9w dCkpKQorICA7OyBObyBlbXB0eSBrZXkvdmFsdWUgcGFpcnMgc2hvdWxkIHNob3cgdXAuCisg IChzaG91bGQtbm90IChzZWFyY2gtZm9yd2FyZCAia2V5IiBuaWwgdCkpCisgIChjdXN0b21p emUtdmFyaWFibGUgJ2N1cy1lZGl0LXRlc3QtYnVnNjMyOTAtb3B0aW9uMikKKyAgKHNlYXJj aC1mb3J3YXJkICJWYWx1ZSIpCisgIDs7IFNpbXVsYXRlIGNoYW5naW5nIHRoZSB2YWx1ZS4K KyAgKGxldCogKChjaG9pY2UgKHdpZGdldC1hdCkpCisgICAgICAgICAoYXJncyAod2lkZ2V0 LWdldCBjaG9pY2UgOmFyZ3MpKQorICAgICAgICAgKGNvbnN0LW9wdCAoY2FyICh3aWRnZXQt Z2V0IGNob2ljZSA6Y2hpbGRyZW4pKSkKKyAgICAgICAgIChsaXN0LW9wdCAobnRoIDEgYXJn cykpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQtY2hvaWNlIGxpc3Qtb3B0 KQorICAgICh3aWRnZXQtdmFsdWUtc2V0IGNob2ljZSAod2lkZ2V0LWRlZmF1bHQtZ2V0IGxp c3Qtb3B0KSkpCisgIDs7IE5vIGVtcHR5IGtleS92YWx1ZSBwYWlycyBzaG91bGQgc2hvdyB1 cC4KKyAgKHNob3VsZC1ub3QgKHNlYXJjaC1mb3J3YXJkICJrZXkiIG5pbCB0KSkpCisKIChw cm92aWRlICdjdXMtZWRpdC10ZXN0cykKIDs7OyBjdXMtZWRpdC10ZXN0cy5lbCBlbmRzIGhl cmUKLS0gCjIuMzQuMQoK --------------oHgPXDvjzeb8knj0zLBTJSV0-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 11 09:29:33 2023 Received: (at 63290) by debbugs.gnu.org; 11 Aug 2023 13:29:34 +0000 Received: from localhost ([127.0.0.1]:45174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUSCr-0007Kn-Ir for submit@debbugs.gnu.org; Fri, 11 Aug 2023 09:29:33 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:50638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUSCp-0007Ka-FY for 63290@debbugs.gnu.org; Fri, 11 Aug 2023 09:29:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Nk7gx1Y+7N0RZF7oP3Y/bw+j+cBfUDX0toVC/ohGw+U=; b=KhnhrYqex7QUo0omweP9EDKzGI HUMbKtjJ27mRx32lm/Pqjg+J8wy0eatxwK0Hn32XtuN/GiAm4Ns9gxbOcr8zb/yZ932gS2exSaJIz hn//2eBpgY7PBAH1OvFx5iraLWJAy9gl8ioYMjcdg/kvGTuQvT97pkO7izy/xhjggQ79+qZOwd3oL 9IMqKiqQzge8KiM8rmhkvRjf/LWOImt9wjfP9ipSGWYYsPrZfjpkKa9TOM3JBqD5wUidvK3oV+co9 U9URpVAMJBvvlEjryEmeSjBfOURsqd/7x1GeZVTSfw/LwbrcfsqrEnwUPa2uxPDCJNp4poQa2vPQ0 Ql4J9P2A==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qUSCj-001LpF-09; Fri, 11 Aug 2023 09:29:25 -0400 From: Thomas Fitzsimmons To: Mauro Aranda Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) In-Reply-To: <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> (Mauro Aranda's message of "Thu, 10 Aug 2023 19:58:24 -0300") References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> Date: Fri, 11 Aug 2023 09:29:24 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Thomas Fitzsimmons writes:=20 >=20 >> Hi Mauro,=20 >>=20 >> Mauro Aranda writes:=20 >>=20 >>> I ended up adding a custom :default-get function for the list=20 >>> widget, to make it respect a nil value as the :value.=C2=A0 This=20 >>> should be backward compatible with other widgets, and should=20 >>> fix these "ghost" elements insertions. I also added a test for=20 >>> cus-edit-tests.=20 >>=20 >> Can you try this patch with:=20 >>=20 >> M-x package-install RET excorporate RET=20 >>=20 >> Then:=20 >>=20 >> M-x customize-variable RET excorporate-configuration RET=20 >>=20 >> then select "Value Menu" and 3, which is "EWS URL OAuth 2.0=20 >> settings (no autodiscovery)".=C2=A0 With your wis-edit.el patch=20 >> applied I still get empty values for:=20 >> =C2=A0=C2=A0=C2=A0 INS DEL Argument name:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Argument value:=20=20 >> and:=20 >> =C2=A0=C2=A0=C2=A0 INS DEL OAuth 2.0 setting name:=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 OAuth 2.0=20 >>setting =C2=A0=C2=A0 value:=20=20 >> and when I apply the setting the value contains:=C2=A0=C2=A0=20 >> (... (... (#1# . #1#))=C2=A0=C2=A0=C2=A0 (#1# . #1#))=20 >>=20 >> Maybe this is a more complicated case than the test case I=20 >> provided (which does now work for me with your patch)?=20 >=20 > I think this ammended patch fixes it.=C2=A0 Since we want=20 > widget-list-default-get to respect a nil :value property, the=20 > alist widget needs to be modified so that its default value is=20 > nil.=20 With the updated patch, when I select "EWS URL OAuth 2.0 settings=20 (no autodiscovery)", all the widgets are disabled. The blank=20 values are no longer added though. However, if I then set the=20 value, without configuring anything, excorporate-configuration=20 stays nil. So I don't think the patch is correct yet. Thomas From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 18:46:49 2023 Received: (at 63290) by debbugs.gnu.org; 15 Aug 2023 22:46:49 +0000 Received: from localhost ([127.0.0.1]:37047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qW2oK-00005M-Tg for submit@debbugs.gnu.org; Tue, 15 Aug 2023 18:46:49 -0400 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]:60488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qW2oF-000052-V7 for 63290@debbugs.gnu.org; Tue, 15 Aug 2023 18:46:47 -0400 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1c4d8eaa8ebso2169013fac.0 for <63290@debbugs.gnu.org>; Tue, 15 Aug 2023 15:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692139598; x=1692744398; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=YdQ/1L1fzlBTj4SDfBo15rlnYkQLDwscrPhK4Hyj0AI=; b=Ui7oC56Vq11wQOPv2DsxhGde27bGEvp94TCU5tCRfFCj9mvkGQNuwEaHAadm6i8zNZ cFCcko4vcvnK+q4emy3x7CyKF1xBYMw6VI15i3TFss3Mydzr0eYtmkaFqT3EHNdFuep3 rCKvDwqDuiWRUz26O8V8O7HUdyeA2J/8XNaKkHQTuOT/OUYqwnunYipfdHUNM85oqxn+ QPbcvupnuAmOVu9IHrlnqAYir3q7bcD5QSfgzuePNe22y6zlqScldLXZMn/7RZpmR+/S rtaYIWEl59VujDZoHmlC9XfIRWuVmW5cEAP8dxJ9nTKzv6CURh6hRS8egesliGW37O0U tSBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692139598; x=1692744398; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YdQ/1L1fzlBTj4SDfBo15rlnYkQLDwscrPhK4Hyj0AI=; b=aQRCLPF8pVItgH+J1lhvk8eVBahJjluP4DNMvUgNYGXkA3pjEOY+SGMHFsQIEdBULf aWEfYommeFfKMzbwsBMWHHciy93H4YVatFNk+Hv25MnuP8IN3/fKssgD93kBfQrYbJ42 UDnDr0L0iPt1lslu5tXoT2inq/YkV4EvHj8qilKl7DvKI2gWDh6342oVYv1NaLH+6TnK ZCVlSCipSkUe9iFo6WCRgfpDnDlBM8nLtfpkQNc4kOxIcbo5+VXEJbWTbHA9id46SfXM GTWgktWF505xR9svdKepRFkLnx6qSCpAgOuK7SvbvpJbYIGl8BIUXtMC6S48UNhXOpHW 6Ydg== X-Gm-Message-State: AOJu0YzBs+sEBSCtk1Oq5uf9asYJo2pjvZKWoJvZyUCNgMyg2GgF1EQL SvVaWSAMOauB9S0Z2wn6/YMAQK94TJc= X-Google-Smtp-Source: AGHT+IFZ+r00SC/SCxb9fuE8TgDFWKAK71GalI589cjADnD3U0BL4ggeYRJn+p/kyAeDGki995DXyQ== X-Received: by 2002:a05:6870:c20e:b0:1bb:ba55:3fdd with SMTP id z14-20020a056870c20e00b001bbba553fddmr60471oae.7.1692139598055; Tue, 15 Aug 2023 15:46:38 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id l7-20020a9d7a87000000b006b92c078d05sm5557651otn.31.2023.08.15.15.46.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 15:46:37 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Eh00ZSnLZgsPQZY8sl2fLz1c" Message-ID: <08306097-a6d2-ffbe-0991-31afbb71c037@gmail.com> Date: Tue, 15 Aug 2023 19:46:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Content-Language: en-US To: Thomas Fitzsimmons References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> From: Mauro Aranda In-Reply-To: X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) This is a multi-part message in MIME format. --------------Eh00ZSnLZgsPQZY8sl2fLz1c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Thomas, Thomas Fitzsimmons writes: > Mauro Aranda writes: >>> Can you try this patch with: M-x package-install RET excorporate >>> RET Then: M-x customize-variable RET excorporate-configuration RET >>> then select "Value Menu" and 3, which is "EWS URL OAuth 2.0 >>> settings (no autodiscovery)".  With your wis-edit.el patch applied >>> I still get empty values for:     INS DEL Argument >>> name:             Argument value:  and:     INS DEL OAuth 2.0 >>> setting name:             OAuth 2.0 setting value:  and when I >>> apply the setting the value contains:   (... (... (#1# . #1#)) >>> (#1# . #1#)) Maybe this is a more complicated case than the test >>> case I provided (which does now work for me with your patch)? >> I think this ammended patch fixes it.  Since we want >> widget-list-default-get to respect a nil :value property, the alist >> widget needs to be modified so that its default value is nil. > > With the updated patch, when I select "EWS URL OAuth 2.0 settings (no > autodiscovery)", all the widgets are disabled.  The blank values are > no longer added though.  However, if I then set the value, without > configuring anything, excorporate-configuration stays nil. So I don't > think the patch is correct yet. So, in case the :value is missing for the alist widget, we want to compute the default-value with the :options, and without including the editable-list. Hopefully the attached patch is 100% correct now.  I did try it with excorporate-configuration and I think it works OK, but please give it yourself a try.  And thank you for your patience. --------------Eh00ZSnLZgsPQZY8sl2fLz1c Content-Type: text/x-patch; charset=UTF-8; name="0001-Specialize-default-get-for-alist-widgets-Bug-63290.patch" Content-Disposition: attachment; filename*0="0001-Specialize-default-get-for-alist-widgets-Bug-63290.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSAyMjgwMDE3OTVhYjE1OTM2Y2QyZThkMWZlYzM4ZWMxNWI3N2M1YjkxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFR1ZSwgMTUgQXVnIDIwMjMgMTk6MzU6MzkgLTAzMDAKU3ViamVjdDog W1BBVENIXSBTcGVjaWFsaXplIGRlZmF1bHQtZ2V0IGZvciBhbGlzdCB3aWRnZXRzIChCdWcj NjMyOTApCgoqIGxpc3Avd2lkLWVkaXQuZWwgKHdpZGdldC1saXN0LWRlZmF1bHQtZ2V0KQoo d2lkZ2V0LWFsaXN0LWRlZmF1bHQtZ2V0KTogTmV3IGZ1bmN0aW9ucy4KKGxpc3QsIGFsaXN0 KTogVXNlIGl0LgoqIHRlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbCAoY3VzLWVkaXQtdGVz dC1idWc2MzI5MC1vcHRpb24pCihjdXMtZWRpdC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbi0yKTog TmV3IHRlc3Qgb3B0aW9ucy4KKGN1cy1lZGl0LXRlc3QtYnVnNjMyOTApOiBOZXcgdGVzdC4K KiB0ZXN0L2xpc3Avd2lkLWVkaXQtdGVzdHMuZWwgKHdpZGdldC10ZXN0LWFsaXN0LWRlZmF1 bHQtdmFsdWUtMSkKKHdpZGdldC10ZXN0LWFsaXN0LWRlZmF1bHQtdmFsdWUtMiwgd2lkZ2V0 LXRlc3QtYWxpc3QtZGVmYXVsdC12YWx1ZS0zKQood2lkZ2V0LXRlc3QtYWxpc3QtZGVmYXVs dC12YWx1ZS00KTogTmV3IHRlc3RzLgotLS0KIGxpc3Avd2lkLWVkaXQuZWwgICAgICAgICAg ICB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysrLQogdGVzdC9saXNwL2N1cy1lZGl0 LXRlc3RzLmVsIHwgNDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwog dGVzdC9saXNwL3dpZC1lZGl0LXRlc3RzLmVsIHwgMzEgKysrKysrKysrKysrKysrKysrKysr KysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMTA1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKCmRpZmYgLS1naXQgYS9saXNwL3dpZC1lZGl0LmVsIGIvbGlzcC93aWQtZWRpdC5lbApp bmRleCA0NzUzMTExM2JhOC4uNWRiZGQ3MTI3YWEgMTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVk aXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApAQCAtMzgxMiw4ICszODEyLDE5IEBAIHdp ZGdldC1jaGFyYWN0ZXItbm90aWZ5CiAoZGVmaW5lLXdpZGdldCAnbGlzdCAnZ3JvdXAKICAg IkEgTGlzcCBsaXN0LiIKICAgOnRhZyAiTGlzdCIKKyAgOmRlZmF1bHQtZ2V0ICMnd2lkZ2V0 LWxpc3QtZGVmYXVsdC1nZXQKICAgOmZvcm1hdCAiJXsldCV9OlxuJXYiKQogCisoZGVmdW4g d2lkZ2V0LWxpc3QtZGVmYXVsdC1nZXQgKHdpZGdldCkKKyAgIlJldHVybiB0aGUgZGVmYXVs dCBleHRlcm5hbCB2YWx1ZSBmb3IgYSBsaXN0IFdJREdFVC4KKworVGhlIGRlZmF1bHQgdmFs dWUgaXMgdGhlIG9uZSBzdG9yZWQgaW4gdGhlIDp2YWx1ZSBwcm9wZXJ0eSwgZXZlbiBpZiBp dCBpcyBuaWwsCitvciBhIGxpc3Qgd2l0aCB0aGUgZGVmYXVsdCB2YWx1ZSBvZiBlYWNoIGNv bXBvbmVudCBvZiB0aGUgbGlzdCBXSURHRVQuIgorICAod2lkZ2V0LWFwcGx5IHdpZGdldCA6 dmFsdWUtdG8tZXh0ZXJuYWwKKyAgICAgICAgICAgICAgICAoaWYgKHdpZGdldC1tZW1iZXIg d2lkZ2V0IDp2YWx1ZSkKKyAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0 IDp2YWx1ZSkKKyAgICAgICAgICAgICAgICAgICh3aWRnZXQtZ3JvdXAtZGVmYXVsdC1nZXQg d2lkZ2V0KSkpKQorCiAoZGVmaW5lLXdpZGdldCAndmVjdG9yICdncm91cAogICAiQSBMaXNw IHZlY3Rvci4iCiAgIDp0YWcgIlZlY3RvciIKQEAgLTM5NDIsNyArMzk1Myw2IEBAIHdpZGdl dC1wbGlzdC1jb252ZXJ0LW9wdGlvbgogCSAgICB2YWx1ZS10eXBlIHdpZGdldC1wbGlzdC12 YWx1ZS10eXBlKSkKICAgICBgKGdyb3VwIDpmb3JtYXQgIktleTogJXYiIDppbmxpbmUgdCAs a2V5LXR5cGUgLHZhbHVlLXR5cGUpKSkKIAotCiA7OzsgVGhlIGBhbGlzdCcgV2lkZ2V0Lgog OzsKIDs7IEFzc29jaWF0aW9uIGxpc3RzLgpAQCAtMzk1Miw2ICszOTYyLDcgQEAgJ2FsaXN0 CiAgIDprZXktdHlwZSAnKHNleHAgOnRhZyAiS2V5IikKICAgOnZhbHVlLXR5cGUgJyhzZXhw IDp0YWcgIlZhbHVlIikKICAgOmNvbnZlcnQtd2lkZ2V0ICd3aWRnZXQtYWxpc3QtY29udmVy dC13aWRnZXQKKyAgOmRlZmF1bHQtZ2V0ICMnd2lkZ2V0LWFsaXN0LWRlZmF1bHQtZ2V0CiAg IDp0YWcgIkFsaXN0IikKIAogKGRlZnZhciB3aWRnZXQtYWxpc3QtdmFsdWUtdHlwZSkJO0R5 bmFtaWMgdmFyaWFibGUKQEAgLTM5ODYsNiArMzk5NywyNSBAQCB3aWRnZXQtYWxpc3QtY29u dmVydC1vcHRpb24KICAgICAgIChzZXRxIGtleS10eXBlIGAoY29uc3QgLG9wdGlvbikKIAkg ICAgdmFsdWUtdHlwZSB3aWRnZXQtYWxpc3QtdmFsdWUtdHlwZSkpCiAgICAgYChjb25zIDpm b3JtYXQgIktleTogJXYiICxrZXktdHlwZSAsdmFsdWUtdHlwZSkpKQorCisoZGVmdW4gd2lk Z2V0LWFsaXN0LWRlZmF1bHQtZ2V0ICh3aWRnZXQpCisgICJSZXR1cm4gdGhlIGRlZmF1bHQg dmFsdWUgZm9yIFdJREdFVCwgYW4gYWxpc3Qgd2lkZ2V0LgorCitUaGUgZGVmYXVsdCB2YWx1 ZSBtYXkgYmUgb25lIG9mOgorLSBUaGUgb25lIHN0b3JlZCBpbiB0aGUgOnZhbHVlIHByb3Bl cnR5LCBldmVuIGlmIGl0IGlzIG5pbC4KKy0gSWYgV0lER0VUIGhhcyBvcHRpb25zIGF2YWls YWJsZSwgYW4gYWxpc3QgY29uc2lzdGluZyBvZiB0aGUKK2RlZmF1bHQgdmFsdWVzIGZvciBl YWNoIG9wdGlvbi4KKy0gbmlsLCBvdGhlcndpc2UuIgorICAod2lkZ2V0LWFwcGx5IHdpZGdl dCA6dmFsdWUtdG8tZXh0ZXJuYWwKKyAgICAgICAgICAgICAgICAoY29uZCAoKHdpZGdldC1t ZW1iZXIgd2lkZ2V0IDp2YWx1ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1n ZXQgd2lkZ2V0IDp2YWx1ZSkpCisgICAgICAgICAgICAgICAgICAgICAgKCh3aWRnZXQtZ2V0 IHdpZGdldCA6b3B0aW9ucykKKyAgICAgICAgICAgICAgICAgICAgICAgKG1hcGNhciAjJ3dp ZGdldC1kZWZhdWx0LWdldAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IExh c3Qgb25lIGlzIHRoZSBlZGl0YWJsZS1saXN0IHBhcnQsIGFuZAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDs7IHdlIGRvbid0IHdhbnQgdGhvc2Ugc2hvd2luZyB1cCBhcwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHBhcnQgb2YgdGhlIGRlZmF1bHQg dmFsdWUuICAoQnVnIzYzMjkwKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChi dXRsYXN0ICh3aWRnZXQtZ2V0IHdpZGdldCA6YXJncykpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAodCBuaWwpKSkpCiAMCiAoZGVmaW5lLXdpZGdldCAnY2hvaWNlICdtZW51LWNob2lj ZQogICAiQSB1bmlvbiBvZiBzZXZlcmFsIHNleHAgdHlwZXMuCmRpZmYgLS1naXQgYS90ZXN0 L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwgYi90ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwK aW5kZXggZWNhMzVkN2M5NmEuLjNhNzg4ZjE5NzQ1IDEwMDY0NAotLS0gYS90ZXN0L2xpc3Av Y3VzLWVkaXQtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2N1cy1lZGl0LXRlc3RzLmVsCkBA IC05Miw1ICs5Miw0OCBAQCB0ZXN0LXNldG9wdAogICAgICAgICAgICAgKGJ1ZmZlci1zdWJz dHJpbmctbm8tcHJvcGVydGllcyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkpKSkKICAgICAo c2hvdWxkIChzdHJpbmctc2VhcmNoICJWYWx1ZSBgOmZvbycgZG9lcyBub3QgbWF0Y2ggdHlw ZSBudW1iZXIiCiAgICAgICAgICAgICAgICAgICAgICAgICAgICB3YXJuLXR4dCkpKSkKKwor KGRlZmN1c3RvbSBjdXMtZWRpdC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbiBuaWwKKyAgIkNob2lj ZSBvcHRpb24gZm9yIHRlc3RpbmcgQnVnIzYzMjkwLiIKKyAgOnR5cGUgJyhjaG9pY2UgKGFs aXN0CisgICAgICAgICAgICAgICAgICA6a2V5LXR5cGUgKHN0cmluZyA6dGFnICJrZXkiKQor ICAgICAgICAgICAgICAgICAgOnZhbHVlLXR5cGUgKHN0cmluZyA6dGFnICJ2YWx1ZSIpKQor ICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiYXV0byIgYXV0bykpKQorCisoZGVmY3Vz dG9tIGN1cy1lZGl0LXRlc3QtYnVnNjMyOTAtb3B0aW9uMiAnc29tZQorICAiQ2hvaWNlIG9w dGlvbiBmb3IgdGVzdGluZyBCdWcjNjMyOTAuIgorICA6dHlwZSAnKGNob2ljZQorICAgICAg ICAgIChjb25zdCA6dGFnICJzb21lIiBzb21lKQorICAgICAgICAgIChhbGlzdAorICAgICAg ICAgICA6a2V5LXR5cGUgKHN0cmluZyA6dGFnICJrZXkiKQorICAgICAgICAgICA6dmFsdWUt dHlwZSAoc3RyaW5nIDp0YWcgInZhbHVlIikpKSkKKworKGVydC1kZWZ0ZXN0IGN1cy1lZGl0 LXRlc3QtYnVnNjMyOTAgKCkKKyAgIlRlc3QgdGhhdCBjaGFuZ2luZyBhIGNob2ljZSB2YWx1 ZSBiYWNrIHRvIGFuIGFsaXN0IHJlc3BlY3RzIGl0cyBuaWwgdmFsdWUuIgorICAoY3VzdG9t aXplLXZhcmlhYmxlICdjdXMtZWRpdC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbikKKyAgKHNlYXJj aC1mb3J3YXJkICJWYWx1ZSIpCisgIDs7IFNpbXVsYXRlIGNoYW5naW5nIHRoZSB2YWx1ZS4K KyAgKGxldCogKChjaG9pY2UgKHdpZGdldC1hdCkpCisgICAgICAgICAoYXJncyAod2lkZ2V0 LWdldCBjaG9pY2UgOmFyZ3MpKQorICAgICAgICAgKGxpc3Qtb3B0IChjYXIgKHdpZGdldC1n ZXQgY2hvaWNlIDpjaGlsZHJlbikpKQorICAgICAgICAgKGNvbnN0LW9wdCAobnRoIDEgYXJn cykpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQtY2hvaWNlIGNvbnN0LW9w dCkKKyAgICAod2lkZ2V0LXZhbHVlLXNldCBjaG9pY2UgKHdpZGdldC1kZWZhdWx0LWdldCBj b25zdC1vcHQpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQtY2hvaWNlIGxp c3Qtb3B0KQorICAgICh3aWRnZXQtdmFsdWUtc2V0IGNob2ljZSAod2lkZ2V0LWRlZmF1bHQt Z2V0IGxpc3Qtb3B0KSkpCisgIDs7IE5vIGVtcHR5IGtleS92YWx1ZSBwYWlycyBzaG91bGQg c2hvdyB1cC4KKyAgKHNob3VsZC1ub3QgKHNlYXJjaC1mb3J3YXJkICJrZXkiIG5pbCB0KSkK KyAgKGN1c3RvbWl6ZS12YXJpYWJsZSAnY3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24y KQorICAoc2VhcmNoLWZvcndhcmQgIlZhbHVlIikKKyAgOzsgU2ltdWxhdGUgY2hhbmdpbmcg dGhlIHZhbHVlLgorICAobGV0KiAoKGNob2ljZSAod2lkZ2V0LWF0KSkKKyAgICAgICAgIChh cmdzICh3aWRnZXQtZ2V0IGNob2ljZSA6YXJncykpCisgICAgICAgICAoY29uc3Qtb3B0IChj YXIgKHdpZGdldC1nZXQgY2hvaWNlIDpjaGlsZHJlbikpKQorICAgICAgICAgKGxpc3Qtb3B0 IChudGggMSBhcmdzKSkpCisgICAgKHdpZGdldC1wdXQgY2hvaWNlIDpleHBsaWNpdC1jaG9p Y2UgbGlzdC1vcHQpCisgICAgKHdpZGdldC12YWx1ZS1zZXQgY2hvaWNlICh3aWRnZXQtZGVm YXVsdC1nZXQgbGlzdC1vcHQpKSkKKyAgOzsgTm8gZW1wdHkga2V5L3ZhbHVlIHBhaXJzIHNo b3VsZCBzaG93IHVwLgorICAoc2hvdWxkLW5vdCAoc2VhcmNoLWZvcndhcmQgImtleSIgbmls IHQpKSkKKwogKHByb3ZpZGUgJ2N1cy1lZGl0LXRlc3RzKQogOzs7IGN1cy1lZGl0LXRlc3Rz LmVsIGVuZHMgaGVyZQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL3dpZC1lZGl0LXRlc3RzLmVs IGIvdGVzdC9saXNwL3dpZC1lZGl0LXRlc3RzLmVsCmluZGV4IGIzNzljN2M5MWE4Li5lYmZl NzI5YmM5YSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL3dpZC1lZGl0LXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC93aWQtZWRpdC10ZXN0cy5lbApAQCAtMzQ5LDQgKzM0OSwzNSBAQCB3aWRn ZXQtdGVzdC1jb2xvci1tYXRjaAogICAgIChzaG91bGQtbm90ICh3aWRnZXQtYXBwbHkgd2lk Z2V0IDptYXRjaCAic29tZXVuZGVmaW5lZGNvbG9yaWhvcGUiKSkKICAgICAoc2hvdWxkLW5v dCAod2lkZ2V0LWFwcGx5IHdpZGdldCA6bWF0Y2ggIiMxMTIyMyIpKSkpCiAKKyhlcnQtZGVm dGVzdCB3aWRnZXQtdGVzdC1hbGlzdC1kZWZhdWx0LXZhbHVlLTEgKCkKKyAgIlRlc3QgZ2V0 dGluZyB0aGUgZGVmYXVsdCB2YWx1ZSBmb3IgYW4gYWxpc3Qgd2lkZ2V0IHdpdGggb3B0aW9u cy4iCisgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgKGxldCAoKHcgKHdpZGdldC1jcmVhdGUg JyhhbGlzdCA6a2V5LXR5cGUgc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICA6dmFsdWUtdHlwZSBpbnRlZ2VyCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA6b3B0aW9ucyAoKCIwIiAoaW50ZWdlcikpKSkpKSkKKyAgICAgIChzaG91 bGQgKGVxdWFsICcoKCIwIiAuIDApKSAod2lkZ2V0LWRlZmF1bHQtZ2V0IHcpKSkpKSkKKwor KGVydC1kZWZ0ZXN0IHdpZGdldC10ZXN0LWFsaXN0LWRlZmF1bHQtdmFsdWUtMiAoKQorICAi VGVzdCBnZXR0aW5nIHRoZSBkZWZhdWx0IHZhbHVlIGZvciBhbiBhbGlzdCB3aWRnZXQgd2l0 aG91dCA6dmFsdWUuIgorICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgIChsZXQgKCh3ICh3aWRn ZXQtY3JlYXRlICcoYWxpc3QgOmtleS10eXBlIHN0cmluZworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgOnZhbHVlLXR5cGUgaW50ZWdlcikpKSkKKyAgICAgIChzaG91 bGQtbm90ICh3aWRnZXQtZGVmYXVsdC1nZXQgdykpKSkpCisKKyhlcnQtZGVmdGVzdCB3aWRn ZXQtdGVzdC1hbGlzdC1kZWZhdWx0LXZhbHVlLTMgKCkKKyAgIlRlc3QgZ2V0dGluZyB0aGUg ZGVmYXVsdCB2YWx1ZSBmb3IgYW4gYWxpc3Qgd2lkZ2V0IHdpdGggbmlsIDp2YWx1ZS4iCisg ICh3aXRoLXRlbXAtYnVmZmVyCisgICAgKGxldCAoKHcgKHdpZGdldC1jcmVhdGUgJyhhbGlz dCA6a2V5LXR5cGUgc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA6dmFsdWUtdHlwZSBpbnRlZ2VyCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA6dmFsdWUgbmlsKSkpKQorICAgICAgKHNob3VsZC1ub3QgKHdpZGdldC1kZWZhdWx0 LWdldCB3KSkpKSkKKworKGVydC1kZWZ0ZXN0IHdpZGdldC10ZXN0LWFsaXN0LWRlZmF1bHQt dmFsdWUtNCAoKQorICAiVGVzdCBnZXR0aW5nIHRoZSBkZWZhdWx0IHZhbHVlIGZvciBhbiBh bGlzdCB3aWRnZXQgd2l0aCBub24tbmlsIDp2YWx1ZS4iCisgICh3aXRoLXRlbXAtYnVmZmVy CisgICAgKGxldCAoKHcgKHdpZGdldC1jcmVhdGUgJyhhbGlzdCA6a2V5LXR5cGUgc3RyaW5n CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6dmFsdWUtdHlwZSBpbnRl Z2VyCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6dmFsdWUgKCgiMSIg LiAxKSAoIjIiIC4gMikpKSkpKQorICAgICAgKHNob3VsZCAoZXF1YWwgJygoIjEiIC4gMSkg KCIyIiAuIDIpKSAod2lkZ2V0LWRlZmF1bHQtZ2V0IHcpKSkpKSkKKwogOzs7IHdpZC1lZGl0 LXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4zNC4xCgo= --------------Eh00ZSnLZgsPQZY8sl2fLz1c-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 11:16:42 2023 Received: (at 63290) by debbugs.gnu.org; 16 Aug 2023 15:16:42 +0000 Received: from localhost ([127.0.0.1]:41844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWIGH-0008D8-Ps for submit@debbugs.gnu.org; Wed, 16 Aug 2023 11:16:42 -0400 Received: from mail.fitzsim.org ([69.165.165.189]:41630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWIGF-0008Ct-8U for 63290@debbugs.gnu.org; Wed, 16 Aug 2023 11:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UPoerxyQpPLa83RRvhKX+enlrxmSh1ejY4h3JlFKCz4=; b=NfrFhnPauh0P9vdrO+OBkI4aTZ vsMY4sx94kf5gDwUaffFy5TUCGP4voWya6wzJFQCJxlMTUJnAocfWmp2nCpizEjKORjprHfeGwaTd w5szc7HQ99iLPoGzXqTZAlthpDSM58tsT1XDqiR9m7RVt1L05LagJyCwMr03aHMx2TyiGidLPdtHA XwxvFKXHiecUFiPdMvuj7G7OJxCekSzmOZDYNXq+OIo4T/Nt95zYC3aUc4qUXlblsQyjwCa6xQXBD M1kybWi2VBYOC36HVpyqs6hOt1rksDvQilUyfump2xryhRJMNTGh/8QPWA1N7GRML16BIkK//JJxk IkPhmHNg==; Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qWIG8-001PhD-Pe; Wed, 16 Aug 2023 11:16:32 -0400 From: Thomas Fitzsimmons To: Mauro Aranda Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) In-Reply-To: <08306097-a6d2-ffbe-0991-31afbb71c037@gmail.com> (Mauro Aranda's message of "Tue, 15 Aug 2023 19:46:35 -0300") References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> <08306097-a6d2-ffbe-0991-31afbb71c037@gmail.com> Date: Wed, 16 Aug 2023 11:16:32 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mauro, =20 Mauro Aranda writes: > Thomas Fitzsimmons writes:=20 >=20 >> Mauro Aranda writes:=20 >>>> Can you try this patch with: M-x package-install RET=20 >>>> excorporate RET Then: M-x customize-variable RET=20 >>>> excorporate-configuration RET then select "Value Menu" and 3,=20 >>>> which is "EWS URL OAuth 2.0 settings (no autodiscovery)".=C2=A0=20 >>>> With your wis-edit.el patch applied I still get empty values=20 >>>> for: =C2=A0=C2=A0=C2=A0 INS DEL Argument name:=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Argument value:=C2=A0=20 >>>> and: =C2=A0=C2=A0=C2=A0 INS DEL OAuth 2.0 setting name:=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 OAuth=20 >>>> 2.0 setting value:=C2=A0 and when I apply the setting the value=20 >>>> contains:=C2=A0=C2=A0 (... (... (#1# . #1#)) (#1# . #1#)) Maybe this i= s=20 >>>> a more complicated case than the test case I provided (which=20 >>>> does now work for me with your patch)?=20 >>> I think this ammended patch fixes it.=C2=A0 Since we want=20 >>> widget-list-default-get to respect a nil :value property, the=20 >>> alist widget needs to be modified so that its default value is=20 >>> nil.=20 >>=20 >> With the updated patch, when I select "EWS URL OAuth 2.0=20 >> settings (no autodiscovery)", all the widgets are disabled.=C2=A0=20 >> The blank values are no longer added though.=C2=A0 However, if I=20 >> then set the value, without configuring anything,=20 >> excorporate-configuration stays nil. So I don't think the patch=20 >> is correct yet.=20 >=20 > So, in case the :value is missing for the alist widget, we want=20 > to compute the default-value with the :options, and without=20 > including the editable-list.=20 >=20 > Hopefully the attached patch is 100% correct now.=C2=A0 I did try it=20 > with excorporate-configuration and I think it works OK, but=20 > please give it yourself a try.=C2=A0 And thank you for your patience.=20 Yes, after applying this patch, I retried the test case and=20 excorporate-configuration and both behave as I was originally=20 expecting them to; no stray structures upon setting the value. Thank you for all your work on this and the comprehensive test=20 cases. Feel free to close this bug report once the patch is=20 pushed. Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 19 04:34:24 2023 Received: (at 63290-done) by debbugs.gnu.org; 19 Aug 2023 08:34:24 +0000 Received: from localhost ([127.0.0.1]:49360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXHPb-0004q4-T7 for submit@debbugs.gnu.org; Sat, 19 Aug 2023 04:34:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXHPa-0004pr-U1 for 63290-done@debbugs.gnu.org; Sat, 19 Aug 2023 04:34:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXHPQ-0007DP-7p; Sat, 19 Aug 2023 04:34:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zVgNR+uC4gcDjXLg+Iut4YRx3EdziBONXFYtT2JC/qQ=; b=eeWLwReDFb/ZFaOCkIN/ wxt6J+kEK8SVsb+A8iZC1nnScQxmCUb8X9q4La/lxN5+uGfeGEqoFESItq9DcS5OOoveRTq6JeiFF VbPNv8qN957ocaPV0WDpWYAlT4mmig5d/zCzRe7g8mwo5AMVLxcO09nBwTX1PmCLI8f6IuozQ9vLl mzdCNl3/zN1RRczYTUBm5+oTPmNQDkd0nokvAJH95qCPibhFqCDGWgmtQcboNc0ivsoJXvWFzErHI mIb3AXgQ1WSSV7t5f2D1B+kg/lrafPVc0zP97SWhIihU0AM+baF9g3xFktnPqFXQ2cqp/FlcohSAu M4/2ZS4ZHfweZQ==; Date: Sat, 19 Aug 2023 11:34:24 +0300 Message-Id: <831qfz1ldb.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: <08306097-a6d2-ffbe-0991-31afbb71c037@gmail.com> (message from Mauro Aranda on Tue, 15 Aug 2023 19:46:35 -0300) Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> <08306097-a6d2-ffbe-0991-31afbb71c037@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63290-done Cc: 63290-done@debbugs.gnu.org, fitzsim@fitzsim.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 63290@debbugs.gnu.org > Date: Tue, 15 Aug 2023 19:46:35 -0300 > From: Mauro Aranda > > So, in case the :value is missing for the alist widget, we want to > compute the default-value with the :options, and without including the > editable-list. > > Hopefully the attached patch is 100% correct now.  I did try it with > excorporate-configuration and I think it works OK, but please give it > yourself a try.  And thank you for your patience. Thanks, I've now installed this on the master branch, and I'm closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 08:23:50 2023 Received: (at 63290) by debbugs.gnu.org; 21 Aug 2023 12:23:50 +0000 Received: from localhost ([127.0.0.1]:55790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3wj-0002yF-Ux for submit@debbugs.gnu.org; Mon, 21 Aug 2023 08:23:50 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:55752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3wh-0002xy-S9 for 63290@debbugs.gnu.org; Mon, 21 Aug 2023 08:23:48 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4ff882397ecso4795559e87.3 for <63290@debbugs.gnu.org>; Mon, 21 Aug 2023 05:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692620620; x=1693225420; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=XWPAMYCVvmVZ80Iqiz9MTPk/3qtVvLCjESPDYfHM1ZY=; b=l6Ux5xeL0/tHsgt5cBfrK7L2hQ8Lku3J+hbdlF7BJ4inCcjzE08imoIRgHqmqr2+v4 AFh058Kb0/oiDpCd0qYnAHHKrtqrqh4F30gSZsvp8PDPronl/qfuyYuC4p+KvWS0ie3W t/0ijGjMZZ8TMkQPYaUxPmeooU6vMNN0xrJbQ3IC8/JAVxz7B4ZP532z4L706ydSe2+f ruqZDwXxBDlV7pyd5zCDZ+g7DD9vy5bfEnHfax5x5Hi0R6HML6Y07SGEiRH3ySr/0oIB r3d02eeF7HHHETEq7Lz/a4fAkhP6CQBTdQusqPw1W9LASYZeicaTBTKeR//LVfBMQvxf tLbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692620620; x=1693225420; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XWPAMYCVvmVZ80Iqiz9MTPk/3qtVvLCjESPDYfHM1ZY=; b=aCsy2aIWEVzr+cmS09xNol2+WEXNHurl9YBTVPsj/GBcu3cd2Ud9XPPBm3rJ4iCBrc Dnw0R0xnHy3SQC8Z0PT7EG9WYBspZG9rKRvr1f5oqTVBAby7yMG88WrgILOoSVOj35qh eJfDqbJGu/sl2UU4eQAod1Ps3Hw3MeKUnEGREVqtdTuDRQ2PGMZDKqtUySHP5gEB11pB g6hsug3QxYKvAdJJIu8M3Af7W4pS5f/SfM+KyOKzny7Gc5BHk/mu3QJSJSxfQNQONQTu v/xQgl+BfozcIjG2zol8Faeq/JAOknoPkgEwUqu5gIVq0lKIL7rG9DLd2BnGfTboDxOx O03A== X-Gm-Message-State: AOJu0Yw31RPooJp7NNNGF+smfldISt7BY+GM6YtqSLWS9xIru+N1gTK0 5mB9qhFLM1LfIz+xnigqePY= X-Google-Smtp-Source: AGHT+IEC8KG0OAYBWLV88hLTmt72BgeK72K/XPy7nJjcQSjux/3u19GpXicAHv62Ha2cEtqbLEE6mA== X-Received: by 2002:a19:2d05:0:b0:4f8:6abe:5249 with SMTP id k5-20020a192d05000000b004f86abe5249mr4742771lfj.3.1692620619475; Mon, 21 Aug 2023 05:23:39 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id w18-20020a19c512000000b004fb9c625b4asm1695750lfe.210.2023.08.21.05.23.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2023 05:23:39 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Message-Id: Date: Mon, 21 Aug 2023 14:23:38 +0200 To: Mauro Aranda X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org, Eli Zaretskii , Thomas Fitzsimmons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro, the test has an unused variable binding, `const-opt`. Would you = please confirm that it is an oversight and can be removed, or was your = intention that it be used in the test? From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 10:43:45 2023 Received: (at 63290) by debbugs.gnu.org; 21 Aug 2023 14:43:45 +0000 Received: from localhost ([127.0.0.1]:57453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY689-0001Ch-CI for submit@debbugs.gnu.org; Mon, 21 Aug 2023 10:43:45 -0400 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]:54675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY687-0001CP-LB for 63290@debbugs.gnu.org; Mon, 21 Aug 2023 10:43:43 -0400 Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3a81154c570so2044295b6e.1 for <63290@debbugs.gnu.org>; Mon, 21 Aug 2023 07:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692629016; x=1693233816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rXF4451NB3VYhe3qGqXgXjozRG/ZSEG2i4DW3mkm/0c=; b=Sb1z6pHOp1/tJGhMknPR5IzXZY5FkyJY9KZcbZ6HhuOn1nQueG/ghorNanKJ4deRQA tHUcUvCMynTyGKdCk6+quQFfW6LQWkItZRs53w53yV/s3XLq+KiGo/F8jPQdcxtyF6Cy qik71MQkQkxabSZFXo178IdoiYFKJVXcyvxawZggKLamjveqjiviV6TytggJ7AFgpIJW 4SN/HViu2buRYdoOXXTX6Q/fJgYg6Vs0K3TttqAJNGmMjJB8x57VROVwaHakDvz6SCtN VLjk+I1BE+w4SrkdzzHeTJmASwwBs+MFMmr/G4MFs4Laz2PbiqtHgjIYSdHGlA4AIWuj 7PtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692629016; x=1693233816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rXF4451NB3VYhe3qGqXgXjozRG/ZSEG2i4DW3mkm/0c=; b=crPP8U//9HpecwsvN1/UD4FuQHZ7UDr2nAKNJiy6C4Xkj/mdBz8pP6bwWsNIAyypK0 T/H7V4IB1KM84hhOExFNAST1Jx5xDQp55JI9yM4SgpbiAxTnT4tO8c2lyzMU5eCalTYg 6gvSjgPhxzQ625TssSNxdXOl6M6Oskmblpv7+uKGt/zWTvngnlNCOHwRsAcAzSzIe7L3 LSVBYAHd9+XIvy3JPjVdm3/NIRMPb3nz6Fa3o/RtIrrxMA6sfkEwYHHpwD4PGnwOHyjs HK4/H8RjHtgXz9S35uaFj8NEEpS71TeEDck9rknEHk4HduqGXMR7+R7x3x4Nt2nrUIOZ GXPg== X-Gm-Message-State: AOJu0Yzl9gsl3VYDdELorXhoEoMT67eJuzTXdhaybOUgb5ojMx5+LwIj 1IDQp9joeW5Dj1jNEUWfTgg= X-Google-Smtp-Source: AGHT+IEtE6yMeoyo9lTD/Wstvkg9nr1vhGf4fFdLCQfzm1X7HD5NEdtCxXpQTdpAI16AGWNJpRVTnQ== X-Received: by 2002:a05:6808:8d1:b0:3a7:6ddd:5046 with SMTP id k17-20020a05680808d100b003a76ddd5046mr5565132oij.43.1692629015691; Mon, 21 Aug 2023 07:43:35 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id bd41-20020a056808222900b003a4825088ffsm3625766oib.51.2023.08.21.07.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 07:43:35 -0700 (PDT) Message-ID: <318f4af5-55dc-8eb8-4875-5cb2ff612ced@gmail.com> Date: Mon, 21 Aug 2023 11:43:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Content-Language: en-US To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org, Eli Zaretskii , Thomas Fitzsimmons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Mattias Engdegård writes: > Mauro, the test has an unused variable binding, `const-opt`. Would you > please confirm that it is an oversight and can be removed, or was your > intention that it be used in the test? Hi Mattias, It was a copy-pasta from the previous let.  It should be removed. Thanks for catching it! From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 11:24:58 2023 Received: (at 63290) by debbugs.gnu.org; 21 Aug 2023 15:24:58 +0000 Received: from localhost ([127.0.0.1]:57538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6m2-00086Q-G0 for submit@debbugs.gnu.org; Mon, 21 Aug 2023 11:24:58 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:47475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6m0-000861-VT for 63290@debbugs.gnu.org; Mon, 21 Aug 2023 11:24:57 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b962c226ceso55310551fa.3 for <63290@debbugs.gnu.org>; Mon, 21 Aug 2023 08:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692631489; x=1693236289; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=9/cWS8Bq1haNMSSWE8zJ0xyY8Kxf233SpTQ2K9/VFDo=; b=eSDpBBAtfu9pfZc9BL41kkxb4OD/wPogm787JZ0xInsPUXfwxYFv6tJGMPpjAZUjrf o2rOYnHR9cJ6WrsKi2hzbAkmpGJACu7jdvL19WqjcOCnYl2Mlv9vrQmghSYxYQTTZPzI MeGVjJPcXCSHUwfNAtpGElfoK7Ak4NRtqjwKMn/hakevP/nL7VIl7Bty3j5N6X3CY1J1 Em6hcvuBi5a2i6Qkj19xVjnvVVW75j7V//jD3SL+/QJOKtjq84VL3J+NRouRrhN8TlLS RrllOf4CBKDDu2D4KUucdZyTn1Ybl7DMTcJ30obejsaYokBQCQ9fry/cBFTDm4Drp/j0 BmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692631489; x=1693236289; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9/cWS8Bq1haNMSSWE8zJ0xyY8Kxf233SpTQ2K9/VFDo=; b=bMHrFioyEEshrlq7LAIuxTb25+qAM9Pn0y+7iW9r9QI6FiCuaAVOfU2A7aczgyfFvo Ti63EybmT5lNZyArxQ+u5VJCDGnt0y0EwyTg4xwkwkabZFPg4dOyY8C/gisofv6RF+WE 5L0O22IBx12R2y+uNeXIaBxaCHy9qDVYkuaHmnJUgg03+Gh1BGq9VlNqNwozv5K1OZop YX7PbI/vJxOjc6mekEnx9ZGf43ljzEtqpLn59gJpawD95jvAXYM7bOds52ZSELswq47g QzXTgfreTF8MNCTmmgnoOcpouv9DX03xxaBMcCNLPyG/ZF1iVzVDDVyo8rTXrB92ZS/J 6/lQ== X-Gm-Message-State: AOJu0YymH6Sc+Z589rUHTykDhaoXsi8X5vUv/opLOGyIdMVg4x/7xLcS qPungPVwZso9qMfWUfQNIAs= X-Google-Smtp-Source: AGHT+IFEPoyWtCUEQGEtvLjF6t9d9E/0S5ibkLeOf21HcMNEt5jNccyXj+qKrWeibrSxGPA7282Z4A== X-Received: by 2002:a2e:9851:0:b0:2b9:f1ad:94f5 with SMTP id e17-20020a2e9851000000b002b9f1ad94f5mr5040642ljj.40.1692631488600; Mon, 21 Aug 2023 08:24:48 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id k4-20020a2e9204000000b002b6ec6cb24bsm2345538ljg.57.2023.08.21.08.24.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2023 08:24:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <318f4af5-55dc-8eb8-4875-5cb2ff612ced@gmail.com> Date: Mon, 21 Aug 2023 17:24:47 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <318f4af5-55dc-8eb8-4875-5cb2ff612ced@gmail.com> To: Mauro Aranda X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63290 Cc: 63290@debbugs.gnu.org, Eli Zaretskii , Thomas Fitzsimmons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 21 aug. 2023 kl. 16.43 skrev Mauro Aranda : > It was a copy-pasta from the previous let. It should be removed. Now removed. > Thanks for catching it! Oh, thank the compiler. I'm just the messenger. From unknown Fri Aug 15 04:08:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Sep 2023 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator