GNU bug report logs - #63288
30.0.50; Emacs 30 packages fail to build with native comp on some machines

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> posteo.net>

Date: Fri, 5 May 2023 04:00:02 UTC

Severity: normal

Found in version 30.0.50

Done: Pip Cet <pipcet <at> protonmail.com>

Bug is archived. No further changes may be made.

Full log

Message #74 received at 63288 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: damien <at> merenne.me, Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org,
 63288 <at> debbugs.gnu.org
Subject: Re: bug#63288: 30.0.50; Emacs 30 packages fail to build with native
 comp on some machines
Date: Sat, 15 Feb 2025 23:33:26 -0500

> diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
> index caaffcf19be..42830ca9f7a 100644
> --- a/lisp/emacs-lisp/cl-macs.el
> +++ b/lisp/emacs-lisp/cl-macs.el
> @@ -2701,7 +2701,7 @@ cl--do-proclaim
>  	 (let ((speed (assq (nth 1 (assq 'speed (cdr spec)))
>  			    '((0 nil) (1 t) (2 t) (3 t))))
>  	       (safety (assq (nth 1 (assq 'safety (cdr spec)))
> -			     '((0 t) (1 t) (2 t) (3 nil)))))
> +			     '((0 t) (1 nil) (2 nil) (3 nil)))))
>  	   (if speed (setq cl--optimize-speed (car speed)
>  			   byte-optimize (nth 1 speed)))
>  	   (if safety (setq cl--optimize-safety (car safety)

LGTM.  I'd also deprecate this machinery.
For the case at hand, I think a better option is to add keyword
arguments to `cl-defstruct` to control whether accessors need to check
the type of their arg.


        Stefan
This bug report was last modified 132 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.