From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 May 2023 11:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63263@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168319953123949 (code B ref -1); Thu, 04 May 2023 11:26:03 +0000 Received: (at submit) by debbugs.gnu.org; 4 May 2023 11:25:31 +0000 Received: from localhost ([127.0.0.1]:48730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puX5X-0006EC-5W for submit@debbugs.gnu.org; Thu, 04 May 2023 07:25:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:42212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puX5T-0006Dq-7j for submit@debbugs.gnu.org; Thu, 04 May 2023 07:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puX5J-00018S-Lq for guix-patches@gnu.org; Thu, 04 May 2023 07:25:23 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puX5F-0006Dq-HG for guix-patches@gnu.org; Thu, 04 May 2023 07:25:15 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 81B8527BBE2 for ; Thu, 4 May 2023 12:24:49 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 4f989652 for ; Thu, 4 May 2023 11:24:48 +0000 (UTC) From: Christopher Baines Date: Thu, 4 May 2023 12:24:48 +0100 Message-Id: <20230504112448.22462-1-mail@cbaines.net> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In Guile, it's possible to produce output from write that can't be read, and this applies to the code staged through g-expressions for derivations. This commit detects this early when the derivation is being created, rather than leaving the error to happen when the derivation is built. This is important as it means that tools like guix lint will indicate that there's a problem, hopefully reducing the number of broken derivations in Guix. * guix/gexp.scm (gexp->derivation): Check that the builder script can be read. --- guix/gexp.scm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index 0fe4f1c98a..7af9302ccf 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -1215,9 +1215,18 @@ (define (add-modules exp modules) #:target target) (return #f))) (guile -> (lowered-gexp-guile lowered)) - (builder (text-file script-name - (sexp->string - (lowered-gexp-sexp lowered))))) + (builder (text-file + script-name + (let ((builder-string + (sexp->string + (lowered-gexp-sexp lowered)))) + (catch 'read-error + (lambda () + (call-with-input-string builder-string + read) + builder-string) + (lambda (key . args) + (error "invalid gexp" name exp args))))))) (mbegin %store-monad (set-grafting graft?) ;restore the initial setting (raw-derivation name -- 2.39.1 From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 May 2023 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.16832044579510 (code B ref 63263); Thu, 04 May 2023 12:48:02 +0000 Received: (at 63263) by debbugs.gnu.org; 4 May 2023 12:47:37 +0000 Received: from localhost ([127.0.0.1]:48781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puYMy-0002TJ-Bj for submit@debbugs.gnu.org; Thu, 04 May 2023 08:47:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puYMu-0002Sz-C4 for 63263@debbugs.gnu.org; Thu, 04 May 2023 08:47:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puYMo-0000wB-R1; Thu, 04 May 2023 08:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=u93X+qk8Qajat/oNLJHNhrOPpbyfB8/fKC3e0EjhEJ0=; b=G8S0AJXZj3u5OXVm6vkR Fp3Iexm/D+vmbnHi9lqHvkb7EcU6sNLS2L7lxvaGv/3mruqTOrKSXFDPh40OG17cPzf0YT0kRY1IY U6i9FGNB+Jw+D/a9lZlwz12afUlD0DNvt51gIJ9XYj/t0PGwVPrYo7f51G+MfUuFkGuLEohxtFH5e 7oirfQ8n8GLWVBEpyIe9qSgv7E1X8BvwDKREZ9fC8Pe/eF1mmSoMkfAXVgcSh5tpbRtDxOsPj/Y+y KZDeXDtc+CcqqYC94lIF0dEu6LwpJIQ81mkQpezq6IkT/UR4mK0pbnF8jjKHOaq4LOQKPoWH+Z9ux GdeUnB841bAA+A==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puYMo-0004vq-D3; Thu, 04 May 2023 08:47:26 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230504112448.22462-1-mail@cbaines.net> Date: Thu, 04 May 2023 14:47:23 +0200 In-Reply-To: <20230504112448.22462-1-mail@cbaines.net> (Christopher Baines's message of "Thu, 4 May 2023 12:24:48 +0100") Message-ID: <87zg6kqn50.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > In Guile, it's possible to produce output from write that can't be read, = and > this applies to the code staged through g-expressions for derivations. T= his > commit detects this early when the derivation is being created, rather th= an > leaving the error to happen when the derivation is built. > > This is important as it means that tools like guix lint will indicate that > there's a problem, hopefully reducing the number of broken derivations in > Guix. > > * guix/gexp.scm (gexp->derivation): Check that the builder script can be = read. Calling =E2=80=98read=E2=80=99 on every generated sexp is definitely not so= mething we should do, performance-wise. Commit 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c addressed that to some extent. It works in examples like this: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,lower (computed-file "foo" #~(list #$(current-module)= )) While executing meta-command: ERROR: 1. &gexp-input-error: # --8<---------------cut here---------------end--------------->8--- =E2=80=A6 where =E2=80=98current-module=E2=80=99 returns a non-serializable= object. I think the problem you=E2=80=99re trying to address that we frequently encounter is old-style packages that end up splicing gexps inside sexps, as in: (package ;; =E2=80=A6 (arguments `(#:phases (modify-phases whatever ,#~doh!)))) Is that right? The problem here is that =E2=80=98sexp->gexp=E2=80=99, which was added prec= isely as an optimization for build systems=C2=B9, does not check the sexp it=E2=80=99s = given. Example: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,lower (computed-file "foo" (sexp->gexp `(list a b c ,= (current-module)))) $19 =3D # 7f26baf56be0> scheme@(guile-user)> (sexp->gexp `(list a b c ,(current-module))) $20 =3D #) 7f26bbf2= f090> --8<---------------cut here---------------end--------------->8--- Oops! It would be tempting to change =E2=80=98sexp->gexp=E2=80=99 to traverse the= sexp in search of non-serializable things=E2=80=A6 but that=E2=80=99d defeat the wh= ole point of =E2=80=98sexp->gexp=E2=80=99. How about a linter instead, with the understanding that use of sexps in packages is vanishing? Perhaps coupled with a =E2=80=98guix style=E2=80=99= automatic rewriter. Thanks, Ludo=E2=80=99. =C2=B9 Packages would get long lists/trees in their =E2=80=98arguments=E2= =80=99 field. Traversing them in search of lowerable objects is costly, and =E2=80=98sexp->gexp=E2=80=99 was introduced precisely do we don=E2=80=99t= have to traverse the sexp. (Gexps are designed so that no such traversal is necessary at run time.) From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 May 2023 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.168320709714729 (code B ref 63263); Thu, 04 May 2023 13:32:02 +0000 Received: (at 63263) by debbugs.gnu.org; 4 May 2023 13:31:37 +0000 Received: from localhost ([127.0.0.1]:48832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZ3Y-0003pU-Hm for submit@debbugs.gnu.org; Thu, 04 May 2023 09:31:36 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZ3U-0003pD-GV for 63263@debbugs.gnu.org; Thu, 04 May 2023 09:31:34 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 6102A27BBE2; Thu, 4 May 2023 14:31:31 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 0deae971; Thu, 4 May 2023 13:31:30 +0000 (UTC) References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Thu, 04 May 2023 13:57:38 +0100 In-reply-to: <87zg6kqn50.fsf@gnu.org> Message-ID: <875y98nryn.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> In Guile, it's possible to produce output from write that can't be read,= and >> this applies to the code staged through g-expressions for derivations. = This >> commit detects this early when the derivation is being created, rather t= han >> leaving the error to happen when the derivation is built. >> >> This is important as it means that tools like guix lint will indicate th= at >> there's a problem, hopefully reducing the number of broken derivations in >> Guix. >> >> * guix/gexp.scm (gexp->derivation): Check that the builder script can be= read. > > Calling =E2=80=98read=E2=80=99 on every generated sexp is definitely not = something we > should do, performance-wise. > > Commit 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c addressed that to some > extent. It works in examples like this: > > scheme@(guile-user)> ,lower (computed-file "foo" #~(list #$(current-modul= e))) > While executing meta-command: > ERROR: > 1. &gexp-input-error: # > > > =E2=80=A6 where =E2=80=98current-module=E2=80=99 returns a non-serializab= le object. > > I think the problem you=E2=80=99re trying to address that we frequently > encounter is old-style packages that end up splicing gexps inside sexps, > as in: > > (package > ;; =E2=80=A6 > (arguments `(#:phases (modify-phases whatever ,#~doh!)))) > > Is that right? I think so, I can't remember if I've seen any other ways that this happens. > The problem here is that =E2=80=98sexp->gexp=E2=80=99, which was added pr= ecisely as an > optimization for build systems=C2=B9, does not check the sexp it=E2=80=99= s given. > Example: > > scheme@(guile-user)> ,lower (computed-file "foo" (sexp->gexp `(list a b c= ,(current-module)))) > $19 =3D # 7f26baf56be0> > scheme@(guile-user)> (sexp->gexp `(list a b c ,(current-module))) > $20 =3D #) 7f26bb= f2f090> > > Oops! > > It would be tempting to change =E2=80=98sexp->gexp=E2=80=99 to traverse t= he sexp in > search of non-serializable things=E2=80=A6 but that=E2=80=99d defeat the = whole point of > =E2=80=98sexp->gexp=E2=80=99. > > How about a linter instead, with the understanding that use of sexps in > packages is vanishing? Perhaps coupled with a =E2=80=98guix style=E2=80= =99 automatic > rewriter. A linter might be helpful, but I'm not sure it'll help that much. I think it's quite a lofty expectation for the linter to be run on packages that are edited, let alone on the packages affected by those changes (which is what's needed to catch this problem), so adding a linter will mean we get lint warnings, but we'll still be living with these broken derivations. The builds for affected derivations fail immediately, and it's pretty obvious from the log that the builder is unreadable, so it should already be possible to spot this problem from looking at the effect of package changes on builds, so I think the main way a linter will help is that it would provide a way to find out what derivations are broken in this way, without attempting to build all of them. I guess my perspective on this is more from the operation of the guix data service, which is carefully computing and storing all of these broken derivations (and there's a lot, like 10,000+ per revision at the moment, since they change every time you compute them). This then propagates down to the build coordinator as well, since there's builds being submitted for all these broken derivations. I have considered trying to detect these breakages in the data service, but I'm not sure how to do it while removing the possibility of false positives. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRTs7BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xeobg/+K8wwXAXEmjgLeHr60iMUPHfH4Nts6zJZ 4lQLG+kMNKtARuc8xQP/KxIwkuUkbb1gCwOcER+HDw6DSwAk4MtFzfEG7Ai7H5w2 XPB79I7FeKxithGaX11qowb3Obu10tMOc5WS8dkusXCLUOlqxVekGXn+DMu/Pfhi Wxnmm6GoUOuzVACUvowE5Cz9QVCB1P8/PWo7lqLOrNmfMpxFATVyBbA1ijSeNhM3 wLFHTTsLMnmZv7+CkEh/tKzXGWZ0AMOFq1HDmWhSPejgSTKtM5pQyySBCTvx0kd0 bYCRviuEGXuneiBhV2AkauoetM9muT/Q69pxTIpDh9x30/7+bib8azVSnmnwkIiQ q8sSK4wBOIqiZCGdDQBEqucEr+6po02MBwp7A5OArAETblkVUIg0wqiFkL3bgPgl C7goR/p3BUfIslEcquHG+7hgFqk0pdZeLHibvzTKS/zBYfuzMt2tUb3PUkzqGZfV 8VMD268voHcLmDEMflCecx5bt90WY869e5xK0kDebWR69Otupq1LweNfJI8h5CcK VsxlTbhCy0dYWZPwPIL4VfdGkjGdmcggeTVNjCJK4V9LUrJkiOc+nYoM2XtJKP2Z YKNYDHhyP3uD7/5EAURkC0dq++jRSKhP2yj1q0V0FLzDDZwIOJ253SjlcRzt4oL+ RRb6Mn9eNHA= =j0e4 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 May 2023 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.168322765224382 (code B ref 63263); Thu, 04 May 2023 19:15:02 +0000 Received: (at 63263) by debbugs.gnu.org; 4 May 2023 19:14:12 +0000 Received: from localhost ([127.0.0.1]:52101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pueP6-0006LC-D5 for submit@debbugs.gnu.org; Thu, 04 May 2023 15:14:12 -0400 Received: from jpoiret.xyz ([206.189.101.64]:35014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pueP4-0006L3-4f for 63263@debbugs.gnu.org; Thu, 04 May 2023 15:14:11 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id F40D0184F2D; Thu, 4 May 2023 19:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1683227648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w5Rgo9zd4+3P0i3wRbdsPpWMuJbxRsyr/8khsGvgSU8=; b=WcGGBfxdJM6LjKUw27KIcC4etFFs2fEtJ9F7uBf1g+GxNkBtwanSIFqMMTEz3OwTpmXfqg an8ag9De/kArUF5NL6O+Z2nNAknXJQKzFFmonfjkW00Mm3fIIUyfGZMRDYBzCeaa7Cccc7 ZHI62hIH1Q61BphdbdJEVRYWAHTCjZPDIqQ0UnkNHMB+du3QVOpzvgiMRItz0qxtbuAk9m llPiJAFBj7AW9fQT3gxNUhmPe3vXcYDLyTdkITRXAc0tYIF+Pvj5kgpXLTwvch6DscP5X3 iC9JYouEnZ4/zn1pxr5oEvCvh+DHoREQ7MRpJa0yuO1tqABKiL59f5cQlmTxIw== From: Josselin Poiret In-Reply-To: <875y98nryn.fsf@cbaines.net> References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> Date: Thu, 04 May 2023 21:14:05 +0200 Message-ID: <87y1m33o5e.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Chris and Ludo, Christopher Baines writes: > I guess my perspective on this is more from the operation of the guix > data service, which is carefully computing and storing all of these > broken derivations (and there's a lot, like 10,000+ per revision at the > moment, since they change every time you compute them). This then > propagates down to the build coordinator as well, since there's builds > being submitted for all these broken derivations. I have considered > trying to detect these breakages in the data service, but I'm not sure > how to do it while removing the possibility of false positives. I guess you already read the derivations from the data service to find out what has changed, right? Would you also be able to try to read the builder script from there, before trying to build? And if the derivation is bad, signal it somehow and flag it for some sort of gc? Although then, all other derivations depending on it would also need to be gc'd, which might be annoying. I don't know if the data service's architecture would allow this to be done before trying to build derivations though, sorry in advance if that would be too much work. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRUA/0QHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaiucaC/46cA5Fnamrlu1fZ3ZeknxPuuHsj1+NTlaZ GNdDkH07RPTDA0gl28CZUEgt/xYRwW8R0HGxK5xVMP3z0n/MOVwPfTZ1Lb3kOUaU Qjc/qKh3EYrpyTHwed4AshNAE1SepSfYGnCq6KZ5M5XxcSAF42bgyDUmbFaUbRps CYf5diJMSlIdZPTXrMYyAQbpNDZdX1wmKdLm+EXGli+NI4rXvPXjtm9MSIfM2i98 HVF5TCiXlg7hJeZRorymOPSf+Y9EVv/OqiZzQ1ojbzfoI9xFAn3FnjXHsB/iVCRQ Z91jtJj9s9j/271lxbFx1yheNIDFLla5ETWuztQ3L1uGch6edvvRa15Jp7RXHfi2 BHO5OEWzV/AI4P2ockAHxYS6fhVeEdrgZVvkElOvxnP1p7WpfDP5sg53fqBEJWJD nS1BBGAokegdmL8SF4R88GaazYBQIBLg/Y5mX9A8v8UcWqWbsqVDQO5XZDOR574k 4qTLv0UDzozq/DAWYjmJKkRFVf+zdU0= =9oUI -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.16833231532677 (code B ref 63263); Fri, 05 May 2023 21:46:02 +0000 Received: (at 63263) by debbugs.gnu.org; 5 May 2023 21:45:53 +0000 Received: from localhost ([127.0.0.1]:57719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv3FR-0000h5-Hb for submit@debbugs.gnu.org; Fri, 05 May 2023 17:45:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv3FP-0000gl-Vn for 63263@debbugs.gnu.org; Fri, 05 May 2023 17:45:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv3FK-0002gw-BV; Fri, 05 May 2023 17:45:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xGU1CIDSLdv/Q8iiHB/iZET2kf1aK4k10899PlmlzHA=; b=H1V9JnwPgHeTi/XuKmOZ 7Bnonc4BRoMoqsJT5lntnaJqhZt+jPcE//A2xHgsUBCv7jGBn6uENtB++CNd6Wx0lf7eV8HGxzqgS lgfXDz+6L24I944iI8Zk23uSLacrSb1Pdgw6lKPz10zb1v/mltZmZQjrxr2vY5/4AflUZ+1SfR49f BTv85TB7buqyjKG4RooTUDW+DWxmCh2mo3HvZ5RN2hHNLoeiisYTLUUl8as/ebctFJL6w9cshwcA5 kAIq5uUhzFmkuyC7KbiXluNxFFylgRvgTdaCywQEqtlrrhxZRResRyPtNPHlcdQaxWVJnCelHp0ex J2jI4NxaQcQBnQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv3FJ-00079D-VT; Fri, 05 May 2023 17:45:46 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> Date: Fri, 05 May 2023 23:45:44 +0200 In-Reply-To: <875y98nryn.fsf@cbaines.net> (Christopher Baines's message of "Thu, 04 May 2023 13:57:38 +0100") Message-ID: <87ild6mozb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Christopher Baines skribis: > Ludovic Court=C3=A8s writes: [...] >> How about a linter instead, with the understanding that use of sexps in >> packages is vanishing? Perhaps coupled with a =E2=80=98guix style=E2=80= =99 automatic >> rewriter. > > A linter might be helpful, but I'm not sure it'll help that much. Yeah. Another option is =E2=80=98guix style -S arguments=E2=80=99: . Not an immediate fix, but a tool that would let us move away more quickly from a situation that=E2=80=99s pr= one to this kind of error. [...] > I guess my perspective on this is more from the operation of the guix > data service, which is carefully computing and storing all of these > broken derivations (and there's a lot, like 10,000+ per revision at the > moment, since they change every time you compute them). Woow, that=E2=80=99s a lot! Could you send a sample of that list, for one system type, to get an idea of what=E2=80=99s going on? Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 07:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.168335903716062 (code B ref 63263); Sat, 06 May 2023 07:44:01 +0000 Received: (at 63263) by debbugs.gnu.org; 6 May 2023 07:43:57 +0000 Received: from localhost ([127.0.0.1]:58090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvCaC-0004B0-Ll for submit@debbugs.gnu.org; Sat, 06 May 2023 03:43:56 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvCa8-0004An-3z for 63263@debbugs.gnu.org; Sat, 06 May 2023 03:43:55 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 5572F1733B; Sat, 6 May 2023 08:43:50 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 327da71c; Sat, 6 May 2023 07:43:49 +0000 (UTC) References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87ild6mozb.fsf_-_@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Sat, 06 May 2023 08:39:21 +0100 In-reply-to: <87ild6mozb.fsf_-_@gnu.org> Message-ID: <87pm7d29cd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> I guess my perspective on this is more from the operation of the guix >> data service, which is carefully computing and storing all of these >> broken derivations (and there's a lot, like 10,000+ per revision at the >> moment, since they change every time you compute them). > > Woow, that=E2=80=99s a lot! Could you send a sample of that list, for one > system type, to get an idea of what=E2=80=99s going on? I think pretty much all the i586-gnu derivations were broken in this way, on core-updates but then after the merge to master too. I think I've "fixed" it now, although I think my change [1] needs some improvement (I fixed some issues in [2], but I saw an error when cross building). 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D08acdd0765b5f4fb= fafa699a823ea7985d4d35a7 2: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D08acdd0765b5f4fb= fafa699a823ea7985d4d35a7 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRWBTJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcEzg//ZSePJ2s7QWHOs6vF00uO9L+XKj6RhQ2A Hn9NY00yRYamjqqfEmUXjFy95hohT8q0QbmV2HAT3Fgf4WX5fBOE8Bjp2dIz46rV JnLZ/OIUv5oNGyZLZY+bVL2V0s2lFgxszoCzX7mDFzMprhSqrRccAYF0VMmHIYNZ cHjWka0sNKqnmQ2OfCfTeUU0mRHNRLcEzILiAxaS54ABDH2Ln2MvMn5jY5bWMmlc L1f8uoxIO0/Ql7c1ZRF8az3j8RiI1kgMCQ7MRNVqZAiD1iLPT6xjbfF1Pfp34ApR LG9LZty/cRi2Sp0OMrjMJqBfQQ/76LfxI6Ly7KDrlCOdX/gbgm0WQW2mNIPrrmq1 HrjSkDhkqgWPqvncSepM0xe5LeOh0q4Bcb5TNyyiuTqAnQzFextdMfjjw93s0N0P 7d345Ksxp6Dmri6QOc80gjM+y26oHXf2vOZU+IyPa0ZcdI5YxO2TkMidBolsFcbP WRIySwB7WyqB+d86kJFRH7quf7iERBCigdQv//UCqh4cfIKeBWN3mvN5k+f1Fde8 lKabunCGWaA4Q2KVS/DslRPorJ7RP96pUvFg/1MFEb1sBuwawtlXvBTbeuXhYAF4 lx4HDivXn+WiD0UcDksa16au1goVtLlcSQouVjLP5q3P09Doxc3hjR8bWzcis4MU kNhg/mGqkwo= =cMX1 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.168336070419877 (code B ref 63263); Sat, 06 May 2023 08:12:02 +0000 Received: (at 63263) by debbugs.gnu.org; 6 May 2023 08:11:44 +0000 Received: from localhost ([127.0.0.1]:59331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvD15-0005AW-Uv for submit@debbugs.gnu.org; Sat, 06 May 2023 04:11:44 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvD13-0005AK-Pf for 63263@debbugs.gnu.org; Sat, 06 May 2023 04:11:42 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 9B2BE27BBE2; Sat, 6 May 2023 09:11:40 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 0d299b4d; Sat, 6 May 2023 08:11:40 +0000 (UTC) References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87y1m33o5e.fsf@jpoiret.xyz> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Sat, 06 May 2023 09:05:43 +0100 In-reply-to: <87y1m33o5e.fsf@jpoiret.xyz> Message-ID: <87lei12820.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Josselin Poiret writes: > Christopher Baines writes: > >> I guess my perspective on this is more from the operation of the guix >> data service, which is carefully computing and storing all of these >> broken derivations (and there's a lot, like 10,000+ per revision at the >> moment, since they change every time you compute them). This then >> propagates down to the build coordinator as well, since there's builds >> being submitted for all these broken derivations. I have considered >> trying to detect these breakages in the data service, but I'm not sure >> how to do it while removing the possibility of false positives. > > I guess you already read the derivations from the data service to find > out what has changed, right? Would you also be able to try to read the > builder script from there, before trying to build? And if the > derivation is bad, signal it somehow and flag it for some sort of gc? > Although then, all other derivations depending on it would also need to > be gc'd, which might be annoying. > > I don't know if the data service's architecture would allow this to be > done before trying to build derivations though, sorry in advance if that > would be too much work. It would do, but I'm not sure this would be as reliable as doing the check from Guix, especially since the version of Guile used for the checking might be different. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRWC7dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd8yA/+NZ1HjOVWoUaNckfArWu8OH9OFAKLGKgQ fOnCw4E6zV+NK9H/70IWYNh5NjlPj/lRLQdZ9WaCbHu7LW5UKgWK5J0j0Si2QNYf PRxya+WmIwePKEnxbB2eLYXzFeaDVp35tyWsmEaOYP7OyPtw6ZeW9U5bWTt4j/oT z5Ucj1wYHokVPsDpOlm9W53UYFYS/6VVH9LX6QEipuTwwZD4zqFkEK9DOgquzeWE XTOwfMXxd4bCfQlGBNjGKqnm8TCE0CYz4SznIrFtII5a5K/WPXXIYtmIFun6J+cz BrgNKTetIJVpYDETxkVx3NQYywxoO5zAUEnxVoyLCxEmtrpX4cuDihEcYg18Z6q1 QiiSsjhKBrkr5ZF9ZKM6sGzbGbO7SBJEymil4suuq4KTke970JD/Fs3D2pQRt9zx gn9itM1p/FHZy1r271S4H3WYnWuutIVfWFgyc8JsdkN+oArp9y7Ng3EQWF/bjWc6 H5X+CXejVfoHRqMVTvuZKQuva+tJq6B61qpceYbg5qZsszcgF4AF8faAjVpi+fzn BS79SmYIAuaSRqldnbk3qF48k80KgmFXkCyAEGXGxZrLGq2esLYOlzLPQhAFQB+l otm++rzZye384GSgwilZcfTW38aceoIUk6wMqpoQcb/w554WkJFUuoZRmLnhvaC/ YUYWHPFWxuw= =zZHD -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 May 2023 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.16837321764093 (code B ref 63263); Wed, 10 May 2023 15:23:01 +0000 Received: (at 63263) by debbugs.gnu.org; 10 May 2023 15:22:56 +0000 Received: from localhost ([127.0.0.1]:48684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwleZ-00013x-L9 for submit@debbugs.gnu.org; Wed, 10 May 2023 11:22:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwleX-00013l-Ul for 63263@debbugs.gnu.org; Wed, 10 May 2023 11:22:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwleS-0006Yo-IX; Wed, 10 May 2023 11:22:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=LlI4SwMdrU9vUnNNr1hYEMLqw1pdO22yapFygodfj8M=; b=bCqGCJq0iux8K5wCsunD dxUCEvDjWvORwMMjag+qm0oyHXCAlKKlGNuhcZRFGcq+OFLhYLebbIijyB+i7fZAbw1KGZnv4+jNd 3FpuG3bZAJ5X+rbe5req6zShKouFIkqcNOYWAqerUyGdc73+zfdVN0+mpcI65ZzyzobVDaqP02ilI 8C6LM8dP39eyryW7EGHjlmuE82R6ZBnRwPLn004VZMk8LrEMEvAQNNnyJHCK+SzeBOks8b9Hd1fNj ffPQ6Lo1YEMJ7zcddNSWwhTqC22iyenEZTelSH1+gxb5KBvtKaaLrlG6X4o7uFzh5zs0kZD3+AaQJ sFxiju28F0MbFA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwleR-00062D-Vc; Wed, 10 May 2023 11:22:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87ild6mozb.fsf_-_@gnu.org> <87pm7d29cd.fsf@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 21 =?UTF-8?Q?Flor=C3=A9al?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Statice X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 10 May 2023 17:22:46 +0200 In-Reply-To: <87pm7d29cd.fsf@cbaines.net> (Christopher Baines's message of "Sat, 06 May 2023 08:39:21 +0100") Message-ID: <87a5yc9po9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Christopher Baines skribis: > Ludovic Court=C3=A8s writes: > >>> I guess my perspective on this is more from the operation of the guix >>> data service, which is carefully computing and storing all of these >>> broken derivations (and there's a lot, like 10,000+ per revision at the >>> moment, since they change every time you compute them). >> >> Woow, that=E2=80=99s a lot! Could you send a sample of that list, for o= ne >> system type, to get an idea of what=E2=80=99s going on? > > I think pretty much all the i586-gnu derivations Oh, I see. I=E2=80=99m less surprised then. :-) > were broken in this way, on core-updates but then after the merge to > master too. I think I've "fixed" it now, although I think my change > [1] needs some improvement (I fixed some issues in [2], but I saw an > error when cross building). I think we=E2=80=99re good now, right? Ludo=E2=80=99. From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 May 2023 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.16837346129322 (code B ref 63263); Wed, 10 May 2023 16:04:02 +0000 Received: (at 63263) by debbugs.gnu.org; 10 May 2023 16:03:32 +0000 Received: from localhost ([127.0.0.1]:48792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwmHs-0002QF-4i for submit@debbugs.gnu.org; Wed, 10 May 2023 12:03:32 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwmHp-0002Q6-Cg for 63263@debbugs.gnu.org; Wed, 10 May 2023 12:03:30 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id DC50127BBEC; Wed, 10 May 2023 17:03:28 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6c00a5e8; Wed, 10 May 2023 16:03:28 +0000 (UTC) References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87ild6mozb.fsf_-_@gnu.org> <87pm7d29cd.fsf@cbaines.net> <87a5yc9po9.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Wed, 10 May 2023 17:02:22 +0100 In-reply-to: <87a5yc9po9.fsf@gnu.org> Message-ID: <87354418dr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> Ludovic Court=C3=A8s writes: >> >>>> I guess my perspective on this is more from the operation of the guix >>>> data service, which is carefully computing and storing all of these >>>> broken derivations (and there's a lot, like 10,000+ per revision at the >>>> moment, since they change every time you compute them). >>> >>> Woow, that=E2=80=99s a lot! Could you send a sample of that list, for = one >>> system type, to get an idea of what=E2=80=99s going on? >> >> I think pretty much all the i586-gnu derivations > > Oh, I see. I=E2=80=99m less surprised then. :-) > >> were broken in this way, on core-updates but then after the merge to >> master too. I think I've "fixed" it now, although I think my change >> [1] needs some improvement (I fixed some issues in [2], but I saw an >> error when cross building). > > I think we=E2=80=99re good now, right? I spotted problems again today. I'm not sure if they're new, or just things I missed in the last round of fixes. I'm waiting for the data service to give it's opinion on these changes: https://issues.guix.gnu.org/63416 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRbwFBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfszg//Uh43XEsO9xGBvD+1F7COerFN26dQqB9W z1rBKbTI28m+AnJmNBlpNiDPk9VTFCL733ys1NYlSNpuskJwAQdAanGUQ5OEC6lc QtPugR4ULDtYi6KIXY68ewjcHXBU24g/t7ulR3ik2jUjIK4HltfplJYRgN5EKvM+ 0sV1l0Nfw4QekDU3F0OfCCA4cxLu/FOIgN/+2Ag6sy0ChIPK2OEY2Rns1dvDWW9Q cFVjiOX0hunv+R464/sRtsI5MFppJSXAPOry+/1zVuvKswfWC6hEMQZ2eN159VnD lLaNBd+dCWR1mK6b4O9uWw6gx2wy4D872WmNhqMm5WoSTBcd8gP58upJg8IE9RIu OHtcg2FM3Qp/tsprGTieoP2I4fvwRx+VUregsOgqy4aDJisrzRuvqpV4jXDpx/9D D3wtKE11iLLlrjGRfKZ0++3BHCexSWWmYE48L+/ZnIlMDzkxlD4+7fDYxZOqNrpE sSoYjdRElvmcns85YoZAWvjFlPROyemPzWUG/+NCYBXKFIkrRk1hDD4P0LqREGYo rocY37LXSn8iOjG/P9yGF3lB+S5lsW2pFw7f3/UuAx17D6MGoFUR8FSUpd4FPgM7 AWJ6PG4Byi112pDUCCq9FwWjKY8M3Z9q2lgyjWwHuzLUbZSLyUqvuwV9KeQw8i5h bCiFZ0hX68I= =n6Kq -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Sep 2023 14:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.169357782528110 (code B ref 63263); Fri, 01 Sep 2023 14:18:03 +0000 Received: (at 63263) by debbugs.gnu.org; 1 Sep 2023 14:17:05 +0000 Received: from localhost ([127.0.0.1]:33559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc4xN-0007JK-7Q for submit@debbugs.gnu.org; Fri, 01 Sep 2023 10:17:05 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:48270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc4xL-0007Im-Oi for 63263@debbugs.gnu.org; Fri, 01 Sep 2023 10:17:04 -0400 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-64b3ae681d1so10046706d6.0 for <63263@debbugs.gnu.org>; Fri, 01 Sep 2023 07:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693577808; x=1694182608; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=aCl9fqutysXcYJ5/WAIfieoMoiyZQttBWRTtdfqfBOY=; b=lJs6rZxZq09as8FtmJ135pri3Ybjgw79TT/firiYxwu+LA7YU0U7VEYYNmQNWzZZTt +69yR/Uhv6DxLHBHjiEE3dCW4cwuYjS7bU9va5X8Yxk+GX0ICsAkM/RoBxltm2KKjHnA jeRBR4VVtNgkXLteYW4jPlZ+KHj7r+U235Bvwc5CNvNXG01fnuU7eCulo33aou0trTaI hki8T8VdsQ9Ya97gZEG1LJVOTDfx/GthsfaOASahGJpd80m/AI+e1yzJ8Bh48SBaktsf mUFePhmRAHAFGFegIQemj6UTG2vj3W/UrxaxMmcy1B0AIebARszup+u6pGZM+hhdAPIt a4cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693577808; x=1694182608; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aCl9fqutysXcYJ5/WAIfieoMoiyZQttBWRTtdfqfBOY=; b=P1b+Ivjp1hV5YUwmtE0J8PkxRd1FnPzNUHzGU/j0KhW3vX5gpQ3+mTXExXQo62EFxZ bjAgSSbvNhxwaADVa6yMgQZMAduAyOeq3ks/+LMmnoQHdyneR5sX84eJaCSFT9QaZ9kB 0AThNEmOEtfJHAs0Cinq5usxQgoy+pQNV9OeUWTpNIvcwpQza7MZ71YeSuhSNN0tp5d7 vxIwJEqRN77YG6DcAxC51i/heGF9ndRf71hUDORVETgEyIRXYgdF+Ds36vrbVsBkU0Qg 5g0F7hiGMk6dxbw5/SslbbUJ74o8fHe9vOTa63fcn1gWfr0OmL15bK2vZgjY+Y3VbS4J gd6g== X-Gm-Message-State: AOJu0YxIKUov21ZwRfhsg+B/iKbGoGQEH/sGaFG7/u9TSsHuKlznd4B8 tVQ3tVIMKAjnq++dGRbLrSY5tnQuUb1cHQ== X-Google-Smtp-Source: AGHT+IFow2usFtvtRdtI7zRemtKA+jZVRhJ58YWPy4xkOcSYlsWOjJjz9cgDDT6vGP4ZM1Od1o9hNg== X-Received: by 2002:a0c:f249:0:b0:64f:5729:7994 with SMTP id z9-20020a0cf249000000b0064f57297994mr1891805qvl.30.1693577808377; Fri, 01 Sep 2023 07:16:48 -0700 (PDT) Received: from hurd (dsl-154-228.b2b2c.ca. [66.158.154.228]) by smtp.gmail.com with ESMTPSA id h3-20020a0cf203000000b0064a1fc557fbsm1450378qvk.139.2023.09.01.07.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 07:16:48 -0700 (PDT) From: Maxim Cournoyer References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87ild6mozb.fsf_-_@gnu.org> <87pm7d29cd.fsf@cbaines.net> <87a5yc9po9.fsf@gnu.org> <87354418dr.fsf@cbaines.net> Date: Fri, 01 Sep 2023 10:16:47 -0400 In-Reply-To: <87354418dr.fsf@cbaines.net> (Christopher Baines's message of "Wed, 10 May 2023 17:02:22 +0100") Message-ID: <87v8cu2d2o.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Christopher, Christopher Baines writes: [...] >>> I think pretty much all the i586-gnu derivations >> >> Oh, I see. I=E2=80=99m less surprised then. :-) >> >>> were broken in this way, on core-updates but then after the merge to >>> master too. I think I've "fixed" it now, although I think my change >>> [1] needs some improvement (I fixed some issues in [2], but I saw an >>> error when cross building). >> >> I think we=E2=80=99re good now, right? > > I spotted problems again today. I'm not sure if they're new, or just > things I missed in the last round of fixes. > > I'm waiting for the data service to give it's opinion on these changes: > > https://issues.guix.gnu.org/63416 Was the problem resolved? If so, can we close this issue? --=20 Thanks, Maxim From unknown Sun Jun 22 22:46:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#63263: closed (Re: bug#63263: [PATCH] gexp: Stop generating unreadable builder scripts.) Message-ID: References: <87ledoeu5p.fsf@cbaines.net> <20230504112448.22462-1-mail@cbaines.net> X-Gnu-PR-Message: they-closed 63263 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63263@debbugs.gnu.org Date: Sat, 02 Sep 2023 10:40:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1693651201-1625-1" This is a multi-part message in MIME format... ------------=_1693651201-1625-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63263: [PATCH] gexp: Stop generating unreadable builder scripts. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63263@debbugs.gnu.org. --=20 63263: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63263 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693651201-1625-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63263-close) by debbugs.gnu.org; 2 Sep 2023 10:39:30 +0000 Received: from localhost ([127.0.0.1]:35288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcO2M-0000PT-7D for submit@debbugs.gnu.org; Sat, 02 Sep 2023 06:39:30 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcO2J-0000PL-RL for 63263-close@debbugs.gnu.org; Sat, 02 Sep 2023 06:39:28 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id 6067827BBE2; Sat, 2 Sep 2023 11:39:17 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ed82ed09; Sat, 2 Sep 2023 10:39:16 +0000 (UTC) References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87ild6mozb.fsf_-_@gnu.org> <87pm7d29cd.fsf@cbaines.net> <87a5yc9po9.fsf@gnu.org> <87354418dr.fsf@cbaines.net> <87v8cu2d2o.fsf_-_@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines To: Maxim Cournoyer Subject: Re: bug#63263: [PATCH] gexp: Stop generating unreadable builder scripts. Date: Sat, 02 Sep 2023 11:36:43 +0100 In-reply-to: <87v8cu2d2o.fsf_-_@gmail.com> Message-ID: <87ledoeu5p.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63263-close Cc: 63263-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: > Hi Christopher, > > Christopher Baines writes: > > [...] > >>>> I think pretty much all the i586-gnu derivations >>> >>> Oh, I see. I=E2=80=99m less surprised then. :-) >>> >>>> were broken in this way, on core-updates but then after the merge to >>>> master too. I think I've "fixed" it now, although I think my change >>>> [1] needs some improvement (I fixed some issues in [2], but I saw an >>>> error when cross building). >>> >>> I think we=E2=80=99re good now, right? >> >> I spotted problems again today. I'm not sure if they're new, or just >> things I missed in the last round of fixes. >> >> I'm waiting for the data service to give it's opinion on these changes: >> >> https://issues.guix.gnu.org/63416 > > Was the problem resolved? If so, can we close this issue? Nope, but the issue covering this is #62051. We can close this patch issue though, as I think there were objections to the approach. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmTzENJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xei+A//QgwbKMo3zma2Umt3HTFwlKDdPNIPumgb yn4bXwkuw+de8hh2rPNtPzoQMeGnb9O0pZ+Wz1SLZefDw5jVIbYc/9D4G2E7mM/k lGf0UXtEQB/0jTqd+/eIY/86IptGgDyhDvrbW/6XP3GYq4Aa9Ln1wiaDBbcgyty4 lqVXeB1jHPj669hVJYzYyqpwnGpxKf/+JBkBJKJov+0JzRjo0AQ/j3f/jOkCB8mj VUFQqTj6xgAxTN90Ypr5Fu+U67j2ub7v/+nHPAgv/dS6aEUPRghwbmW0qWodASAF o+O4cdX49eNSzMKf3viXADfc+79z8Toe1RoPpWLQI5WrZc8RPJ/mwk/y0gSNzrot 3O5GcHgL7U3MLk3uQQBDK2G5DIRm2PVhzvM7+zEpk4X3Z4VPVc2yzgINv9rg8x7W uyxusqHYYcmvvSV3dGsNC5XsPcagtB5fP51shP09pRB7OffwhFygOK5u1UmEPj9l PyKLN2Co9Yf4sE9GIbxBfO5iwsLwo/UrblkklB1BkAXvgvUQjNFkHvByLsWndSTG EXmkPIOvFnl+zJcpMcfKGGXleAV2S2Sjbn6qOYWAm7+l4VXbAbJGCaq9r/0JbohP PB514w8G4Nzlpx3nX8S3ST4QR4escz3c78TVvWcyLn6iAlSPxfuG/HC7j8fi44pW 1WTlnMjiFLc= =0VvU -----END PGP SIGNATURE----- --=-=-=-- ------------=_1693651201-1625-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 May 2023 11:25:31 +0000 Received: from localhost ([127.0.0.1]:48730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puX5X-0006EC-5W for submit@debbugs.gnu.org; Thu, 04 May 2023 07:25:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:42212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puX5T-0006Dq-7j for submit@debbugs.gnu.org; Thu, 04 May 2023 07:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puX5J-00018S-Lq for guix-patches@gnu.org; Thu, 04 May 2023 07:25:23 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puX5F-0006Dq-HG for guix-patches@gnu.org; Thu, 04 May 2023 07:25:15 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 81B8527BBE2 for ; Thu, 4 May 2023 12:24:49 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 4f989652 for ; Thu, 4 May 2023 11:24:48 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] gexp: Stop generating unreadable builder scripts. Date: Thu, 4 May 2023 12:24:48 +0100 Message-Id: <20230504112448.22462-1-mail@cbaines.net> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In Guile, it's possible to produce output from write that can't be read, and this applies to the code staged through g-expressions for derivations. This commit detects this early when the derivation is being created, rather than leaving the error to happen when the derivation is built. This is important as it means that tools like guix lint will indicate that there's a problem, hopefully reducing the number of broken derivations in Guix. * guix/gexp.scm (gexp->derivation): Check that the builder script can be read. --- guix/gexp.scm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index 0fe4f1c98a..7af9302ccf 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -1215,9 +1215,18 @@ (define (add-modules exp modules) #:target target) (return #f))) (guile -> (lowered-gexp-guile lowered)) - (builder (text-file script-name - (sexp->string - (lowered-gexp-sexp lowered))))) + (builder (text-file + script-name + (let ((builder-string + (sexp->string + (lowered-gexp-sexp lowered)))) + (catch 'read-error + (lambda () + (call-with-input-string builder-string + read) + builder-string) + (lambda (key . args) + (error "invalid gexp" name exp args))))))) (mbegin %store-monad (set-grafting graft?) ;restore the initial setting (raw-derivation name -- 2.39.1 ------------=_1693651201-1625-1-- From unknown Sun Jun 22 22:46:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Sep 2023 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 63263-close@debbugs.gnu.org Received: via spool by 63263-done@debbugs.gnu.org id=D63263.16937628614198 (code D ref 63263); Sun, 03 Sep 2023 17:41:02 +0000 Received: (at 63263-close) by debbugs.gnu.org; 3 Sep 2023 17:41:01 +0000 Received: from localhost ([127.0.0.1]:46821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcr5p-00015e-1x for submit@debbugs.gnu.org; Sun, 03 Sep 2023 13:41:01 -0400 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]:44429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcr5m-00015Q-C0 for 63263-close@debbugs.gnu.org; Sun, 03 Sep 2023 13:40:59 -0400 Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-573249e73f8so563529eaf.1 for <63263-close@debbugs.gnu.org>; Sun, 03 Sep 2023 10:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693762853; x=1694367653; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AExzEetPX+adYvHs4Xup+10IqqYfnQKRxDADldZsavo=; b=krdM+8OnitOYvUoEnNvzdyX8ru9sCTg4Iyy5NTKbMs4ibhu1Qia568nkfQ817Cosxs zKRhqC0GhEXShN2nFngMDrI3WG3jCpYDKemFRE61qzpBXRwFfi8zVLgrbqA99s1EO/h7 hs47JvYKqpzWQ8y9lHW2X1jbMkskjsihwG7GbhPtbcyfvyGw53qffeZpBsIbAjVuBnNj is4VFwbZNXPICtQ32sksWGmeSXhuk9R8/sXY1ORv7yTO+pvleJJUWQ4XAVev+NHVml0m X3ikDM9OZJF2i42KIm6RTV67+66Ybo8ellGBqnKxO/7taqxwmxXkPSMt3HlLOuAt5r6q sQpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693762853; x=1694367653; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AExzEetPX+adYvHs4Xup+10IqqYfnQKRxDADldZsavo=; b=D96YOBSsbHgDr21x9p08ysxBv9Y3Z6a0mopIjZd0zMIVwSZ40TUMCA/D4H2OQW52bc cpnhtfLIXlc5JtTtaKhaNFqt5FM9QeNyoOlJLDeth0zC/8lOW6X5tlmgJDtVqnwNdyM4 kKdSauAybnE7psMfGbTdZfTq9Od8vwmUyBwXjYDmFFifTtoVYR+QsDt/mgmuIpmLzzXN HlRuN6w+Te3oaU+5r7srbwXGsO2MD2biCOCD1ft3/xmRXQRhwtuA3ePNrNqOIYL5Twvi p8UqGpDgzYN+cyPWjpDp93MHBWUXRZNj7AB7e1XlvxheXGLod4XSe0zWzRiceMrtedQ/ t9kw== X-Gm-Message-State: AOJu0YzBhjr2SiY2L4GB/QS6ksWwpZjMjDG9L+T/sq1FhUdTZaEgo0jS aayxjZL4zKXGM40aeB4AZiIb0GEYrgDg8w== X-Google-Smtp-Source: AGHT+IEwJGD//VuivJwj8ePS40p7qMzxa+wj9DJ8i59Yid4IAT8Kt9e/amXqTZUH41m/8KXi6YZcag== X-Received: by 2002:a05:620a:22f3:b0:76f:78:c9f8 with SMTP id p19-20020a05620a22f300b0076f0078c9f8mr7153140qki.28.1693752857766; Sun, 03 Sep 2023 07:54:17 -0700 (PDT) Received: from hurd (dsl-10-135-141.b2b2c.ca. [72.10.135.141]) by smtp.gmail.com with ESMTPSA id d7-20020a05620a158700b0076cb3690ae7sm2736301qkk.68.2023.09.03.07.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 07:54:17 -0700 (PDT) From: Maxim Cournoyer References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87ild6mozb.fsf_-_@gnu.org> <87pm7d29cd.fsf@cbaines.net> <87a5yc9po9.fsf@gnu.org> <87354418dr.fsf@cbaines.net> <87v8cu2d2o.fsf_-_@gmail.com> <87ledoeu5p.fsf@cbaines.net> Date: Sun, 03 Sep 2023 10:54:16 -0400 In-Reply-To: <87ledoeu5p.fsf@cbaines.net> (Christopher Baines's message of "Sat, 02 Sep 2023 11:36:43 +0100") Message-ID: <87bkejux2f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, [...] > Nope, but the issue covering this is #62051. > > We can close this patch issue though, as I think there were objections > to the approach. Thank you. By the way, I think '-close' has been obsoleted by '-done' in Debbugs; not sure what it does differently, if anything. -- Thanks, Maxim