GNU bug report logs - #63261
Recent changes to git config cause errors for non-committers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63261: closed (Recent changes to git config cause errors for
 non-committers)
Date: Sun, 07 May 2023 03:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 06 May 2023 23:34:42 -0400
with message-id <87y1m024rx.fsf <at> gmail.com>
and subject line Re: bug#63261: Recent changes to git config cause errors for non-committers
has caused the debbugs.gnu.org bug report #63261,
regarding Recent changes to git config cause errors for non-committers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63261: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63261
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brian Cully <bjc <at> spork.org>
To: bug-guix <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Recent changes to git config cause errors for non-committers
Date: Thu, 04 May 2023 06:47:32 -0400

I've run into two issues with the recent changes to git config 
integration:

1) All commits must now be signed, even if you're not a 
committer. This breaks just tons of things, including 
rebasing. I'm not sure how to fix this without just disabling that 
configuration line altogether.

2) Some ‘make’ rules now require git to be installed so that ‘git 
config’ can add ‘etc/git/gitconfig’ to the local 
configuration. So, for instance, ‘guix shell --pure -D guix -- 
make’ will now fail. Calls to git should be prefixed with a test 
to see if there is a git executable in the path.

-bjc

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Brian Cully via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 63261-done <at> debbugs.gnu.org, Brian Cully <bjc <at> spork.org>
Subject: Re: bug#63261: Recent changes to git config cause errors for
 non-committers
Date: Sat, 06 May 2023 23:34:42 -0400

Hi,

Brian Cully via Bug reports for GNU Guix <bug-guix <at> gnu.org> writes:

> I've run into two issues with the recent changes to git config
> integration:
>
> 1) All commits must now be signed, even if you're not a
> committer. This breaks just tons of things, including rebasing. I'm
> not sure how to fix this without just disabling that configuration
> line altogether.
>
> 2) Some ‘make’ rules now require git to be installed so that ‘git
> config’ can add ‘etc/git/gitconfig’ to the local configuration. So,
> for instance, ‘guix shell --pure -D guix -- make’ will now fail. Calls
> to git should be prefixed with a test to see if there is a git
> executable in the path.

2. has been fixed (also by Ludovic, ah!).  I'm not sure a good solution
can be found for 1. but it seems reasonable to me that contributors
working on Guix learn to sign their commits with GnuPG; that way they
are on the right path to become a Guix committer, already getting up to
speed with the required practices.

Closing, but we can continue discussing it.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.