GNU bug report logs - #63260
29.0.90; Regression installing/activating packages without autoloads

Previous Next

Full log

Message #28 received at 63260 <at> debbugs.gnu.org (full text, mbox):

From: Basil Contovounesios <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63260 <at> debbugs.gnu.org, Robert Pluim <rpluim <at> gmail.com>, philipk <at> posteo.net
Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages
 without autoloads
Date: Sat, 06 May 2023 15:12:31 +0200

Eli Zaretskii [2023-05-06 05:00 -0400] wrote:

>> Cc: 63260 <at> debbugs.gnu.org, Philip Kaludercic <philipk <at> posteo.net>
>> From: Robert Pluim <rpluim <at> gmail.com>
>> Date: Fri, 05 May 2023 08:36:51 +0200
>> 
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index 0919ce34448..4b488281b78 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -4491,11 +4491,11 @@ package-quickstart-refresh
>>        (insert ";;; Quickstart file to activate all packages at startup  -*- lexical-binding:t -*-\n")
>>        (insert ";; ¡¡ This file is autogenerated by `package-quickstart-refresh', DO NOT EDIT !!\n\n")
>>        (dolist (pkg package--quickstart-pkgs)
>> -        (let* ((file
>> -                ;; Prefer uncompiled files (and don't accept .so files).
>> -                (let ((load-suffixes '(".el" ".elc")))
>> -                  (locate-library (package--autoloads-file-name pkg))))
>> -               (pfile (prin1-to-string file)))
>> +        (when-let* ((file
>> +                     ;; Prefer uncompiled files (and don't accept .so files).
>> +                     (let ((load-suffixes '(".el" ".elc")))
>> +                       (locate-library (package--autoloads-file-name pkg))))
>> +                    (pfile (prin1-to-string file)))
>>            (insert "(let ((load-true-file-name " pfile ")\
>>  \(load-file-name " pfile "))\n")
>>            (insert-file-contents file)
>
> Philip, Basil: is the above okay with you?  I'd like this issue
> resolved before making the next pretest of Emacs 29.1.

As I said in my other message, AFAICT this fixes a symptom specific to
package-quickstart of the more general autoload file problem
reintroduced by dd21003878d.

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.