From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 06:15:32 2023 Received: (at submit) by debbugs.gnu.org; 4 May 2023 10:15:33 +0000 Received: from localhost ([127.0.0.1]:48617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puVzo-0003yu-7B for submit@debbugs.gnu.org; Thu, 04 May 2023 06:15:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:46612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puVzi-0003yj-W6 for submit@debbugs.gnu.org; Thu, 04 May 2023 06:15:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puVzi-0005lV-PV for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 06:15:26 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puVze-0002iw-It for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 06:15:26 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-64115eef620so11190995b3a.1 for ; Thu, 04 May 2023 03:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683195319; x=1685787319; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=4XUqSEZ0DiT48XAkKO40R6wpm0nKug91rasftepW13Q=; b=fxQ5k+mFXYBhmKupuSr9PaJ6F/EU04pOjvbqt76NNYyVD5U/ov8RJxZ7bCDthz3iaA Gdcpd80CmeIFtrQjtXQtaCedEEQMJa711YzbXk/0QzpQaW8hXgXFV2PkQzwo4tkkznC8 fZcONdlD9AkAMw4OsQKcMZY9YTaueksUANIEs7Ykt+lWpHwzZVYa6EYCwLU+cR5HvfBW +xl1lkoC3kpxpYgBnZ6rtPaasD4S2NeiA2Cv2Up0jNP9t/qP+RNg4DXzuWxby9th2ylN bCwtsDB8A4Faq/a2+zXgcV7Fy/gOCz2P59up2Rhyu3V4AqylGDIZ/mILcZ1c+84IjODf blTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683195319; x=1685787319; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4XUqSEZ0DiT48XAkKO40R6wpm0nKug91rasftepW13Q=; b=dgljKLBMbzF2EDB+M5xNkhWVA+DIJq0AcKnpwK7Gbrz87790oEXWblJ3Jk3K6JgODD FkTYndripVDwkbWKLALzONk4QLF1eXaFEn9I/7/po1ANhkcZ4pccJxQcHncy/AbCu1I9 XhmL7kxgRDkcGBOIgxTDBlMzuferIE9XrcVQBuhhKNTw2D3gkLCfJDcloZsESiG9lwkl yPE+rUUBQZbQSD/JwVjclWsna7cGhF+BlEaYKsFbmnM9/LN3G5VM9xb+1sAI2ilyCU90 Roj3LB8Hyk8ncG9/0qJhB+azDUajk6kpYsNH6QSWkITpQRcQ+Vczt21xqumYFoKZL1IV lXXQ== X-Gm-Message-State: AC+VfDw7uvR7gZ5/S5Bal5+Y5qEIhyCSOY1z00y6LJbjq/rr/qTtNDEQ dlSEIY4FxtuosH3KlctoPT//TBweXMdAQX74mR2/Ag== X-Google-Smtp-Source: ACHHUZ6j2Wx/bmGatgv5g40tYCQi5kcOnm7ubOUL7LxfbNw7VmZs/d2Gr6CkFLQdEGqNzLLsniw5dA== X-Received: by 2002:a17:902:bd95:b0:1a6:e564:6044 with SMTP id q21-20020a170902bd9500b001a6e5646044mr2648658pls.7.1683195319137; Thu, 04 May 2023 03:15:19 -0700 (PDT) Received: from localhost ([162.210.129.5]) by smtp.gmail.com with ESMTPSA id g13-20020a170902868d00b001a221d14179sm23074502plo.302.2023.05.04.03.15.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 03:15:18 -0700 (PDT) From: Basil Contovounesios To: bug-gnu-emacs@gnu.org Subject: 29.0.90; Regression installing/activating packages without autoloads X-Debbugs-Cc: Philip Kaludercic Date: Thu, 04 May 2023 12:15:15 +0200 Message-ID: <87ild8tnbg.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=contovob@tcd.ie; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This change: Prevent generating empty autoload files dd21003878d 2023-04-30 18:42:58 +0200 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=dd21003878d seems to have reintroduced the following issue: https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html First start Emacs 29 (or 30) with a clean slate: $ cd "$(mktemp --directory)" $ export HOME="${PWD}" XDG_CONFIG_HOME="${PWD}/.config" $ emacs Then try to install the sicp package (which lacks autoloads) from MELPA: 0. C-x b RET 1. (setq package-archives '(("melpa" . "https://melpa.org/packages/"))) C-x C-e 2. M-x package-install RET sicp RET 3. C-h e 4. C-M-S-v Observe that *Messages* contains the line: Error loading autoloads: (file-missing Cannot open load file No such file or directory /tmp/tmp.5GvMpPatMo/.emacs.d/elpa/sicp-20200512.1137/sicp-autoloads) 5. M-x toggle-debug-on-error RET 6. M-x package-quickstart-refresh RET This fails with: Debugger entered--Lisp error: (wrong-type-argument stringp nil) insert-file-contents(nil) package-quickstart-refresh() funcall-interactively(package-quickstart-refresh) call-interactively(package-quickstart-refresh record nil) command-execute(package-quickstart-refresh record) execute-extended-command(nil "package-quickstart-refresh" "package-quick") funcall-interactively(execute-extended-command nil "package-quickstart-refresh" "package-quick") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) The file-missing error also appears on subsequent Emacs startup. Thanks, -- Basil In GNU Emacs 29.0.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-05-04 built on blc Repository revision: dd21003878dadba1e0420269e63e10685d4670a9 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.2 LTS Configured using: 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/bic/.local --with-program-suffix=-29 --with-file-notification=yes --with-x --with-x-toolkit=lucid' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug help-fns cl-print debug backtrace help-mode find-func compile comint ansi-osc ansi-color ring info loaddefs-gen lisp-mnt radix-tree tar-mode arc-mode archive-mode cus-edit pp cus-start cus-load icons wid-edit mm-archive message sendmail yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils gnutls network-stream url-cache url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny epg rfc6068 epg-config finder-inf package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 282927 159473) (symbols 48 16620 1) (strings 32 98218 50117) (string-bytes 1 2278870) (vectors 16 25526) (vector-slots 8 346646 26540) (floats 8 46 357) (intervals 56 468 3) (buffers 984 15)) From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 11:15:39 2023 Received: (at 63260) by debbugs.gnu.org; 4 May 2023 15:15:39 +0000 Received: from localhost ([127.0.0.1]:51769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puagF-0004Rr-8r for submit@debbugs.gnu.org; Thu, 04 May 2023 11:15:39 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:53332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puagE-0004R6-04 for 63260@debbugs.gnu.org; Thu, 04 May 2023 11:15:38 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f19a7f9424so6597415e9.2 for <63260@debbugs.gnu.org>; Thu, 04 May 2023 08:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683213332; x=1685805332; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4iawT47iVBXEZlo5QORmbk22inkR/AFIXpuayUsVjdQ=; b=LhtJ/bswBpNRcEFbFpSGQnQyU5Mt/cpTFvcczS/qL6WuE1343RV1WZI9yNoQSTtSMI UyGVCETsAaKfxdxpc8fB3g3+RTkh27rKmifNJAM9Z1atNgXyoEby9uErKYk79mjRkSUB UXxMVN5bL6/GaqpK/j0Cq1kZNu01jPJ1GuAyRCCHU0wrhTgYFjdKOZUC7GrvBdlqydi3 9w3DcyhwOZM6e6UXvzpJ5NaHn0TJ/hMiv3oytNkN8SdoXOvYnM+tmhjg2g+7+uEUHy5H biKibN0DTHOnl6hOO2Ni5w22AGVWY0tl6RB7zDSciibkg3oZ5610tSXbY4FlnFAppVfn u04Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683213332; x=1685805332; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4iawT47iVBXEZlo5QORmbk22inkR/AFIXpuayUsVjdQ=; b=h9cYEXV7sk3WY0F6CoNSjPD6piUZ0NkpPHqUeN5YX2vx/Y2wBSvJ2z2oX5NtzzsUIh GN0XI5XkPbiTWeVKtUq1RkbbS+sMN6LtVrvWyemo3+fqt0FWy7yXxIbng3WnIRUflJSJ EX7Vv7DVhxpYild4+42LnH6hEIPKxK+/FzO8ms/OvKjW6BS429PgCm4a1lQ8V5YFbj99 t/h2+MHlwym0B8cCa/c1qZTGmEDLiX3qQ34cIc4nfPv1tHJ/TY9kDZlu+Jk/NU04j5bY gkyjR3Ujf3xkijsoRgMnyJWn9S2A3BeCKyxYqFlWEnJx4iY4wb9AKSdmSmfNkXzIi8wl FfWA== X-Gm-Message-State: AC+VfDy+qecG3Fz4EpDxE1VR+9v6hy6N8VX48rIcMAhMK/ep2l6tthDv +nuJV6spkNa36vnAIvm7Kp4= X-Google-Smtp-Source: ACHHUZ4dq7X3UxjsiISv0Q+Sa6teYbhSBdBlG9hGSu/brMA5IxdmFT3Z3fDzhj/oO68i+rYtBHthxA== X-Received: by 2002:a7b:cd85:0:b0:3f1:6fb3:ffcc with SMTP id y5-20020a7bcd85000000b003f16fb3ffccmr8601wmj.22.1683213331609; Thu, 04 May 2023 08:15:31 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id u20-20020a05600c211400b003f183127434sm5184170wml.30.2023.05.04.08.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 08:15:31 -0700 (PDT) From: Robert Pluim To: 63260@debbugs.gnu.org Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <87ild8tnbg.fsf@tcd.ie> (Basil Contovounesios via's message of "Thu, 04 May 2023 12:15:15 +0200") References: <87ild8tnbg.fsf@tcd.ie> Date: Thu, 04 May 2023 17:15:30 +0200 Message-ID: <87ttwsnn59.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: Basil Contovounesios , Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 04 May 2023 12:15:15 +0200, Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: Bug> This change: Basil> Prevent generating empty autoload files Basil> dd21003878d 2023-04-30 18:42:58 +0200 Basil> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=dd21003878d Basil> seems to have reintroduced the following issue: Basil> https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html Basil> First start Emacs 29 (or 30) with a clean slate: Basil> $ cd "$(mktemp --directory)" Basil> $ export HOME="${PWD}" XDG_CONFIG_HOME="${PWD}/.config" Basil> $ emacs Basil> Then try to install the sicp package (which lacks autoloads) from MELPA: Basil> 0. C-x b RET Basil> 1. (setq package-archives '(("melpa" . "https://melpa.org/packages/"))) Basil> C-x C-e Basil> 2. M-x package-install RET sicp RET Basil> 3. C-h e Basil> 4. C-M-S-v Only when `package-quickstart' is non-nil, right? How about this: diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 0919ce34448..42d47ed259c 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4498,7 +4498,8 @@ package-quickstart-refresh (pfile (prin1-to-string file))) (insert "(let ((load-true-file-name " pfile ")\ \(load-file-name " pfile "))\n") - (insert-file-contents file) + (when file + (insert-file-contents file)) ;; Fixup the special #$ reader form and throw away comments. (while (re-search-forward "#\\$\\|^;\\(.*\n\\)" nil 'move) (unless (ppss-string-terminator (save-match-data (syntax-ppss))) Robert -- From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 12:29:05 2023 Received: (at 63260) by debbugs.gnu.org; 4 May 2023 16:29:05 +0000 Received: from localhost ([127.0.0.1]:51932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pubpI-0000yM-LK for submit@debbugs.gnu.org; Thu, 04 May 2023 12:29:05 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:49313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pubpF-0000xi-K9 for 63260@debbugs.gnu.org; Thu, 04 May 2023 12:29:02 -0400 Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1ab05018381so6108075ad.2 for <63260@debbugs.gnu.org>; Thu, 04 May 2023 09:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683217735; x=1685809735; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ByT1v349SgCMbgHik0jgGfDpSJO4/jDaZJHxUpjdIio=; b=FpB/cFhLy4ksQ4Zm5AK6KW247waCC/ncfjK6y2C9Ozcwvt2RwDoLWeZTx9M31sE6l8 1DuyBvNVraeO4cZus7w1wb4P9UlJ25Cil40fAQFTtQvmCRL7IjwEsojgS1sHpYIsLB50 IkA0OMAhyGZvhAj+cEqGHZZJ/QCNdLiJ4yKlf3OkdTRsmhUOuyhfh+x/Z9ak/X4JwHpW WW2ZOqzumZft9J/Y/W9UDl52wlLLNSvO/kxFbgKg5Pv8f507YaPBiFNl0FD4a7q0GylO sdBWnsk79b9jtG6ELT1oEMI6MucExXy7HFCvn38s8sXH2Wtkt0+H88J2wUygsRHMyf// VzCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683217735; x=1685809735; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ByT1v349SgCMbgHik0jgGfDpSJO4/jDaZJHxUpjdIio=; b=GrgnbD/A4szyH/cp5vYcJhFHGN4CLzoqKJ9MnLjj1T9ZX+5MnqnpE2Yd8g4zaclI0o liCDK07/jK+LDi/4WvAUpcO6wP9uB2t9C8oqNamqEHkk7zChR91CUG4CsJhCf9znTCkN EAf/HMBSujhDEe1araWfdUxh+6LzTzb06FE6hr7GCrN2pNOv8S41hegGZG7jvXZvw+n/ MEanZD82FJzraKLwCdc5fGu5uTd3114t4GGjFSC3gV3EbAqLkjDx7RSIlmh3IsOkMglJ LfdXmmF8t0kahvDZbL5o/uv20EOzpxA9q+RLzeUYtdwV7zerF1McQFyTBGA8EFKIkzu7 m09w== X-Gm-Message-State: AC+VfDymqDQjNAnQcjJ3p6QNjUM2/RakV3+SR3NHqDdRGDpiCF32lxrf EGiEiOaDHkPS0CzwZWaR9aYCZw== X-Google-Smtp-Source: ACHHUZ7qxQ2vcFXn7xn5m+zsbQEn3SFcK9EEMhSbLAhWmHt1gXu26fY9p4QDibcH3sq+PHS0b3VAWA== X-Received: by 2002:a17:902:b10e:b0:1a0:6690:d3d1 with SMTP id q14-20020a170902b10e00b001a06690d3d1mr4065168plr.6.1683217735393; Thu, 04 May 2023 09:28:55 -0700 (PDT) Received: from localhost (20014C4E1E52280005DF6EAF1CEC5CC5.dsl.pool.telekom.hu. [2001:4c4e:1e52:2800:5df:6eaf:1cec:5cc5]) by smtp.gmail.com with ESMTPSA id b11-20020a170902d50b00b001a67a2dae7fsm15314192plg.266.2023.05.04.09.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 09:28:54 -0700 (PDT) From: Basil Contovounesios To: Robert Pluim Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <87ttwsnn59.fsf@gmail.com> (Robert Pluim's message of "Thu, 04 May 2023 17:15:30 +0200") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> Date: Thu, 04 May 2023 18:28:47 +0200 Message-ID: <87zg6kysao.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim [2023-05-04 17:15 +0200] wrote: >>>>>> On Thu, 04 May 2023 12:15:15 +0200, Basil Contovounesios via "Bug re= ports for GNU Emacs, the Swiss army knife of text editors" said: > > Bug> This change: > > Basil> Prevent generating empty autoload files > Basil> dd21003878d 2023-04-30 18:42:58 +0200 > Basil> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Ddd2100387= 8d > > Basil> seems to have reintroduced the following issue: > > Basil> https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html > > Basil> First start Emacs 29 (or 30) with a clean slate: > > Basil> $ cd "$(mktemp --directory)" > Basil> $ export HOME=3D"${PWD}" XDG_CONFIG_HOME=3D"${PWD}/.config" > Basil> $ emacs > > Basil> Then try to install the sicp package (which lacks autoloads) f= rom MELPA: > > Basil> 0. C-x b RET > Basil> 1. (setq package-archives '(("melpa" . "https://melpa.org/pack= ages/"))) > Basil> C-x C-e > Basil> 2. M-x package-install RET sicp RET > Basil> 3. C-h e > Basil> 4. C-M-S-v > > Only when `package-quickstart' is non-nil, right? No, this is in an empty user-emacs-directory, i.e. with the default package-quickstart =3D nil. Besides, package-quickstart does not come into play during package-install AFAICT. > How about this: > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..42d47ed259c 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4498,7 +4498,8 @@ package-quickstart-refresh > (pfile (prin1-to-string file))) > (insert "(let ((load-true-file-name " pfile ")\ > \(load-file-name " pfile "))\n") > - (insert-file-contents file) > + (when file > + (insert-file-contents file)) This does not address the file-missing error during package activation, but it allows a subsequent package-quickstart-refresh to complete (albeit with a warning in a *Compile-Log*): Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart.el at Thu May 4 18:24:07 2023 Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/=E2=80=99 package-quickstart.el:4:2: Warning: Empty let body due to the following generated contents of package-quickstart-file: (let ((load-true-file-name nil)(load-file-name nil)) ) Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 02:37:04 2023 Received: (at 63260) by debbugs.gnu.org; 5 May 2023 06:37:04 +0000 Received: from localhost ([127.0.0.1]:52988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pup3v-00082w-NS for submit@debbugs.gnu.org; Fri, 05 May 2023 02:37:04 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:60580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pup3q-00082D-TR for 63260@debbugs.gnu.org; Fri, 05 May 2023 02:37:01 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f4000ec6ecso13901135e9.0 for <63260@debbugs.gnu.org>; Thu, 04 May 2023 23:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683268613; x=1685860613; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=muMVkuDjUJnbCXQ5xzbwGDFZqnkk6JiTlkjExwWCLMw=; b=AxkcA66k9SOlYjRJ84HV9yuPMfuL6WICmh3Wr18jE6F+8H2NoSC61oUSnPVELv6lbM pNhMqXuetbxPbpC8EZ6P3DoVWyb8c2MOEsJNFoq7Hn7J1HayVfxk1VSopMuuvU6HLRUg 53I73iBw/TEsJSJ+eA2nz8DhyDyB5VcLCa9Xn/4/JhiDq7awuK4tZQcmutIH3Y8Bep0r 5pzU7VHmaaZn/IZiQja28yHaAcPp4q6H/oIrvpf3On0ZZmY7FDkIJxTjWWtQnr30N+Ab 94c0+S6GtOIP2GOmrl5nDBmAtlEO+RzGWJmrpmtyCcQTrMYLDrmOqyBfDXD4ingV/5Ru 7Wog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683268613; x=1685860613; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=muMVkuDjUJnbCXQ5xzbwGDFZqnkk6JiTlkjExwWCLMw=; b=QoQb2DcltwQbZZaA7yOg6XTj5v5+m+JHgKtN9GvM4v4bGeSzYMwHiuTOeIHAnYX0ow L8VUzwaxRAHJ2/erBhxpIl/XdDtWEynQO07ZY9366YELt7xCCWvhiMmQ/2GCWsFvDm4f k6iX6izbgTM0H0IVQ6sQHU0URUsjSU7qv9GeAp7FirUn8CQFY3dii0L/nYvvTjWUbD3Z qY/ju8gvD/ecZpill5SHABBriOy44m+sNJRNCajzM9ZsYtKYMHg2AcXSpR8aTDfc3dTV iFM+9bDZVY4MsNpeXzRfjd90J8XyTSKKUJntTIhJUpPAlqyY9z6G+jaZzA3nBBHV+T6a 3twQ== X-Gm-Message-State: AC+VfDwK9PEsdzTlFJyc30ruPL86z18OQ0RfLGQt7/DgppG+O7Pev9ER AyaQi8W3+p0m2wLx2H0D7qs= X-Google-Smtp-Source: ACHHUZ6fAI/Yu3QvoTa3Ne8VU53uhtcGvJKVgbG/j/75XzKyQI/uLdNUZYp60YXWMXO1b5HLt0Y3Kw== X-Received: by 2002:a5d:4a86:0:b0:306:2aea:3dff with SMTP id o6-20020a5d4a86000000b003062aea3dffmr626231wrq.31.1683268612804; Thu, 04 May 2023 23:36:52 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id s7-20020a1cf207000000b003e91b9a92c9sm6996773wmc.24.2023.05.04.23.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 23:36:52 -0700 (PDT) From: Robert Pluim To: Basil Contovounesios Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <87zg6kysao.fsf@tcd.ie> (Basil Contovounesios's message of "Thu, 04 May 2023 18:28:47 +0200") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> Date: Fri, 05 May 2023 08:36:51 +0200 Message-ID: <87lei3nv24.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios said: Basil> Robert Pluim [2023-05-04 17:15 +0200] wrote: >>>>>>> On Thu, 04 May 2023 12:15:15 +0200, Basil Contovounesios via "B= ug reports for GNU Emacs, the Swiss army knife of text editors" said: >>=20 Bug> This change: >>=20 Basil> Prevent generating empty autoload files Basil> dd21003878d 2023-04-30 18:42:58 +0200 Basil> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Ddd21003878d >>=20 Basil> seems to have reintroduced the following issue: >>=20 Basil> https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html >>=20 Basil> First start Emacs 29 (or 30) with a clean slate: >>=20 Basil> $ cd "$(mktemp --directory)" Basil> $ export HOME=3D"${PWD}" XDG_CONFIG_HOME=3D"${PWD}/.config" Basil> $ emacs >>=20 Basil> Then try to install the sicp package (which lacks autoloads) fro= m MELPA: >>=20 Basil> 0. C-x b RET Basil> 1. (setq package-archives '(("melpa" . "https://melpa.org/packag= es/"))) Basil> C-x C-e Basil> 2. M-x package-install RET sicp RET Basil> 3. C-h e Basil> 4. C-M-S-v >>=20 >> Only when `package-quickstart' is non-nil, right? Basil> No, this is in an empty user-emacs-directory, i.e. with the defa= ult Basil> package-quickstart =3D nil. Besides, package-quickstart does no= t come Basil> into play during package-install AFAICT. Right. My testing was faulty Basil> This does not address the file-missing error during package acti= vation, Basil> but it allows a subsequent package-quickstart-refresh to complete Basil> (albeit with a warning in a *Compile-Log*): The file-missing error is expected, no? That=CA=BCs why the autoloads loading is wrapped in `with-demoted-errors'. Although if the message bothers you, I guess we could check `file-exists-p' for it. Basil> Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart= .el Basil> at Thu May 4 18:24:07 2023 Basil> Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/=E2= =80=99 Basil> package-quickstart.el:4:2: Warning: Empty let body Basil> due to the following generated contents of package-quickstart-fi= le: Basil> (let ((load-true-file-name nil)(load-file-name nil)) Basil> ) I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the morning :-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 0919ce34448..4b488281b78 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4491,11 +4491,11 @@ package-quickstart-refresh (insert ";;; Quickstart file to activate all packages at startup -*= - lexical-binding:t -*-\n") (insert ";; =C2=A1=C2=A1 This file is autogenerated by `package-quic= kstart-refresh', DO NOT EDIT !!\n\n") (dolist (pkg package--quickstart-pkgs) - (let* ((file - ;; Prefer uncompiled files (and don't accept .so files). - (let ((load-suffixes '(".el" ".elc"))) - (locate-library (package--autoloads-file-name pkg)))) - (pfile (prin1-to-string file))) + (when-let* ((file + ;; Prefer uncompiled files (and don't accept .so file= s). + (let ((load-suffixes '(".el" ".elc"))) + (locate-library (package--autoloads-file-name pkg))= )) + (pfile (prin1-to-string file))) (insert "(let ((load-true-file-name " pfile ")\ \(load-file-name " pfile "))\n") (insert-file-contents file) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 07:00:49 2023 Received: (at control) by debbugs.gnu.org; 5 May 2023 11:00:49 +0000 Received: from localhost ([127.0.0.1]:53243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putBB-0002Dr-1T for submit@debbugs.gnu.org; Fri, 05 May 2023 07:00:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putB9-0002DW-4p; Fri, 05 May 2023 07:00:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1putB3-0006Vy-Mo; Fri, 05 May 2023 07:00:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N5gqUUmCGZI0vqTwbwDtHFlfV+N40rgKZkklk/ZbIRg=; b=jZHgADvOTN7f 7meeEzuC2X0axRg6Pc9vanuIU2zhONBlRKhWj/vSknJUbbGxjRpCVYqqxuhbzvfvr4PpVw/aFad3O R0ebYnMrN6dogwUllTvrexSS27GVRZXDyMu45u0HHEM/yRpbSSFCB1mqWjFq0rGJYwDUSpqVHvYAd 2ukFWS2cmeq+rsQy+lkfofJsVjX4a3rziuClEEvSudIVSwgmZAP+IUT3dxXmVVKjBhQy8SQLry1pO IMTYAhND1AZph4ef7gaJDmGZL+HXkwRO673xYrJR6+ghLRww4qEXQvJhJ8YrLBMWqopTUPNwL3XKe borUocyZm+6JSD2j5yXaCg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1putB2-00063E-Pv; Fri, 05 May 2023 07:00:41 -0400 Date: Fri, 05 May 2023 14:01:34 +0300 Message-Id: <83o7mzhwj5.fsf@gnu.org> From: Eli Zaretskii To: Jimmy Wong In-Reply-To: (message from Jimmy Wong on Fri, 5 May 2023 11:52:14 +0100) Subject: Re: bug#63298: 29.0.90; Commit dd21003 broke package activation References: <83r0rvhx1u.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 63298@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 63298 63260 thanks > Date: Fri, 5 May 2023 11:52:14 +0100 > From: Jimmy Wong > Cc: 63298@debbugs.gnu.org > > The backtraces are different, so the sites of failures are different, but the cause appears to be the > same. Thanks, I merged them. From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 05:00:25 2023 Received: (at 63260) by debbugs.gnu.org; 6 May 2023 09:00:25 +0000 Received: from localhost ([127.0.0.1]:59401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvDmD-0006em-7a for submit@debbugs.gnu.org; Sat, 06 May 2023 05:00:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvDmA-0006eV-BG for 63260@debbugs.gnu.org; Sat, 06 May 2023 05:00:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvDm4-0008RG-8Q; Sat, 06 May 2023 05:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oLtQT9S7V7eUm6Mq0BLSqUUJpvvXogj+nHqoswGyb1E=; b=TeMaUHSY5l/SLEG+05yN 7oq9FuA5bV8FWIIRpN1B6Iikko/LmupRPpH69KqOWPg0IgaqymmoWNjRbz/y1BZzYvX9c/UoRV72P XJIbHmetTprUkJROywCheweE2paQTjsaItNASibiGfszCtHTAVpEYuBzisVvyhIgq/eHKPVwXRx4r iXbp2FNgkLTinSe66V4MYYkO1U/OKL26yhrgod7d/ZPW5ZGlw+Srcc3QZpZsjpr+3oqpcV2s6p7ku 4fvIQicdWuG3js+NsOYa0wQgBQlhfMIbwB3jESkD34B2aVf30kx+BbQtBck4/X8nVkC5TwLOh+Kuo rimFR3qcXMCBeg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvDm0-0001dT-Bi; Sat, 06 May 2023 05:00:16 -0400 Date: Sat, 06 May 2023 12:01:07 +0300 Message-Id: <83bkixhm0c.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87lei3nv24.fsf@gmail.com> (message from Robert Pluim on Fri, 05 May 2023 08:36:51 +0200) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 63260@debbugs.gnu.org, Philip Kaludercic > From: Robert Pluim > Date: Fri, 05 May 2023 08:36:51 +0200 > > >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios said: > > Basil> This does not address the file-missing error during package activation, > Basil> but it allows a subsequent package-quickstart-refresh to complete > Basil> (albeit with a warning in a *Compile-Log*): > > The file-missing error is expected, no? Thatʼs why the autoloads > loading is wrapped in `with-demoted-errors'. Although if the message bothers > you, I guess we could check `file-exists-p' for it. > > Basil> Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart.el > Basil> at Thu May 4 18:24:07 2023 > Basil> Entering directory ‘/tmp/tmp.6cdF8paE0K/.emacs.d/’ > Basil> package-quickstart.el:4:2: Warning: Empty let body > > Basil> due to the following generated contents of package-quickstart-file: > > Basil> (let ((load-true-file-name nil)(load-file-name nil)) > Basil> ) > > Iʼd claim ENOCOFFEE for the last patch, but it was not the morning :-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..4b488281b78 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4491,11 +4491,11 @@ package-quickstart-refresh > (insert ";;; Quickstart file to activate all packages at startup -*- lexical-binding:t -*-\n") > (insert ";; ¡¡ This file is autogenerated by `package-quickstart-refresh', DO NOT EDIT !!\n\n") > (dolist (pkg package--quickstart-pkgs) > - (let* ((file > - ;; Prefer uncompiled files (and don't accept .so files). > - (let ((load-suffixes '(".el" ".elc"))) > - (locate-library (package--autoloads-file-name pkg)))) > - (pfile (prin1-to-string file))) > + (when-let* ((file > + ;; Prefer uncompiled files (and don't accept .so files). > + (let ((load-suffixes '(".el" ".elc"))) > + (locate-library (package--autoloads-file-name pkg)))) > + (pfile (prin1-to-string file))) > (insert "(let ((load-true-file-name " pfile ")\ > \(load-file-name " pfile "))\n") > (insert-file-contents file) > Philip, Basil: is the above okay with you? I'd like this issue resolved before making the next pretest of Emacs 29.1. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 08:52:00 2023 Received: (at 63260) by debbugs.gnu.org; 6 May 2023 12:52:00 +0000 Received: from localhost ([127.0.0.1]:59637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHOJ-0007Lb-RQ for submit@debbugs.gnu.org; Sat, 06 May 2023 08:52:00 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]:60885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHOG-0007LJ-8r for 63260@debbugs.gnu.org; Sat, 06 May 2023 08:51:59 -0400 Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ac785015d7so31464201fa.1 for <63260@debbugs.gnu.org>; Sat, 06 May 2023 05:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683377510; x=1685969510; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bt+ICshN55yov9ZgkQpwS2HFV0/4OBEy3mf1zZHu7zU=; b=FBsRmMZIV8IxfelnHMfsVnNpx2O9p/Cme8honKTxEtQ1RIjwxgj+Gq5O13Fl+LQlyC B7D+PxxTpqbQ/0Ss8Kq/RX6qtgyWs43POHdrugtbKBr7HPj1T8TYhD92S2kJIhcEaQYK yOCUDPVMwCSNseW+YwDVY3CRCDeefOUw0jYODgmRHzI7W5DKSD+Tnc7XUyvL8LMuTadp 7wjSvI09z6msdYjaf0nYAUPe9rJZ23/6bDAuZoGipoMHm1g593ddVHmNs0uR5axzhFi7 Mi511Iq0JkaUBHfm4C/hniC5VLR7tiijnS2P8OSlBVXjlcKCoCtxcIl01TH0BYL5CbkC 3BKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683377510; x=1685969510; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bt+ICshN55yov9ZgkQpwS2HFV0/4OBEy3mf1zZHu7zU=; b=LAIMo+/WXF/TcfD75S2HvgmvGwV817gTtrm//aFU5XrNtgOYQ3ur0upZCdiHJyFb/Z EoQP5gJoK+o8DHDsZjtDGtKggEsGXhZWrzlIVRaTZABv8k9cQFoZWKfb+z8W8pmsb4+e FkvZGalnVs0pZM59OMYEYiBP8JPHnAdh/5WR5boQDY1des+hizb2z80DuhjD6gu32sB8 GNy90HPL58dBwAXKim5WWNQxsaDNRmhQDAk01PSq8DeaVwGmsWiIAHsEoxPhUDngqw3F 9uHjMp8F01+ZGc7hmDSAY6iNq9N4/B2elaJiUrbHcZhsAmlwe8mw17ctIgmGHH36g2xW 0Kww== X-Gm-Message-State: AC+VfDx+LtFSNH7koH6BDMDdBEmiEXlf3S3FxxaprHPcxWuaNtZH/1xr 8dh6T74cg4VwjWjffbkS9wY/PVZZfU7vhtvPbcc= X-Google-Smtp-Source: ACHHUZ7Z6w1GLpO+ixZeoHCGfk6eAQnxH+iLnHtOUUo8TueulWjhGiaNhD++N1JknMEssqAITADzvyJqdNkHlR9Q3RI= X-Received: by 2002:a2e:6816:0:b0:2ac:7e64:ef8 with SMTP id c22-20020a2e6816000000b002ac7e640ef8mr1280414lja.16.1683377510012; Sat, 06 May 2023 05:51:50 -0700 (PDT) MIME-Version: 1.0 References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <83bkixhm0c.fsf@gnu.org> In-Reply-To: <83bkixhm0c.fsf@gnu.org> From: Robert Pluim Date: Sat, 6 May 2023 14:51:39 +0200 Message-ID: Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000081dd1a05fb05deef" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: "Basil L. Contovounesios" , 63260@debbugs.gnu.org, "Philip K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000081dd1a05fb05deef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Please push if it's ok with you, I'm afk until tomorrow Thanks Robert On Sat, May 6, 2023, 11:00 Eli Zaretskii wrote: > > Cc: 63260@debbugs.gnu.org, Philip Kaludercic > > From: Robert Pluim > > Date: Fri, 05 May 2023 08:36:51 +0200 > > > > >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios < > contovob@tcd.ie> said: > > > > Basil> This does not address the file-missing error during package > activation, > > Basil> but it allows a subsequent package-quickstart-refresh to > complete > > Basil> (albeit with a warning in a *Compile-Log*): > > > > The file-missing error is expected, no? That=CA=BCs why the autoloads > > loading is wrapped in `with-demoted-errors'. Although if the message > bothers > > you, I guess we could check `file-exists-p' for it. > > > > Basil> Compiling file > /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart.el > > Basil> at Thu May 4 18:24:07 2023 > > Basil> Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/= =E2=80=99 > > Basil> package-quickstart.el:4:2: Warning: Empty let body > > > > Basil> due to the following generated contents of > package-quickstart-file: > > > > Basil> (let ((load-true-file-name nil)(load-file-name nil)) > > Basil> ) > > > > I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the morning= :-) > > > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > > index 0919ce34448..4b488281b78 100644 > > --- a/lisp/emacs-lisp/package.el > > +++ b/lisp/emacs-lisp/package.el > > @@ -4491,11 +4491,11 @@ package-quickstart-refresh > > (insert ";;; Quickstart file to activate all packages at startup > -*- lexical-binding:t -*-\n") > > (insert ";; =C2=A1=C2=A1 This file is autogenerated by > `package-quickstart-refresh', DO NOT EDIT !!\n\n") > > (dolist (pkg package--quickstart-pkgs) > > - (let* ((file > > - ;; Prefer uncompiled files (and don't accept .so files= ). > > - (let ((load-suffixes '(".el" ".elc"))) > > - (locate-library (package--autoloads-file-name pkg)))= ) > > - (pfile (prin1-to-string file))) > > + (when-let* ((file > > + ;; Prefer uncompiled files (and don't accept .so > files). > > + (let ((load-suffixes '(".el" ".elc"))) > > + (locate-library (package--autoloads-file-name > pkg)))) > > + (pfile (prin1-to-string file))) > > (insert "(let ((load-true-file-name " pfile ")\ > > \(load-file-name " pfile "))\n") > > (insert-file-contents file) > > > > Philip, Basil: is the above okay with you? I'd like this issue > resolved before making the next pretest of Emacs 29.1. > > Thanks. > --00000000000081dd1a05fb05deef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please push if it's ok with you, I'm afk until to= morrow

Thanks

Robert

On Sat, May 6, 2023, 11:00 E= li Zaretskii <eliz@gnu.org> wrote= :
> Cc: 63260@debbugs.gnu.org= , Philip Kaludercic <philipk@posteo.net>
> From: Robert Pluim <rpluim@gmail.com>
> Date: Fri, 05 May 2023 08:36:51 +0200
>
> >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovo= unesios <contovob@tcd.ie> said:
>
>=C2=A0 =C2=A0 =C2=A0Basil> This does not address the file-missing er= ror during package activation,
>=C2=A0 =C2=A0 =C2=A0Basil> but it allows a subsequent package-quicks= tart-refresh to complete
>=C2=A0 =C2=A0 =C2=A0Basil> (albeit with a warning in a *Compile-Log*= ):
>
> The file-missing error is expected, no? That=CA=BCs why the autoloads<= br> > loading is wrapped in `with-demoted-errors'. Although if the messa= ge bothers
> you, I guess we could check `file-exists-p' for it.
>
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0Compiling file /tmp/tmp.6cdF8= paE0K/.emacs.d/package-quickstart.el
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 at Thu May=C2=A0 4 18:24:07 2023
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0Entering directory =E2=80=98/= tmp/tmp.6cdF8paE0K/.emacs.d/=E2=80=99
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0package-quickstart.el:4:2: Wa= rning: Empty let body
>
>=C2=A0 =C2=A0 =C2=A0Basil> due to the following generated contents o= f package-quickstart-file:
>
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0(let ((load-true-file-name ni= l)(load-file-name nil))
>=C2=A0 =C2=A0 =C2=A0Basil>=C2=A0 =C2=A0)
>
> I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the mornin= g :-)
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..4b488281b78 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -4491,11 +4491,11 @@ package-quickstart-refresh
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert ";;; Quickstart file to activa= te all packages at startup=C2=A0 -*- lexical-binding:t -*-\n")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert ";; =C2=A1=C2=A1 This file is = autogenerated by `package-quickstart-refresh', DO NOT EDIT !!\n\n"= )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (dolist (pkg package--quickstart-pkgs)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let* ((file
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Prefer unc= ompiled files (and don't accept .so files).
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((load-s= uffixes '(".el" ".elc")))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (locat= e-library (package--autoloads-file-name pkg))))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(pfile (prin1-= to-string file)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (when-let* ((file
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0;; Prefer uncompiled files (and don't accept .so files).
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(let ((load-suffixes '(".el" ".elc")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(locate-library (package--autoloads-file-name pkg))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (pfile (prin1-to-string file)))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert "(let ((load-tru= e-file-name " pfile ")\
>=C2=A0 \(load-file-name " pfile "))\n")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (insert-file-contents file) >

Philip, Basil: is the above okay with you?=C2=A0 I'd like this issue resolved before making the next pretest of Emacs 29.1.

Thanks.
--00000000000081dd1a05fb05deef-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 09:10:35 2023 Received: (at 63260) by debbugs.gnu.org; 6 May 2023 13:10:35 +0000 Received: from localhost ([127.0.0.1]:59677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHgJ-0007vG-5R for submit@debbugs.gnu.org; Sat, 06 May 2023 09:10:35 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:51475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHgG-0007uy-Ag for 63260@debbugs.gnu.org; Sat, 06 May 2023 09:10:33 -0400 Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-50bceaf07b8so5386534a12.3 for <63260@debbugs.gnu.org>; Sat, 06 May 2023 06:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683378626; x=1685970626; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HT7/HVug8iAu4pXW8FQD85wHI2TDHDk5NCuYA8/CK7c=; b=UMltlKepGG9OSNRkzQVEts3ivIqSf+T/ECNkydZZdRanRXOEHYjJ4H9JHG9A0VDyag Ok5O1koiCHfmcGzYaaSz71tFWcSOfbGB7QSswVXmn6iY+c6KVx+ZA7lVL76XAMLob0Ze yXedi2b3xpESJLrFPnUrAB/Cf3rpMBuzPT4ZrNtRC5dvW4U2h7+yh8Yl1Uy2h2gNGjhT nJNYm1Op3M+jzCaW3FT/LB338pN9JWFtBPJneqBouglHFuKrHAMtl9Xx2cFnDlDDvXZB DOgyPLrP8sgci851Ayx435ZNVRIvVSyViVV8Nj93Rx4x/hcJnFkCDTe0FY9/8tpWnIEj UFYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683378626; x=1685970626; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HT7/HVug8iAu4pXW8FQD85wHI2TDHDk5NCuYA8/CK7c=; b=Pcf00JJBHRuzOcNNJkN5Ixx9FHgFXveWN57T40qPz75J06hcSL/XmS49OxgUCBppGC mjUojMNS9hD908y3ExZO3q1SDtvfyPtDFWweq2/bJau1tH/jGbiwDFqn/820ESd+/qTD tC8w1r5HcZUrjTR6lqNLqkJ7JrRA8OVdclYd0qsmLaDj+22SjbR7nHfyNNo+/uEiTfo3 rEaJJUvZ5Qb5Bf/q4iIOGeGXeXcSgbQp34bQCTXta/rjc7g9NY7qXA/Mp7WmySrhItcl I0yWw+xzSjCdsC2beGK2/EVQPaK13oNXxDQ1OthpvOwuIqpFcK7UHr8WyQvPasRPoLQj lfnA== X-Gm-Message-State: AC+VfDye3Mlo/cbZA2ZwoWP5Q+LLqTgPOACDYnVFTLip1aeVl4K2RHmC 0uSZhAdSe+tlUbAhYtvsGzU3DA== X-Google-Smtp-Source: ACHHUZ7q7rWACOF8L3wufHiae5dMb9+VyOmLTFdCy1VeUnQVEaaGcZFAsCNSH45jSDMm0tG1hYt32A== X-Received: by 2002:a50:eb48:0:b0:50b:c479:fed7 with SMTP id z8-20020a50eb48000000b0050bc479fed7mr3834525edp.21.1683378626467; Sat, 06 May 2023 06:10:26 -0700 (PDT) Received: from localhost ([146.70.196.229]) by smtp.gmail.com with ESMTPSA id a25-20020aa7d919000000b0050bc9ffed66sm4002196edr.53.2023.05.06.06.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 06:10:25 -0700 (PDT) From: Basil Contovounesios To: Robert Pluim Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <87lei3nv24.fsf@gmail.com> (Robert Pluim's message of "Fri, 05 May 2023 08:36:51 +0200") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> Date: Sat, 06 May 2023 15:10:23 +0200 Message-ID: <87a5yhtxkw.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim [2023-05-05 08:36 +0200] wrote: >>>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios said: > > Basil> This does not address the file-missing error during package ac= tivation, > Basil> but it allows a subsequent package-quickstart-refresh to compl= ete > Basil> (albeit with a warning in a *Compile-Log*): > > The file-missing error is expected, no? That=CA=BCs why the autoloads > loading is wrapped in `with-demoted-errors'. Although if the message both= ers > you, I guess we could check `file-exists-p' for it. I think it's problematic to emit even a demoted error for supported circumstances, such as a 'library' package that defines no autoload cookies. Besides, shouldn't the autoloads file be generated unconditionally? https://lists.gnu.org/r/emacs-devel/2022-06/msg00570.html While the error logged to *Messages* is relatively silent, its subequent repetition on Emacs startup is not: $ emacs-29 Error loading autoloads: (file-missing Cannot open load file No such file or directory /tmp/tmp.QQvQfBZ384/.emacs.d/elpa/sicp-20200512.1137/sicp-autoloads) This does not seem like TRT to me. > Basil> Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quicksta= rt.el > Basil> at Thu May 4 18:24:07 2023 > Basil> Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/=E2= =80=99 > Basil> package-quickstart.el:4:2: Warning: Empty let body > > Basil> due to the following generated contents of package-quickstart-= file: > > Basil> (let ((load-true-file-name nil)(load-file-name nil)) > Basil> ) > > I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the morning := -) If only POSIX made it clear to expect ENOCOFFEE when it's least expected ;). > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..4b488281b78 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4491,11 +4491,11 @@ package-quickstart-refresh > (insert ";;; Quickstart file to activate all packages at startup = -*- lexical-binding:t -*-\n") > (insert ";; =C2=A1=C2=A1 This file is autogenerated by `package-qu= ickstart-refresh', DO NOT EDIT !!\n\n") > (dolist (pkg package--quickstart-pkgs) > - (let* ((file > - ;; Prefer uncompiled files (and don't accept .so files). > - (let ((load-suffixes '(".el" ".elc"))) > - (locate-library (package--autoloads-file-name pkg)))) > - (pfile (prin1-to-string file))) > + (when-let* ((file > + ;; Prefer uncompiled files (and don't accept .so fi= les). > + (let ((load-suffixes '(".el" ".elc"))) > + (locate-library (package--autoloads-file-name pkg= )))) > + (pfile (prin1-to-string file))) > (insert "(let ((load-true-file-name " pfile ")\ > \(load-file-name " pfile "))\n") > (insert-file-contents file) This indeed avoids the problem in package-quickstart, thanks. The issue with the missing autoload file during package installation/activation remains, however. Sorry for not being more helpful, but I'm travelling until next week. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 09:12:48 2023 Received: (at 63260) by debbugs.gnu.org; 6 May 2023 13:12:48 +0000 Received: from localhost ([127.0.0.1]:59683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHiR-0007yp-Om for submit@debbugs.gnu.org; Sat, 06 May 2023 09:12:48 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:61784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHiJ-0007yW-4W for 63260@debbugs.gnu.org; Sat, 06 May 2023 09:12:46 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-50c8d87c775so2722812a12.3 for <63260@debbugs.gnu.org>; Sat, 06 May 2023 06:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683378753; x=1685970753; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LVzLqt8aZRMs0xN5m62trIF/7G5zoCoh380b3mkCi6M=; b=aSQuZZW5fGCYEBJC9ZYni+UDSxbEKmRsfDuepxDxQQJSDbEquLfJnIZEWa5dz9B4nk eHq7Go3exNk0DGRwh0uM1DPNoPFp+Lv378XgGDvXextlNUoTNxc+e9ftfhS+Bh4UTkwn gd6H3zLtQz8LmEolQ7DAIQn1wGMgsh3av+dXU+pLV7LaYUdEYwpPUDhyWx+A819qSixy D1qXFC1+BCakqJDKEYT3bfyYmMUxmHvtnbWfUjcGeFnQNCIq672mSaERgp0lpge+aB+n NY1UyOhlcTxuUyn0LNFnxwHJcU99G0Rb9nE9jGfmX9touFVcq2l18fsCj7kdqe0mIaWf sOzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683378753; x=1685970753; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LVzLqt8aZRMs0xN5m62trIF/7G5zoCoh380b3mkCi6M=; b=Mw/blNkiPmQhiu/CY8WUitt8zJTFem7/ms+nZ1qJuw71z/aa7g3qaZ2wq/r84pWxEL j2PTk/yNgyyGa1AnBalSAYDdz0Ffy37oTBLeAiwIf5Tlb5cFGpc7P8YJRUBEzNLoBM8z FTM/ThZnFjOv4wn7S+OhEcZDTT8whRDs8s40MxsgUZ83hbaDNtFb5HCKtmLhn7HpxSK4 x6svhqEZn0TsmBjQg2cZQudGUMnmcHWt5j3e/PjzJBpADH5bDUrw9B7WNFAazpwOdzPO ZO1dKH8/Wr85+pmvD3wVvPjpigkzbGctbl8SzkjUOknQZ+lwVXSsg9IZLbu/NRnYgXUs JSrQ== X-Gm-Message-State: AC+VfDz/KNhftRbxT2F225nUoWNXgYBsAuIm0VEtvEd6g0DRP42A3X3K j/thVwsdNjZVprAHXWper4pUuTkucYFCHOt22C8vFkVzyAk= X-Google-Smtp-Source: ACHHUZ7ZTZ8S0R7u/kLaVIWEx2IO7VLqpjgmTf/PStOSDh6buLVxd7xOrt7qNnKnIfFdVwp5ZhK33A== X-Received: by 2002:aa7:dbd4:0:b0:501:cf67:97f3 with SMTP id v20-20020aa7dbd4000000b00501cf6797f3mr3865391edt.25.1683378753510; Sat, 06 May 2023 06:12:33 -0700 (PDT) Received: from localhost ([146.70.196.229]) by smtp.gmail.com with ESMTPSA id w17-20020aa7dcd1000000b004ad601533a3sm4000502edu.55.2023.05.06.06.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 06:12:33 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83bkixhm0c.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 05:00:17 -0400") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <83bkixhm0c.fsf@gnu.org> Date: Sat, 06 May 2023 15:12:31 +0200 Message-ID: <87wn1lsiww.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, Robert Pluim , philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2023-05-06 05:00 -0400] wrote: >> Cc: 63260@debbugs.gnu.org, Philip Kaludercic >> From: Robert Pluim >> Date: Fri, 05 May 2023 08:36:51 +0200 >>=20 >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index 0919ce34448..4b488281b78 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -4491,11 +4491,11 @@ package-quickstart-refresh >> (insert ";;; Quickstart file to activate all packages at startup = -*- lexical-binding:t -*-\n") >> (insert ";; =C2=A1=C2=A1 This file is autogenerated by `package-q= uickstart-refresh', DO NOT EDIT !!\n\n") >> (dolist (pkg package--quickstart-pkgs) >> - (let* ((file >> - ;; Prefer uncompiled files (and don't accept .so files). >> - (let ((load-suffixes '(".el" ".elc"))) >> - (locate-library (package--autoloads-file-name pkg)))) >> - (pfile (prin1-to-string file))) >> + (when-let* ((file >> + ;; Prefer uncompiled files (and don't accept .so f= iles). >> + (let ((load-suffixes '(".el" ".elc"))) >> + (locate-library (package--autoloads-file-name pk= g)))) >> + (pfile (prin1-to-string file))) >> (insert "(let ((load-true-file-name " pfile ")\ >> \(load-file-name " pfile "))\n") >> (insert-file-contents file) > > Philip, Basil: is the above okay with you? I'd like this issue > resolved before making the next pretest of Emacs 29.1. As I said in my other message, AFAICT this fixes a symptom specific to package-quickstart of the more general autoload file problem reintroduced by dd21003878d. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 09:22:59 2023 Received: (at 63260) by debbugs.gnu.org; 6 May 2023 13:22:59 +0000 Received: from localhost ([127.0.0.1]:59692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHsJ-0008FO-83 for submit@debbugs.gnu.org; Sat, 06 May 2023 09:22:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHsG-0008FB-Uc for 63260@debbugs.gnu.org; Sat, 06 May 2023 09:22:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHsA-00058m-Ps; Sat, 06 May 2023 09:22:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VnJfdsUzVmybaHk7lo0OshYtV9TGweTpdSDPNugKhEQ=; b=Mo5FsNOMGy9572TIZJiy pb+DjVZqia09xeQoN5BumaD++OH84eio8HXiAQEwEN62ViKjRHURKQVTBDguQQLGwtmIwdqasZWGh Y/aPflvxqU57pYgiyTKbm1WIUjxH5fW2vmmZ8DleceTXiGa7ni06KhMFlkgksjKpIbWMWzhmgoNTG 6t/W/foiaT3dQRa6NTzKcPhaaUEByoH0ucEui9ep4gn/JRFzHhfMYygkdn+GQJkwareyxeEiC6rmA YPhBuRYdNiWTL56n8KTTcq7+MBgBkVC4NjKHenrg+K7blIE+N7NyQvWBVXbYCKgGP5XqTpsPn8fIV +3ZM3U0LVlgLUQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHsA-0007zV-4l; Sat, 06 May 2023 09:22:50 -0400 Date: Sat, 06 May 2023 16:23:43 +0300 Message-Id: <83sfc9fva8.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios In-Reply-To: <87a5yhtxkw.fsf@tcd.ie> (bug-gnu-emacs@gnu.org) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 63260@debbugs.gnu.org, Philip Kaludercic > Date: Sat, 06 May 2023 15:10:23 +0200 > From: Basil Contovounesios via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Robert Pluim [2023-05-05 08:36 +0200] wrote: > > > The file-missing error is expected, no? Thatʼs why the autoloads > > loading is wrapped in `with-demoted-errors'. Although if the message bothers > > you, I guess we could check `file-exists-p' for it. > > I think it's problematic to emit even a demoted error for supported > circumstances, such as a 'library' package that defines no autoload > cookies. > > Besides, shouldn't the autoloads file be generated unconditionally? > https://lists.gnu.org/r/emacs-devel/2022-06/msg00570.html > > While the error logged to *Messages* is relatively silent, its subequent > repetition on Emacs startup is not: > > $ emacs-29 > Error loading autoloads: (file-missing Cannot open load file > No such file or directory > /tmp/tmp.QQvQfBZ384/.emacs.d/elpa/sicp-20200512.1137/sicp-autoloads) > > This does not seem like TRT to me. What happened in Emacs 28 in the same situation? From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 09:28:08 2023 Received: (at 63260) by debbugs.gnu.org; 6 May 2023 13:28:08 +0000 Received: from localhost ([127.0.0.1]:59717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHxI-0008O8-0G for submit@debbugs.gnu.org; Sat, 06 May 2023 09:28:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHxF-0008Nl-6g for 63260@debbugs.gnu.org; Sat, 06 May 2023 09:28:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHx9-0006J8-Na; Sat, 06 May 2023 09:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JTgj39iCqe2X9rvMvht8TttOidwf1Fit14TOCoKkU8w=; b=RLE/GsYaht6M kjnsISj5MKOgq6Dlt8EvXKGYJ5hyxa9FCrqvNCTOpj6+QZteFhpqT4cn79iTZaJ8ryqySeKE+tTK6 bQQS2KiHpyTINK7Lv/zBF933UXfxF8rE/bsD/YBRJWRO/BdvZAu4C8Yly9Azj1vkhg/TyyBl8pEjM 5C91jKmRHO/0fy8+MTTTymqO3kS++3JGBaJLJbP44PWhsmikOXArmu45MO5l9iMskI1ge9TmF1b3b lVMaiDvh22pOnHfETtV+yy2qhOAF8/syGMfGsRVQMbeZHVKGGJJwr/0ObgUj5h/v2kqSmMSr+YIPK b+dk2pR2oGDUySZ7yEMtLw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHx6-0002wm-0d; Sat, 06 May 2023 09:27:59 -0400 Date: Sat, 06 May 2023 16:28:51 +0300 Message-Id: <83pm7dfv1o.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios In-Reply-To: <87wn1lsiww.fsf@tcd.ie> (message from Basil Contovounesios on Sat, 06 May 2023 15:12:31 +0200) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <83bkixhm0c.fsf@gnu.org> <87wn1lsiww.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Basil Contovounesios > Cc: Robert Pluim , 63260@debbugs.gnu.org, > philipk@posteo.net > Date: Sat, 06 May 2023 15:12:31 +0200 > > > Philip, Basil: is the above okay with you? I'd like this issue > > resolved before making the next pretest of Emacs 29.1. > > As I said in my other message, AFAICT this fixes a symptom specific to > package-quickstart of the more general autoload file problem > reintroduced by dd21003878d. I'm trying to find a solution that is less drastic than reverting commit dd21003878d. Please help me. From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 05:46:41 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 09:46:41 +0000 Received: from localhost ([127.0.0.1]:36506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvayW-0004pA-TI for submit@debbugs.gnu.org; Sun, 07 May 2023 05:46:41 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:62748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvayU-0004ou-DA for 63260@debbugs.gnu.org; Sun, 07 May 2023 05:46:39 -0400 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3f315735514so139663825e9.1 for <63260@debbugs.gnu.org>; Sun, 07 May 2023 02:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683452793; x=1686044793; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GTv6xspsiFr6kwjIZ+NEWFySM+bWCk+EteFOMsTzwgs=; b=eREorz4QYyiiUp45mnNDIDPFki/iLFXXW7CCS9FXcayTNEZdcL2XXFxOd0qzmkFmC0 MSx8KNWqYQ58Q4z89jGI3tihl2IUxFA9CFQ+dBd7p8ynUCXqXdRdExRPnhlGnWXSe/dI y5i1xy1m0H4CadiTdxJY0cRQMqf4A+XFLszbsKlDTFHbtHCb9CvcTp+QTUxa/4/psJ+j gCJv1TSNJ/4H9+NlZfija5NQJhZwgzmCoiTrxojhHFzVwvraq/j/zjOLfBPL7t3+t5vO 9I6QBAA7We7pRo76YxM64hC1npK9a5ItThlv2j8Cm/+hdCtXkZNE6Zb/6DvwRCBzERa7 7mDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683452793; x=1686044793; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GTv6xspsiFr6kwjIZ+NEWFySM+bWCk+EteFOMsTzwgs=; b=h59fk4sBEt5PEaOkLt2wMRi8xoXWC1MSr7LIsSCV/PQrA5sGnMaQP/4zmLt1SEi9Nx AWH/Nm0zxTdKPuM0+nxXm16g6rBDlQVc7wb+yy0xT6fRgdUYX9D8mIuN3Lak2OTaMxy9 frFLpny6Hz4EBRdMd2erfLjLugidU4ZK43sYRdFt7SjJ8cD7X1jhunDhg/6SCFpnBZyJ CrLGZZYkuM2DYglX8MZY8MzaNhjLD2FWk1J8rh7ELsk7VUx8pwFzIcpWZysGxbeFdllC IWq/3gpPdkNrFSOIpy9chpYPdp/6PB7ZyA2iWwvcxEWfln9J+r8+g03c878KCd0SrwEH NSUA== X-Gm-Message-State: AC+VfDxk1UMjk38cN1YljaXdOTE7WG8nQpZr1FAcPTH1g8ZATjJlHN3q LJ2hAocOfHDwxw4OPvqetZ283A== X-Google-Smtp-Source: ACHHUZ74z9Pm7qjcXmJo2sc98ZxHkdYMdVgPyVOrmVSw5gV3wrPNQ9fpzIBIa5jtfCxH2dMu9Sy7fA== X-Received: by 2002:a05:600c:c1a:b0:3f1:7619:f0f6 with SMTP id fm26-20020a05600c0c1a00b003f17619f0f6mr5375758wmb.9.1683452792682; Sun, 07 May 2023 02:46:32 -0700 (PDT) Received: from localhost ([64.43.50.196]) by smtp.gmail.com with ESMTPSA id y6-20020a1c4b06000000b003f17131952fsm13175008wma.29.2023.05.07.02.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 02:46:30 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83sfc9fva8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 16:23:43 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> Date: Sun, 07 May 2023 11:46:29 +0200 Message-ID: <87mt2go4ne.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii [2023-05-06 16:23 +0300] wrote: >> Cc: 63260@debbugs.gnu.org, Philip Kaludercic >> Date: Sat, 06 May 2023 15:10:23 +0200 >> From: Basil Contovounesios via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Robert Pluim [2023-05-05 08:36 +0200] wrote: >>=20 >> > The file-missing error is expected, no? That=CA=BCs why the autoloads >> > loading is wrapped in `with-demoted-errors'. Although if the message b= others >> > you, I guess we could check `file-exists-p' for it. >>=20 >> I think it's problematic to emit even a demoted error for supported >> circumstances, such as a 'library' package that defines no autoload >> cookies. >>=20 >> Besides, shouldn't the autoloads file be generated unconditionally? >> https://lists.gnu.org/r/emacs-devel/2022-06/msg00570.html >>=20 >> While the error logged to *Messages* is relatively silent, its subequent >> repetition on Emacs startup is not: >>=20 >> $ emacs-29 >> Error loading autoloads: (file-missing Cannot open load file >> No such file or directory >> /tmp/tmp.QQvQfBZ384/.emacs.d/elpa/sicp-20200512.1137/sicp-autoloads) >>=20 >> This does not seem like TRT to me. > > What happened in Emacs 28 in the same situation? Emacs 28.2 installs and activates the sicp package without complaints, and generates the following -autoloads.el file, as expected: --=-=-= Content-Type: application/emacs-lisp; charset=utf-8 Content-Disposition: inline; filename=sicp-autoloads.el Content-Transfer-Encoding: quoted-printable ;;; sicp-autoloads.el --- automatically extracted autoloads -*- lexical-bi= nding: t -*- ;; ;;; Code: (add-to-list 'load-path (directory-file-name (or (file-name-directory #$) (car load-path)))) ;; Local Variables: ;; version-control: never ;; no-byte-compile: t ;; no-update-autoloads: t ;; coding: utf-8 ;; End: ;;; sicp-autoloads.el ends here --=-=-= Content-Type: text/plain The current emacs-29 generates no such autoloads file, because the sicp package defines no autoloads. But in general the -autoloads.el file is nevertheless needed, at least for its load-path logic. Contrast this with a package that defines even a single autoload cookie, such as the bluetooth package on GNU ELPA. In this case emacs-29 does TRT: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline; filename=bluetooth-autoloads.el Content-Transfer-Encoding: quoted-printable ;;; bluetooth-autoloads.el --- automatically extracted autoloads (do not ed= it) -*- lexical-binding: t -*- ;; Generated by the `loaddefs-generate' function. ;; This file is part of GNU Emacs. ;;; Code: (add-to-list 'load-path (or (and load-file-name (file-name-directory load-f= ile-name)) (car load-path))) ;;; Generated autoloads from bluetooth.el (autoload 'bluetooth-list-devices "bluetooth" "\ Display a list of Bluetooth devices. This function starts Bluetooth mode which offers an interface offering device management functions, e.g. pairing, connecting, scanning the bus, displaying device info etc." t) (register-definition-prefixes "bluetooth" '("bluetooth-")) ;;; End of scraped data (provide 'bluetooth-autoloads) ;; Local Variables: ;; version-control: never ;; no-byte-compile: t ;; no-update-autoloads: t ;; no-native-compile: t ;; coding: utf-8-emacs-unix ;; End: ;;; bluetooth-autoloads.el ends here --=-=-= Content-Type: text/plain -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 06:50:03 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 10:50:03 +0000 Received: from localhost ([127.0.0.1]:36554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvbxq-0006jn-NK for submit@debbugs.gnu.org; Sun, 07 May 2023 06:50:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvbxm-0006jD-VR for 63260@debbugs.gnu.org; Sun, 07 May 2023 06:50:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvbxf-00027x-M1; Sun, 07 May 2023 06:49:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jdx5/7OAdOd4HMpCGe7E1c9etLUCPcMogcGPAtqU44Q=; b=fnL3QmPDSO5n oA9CmlHYg4B8s0KIIgEWuNBHZFVYM1gPJfqPLp5t5LxmEtm5BJfsz8rYxTXNJcL5FAmhClFdpMzZS mV+1xsQ2ztEaNK3ZPEpOecvb1pJ0er/BPyswkWR1187Pcrwe4Jm8HuiYa8JaMDDWvEkczIBA1K9D3 2DgFAnGLPf1lVSDcYQOhFimVZ7DRHubmi1KwwNp/WX8sk+oQ2/1FbHrnPcfotvVcq2kpeaJmoS774 TJpeaMmLwcL+40gE6cJWfg/p5UdEDWvEn4PIgYZPCG/Q9nTeENHFCLqxzZ8IaicVZPxPASxr4aILP BEOc7yZtgDd6CE3vgS+O3A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvbxf-0007eW-5z; Sun, 07 May 2023 06:49:51 -0400 Date: Sun, 07 May 2023 13:50:49 +0300 Message-Id: <83pm7ce7p2.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios , philipk@posteo.net In-Reply-To: <87mt2go4ne.fsf@tcd.ie> (message from Basil Contovounesios on Sun, 07 May 2023 11:46:29 +0200) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Basil Contovounesios > Cc: 63260@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net > Date: Sun, 07 May 2023 11:46:29 +0200 > > >> While the error logged to *Messages* is relatively silent, its subequent > >> repetition on Emacs startup is not: > >> > >> $ emacs-29 > >> Error loading autoloads: (file-missing Cannot open load file > >> No such file or directory > >> /tmp/tmp.QQvQfBZ384/.emacs.d/elpa/sicp-20200512.1137/sicp-autoloads) > >> > >> This does not seem like TRT to me. > > > > What happened in Emacs 28 in the same situation? > > Emacs 28.2 installs and activates the sicp package without complaints, > and generates the following -autoloads.el file, as expected: > > > The current emacs-29 generates no such autoloads file, because the sicp > package defines no autoloads. But in general the -autoloads.el file is > nevertheless needed, at least for its load-path logic. AFAIU, in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62734 I asked Philip what would happen in this case, and he replied that the changes he proposed did TRT in that case? So what is different here? Philip? From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 06:59:44 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 10:59:44 +0000 Received: from localhost ([127.0.0.1]:36581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvc7D-0006yu-Qx for submit@debbugs.gnu.org; Sun, 07 May 2023 06:59:44 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:60729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvc7A-0006yg-Hz for 63260@debbugs.gnu.org; Sun, 07 May 2023 06:59:42 -0400 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-306281edf15so3284378f8f.1 for <63260@debbugs.gnu.org>; Sun, 07 May 2023 03:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683457174; x=1686049174; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BeWxyiQQqUh32TdA1fG/AnZbokWohGZwFeBjOHhejgg=; b=LLq4yACYJJ3o3XslaLxz0WdT/1tW3puwzM/kIWWDJQ+MM8flkgGqpax7rAwRGlu765 /E0Hxj8OYUfEAsGPUCyWCQkAD0UmdY7j8E/ky4bZMzvxoLoJUfXxvqsBSuZMpjcQ7oYd 2aTv4zmXu/a5PNZKgDEpCPArD5INhmbNejkKlzp7pxGQVpbgAcnfaLWAhndkHjqz8qEg cvMkZbMCDQ7R4/nHi1lUbnoBIrA/G3i3I1828K4NGQ/UjX9T88A0BefNGQaoxA9C5xUw u15fFgWzGIx6wKGEoEM7qCvE6c6rQJlNK8/frcA5ao7yZQ0ArSL2uPF3779hQgVLZCQs 04Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683457174; x=1686049174; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BeWxyiQQqUh32TdA1fG/AnZbokWohGZwFeBjOHhejgg=; b=hA8LfnXu/2VawOx57IP19j6+YUEJlWM6x/598KIyC60qzryIe2ArlZmSk+O+F8VkxT 5nuMjEonZBxG/++04+iuCUhCK21vvyj/JgEKcOdKJqAdT2VZ+pfhM9ZwDJ0mGV7EmZgy lYcKAuWTKLYAp/QRMw6aCGE0sBztWHPAQxrBMu9vbkqxSd2fh3vyRfn6KTHqCCQmgbri pveR+2P7XUKVOsc7+fP0E+7uCNxJg2hWcDUw6ZDGf+uv7ILRjtxAyMI635ocpPYnBUsU sFatWJn+NvvhGWYoEs4TaGtzgNWhbuLbGLjI8cRAvb0fnxqs2lXuqvwyMR+23eWrGSax SABg== X-Gm-Message-State: AC+VfDxnJZ/6sCoa4NfC8qWaC/ZMdvXhs5hI3q3Hgd5DwVTpZAlx3qXk gLb73xKLxpbniAJ1i1pLEN7p7A== X-Google-Smtp-Source: ACHHUZ6UXqwgO1J0TuzokpPFlr71qwChX6PtTzjefuhQQlU4QSfYoWFbSzn8iRXdODgPyKWHa+gDlQ== X-Received: by 2002:a5d:51c4:0:b0:306:4031:63c5 with SMTP id n4-20020a5d51c4000000b00306403163c5mr4897913wrv.51.1683457174579; Sun, 07 May 2023 03:59:34 -0700 (PDT) Received: from localhost ([89.19.67.63]) by smtp.gmail.com with ESMTPSA id i1-20020a5d55c1000000b003062b2c5255sm7923060wrw.40.2023.05.07.03.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 03:59:34 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83pm7dfv1o.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 09:28:00 -0400") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <83bkixhm0c.fsf@gnu.org> <87wn1lsiww.fsf@tcd.ie> <83pm7dfv1o.fsf@gnu.org> Date: Sun, 07 May 2023 12:59:32 +0200 Message-ID: <87ild4h0ff.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2023-05-06 09:28 -0400] wrote: >> From: Basil Contovounesios >> Cc: Robert Pluim , 63260@debbugs.gnu.org, >> philipk@posteo.net >> Date: Sat, 06 May 2023 15:12:31 +0200 >> >> > Philip, Basil: is the above okay with you? I'd like this issue >> > resolved before making the next pretest of Emacs 29.1. >> >> As I said in my other message, AFAICT this fixes a symptom specific to >> package-quickstart of the more general autoload file problem >> reintroduced by dd21003878d. > > I'm trying to find a solution that is less drastic than reverting > commit dd21003878d. Please help me. I would like to, but I'm unfamiliar with loaddefs-gen and what Philip's change was addressing. I'll need some time to understand and test what's going on. Unfortunately I'm only very sporadically at a keyboard until at least tomorrow evening. Hopefully Philip or Robert can beat me to it, otherwise I hope to have a look in the coming days. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 08:40:00 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 12:40:00 +0000 Received: from localhost ([127.0.0.1]:36639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvdgG-0003dZ-GE for submit@debbugs.gnu.org; Sun, 07 May 2023 08:40:00 -0400 Received: from mout01.posteo.de ([185.67.36.65]:36423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvdgB-0003dE-CG for 63260@debbugs.gnu.org; Sun, 07 May 2023 08:39:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CF29D240135 for <63260@debbugs.gnu.org>; Sun, 7 May 2023 14:39:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683463189; bh=2msOTrJNiYOgIw+cNU/g1ZRtmukhbvSqSc6QIgs0A2k=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=eOYwZNevlWti1+zvLZiuXqMJNjAr3IdGIVnyBW5sRFfda7/N6MySw74nWirJVlZGS c5bkDOCy+E8A6ODo4aMbyB4sOCi3RukuPyUQ/bVVRudnD7ZvEFOxl1OOFCrFvgyJnx 4h1+KA/jOIrgxbMpJTK6eBIyXC02UuSsgHyQBzGUVR/o1QF3BZkMPwCZDLCorYaek6 ftAmXoRRYAiawR5DxbWZrNiDA51iZPRBwaUJ0pxz0569xEPgx21XwdYpkwyMjCMLle scztKCsE5thlrDcH4n+XXm5hjT0zWtoMqoZIiQuh5TT7dPZXHWcr2e+PUJxcvOv+5R sLgvuQ01oq5+g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDkX51TKgz6tvs; Sun, 7 May 2023 14:39:49 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83pm7ce7p2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 May 2023 13:50:49 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 07 May 2023 12:39:48 +0000 Message-ID: <87y1m0co2z.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: Basil Contovounesios , 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Basil Contovounesios >> Cc: 63260@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net >> Date: Sun, 07 May 2023 11:46:29 +0200 >> >> >> While the error logged to *Messages* is relatively silent, its subequent >> >> repetition on Emacs startup is not: >> >> >> >> $ emacs-29 >> >> Error loading autoloads: (file-missing Cannot open load file >> >> No such file or directory >> >> /tmp/tmp.QQvQfBZ384/.emacs.d/elpa/sicp-20200512.1137/sicp-autoloads) >> >> >> >> This does not seem like TRT to me. >> > >> > What happened in Emacs 28 in the same situation? >> >> Emacs 28.2 installs and activates the sicp package without complaints, >> and generates the following -autoloads.el file, as expected: >> >> >> The current emacs-29 generates no such autoloads file, because the sicp >> package defines no autoloads. But in general the -autoloads.el file is >> nevertheless needed, at least for its load-path logic. > > AFAIU, in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62734 I asked > Philip what would happen in this case, and he replied that the changes > he proposed did TRT in that case? So what is different here? Philip? No, that appears to have been my mistake. The issue is that `loaddefs-generate' generates the autoload file while looping over all definitions to autoload, but if there are no files, Basil is right that nothing happens. This is fine in general, but `loaddefs-generate' has the extra task of modifying load-path (which has been the root of the issue in bug#62734). Perhaps it is best to revert the commit, and come up with a alternative solution. I have an idea, but I'll have to test it again before I forget something like this. -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 08:53:40 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 12:53:40 +0000 Received: from localhost ([127.0.0.1]:36656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvdtT-00047H-JQ for submit@debbugs.gnu.org; Sun, 07 May 2023 08:53:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvdtR-000471-W9 for 63260@debbugs.gnu.org; Sun, 07 May 2023 08:53:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvdtL-0000u5-TU; Sun, 07 May 2023 08:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N2RupsrZR2cU01le7aUH/HkPGyAQ5BzrQDONaB09QXk=; b=Pb3uO8OzjPZO QYi9runmH1+P6yIifsYQULLmRF2/Wz9FKBn4KxG5cF4pdZoxcNbhVyHpk4sYAPAEdQS6TkxbULX8R TQGlbYSCmfnbZiUM0znwQCmk7UOoWTQEMCEULtkYK0qcl3RieNIbAb3sVALsxhX47NEFSpQuwt2OF HGXhoBq4hierPlVs1Yf8BwMBmk+YOVKOrqTG/sQNHzP37C8fjVABMcy0Tn5fp8u8Vh28vC3Qrcgo2 rusEsinECEn/7yOm4ASZ2Ppo+TuIqGlLkhPTVVRkT8WKJ5C55rxj28NS6kactPoNTWhHy1XtSsHbE OQ00Hrapb9R7PmPJKLAKFA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvdtL-0006l2-9S; Sun, 07 May 2023 08:53:31 -0400 Date: Sun, 07 May 2023 15:54:28 +0300 Message-Id: <83fs88e1yz.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87y1m0co2z.fsf@posteo.net> (message from Philip Kaludercic on Sun, 07 May 2023 12:39:48 +0000) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: Basil Contovounesios , 63260@debbugs.gnu.org, > rpluim@gmail.com > Date: Sun, 07 May 2023 12:39:48 +0000 > > Eli Zaretskii writes: > > > AFAIU, in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62734 I asked > > Philip what would happen in this case, and he replied that the changes > > he proposed did TRT in that case? So what is different here? Philip? > > No, that appears to have been my mistake. The issue is that > `loaddefs-generate' generates the autoload file while looping over all > definitions to autoload, but if there are no files, Basil is right that > nothing happens. This is fine in general, but `loaddefs-generate' has > the extra task of modifying load-path (which has been the root of the > issue in bug#62734). Perhaps it is best to revert the commit, and come > up with a alternative solution. I have an idea, but I'll have to test > it again before I forget something like this. If we revert that commit, we will bring back bug#62734, which to me sounds like a similarly serious, perhaps even more serious, issue, don't you agree? So I think maybe we need to amend that commit with something that takes care of the particular situation reported here. Specifically, it seems we need to detect the situation where a package has no autoloads at all, and then produce the minimal autoloads file that such packages expect. From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 09:13:03 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 13:13:03 +0000 Received: from localhost ([127.0.0.1]:36675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveCF-0004gK-4V for submit@debbugs.gnu.org; Sun, 07 May 2023 09:13:03 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveC6-0004ff-H3 for 63260@debbugs.gnu.org; Sun, 07 May 2023 09:13:02 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 526272401DF for <63260@debbugs.gnu.org>; Sun, 7 May 2023 15:12:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683465168; bh=4xnZfOtBS7kIG9VonHInSXTqWLZq3/jqkw9If1PuOPg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=OsxIo59Gj9wPF/ug1OkTD2TyeHRTTtJKOS26wig5Pbi7G7PkuntXORl+HS57U9NMK 0zc0lTsD3SLzJsjCSuD1D0fmo4zGYgXnfxzlCBP54F/4XIPbHW0ANqsVSJ+dfwMXpk pUz+VUKpJU2abk2IVrYyVExJmdvPb3u+1/h9JQlFPzUnjhYas9XMcq9FFDPgLg1xNN iF5aREP8gFCyfi5wYFziaQxlDK6lNTLe78pCx//O9QXskhdOURYfjw4JfikpDOFAn+ DsKOuOGdKWf7H0cIvVcb59NdGi7dD3ue13p+Jx603W/j8x409bqH3z5ysrdPwDRjJ3 1lh4iv1f7ERAQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDlG73xPpz6tmv; Sun, 7 May 2023 15:12:47 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83fs88e1yz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 May 2023 15:54:28 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 07 May 2023 13:12:47 +0000 Message-ID: <87jzxkcmk0.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Basil Contovounesios , 63260@debbugs.gnu.org, >> rpluim@gmail.com >> Date: Sun, 07 May 2023 12:39:48 +0000 >> >> Eli Zaretskii writes: >> >> > AFAIU, in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62734 I asked >> > Philip what would happen in this case, and he replied that the changes >> > he proposed did TRT in that case? So what is different here? Philip? >> >> No, that appears to have been my mistake. The issue is that >> `loaddefs-generate' generates the autoload file while looping over all >> definitions to autoload, but if there are no files, Basil is right that >> nothing happens. This is fine in general, but `loaddefs-generate' has >> the extra task of modifying load-path (which has been the root of the >> issue in bug#62734). Perhaps it is best to revert the commit, and come >> up with a alternative solution. I have an idea, but I'll have to test >> it again before I forget something like this. > > If we revert that commit, we will bring back bug#62734, which to me > sounds like a similarly serious, perhaps even more serious, issue, > don't you agree? My idea was that we could revert the commit, and then install a smaller change, basically just replacing the condition (and (not defs) extra-data) with (not defs) but thinking about it for a bit, I noticed that you are right that this would just re-introduce the same issue. > So I think maybe we need to amend that commit with > something that takes care of the particular situation reported here. > Specifically, it seems we need to detect the situation where a package > has no autoloads at all, and then produce the minimal autoloads file > that such packages expect. One hack might just be to check if `loaddefs-generate' has generated anything at all or not, and if that is not the case to do so manually in package.el. The reason this doesn't seem nice, is that we'd have to make the fact that `loaddefs-generate' does not generate a OUTPUT-FILE if there is no file with autoloads explicit, and finding a justification for that is difficult. Alternatively, this could be done inside of `loaddefs-generate'? Something like --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el index 2a46fb7a022..c23f21553d5 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -656,7 +656,17 @@ loaddefs-generate (write-region (point-min) (point-max) loaddefs-file nil 'silent) (byte-compile-info (file-relative-name loaddefs-file (car (ensure-list dir))) - t "GEN"))))))) + t "GEN"))))) + + ;; HACK: If no file with autoloads were found, but EXTRA-DATA was + ;; passed, we still want to generate a file. + (unless (and extra-data (file-exists-p output-file)) + (with-temp-buffer + (insert (loaddefs-generate--rubric output-file nil t)) + (search-backward "\f") + (insert extra-data) + (ensure-empty-lines 1) + (write-region (point-min) (point-max) output-file nil 'silent))))) (defun loaddefs-generate--print-form (def) "Print DEF in a format that makes sense for version control." --=-=-= Content-Type: text/plain -- Philip Kaludercic --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 09:20:12 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 13:20:12 +0000 Received: from localhost ([127.0.0.1]:36690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveJ9-0004t8-VE for submit@debbugs.gnu.org; Sun, 07 May 2023 09:20:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveJ8-0004sv-GI for 63260@debbugs.gnu.org; Sun, 07 May 2023 09:20:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveJ2-0007Nu-5q; Sun, 07 May 2023 09:20:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ro9OI2IswZsobd3jUCVyIxrYyhMyynlapECuUIPgrFU=; b=sItPDreBpQSP h02GbxVUaUEKWS+NzuxEe16/EwpzxGKrFbSzaqAfbrEu0Lfpj/pJsxpbv0BLE6LAUz9SHKUv3oK2N URLGF9LTb4Ry4bPb4Xl7+6JkIgT/wPK31Sg4bS5oD63A/IKwqn/hm+E6tfs9XSbpukvHNVkkOEaiS C1daetr38zwty/TEWTyVJS+k8dlQYeqxIFDXGHyfnwLKwdGX3Nf7h6Aje6PcniqhiIkfbJsQ0WJTy JYVx+9jHDQBUC471ht5erQ76BQ0nEzNSOflVl0oCdCTRWZJ+4n4g5zlxMjZaInbY92nGfThH/tKf6 HMHXQ+BcAMnmlIfTi5pOow==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveJ0-0006Kg-Vk; Sun, 07 May 2023 09:20:03 -0400 Date: Sun, 07 May 2023 16:21:01 +0300 Message-Id: <83cz3ce0qq.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87jzxkcmk0.fsf@posteo.net> (message from Philip Kaludercic on Sun, 07 May 2023 13:12:47 +0000) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com > Date: Sun, 07 May 2023 13:12:47 +0000 > > One hack might just be to check if `loaddefs-generate' has generated > anything at all or not, and if that is not the case to do so manually in > package.el. The reason this doesn't seem nice, is that we'd have to > make the fact that `loaddefs-generate' does not generate a OUTPUT-FILE > if there is no file with autoloads explicit, and finding a justification > for that is difficult. Alternatively, this could be done inside of > `loaddefs-generate'? Something like Assuming it solves the issue and doesn't break anything, the latter sounds good to me, better than the alternatives. > + ;; HACK: If no file with autoloads were found, but EXTRA-DATA was > + ;; passed, we still want to generate a file. The comment says "EXTRA-DATA was passed", but this added snipped will also run if EXTRA-DATA was NOT passed, but the OUTPUT-FILE doesn't exist, right? And I would explain in the comment the real-life situations where this is needed, and why, rather than just explaining in English what the code does. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 15:37:40 2023 Received: (at 63260) by debbugs.gnu.org; 7 May 2023 19:37:40 +0000 Received: from localhost ([127.0.0.1]:38555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvkCR-0001fl-JY for submit@debbugs.gnu.org; Sun, 07 May 2023 15:37:40 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvkCM-0001fT-22 for 63260@debbugs.gnu.org; Sun, 07 May 2023 15:37:37 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EA995240170 for <63260@debbugs.gnu.org>; Sun, 7 May 2023 21:37:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683488248; bh=aSEdL0YBFtnSVs/9fr7gwjwlb/7yZqXw7gT+565nTJo=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=SHc4FcbFR4PsgrJqSIjT2kkRNEgJdCISW/hPWKzuYvYgevHpFlENOumLX43fzQDMG U5IXDa633JQzTpknzXXFgPBiNjCm4VfSp7r/mSuxjJwGszO5pSlRNSAAd9F/2RKexG tAVFL7QrYscIfrZJmh99/hgM6qN3n1PXwt7uorECmnNL5vtKgVptpg9gxGK27ch+rV gi/wcuvpKbD/UGKUKHOW6/dmCjZKFQ17NnQV4y55pk2WWmF+xvtN0WxodUyvN6v094 HXvU7DBQIx8cHZ9lNRKSH319fyu0iEf3pXaoSHAD2/rm2OfOijBUJ+aF1TUfTOkHe1 JCdm5nQ0H7ehw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDvnz38s7z9rxM; Sun, 7 May 2023 21:37:27 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83cz3ce0qq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 May 2023 16:21:01 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 07 May 2023 19:37:26 +0000 Message-ID: <87jzxkgcg9.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com >> Date: Sun, 07 May 2023 13:12:47 +0000 >> >> One hack might just be to check if `loaddefs-generate' has generated >> anything at all or not, and if that is not the case to do so manually in >> package.el. The reason this doesn't seem nice, is that we'd have to >> make the fact that `loaddefs-generate' does not generate a OUTPUT-FILE >> if there is no file with autoloads explicit, and finding a justification >> for that is difficult. Alternatively, this could be done inside of >> `loaddefs-generate'? Something like > > Assuming it solves the issue and doesn't break anything, the latter > sounds good to me, better than the alternatives. > >> + ;; HACK: If no file with autoloads were found, but EXTRA-DATA was >> + ;; passed, we still want to generate a file. > > The comment says "EXTRA-DATA was passed", but this added snipped will > also run if EXTRA-DATA was NOT passed, but the OUTPUT-FILE doesn't > exist, right? Right, the code was not tested as I was in a hurry. I've changed it to ;; HACK: If no file with autoloads were found, but EXTRA-DATA was ;; passed, we still want to generate a file. (when (and extra-data (not (file-exists-p output-file))) and this file is generated when installing the SICP package: --8<---------------cut here---------------start------------->8--- ;;; sicp-autoloads.el --- automatically extracted autoloads (do not edit) -*- lexical-binding: t -*- ;; Generated by the `loaddefs-generate' function. ;; This file is part of GNU Emacs. ;;; Code: (add-to-list 'load-path (or (and load-file-name (file-name-directory load-file-name)) (car load-path))) ;;; End of scraped data (provide 'sicp-autoloads) ;; Local Variables: ;; version-control: never ;; no-byte-compile: t ;; no-update-autoloads: t ;; no-native-compile: t ;; coding: utf-8-emacs-unix ;; End: ;;; sicp-autoloads.el ends here --8<---------------cut here---------------end--------------->8--- and this does not break anything when installing packages. > And I would explain in the comment the real-life situations where this > is needed, and why, rather than just explaining in English what the > code does. You are right. How does this patch look like: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Ensure-that-EXTRA-DATA-are-always-written-when-gener.patch >From 08c914abaa37bfb1f84ca7a357cc6e01ccfd254f Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 7 May 2023 21:37:01 +0200 Subject: [PATCH] Ensure that EXTRA-DATA are always written when generating autoloads * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate): Handle edge-case where no autoloads are found. (Bug#63260) --- lisp/emacs-lisp/loaddefs-gen.el | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el index 2a46fb7a022..5db9af21508 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -656,7 +656,20 @@ loaddefs-generate (write-region (point-min) (point-max) loaddefs-file nil 'silent) (byte-compile-info (file-relative-name loaddefs-file (car (ensure-list dir))) - t "GEN"))))))) + t "GEN"))))) + + ;; If processing files without any autoloads, the above loop will + ;; not generate any files. If the function was invoked with + ;; EXTRA-DATA, we want to ensure that even if no autoloads were + ;; found, that at least a file will have been generated containing + ;; the contents of EXTRA-DATA: + (when (and extra-data (not (file-exists-p output-file))) + (with-temp-buffer + (insert (loaddefs-generate--rubric output-file nil t)) + (search-backward "\f") + (insert extra-data) + (ensure-empty-lines 1) + (write-region (point-min) (point-max) output-file nil 'silent))))) (defun loaddefs-generate--print-form (def) "Print DEF in a format that makes sense for version control." -- 2.39.2 --=-=-= Content-Type: text/plain > Thanks. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 07:15:57 2023 Received: (at 63260) by debbugs.gnu.org; 8 May 2023 11:15:57 +0000 Received: from localhost ([127.0.0.1]:39435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvyqS-00070X-VC for submit@debbugs.gnu.org; Mon, 08 May 2023 07:15:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvyqQ-00070D-Mj for 63260@debbugs.gnu.org; Mon, 08 May 2023 07:15:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvyqK-00022z-TD; Mon, 08 May 2023 07:15:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=W+w/DtEjM++YMyu9bzp5kco7/fF4kj4j247fqs534dQ=; b=qs0rx2/y/jjZ R6nLX8DycdVBu6OhJzcgmCfJIE3EeI61PhnxpIBLmffFx/NCvQdnwPOTNGlcj1Si3xfeht9w4whlM RCAOBjEGx5t9JgILqTIdnAKabEP7pr1TeVzbCB62uL/y9/T0RrcOYKsxV3xMMU7snxX45rvYvycJa y7A6VCM85WjlqEJuA6/MUd7WZf1wmDluc/6C7wlFEo0F3vr6hOrVRDzJ46yqUac90sitdoG6NAlp4 c2C/AuV/mdN69yDLcy5WSBTsZQjs7Ogk/8Lojr2pBgOLysQXkP97JWbz7kBavEBeHTHYNKUgmCYW9 lkNjjrhehZukhb4L2KWraQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvyqK-0002TH-Cy; Mon, 08 May 2023 07:15:48 -0400 Date: Mon, 08 May 2023 14:16:49 +0300 Message-Id: <83v8h3cbtq.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87jzxkgcg9.fsf@posteo.net> (message from Philip Kaludercic on Sun, 07 May 2023 19:37:26 +0000) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com > Date: Sun, 07 May 2023 19:37:26 +0000 > > and this file is generated when installing the SICP package: > > --8<---------------cut here---------------start------------->8--- > ;;; sicp-autoloads.el --- automatically extracted autoloads (do not edit) -*- lexical-binding: t -*- > ;; Generated by the `loaddefs-generate' function. > > ;; This file is part of GNU Emacs. > > ;;; Code: > > (add-to-list 'load-path (or (and load-file-name (file-name-directory load-file-name)) (car load-path))) > > > ;;; End of scraped data > > (provide 'sicp-autoloads) > > ;; Local Variables: > ;; version-control: never > ;; no-byte-compile: t > ;; no-update-autoloads: t > ;; no-native-compile: t > ;; coding: utf-8-emacs-unix > ;; End: > > ;;; sicp-autoloads.el ends here > --8<---------------cut here---------------end--------------->8--- > > and this does not break anything when installing packages. > > > And I would explain in the comment the real-life situations where this > > is needed, and why, rather than just explaining in English what the > > code does. > > You are right. How does this patch look like: LGTM, thanks. Is Robert's use case also taken care of? From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 09:15:42 2023 Received: (at 63260) by debbugs.gnu.org; 8 May 2023 13:15:42 +0000 Received: from localhost ([127.0.0.1]:39578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw0iM-0004dB-Dp for submit@debbugs.gnu.org; Mon, 08 May 2023 09:15:42 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:44501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw0iK-0004cw-7R for 63260@debbugs.gnu.org; Mon, 08 May 2023 09:15:40 -0400 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3064099f9b6so2790122f8f.1 for <63260@debbugs.gnu.org>; Mon, 08 May 2023 06:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683551734; x=1686143734; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=U8HlBpYO52WYNlWRykv84L6j80AEIM4MK0rrFAjJmOI=; b=rFH77dXWjWqFpBsAZmACQMONpSMSDlwdYgX+4/ptFZ8vrGc/ZIJqTXKMaUUiwrwlRQ zge6rH+8ST0/9SJWF3FWu1GBI+r5+lDiWSYmFiFCy4VzlYzGMnLvLth+tbkMIOCId7Am HzLsFRHjB6lrwR0nJlq5B68ELOW0m7WqczGlv+5QY0HjwUZE/Ccmi0f4jTv7QagrlTmH YiQdV/6rjrsOXbj5zPq5Slq3cuFhWUN2Rqzf64NoEg9qZ4iMGtkYEjOLTxI+dlxbhr23 qhW5VNLsOm3B+i/NNTHLnrC90lyrGGsscPUJMHbGF92OsI0Bu3hszUnT0kieY+l2UnYU JQew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683551734; x=1686143734; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U8HlBpYO52WYNlWRykv84L6j80AEIM4MK0rrFAjJmOI=; b=O968/cPgzvlf11D1w2HJZBMspf5McVMbyAmgLmFBWjYc1YpEM8gYO2wetHIWGCcAXr mFZR1X4WJAc4t7pt4GnS/VYDzUxJ8VLIigANVu0jlp5yRE+Ai4TtcS97YWOTFKNrH6qw wlUKWp5NyJk4SL9dJpwl7BseDTR+ZpYnBIIac5zAOymQErDLVQ0cXlpjbyzry/KTQshl 0U+GXs8RscUXqoTey+hHYE+jN/yVPI0e8v2GfnO0CXk9WEsu0lqcipjNPlhXF1FSYQlV aDxqox1VtFn61AmK8CS8hcGc4/mqaMm0RHQ3v1WY5sXgSTCSh6aka8agJ8DmZXZ1Ubm3 auOQ== X-Gm-Message-State: AC+VfDzw0+U6ru8pqh6AiQQKAHIhhWTOwYOuyyoZ4XYd7cmFGEc2aFFO IIFUa1pAWBDBR60NETpK2wzLuvg/Sec= X-Google-Smtp-Source: ACHHUZ4nmoT5ObjSYzuWkFWu6YXYjhVYCkIabGYHqzlSCt7Mysl7ZvVVSnTudxKR/FT6HDhzBiJucg== X-Received: by 2002:a5d:6ad2:0:b0:306:3b39:9a3d with SMTP id u18-20020a5d6ad2000000b003063b399a3dmr7571384wrw.15.1683551733858; Mon, 08 May 2023 06:15:33 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id h14-20020a056000000e00b002ceacff44c7sm11327997wrx.83.2023.05.08.06.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 06:15:33 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83v8h3cbtq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 May 2023 14:16:49 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> <83v8h3cbtq.fsf@gnu.org> Date: Mon, 08 May 2023 15:15:32 +0200 Message-ID: <87h6snnevf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 08 May 2023 14:16:49 +0300, Eli Zaretskii said: >> You are right. How does this patch look like: Eli> LGTM, thanks. Is Robert's use case also taken care of? I wasn=CA=BCt aware I had one, Basil reported the bug. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 09:18:12 2023 Received: (at 63260) by debbugs.gnu.org; 8 May 2023 13:18:13 +0000 Received: from localhost ([127.0.0.1]:39583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw0kk-0004i0-Tb for submit@debbugs.gnu.org; Mon, 08 May 2023 09:18:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw0kU-0004gy-Kl for 63260@debbugs.gnu.org; Mon, 08 May 2023 09:18:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw0kN-0003gY-Ew; Mon, 08 May 2023 09:17:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Awm0RSXSqa/nxNBm7r7bAOZ83CtjqQJQVGLC6RER3t4=; b=AUiCCSOwFwNLgZtbZORx 27rX6zYTbxT4M/QNkQ0A2oVl65XMObrfx1sEA3YfbzKPTObpUFHs2mpB2MFMzRaj2o8zVi6nDPENS kfQn/RYlZ0llaan3AkTkaHrWFG+YA4ry09vxvf4AVTgbEu4kcSyFx5cB+IB5LsTLXLgpu1l8c8c7I JNSozWNOCwlCrZV/BwFnKuM4nTGTHMrn49I+dve7jYmppkDokUJOow3SZ3s3S7cy1/KmWIauTAF/c hr/J58kiN5lpoKsbepdt3d0sB9xRiBfCHLfmb7o5pwZCJca67qW2fAdF9Ebt156Bdg+Dik4nP829b HrhZd+SuizT/bA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw0kM-0008RI-Uy; Mon, 08 May 2023 09:17:47 -0400 Date: Mon, 08 May 2023 16:18:47 +0300 Message-Id: <83bkivc66g.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87h6snnevf.fsf@gmail.com> (message from Robert Pluim on Mon, 08 May 2023 15:15:32 +0200) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> <83v8h3cbtq.fsf@gnu.org> <87h6snnevf.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Philip Kaludercic , contovob@tcd.ie, > 63260@debbugs.gnu.org > Date: Mon, 08 May 2023 15:15:32 +0200 > > >>>>> On Mon, 08 May 2023 14:16:49 +0300, Eli Zaretskii said: > >> You are right. How does this patch look like: > > Eli> LGTM, thanks. Is Robert's use case also taken care of? > > I wasnʼt aware I had one, Basil reported the bug. Sorry, I thought you two reported 2 separate issues. From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 09:24:05 2023 Received: (at 63260) by debbugs.gnu.org; 8 May 2023 13:24:05 +0000 Received: from localhost ([127.0.0.1]:39596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw0qT-0004td-9u for submit@debbugs.gnu.org; Mon, 08 May 2023 09:24:05 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:46196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw0qQ-0004sr-Qm for 63260@debbugs.gnu.org; Mon, 08 May 2023 09:24:03 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f427118644so7111965e9.0 for <63260@debbugs.gnu.org>; Mon, 08 May 2023 06:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683552237; x=1686144237; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fgePZB4us2eHMcJs+zrq3Mgw6Yfyzr0MA+5EE2Mfwts=; b=HTSsKmbImDu3pjpHICvZEXO991XzpqoRACwwBVTuinIfafQrOcOVlqU/G+cx9ZYKIb ptzUGCGS7Ki0nCZsgveuFwrhNaLmqKva3A9KSme170KBR7D/AiNuFFYFIWM1buLGE0Wx BuQkwC/n5WMbwwmBXqPucGejj5HKDKLK0n+CBZe74kIugdi3+qXZTB+bXNMR6eOUKyQ4 8y2cBGvDf8x9jA5BAeSp6A6pq//lQ/8z/gh2+HGIsEXg+GDcctNIzvV2zY0eZvuf5+k9 mGM33RmCpSFa6oD6gRBVoe9fCQxEjIN9cJzjzN3Ys2hLuLJUwxalhs7d33WKd279xkzt BTIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683552237; x=1686144237; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fgePZB4us2eHMcJs+zrq3Mgw6Yfyzr0MA+5EE2Mfwts=; b=UVqynb18f6hO6jZnxssHO7W5YCxHpf5QEBFibbgef8vh/ESxTtpyycc9iXnAcBRkZR A8xIwTBZDo4W2o6oqAScREKV5vxYlUTSZvemlWeYUugzWMkcNBtoNEa54d9DqqaUXQHV TgEiiiJnf8hCWzg1UAknKNuYW1ZAEbatXuLeAimkFZsTUdnJJIMBU2fcg+sAS8C0qBdu JpdiZ0YzhUQzG19aFtT9xF3XcFAonc657JW4iMSayCIEtE4Va+Hw1+sZERVwgs8uInZs K/SSS8AmUKbRrcATYbiZEkJymMIr/tAIAYe9zr3e4KksWBLxiso4sTVUnLZEpLLvErsB Ry2w== X-Gm-Message-State: AC+VfDzBKndXyQzjhHLbv5SEdNlC9UfJQJJl3odrjCywK4kUDAq3fJIx bwo/YI5TQHHY1cvcAqLZjkAMREByLJc= X-Google-Smtp-Source: ACHHUZ6PmUafmvP3OKayBb0JWCDKnEBmlekbYuwYmBReMrvd0XjwGV2Kpabo67RbFPsuzsKc+aD8Sg== X-Received: by 2002:a7b:c051:0:b0:3f1:6ec5:3105 with SMTP id u17-20020a7bc051000000b003f16ec53105mr6972033wmc.20.1683552236478; Mon, 08 May 2023 06:23:56 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id k11-20020a7bc40b000000b003f4247fbb5fsm3661849wmi.10.2023.05.08.06.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 06:23:56 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83bkivc66g.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 May 2023 16:18:47 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> <83v8h3cbtq.fsf@gnu.org> <87h6snnevf.fsf@gmail.com> <83bkivc66g.fsf@gnu.org> Date: Mon, 08 May 2023 15:23:55 +0200 Message-ID: <87cz3bnehg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 08 May 2023 16:18:47 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Philip Kaludercic , contovob@tcd.ie, >> 63260@debbugs.gnu.org >> Date: Mon, 08 May 2023 15:15:32 +0200 >>=20 >> >>>>> On Mon, 08 May 2023 14:16:49 +0300, Eli Zaretskii said: >> >> You are right. How does this patch look like: >>=20 Eli> LGTM, thanks. Is Robert's use case also taken care of? >>=20 >> I wasn=CA=BCt aware I had one, Basil reported the bug. Eli> Sorry, I thought you two reported 2 separate issues. There were two separate reports for this issue, plus I reported Bug#63236, but that one=CA=BCs fixed. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed May 10 09:12:57 2023 Received: (at 63260) by debbugs.gnu.org; 10 May 2023 13:12:57 +0000 Received: from localhost ([127.0.0.1]:45548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwjcn-0004wo-IJ for submit@debbugs.gnu.org; Wed, 10 May 2023 09:12:57 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:54631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwjci-0004wX-0Y for 63260@debbugs.gnu.org; Wed, 10 May 2023 09:12:55 -0400 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-30639daee76so4706870f8f.1 for <63260@debbugs.gnu.org>; Wed, 10 May 2023 06:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683724366; x=1686316366; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=q9wP/58Zz5tpgxEYKBWqffjiUg1qjuZDTONY2niBSdY=; b=W0JDI85+laFDyj5I9GB+IFuYYruQ1reODWjVOGWEaVuFeKxIJF3NVtMXpdUaZAa8v8 C0uzU7jrln2VJVaN683XQ+OSbxXkZ4LSfwWQ4U8i1P38WrbZ1XwJJR3ES/WZFUxg8L58 dabeO4vtQzgG7sRTeC2Toss0tSi8ts3lKuedOVCsTXhOyCmDlVJMov56FtG0wujoPqnJ b7OcWiKy440ub/B9fxE3WkKomgcygsYZThHIQEG9fuwyH3nmmWeuDnLjC9qyvghyriGi RWgOs1Qml8ueKfN02PsaV98z9cN1vf6HFpuBiD8/X8UmOeCx/q3+FXE09CdvhBaHVJrW 3QUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683724366; x=1686316366; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q9wP/58Zz5tpgxEYKBWqffjiUg1qjuZDTONY2niBSdY=; b=AMrHxV1HD9LmJsC+6QEyClsyh8cFqvD71jd8Ad+kt9V7XbCkUBbeIg8/td/gonGhzR 8waH0uTwhXHdSkvs3+pAazUnV7cD8N+Y/qsy9L1j4auct7fU41X+fCzP5u3lA/uoJV1v +BnQxPeTogHBZqKVJl/l9HmQlCJ6SG627ROtEdO6p7jTBOWnIGrKsJHQyhC/X8m3Z4la nMPZM9LpXu8GNRRJy0q46rp15YJKIbFW8qAdHKmz4zW89kr58YCxnskhmXfw8G5Dy7IQ B/EWC0OrE4A3M7NWqETACK8ODqQqjg/C1El/6ZWGASOxwP+t7lN3VlDLE2xr9Zk+yuyH xcQg== X-Gm-Message-State: AC+VfDw6sUtbP/lubjU9UmD3uqfzRAGDOC5FAlDjHFZ3sEsra67zgn5C KNEqrhB51KAjOx64wZlT+v+7Hw== X-Google-Smtp-Source: ACHHUZ7wTvWq2J47hRUnotC0uPTtV0tv9aaEId7YQ1gYeGfNL4ywLkFoI1xLxVrEqqDibtS3wUkiKA== X-Received: by 2002:a5d:58d9:0:b0:2f9:1224:2474 with SMTP id o25-20020a5d58d9000000b002f912242474mr12420730wrf.23.1683724366199; Wed, 10 May 2023 06:12:46 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id n10-20020a5d400a000000b00307a3045d65sm5351809wrp.46.2023.05.10.06.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 06:12:45 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <83v8h3cbtq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 May 2023 07:15:49 -0400") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> <83v8h3cbtq.fsf@gnu.org> Date: Wed, 10 May 2023 14:12:44 +0100 Message-ID: <874joks52r.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, Philip Kaludercic , rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2023-05-08 07:15 -0400] wrote: >> From: Philip Kaludercic >> Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com >> Date: Sun, 07 May 2023 19:37:26 +0000 >> >> You are right. How does this patch look like: > > LGTM, thanks. Is Robert's use case also taken care of? Both the package-install and package-quickstart-refresh issues I listed are fixed by the patch. I also checked that loaddefs-generate continues to work in an external package, AFAICT: https://github.com/kyleam/bog/blob/8fc7ff7d926ddb7291df9706b92e09cc8addcfad/Makefile#L20-L28 Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Wed May 10 10:21:54 2023 Received: (at 63260) by debbugs.gnu.org; 10 May 2023 14:21:54 +0000 Received: from localhost ([127.0.0.1]:48574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwkhW-0007eL-B8 for submit@debbugs.gnu.org; Wed, 10 May 2023 10:21:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwkhT-0007e7-R7 for 63260@debbugs.gnu.org; Wed, 10 May 2023 10:21:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwkhO-0000d1-7p; Wed, 10 May 2023 10:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q3ZHfxisK3yR0cuIPz05FKnh/9pIxjCqpFwzMqbzAe8=; b=flCGw5ae3CLh KLH3Y/n1+U+gAxd0KWISJD/FB68J3xRtHcD5CcFCU8TFNIs0RfPHrLLh+9O8LtkurF4x9CcKtyHb+ YHtGSr31IwNgsrg5Wg0eZNsqnB27eSuSEhL+ezGaNSqFQkTyZwBoLeB4otqBgfVE4Ydzcn1rtXTxq EhU37arFdMXXdSN32krwxEXitKpgCbp7qElp/zW/J+8MF2+R9tbS4Z+t/c/2qqLA98F+mOJH+L16T J30VDTwSapZBKpIiH0GWMV9bQKZwe5jFq5Ku28mk3yPMapFi+ouHD5J3KMFm/RYA7TQ6/t7qrlpim lEUYDtebXZ2ei32unY3vtw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwkhN-00029j-OC; Wed, 10 May 2023 10:21:46 -0400 Date: Wed, 10 May 2023 17:22:52 +0300 Message-Id: <834jok8dvn.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios In-Reply-To: <874joks52r.fsf@tcd.ie> (message from Basil Contovounesios on Wed, 10 May 2023 14:12:44 +0100) Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> <83v8h3cbtq.fsf@gnu.org> <874joks52r.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260 Cc: 63260@debbugs.gnu.org, philipk@posteo.net, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Basil Contovounesios > Cc: Philip Kaludercic , 63260@debbugs.gnu.org, > rpluim@gmail.com > Date: Wed, 10 May 2023 14:12:44 +0100 > > Eli Zaretskii [2023-05-08 07:15 -0400] wrote: > > >> From: Philip Kaludercic > >> Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com > >> Date: Sun, 07 May 2023 19:37:26 +0000 > >> > >> You are right. How does this patch look like: > > > > LGTM, thanks. Is Robert's use case also taken care of? > > Both the package-install and package-quickstart-refresh issues I listed > are fixed by the patch. I also checked that loaddefs-generate continues > to work in an external package, AFAICT: > > https://github.com/kyleam/bog/blob/8fc7ff7d926ddb7291df9706b92e09cc8addcfad/Makefile#L20-L28 Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 12 03:43:21 2023 Received: (at 63260-done) by debbugs.gnu.org; 12 May 2023 07:43:21 +0000 Received: from localhost ([127.0.0.1]:53965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNQv-0000fY-9e for submit@debbugs.gnu.org; Fri, 12 May 2023 03:43:21 -0400 Received: from mout02.posteo.de ([185.67.36.66]:42039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNQq-0000fK-PF for 63260-done@debbugs.gnu.org; Fri, 12 May 2023 03:43:19 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 42C3824028E for <63260-done@debbugs.gnu.org>; Fri, 12 May 2023 09:43:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683877391; bh=FoLIGGUQhxBGggsogtLJLojgvl6avSRlvcjOwgAfzVE=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=kF2NifaM/AL9r6AiegCuTS4Eteb/loUdGQBcXPaT8nfPp5Fdkv2GvxwGBtedIvDRF clWVTBj6oYEIwxhgsPVEv9P8J/6rdav7Iz98i3ZXtOPLY8+LMn+s5o2we2v7/5l2fU ZRkmuOKDGW2TEcXcjAIqCaTdTVfv2SS+YHAm9exYm8Whaov/mKLLxG89aOQbBU8yOB 1SR94PUP59YX7kqtVX453mL0zaprZM4y8HowEFfYjB63Hzzz0hMOMqT6DooZfSJej6 oJBVkqP0UPE7kR9Fww0uSrrCTo50CttWIfD+JIn72cSBLL/7dzmP1nAsntSOItZcdG 038UVd5xPqBvQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QHgjT0M5sz6tn4; Fri, 12 May 2023 09:43:09 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#63260: 29.0.90; Regression installing/activating packages without autoloads In-Reply-To: <834jok8dvn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 May 2023 17:22:52 +0300") References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> <83cz3ce0qq.fsf@gnu.org> <87jzxkgcg9.fsf@posteo.net> <83v8h3cbtq.fsf@gnu.org> <874joks52r.fsf@tcd.ie> <834jok8dvn.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 12 May 2023 07:43:08 +0000 Message-ID: <87pm76vvub.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63260-done Cc: Basil Contovounesios , 63260-done@debbugs.gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Basil Contovounesios >> Cc: Philip Kaludercic , 63260@debbugs.gnu.org, >> rpluim@gmail.com >> Date: Wed, 10 May 2023 14:12:44 +0100 >> >> Eli Zaretskii [2023-05-08 07:15 -0400] wrote: >> >> >> From: Philip Kaludercic >> >> Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com >> >> Date: Sun, 07 May 2023 19:37:26 +0000 >> >> >> >> You are right. How does this patch look like: >> > >> > LGTM, thanks. Is Robert's use case also taken care of? >> >> Both the package-install and package-quickstart-refresh issues I listed >> are fixed by the patch. I also checked that loaddefs-generate continues >> to work in an external package, AFAICT: >> >> https://github.com/kyleam/bog/blob/8fc7ff7d926ddb7291df9706b92e09cc8addcfad/Makefile#L20-L28 > > Thanks. I've pushed the changes. From unknown Mon Jun 23 11:26:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Jun 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator