From unknown Thu Aug 14 17:27:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63251 <63251@debbugs.gnu.org> To: bug#63251 <63251@debbugs.gnu.org> Subject: Status: 28.2; vhdl-mode contribution Reply-To: bug#63251 <63251@debbugs.gnu.org> Date: Fri, 15 Aug 2025 00:27:57 +0000 retitle 63251 28.2; vhdl-mode contribution reassign 63251 emacs submitter 63251 Cyril Arnould severity 63251 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 15:45:34 2023 Received: (at submit) by debbugs.gnu.org; 3 May 2023 19:45:34 +0000 Received: from localhost ([127.0.0.1]:47766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puIPt-00013x-U8 for submit@debbugs.gnu.org; Wed, 03 May 2023 15:45:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:52508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puIPo-00013j-39 for submit@debbugs.gnu.org; Wed, 03 May 2023 15:45:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puIPm-0002cd-GH for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 15:45:27 -0400 Received: from mail-vi1eur04olkn0804.outbound.protection.outlook.com ([2a01:111:f400:fe0e::804] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puIPj-0001SM-83 for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 15:45:26 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e1rR4gX/okzFNOuHtcxbvsOIAzHjajAWYgT53lJjPyjxqUrMdtxY/FtHVXE9w1Ty4Vol3pKXM/LCnrhpMaRo5UJ4ZLh4/adL6TH+bachX0Flap0F1Cuu2VH7jO6YphGzYx+WoKZOW1F5SBg22AorIEtfDOpsxYt3t272Vy00fDfkZrewDfVEUBuJj4UO+MGy6g9r4rlBuEa7LSAhUYeC3btyVQ71tigOOR1aTRs8kOx/AnvGrBhaFPjqzmcsXNTxt6FypxeuZMFYrb/PVaR8kKg0bH9ee1eTRAJBwPPm8JlKBa6qZcEA/tuby8ptS5sun/xMrdN1FFkbQeQnI4yVMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xsvh4bAYb5xKJNRMym/Zn2BE/2AVAE8MEOdqjYPX3A=; b=WP3zt4yO0VzPdcdYR3CWjvI4Z89QCseqhDbwIdvDhUzMW6DTzc7T6LRE4NESjbNxgxdiipjBqVfusr+fBldCspFHFL6I7HaKAVXzuf0zNY9eRfUnLg+n1GdnDakoJjG/B1mrYoXn5yL2H4GyryNU14UPupfJdE/OI2/iCLo57Cp9kz+6gfh2edkvDWxadJ/0PHqCCHu2fxQBZk1Pjl4Y3iYVvFqXd42sZJZkyhgcKO81F8ByUGwL8xtIA6vi9u4/grC55KCzDPqv3zDgrjS5M7GliNUuD4T8b98wGRqV3fopFVPRjZgmoLSeDvCfltCk+gr22WPei6y+bVvmEhVpgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xsvh4bAYb5xKJNRMym/Zn2BE/2AVAE8MEOdqjYPX3A=; b=BHFH7QGjaItNePAX8s1rcWNV/HqPbZ2CMQtuQjh11qAXFRz1TNK0BqxhAQy7o9QhpRIM6MmPKV6pvRVG4mTpCND3bixWgXZuv2K+8ACZ6zUFZyUtNNnXG+aITIHG+wrXikZfrCrFxVjh2uO/WYQS/cX69qBHy9mff2e+mvJbgqYCaByXWfN95h5BSfrPBNmdcrwDgIPNIcAqCyTnHKuqgz3e4pyuW4K2lFADb3Lesh/EoycV1DnzU67FxQWmYb2Y2Wn5FCov8j1mvAjrntvKhWvWDsU8e9VRa7VjSmWOEUAADc+7c4S/UzO14OPLaJLZZJQYczKccWJfbxcMNYMElA== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by AS1PR10MB5603.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:47a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 19:40:18 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.022; Wed, 3 May 2023 19:40:18 +0000 From: Cyril Arnould To: "bug-gnu-emacs@gnu.org" Subject: 28.2; vhdl-mode contribution Thread-Topic: 28.2; vhdl-mode contribution Thread-Index: AQHZffbrSAlGpj5IuUWqMPuC8AoM3Q== Date: Wed, 3 May 2023 19:40:18 +0000 Message-ID: Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [YwQ8Erwzx8OXSfFr+B6yvf2zeZrGvki3] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|AS1PR10MB5603:EE_ x-ms-office365-filtering-correlation-id: 6319c7e5-303e-4010-6a32-08db4c0e397e x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zdSnAayk3VmW1Cm01Tf1GL4SQEJJSwVYDPGhVGyvu0Q+0bg6CPK5MYwgTrK9ObG72BdVHx0BFe0gkexrF9erjSlUGgbGmPaXLvPjl8rPVn5TCTyl06GQ3mYQ7WD7Tf4B5eyCdgLd58OKenghDSnTxeXq6z2K5oeUiYsq8Kc0PNP8R63Y8BqZFb4g6wBRjREARZViZIP3DzvGA2YaM6Z55rIbtcHp1QXeqzRI/H67aCGuA153Ib4ehkhBCbScPOjyuFLBtK1TlZzNNtjZoU/OJZwsNm9xOvW2JqPsVkUc3QL2BFbpv+2nS05rSLWvHo2xIvRNYKo2jl9/QFFk3WgoBtmktdiu4PkA+OKK9IoJSLNcZrl9Q8jG04uLRZAga1tBpBY9HiU1wV+3KUmXzpzxWykjFHWAsqVbq2zhJjszGvVmCia6Jnu5s7P+ztcfiOqlbkafuWO6AKegUDiB/miHTJutsricia4N5AM6i05NNHFJE2IEqPKrIYYFvs805ScwYe2Ok2eB1mcQHXWegQjT3p+GH3DHcHbTArhE5E6JjzcKVLB9VykIxZ5540f4vLj2 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FGCKW3w7F8JEwStyMNvpqTwmQ+CABbKVOzioIBta210qay2EpBQ9pTsbjjVK?= =?us-ascii?Q?tIsT5drhl3LHWpk0tlrKwxpUxlsDOmqIL2QNbSC6NRCIKrrgXi0IYqp7OCtm?= =?us-ascii?Q?BORdjP6n9R5y1anA5zSUOPO2H0T5RPacLqQ7zZpfUx+Mfe8ztbOSuZKMawAV?= =?us-ascii?Q?w/2+3plkRqoynx2W9hk/Ooy8pUOhbtE0awzD9ajf3UV5nBMZgAVizbC+JHui?= =?us-ascii?Q?OMtNGqxKUTCLBg+Kv/rtsKAwFjrXU9gTMnUmLzHyGqkNfdaHeUoBx0T9+bEW?= =?us-ascii?Q?tU7D0quMfHAZxirV3+0T72ThhCkDkT7P3jB2Y7iocLnqGaWXNuXDTMJVIQAe?= =?us-ascii?Q?58uBJ8Eot2lQf6qaOv1qMCU9GXmGY/BrzwbySzClnh/pl1DmfTMAo0iAFqJE?= =?us-ascii?Q?EeI+DkiRuG1iVmGXAfxwHytUnrUJeCixQ0vsEHUCMSZjQOBpDSiY6U284M33?= =?us-ascii?Q?1gUbbZNNxy+e6pSzyH/lAUWtuRXMlUj/+J6kjEViB7qBCbDLfZhXyUTS1hNp?= =?us-ascii?Q?GrGToA2A3E9OMzJzbKNoEpR6uBi+rzjR4y+FSaW5oJiMPfaca111KaXUJR6b?= =?us-ascii?Q?d/0iEqD0DMFEzjorrJRzI4o/BaLpJ2dSdAGj+ZkbRa1dqCkxaUtwKQfNTJMA?= =?us-ascii?Q?oz+K9YFIdbA+Xl83eFrPnrOu1CqHIU80hmuypE6aTYqgPOdgq8/Q+ua82c0Z?= =?us-ascii?Q?ne2B+AS3BCzNaTmZ7hVKp9zbO1xDawhP2xwMVqxt7G02jeMMSlkQYutJ0L1d?= =?us-ascii?Q?gfHVjbdy1+XD2GfZ5spOX3xUFTi712GORqM46TRVDxC/lI2HjmsPQGgibth4?= =?us-ascii?Q?DsHnCAiXYpBnxKR8RsYBOgPls1UAAq8AK4dDdHrhr9DUwiMr7lcvYufVKVAC?= =?us-ascii?Q?pk+sLFtV7Cb1G6HYUnG/TL+vpLaEDpzDrZS5CLwe1aPrXs7BHLL3WfHb/5T6?= =?us-ascii?Q?t0Gw0v50p3Plq34tvfFeh/tGxK0lyb90gPc1bW2rv519WmnhibT7XIfhqsAV?= =?us-ascii?Q?nagyIbOXx5YGz3n9kt/xg8L/RPKcUHnORZwI5FUjYuBWZkeGf6MUZQjOAO5b?= =?us-ascii?Q?aVp4tksBn8DUrHzaa9GmgrHfDyAr+HnzICbpiQtptLcKZsOxihfOB5MgjBnE?= =?us-ascii?Q?YF07w1NABB4UVXQLucMxjMbsSupGPeCFHY4pwbdtvJdnmJlLEOopN/9gCEEo?= =?us-ascii?Q?AXYTKfwkObW5lp+go0RjpZfqzJRdZ20NZ7ukycAR0AEV52VhpTcL9H7QbNbh?= =?us-ascii?Q?g2UfOuZ6R4mCmWb+R0ZI?= Content-Type: multipart/alternative; boundary="_000_AS4PR10MB6110128C3D7D01D1251D8BA8E36C9AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 6319c7e5-303e-4010-6a32-08db4c0e397e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 19:40:18.0756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR10MB5603 Received-SPF: pass client-ip=2a01:111:f400:fe0e::804; envelope-from=cyril.arnould@outlook.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --_000_AS4PR10MB6110128C3D7D01D1251D8BA8E36C9AS4PR10MB6110EURP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Following bug#62508, I've taken a bit of a closer look at the compiler regexp for ModelSim. I've modified it so that it can differentiate between Errors, Warnings and Notes when highlighting. I also make use of Xilinx Vivado at work, for which I've added a new compiler entry: --- a/lisp/progmodes/vhdl-mode.el +++ b/lisp/progmodes/vhdl-mode.el @@ -286,7 +286,7 @@ vhdl-compiler-alist ;; counter_rtl.vhd(29):Conditional signal assignment line__29 ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1" nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim" - ("^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\= [[0-9]+]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil) + ("^\\(?:\\(?1:ERROR\\|\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warnin= g\\)\\|\\(?3:NOTE\\|\\*\\* Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \= \(?4:[^ \t\n]+\\)(\\(?5:[0-9]+\\)):" 4 5 nil (2 . 3)) ("" 0) ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat" "\\1/_primary.dat" "\\1/body.dat" downcase)) @@ -385,6 +385,13 @@ vhdl-compiler-alist nil "mkdir \\1" "./" "work/" "Makefile" "xilinx" ("^ERROR:HDLParsers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\.= " 1 2 nil) ("" 0) nil) + ;; Xilinx Vivado: + ;; ERROR: [VRFC 10-1412] syntax error near o_idle [test.vhd:23] + ("Xilinx Vivado" "xvhdl" "" "make" "-f \\1" + nil "mkdir \\1" "./" "work" "Makefile" "vivado" + ("^\\(?:\\(?1:ERROR\\)\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\= ) \\[\\(?4:[^ \t\n]+\\):\\(?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0) + ("\\1/entity" "\\2/\\1" "\\1/configuration" + "\\1/package" "\\1/body" downcase)) ) "List of available VHDL compilers and their properties. Each list entry specifies the following items for a compiler: The patch was generated from the emacs master branch. I would greatly appreciate it if these changes could find their way in some form into a future emacs release. Cyril In GNU Emacs 28.2 (build 2, x86_64-w64-mingw32) of 2022-10-11 built on fv-az277-711 Repository revision: b35f9af313a5d5c42988eb5a7751209b4234a67e Repository branch: master Windowing system distributor 'Microsoft Corp.', version 10.0.19044 System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2846) Configured using: 'configure --prefix=3D/ucrt64 --host=3Dx86_64-w64-mingw32 --build=3Dx86_64-w64-mingw32 --with-modules --without-dbus --without-compress-install --with-native-compilation 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe' CPPFLAGS=3D-D__USE_MINGW_ANSI_STDIO=3D1 LDFLAGS=3D-pipe' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULES NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM ZLIB Important settings: value of $LANG: en_GB locale-coding-system: cp1252 Major mode: Outline Minor modes in effect: bug-reference-mode: t display-line-numbers-mode: t override-global-mode: t delete-selection-mode: t tabbar-mwheel-mode: t tabbar-mode: t global-so-long-mode: t global-flycheck-mode: t flycheck-mode: t cua-mode: t company-tng-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: ~/.lisp/load/vhdl-mode hides c:/msys64/ucrt64/share/emacs/28.2/lisp/progmod= es/vhdl-mode Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail comp comp-cstr warnings rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils bug-reference noutline outline grep compile text-property-search comint ring time-date vc-git diff-mode vc-dispatcher display-line-numbers cl-extra use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key use-package-core server delsel tabbar easy-mmode so-long flycheck ansi-color find-func help-mode rx dash cua-base company-tng company edmacro kmacro pcase cus-load tex-site info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 188555 94726) (symbols 48 14756 152) (strings 32 47401 16490) (string-bytes 1 1658309) (vectors 16 27316) (vector-slots 8 484534 272322) (floats 8 77 281) (intervals 56 371 432) (buffers 992 15)) --_000_AS4PR10MB6110128C3D7D01D1251D8BA8E36C9AS4PR10MB6110EURP_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Following bug#62508, I've taken a bit of a closer lo= ok at the compiler

regexp for ModelSim. I've modified it so that it can= differentiate

between Errors, Warnings and Notes when highlighting= . I also make use of

Xilinx Vivado at work, for which I've added a new co= mpiler entry:

 

 

--- a/lisp/progmodes/vhdl-mode.el

+++ b/lisp/progmodes/vhdl-mode.el

@@ -286,7 +286,7 @@ vhdl-compiler-alist

     ;;    counte= r_rtl.vhd(29):Conditional signal assignment line__29

     ("ModelSim" "= ;vcom" "-93 -work \\1" "make" "-f \\1"

      nil "vlib \\1; v= map \\2 \\1" "./" "work/" "Makefile" &qu= ot;modelsim"

-     ("^\\(ERROR\\|WARNING= \\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(= [^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil)

+     ("^\\(?:\\(?1:ERROR\\= |\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warning\\)\\|\\(?3:NOTE\\|\\*\\* = Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(?4:[^ \t\n]+\\)(\\(?5:[0-= 9]+\\)):" 4 5 nil (2 . 3))

      ("" 0)

      ("\\1/_primary.d= at" "\\2/\\1.dat" "\\1/_primary.dat"

       "\\1/_prim= ary.dat" "\\1/body.dat" downcase))

@@ -385,6 +385,13 @@ vhdl-compiler-alist

      nil "mkdir \\1&q= uot; "./" "work/" "Makefile" "xilinx&quo= t;

      ("^ERROR:HDLPars= ers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\." 1 2 n= il) ("" 0)

      nil)

+    ;; Xilinx Vivado:

+    ;; ERROR: [VRFC 10-1412] syntax = error near o_idle [test.vhd:23]

+    ("Xilinx Vivado" "= ;xvhdl" "" "make" "-f \\1"

+     nil "mkdir \\1" = "./" "work" "Makefile" "vivado"

+     ("^\\(?:\\(?1:ERROR\\= )\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\) \\[\\(?4:[^ \t\n]+\\):\\(= ?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0)

+     ("\\1/entity" &q= uot;\\2/\\1" "\\1/configuration"

+      "\\1/package&qu= ot; "\\1/body" downcase))

     )

   "List of available VHDL compilers = and their properties.

Each list entry specifies the following items for a = compiler:

 

 

The patch was generated from the emacs master branch= . I would greatly

appreciate it if these changes could find their way = in some form into a

future emacs release.

 

Cyril

 

 

In GNU Emacs 28.2 (build 2, x86_64-w64-mingw32)

of 2022-10-11 built on fv-az277-711

Repository revision: b35f9af313a5d5c42988eb5a7751209= b4234a67e

Repository branch: master

Windowing system distributor 'Microsoft Corp.', vers= ion 10.0.19044

System Description: Microsoft Windows 10 Pro (v10.0.= 2009.19044.2846)

 

Configured using:

'configure --prefix=3D/ucrt64 --host=3Dx86_64-w64-mi= ngw32

--build=3Dx86_64-w64-mingw32 --with-modules --withou= t-dbus

--without-compress-install --with-native-compilation=

'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe= '

CPPFLAGS=3D-D__USE_MINGW_ANSI_STDIO=3D1 LDFLAGS=3D-p= ipe'

 

Configured features:

ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULE= S NATIVE_COMP NOTIFY

W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKI= T_SCROLL_BARS XPM

ZLIB

 

Important settings:

  value of $LANG: en_GB

  locale-coding-system: cp1252

 

Major mode: Outline

 

Minor modes in effect:

  bug-reference-mode: t

  display-line-numbers-mode: t

  override-global-mode: t

  delete-selection-mode: t

  tabbar-mwheel-mode: t

  tabbar-mode: t

  global-so-long-mode: t

  global-flycheck-mode: t

  flycheck-mode: t

  cua-mode: t

  company-tng-mode: t

  tooltip-mode: t

  global-eldoc-mode: t

  show-paren-mode: t

  electric-indent-mode: t

  mouse-wheel-mode: t

  menu-bar-mode: t

  file-name-shadow-mode: t

  global-font-lock-mode: t

  font-lock-mode: t

  blink-cursor-mode: t

  auto-composition-mode: t

  auto-encryption-mode: t

  auto-compression-mode: t

  size-indication-mode: t

  column-number-mode: t

  line-number-mode: t

  visual-line-mode: t

  transient-mark-mode: t

 

Load-path shadows:

~/.lisp/load/vhdl-mode hides c:/msys64/ucrt64/share/= emacs/28.2/lisp/progmodes/vhdl-mode

 

Features:

(shadow sort mail-extr emacsbug message rmc puny dir= ed dired-loaddefs

rfc822 mml mml-sec epa derived epg rfc6068 epg-confi= g gnus-util rmail

rmail-loaddefs mm-decode mm-bodies mm-encode mail-pa= rse rfc2231

mailabbrev gmm-utils mailheader sendmail comp comp-c= str warnings rfc2047

rfc2045 ietf-drums mm-util mail-prsvr mail-utils bug= -reference noutline

outline grep compile text-property-search comint rin= g time-date vc-git

diff-mode vc-dispatcher display-line-numbers cl-extr= a use-package

use-package-ensure use-package-delight use-package-d= iminish

use-package-bind-key bind-key use-package-core serve= r delsel tabbar

easy-mmode so-long flycheck ansi-color find-func hel= p-mode rx dash

cua-base company-tng company edmacro kmacro pcase cu= s-load tex-site info

package browse-url url url-proxy url-privacy url-exp= and url-methods

url-history url-cookie url-domsuf url-util mailcap u= rl-handlers

url-parse auth-source cl-seq eieio eieio-core cl-mac= s eieio-loaddefs

password-cache json subr-x map url-vars seq byte-opt= gv bytecomp

byte-compile cconv cl-loaddefs cl-lib iso-transl too= ltip eldoc paren

electric uniquify ediff-hook vc-hooks lisp-float-typ= e elisp-mode mwheel

dos-w32 ls-lisp disp-table term/w32-win w32-win w32-= vars term/common-win

tool-bar dnd fontset image regexp-opt fringe tabulat= ed-list replace

newcomment text-mode lisp-mode prog-mode register pa= ge tab-bar menu-bar

rfn-eshadow isearch easymenu timer select scroll-bar= mouse jit-lock

font-lock syntax font-core term/tty-colors frame min= ibuffer cl-generic

cham georgian utf-8-lang misc-lang vietnamese tibeta= n thai tai-viet lao

korean japanese eucjp-ms cp51932 hebrew greek romani= an slovak czech

european ethiopic indian cyrillic chinese composite = emoji-zwj charscript

charprop case-table epa-hook jka-cmpr-hook help simp= le abbrev obarray

cl-preloaded nadvice button loaddefs faces cus-face = macroexp files

window text-properties overlay sha1 md5 base64 forma= t env code-pages

mule custom widget hashtable-print-readable backquot= e threads w32notify

w32 multi-tty make-network-process native-compile em= acs)

 

Memory information:

((conses 16 188555 94726)

(symbols 48 14756 152)

(strings 32 47401 16490)

(string-bytes 1 1658309)

(vectors 16 27316)

(vector-slots 8 484534 272322)

(floats 8 77 281)

(intervals 56 371 432)

(buffers 992 15))

--_000_AS4PR10MB6110128C3D7D01D1251D8BA8E36C9AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 01:16:10 2023 Received: (at 63251) by debbugs.gnu.org; 4 May 2023 05:16:10 +0000 Received: from localhost ([127.0.0.1]:48213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puRK5-0003hn-Qk for submit@debbugs.gnu.org; Thu, 04 May 2023 01:16:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puRK0-0003h0-GX for 63251@debbugs.gnu.org; Thu, 04 May 2023 01:16:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRJs-0007DP-SD; Thu, 04 May 2023 01:15:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cj0NHSQnRY39694sLQB3K7hujXz4ISd3BOevJ+VlDic=; b=bERtg9YzXz/x iyeoCL3YbvuPrs6EHdfQN5yGIe1hKb3xMyDtK0VCey8Oj2i1wieYKsXTfW35q14pnOWIjyGR7kSLj RJM3WvRrYbMZXgOtxhUwY9sKAC+9X+0YQPXVTdBmUGvIingbVm3XMU4RrFgT4ggDfH2gx25X8tQaO mCELXBkgqV4uTbVvCmRnzJbuSKJx7PYSXV5BBdBY+y/6JBWonUeXq7IjkMDC/HLa6mKidQ7+RRHeS Ft1wj7QnrWWW3VRqj9I1pPplIbiUmQy8LPHnm5TK11CDV+lI2Dna/wwv2p6fHfWE5T6wJOsYy6jXN qvTDQfMy/Oktr7uHUEMPuA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRJs-0008SO-A7; Thu, 04 May 2023 01:15:56 -0400 Date: Thu, 04 May 2023 08:16:47 +0300 Message-Id: <83mt2kllq8.fsf@gnu.org> From: Eli Zaretskii To: Cyril Arnould , Reto Zimmermann In-Reply-To: (message from Cyril Arnould on Wed, 3 May 2023 19:40:18 +0000) Subject: Re: bug#63251: 28.2; vhdl-mode contribution References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63251 Cc: 63251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Cyril Arnould > Date: Wed, 3 May 2023 19:40:18 +0000 > > Following bug#62508, I've taken a bit of a closer look at the compiler > regexp for ModelSim. I've modified it so that it can differentiate > between Errors, Warnings and Notes when highlighting. I also make use of > Xilinx Vivado at work, for which I've added a new compiler entry: > > > --- a/lisp/progmodes/vhdl-mode.el > +++ b/lisp/progmodes/vhdl-mode.el > @@ -286,7 +286,7 @@ vhdl-compiler-alist > ;; counter_rtl.vhd(29):Conditional signal assignment line__29 > ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1" > nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim" > - ("^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil) > + ("^\\(?:\\(?1:ERROR\\|\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warning\\)\\|\\(?3:NOTE\\|\\*\\* Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(?4:[^ \t\n]+\\)(\\(?5:[0-9]+\\)):" 4 5 nil (2 . 3)) > ("" 0) > ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat" > "\\1/_primary.dat" "\\1/body.dat" downcase)) > @@ -385,6 +385,13 @@ vhdl-compiler-alist > nil "mkdir \\1" "./" "work/" "Makefile" "xilinx" > ("^ERROR:HDLParsers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\." 1 2 nil) ("" 0) > nil) > + ;; Xilinx Vivado: > + ;; ERROR: [VRFC 10-1412] syntax error near o_idle [test.vhd:23] > + ("Xilinx Vivado" "xvhdl" "" "make" "-f \\1" > + nil "mkdir \\1" "./" "work" "Makefile" "vivado" > + ("^\\(?:\\(?1:ERROR\\)\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\) \\[\\(?4:[^ \t\n]+\\):\\(?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0) > + ("\\1/entity" "\\2/\\1" "\\1/configuration" > + "\\1/package" "\\1/body" downcase)) > ) > "List of available VHDL compilers and their properties. > Each list entry specifies the following items for a compiler: > > > The patch was generated from the emacs master branch. I would greatly > appreciate it if these changes could find their way in some form into a > future emacs release. Reto, any comments on these changes? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 09:56:51 2023 Received: (at 63251) by debbugs.gnu.org; 4 May 2023 13:56:51 +0000 Received: from localhost ([127.0.0.1]:51602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZRy-0005Qv-V7 for submit@debbugs.gnu.org; Thu, 04 May 2023 09:56:51 -0400 Received: from asave02.hostfactory.ch ([217.150.252.154]:39798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZRu-0005Qk-2o for 63251@debbugs.gnu.org; Thu, 04 May 2023 09:56:49 -0400 Received: from server09.hostfactory.ch ([185.117.170.110]) by asave02.hostfactory.ch with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puZRq-00075y-V3; Thu, 04 May 2023 15:56:44 +0200 Received: from [192.168.0.99] (77-56-245-67.dclient.hispeed.ch [77.56.245.67]) (Authenticated sender: reto@retoweb.net) by server09.hostfactory.ch (Postfix) with ESMTPSA id C1FD2600241BB; Thu, 4 May 2023 15:56:41 +0200 (CEST) Message-ID: <3d52f4b8-a8d8-0eb7-1b61-8c5c8310bc1c@gnu.org> Date: Thu, 4 May 2023 15:56:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: bug#63251: 28.2; vhdl-mode contribution To: Eli Zaretskii , Cyril Arnould References: <83mt2kllq8.fsf@gnu.org> Content-Language: en-US From: Reto Zimmermann In-Reply-To: <83mt2kllq8.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <168320860207.15714.1218128604380003203@server09.hostfactory.ch> X-PPP-Vhost: retoweb.net X-Originating-IP: 185.117.170.110 X-SpamExperts-Domain: outboundprotection.hostfactory.ch X-SpamExperts-Username: 185.117.170.110 Authentication-Results: hostfactory.ch; auth=pass smtp.auth=185.117.170.110@outboundprotection.hostfactory.ch X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.19) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8fqpyGU+JKm7iH73NU12oXPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5zWeeXfe8rOJaVknViDr+wSeeTGE6/jLakLVHLNXqEJIhxS lJfpC26YA1p3y1AvmgZGfE8dHb9EGwzAhulvvFKhS+D2vI6B8nXTKx6M89rgzb9x5lMX6MhbABoo mERJbytaa40DxZPJuLUk3zkVKd8p4CuEXwMMCcu55/Z5CMTXnATZv3yedj9bxcXA/piha0/6oZjM /85swxkmKciKJwjqgDi+/7T16DN8cGs8VO04+YvoyRoynzCZCifNLhKZU97iVUdm9my+LflbFqbt gFcIEmJdZutYAM85hpsRCgzMqwCLV82M5MY/DVZtIrYIsdPUNrOF2YK2uKlri+LH134sPEg+PVRT iaxPY52n0Pp/846HfW6p0vld2I/++zLm8KrifXYuDMhUEM3aQb/Gz0q0UJqTJuY710nJBeCWvY4Q XlZnXtPburoqP/j1uizZfx9DFxQeM5hKKDqHvwRqP46o31/E3ahF5MMcDI7KdpjQKZ4xqPIc0G6k bpHbawWavOrDYwYZzM+Usa8X+GuUY3CVXj3gjnaj+6UA0UPkADHoS6gJylT+GdeVzzo8fCPU9s2+ 535SEn7rjFiHERuQKNS8YLXq+u4v0mZOOS2cVS/DC44pfZuA8vIitSY8vMUDbvJIIlqT7HdthvnW /HDJedAt00JnDHy8VhAbXwypogrG9boETNcXg0/k5loninDL6ejmGs1Fa3xRHcJFHrX8LUVeKy// ID+N6a23qUSq5sK6rs4Fql/GuR+Ch6lqof1bP1vZlWt5H5mTj8r6wDADTytxhcaeFEm4YEUVXGgG XXK/43sznPunxWOK/5KzMPZOo8INhVu8QoRS41zQjPD1gQaoE2Yrl6aI8RzFt5UsHsUSch0UL40x ARcvLP9Hl9oSm7D1H/aAwarQpYDOYx/6JtUOs41DYOkfnwGBKP3aDOh2BtEBWs5rHreiDqaaHPgA WeBHM2nbd7xDKxZk0UvQPaisxQ0nfMeJr16/UsQutzu7gxR4wxwZ8qskvIwViyrCeNjyIjDa8uNA BnQQY/89rctZsVlq7B0RSfPOO8v8OQPPPegyVg/0EwbglKTKjDjOURo= X-Report-Abuse-To: spam@asave01.hostfactory.ch X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 63251 Cc: 63251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) On 2023-05-04 07:16, Eli Zaretskii wrote: >> From: Cyril Arnould >> Date: Wed, 3 May 2023 19:40:18 +0000 >> >> Following bug#62508, I've taken a bit of a closer look at the compiler >> regexp for ModelSim. I've modified it so that it can differentiate >> between Errors, Warnings and Notes when highlighting. I also make use of >> Xilinx Vivado at work, for which I've added a new compiler entry: >> >> >> --- a/lisp/progmodes/vhdl-mode.el >> +++ b/lisp/progmodes/vhdl-mode.el >> @@ -286,7 +286,7 @@ vhdl-compiler-alist >> ;; counter_rtl.vhd(29):Conditional signal assignment line__29 >> ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1" >> nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim" >> - ("^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil) >> + ("^\\(?:\\(?1:ERROR\\|\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warning\\)\\|\\(?3:NOTE\\|\\*\\* Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(?4:[^ \t\n]+\\)(\\(?5:[0-9]+\\)):" 4 5 nil (2 . 3)) >> ("" 0) >> ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat" >> "\\1/_primary.dat" "\\1/body.dat" downcase)) >> @@ -385,6 +385,13 @@ vhdl-compiler-alist >> nil "mkdir \\1" "./" "work/" "Makefile" "xilinx" >> ("^ERROR:HDLParsers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\." 1 2 nil) ("" 0) >> nil) >> + ;; Xilinx Vivado: >> + ;; ERROR: [VRFC 10-1412] syntax error near o_idle [test.vhd:23] >> + ("Xilinx Vivado" "xvhdl" "" "make" "-f \\1" >> + nil "mkdir \\1" "./" "work" "Makefile" "vivado" >> + ("^\\(?:\\(?1:ERROR\\)\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\) \\[\\(?4:[^ \t\n]+\\):\\(?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0) >> + ("\\1/entity" "\\2/\\1" "\\1/configuration" >> + "\\1/package" "\\1/body" downcase)) >> ) >> "List of available VHDL compilers and their properties. >> Each list entry specifies the following items for a compiler: >> >> >> The patch was generated from the emacs master branch. I would greatly >> appreciate it if these changes could find their way in some form into a >> future emacs release. > Reto, any comments on these changes? > > Thanks. The changes look good to me. Thanks, Reto From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 01:46:39 2023 Received: (at 63251-done) by debbugs.gnu.org; 5 May 2023 05:46:39 +0000 Received: from localhost ([127.0.0.1]:52902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puoH8-0003ip-MF for submit@debbugs.gnu.org; Fri, 05 May 2023 01:46:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puoH4-0003iY-Ka for 63251-done@debbugs.gnu.org; Fri, 05 May 2023 01:46:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puoGw-0005Op-0H; Fri, 05 May 2023 01:46:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nDSmUm0s4tY9Mf4Q35bfw4iyCtS1dti48qvevpu9rC0=; b=r0wZ85Y8nBO/ Aw9TNRIbEkqso8FchzRsK4fOujBoDSIJ8mRX7h/SmCkJtHmrd7opt34DSiNjiSafDVWoTmrnfiTPp 7jCq0MTkUb2eg0ILqkvTx3aiqoaysL+yiCJTmvYAxQBvW/1ak2ppFeca3dzR3zQNDc1frcPRypdc/ 5myCg7eY8wjaGUvDxMz/g4VtHi8EquIYjj1YBV47ny+L4IR+ZCfuxdI4wseCmRnVIROlCB2E4D/Ps DE0RnTaBfU0hQY9dFZnHhR2hpev2UXTJG8yHKq2twCW5nUwPFJszO69H5R9cBBG5eVtC7VS6jpEXg yE9ZNn2QQrTDFJFOsoxaGw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puoGq-0003fW-0i; Fri, 05 May 2023 01:46:23 -0400 Date: Fri, 05 May 2023 08:47:11 +0300 Message-Id: <83h6srjpnk.fsf@gnu.org> From: Eli Zaretskii To: Reto Zimmermann In-Reply-To: <3d52f4b8-a8d8-0eb7-1b61-8c5c8310bc1c@gnu.org> (message from Reto Zimmermann on Thu, 4 May 2023 15:56:42 +0200) Subject: Re: bug#63251: 28.2; vhdl-mode contribution References: <83mt2kllq8.fsf@gnu.org> <3d52f4b8-a8d8-0eb7-1b61-8c5c8310bc1c@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63251-done Cc: 63251-done@debbugs.gnu.org, cyril.arnould@outlook.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 4 May 2023 15:56:42 +0200 > Cc: 63251@debbugs.gnu.org > From: Reto Zimmermann > > > Reto, any comments on these changes? > > > > Thanks. > The changes look good to me. Thanks, installed on the emacs-29 branch, and closing. From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 05:22:57 2023 Received: (at 63251) by debbugs.gnu.org; 6 May 2023 09:22:57 +0000 Received: from localhost ([127.0.0.1]:59422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvE81-0007Bc-6c for submit@debbugs.gnu.org; Sat, 06 May 2023 05:22:57 -0400 Received: from mail-lj1-f179.google.com ([209.85.208.179]:61468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvE7w-0007BJ-6e for 63251@debbugs.gnu.org; Sat, 06 May 2023 05:22:55 -0400 Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2ac8c0fbb16so14739601fa.2 for <63251@debbugs.gnu.org>; Sat, 06 May 2023 02:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683364966; x=1685956966; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=GLpO1cNAvExQM61u5vjPwwxA/FBPBsVJoXa4mIUft1E=; b=TeOFEgRneTpKdrSOF4NpcmuuffinDGv4OqtliyvtqvK4h+1JCq3qXPUJpLof6OcmJq XBkZ5z+cI2RaQMT71HTvFn4mMEnIyGDoWbCB6+8YIFo7u/LxH6NRn2rypWFTnJxy1d+Y AFOCQjh54GFosgI/ajAsy6wwiaP2bqXue47mJzJpsufyf4EKPMjQqrVcIWD4QCNPEfNu rT9D1gvqtSDI7zd8RhDgp59hwpS99jko/q/pOyJtxNM9vb0+YMm4lzMubxrYnwV4LlJw rNQ6mr/+WiEzNxedIBaKu1jmODpuijTqTjtXAEuu7ki+CoSOjawLSe8G/YAJsYzhNhpH wmIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683364966; x=1685956966; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GLpO1cNAvExQM61u5vjPwwxA/FBPBsVJoXa4mIUft1E=; b=T34kGS5+vFRwU5pUc8ke/n2QpDFKBlXcbruOma8NTEhYqw6UaO9iW0DZQMa4R8EbPi 5FSTGzt1Le+nXvTlZ2/pqw+JnrazjVaY/OqFMkiiwISezTXY0Pylbu3+E4JmPFx15dVo Vooq66iXPldi2vYy2tHvpikwbm2NRKAavF8jnqVV6c5bgCcPL4VSzNMzJR+z7CZrxjnb FfqZ1Rl4Ma/FiwkyOrlV9LmIxdY6L6i63S1uEZbghWXbeNc536SV9IVKocqBlJ/hhbiR yffS9dU9SqjSWms3D4+BO+IM09Vbp9R9nWQoWZnx5uJaFeR7ePRSXBV2KzWfV9BMYTXf Rgbg== X-Gm-Message-State: AC+VfDwss4+yMndR1rylyU9T9HIZ/v8JJtaq3hWhaZ4kTMGr5s6zICPs yl8dD69BVREDJfEul1IvSvfOtBEoUJw= X-Google-Smtp-Source: ACHHUZ4YGlhDVA/G8nFcqyfkJchpvKULBHgQSbbepe64cRADBKgbUVumUXB4emLnjIAScG5kyuRScA== X-Received: by 2002:a2e:3508:0:b0:299:bdc7:8ff2 with SMTP id z8-20020a2e3508000000b00299bdc78ff2mr1343247ljz.39.1683364966114; Sat, 06 May 2023 02:22:46 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id a5-20020a05651c010500b002ac9138a419sm261400ljb.80.2023.05.06.02.22.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 May 2023 02:22:45 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#63251: 28.2; vhdl-mode contribution Message-Id: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> Date: Sat, 6 May 2023 11:22:44 +0200 To: 63251@debbugs.gnu.org X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , Cyril Arnould X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Following bug#62508, I've taken a bit of a closer look at the compiler > regexp for ModelSim. I've modified it so that it can differentiate > between Errors, Warnings and Notes when highlighting. I also make use = of > Xilinx Vivado at work, for which I've added a new compiler entry: Sorry, but computer says no. The modified vhdl-compiler-alist value does = not match its declared type. You can easily check this by running `M-x customize-variable = vhdl-compiler-alist`; it will show the contents as a single big text = field and say (mismatch). If the value matches the type, it would have shown the value = structurally. Another check is to run `make -C test test-custom-opts`, which checks = the values of all defcustom variables in Emacs. In this case it seems to be the `(2 . 3)` values at the end of the error = message sublists. Remove them and the value matches the type. If those (2 . 3) are important, perhaps you want to change the type = instead but you would have to maintain compatibility somehow. I see = there is a lot of code dealing with changes to the type of that variable = in vhdl-mode.el. From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 08:53:34 2023 Received: (at 63251) by debbugs.gnu.org; 6 May 2023 12:53:34 +0000 Received: from localhost ([127.0.0.1]:59642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHPp-0007OS-Ji for submit@debbugs.gnu.org; Sat, 06 May 2023 08:53:34 -0400 Received: from mail-vi1eur05olkn2106.outbound.protection.outlook.com ([40.92.90.106]:35557 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHPl-0007OD-Ly for 63251@debbugs.gnu.org; Sat, 06 May 2023 08:53:31 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8GxanQy6aF3Q2N68/B8/DUd5WZydtlNsehDkC9B3YCzLr91VTVobq1bRtxF+7nsFiI1OTTMmjmL82j2eazj2KVxMWgUpDsFuv43ZdjCSWRI/io9ilZN79z4NKh0WTiQG/gtrkky04Qc53x8bNbmjetoELd5C+q/4Rc2P/fzmEY5HUBwz9rRINclYl0rnEAHzo9YdQR6AQApOWuTPLmWDKXlUl5Lo0IXAA9OjuEnAOpQ/U9SqEpCcxuFU94TrHUrJ0naJFnW28taRWG5LJ0zpUhy8Qt+5vOzybwUc3iHTBBXrESheUqhKxDhhhHqAxa3j0QsKg2sm2wbw62zVyFpuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUI8MaA8WIImuqewLVlQkSyXRq8aAZ0ISE0z232r/gQ=; b=lJtSKvZt52R4u9JWSz9vW7ujCI9oK1Rl7yssoUXvpTXktkILTOUIdXMOf+f+3fVJPa3P01bn3eD1h4QG7UBrQIvDYaJv4ql5q4FhD5PUTFFLG5gpssfBG0O64neFWZs4YPCaF2KFANyoq0VeKjRNOFEBXDcqTKvlmMr7AKoE6umMQiiv9Nh5xAG7w1/jrkFc61OoIvuZSAx40Ni/CJgjrCsCBUxA9yvbukUwpCqEnEaWLZis4VLEB3yEJR22mm8Oz+FkuKIqOVBiS+lQHDOJ5T2386dMcz6lPZfLoKT6wyHFgCVHxjA1lloS5uIidfnYxosDOGsFvQLuglgkEKbQqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rUI8MaA8WIImuqewLVlQkSyXRq8aAZ0ISE0z232r/gQ=; b=CWXh2rshgdZ6Il8mOEHwCvFGm3njDE2FnOBbRwsJLoFPU9C9rzJud05lWn1He5GsJaf7BgD5xW8YrUlMxn4d9k7V0ZV+tCp3xQJbcxVXyZvT5WaDzmxTM32af1jaYglLkw3CEzBuWjNXzkHeLHQVwHgEOQurWRXyQFW9dX709RTfeQGTTnt6o2sbgmTZdFW4miHkbKWX68Y3hG61WaSIzeah6Yk2mWtXIK1k/wdu3OKCdIs+0kTpCr+DvoHpVVgNJ2xZJHwWDikV+Rnvxu+RkoQyQWQsh+H9vAem5g7NereIIWzyIAbxDJdwXwcU2XXa5C44dngo/L+SVKZ7A81lQA== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by DU2PR10MB7908.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:49b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29; Sat, 6 May 2023 12:53:23 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.029; Sat, 6 May 2023 12:53:23 +0000 From: Cyril Arnould To: =?Windows-1252?Q?Mattias_Engdeg=E5rd?= , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0 Date: Sat, 6 May 2023 12:53:23 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> In-Reply-To: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [SrhmvkJE0F4pv0cuXANA+Sg+8xBWd5jH] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|DU2PR10MB7908:EE_ x-ms-office365-filtering-correlation-id: e5e98ca1-0f51-4401-c5dd-08db4e30e051 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3fFSunFZ4sdTU15ddcJ9xhtS/fYClAsMHA1pwJ+Av77t06l7lX7bwaX55sZGrhd9C9lWnLayPp1z4XDZ1x7WSa1fv5LzvvCClFpvDpk4kIk1eVp9dKZ1dtJ+MF+PLV703Z0DzNYXMD87NdeJ3X8VgBcwldypQvEtwiEc2NoSu6v0gWS3yD97lt+VareQCqRrhgguRgoo52SqfYy47e/7NfOONw/j8PGx+lST5SFIrsgq6By0fMAnBi10B20qFoAkydvfH0Yev5jheReg+Ka04HPbZ0bB/asYx1BGe43f+oPMT3MoStmbenqpphIAS5OwT64udq/ikPWDsLKRqokwrvUhESddGObgHQX4sKI/HjLfIx9Cz0zLet8527VHtUwnWHL8GAC469elwIBdv2/w6ZgvrIxiDGT7weDUgl4tsJ5y6gKOLTooPXQ3ui809vGfLHjHTSv0XdKcFb4sITwIiZlM7iviqO1R1V3IQM0vMi5nWlcK3dKZ3vJZIeMalkr1331/8WoQcxEDLpZWWwHJgwgXn4irlVW/IlyJmxFAdlqWx78yXqQGxU0upJspG8iH x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?JiwSuQR9Mxmeg5ul01i6jAz9Y8rrVcaw/mbdOpjJfVK6tSdgXuR+FxgB?= =?Windows-1252?Q?fpGUpEGoSMun6Cq7DBMx0Rko5DBlY9MCOrLHYVCEoWzjo/AKhSsQrV0d?= =?Windows-1252?Q?Si7wDcfFE/l8UDkkvp3jqlXPyfNyOqz9x5a4KfkoUKDGnOgz3TpxQNUU?= =?Windows-1252?Q?eefWLiFWWUSSUp54NhEbMR1QEM/R3FdZzTn/BKWA79OnwTmfSzsrKz9X?= =?Windows-1252?Q?LJYLnjukjFRlfIlyO/3/audvKZ4ZuI57rIffTN2MqEHStMZxCqfML9yv?= =?Windows-1252?Q?+ZhglW/qbphp+hsdjoF2/esSU+CBl5VbmXCel/zT8+SJskMY56jTHPu7?= =?Windows-1252?Q?fi/J9x6pYUjdcJHguM//8MFqW+DGtrg12CjE993oD2+6XtqABssuRTI6?= =?Windows-1252?Q?Nv4xQswKvoBY7IJEGzj6E2i/1lqY5GsbnRmySaW2R7sK4MQ75ioyv9y0?= =?Windows-1252?Q?voxT8qsFauKyy/ESl8JBXyE2A64pI2UnS77TY+qFyu8VzKCqxqxlRFEH?= =?Windows-1252?Q?eMCflFkaqPJBKE79p/pPAJJmU52j4T21Q2ROMxYZ2RbE/1UrvHBK4Jum?= =?Windows-1252?Q?PAm9IkKpAkLr02u/is3tylUbxnhS2aQqUAXF/Doi9MRxZdIbNPgrq6CV?= =?Windows-1252?Q?V2iKwVhKb9wWRu+Y/dakAf6Juk2So8Sp40Y0Ogs2WlxZ00FV6G1bsDeO?= =?Windows-1252?Q?ndloByXWpUjZ8zkGOeCQsKZ0ZTu6tv0hkbWAnVJ/Q54ZQe8Z21o6eWSv?= =?Windows-1252?Q?MhMUZHZ79gp8A4y47ZMdSRevXuUPxDpUT9xfyZNhO3rVI7KXJZBm/EPW?= =?Windows-1252?Q?DrT9NaHnWnJhu2yAMErCjCeqZuLwk5xltbKf5T6yHHdqHKsDjH6yHigH?= =?Windows-1252?Q?4DIZIQXhgpf4vMZLMsqkzeOqzj6SJ9oNQ3Ieqxd185HLlb7js+Q8E+DQ?= =?Windows-1252?Q?4YQJzu03xJXKySyCUWhJyjMrYX+x1gj2BFUlqeqXVhOEvzVk3XSJdYYD?= =?Windows-1252?Q?yAgFmTShnmLWazG5wzfj/3VGKicSeZQqt73/GrJe05mdml3k5rpudfeP?= =?Windows-1252?Q?dhEdZy2yjpP4ULfKKC8YB3rpOCvxNsVLr3d0kopkIowW6ufC8pZoqf59?= =?Windows-1252?Q?rA4CbJEQMqSCTbUTVZc+8v73263i7aGUzXmFyElaz2cpJnk76PSjqxQc?= =?Windows-1252?Q?WbveiMwd+6L4H1qj7zmkqkKgcNkgNVqI0pLBeFxV2NHZun94mhxoGbhE?= =?Windows-1252?Q?iKPXMfXsqzqw8scBDvf2gIhmVheue37FPyta7Y67a8PkgmF9ltdRTjci?= =?Windows-1252?Q?WV+NvR5lia6iAzeEDpdKGBdyfjenwZr6Npg4sWXCj87uOx7A?= Content-Type: multipart/alternative; boundary="_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: e5e98ca1-0f51-4401-c5dd-08db4e30e051 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2023 12:53:23.1580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR10MB7908 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Forgot to hit =ABReply to all=BB Oh, did not realize that. Yes, the (2 . 3) is important, it=92s the TYPE that determines whether the message is highlighted as an INFO, WARNING or ERROR. From compilation-error-regexp-alist: Each elt has the form (REGEXP FILE [LINE COLUMN TYPE HYPERLINK HIGHLIGHT...]). TYPE is 2 or nil for a real error or 1 for warning or 0 for info. TYPE can also be of the form (WARNING . INFO). In that case this will be equivalent to 1 if the WARNING=92th subexpression matched or else equivalent to 0 if the INFO=92th subexpression matched, or else equivalent to 2 if neither of them matched. See =91compilation-error-face=92, =91compilation-warning-face=92, =91compilation-info-face=92 and =91compilation-skip-threshold=92. I=92ll try to take a look into modifying the type of the vhdl-compiler-alist. Von: Mattias Engdeg=E5rd Gesendet: Samstag, 6. Mai 2023 11:22 An: 63251@debbugs.gnu.org Cc: Reto Zimmermann; Eli Zaretskii; Cyril Arnould Betreff: bug#63251: 28.2; vhdl-mode contribution > Following bug#62508, I've taken a bit of a closer look at the compiler > regexp for ModelSim. I've modified it so that it can differentiate > between Errors, Warnings and Notes when highlighting. I also make use of > Xilinx Vivado at work, for which I've added a new compiler entry: Sorry, but computer says no. The modified vhdl-compiler-alist value does no= t match its declared type. You can easily check this by running `M-x customize-variable vhdl-compiler-= alist`; it will show the contents as a single big text field and say (misma= tch). If the value matches the type, it would have shown the value structurally. Another check is to run `make -C test test-custom-opts`, which checks the v= alues of all defcustom variables in Emacs. In this case it seems to be the `(2 . 3)` values at the end of the error me= ssage sublists. Remove them and the value matches the type. If those (2 . 3) are important, perhaps you want to change the type instead= but you would have to maintain compatibility somehow. I see there is a lot= of code dealing with changes to the type of that variable in vhdl-mode.el. --_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Forgot to hit =ABReply to all=BB

 

Oh, did not realize that. Yes, the (2 . 3) is import= ant, it=92s the

TYPE that determines whether the message is highligh= ted as an

INFO, WARNING or ERROR. From compilation-error-regex= p-alist:

 

Each elt has the form (REGEXP FILE [LINE COLUMN TYPE= HYPERLINK

HIGHLIGHT...]).

 

TYPE is 2 or nil for a real error or 1 for warning o= r 0 for info.

TYPE can also be of the form (WARNING . INFO). = In that case this

will be equivalent to 1 if the WARNING=92th subexpre= ssion matched

or else equivalent to 0 if the INFO=92th subexpressi= on matched,

or else equivalent to 2 if neither of them matched.<= o:p>

See =91compilation-error-face=92, =91compilation-war= ning-face=92,

=91compilation-info-face=92 and =91compilation-skip-= threshold=92.

 

I=92ll try to take a look into modifying the type of= the

vhdl-compiler-alist.

 

 

Von: Mattias Engdeg=E5rd
Gesendet: Samstag, 6. Mai 2023 11:22
An: 63251@debbugs.gnu.org
Cc:
Reto Zimmermann; Eli Zaretskii; Cyril Arnou= ld
Betreff: bug#63251: 28.2; vhdl-mode contribution

 

> Following bug#62= 508, I've taken a bit of a closer look at the compiler
> regexp for ModelSim. I've modified it so that it can differentiate
> between Errors, Warnings and Notes when highlighting. I also make use = of
> Xilinx Vivado at work, for which I've added a new compiler entry:

Sorry, but computer says no. The modified vhdl-compiler-alist value does no= t match its declared type.

You can easily check this by running `M-x customize-variable vhdl-compiler-= alist`; it will show the contents as a single big text field and say (misma= tch).
If the value matches the type, it would have shown the value structurally.<= br>
Another check is to run `make -C test test-custom-opts`, which checks the v= alues of all defcustom variables in Emacs.

In this case it seems to be the `(2 . 3)` values at the end of the error me= ssage sublists. Remove them and the value matches the type.
If those (2 . 3) are important, perhaps you want to change the type instead= but you would have to maintain compatibility somehow. I see there is a lot= of code dealing with changes to the type of that variable in vhdl-mode.el.=



 

--_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 18:12:03 2023 Received: (at 63251) by debbugs.gnu.org; 6 May 2023 22:12:04 +0000 Received: from localhost ([127.0.0.1]:35918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQ8J-0001Qa-7G for submit@debbugs.gnu.org; Sat, 06 May 2023 18:12:03 -0400 Received: from mail-am6eur05olkn2025.outbound.protection.outlook.com ([40.92.91.25]:22240 helo=EUR05-AM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQ8D-0001Q0-9W for 63251@debbugs.gnu.org; Sat, 06 May 2023 18:12:01 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXvw/xDlCI05wvgluuzWdK4uohOEqPuPn9WbL/1X8oez83lFBLquZFWhlEhCUbjYiGFnEDSsi3EHDxcJKqQMnayd7omLGgnfota8isADvCORHhffyqW9sbnYTBdZBJ97/9R+z4ObqXJPXiYwpnSeTEJxGzjJeVteSlvRyAUS4CiLgJVvvGszM/6Bu297wKiAWWWIXWQBcI9ZfUkM6IDLTK4LppSgXaetbVxJe0+OE48trVH4aAYn4Q4OOeZ7y0CpS4AbW0S5aRM+squvl+VPiG+nq9g5zrRp1Y+8qY9kcBmUYuO+dIVENxBj7QGQD25Gs9XLtz7aGv+hfzBSAL7NQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ds9XYRhwDeTTY24VBBM2JGUiMlr7p/gOzAvWh/ee79A=; b=E+avJe7YVbFv5JIhsDR9N6Zhc14zNRw6XnMBt2x+PukpP+f8DusQJA+m1TUouNTQ9vLDHJDhqiUz7CKkj4EKidij1CLGdWPJQOqUFBR5pBF/g+6XFCoLRwQuRalizPaRkcZxBARoPRWMym+sWXNVMJdkO1Ac46AFNu9sAqOxyuF7cVaLej66n4t/oujyTVICiC5KD+ecXts2HZk5V1DvFQNhfJfise3Y2NqdohrXmYMYF2GR2jN67LUKalkM0rhMmM85gAu9XjLk3rsQdNwTp1s1+5XNVm7dGH2P9T3KMWAmiLjJypk7XYBVSY5SOcJPwRHs3AdAC9/ebxDxP1wRYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ds9XYRhwDeTTY24VBBM2JGUiMlr7p/gOzAvWh/ee79A=; b=A6YD4vTAi/+iLsMbzkKJUSJkQPtcDBSzA+nNb8wW6i/tWICj3PQn+hG6arrNg3AD9riC2O2AtieToWH0Fqz1zUNSTr3BE2Oefk7BKhQ972HErKXHdWUrZdmeO7JKmF3Eih1rx5RB9PMqVGctwvnNMyJBPv5tdv/WPyWGVw34LW3tTaNRvqur5p573kDJzFCPhtILcKfsMrEAsrCXALu8PCYIujx28cb1Eo1tI78/LsGwL4t2HQHGfZMslSpBveMXsu7bu4IvP+vEjQM11Obr+C8l3G5ZqVmLGOUr4j1XW/VClA/8NWbJiMA3/ZWN28pv8AWRvPx4C4Kmj5BF0GC09w== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by AS4PR10MB5989.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:51c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.28; Sat, 6 May 2023 22:11:51 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.029; Sat, 6 May 2023 22:11:51 +0000 From: Cyril Arnould To: =?Windows-1252?Q?Mattias_Engdeg=E5rd?= , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj78= Date: Sat, 6 May 2023 22:11:50 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> In-Reply-To: Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [5dQ3luS8OSYnsuJV/aAv0KJS3mFtQ8aW] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|AS4PR10MB5989:EE_ x-ms-office365-filtering-correlation-id: 53567e8b-196f-4ef8-5eb2-08db4e7ee487 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2ThVJe8mHKVmemTHpWqqqfU9DaQQ5nUuKOGKCSPE5XAoIO5x6jT1W0eFzfk4HpuCnhSg9Ny5lrKXxoB7qNbx/65DK09GaCvoAeV3NAWObGNoppKRcAHZ2RLU27FScywJCOQc6r5trSr4CRYU9rCoXu41LHSHXwaVl1BA30v6Bp97763UUjf//cJbiKkzefXL1oZdoi/OJJBFy8e4PAq3tFAmsHnHYvs7oS2Dzl+3gcsmIExp0LbwBVVpmhAkUaLb0yqcRIupcuJk19fZBVUiYngyQfCFSIVmWZsbsb46BT+0K70fZ1RywqYet/rTeGY+t4Yx2Mz/KXjjfZFZK/4icX6WjOK73VKKQlVugQxcWf496FwgFVshdHWf8GEeR4QY533p+Fn0A0EIXJuhg8c03bLvpE4T6vb/zKeJSkI6MzQwgOVgunApLZAvw4CozfmQXwQLx8X4R8zcnTGYVNRHFxVQe7m2R7d7AZ3abXsigattkWGdDmAztInB6rBYz9prryi/BetN0+X+J/+chInA9zpt7I+jbRS98dRkbvVovjoF5i24u5oGcrlZkXyMpIES x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?kE8vf/OXWw6xUZuK7oOTJwafhKw1jyA98dgYfZPWBEC5OvF9bk+F1M78?= =?Windows-1252?Q?kEsEpyY8jzW7gDY7Al7i5deUBC9fXeF/4Eyyu/3hNMnXTWswCLJW+T76?= =?Windows-1252?Q?UiiRfrIwUFMw09VWO0ks/nGCi3FfFH4ePpJqzeYQg6gkBdSRDgvCCNhD?= =?Windows-1252?Q?n8LI6A0slo3gN/CcmATccHBmU/TyGvHmwnIaiBtxcQI2S3pCBYMszAfF?= =?Windows-1252?Q?67GlV9/rerKliOuFGP3qrmP9ObFIE0eMPQlB+Yq2S4nbTFsp3nss94pS?= =?Windows-1252?Q?w7ISHGHxfg1bFwTR8s2WZfgSf8B1cLNAauuVsZcGvFIswcpXHKUtSNWU?= =?Windows-1252?Q?95yW0CaJg6PPAGV4+QyT01GsNAnH6lWhYSPo01KgEw4oFO6hkQYp9BQl?= =?Windows-1252?Q?jgxRQGgcFZxHO7dgwzGjyoAQycXbDDvzfEXEKjBgbpJqffOlIZ/hOvNR?= =?Windows-1252?Q?qo6MpfA9VBjZDbIc66nJowIbLeZgJsuD8QY3XfeUCXwSi6LRKuWxJ+ay?= =?Windows-1252?Q?WU4R3Xvl1Ss13yLywEpZ9y7wugRzGDGDqakD90wYA5M9hHf94ptLYJe8?= =?Windows-1252?Q?3arm3QF2qXBhOoez/g+yDobWfVA8XenQef5NO2cMNc2q6c7eJbjJHY3p?= =?Windows-1252?Q?qiHsJdxPKDMCk0OcrVgttjFb5CTzzUU5hYGneTaxQubJvRh6wRia4AeT?= =?Windows-1252?Q?tRD7cKmm/4rSqQ1zdrhRyrPR8gDDM20YVoT//hTFoMkGeTKMShUdYjsG?= =?Windows-1252?Q?kvS+uOjga++/DeBWFiUDnFm063zi9wedTm96TQdz+Qb6Jb+n5CdZnwyY?= =?Windows-1252?Q?j2Awe1vB8H3evgglW3AwfFaFk/Pyvtfs1J2QOKkoSdqZzESR/9vz0Elu?= =?Windows-1252?Q?LroKFqCebgq5fAG5rpRpetG+pUpM/te9a191ZThjwE0VG3ZYIiiuCUH+?= =?Windows-1252?Q?qMEathgzO5VYzBofzH5E1gUeKfj2vJg9ilIoRe4WEU3TvEHueJrKFdWS?= =?Windows-1252?Q?3z66kzMNOxbWBqy65tRWKYaVRraEaUMJcGOlPNix4IyUOB+KtISRBg76?= =?Windows-1252?Q?nWvBaG5eJivh7b01SHiNI8i/Y96F1T19E2jbF86cOsfzzQsyILC1gMOH?= =?Windows-1252?Q?HnWcCkWMDdrwS2dAjUOrNjEPNat/kO/UYY7/i5Xl9etx2/1kni7b0mxv?= =?Windows-1252?Q?lWpG3Vue5DaloeSgTbRa2uk6PJOBazm1gcPQa2bwAdDdjASDsNAJNR5z?= =?Windows-1252?Q?sMFSFwAGT6JFFkmhHqE0DNPGC+SUqUUIgNK6xgRiu6rvY73FnZe0nRW2?= =?Windows-1252?Q?mqDXoItU1cNhtOXVNX11KbigcC26i2ACdHuuFR4zvJagH6wU?= Content-Type: multipart/mixed; boundary="_004_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 53567e8b-196f-4ef8-5eb2-08db4e7ee487 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2023 22:11:50.9765 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5989 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_004_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_ Content-Type: multipart/alternative; boundary="_000_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_" --_000_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Ok, I hope the attached patch takes care of things. This time it's based on the emacs-29 branch. - I've updated the docstring with a description of the TYPE, pretty much copied from compile.el. Feel free to change it of course. - I've added TYPE to the vhdl-compiler definition with the appropriate choices for Info/Warning/Error and the dotted pair. I'm not sure if sexp was the correct choice for the dotted pair, is there a better alternative? At any rate, it seems to work. - All other compiler entries now have TYPE nil, i.e. an error. - I added another entry to the backwards compatibility code, all it took was a slight modification of the entry before that. I've tested it by saving a custom vhdl-compiler-alist and then updating the vhdl-mode.el, it automatically inserted nil into the customization without touching the other values. - Unrelated to the changes above, I've also updated the Xilinx Vivado compiler entry's library directory, I got an error message that it must end with '/'. Since this introduces changes in the vhdl-compiler type, I guess it would be appropriate to increment the vhdl-version number? Von: Cyril Arnould Gesendet: Samstag, 6. Mai 2023 14:53 An: Mattias Engdeg=E5rd; 63251@debbugs.= gnu.org Cc: Reto Zimmermann; Eli Zaretskii Betreff: AW: bug#63251: 28.2; vhdl-mode contribution Forgot to hit =ABReply to all=BB Oh, did not realize that. Yes, the (2 . 3) is important, it=92s the TYPE that determines whether the message is highlighted as an INFO, WARNING or ERROR. From compilation-error-regexp-alist: Each elt has the form (REGEXP FILE [LINE COLUMN TYPE HYPERLINK HIGHLIGHT...]). TYPE is 2 or nil for a real error or 1 for warning or 0 for info. TYPE can also be of the form (WARNING . INFO). In that case this will be equivalent to 1 if the WARNING=92th subexpression matched or else equivalent to 0 if the INFO=92th subexpression matched, or else equivalent to 2 if neither of them matched. See =91compilation-error-face=92, =91compilation-warning-face=92, =91compilation-info-face=92 and =91compilation-skip-threshold=92. I=92ll try to take a look into modifying the type of the vhdl-compiler-alist. Von: Mattias Engdeg=E5rd Gesendet: Samstag, 6. Mai 2023 11:22 An: 63251@debbugs.gnu.org Cc: Reto Zimmermann; Eli Zaretskii; Cyril Arnould Betreff: bug#63251: 28.2; vhdl-mode contribution > Following bug#62508, I've taken a bit of a closer look at the compiler > regexp for ModelSim. I've modified it so that it can differentiate > between Errors, Warnings and Notes when highlighting. I also make use of > Xilinx Vivado at work, for which I've added a new compiler entry: Sorry, but computer says no. The modified vhdl-compiler-alist value does no= t match its declared type. You can easily check this by running `M-x customize-variable vhdl-compiler-= alist`; it will show the contents as a single big text field and say (misma= tch). If the value matches the type, it would have shown the value structurally. Another check is to run `make -C test test-custom-opts`, which checks the v= alues of all defcustom variables in Emacs. In this case it seems to be the `(2 . 3)` values at the end of the error me= ssage sublists. Remove them and the value matches the type. If those (2 . 3) are important, perhaps you want to change the type instead= but you would have to maintain compatibility somehow. I see there is a lot= of code dealing with changes to the type of that variable in vhdl-mode.el. --_000_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Ok, I hope the attached patch takes care of things. = This time

it's based on the emacs-29 branch.

 

- I've updated the docstring with a description of t= he TYPE,

  pretty much copied from compile.el. Feel free= to change it of

  course.

 

- I've added TYPE to the vhdl-compiler definition wi= th the

  appropriate choices for Info/Warning/Error an= d the dotted

  pair. I'm not sure if sexp was the correct ch= oice for the

  dotted pair, is there a better alternative? A= t any rate, it

  seems to work.

 

- All other compiler entries now have TYPE nil, i.e.= an error.

 

- I added another entry to the backwards compatibili= ty code, all

  it took was a slight modification of the entr= y before

  that. I've tested it by saving a custom vhdl-= compiler-alist and

  then updating the vhdl-mode.el, it automatica= lly inserted nil

  into the customization without touching the o= ther values.

 

- Unrelated to the changes above, I've also updated = the Xilinx

  Vivado compiler entry's library directory, I = got an error

  message that it must end with '/'.

 

Since this introduces changes in the vhdl-compiler t= ype, I guess

it would be appropriate to increment the vhdl-versio= n number?

 

 

Von: Cyril Arnould
Gesendet: Samstag, 6. Mai 2023 14:53
An: Mattias Engdeg=E5= rd; 63251@debbugs.gnu.org
Cc: Reto Zimmermann; Eli Zaretskii
Betreff: AW: bug#63251: 28.2; vhdl-mode contribution

 

Forgot to hit =ABReply to all=BB

 

Oh, did not realize that. Yes, the (2 . 3) is import= ant, it=92s the

TYPE that determines whether the message is highligh= ted as an

INFO, WARNING or ERROR. From compilation-error-regex= p-alist:

 

Each elt has the form (REGEXP FILE [LINE COLUMN TYPE= HYPERLINK

HIGHLIGHT...]).

 

TYPE is 2 or nil for a real error or 1 for warning o= r 0 for info.

TYPE can also be of the form (WARNING . INFO). = In that case this

will be equivalent to 1 if the WARNING=92th subexpre= ssion matched

or else equivalent to 0 if the INFO=92th subexpressi= on matched,

or else equivalent to 2 if neither of them matched.<= o:p>

See =91compilation-error-face=92, =91compilation-war= ning-face=92,

=91compilation-info-face=92 and =91compilation-skip-= threshold=92.

 

I=92ll try to take a look into modifying the type of= the

vhdl-compiler-alist.

 

 

Von: Mattias Engdeg=E5rd
Gesendet: Samstag, 6. Mai 2023 11:22
An: 63251@debbugs.gnu.org
Cc:
Reto Zimmermann; Eli Zaretskii; Cyril Arnou= ld
Betreff: bug#63251: 28.2; vhdl-mode contribution

 

> Following bug#62= 508, I've taken a bit of a closer look at the compiler
> regexp for ModelSim. I've modified it so that it can differentiate
> between Errors, Warnings and Notes when highlighting. I also make use = of
> Xilinx Vivado at work, for which I've added a new compiler entry:

Sorry, but computer says no. The modified vhdl-compiler-alist value does no= t match its declared type.

You can easily check this by running `M-x customize-variable vhdl-compiler-= alist`; it will show the contents as a single big text field and say (misma= tch).
If the value matches the type, it would have shown the value structurally.<= br>
Another check is to run `make -C test test-custom-opts`, which checks the v= alues of all defcustom variables in Emacs.

In this case it seems to be the `(2 . 3)` values at the end of the error me= ssage sublists. Remove them and the value matches the type.
If those (2 . 3) are important, perhaps you want to change the type instead= but you would have to maintain compatibility somehow. I see there is a lot= of code dealing with changes to the type of that variable in vhdl-mode.el.=


 

 

--_000_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_-- --_004_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_ Content-Type: application/octet-stream; name="fix-vhdl-compiler-customization.patch" Content-Description: fix-vhdl-compiler-customization.patch Content-Disposition: attachment; filename="fix-vhdl-compiler-customization.patch"; size=11658; creation-date="Sat, 06 May 2023 21:59:11 GMT"; modification-date="Sat, 06 May 2023 21:59:11 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCAiYS9saXNwL3Byb2dtb2Rlcy92aGRsLW1vZGUuZWwiICJiL2xpc3AvcHJvZ21v ZGVzL3ZoZGwtbW9kZS5lbCIKaW5kZXggZWUwZWM2M2I2YmMuLjZjOTUxZWU4YWYzIDEwMDY0NAot LS0gImEvbGlzcC9wcm9nbW9kZXMvdmhkbC1tb2RlLmVsIgorKysgImIvbGlzcC9wcm9nbW9kZXMv dmhkbC1tb2RlLmVsIgpAQCAtMjI5LDIwICsyMjksMjAgQEAgdmhkbC1jb21waWxlci1hbGlzdAog ICAgIDs7IFtFcnJvcl0gQXNzaWdubWVudCBlcnJvcjogdmFyaWFibGUgaXMgaWxsZWdhbCB0YXJn ZXQgb2Ygc2lnbmFsIGFzc2lnbm1lbnQKICAgICAoIkFEVmFuY2UgTVMiICJ2YWNvbSIgIi13b3Jr IFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAidmFsaWIgXFwxOyB2YW1hcCBcXDIgXFwx IiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiYWRtcyIKLSAgICAgKCJeXFxzLStcXChbMC05XStc XCk6XFxzLSsiIG5pbCAxIG5pbCkgKCJeQ29tcGlsaW5nIGZpbGUgXFwoLitcXCkiIDEpCisgICAg ICgiXlxccy0rXFwoWzAtOV0rXFwpOlxccy0rIiBuaWwgMSBuaWwgbmlsKSAoIl5Db21waWxpbmcg ZmlsZSBcXCguK1xcKSIgMSkKICAgICAgKCJFTlRJL1xcMS52aWYiICJBUkNIL1xcMS1cXDIudmlm IiAiQ09ORi9cXDEudmlmIgogICAgICAgIlBBQ0svXFwxLnZpZiIgIkJPRFkvXFwxLnZpZiIgdXBj YXNlKSkKICAgICA7OyBBbGRlYwogICAgIDs7IENPTVA5NiBFUlJPUiBDT01QOTZfMDAxODogIklk ZW50aWZpZXIgZXhwZWN0ZWQuIiAidGVzdC52aGQiIDY2IDMKICAgICAoIkFsZGVjIiAidmNvbSIg Ii13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAidmxpYiBcXDE7IHZtYXAgXFwy IFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgImFsZGVjIgotICAgICAoIl4uKiBFUlJPUiBb XjpdKzogXCIuKlwiIFwiXFwoW14gXHRcbl0rXFwpXCIgXFwoWzAtOV0rXFwpIFxcKFswLTldK1xc KSIgMSAyIDMpICgiIiAwKQorICAgICAoIl4uKiBFUlJPUiBbXjpdKzogXCIuKlwiIFwiXFwoW14g XHRcbl0rXFwpXCIgXFwoWzAtOV0rXFwpIFxcKFswLTldK1xcKSIgMSAyIDMgbmlsKSAoIiIgMCkK ICAgICAgbmlsKQogICAgIDs7IENhZGVuY2UgTGVhcGZyb2c6IGN2IC1maWxlIHRlc3QudmhkCiAg ICAgOzsgZHVsdXRoOiAqRSw0MzAgKHRlc3QudmhkLDEzKTogaWRlbnRpZmllciAoUE9TSVRJVikg aXMgbm90IGRlY2xhcmVkCiAgICAgKCJDYWRlbmNlIExlYXBmcm9nIiAiY3YiICItd29yayBcXDEg LWZpbGUiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8i ICJNYWtlZmlsZSIgImxlYXBmcm9nIgotICAgICAoIl5kdWx1dGg6IFxcKkUsWzAtOV0rIChcXChb XiBcdFxuXStcXCksXFwoWzAtOV0rXFwpKToiIDEgMiBuaWwpICgiIiAwKQorICAgICAoIl5kdWx1 dGg6IFxcKkUsWzAtOV0rIChcXChbXiBcdFxuXStcXCksXFwoWzAtOV0rXFwpKToiIDEgMiBuaWwg bmlsKSAoIiIgMCkKICAgICAgKCJcXDEvZW50aXR5IiAiXFwyL1xcMSIgIlxcMS9jb25maWd1cmF0 aW9uIgogICAgICAgIlxcMS9wYWNrYWdlIiAiXFwxL2JvZHkiIGRvd25jYXNlKSkKICAgICA7OyBD YWRlbmNlIEFmZmlybWEgTkMgdmhkbDogbmN2aGRsIHRlc3QudmhkCkBAIC0yNTAsNyArMjUwLDcg QEAgdmhkbC1jb21waWxlci1hbGlzdAogICAgIDs7IChQTExfNDAwWF9UT1ApIGlzIG5vdCBkZWNs YXJlZCBbMTAuM10uCiAgICAgKCJDYWRlbmNlIE5DIiAibmN2aGRsIiAiLXdvcmsgXFwxIiAibWFr ZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUi ICJuY3ZoZGwiCi0gICAgICgiXm5jdmhkbF9wOiBcXCpFLFxcdysgKFxcKFteIFx0XG5dK1xcKSxc XChbMC05XStcXCl8XFwoWzAtOV0rXFwpKToiIDEgMiAzKSAoIiIgMCkKKyAgICAgKCJebmN2aGRs X3A6IFxcKkUsXFx3KyAoXFwoW14gXHRcbl0rXFwpLFxcKFswLTldK1xcKXxcXChbMC05XStcXCkp OiIgMSAyIDMgbmlsKSAoIiIgMCkKICAgICAgKCJcXDEvZW50aXR5L3BjLmRiIiAiXFwyL1xcMS9w Yy5kYiIgIlxcMS9jb25maWd1cmF0aW9uL3BjLmRiIgogICAgICAgIlxcMS9wYWNrYWdlL3BjLmRi IiAiXFwxL2JvZHkvcGMuZGIiIGRvd25jYXNlKSkKICAgICA7OyBnaGRsIHZoZGwKQEAgLTI1OCwy MSArMjU4LDIxIEBAIHZoZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyBiYWRfY291bnRlci52aGRs OjEzOjE0OiBvcGVyYXRvciAiPSIgaXMgb3ZlcmxvYWRlZAogICAgICgiR0hETCIgImdoZGwiICIt aSAtLXdvcmtkaXI9XFwxIC0taWVlZT1zeW5vcHN5cyAtZmV4cGxpY2l0ICIgIm1ha2UiICItZiBc XDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiZ2hkbCIK LSAgICAgKCJeZ2hkbF9wOiBcXCpFLFxcdysgKFxcKFteIFx0XG5dK1xcKSxcXChbMC05XStcXCl8 XFwoWzAtOV0rXFwpKToiIDEgMiAzKSAoIiIgMCkKKyAgICAgKCJeZ2hkbF9wOiBcXCpFLFxcdysg KFxcKFteIFx0XG5dK1xcKSxcXChbMC05XStcXCl8XFwoWzAtOV0rXFwpKToiIDEgMiAzIG5pbCkg KCIiIDApCiAgICAgICgiXFwxL2VudGl0eSIgIlxcMi9cXDEiICJcXDEvY29uZmlndXJhdGlvbiIK ICAgICAgICJcXDEvcGFja2FnZSIgIlxcMS9ib2R5IiBkb3duY2FzZSkpCiAgICAgOzsgSUJNIENv bXBpbGVyCiAgICAgOzsgMDAgQ09BQ0hETCogfCBbQ0NIREwtMV06IEZpbGU6IGFkZGVyLnZoZCwg bGluZS5jb2x1bW46IDEyMC42CiAgICAgKCJJQk0gQ29tcGlsZXIiICJnMnR2YyIgIi1zcmMiICJw cmVjb21wIiAiXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmls ZSIgImlibSIKLSAgICAgKCJeWzAtOV0rIENPQUNIREwuKjogRmlsZTogXFwoW14gXHRcbl0rXFwp LCAqbGluZS5jb2x1bW46IFxcKFswLTldK1xcKS5cXChbMC05XStcXCkiIDEgMiAzKSAoIiAiIDAp CisgICAgICgiXlswLTldKyBDT0FDSERMLio6IEZpbGU6IFxcKFteIFx0XG5dK1xcKSwgKmxpbmUu Y29sdW1uOiBcXChbMC05XStcXCkuXFwoWzAtOV0rXFwpIiAxIDIgMyBuaWwpICgiICIgMCkKICAg ICAgbmlsKQogICAgIDs7IElrb3MgVm95YWdlcjogYW5hbHl6ZSB0ZXN0LnZoZAogICAgIDs7IGFu YWx5emUgdGVzdC52aGQKICAgICA7OyBFIEw0L0M1OiAgICAgICAgdGhpcyBsaWJyYXJ5IHVuaXQg aXMgaW5hY2Nlc3NpYmxlCiAgICAgKCJJa29zIiAiYW5hbHl6ZSIgIi1sIFxcMSIgIm1ha2UiICIt ZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiaWtv cyIKLSAgICAgKCJeRSBMXFwoWzAtOV0rXFwpL0NcXChbMC05XStcXCk6IiBuaWwgMSAyKQorICAg ICAoIl5FIExcXChbMC05XStcXCkvQ1xcKFswLTldK1xcKToiIG5pbCAxIDIgbmlsKQogICAgICAo Il5hbmFseXplICtcXCguKyArXFwpKlxcKC4rXFwpJCIgMikKICAgICAgbmlsKQogICAgIDs7IE1v ZGVsU2ltLCBNb2RlbCBUZWNobm9sb2d5OiB2Y29tIHRlc3QudmhkCkBAIC0yOTQsNyArMjk0LDcg QEAgdmhkbC1jb21waWxlci1hbGlzdAogICAgIDs7IHRlc3QudmhkOjM0OiBlcnJvciBtZXNzYWdl CiAgICAgKCJMRURBIFByb1ZIREwiICJwcm92aGRsIiAiLXcgXFwxIC1mIiAibWFrZSIgIi1mIFxc MSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJwcm92aGRs IgotICAgICAoIl5cXChbXiBcdFxuOl0rXFwpOlxcKFswLTldK1xcKTogIiAxIDIgbmlsKSAoIiIg MCkKKyAgICAgKCJeXFwoW14gXHRcbjpdK1xcKTpcXChbMC05XStcXCk6ICIgMSAyIG5pbCBuaWwp ICgiIiAwKQogICAgICAoIkVOVEkvXFwxLnZpZiIgIkFSQ0gvXFwxLVxcMi52aWYiICJDT05GL1xc MS52aWYiCiAgICAgICAiUEFDSy9cXDEudmlmIiAiQk9EWS9CT0RZLVxcMS52aWYiIHVwY2FzZSkp CiAgICAgOzsgUXVhcnR1cyBjb21waWxlcgpAQCAtMzA1LDE0ICszMDUsMTQgQEAgdmhkbC1jb21w aWxlci1hbGlzdAogICAgIDs7IFdhcm5pbmc6IFZIREwgUHJvY2VzcyBTdGF0ZW1lbnQgd2Fybmlu ZyBhdCBkdmkyc2RpX3RzdC52aGQoMTcyKTogLi4uCiAgICAgKCJRdWFydHVzIiAibWFrZSIgIi13 b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3Jr LyIgIk1ha2VmaWxlIiAicXVhcnR1cyIKLSAgICAgKCJeXFwoRXJyb3JcXHxXYXJuaW5nXFwpOiAu KiBcXChbXiBcdFxuXStcXCkoXFwoWzAtOV0rXFwpKSIgMiAzIG5pbCkgKCIiIDApCisgICAgICgi XlxcKEVycm9yXFx8V2FybmluZ1xcKTogLiogXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSki IDIgMyBuaWwgbmlsKSAoIiIgMCkKICAgICAgbmlsKQogICAgIDs7IFF1aWNrSERMLCBNZW50b3Ig R3JhcGhpY3M6IHF2aGNvbSB0ZXN0LnZoZAogICAgIDs7IEVSUk9SOiB0ZXN0LnZoZCgyNCk6IG5l YXIgImRuZCI6IGV4cGVjdGluZzogRU5ECiAgICAgOzsgV0FSTklOR1s0XTogdGVzdC52aGQoMzAp OiBBIHNwYWNlIGlzIHJlcXVpcmVkIGJldHdlZW4gLi4uCiAgICAgKCJRdWlja0hETCIgInF2aGNv bSIgIi13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8i ICJ3b3JrLyIgIk1ha2VmaWxlIiAicXVpY2toZGwiCi0gICAgICgiXlxcKEVSUk9SXFx8V0FSTklO R1xcKVteOl0qOiBcXChbXiBcdFxuXStcXCkoXFwoWzAtOV0rXFwpKToiIDIgMyBuaWwpICgiIiAw KQorICAgICAoIl5cXChFUlJPUlxcfFdBUk5JTkdcXClbXjpdKjogXFwoW14gXHRcbl0rXFwpKFxc KFswLTldK1xcKSk6IiAyIDMgbmlsIG5pbCkgKCIiIDApCiAgICAgICgiXFwxL19wcmltYXJ5LmRh dCIgIlxcMi9cXDEuZGF0IiAiXFwxL19wcmltYXJ5LmRhdCIKICAgICAgICJcXDEvX3ByaW1hcnku ZGF0IiAiXFwxL2JvZHkuZGF0IiBkb3duY2FzZSkpCiAgICAgOzsgU2F2YW50OiBzY3JhbSAtcHVi bGlzaC1jYyB0ZXN0LnZoZApAQCAtMzI3LDM5ICszMjcsMzkgQEAgdmhkbC1jb21waWxlci1hbGlz dAogICAgIDs7IEVycm9yOiBDU1ZIREwwMDAyOiB0ZXN0LnZoZDogKGxpbmUgOTcpOiBJbnZhbGlk IHByZWZpeAogICAgICgiU2ltaWxpIiAidmhkbHAiICItd29yayBcXDEiICJtYWtlIiAiLWYgXFwx IgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInNpbWlsaSIK LSAgICAgKCJeXFwoRXJyb3JcXHxXYXJuaW5nXFwpOiBcXHcrOiBcXChbXiBcdFxuXStcXCk6IChs aW5lIFxcKFswLTldK1xcKSk6ICIgMiAzIG5pbCkgKCIiIDApCisgICAgICgiXlxcKEVycm9yXFx8 V2FybmluZ1xcKTogXFx3KzogXFwoW14gXHRcbl0rXFwpOiAobGluZSBcXChbMC05XStcXCkpOiAi IDIgMyBuaWwgbmlsKSAoIiIgMCkKICAgICAgKCJcXDEvcHJpbS52YXIiICJcXDIvX1xcMS52YXIi ICJcXDEvcHJpbS52YXIiCiAgICAgICAiXFwxL3ByaW0udmFyIiAiXFwxL19ib2R5LnZhciIgZG93 bmNhc2UpKQogICAgIDs7IFNwZWVkd2F2ZSAoSW5ub3ZlZGEpOiBhbmFseXplIC1saWJmaWxlIHZz c2xpYi5pbmkgLXNyYyB0ZXN0LnZoZAogICAgIDs7ICAgICBFUlJPUlsxMV06OkZpbGUgdGVzdC52 aGQgTGluZSAxMDA6IFVzZSBvZiB1bmRlY2xhcmVkIGlkZW50aWZpZXIKICAgICAoIlNwZWVkd2F2 ZSIgImFuYWx5emUiICItbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMiICJtYWtlIiAiLWYgXFwxIgog ICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInNwZWVkd2F2ZSIK LSAgICAgKCJeICpFUlJPUlxcW1swLTldK106OkZpbGUgXFwoW14gXHRcbl0rXFwpIExpbmUgXFwo WzAtOV0rXFwpOiIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXiAqRVJST1JcXFtbMC05XStdOjpG aWxlIFxcKFteIFx0XG5dK1xcKSBMaW5lIFxcKFswLTldK1xcKToiIDEgMiBuaWwgbmlsKSAoIiIg MCkKICAgICAgbmlsKQogICAgIDs7IFN5bm9wc3lzLCBWSERMIEFuYWx5emVyIChzaW0pOiB2aGRs YW4gLW5jIHRlc3QudmhkCiAgICAgOzsgKipFcnJvcjogdmhkbGFuLDcwMyB0ZXN0LnZoZCgyMik6 IE9USEVSUyBpcyBub3QgbGVnYWwgaW4gdGhpcyBjb250ZXh0LgogICAgICgiU3lub3BzeXMiICJ2 aGRsYW4iICItbmMgLXdvcmsgXFwxIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBc XDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJzeW5vcHN5cyIKLSAgICAgKCJeXFwqXFwqRXJy b3I6IHZoZGxhbixbMC05XSsgXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSk6IiAxIDIgbmls KSAoIiIgMCkKKyAgICAgKCJeXFwqXFwqRXJyb3I6IHZoZGxhbixbMC05XSsgXFwoW14gXHRcbl0r XFwpKFxcKFswLTldK1xcKSk6IiAxIDIgbmlsIG5pbCkgKCIiIDApCiAgICAgICgiXFwxLnNpbSIg IlxcMl9fXFwxLnNpbSIgIlxcMS5zaW0iICJcXDEuc2ltIiAiXFwxX18uc2ltIiB1cGNhc2UpKQog ICAgIDs7IFN5bm9wc3lzLCBWSERMIEFuYWx5emVyIChzeW4pOiB2aGRsYW4gLW5jIC1zcGMgdGVz dC52aGQKICAgICA7OyAqKkVycm9yOiB2aGRsYW4sNzAzIHRlc3QudmhkKDIyKTogT1RIRVJTIGlz IG5vdCBsZWdhbCBpbiB0aGlzIGNvbnRleHQuCiAgICAgKCJTeW5vcHN5cyBEZXNpZ24gQ29tcGls ZXIiICJ2aGRsYW4iICItbmMgLXNwYyAtd29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBu aWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInN5bm9wc3lzX2RjIgotICAg ICAoIl5cXCpcXCpFcnJvcjogdmhkbGFuLFswLTldKyBcXChbXiBcdFxuXStcXCkoXFwoWzAtOV0r XFwpKToiIDEgMiBuaWwpICgiIiAwKQorICAgICAoIl5cXCpcXCpFcnJvcjogdmhkbGFuLFswLTld KyBcXChbXiBcdFxuXStcXCkoXFwoWzAtOV0rXFwpKToiIDEgMiBuaWwgbmlsKSAoIiIgMCkKICAg ICAgKCJcXDEuc3luIiAiXFwyX19cXDEuc3luIiAiXFwxLnN5biIgIlxcMS5zeW4iICJcXDFfXy5z eW4iIHVwY2FzZSkpCiAgICAgOzsgU3lucGxpZnk6CiAgICAgOzsgQFc6InRlc3QudmhkIjo1Nzo4 OjU3Ojl8T3B0aW1pemluZyByZWdpc3RlciBiaXQgY291bnRfeCg1KSB0byBhIGNvbnN0YW50IDAK ICAgICAoIlN5bnBsaWZ5IiAibi9hIiAibi9hIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJt a2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJzeW5wbGlmeSIKLSAgICAgKCJeQFtF V05dOlwiXFwoW14gXHRcbl0rXFwpXCI6XFwoWzAtOV0rXFwpOlxcKFswLTldK1xcKToiIDEgMiAz KSAoIiIgMCkKKyAgICAgKCJeQFtFV05dOlwiXFwoW14gXHRcbl0rXFwpXCI6XFwoWzAtOV0rXFwp OlxcKFswLTldK1xcKToiIDEgMiAzIG5pbCkgKCIiIDApCiAgICAgIG5pbCkKICAgICA7OyBWYW50 YWdlOiBhbmFseXplIC1saWJmaWxlIHZzc2xpYi5pbmkgLXNyYyB0ZXN0LnZoZAogICAgIDs7ICAg ICBDb21waWxpbmcgInRlc3QudmhkIiBsaW5lIDEuLi4KICAgICA7OyAqKkVycm9yOiBMSU5FIDQ5 ICoqKiBObyBhZ2dyZWdhdGUgdmFsdWUgaXMgdmFsaWQgaW4gdGhpcyBjb250ZXh0LgogICAgICgi VmFudGFnZSIgImFuYWx5emUiICItbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMiICJtYWtlIiAiLWYg XFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInZhbnRh Z2UiCi0gICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoiIG5p bCAxIG5pbCkKKyAgICAgKCJeXFwqXFwqRXJyb3I6IExJTkUgXFwoWzAtOV0rXFwpIFxcKlxcKlxc KiIgbmlsIDEgbmlsIG5pbCkKICAgICAgKCJeICpDb21waWxpbmcgXCJcXCguK1xcKVwiICIgMSkK ICAgICAgbmlsKQogICAgIDs7IFZlcmlCZXN0OiB2YyB2aGRsIHRlc3QudmhkCkBAIC0zNjksMjYg KzM2OSwyNiBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgICAgOzsgW0Vycm9yXSBOYW1lIEJJVEEg aXMgdW5rbm93bgogICAgICgiVmVyaUJlc3QiICJ2YyIgInZoZGwiICJtYWtlIiAiLWYgXFwxIgog ICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInZlcmliZXN0Igot ICAgICAoIl4gK1xcKFswLTldK1xcKTogK1teIF0iIG5pbCAxIG5pbCkgKCIiIDApCisgICAgICgi XiArXFwoWzAtOV0rXFwpOiArW14gXSIgbmlsIDEgbmlsIG5pbCkgKCIiIDApCiAgICAgIG5pbCkK ICAgICA7OyBWaWV3bG9naWM6IGFuYWx5emUgLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIHRlc3Qu dmhkCiAgICAgOzsgICAgIENvbXBpbGluZyAidGVzdC52aGQiIGxpbmUgMS4uLgogICAgIDs7ICoq RXJyb3I6IExJTkUgNDkgKioqIE5vIGFnZ3JlZ2F0ZSB2YWx1ZSBpcyB2YWxpZCBpbiB0aGlzIGNv bnRleHQuCiAgICAgKCJWaWV3bG9naWMiICJhbmFseXplIiAiLWxpYmZpbGUgdnNzbGliLmluaSAt c3JjIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAi TWFrZWZpbGUiICJ2aWV3bG9naWMiCi0gICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTld K1xcKSBcXCpcXCpcXCoiIG5pbCAxIG5pbCkKKyAgICAgKCJeXFwqXFwqRXJyb3I6IExJTkUgXFwo WzAtOV0rXFwpIFxcKlxcKlxcKiIgbmlsIDEgbmlsIG5pbCkKICAgICAgKCJeICpDb21waWxpbmcg XCJcXCguK1xcKVwiICIgMSkKICAgICAgbmlsKQogICAgIDs7IFhpbGlueCBYU1Q6CiAgICAgOzsg RVJST1I6SERMUGFyc2VyczoxNjQgLSAidGVzdC52aGQiIExpbmUgMy4gcGFyc2UgZXJyb3IKICAg ICAoIlhpbGlueCBYU1QiICJ4ZmxvdyIgIiIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtk aXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAieGlsaW54IgotICAgICAoIl5FUlJPUjpI RExQYXJzZXJzOlswLTldKyAtIFwiXFwoW14gXHRcbl0rXFwpXCIgTGluZSBcXChbMC05XStcXClc XC4iIDEgMiBuaWwpICgiIiAwKQorICAgICAoIl5FUlJPUjpIRExQYXJzZXJzOlswLTldKyAtIFwi XFwoW14gXHRcbl0rXFwpXCIgTGluZSBcXChbMC05XStcXClcXC4iIDEgMiBuaWwgbmlsKSAoIiIg MCkKICAgICAgbmlsKQogICAgIDs7IFhpbGlueCBWaXZhZG86CiAgICAgOzsgRVJST1I6IFtWUkZD IDEwLTE0MTJdIHN5bnRheCBlcnJvciBuZWFyIG9faWRsZSBbdGVzdC52aGQ6MjNdCiAgICAgKCJY aWxpbnggVml2YWRvIiAieHZoZGwiICIiICJtYWtlIiAiLWYgXFwxIgotICAgICBuaWwgIm1rZGly IFxcMSIgIi4vIiAid29yayIgIk1ha2VmaWxlIiAidml2YWRvIgorICAgICBuaWwgIm1rZGlyIFxc MSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInZpdmFkbyIKICAgICAgKCJeXFwoPzpcXCg/MTpF UlJPUlxcKVxcfFxcKD8yOldBUk5JTkdcXClcXHxcXCg/MzpJTkZPXFwpXFwpOiBcXCguK1xcKSBc XFtcXCg/NDpbXiBcdFxuXStcXCk6XFwoPzU6WzAtOV0rXFwpXFxdIiA0IDUgbmlsICgyIC4gMykp ICgiIiAwKQogICAgICAoIlxcMS9lbnRpdHkiICJcXDIvXFwxIiAiXFwxL2NvbmZpZ3VyYXRpb24i CiAgICAgICAiXFwxL3BhY2thZ2UiICJcXDEvYm9keSIgZG93bmNhc2UpKQpAQCAtNDE0LDYgKzQx NCwxMyBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgIEZpbGUgc3ViZXhwIGluZGV4OiBpbmRleCBv ZiBzdWJleHByZXNzaW9uIHRoYXQgbWF0Y2hlcyB0aGUgZmlsZSBuYW1lCiAgIExpbmUgc3ViZXhw IGluZGV4OiBpbmRleCBvZiBzdWJleHByZXNzaW9uIHRoYXQgbWF0Y2hlcyB0aGUgbGluZSBudW1i ZXIKICAgQ29sdW1uIHN1YmV4cCBpZHg6IGluZGV4IG9mIHN1YmV4cHJlc3Npb24gdGhhdCBtYXRj aGVzIHRoZSBjb2x1bW4gbnVtYmVyCisgIFR5cGUgc3ViZXhwICAgICAgOiBtZXNzYWdlIHR5cGUs IGNhbiBiZSAyIG9yIG5pbCBmb3IgYSByZWFsIGVycm9yLCAxIGZvcgorICAgICAgICAgICAgICAg ICAgICAgd2FybmluZyBvciAwIGZvciBpbmZvLiBDYW4gYWxzbyBiZSBvZiB0aGUgZm9ybQorICAg ICAgICAgICAgICAgICAgICAgKFdBUk5JTkcgLiBJTkZPKS4gIEluIHRoYXQgY2FzZSB0aGlzIHdp bGwgYmUgZXF1aXZhbGVudCB0bworICAgICAgICAgICAgICAgICAgICAgMSBpZiB0aGUgV0FSTklO R+KAmXRoIHN1YmV4cHJlc3Npb24gbWF0Y2hlZCBvciBlbHNlCisgICAgICAgICAgICAgICAgICAg ICBlcXVpdmFsZW50IHRvIDAgaWYgdGhlIElORk/igJl0aCBzdWJleHByZXNzaW9uIG1hdGNoZWQs IG9yCisgICAgICAgICAgICAgICAgICAgICBlbHNlIGVxdWl2YWxlbnQgdG8gMiBpZiBuZWl0aGVy IG9mIHRoZW0gbWF0Y2hlZC4gU2VlIGFsc28KKyAgICAgICAgICAgICAgICAgICAgIGBjb21waWxh dGlvbi1lcnJvci1yZWdleHAtYWxpc3QnLgogRmlsZSBtZXNzYWdlOgogICBSZWdleHAgICAgICAg ICAgIDogcmVndWxhciBleHByZXNzaW9uIHRvIG1hdGNoIGEgZmlsZSBuYW1lIG1lc3NhZ2UKICAg RmlsZSBzdWJleHAgaW5kZXg6IGluZGV4IG9mIHN1YmV4cHJlc3Npb24gdGhhdCBtYXRjaGVzIHRo ZSBmaWxlIG5hbWUKQEAgLTQ4Myw3ICs0OTAsMTIgQEAgdmhkbC1jb21waWxlci1hbGlzdAogCQkg ICAgICAoaW50ZWdlciA6dGFnICJMaW5lIHN1YmV4cCBpbmRleCIpCiAJCSAgICAgIChjaG9pY2Ug IDp0YWcgIkNvbHVtbiBzdWJleHAgICAgIgogCQkJICAgICAgKGludGVnZXIgOnRhZyAiSW5kZXgi KQotCQkJICAgICAgKGNvbnN0IDp0YWcgIk5vIGNvbHVtbiBudW1iZXIiIG5pbCkpKQorCQkJICAg ICAgKGNvbnN0IDp0YWcgIk5vIGNvbHVtbiBudW1iZXIiIG5pbCkpCisJCQkgICAgKGNob2ljZSAg OnRhZyAiVHlwZSAgICAiCisJCQkgICAgICAoY29uc3QgOnRhZyAiSW5mbyIgMCkKKwkJCSAgICAg IChjb25zdCA6dGFnICJXYXJuaW5nIiAxKQorCQkJICAgICAgKGNvbnN0IDp0YWcgIkVycm9yIiBu aWwpCisJCQkgICAgICAoc2V4cCA6dGFnICIoV0FSTklORyAuIElORk8pIikpKQogCQkobGlzdCA6 dGFnICJGaWxlIG1lc3NhZ2UiIDppbmRlbnQgNAogCQkgICAgICAocmVnZXhwICA6dGFnICJSZWdl eHAgICAgICAgICAgICIpCiAJCSAgICAgIChpbnRlZ2VyIDp0YWcgIkZpbGUgc3ViZXhwIGluZGV4 IikpCkBAIC0yNDUxLDYgKzI0NjMsMTUgQEAgdmhkbC1wcmludC13YXJuaW5ncwogICAgICAgKHNl dHEgdG1wLWFsaXN0IChjZHIgdG1wLWFsaXN0KSkpKQogICAoY3VzdG9taXplLXNhdmUtdmFyaWFi bGUgJ3ZoZGwtY29tcGlsZXItYWxpc3QgdmhkbC1jb21waWxlci1hbGlzdCkpCiAKKzs7IG9wdGlv biBgdmhkbC1jb21waWxlci1hbGlzdCcgY2hhbmdlZCBmb3JtYXQgKDMuMzguMSkKKyh3aGVuICg9 IChsZW5ndGggKG50aCAxMSAoY2FyIHZoZGwtY29tcGlsZXItYWxpc3QpKSkgNCkKKyAgKGxldCAo KHRtcC1hbGlzdCB2aGRsLWNvbXBpbGVyLWFsaXN0KSkKKyAgICAod2hpbGUgdG1wLWFsaXN0Cisg ICAgICAoc2V0Y2RyIChudGhjZHIgMyAobnRoIDExIChjYXIgdG1wLWFsaXN0KSkpCisJICAgICAg JyhuaWwgLiBuaWwpKQorICAgICAgKHNldHEgdG1wLWFsaXN0IChjZHIgdG1wLWFsaXN0KSkpKQor ICAoY3VzdG9taXplLXNhdmUtdmFyaWFibGUgJ3ZoZGwtY29tcGlsZXItYWxpc3QgdmhkbC1jb21w aWxlci1hbGlzdCkpCisKIDs7IG9wdGlvbiBgdmhkbC1wcm9qZWN0JzogZW1wdHkgdmFsdWUgY2hh bmdlZCBmcm9tICIiIHRvIG5pbCAoMy4zMS4xKQogKHdoZW4gKGVxdWFsIHZoZGwtcHJvamVjdCAi IikKICAgKHNldHEgdmhkbC1wcm9qZWN0IG5pbCkK --_004_AS4PR10MB611055A0494DA22FCA2F073CE3739AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 04:17:14 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 08:17:14 +0000 Received: from localhost ([127.0.0.1]:36340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvZZy-0002R7-9k for submit@debbugs.gnu.org; Sun, 07 May 2023 04:17:14 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:50362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvZZv-0002Qo-B0 for 63251@debbugs.gnu.org; Sun, 07 May 2023 04:17:11 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f14e499ffcso2024788e87.0 for <63251@debbugs.gnu.org>; Sun, 07 May 2023 01:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683447425; x=1686039425; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=YBTjnRC9OvMfLOtgvTwfwXaneuSd1UMRKvol3Thpm0k=; b=CIAVRPL9oEIwepYJgLEmcLo7RV2BEdfgZQjXlqx21xgv5AjzT9cs/th38fRKZKMKfc rdHTwLFQrv9OAComzOI7d/k3lkb3AExPEpyqjHyWgMsnEaWCFUPFtsxOob9I9IMmz4kS jrlYbVi5+oLVl/GkHu35eCca5cMijci7UZgsnmUFkOtRAM72mNYrcUHWgDD+3iH5mPs1 4uP/jSyfwsCbmDaWKhloGeKcgWmNPjhLqMPBgDsQlzx9t7TIyjaXFMmrGG93N/aCfdxk lgqQi//y1l7cjrhiXV2OYwIHGhKeRJkmlZr6GzC65Cpl8NJwUGpfp93wW3QIDFYErWf8 gOwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683447425; x=1686039425; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YBTjnRC9OvMfLOtgvTwfwXaneuSd1UMRKvol3Thpm0k=; b=NWEa18I2hiNj4Jv2n3O35btE6IJdYpj/vlAUQF5aNhN9CP68WrsDQCfNmxxjM7ambJ zFRcPCTHFcU4Y+8J55lm61nfdHqS+tL9nlNoKmT6hHMMJaLuN1W3wTPloM+iHEtIDyW5 oW+SDa+KCRK+a9yscvwj4FqY3wVek1vcp5RBxJFfhjgaegRPge84lo2rxjL+PoKR+DfP Z2wSclyGKJ6a/eSVMyWETeT2H17igYCHa15DAbheSpWLjY9q4SZmBm/pFdnnY/LEnx4b 0Pd3FKdQ8djSMGj1n+ugrKqQoT1yf5TRH7ergIEDcLdUebuJdJ77XHlC3ex4LxgFdsip dnEQ== X-Gm-Message-State: AC+VfDw/uq11xRpqTfRHrLHb96N2g5+O3fMDUHNy76wgd3WAA8g+Gkqs tgNjGGbsC1/An2ktp0x989c= X-Google-Smtp-Source: ACHHUZ6y+jiPO3ooc0lbnWpyAPRatYVr68tQ1FnDowIQVK45Ri8fXDryj1fJLgDrJLDcwp77pkf4lQ== X-Received: by 2002:ac2:5d23:0:b0:4db:ebb3:b529 with SMTP id i3-20020ac25d23000000b004dbebb3b529mr1694944lfb.46.1683447424836; Sun, 07 May 2023 01:17:04 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id c8-20020a05651221a800b004edafe3f8dbsm909209lft.11.2023.05.07.01.17.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 May 2023 01:17:04 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63251: 28.2; vhdl-mode contribution From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 7 May 2023 10:17:03 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> To: Cyril Arnould X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The vhdl-mode maintainers need to look at your patch more closely; I = just have some minor remarks. 7 maj 2023 kl. 00.11 skrev Cyril Arnould : > - I've added TYPE to the vhdl-compiler definition with the > appropriate choices for Info/Warning/Error and the dotted > pair. I'm not sure if sexp was the correct choice for the > dotted pair, is there a better alternative? There is (cons ...) which would be more precise, see the manual. The new doc string says that a TYPE of 2 is allowed but the type spec = doesn't allow it. Either allow both 2 and nil or change the docs to only mention one of = them. > - I added another entry to the backwards compatibility code, all > it took was a slight modification of the entry before > that. That's fine, but I'd be a bit more careful with the destructive in-place = changes and quoted list constants. (Think of what happens if later code = performs an in-place change of that nil you added.) This isn't performance-critical-code, we can afford consing here. From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 11:40:21 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 15:40:22 +0000 Received: from localhost ([127.0.0.1]:38218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvgUn-0003Gc-Dl for submit@debbugs.gnu.org; Sun, 07 May 2023 11:40:21 -0400 Received: from mail-vi1eur02olkn2104.outbound.protection.outlook.com ([40.92.48.104]:54113 helo=EUR02-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvgUl-0003GI-FR for 63251@debbugs.gnu.org; Sun, 07 May 2023 11:40:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UmjuOqrKi9WTDFR/BF4zGqVAxOvnq60fw/878hoe44j7/GfaB7Z3yTonAEFXiKOyNAyXQT96wDnis60on50HH1eqRCwHhoW5HP5zOjXic6bkJLuOkOi0Yeb59NIkaamC5Y7DHQwEaQ9brTSBZCq8ed01cTQIxW68z0bztcDwG3WQpbInGoIF3yzgv0h5ebkT+qMHYSlbzLlt7b9d5mhoaKNGNcrRhRcvwbQVkLbJIitI388VWrq2wu9HNtHSwqQmDJfZXJ5xDtogT78pnFasE08gIa2foH72lM3O5r0mjfwsuU2xavjVGUPvMEhGFa+6JkLDy1ZgClgmC1zkuyP+3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4MldSj+dPeE71KDa49LovZhhuKagcWkcdgpjX3388OI=; b=AYMbtDZ+jexH3IJVKHEdVqGV/eo6c/psa6i8bS0aeER7uU8YMoSUEvs2Rd5PgtcDuRi6bslJnLSEP4vF8HQLeMLid4mv/9EJUsxDgUb7HXmMiK4z7s1UpFJ4f5nYogexhEgb9oN+UppTuzB57+Zc4rvwqv/AnIw301TqdZ5sV/aLogZsa915SgGC51Ely2Wtx1jTnbN0TqEaMJa/q7Gs6lWGXcmCUGqEoGZ2fH7NG0uD5YnaK5rVveok+hrt9U3IK6/m1jl1Ut6n7Up++tySycAG7HzBIk7PqU8FMZ8pARRlvCURg3tYd2xNdNsT58O0DmXo/PRSW8ILWnlkyXoqvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4MldSj+dPeE71KDa49LovZhhuKagcWkcdgpjX3388OI=; b=q5DebxzU1rSOIBQIWAEqAuozEnEm9IBOTo+JD68LiH3MPffld3sXVDopb+wb1nGNowky+Va5X/vlrNAk8hR9YMZ8zDP0Jhq5RE3T3MEDv9JPWesHsKG7/Sk1RQVakkGrEYeG3JWlmNYvT1TWMuLXVfuwwxsz+Myo9DS/J8Uz/FD4G+4yBy2sZkz5cAXuleyUFGVr/JRU8bIyGMet38aq6MAG1hYa6B11Co7nv4ofXCuOC00EgKY4rcQJJayGzULdALA+bSnJDfz1xmRlFnXNLDU5MSzbmh+PWyDKnTfHvBo0U+XNR9mMHJTw2NaySzVpyU1w6PcYUFhW8Jb5g4/aHA== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by VE1PR10MB3886.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:16a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Sun, 7 May 2023 15:40:12 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.031; Sun, 7 May 2023 15:40:12 +0000 From: Cyril Arnould To: =?Windows-1252?Q?Mattias_Engdeg=E5rd?= Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj7+AAK+qgIAAAlBP Date: Sun, 7 May 2023 15:40:12 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> In-Reply-To: <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [qC8KHgx2mo2NgSaIiHVl/N4bn9wTcy1z] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|VE1PR10MB3886:EE_ x-ms-office365-filtering-correlation-id: 89659367-4363-4577-0431-08db4f1158cd x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GYhdQpjq70RkKERetzzugDybkdRb4XKd2Jxvy9C4m5tUCAByH6ZKRtVm8J5MTPGPE4zYA7sCo6jo7tW7hSGYnn6xU3D/GRWUaSFFlmA54sBqbdK7k+asBmDXorUo7LAOH2tj8rWxQKbXmfcTxEjVZNBxki2jtN6N++7hC/8mDnt7b/GF+FmrKAA/IX9Ur/SVRV62XzveOIVAGDL6oZZvP7Dk+FId3kuf7BXbZssHcctRPRuEsKkRrIdNx9qTNybJja8mqj1OkTBUYoFz1txdcCPGfp0whXaVkf8Vi22+zsU0Vi8lLjJm44DrqaSEpJwwbrwRFeHCkHjUyYGMk06Z8qGYNeB8nkHG65dtwCWPDTlHSa/nTGrrzQ30vh4cMWHJD9GM3eEP7W1zB3DwVCTSqspbBSHpXrY98H5HJL//6173zZB3wl515ler5fZGs0JiN51RK/hO3Hy/LYvl4Am/I2/JcJFw43WsJKIAUv93VZJu42kf9oAkj5h4/VYgUxwUtkLBxcclMPkM2C5DPtrkYaj4g+QaPmnDtg0Id4+OogEk7+64j3XeA21LfUoTQoCL x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?VHLvzfcqSIXLne0Df99V99KO3s4x88sUs/m9fWDLB65cR39N1RmgBwb7?= =?Windows-1252?Q?pJ3bw1RWmgYFGIDM/1RA41Gk+pLcRGfMUS/mjM7lSHyEln8F5Lacm8bG?= =?Windows-1252?Q?TQyAxzdFWoeq8O+MnMYyR+LDUYAPENxEo5PSxgqS195bXc+Wkz+/fQmn?= =?Windows-1252?Q?nJRPZ7YrIdU0A3ZqNAuVsaIPn9mdozG2snwKf+RdzbmcCaG8/FnTng0Z?= =?Windows-1252?Q?+BizjGwhi01hYEj37BPZ29konDY6iyYOs5nv1CNH+jGJj4HChup70GpO?= =?Windows-1252?Q?qvoFsCfxREqmuOVBQ3LPIuv+CrXiiGZVVuUncTcIslFOuc/D6oufsMis?= =?Windows-1252?Q?0pWsJ6apPd/4AvIMsJzRwEnJ3sgaBkiuFAJ+1tPpKJLgEjsr10l1W41q?= =?Windows-1252?Q?N0nJN/qvx8gK5z0iqv6fVLfBjyzQk9EEEL3dMf/3S36iP1SEL/LccsY/?= =?Windows-1252?Q?9Ymbpx8GDw3tvk2WqrrDcvh1ti2jkXpzs4d4bjRCqmTR25j1dcz8RGMz?= =?Windows-1252?Q?TYFdYPZbU2JMIpqIg4f0RNalD+jdMKqh6wxXxfsq7c1cSf09hkPIgDBz?= =?Windows-1252?Q?NMOA6C5iSZ1QepiznrG7XCbnHS/eXaNEw+sxhsUuSQUB8ugKO2yBwJUf?= =?Windows-1252?Q?XjbfImayKB2s+m2yGcPtpwua4tTIZUajnqV8UiCF+b9OwoYqflTrZ6Z+?= =?Windows-1252?Q?a6+lGyt3TfEgD/DlW4Lb4n9DmKTdBC8Orj4ta7iyrBXhU5v3je9wDwXo?= =?Windows-1252?Q?cdWgPC2Po33lhCyyU0nDAydI2ivZ9YXmiEn2IuUvdYDCx/FOjqVFZchx?= =?Windows-1252?Q?h5T/OnqUcEMn448zUWg6md1Vrbrq1Jii85z123gS1kJ55jCx0Ht7w6n6?= =?Windows-1252?Q?TT7Yo6zS+n2zfGVpEP0PL5TuHu3WbFJARgRl+wu11GBVpnQ05MZdVxRx?= =?Windows-1252?Q?QWiK5paFL7t0Wrn/baZhJ69cE7aGWCBbb208SBad0H4Fp883Kggcn17i?= =?Windows-1252?Q?aCZpqP5FOux8GMXsEz+UBoakzjxYxVEPDDRyelDBnmNWAZWQ0H+vM50i?= =?Windows-1252?Q?19KXc2iuOIEY2ZpYM+1UUbrNzVy6OQbkkt/9sDmFJM/hD5DWprPsRD6v?= =?Windows-1252?Q?79bMUXmWt0BLe0njI5LkVKjKDpOeeri9W6EVfw5/Ja1HY/h+DbgDZ3df?= =?Windows-1252?Q?XH8ikZkjdmbz5ZgPtlfzPG72e103Ao74gfFrDtYiSlwERrquV+JIS4Iu?= =?Windows-1252?Q?sf01WyyxkhRQEXDQToysF1JhV1JTnZvxpszlCubQLr4tOToh1rpfaYjK?= =?Windows-1252?Q?1YQD1lNj7OoBMXe6LT3E8rb3xTVra4wGQNx59Y5PkxH0ORj9?= Content-Type: multipart/mixed; boundary="_004_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 89659367-4363-4577-0431-08db4f1158cd X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 15:40:12.5393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR10MB3886 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_004_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_ Content-Type: multipart/alternative; boundary="_000_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_" --_000_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Thanks for the feedback. > There is (cons ...) which would be more precise, see the manual. I had tried (cons =85) instead of (sexp =85), but that just resulted in the customization menu breaking again if one of the compilers was set to a dotted list. > The new doc string says that a TYPE of 2 is allowed but the type spec doe= sn't allow it. > Either allow both 2 and nil or change the docs to only mention one of the= m. Makes sense. It=92s probably more user-friendly (not to mention easier) to just allow one of them. > Think of what happens if later code performs an in-place change of that n= il you added. I am by no means an expert when it comes to elisp, I don=92t know what kind of problems this could cause. Would using 2 rather than nil make more sense for this? I=92ve checked compile.el, and internally they remap nil to 2 and use that, so 2 would also be more explicit I guess. I've modifided the patch to use 2 rather than nil (exclusively). Von: Mattias Engdeg=E5rd Gesendet: Sonntag, 7. Mai 2023 10:17 An: Cyril Arnould Cc: 63251@debbugs.gnu.org; Reto Zimmermann; Eli Zaretskii Betreff: Re: bug#63251: 28.2; vhdl-mode contribution The vhdl-mode maintainers need to look at your patch more closely; I just h= ave some minor remarks. 7 maj 2023 kl. 00.11 skrev Cyril Arnould : > - I've added TYPE to the vhdl-compiler definition with the > appropriate choices for Info/Warning/Error and the dotted > pair. I'm not sure if sexp was the correct choice for the > dotted pair, is there a better alternative? There is (cons ...) which would be more precise, see the manual. The new doc string says that a TYPE of 2 is allowed but the type spec doesn= 't allow it. Either allow both 2 and nil or change the docs to only mention one of them. > - I added another entry to the backwards compatibility code, all > it took was a slight modification of the entry before > that. That's fine, but I'd be a bit more careful with the destructive in-place ch= anges and quoted list constants. (Think of what happens if later code perfo= rms an in-place change of that nil you added.) This isn't performance-critical-code, we can afford consing here. --_000_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Thanks for the feedback.

 

> There is (cons ...) which would be more precise= , see the manual.

 

I had tried (cons =85) instead of (sexp =85), but th= at just resulted in

the customization menu breaking again if one of the = compilers was set

to a dotted list.

 

> The new doc string says that a TYPE of 2 is all= owed but the type spec doesn't allow it.

> Either allow both 2 and nil or change the docs = to only mention one of them.

 

Makes sense. It=92s probably more user-friendly (not= to mention easier)

to just allow one of them.

 

> Think of what happens if later code performs an= in-place change of that nil you added.

 

I am by no means an expert when it comes to elisp, I= don=92t know what

kind of problems this could cause. Would using 2 rat= her than nil make

more sense for this? I=92ve checked compile.el, and = internally they

remap nil to 2 and use that, so 2 would also be more= explicit I guess.

 

I've modifided the patch to use 2 rather than nil (e= xclusively).

 

 

Von: Mattias Engdeg=E5rd
Gesendet: Sonntag, 7. Mai 2023 10:17
An: Cyril Arnould Cc: 63251@debbugs.gnu.org; Reto Zimmermann; Eli Zaretskii
Betreff: Re: bug#63251: 28.2; vhdl-mode contribution

 

The vhdl-mode maintai= ners need to look at your patch more closely; I just have some minor remark= s.

7 maj 2023 kl. 00.11 skrev Cyril Arnould <cyril.arnould@outlook.com>:=

> - I've added TYPE to the vhdl-compiler definition with the
>   appropriate choices for Info/Warning/Error and the dotted<= br> >   pair. I'm not sure if sexp was the correct choice for the<= br> >   dotted pair, is there a better alternative?

There is (cons ...) which would be more precise, see the manual.

The new doc string says that a TYPE of 2 is allowed but the type spec doesn= 't allow it.
Either allow both 2 and nil or change the docs to only mention one of them.=

> - I added another entry to the backwards compatibility code, all
>   it took was a slight modification of the entry before
>   that.

That's fine, but I'd be a bit more careful with the destructive in-place ch= anges and quoted list constants. (Think of what happens if later code perfo= rms an in-place change of that nil you added.)
This isn't performance-critical-code, we can afford consing here.

 

--_000_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_-- --_004_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_ Content-Type: application/octet-stream; name="fix-vhdl-compiler-customization-2.patch" Content-Description: fix-vhdl-compiler-customization-2.patch Content-Disposition: attachment; filename="fix-vhdl-compiler-customization-2.patch"; size=12143; creation-date="Sun, 07 May 2023 15:38:30 GMT"; modification-date="Sun, 07 May 2023 15:38:30 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCAiYS9saXNwL3Byb2dtb2Rlcy92aGRsLW1vZGUuZWwiICJiL2xpc3AvcHJvZ21v ZGVzL3ZoZGwtbW9kZS5lbCIKaW5kZXggZWUwZWM2M2I2YmMuLjQxYzAwZDRjODczIDEwMDY0NAot LS0gImEvbGlzcC9wcm9nbW9kZXMvdmhkbC1tb2RlLmVsIgorKysgImIvbGlzcC9wcm9nbW9kZXMv dmhkbC1tb2RlLmVsIgpAQCAtMjI5LDIwICsyMjksMjAgQEAgdmhkbC1jb21waWxlci1hbGlzdAog ICAgIDs7IFtFcnJvcl0gQXNzaWdubWVudCBlcnJvcjogdmFyaWFibGUgaXMgaWxsZWdhbCB0YXJn ZXQgb2Ygc2lnbmFsIGFzc2lnbm1lbnQKICAgICAoIkFEVmFuY2UgTVMiICJ2YWNvbSIgIi13b3Jr IFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAidmFsaWIgXFwxOyB2YW1hcCBcXDIgXFwx IiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiYWRtcyIKLSAgICAgKCJeXFxzLStcXChbMC05XStc XCk6XFxzLSsiIG5pbCAxIG5pbCkgKCJeQ29tcGlsaW5nIGZpbGUgXFwoLitcXCkiIDEpCisgICAg ICgiXlxccy0rXFwoWzAtOV0rXFwpOlxccy0rIiBuaWwgMSBuaWwgMikgKCJeQ29tcGlsaW5nIGZp bGUgXFwoLitcXCkiIDEpCiAgICAgICgiRU5USS9cXDEudmlmIiAiQVJDSC9cXDEtXFwyLnZpZiIg IkNPTkYvXFwxLnZpZiIKICAgICAgICJQQUNLL1xcMS52aWYiICJCT0RZL1xcMS52aWYiIHVwY2Fz ZSkpCiAgICAgOzsgQWxkZWMKICAgICA7OyBDT01QOTYgRVJST1IgQ09NUDk2XzAwMTg6ICJJZGVu dGlmaWVyIGV4cGVjdGVkLiIgInRlc3QudmhkIiA2NiAzCiAgICAgKCJBbGRlYyIgInZjb20iICIt d29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgInZsaWIgXFwxOyB2bWFwIFxcMiBc XDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJhbGRlYyIKLSAgICAgKCJeLiogRVJST1IgW146 XSs6IFwiLipcIiBcIlxcKFteIFx0XG5dK1xcKVwiIFxcKFswLTldK1xcKSBcXChbMC05XStcXCki IDEgMiAzKSAoIiIgMCkKKyAgICAgKCJeLiogRVJST1IgW146XSs6IFwiLipcIiBcIlxcKFteIFx0 XG5dK1xcKVwiIFxcKFswLTldK1xcKSBcXChbMC05XStcXCkiIDEgMiAzIDIpICgiIiAwKQogICAg ICBuaWwpCiAgICAgOzsgQ2FkZW5jZSBMZWFwZnJvZzogY3YgLWZpbGUgdGVzdC52aGQKICAgICA7 OyBkdWx1dGg6ICpFLDQzMCAodGVzdC52aGQsMTMpOiBpZGVudGlmaWVyIChQT1NJVElWKSBpcyBu b3QgZGVjbGFyZWQKICAgICAoIkNhZGVuY2UgTGVhcGZyb2ciICJjdiIgIi13b3JrIFxcMSAtZmls ZSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1h a2VmaWxlIiAibGVhcGZyb2ciCi0gICAgICgiXmR1bHV0aDogXFwqRSxbMC05XSsgKFxcKFteIFx0 XG5dK1xcKSxcXChbMC05XStcXCkpOiIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXmR1bHV0aDog XFwqRSxbMC05XSsgKFxcKFteIFx0XG5dK1xcKSxcXChbMC05XStcXCkpOiIgMSAyIG5pbCAyKSAo IiIgMCkKICAgICAgKCJcXDEvZW50aXR5IiAiXFwyL1xcMSIgIlxcMS9jb25maWd1cmF0aW9uIgog ICAgICAgIlxcMS9wYWNrYWdlIiAiXFwxL2JvZHkiIGRvd25jYXNlKSkKICAgICA7OyBDYWRlbmNl IEFmZmlybWEgTkMgdmhkbDogbmN2aGRsIHRlc3QudmhkCkBAIC0yNTAsNyArMjUwLDcgQEAgdmhk bC1jb21waWxlci1hbGlzdAogICAgIDs7IChQTExfNDAwWF9UT1ApIGlzIG5vdCBkZWNsYXJlZCBb MTAuM10uCiAgICAgKCJDYWRlbmNlIE5DIiAibmN2aGRsIiAiLXdvcmsgXFwxIiAibWFrZSIgIi1m IFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJuY3Zo ZGwiCi0gICAgICgiXm5jdmhkbF9wOiBcXCpFLFxcdysgKFxcKFteIFx0XG5dK1xcKSxcXChbMC05 XStcXCl8XFwoWzAtOV0rXFwpKToiIDEgMiAzKSAoIiIgMCkKKyAgICAgKCJebmN2aGRsX3A6IFxc KkUsXFx3KyAoXFwoW14gXHRcbl0rXFwpLFxcKFswLTldK1xcKXxcXChbMC05XStcXCkpOiIgMSAy IDMgMikgKCIiIDApCiAgICAgICgiXFwxL2VudGl0eS9wYy5kYiIgIlxcMi9cXDEvcGMuZGIiICJc XDEvY29uZmlndXJhdGlvbi9wYy5kYiIKICAgICAgICJcXDEvcGFja2FnZS9wYy5kYiIgIlxcMS9i b2R5L3BjLmRiIiBkb3duY2FzZSkpCiAgICAgOzsgZ2hkbCB2aGRsCkBAIC0yNTgsMjEgKzI1OCwy MSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgICAgOzsgYmFkX2NvdW50ZXIudmhkbDoxMzoxNDog b3BlcmF0b3IgIj0iIGlzIG92ZXJsb2FkZWQKICAgICAoIkdIREwiICJnaGRsIiAiLWkgLS13b3Jr ZGlyPVxcMSAtLWllZWU9c3lub3BzeXMgLWZleHBsaWNpdCAiICJtYWtlIiAiLWYgXFwxIgogICAg ICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgImdoZGwiCi0gICAgICgi XmdoZGxfcDogXFwqRSxcXHcrIChcXChbXiBcdFxuXStcXCksXFwoWzAtOV0rXFwpfFxcKFswLTld K1xcKSk6IiAxIDIgMykgKCIiIDApCisgICAgICgiXmdoZGxfcDogXFwqRSxcXHcrIChcXChbXiBc dFxuXStcXCksXFwoWzAtOV0rXFwpfFxcKFswLTldK1xcKSk6IiAxIDIgMyAyKSAoIiIgMCkKICAg ICAgKCJcXDEvZW50aXR5IiAiXFwyL1xcMSIgIlxcMS9jb25maWd1cmF0aW9uIgogICAgICAgIlxc MS9wYWNrYWdlIiAiXFwxL2JvZHkiIGRvd25jYXNlKSkKICAgICA7OyBJQk0gQ29tcGlsZXIKICAg ICA7OyAwMCBDT0FDSERMKiB8IFtDQ0hETC0xXTogRmlsZTogYWRkZXIudmhkLCBsaW5lLmNvbHVt bjogMTIwLjYKICAgICAoIklCTSBDb21waWxlciIgImcydHZjIiAiLXNyYyIgInByZWNvbXAiICJc XDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiaWJtIgot ICAgICAoIl5bMC05XSsgQ09BQ0hETC4qOiBGaWxlOiBcXChbXiBcdFxuXStcXCksICpsaW5lLmNv bHVtbjogXFwoWzAtOV0rXFwpLlxcKFswLTldK1xcKSIgMSAyIDMpICgiICIgMCkKKyAgICAgKCJe WzAtOV0rIENPQUNIREwuKjogRmlsZTogXFwoW14gXHRcbl0rXFwpLCAqbGluZS5jb2x1bW46IFxc KFswLTldK1xcKS5cXChbMC05XStcXCkiIDEgMiAzIDIpICgiICIgMCkKICAgICAgbmlsKQogICAg IDs7IElrb3MgVm95YWdlcjogYW5hbHl6ZSB0ZXN0LnZoZAogICAgIDs7IGFuYWx5emUgdGVzdC52 aGQKICAgICA7OyBFIEw0L0M1OiAgICAgICAgdGhpcyBsaWJyYXJ5IHVuaXQgaXMgaW5hY2Nlc3Np YmxlCiAgICAgKCJJa29zIiAiYW5hbHl6ZSIgIi1sIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAg IG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiaWtvcyIKLSAgICAgKCJe RSBMXFwoWzAtOV0rXFwpL0NcXChbMC05XStcXCk6IiBuaWwgMSAyKQorICAgICAoIl5FIExcXChb MC05XStcXCkvQ1xcKFswLTldK1xcKToiIG5pbCAxIDIgMikKICAgICAgKCJeYW5hbHl6ZSArXFwo LisgK1xcKSpcXCguK1xcKSQiIDIpCiAgICAgIG5pbCkKICAgICA7OyBNb2RlbFNpbSwgTW9kZWwg VGVjaG5vbG9neTogdmNvbSB0ZXN0LnZoZApAQCAtMjk0LDcgKzI5NCw3IEBAIHZoZGwtY29tcGls ZXItYWxpc3QKICAgICA7OyB0ZXN0LnZoZDozNDogZXJyb3IgbWVzc2FnZQogICAgICgiTEVEQSBQ cm9WSERMIiAicHJvdmhkbCIgIi13IFxcMSAtZiIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAi bWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAicHJvdmhkbCIKLSAgICAgKCJeXFwo W14gXHRcbjpdK1xcKTpcXChbMC05XStcXCk6ICIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXlxc KFteIFx0XG46XStcXCk6XFwoWzAtOV0rXFwpOiAiIDEgMiBuaWwgMikgKCIiIDApCiAgICAgICgi RU5USS9cXDEudmlmIiAiQVJDSC9cXDEtXFwyLnZpZiIgIkNPTkYvXFwxLnZpZiIKICAgICAgICJQ QUNLL1xcMS52aWYiICJCT0RZL0JPRFktXFwxLnZpZiIgdXBjYXNlKSkKICAgICA7OyBRdWFydHVz IGNvbXBpbGVyCkBAIC0zMDUsMjEgKzMwNSwyMSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgICAg OzsgV2FybmluZzogVkhETCBQcm9jZXNzIFN0YXRlbWVudCB3YXJuaW5nIGF0IGR2aTJzZGlfdHN0 LnZoZCgxNzIpOiAuLi4KICAgICAoIlF1YXJ0dXMiICJtYWtlIiAiLXdvcmsgXFwxIiAibWFrZSIg Ii1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJx dWFydHVzIgotICAgICAoIl5cXChFcnJvclxcfFdhcm5pbmdcXCk6IC4qIFxcKFteIFx0XG5dK1xc KShcXChbMC05XStcXCkpIiAyIDMgbmlsKSAoIiIgMCkKKyAgICAgKCJeXFwoRXJyb3JcXHxXYXJu aW5nXFwpOiAuKiBcXChbXiBcdFxuXStcXCkoXFwoWzAtOV0rXFwpKSIgMiAzIG5pbCAyKSAoIiIg MCkKICAgICAgbmlsKQogICAgIDs7IFF1aWNrSERMLCBNZW50b3IgR3JhcGhpY3M6IHF2aGNvbSB0 ZXN0LnZoZAogICAgIDs7IEVSUk9SOiB0ZXN0LnZoZCgyNCk6IG5lYXIgImRuZCI6IGV4cGVjdGlu ZzogRU5ECiAgICAgOzsgV0FSTklOR1s0XTogdGVzdC52aGQoMzApOiBBIHNwYWNlIGlzIHJlcXVp cmVkIGJldHdlZW4gLi4uCiAgICAgKCJRdWlja0hETCIgInF2aGNvbSIgIi13b3JrIFxcMSIgIm1h a2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxl IiAicXVpY2toZGwiCi0gICAgICgiXlxcKEVSUk9SXFx8V0FSTklOR1xcKVteOl0qOiBcXChbXiBc dFxuXStcXCkoXFwoWzAtOV0rXFwpKToiIDIgMyBuaWwpICgiIiAwKQorICAgICAoIl5cXChFUlJP UlxcfFdBUk5JTkdcXClbXjpdKjogXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSk6IiAyIDMg bmlsIDIpICgiIiAwKQogICAgICAoIlxcMS9fcHJpbWFyeS5kYXQiICJcXDIvXFwxLmRhdCIgIlxc MS9fcHJpbWFyeS5kYXQiCiAgICAgICAiXFwxL19wcmltYXJ5LmRhdCIgIlxcMS9ib2R5LmRhdCIg ZG93bmNhc2UpKQogICAgIDs7IFNhdmFudDogc2NyYW0gLXB1Ymxpc2gtY2MgdGVzdC52aGQKICAg ICA7OyB0ZXN0LnZoZDo4NzogX3NldF9wYXNzZWRfdGhyb3VnaF9vdXRfcG9ydChJSVJfQm9vbGVh bikgbm90IGRlZmluZWQgZm9yCiAgICAgKCJTYXZhbnQiICJzY3JhbSIgIi1wdWJsaXNoLWNjIC1k ZXNpZ24tbGlicmFyeS1uYW1lIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIg XFwxIiAiLi8iICJ3b3JrLl9zYXZhbnRfbGliLyIgIk1ha2VmaWxlIiAic2F2YW50IgotICAgICAo Il5cXChbXiBcdFxuOl0rXFwpOlxcKFswLTldK1xcKTogIiAxIDIgbmlsKSAoIiIgMCkKKyAgICAg KCJeXFwoW14gXHRcbjpdK1xcKTpcXChbMC05XStcXCk6ICIgMSAyIG5pbCAyKSAoIiIgMCkKICAg ICAgKCJcXDFfZW50aXR5LnZoZGwiICJcXDJfc2Vjb25kYXJ5X3VuaXRzLl9zYXZhbnRfbGliL1xc Ml9cXDEudmhkbCIKICAgICAgICJcXDFfY29uZmlnLnZoZGwiICJcXDFfcGFja2FnZS52aGRsIgog ICAgICAgIlxcMV9zZWNvbmRhcnlfdW5pdHMuX3NhdmFudF9saWIvXFwxX3BhY2thZ2VfYm9keS52 aGRsIiBkb3duY2FzZSkpCkBAIC0zMjcsMzkgKzMyNywzOSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0 CiAgICAgOzsgRXJyb3I6IENTVkhETDAwMDI6IHRlc3QudmhkOiAobGluZSA5Nyk6IEludmFsaWQg cHJlZml4CiAgICAgKCJTaW1pbGkiICJ2aGRscCIgIi13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEi CiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAic2ltaWxpIgot ICAgICAoIl5cXChFcnJvclxcfFdhcm5pbmdcXCk6IFxcdys6IFxcKFteIFx0XG5dK1xcKTogKGxp bmUgXFwoWzAtOV0rXFwpKTogIiAyIDMgbmlsKSAoIiIgMCkKKyAgICAgKCJeXFwoRXJyb3JcXHxX YXJuaW5nXFwpOiBcXHcrOiBcXChbXiBcdFxuXStcXCk6IChsaW5lIFxcKFswLTldK1xcKSk6ICIg MiAzIG5pbCAyKSAoIiIgMCkKICAgICAgKCJcXDEvcHJpbS52YXIiICJcXDIvX1xcMS52YXIiICJc XDEvcHJpbS52YXIiCiAgICAgICAiXFwxL3ByaW0udmFyIiAiXFwxL19ib2R5LnZhciIgZG93bmNh c2UpKQogICAgIDs7IFNwZWVkd2F2ZSAoSW5ub3ZlZGEpOiBhbmFseXplIC1saWJmaWxlIHZzc2xp Yi5pbmkgLXNyYyB0ZXN0LnZoZAogICAgIDs7ICAgICBFUlJPUlsxMV06OkZpbGUgdGVzdC52aGQg TGluZSAxMDA6IFVzZSBvZiB1bmRlY2xhcmVkIGlkZW50aWZpZXIKICAgICAoIlNwZWVkd2F2ZSIg ImFuYWx5emUiICItbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMiICJtYWtlIiAiLWYgXFwxIgogICAg ICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInNwZWVkd2F2ZSIKLSAg ICAgKCJeICpFUlJPUlxcW1swLTldK106OkZpbGUgXFwoW14gXHRcbl0rXFwpIExpbmUgXFwoWzAt OV0rXFwpOiIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXiAqRVJST1JcXFtbMC05XStdOjpGaWxl IFxcKFteIFx0XG5dK1xcKSBMaW5lIFxcKFswLTldK1xcKToiIDEgMiBuaWwgMikgKCIiIDApCiAg ICAgIG5pbCkKICAgICA7OyBTeW5vcHN5cywgVkhETCBBbmFseXplciAoc2ltKTogdmhkbGFuIC1u YyB0ZXN0LnZoZAogICAgIDs7ICoqRXJyb3I6IHZoZGxhbiw3MDMgdGVzdC52aGQoMjIpOiBPVEhF UlMgaXMgbm90IGxlZ2FsIGluIHRoaXMgY29udGV4dC4KICAgICAoIlN5bm9wc3lzIiAidmhkbGFu IiAiLW5jIC13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAi Li8iICJ3b3JrLyIgIk1ha2VmaWxlIiAic3lub3BzeXMiCi0gICAgICgiXlxcKlxcKkVycm9yOiB2 aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIgMSAyIG5pbCkgKCIi IDApCisgICAgICgiXlxcKlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShc XChbMC05XStcXCkpOiIgMSAyIG5pbCAyKSAoIiIgMCkKICAgICAgKCJcXDEuc2ltIiAiXFwyX19c XDEuc2ltIiAiXFwxLnNpbSIgIlxcMS5zaW0iICJcXDFfXy5zaW0iIHVwY2FzZSkpCiAgICAgOzsg U3lub3BzeXMsIFZIREwgQW5hbHl6ZXIgKHN5bik6IHZoZGxhbiAtbmMgLXNwYyB0ZXN0LnZoZAog ICAgIDs7ICoqRXJyb3I6IHZoZGxhbiw3MDMgdGVzdC52aGQoMjIpOiBPVEhFUlMgaXMgbm90IGxl Z2FsIGluIHRoaXMgY29udGV4dC4KICAgICAoIlN5bm9wc3lzIERlc2lnbiBDb21waWxlciIgInZo ZGxhbiIgIi1uYyAtc3BjIC13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtk aXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAic3lub3BzeXNfZGMiCi0gICAgICgiXlxc KlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIg MSAyIG5pbCkgKCIiIDApCisgICAgICgiXlxcKlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFte IFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIgMSAyIG5pbCAyKSAoIiIgMCkKICAgICAgKCJcXDEu c3luIiAiXFwyX19cXDEuc3luIiAiXFwxLnN5biIgIlxcMS5zeW4iICJcXDFfXy5zeW4iIHVwY2Fz ZSkpCiAgICAgOzsgU3lucGxpZnk6CiAgICAgOzsgQFc6InRlc3QudmhkIjo1Nzo4OjU3Ojl8T3B0 aW1pemluZyByZWdpc3RlciBiaXQgY291bnRfeCg1KSB0byBhIGNvbnN0YW50IDAKICAgICAoIlN5 bnBsaWZ5IiAibi9hIiAibi9hIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEi ICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJzeW5wbGlmeSIKLSAgICAgKCJeQFtFV05dOlwiXFwo W14gXHRcbl0rXFwpXCI6XFwoWzAtOV0rXFwpOlxcKFswLTldK1xcKToiIDEgMiAzKSAoIiIgMCkK KyAgICAgKCJeQFtFV05dOlwiXFwoW14gXHRcbl0rXFwpXCI6XFwoWzAtOV0rXFwpOlxcKFswLTld K1xcKToiIDEgMiAzIDIpICgiIiAwKQogICAgICBuaWwpCiAgICAgOzsgVmFudGFnZTogYW5hbHl6 ZSAtbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMgdGVzdC52aGQKICAgICA7OyAgICAgQ29tcGlsaW5n ICJ0ZXN0LnZoZCIgbGluZSAxLi4uCiAgICAgOzsgKipFcnJvcjogTElORSA0OSAqKiogTm8gYWdn cmVnYXRlIHZhbHVlIGlzIHZhbGlkIGluIHRoaXMgY29udGV4dC4KICAgICAoIlZhbnRhZ2UiICJh bmFseXplIiAiLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIiAibWFrZSIgIi1mIFxcMSIKICAgICAg bmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJ2YW50YWdlIgotICAgICAo Il5cXCpcXCpFcnJvcjogTElORSBcXChbMC05XStcXCkgXFwqXFwqXFwqIiBuaWwgMSBuaWwpCisg ICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoiIG5pbCAxIG5p bCAyKQogICAgICAoIl4gKkNvbXBpbGluZyBcIlxcKC4rXFwpXCIgIiAxKQogICAgICBuaWwpCiAg ICAgOzsgVmVyaUJlc3Q6IHZjIHZoZGwgdGVzdC52aGQKQEAgLTM2OSwyNiArMzY5LDI2IEBAIHZo ZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyBbRXJyb3JdIE5hbWUgQklUQSBpcyB1bmtub3duCiAg ICAgKCJWZXJpQmVzdCIgInZjIiAidmhkbCIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtk aXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAidmVyaWJlc3QiCi0gICAgICgiXiArXFwo WzAtOV0rXFwpOiArW14gXSIgbmlsIDEgbmlsKSAoIiIgMCkKKyAgICAgKCJeICtcXChbMC05XStc XCk6ICtbXiBdIiBuaWwgMSBuaWwgMikgKCIiIDApCiAgICAgIG5pbCkKICAgICA7OyBWaWV3bG9n aWM6IGFuYWx5emUgLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIHRlc3QudmhkCiAgICAgOzsgICAg IENvbXBpbGluZyAidGVzdC52aGQiIGxpbmUgMS4uLgogICAgIDs7ICoqRXJyb3I6IExJTkUgNDkg KioqIE5vIGFnZ3JlZ2F0ZSB2YWx1ZSBpcyB2YWxpZCBpbiB0aGlzIGNvbnRleHQuCiAgICAgKCJW aWV3bG9naWMiICJhbmFseXplIiAiLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIiAibWFrZSIgIi1m IFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJ2aWV3 bG9naWMiCi0gICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoi IG5pbCAxIG5pbCkKKyAgICAgKCJeXFwqXFwqRXJyb3I6IExJTkUgXFwoWzAtOV0rXFwpIFxcKlxc KlxcKiIgbmlsIDEgbmlsIDIpCiAgICAgICgiXiAqQ29tcGlsaW5nIFwiXFwoLitcXClcIiAiIDEp CiAgICAgIG5pbCkKICAgICA7OyBYaWxpbnggWFNUOgogICAgIDs7IEVSUk9SOkhETFBhcnNlcnM6 MTY0IC0gInRlc3QudmhkIiBMaW5lIDMuIHBhcnNlIGVycm9yCiAgICAgKCJYaWxpbnggWFNUIiAi eGZsb3ciICIiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29y ay8iICJNYWtlZmlsZSIgInhpbGlueCIKLSAgICAgKCJeRVJST1I6SERMUGFyc2VyczpbMC05XSsg LSBcIlxcKFteIFx0XG5dK1xcKVwiIExpbmUgXFwoWzAtOV0rXFwpXFwuIiAxIDIgbmlsKSAoIiIg MCkKKyAgICAgKCJeRVJST1I6SERMUGFyc2VyczpbMC05XSsgLSBcIlxcKFteIFx0XG5dK1xcKVwi IExpbmUgXFwoWzAtOV0rXFwpXFwuIiAxIDIgbmlsIDIpICgiIiAwKQogICAgICBuaWwpCiAgICAg OzsgWGlsaW54IFZpdmFkbzoKICAgICA7OyBFUlJPUjogW1ZSRkMgMTAtMTQxMl0gc3ludGF4IGVy cm9yIG5lYXIgb19pZGxlIFt0ZXN0LnZoZDoyM10KICAgICAoIlhpbGlueCBWaXZhZG8iICJ4dmhk bCIgIiIgIm1ha2UiICItZiBcXDEiCi0gICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrIiAi TWFrZWZpbGUiICJ2aXZhZG8iCisgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1h a2VmaWxlIiAidml2YWRvIgogICAgICAoIl5cXCg/OlxcKD8xOkVSUk9SXFwpXFx8XFwoPzI6V0FS TklOR1xcKVxcfFxcKD8zOklORk9cXClcXCk6IFxcKC4rXFwpIFxcW1xcKD80OlteIFx0XG5dK1xc KTpcXCg/NTpbMC05XStcXClcXF0iIDQgNSBuaWwgKDIgLiAzKSkgKCIiIDApCiAgICAgICgiXFwx L2VudGl0eSIgIlxcMi9cXDEiICJcXDEvY29uZmlndXJhdGlvbiIKICAgICAgICJcXDEvcGFja2Fn ZSIgIlxcMS9ib2R5IiBkb3duY2FzZSkpCkBAIC00MTQsNiArNDE0LDEzIEBAIHZoZGwtY29tcGls ZXItYWxpc3QKICAgRmlsZSBzdWJleHAgaW5kZXg6IGluZGV4IG9mIHN1YmV4cHJlc3Npb24gdGhh dCBtYXRjaGVzIHRoZSBmaWxlIG5hbWUKICAgTGluZSBzdWJleHAgaW5kZXg6IGluZGV4IG9mIHN1 YmV4cHJlc3Npb24gdGhhdCBtYXRjaGVzIHRoZSBsaW5lIG51bWJlcgogICBDb2x1bW4gc3ViZXhw IGlkeDogaW5kZXggb2Ygc3ViZXhwcmVzc2lvbiB0aGF0IG1hdGNoZXMgdGhlIGNvbHVtbiBudW1i ZXIKKyAgVHlwZSBzdWJleHAgICAgICA6IG1lc3NhZ2UgdHlwZSwgY2FuIGJlIDIgZm9yIGEgcmVh bCBlcnJvciwgMSBmb3Igd2FybmluZyBvcgorICAgICAgICAgICAgICAgICAgICAgMCBmb3IgaW5m by4gQ2FuIGFsc28gYmUgb2YgdGhlIGZvcm0gKFdBUk5JTkcgLiBJTkZPKS4gIEluCisgICAgICAg ICAgICAgICAgICAgICB0aGF0IGNhc2UgdGhpcyB3aWxsIGJlIGVxdWl2YWxlbnQgdG8gMSBpZiB0 aGUgV0FSTklOR+KAmXRoCisgICAgICAgICAgICAgICAgICAgICBzdWJleHByZXNzaW9uIG1hdGNo ZWQgb3IgZWxzZSBlcXVpdmFsZW50IHRvIDAgaWYgdGhlCisgICAgICAgICAgICAgICAgICAgICBJ TkZP4oCZdGggc3ViZXhwcmVzc2lvbiBtYXRjaGVkLCBvciBlbHNlIGVxdWl2YWxlbnQgdG8gMiBp ZgorICAgICAgICAgICAgICAgICAgICAgbmVpdGhlciBvZiB0aGVtIG1hdGNoZWQuIFNlZSBhbHNv CisgICAgICAgICAgICAgICAgICAgICBgY29tcGlsYXRpb24tZXJyb3ItcmVnZXhwLWFsaXN0Jy4K IEZpbGUgbWVzc2FnZToKICAgUmVnZXhwICAgICAgICAgICA6IHJlZ3VsYXIgZXhwcmVzc2lvbiB0 byBtYXRjaCBhIGZpbGUgbmFtZSBtZXNzYWdlCiAgIEZpbGUgc3ViZXhwIGluZGV4OiBpbmRleCBv ZiBzdWJleHByZXNzaW9uIHRoYXQgbWF0Y2hlcyB0aGUgZmlsZSBuYW1lCkBAIC00ODMsNyArNDkw LDEyIEBAIHZoZGwtY29tcGlsZXItYWxpc3QKIAkJICAgICAgKGludGVnZXIgOnRhZyAiTGluZSBz dWJleHAgaW5kZXgiKQogCQkgICAgICAoY2hvaWNlICA6dGFnICJDb2x1bW4gc3ViZXhwICAgICIK IAkJCSAgICAgIChpbnRlZ2VyIDp0YWcgIkluZGV4IikKLQkJCSAgICAgIChjb25zdCA6dGFnICJO byBjb2x1bW4gbnVtYmVyIiBuaWwpKSkKKwkJCSAgICAgIChjb25zdCA6dGFnICJObyBjb2x1bW4g bnVtYmVyIiBuaWwpKQorCQkJICAgIChjaG9pY2UgIDp0YWcgIlR5cGUgICAgIgorCQkJICAgICAg KGNvbnN0IDp0YWcgIkluZm8iIDApCisJCQkgICAgICAoY29uc3QgOnRhZyAiV2FybmluZyIgMSkK KwkJCSAgICAgIChjb25zdCA6dGFnICJFcnJvciIgbmlsKQorCQkJICAgICAgKHNleHAgOnRhZyAi KFdBUk5JTkcgLiBJTkZPKSIpKSkKIAkJKGxpc3QgOnRhZyAiRmlsZSBtZXNzYWdlIiA6aW5kZW50 IDQKIAkJICAgICAgKHJlZ2V4cCAgOnRhZyAiUmVnZXhwICAgICAgICAgICAiKQogCQkgICAgICAo aW50ZWdlciA6dGFnICJGaWxlIHN1YmV4cCBpbmRleCIpKQpAQCAtMjQ1MSw2ICsyNDYzLDE1IEBA IHZoZGwtcHJpbnQtd2FybmluZ3MKICAgICAgIChzZXRxIHRtcC1hbGlzdCAoY2RyIHRtcC1hbGlz dCkpKSkKICAgKGN1c3RvbWl6ZS1zYXZlLXZhcmlhYmxlICd2aGRsLWNvbXBpbGVyLWFsaXN0IHZo ZGwtY29tcGlsZXItYWxpc3QpKQogCis7OyBvcHRpb24gYHZoZGwtY29tcGlsZXItYWxpc3QnIGNo YW5nZWQgZm9ybWF0ICgzLjM4LjEpCisod2hlbiAoPSAobGVuZ3RoIChudGggMTEgKGNhciB2aGRs LWNvbXBpbGVyLWFsaXN0KSkpIDQpCisgIChsZXQgKCh0bXAtYWxpc3QgdmhkbC1jb21waWxlci1h bGlzdCkpCisgICAgKHdoaWxlIHRtcC1hbGlzdAorICAgICAgKHNldGNkciAobnRoY2RyIDMgKG50 aCAxMSAoY2FyIHRtcC1hbGlzdCkpKQorCSAgICAgICcoMiAuIG5pbCkpCisgICAgICAoc2V0cSB0 bXAtYWxpc3QgKGNkciB0bXAtYWxpc3QpKSkpCisgIChjdXN0b21pemUtc2F2ZS12YXJpYWJsZSAn dmhkbC1jb21waWxlci1hbGlzdCB2aGRsLWNvbXBpbGVyLWFsaXN0KSkKKwogOzsgb3B0aW9uIGB2 aGRsLXByb2plY3QnOiBlbXB0eSB2YWx1ZSBjaGFuZ2VkIGZyb20gIiIgdG8gbmlsICgzLjMxLjEp CiAod2hlbiAoZXF1YWwgdmhkbC1wcm9qZWN0ICIiKQogICAoc2V0cSB2aGRsLXByb2plY3Qgbmls KQo= --_004_AS4PR10MB6110088E0C21389B12DDCB89E3709AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 11:56:55 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 15:56:55 +0000 Received: from localhost ([127.0.0.1]:38236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvgko-0003sw-W6 for submit@debbugs.gnu.org; Sun, 07 May 2023 11:56:55 -0400 Received: from mail-am7eur03olkn2100.outbound.protection.outlook.com ([40.92.59.100]:18656 helo=EUR03-AM7-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvgkm-0003sh-Cp for 63251@debbugs.gnu.org; Sun, 07 May 2023 11:56:53 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdwFBgnrc+OvMShJ7HK26y+8kFHj9RzjARLENvF6VRSgZUMhhIsp7GlTYT8tCX0zU9m3DZjxsoxtt5989X1GpnwDaAy508UMvw+27frnDUj5wqN8keo+v3KRSY7tSNv1XKx1DGtFPQrg2I/XaItfWzAz4HiVr87b0VPOl/tLfseF5ISuC5qdFtKTz997uYeqmMxMtfykUZG6lrm2CFEv3n1Yp1PXwxOhxm2j2epDd/jHm21nt20ewRBWPfxgqNtLUDONd1U9q2B3Gs9xmj2i/N0Q1b4r01R11oeDa9PqKipnTMN42SAEFVSGKYYujBE2E8Wg78f2WiG6fCNoFnXxcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lyQJ4Dt86qGUN7LRN0UfjYyFAp5WsMTVbqAMYsXFfs0=; b=LRmr8cF0XsxMwmodM3fIzI69NRpVmMXmmIFy5y/uksGpl4eLHAraMqTcI2xD2pZ7kQOTo81hwggGO1jb/JdTBJHQe1Ox6fIj1Sr68SKy+lsNF366YMlarJuPfW50x5XSXOdnrqLxIqPsgAmzjyMoXrtBrPy3SmsNOITc3p5FpjeZmTcUHBItIDaftMeI9zpiLCIhG3sHpoIpFllbp+Zeusrjc0WZd9gHzzWqxX7Axpnb4n4edmajp8jFK6aDaIJUeKDTckaZHJOqGUFNELEfustJ1zvdDwaqzUtujNZxPHl0W100f+Wq2wzfj7AmG3zC3MdmIB8nhdgdwiEjvPzTVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lyQJ4Dt86qGUN7LRN0UfjYyFAp5WsMTVbqAMYsXFfs0=; b=U0hxV35TtzCLpL5tbVMfIR/dqkjjJJ512/pRcLtEet4xXiFYUQskTgFWmVvFlDGVIOvo136O+amrwh/Bdjc7WB/Vg1s17fbhHEcXCIzjmB6FbUdGtpO1mO5cK7iCXNWdUJ5rGwenHYBeiR1AFAL4CQmFSbclYFJok3UBmySPg5gSEcXi7/iOw/larAl6s3P/tRZu1C5RC1GS89TerTphzmn1POssLEhgg8WfWuq6NltrSp20dEq/HfBHwq7wkd5MbP2TO65fUw74eRy02e+8NKuvFTqV65N6++7ByUYfoIXr0G6zBI6HtZePzfkBuVVnRZGgohE1vkfWe5OVwQjWdQ== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by VI1PR10MB3503.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:13e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Sun, 7 May 2023 15:56:45 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.031; Sun, 7 May 2023 15:56:45 +0000 From: Cyril Arnould To: =?Windows-1252?Q?Mattias_Engdeg=E5rd?= Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj7+AAK+qgIAAgDLx Date: Sun, 7 May 2023 15:56:45 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> In-Reply-To: <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [kOtOVl4bY2ELfmuyrdJfu+vtL8xumJRq] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|VI1PR10MB3503:EE_ x-ms-office365-filtering-correlation-id: b2c63c75-407a-4f27-3194-08db4f13a882 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aVDqeP6jKUSMQZR7Qe4e3G1jKCXcfZN4dqLXqtZpuTL8IfDtttzq3/JzaSxh/DUPW14nA4sd56AR7f36ZqSScwmkjc3ITQj+D47fTtW0FttOG3Ec5Np8I2OG81zrCv1iCTGTWUxn472e4Bfi0aigddj9fvd6sJ/Z38X9DXhT19nStVRT70jztsQkauVW5vQKmgF7FMZybcpzfmlBxMYGMcFJMlELXyYR6GHg5dSp78fkgL4nfluGwGeXxzTGO4tByBgf5x59TNmRRwogizfKQrBJvKuhBsW1PZ5n6cYC4q34fEKBygpN6CA/fmlmaAYdop2l3cKM8P0VyvpY7wXf2jBhBXH3OFH+fVjFqqzsCPvTQWcw2LC3tkiRhQyQ7wk/ojBzi8BOiibrhaPH9xUNs0FyXAxN5mmBFl2z+oOQNcvbuCXosHWtiwnSITMjaCNNHH+ceBajKC54BMbR8SHnchWeeIpzzh0U7m6W4KX+ywIg4mRpZ+4Krj4FjhQQ1H14w1ufsreB8PfD7eQiThgGF7nVwVVDlaQVBk3P+tAAxx+hvk1Ld0vMjYrb+DRm8GKM x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?s8EBjBcoHmLDUDqIDuGE4UW7rajZ7WPKVHhIPtdCI6oikBUGa6T5fOw0?= =?Windows-1252?Q?aElO7Gsb9hkoEbQVBGPjZWpbfzW8dEvf+KAt0EgB/HrbOoq/gLT77GdN?= =?Windows-1252?Q?ff/sXlAVMG7ARzsUKhafhUZPilX6zimNaH/vHrauJFg+3htoQraYwgxV?= =?Windows-1252?Q?b8nNmzx+nz9dUAPZXFFWzbmSnM0d7wiDdq4J2N2wrFvp857msHuKeW7M?= =?Windows-1252?Q?ckVBKHtis00mXSk8R5lnSJ6B6hzq4tdDKL1XwhKbmNSjzvQmALT4moBP?= =?Windows-1252?Q?sMn75D7y5QM5s/4Li5cJ9+pDcQ2S7E1EAVoQPaPtmPf8gYuznX5Fsc+W?= =?Windows-1252?Q?yzRaHq5C6XDPoU3YP2THK2gmiWfDrQyqhWjEgpYAp/TTB0EPQKhbqsdp?= =?Windows-1252?Q?nJa/uHdA1ZwNQTUtEj89vI9xEsi2P50ONPx6Mm2WhtnPH9m/kSeva7A8?= =?Windows-1252?Q?oQXhMqOSCfV5NW4JY7IvHtt0ib+Yd7ItVQv8Mt/h4kdFhILmSW/DV226?= =?Windows-1252?Q?ynOk6VHpV4F/d1+7rZQVByzg4OeipC9vnqUS56cQr8s3PqApOmCBcCpq?= =?Windows-1252?Q?2v2bh3jj9rjxaJUydI/z4QLxSVbu17rls/oJKUO9FGshbrxyLcB+ci8G?= =?Windows-1252?Q?gN/GLOVjuqhQXRDDKS+6r/9mfDnbj7j+1L1GXBs4ixG8MRHUAfur5mgx?= =?Windows-1252?Q?klgteHcse5HVjebc/4NdlbHncC4LHIYYeT/PdKgXRkKyG4TwFxAubclt?= =?Windows-1252?Q?SJfRDb8kqCKeE4rrqNMr6LZyXU+fJtfMU4Wf2tqsI8k26xey23Pd9dp8?= =?Windows-1252?Q?pEbqGavFRLsifIyN88kriCwBeHFis6s/rst1vPlZj0TQ7sCJ28dwDxyL?= =?Windows-1252?Q?5y1xgTA7v4HxJ+YadwJVsjb0ty7sTbRXWch0KP0tfr5wOOOJ3cCf3wcb?= =?Windows-1252?Q?p/mm0+4GDlfeiveDhg5q3TeAst+mJwUEGN2b/lmGqaF2EtS4npS/ka6l?= =?Windows-1252?Q?cNCxid76ySi/UQp3UV+O4+IHnYOwUFqm3r1BwY04Uvk5YAjg4ruLNxwj?= =?Windows-1252?Q?D0PLqYwc7MnLycg70Ob+yhC//YKyShaS6M6JIEPAH3ns3G/wfsLx0eFQ?= =?Windows-1252?Q?8kfIVTLo/vEfddFc0SkzswrpOUgtXvbKqhBZ1VIMNjP4FQP6g8CbPIuV?= =?Windows-1252?Q?j5wcP4RPcAED2NXstzoCkea9f/PZ9yRxqPYY8tDTcO8N+DNrWnb2ndgF?= =?Windows-1252?Q?2TMmKAYKIRSdsOxkmY8mNtMYPhMl05jDCdEd77ebo+Tj2ayOcDhiY4Ho?= =?Windows-1252?Q?7D2/xl1wzozcGTkt7UZ3IiFPTgjGIkXVisb+FbSLdQlQm6K/?= Content-Type: multipart/mixed; boundary="_004_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b2c63c75-407a-4f27-3194-08db4f13a882 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 15:56:45.2796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3503 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_004_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_ Content-Type: multipart/alternative; boundary="_000_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_" --_000_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Very sorry, I just noticed that I messed up the previous patch. Third time= =92s the charm. ________________________________ Von: Mattias Engdeg=E5rd im Auftrag von Mattia= s Engdeg=E5rd Gesendet: Sunday, May 7, 2023 10:17:03 AM An: Cyril Arnould Cc: 63251@debbugs.gnu.org <63251@debbugs.gnu.org>; Reto Zimmermann ; Eli Zaretskii Betreff: Re: bug#63251: 28.2; vhdl-mode contribution The vhdl-mode maintainers need to look at your patch more closely; I just h= ave some minor remarks. 7 maj 2023 kl. 00.11 skrev Cyril Arnould : > - I've added TYPE to the vhdl-compiler definition with the > appropriate choices for Info/Warning/Error and the dotted > pair. I'm not sure if sexp was the correct choice for the > dotted pair, is there a better alternative? There is (cons ...) which would be more precise, see the manual. The new doc string says that a TYPE of 2 is allowed but the type spec doesn= 't allow it. Either allow both 2 and nil or change the docs to only mention one of them. > - I added another entry to the backwards compatibility code, all > it took was a slight modification of the entry before > that. That's fine, but I'd be a bit more careful with the destructive in-place ch= anges and quoted list constants. (Think of what happens if later code perfo= rms an in-place change of that nil you added.) This isn't performance-critical-code, we can afford consing here. --_000_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Very sorry, I just noticed that I messed up the prev= ious patch. Third time=92s the charm.

 


Von: Mattias Engdeg=E5rd &l= t;mattiasengdegard@gmail.com> im Auftrag von Mattias Engdeg=E5rd <mat= tias.engdegard@gmail.com>
Gesendet: Sunday, May 7, 2023 10:17:03 AM
An: Cyril Arnould <cyril.arnould@outlook.com>
Cc: 63251@debbugs.gnu.org <63251@debbugs.gnu.org>; Reto Zimmer= mann <reto@gnu.org>; Eli Zaretskii <eliz@gnu.org>
Betreff: Re: bug#63251: 28.2; vhdl-mode contribution
 
The vhdl-mode maintainers need to look at your pat= ch more closely; I just have some minor remarks.

7 maj 2023 kl. 00.11 skrev Cyril Arnould <cyril.arnould@outlook.com>:=

> - I've added TYPE to the vhdl-compiler definition with the
>   appropriate choices for Info/Warning/Error and the dotted<= br> >   pair. I'm not sure if sexp was the correct choice for the<= br> >   dotted pair, is there a better alternative?

There is (cons ...) which would be more precise, see the manual.

The new doc string says that a TYPE of 2 is allowed but the type spec doesn= 't allow it.
Either allow both 2 and nil or change the docs to only mention one of them.=

> - I added another entry to the backwards compatibility code, all
>   it took was a slight modification of the entry before
>   that.

That's fine, but I'd be a bit more careful with the destructive in-place ch= anges and quoted list constants. (Think of what happens if later code perfo= rms an in-place change of that nil you added.)
This isn't performance-critical-code, we can afford consing here.

--_000_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_-- --_004_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_ Content-Type: application/octet-stream; name="fix-vhdl-compiler-customization-3.patch" Content-Description: fix-vhdl-compiler-customization-3.patch Content-Disposition: attachment; filename="fix-vhdl-compiler-customization-3.patch"; size=12141; creation-date="Sun, 07 May 2023 15:55:57 GMT"; modification-date="Sun, 07 May 2023 15:55:57 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCAiYS9saXNwL3Byb2dtb2Rlcy92aGRsLW1vZGUuZWwiICJiL2xpc3AvcHJvZ21v ZGVzL3ZoZGwtbW9kZS5lbCIKaW5kZXggZWUwZWM2M2I2YmMuLmNkYWFmNDI3N2VlIDEwMDY0NAot LS0gImEvbGlzcC9wcm9nbW9kZXMvdmhkbC1tb2RlLmVsIgorKysgImIvbGlzcC9wcm9nbW9kZXMv dmhkbC1tb2RlLmVsIgpAQCAtMjI5LDIwICsyMjksMjAgQEAgdmhkbC1jb21waWxlci1hbGlzdAog ICAgIDs7IFtFcnJvcl0gQXNzaWdubWVudCBlcnJvcjogdmFyaWFibGUgaXMgaWxsZWdhbCB0YXJn ZXQgb2Ygc2lnbmFsIGFzc2lnbm1lbnQKICAgICAoIkFEVmFuY2UgTVMiICJ2YWNvbSIgIi13b3Jr IFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAidmFsaWIgXFwxOyB2YW1hcCBcXDIgXFwx IiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiYWRtcyIKLSAgICAgKCJeXFxzLStcXChbMC05XStc XCk6XFxzLSsiIG5pbCAxIG5pbCkgKCJeQ29tcGlsaW5nIGZpbGUgXFwoLitcXCkiIDEpCisgICAg ICgiXlxccy0rXFwoWzAtOV0rXFwpOlxccy0rIiBuaWwgMSBuaWwgMikgKCJeQ29tcGlsaW5nIGZp bGUgXFwoLitcXCkiIDEpCiAgICAgICgiRU5USS9cXDEudmlmIiAiQVJDSC9cXDEtXFwyLnZpZiIg IkNPTkYvXFwxLnZpZiIKICAgICAgICJQQUNLL1xcMS52aWYiICJCT0RZL1xcMS52aWYiIHVwY2Fz ZSkpCiAgICAgOzsgQWxkZWMKICAgICA7OyBDT01QOTYgRVJST1IgQ09NUDk2XzAwMTg6ICJJZGVu dGlmaWVyIGV4cGVjdGVkLiIgInRlc3QudmhkIiA2NiAzCiAgICAgKCJBbGRlYyIgInZjb20iICIt d29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgInZsaWIgXFwxOyB2bWFwIFxcMiBc XDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJhbGRlYyIKLSAgICAgKCJeLiogRVJST1IgW146 XSs6IFwiLipcIiBcIlxcKFteIFx0XG5dK1xcKVwiIFxcKFswLTldK1xcKSBcXChbMC05XStcXCki IDEgMiAzKSAoIiIgMCkKKyAgICAgKCJeLiogRVJST1IgW146XSs6IFwiLipcIiBcIlxcKFteIFx0 XG5dK1xcKVwiIFxcKFswLTldK1xcKSBcXChbMC05XStcXCkiIDEgMiAzIDIpICgiIiAwKQogICAg ICBuaWwpCiAgICAgOzsgQ2FkZW5jZSBMZWFwZnJvZzogY3YgLWZpbGUgdGVzdC52aGQKICAgICA7 OyBkdWx1dGg6ICpFLDQzMCAodGVzdC52aGQsMTMpOiBpZGVudGlmaWVyIChQT1NJVElWKSBpcyBu b3QgZGVjbGFyZWQKICAgICAoIkNhZGVuY2UgTGVhcGZyb2ciICJjdiIgIi13b3JrIFxcMSAtZmls ZSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1h a2VmaWxlIiAibGVhcGZyb2ciCi0gICAgICgiXmR1bHV0aDogXFwqRSxbMC05XSsgKFxcKFteIFx0 XG5dK1xcKSxcXChbMC05XStcXCkpOiIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXmR1bHV0aDog XFwqRSxbMC05XSsgKFxcKFteIFx0XG5dK1xcKSxcXChbMC05XStcXCkpOiIgMSAyIG5pbCAyKSAo IiIgMCkKICAgICAgKCJcXDEvZW50aXR5IiAiXFwyL1xcMSIgIlxcMS9jb25maWd1cmF0aW9uIgog ICAgICAgIlxcMS9wYWNrYWdlIiAiXFwxL2JvZHkiIGRvd25jYXNlKSkKICAgICA7OyBDYWRlbmNl IEFmZmlybWEgTkMgdmhkbDogbmN2aGRsIHRlc3QudmhkCkBAIC0yNTAsNyArMjUwLDcgQEAgdmhk bC1jb21waWxlci1hbGlzdAogICAgIDs7IChQTExfNDAwWF9UT1ApIGlzIG5vdCBkZWNsYXJlZCBb MTAuM10uCiAgICAgKCJDYWRlbmNlIE5DIiAibmN2aGRsIiAiLXdvcmsgXFwxIiAibWFrZSIgIi1m IFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJuY3Zo ZGwiCi0gICAgICgiXm5jdmhkbF9wOiBcXCpFLFxcdysgKFxcKFteIFx0XG5dK1xcKSxcXChbMC05 XStcXCl8XFwoWzAtOV0rXFwpKToiIDEgMiAzKSAoIiIgMCkKKyAgICAgKCJebmN2aGRsX3A6IFxc KkUsXFx3KyAoXFwoW14gXHRcbl0rXFwpLFxcKFswLTldK1xcKXxcXChbMC05XStcXCkpOiIgMSAy IDMgMikgKCIiIDApCiAgICAgICgiXFwxL2VudGl0eS9wYy5kYiIgIlxcMi9cXDEvcGMuZGIiICJc XDEvY29uZmlndXJhdGlvbi9wYy5kYiIKICAgICAgICJcXDEvcGFja2FnZS9wYy5kYiIgIlxcMS9i b2R5L3BjLmRiIiBkb3duY2FzZSkpCiAgICAgOzsgZ2hkbCB2aGRsCkBAIC0yNTgsMjEgKzI1OCwy MSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgICAgOzsgYmFkX2NvdW50ZXIudmhkbDoxMzoxNDog b3BlcmF0b3IgIj0iIGlzIG92ZXJsb2FkZWQKICAgICAoIkdIREwiICJnaGRsIiAiLWkgLS13b3Jr ZGlyPVxcMSAtLWllZWU9c3lub3BzeXMgLWZleHBsaWNpdCAiICJtYWtlIiAiLWYgXFwxIgogICAg ICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgImdoZGwiCi0gICAgICgi XmdoZGxfcDogXFwqRSxcXHcrIChcXChbXiBcdFxuXStcXCksXFwoWzAtOV0rXFwpfFxcKFswLTld K1xcKSk6IiAxIDIgMykgKCIiIDApCisgICAgICgiXmdoZGxfcDogXFwqRSxcXHcrIChcXChbXiBc dFxuXStcXCksXFwoWzAtOV0rXFwpfFxcKFswLTldK1xcKSk6IiAxIDIgMyAyKSAoIiIgMCkKICAg ICAgKCJcXDEvZW50aXR5IiAiXFwyL1xcMSIgIlxcMS9jb25maWd1cmF0aW9uIgogICAgICAgIlxc MS9wYWNrYWdlIiAiXFwxL2JvZHkiIGRvd25jYXNlKSkKICAgICA7OyBJQk0gQ29tcGlsZXIKICAg ICA7OyAwMCBDT0FDSERMKiB8IFtDQ0hETC0xXTogRmlsZTogYWRkZXIudmhkLCBsaW5lLmNvbHVt bjogMTIwLjYKICAgICAoIklCTSBDb21waWxlciIgImcydHZjIiAiLXNyYyIgInByZWNvbXAiICJc XDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiaWJtIgot ICAgICAoIl5bMC05XSsgQ09BQ0hETC4qOiBGaWxlOiBcXChbXiBcdFxuXStcXCksICpsaW5lLmNv bHVtbjogXFwoWzAtOV0rXFwpLlxcKFswLTldK1xcKSIgMSAyIDMpICgiICIgMCkKKyAgICAgKCJe WzAtOV0rIENPQUNIREwuKjogRmlsZTogXFwoW14gXHRcbl0rXFwpLCAqbGluZS5jb2x1bW46IFxc KFswLTldK1xcKS5cXChbMC05XStcXCkiIDEgMiAzIDIpICgiICIgMCkKICAgICAgbmlsKQogICAg IDs7IElrb3MgVm95YWdlcjogYW5hbHl6ZSB0ZXN0LnZoZAogICAgIDs7IGFuYWx5emUgdGVzdC52 aGQKICAgICA7OyBFIEw0L0M1OiAgICAgICAgdGhpcyBsaWJyYXJ5IHVuaXQgaXMgaW5hY2Nlc3Np YmxlCiAgICAgKCJJa29zIiAiYW5hbHl6ZSIgIi1sIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAg IG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAiaWtvcyIKLSAgICAgKCJe RSBMXFwoWzAtOV0rXFwpL0NcXChbMC05XStcXCk6IiBuaWwgMSAyKQorICAgICAoIl5FIExcXChb MC05XStcXCkvQ1xcKFswLTldK1xcKToiIG5pbCAxIDIgMikKICAgICAgKCJeYW5hbHl6ZSArXFwo LisgK1xcKSpcXCguK1xcKSQiIDIpCiAgICAgIG5pbCkKICAgICA7OyBNb2RlbFNpbSwgTW9kZWwg VGVjaG5vbG9neTogdmNvbSB0ZXN0LnZoZApAQCAtMjk0LDcgKzI5NCw3IEBAIHZoZGwtY29tcGls ZXItYWxpc3QKICAgICA7OyB0ZXN0LnZoZDozNDogZXJyb3IgbWVzc2FnZQogICAgICgiTEVEQSBQ cm9WSERMIiAicHJvdmhkbCIgIi13IFxcMSAtZiIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAi bWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAicHJvdmhkbCIKLSAgICAgKCJeXFwo W14gXHRcbjpdK1xcKTpcXChbMC05XStcXCk6ICIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXlxc KFteIFx0XG46XStcXCk6XFwoWzAtOV0rXFwpOiAiIDEgMiBuaWwgMikgKCIiIDApCiAgICAgICgi RU5USS9cXDEudmlmIiAiQVJDSC9cXDEtXFwyLnZpZiIgIkNPTkYvXFwxLnZpZiIKICAgICAgICJQ QUNLL1xcMS52aWYiICJCT0RZL0JPRFktXFwxLnZpZiIgdXBjYXNlKSkKICAgICA7OyBRdWFydHVz IGNvbXBpbGVyCkBAIC0zMDUsMjEgKzMwNSwyMSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgICAg OzsgV2FybmluZzogVkhETCBQcm9jZXNzIFN0YXRlbWVudCB3YXJuaW5nIGF0IGR2aTJzZGlfdHN0 LnZoZCgxNzIpOiAuLi4KICAgICAoIlF1YXJ0dXMiICJtYWtlIiAiLXdvcmsgXFwxIiAibWFrZSIg Ii1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJx dWFydHVzIgotICAgICAoIl5cXChFcnJvclxcfFdhcm5pbmdcXCk6IC4qIFxcKFteIFx0XG5dK1xc KShcXChbMC05XStcXCkpIiAyIDMgbmlsKSAoIiIgMCkKKyAgICAgKCJeXFwoRXJyb3JcXHxXYXJu aW5nXFwpOiAuKiBcXChbXiBcdFxuXStcXCkoXFwoWzAtOV0rXFwpKSIgMiAzIG5pbCAyKSAoIiIg MCkKICAgICAgbmlsKQogICAgIDs7IFF1aWNrSERMLCBNZW50b3IgR3JhcGhpY3M6IHF2aGNvbSB0 ZXN0LnZoZAogICAgIDs7IEVSUk9SOiB0ZXN0LnZoZCgyNCk6IG5lYXIgImRuZCI6IGV4cGVjdGlu ZzogRU5ECiAgICAgOzsgV0FSTklOR1s0XTogdGVzdC52aGQoMzApOiBBIHNwYWNlIGlzIHJlcXVp cmVkIGJldHdlZW4gLi4uCiAgICAgKCJRdWlja0hETCIgInF2aGNvbSIgIi13b3JrIFxcMSIgIm1h a2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxl IiAicXVpY2toZGwiCi0gICAgICgiXlxcKEVSUk9SXFx8V0FSTklOR1xcKVteOl0qOiBcXChbXiBc dFxuXStcXCkoXFwoWzAtOV0rXFwpKToiIDIgMyBuaWwpICgiIiAwKQorICAgICAoIl5cXChFUlJP UlxcfFdBUk5JTkdcXClbXjpdKjogXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSk6IiAyIDMg bmlsIDIpICgiIiAwKQogICAgICAoIlxcMS9fcHJpbWFyeS5kYXQiICJcXDIvXFwxLmRhdCIgIlxc MS9fcHJpbWFyeS5kYXQiCiAgICAgICAiXFwxL19wcmltYXJ5LmRhdCIgIlxcMS9ib2R5LmRhdCIg ZG93bmNhc2UpKQogICAgIDs7IFNhdmFudDogc2NyYW0gLXB1Ymxpc2gtY2MgdGVzdC52aGQKICAg ICA7OyB0ZXN0LnZoZDo4NzogX3NldF9wYXNzZWRfdGhyb3VnaF9vdXRfcG9ydChJSVJfQm9vbGVh bikgbm90IGRlZmluZWQgZm9yCiAgICAgKCJTYXZhbnQiICJzY3JhbSIgIi1wdWJsaXNoLWNjIC1k ZXNpZ24tbGlicmFyeS1uYW1lIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIg XFwxIiAiLi8iICJ3b3JrLl9zYXZhbnRfbGliLyIgIk1ha2VmaWxlIiAic2F2YW50IgotICAgICAo Il5cXChbXiBcdFxuOl0rXFwpOlxcKFswLTldK1xcKTogIiAxIDIgbmlsKSAoIiIgMCkKKyAgICAg KCJeXFwoW14gXHRcbjpdK1xcKTpcXChbMC05XStcXCk6ICIgMSAyIG5pbCAyKSAoIiIgMCkKICAg ICAgKCJcXDFfZW50aXR5LnZoZGwiICJcXDJfc2Vjb25kYXJ5X3VuaXRzLl9zYXZhbnRfbGliL1xc Ml9cXDEudmhkbCIKICAgICAgICJcXDFfY29uZmlnLnZoZGwiICJcXDFfcGFja2FnZS52aGRsIgog ICAgICAgIlxcMV9zZWNvbmRhcnlfdW5pdHMuX3NhdmFudF9saWIvXFwxX3BhY2thZ2VfYm9keS52 aGRsIiBkb3duY2FzZSkpCkBAIC0zMjcsMzkgKzMyNywzOSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0 CiAgICAgOzsgRXJyb3I6IENTVkhETDAwMDI6IHRlc3QudmhkOiAobGluZSA5Nyk6IEludmFsaWQg cHJlZml4CiAgICAgKCJTaW1pbGkiICJ2aGRscCIgIi13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEi CiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAic2ltaWxpIgot ICAgICAoIl5cXChFcnJvclxcfFdhcm5pbmdcXCk6IFxcdys6IFxcKFteIFx0XG5dK1xcKTogKGxp bmUgXFwoWzAtOV0rXFwpKTogIiAyIDMgbmlsKSAoIiIgMCkKKyAgICAgKCJeXFwoRXJyb3JcXHxX YXJuaW5nXFwpOiBcXHcrOiBcXChbXiBcdFxuXStcXCk6IChsaW5lIFxcKFswLTldK1xcKSk6ICIg MiAzIG5pbCAyKSAoIiIgMCkKICAgICAgKCJcXDEvcHJpbS52YXIiICJcXDIvX1xcMS52YXIiICJc XDEvcHJpbS52YXIiCiAgICAgICAiXFwxL3ByaW0udmFyIiAiXFwxL19ib2R5LnZhciIgZG93bmNh c2UpKQogICAgIDs7IFNwZWVkd2F2ZSAoSW5ub3ZlZGEpOiBhbmFseXplIC1saWJmaWxlIHZzc2xp Yi5pbmkgLXNyYyB0ZXN0LnZoZAogICAgIDs7ICAgICBFUlJPUlsxMV06OkZpbGUgdGVzdC52aGQg TGluZSAxMDA6IFVzZSBvZiB1bmRlY2xhcmVkIGlkZW50aWZpZXIKICAgICAoIlNwZWVkd2F2ZSIg ImFuYWx5emUiICItbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMiICJtYWtlIiAiLWYgXFwxIgogICAg ICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInNwZWVkd2F2ZSIKLSAg ICAgKCJeICpFUlJPUlxcW1swLTldK106OkZpbGUgXFwoW14gXHRcbl0rXFwpIExpbmUgXFwoWzAt OV0rXFwpOiIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXiAqRVJST1JcXFtbMC05XStdOjpGaWxl IFxcKFteIFx0XG5dK1xcKSBMaW5lIFxcKFswLTldK1xcKToiIDEgMiBuaWwgMikgKCIiIDApCiAg ICAgIG5pbCkKICAgICA7OyBTeW5vcHN5cywgVkhETCBBbmFseXplciAoc2ltKTogdmhkbGFuIC1u YyB0ZXN0LnZoZAogICAgIDs7ICoqRXJyb3I6IHZoZGxhbiw3MDMgdGVzdC52aGQoMjIpOiBPVEhF UlMgaXMgbm90IGxlZ2FsIGluIHRoaXMgY29udGV4dC4KICAgICAoIlN5bm9wc3lzIiAidmhkbGFu IiAiLW5jIC13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAi Li8iICJ3b3JrLyIgIk1ha2VmaWxlIiAic3lub3BzeXMiCi0gICAgICgiXlxcKlxcKkVycm9yOiB2 aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIgMSAyIG5pbCkgKCIi IDApCisgICAgICgiXlxcKlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShc XChbMC05XStcXCkpOiIgMSAyIG5pbCAyKSAoIiIgMCkKICAgICAgKCJcXDEuc2ltIiAiXFwyX19c XDEuc2ltIiAiXFwxLnNpbSIgIlxcMS5zaW0iICJcXDFfXy5zaW0iIHVwY2FzZSkpCiAgICAgOzsg U3lub3BzeXMsIFZIREwgQW5hbHl6ZXIgKHN5bik6IHZoZGxhbiAtbmMgLXNwYyB0ZXN0LnZoZAog ICAgIDs7ICoqRXJyb3I6IHZoZGxhbiw3MDMgdGVzdC52aGQoMjIpOiBPVEhFUlMgaXMgbm90IGxl Z2FsIGluIHRoaXMgY29udGV4dC4KICAgICAoIlN5bm9wc3lzIERlc2lnbiBDb21waWxlciIgInZo ZGxhbiIgIi1uYyAtc3BjIC13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtk aXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAic3lub3BzeXNfZGMiCi0gICAgICgiXlxc KlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIg MSAyIG5pbCkgKCIiIDApCisgICAgICgiXlxcKlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFte IFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIgMSAyIG5pbCAyKSAoIiIgMCkKICAgICAgKCJcXDEu c3luIiAiXFwyX19cXDEuc3luIiAiXFwxLnN5biIgIlxcMS5zeW4iICJcXDFfXy5zeW4iIHVwY2Fz ZSkpCiAgICAgOzsgU3lucGxpZnk6CiAgICAgOzsgQFc6InRlc3QudmhkIjo1Nzo4OjU3Ojl8T3B0 aW1pemluZyByZWdpc3RlciBiaXQgY291bnRfeCg1KSB0byBhIGNvbnN0YW50IDAKICAgICAoIlN5 bnBsaWZ5IiAibi9hIiAibi9hIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEi ICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJzeW5wbGlmeSIKLSAgICAgKCJeQFtFV05dOlwiXFwo W14gXHRcbl0rXFwpXCI6XFwoWzAtOV0rXFwpOlxcKFswLTldK1xcKToiIDEgMiAzKSAoIiIgMCkK KyAgICAgKCJeQFtFV05dOlwiXFwoW14gXHRcbl0rXFwpXCI6XFwoWzAtOV0rXFwpOlxcKFswLTld K1xcKToiIDEgMiAzIDIpICgiIiAwKQogICAgICBuaWwpCiAgICAgOzsgVmFudGFnZTogYW5hbHl6 ZSAtbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMgdGVzdC52aGQKICAgICA7OyAgICAgQ29tcGlsaW5n ICJ0ZXN0LnZoZCIgbGluZSAxLi4uCiAgICAgOzsgKipFcnJvcjogTElORSA0OSAqKiogTm8gYWdn cmVnYXRlIHZhbHVlIGlzIHZhbGlkIGluIHRoaXMgY29udGV4dC4KICAgICAoIlZhbnRhZ2UiICJh bmFseXplIiAiLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIiAibWFrZSIgIi1mIFxcMSIKICAgICAg bmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJ2YW50YWdlIgotICAgICAo Il5cXCpcXCpFcnJvcjogTElORSBcXChbMC05XStcXCkgXFwqXFwqXFwqIiBuaWwgMSBuaWwpCisg ICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoiIG5pbCAxIG5p bCAyKQogICAgICAoIl4gKkNvbXBpbGluZyBcIlxcKC4rXFwpXCIgIiAxKQogICAgICBuaWwpCiAg ICAgOzsgVmVyaUJlc3Q6IHZjIHZoZGwgdGVzdC52aGQKQEAgLTM2OSwyNiArMzY5LDI2IEBAIHZo ZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyBbRXJyb3JdIE5hbWUgQklUQSBpcyB1bmtub3duCiAg ICAgKCJWZXJpQmVzdCIgInZjIiAidmhkbCIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtk aXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAidmVyaWJlc3QiCi0gICAgICgiXiArXFwo WzAtOV0rXFwpOiArW14gXSIgbmlsIDEgbmlsKSAoIiIgMCkKKyAgICAgKCJeICtcXChbMC05XStc XCk6ICtbXiBdIiBuaWwgMSBuaWwgMikgKCIiIDApCiAgICAgIG5pbCkKICAgICA7OyBWaWV3bG9n aWM6IGFuYWx5emUgLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIHRlc3QudmhkCiAgICAgOzsgICAg IENvbXBpbGluZyAidGVzdC52aGQiIGxpbmUgMS4uLgogICAgIDs7ICoqRXJyb3I6IExJTkUgNDkg KioqIE5vIGFnZ3JlZ2F0ZSB2YWx1ZSBpcyB2YWxpZCBpbiB0aGlzIGNvbnRleHQuCiAgICAgKCJW aWV3bG9naWMiICJhbmFseXplIiAiLWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIiAibWFrZSIgIi1m IFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJ2aWV3 bG9naWMiCi0gICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoi IG5pbCAxIG5pbCkKKyAgICAgKCJeXFwqXFwqRXJyb3I6IExJTkUgXFwoWzAtOV0rXFwpIFxcKlxc KlxcKiIgbmlsIDEgbmlsIDIpCiAgICAgICgiXiAqQ29tcGlsaW5nIFwiXFwoLitcXClcIiAiIDEp CiAgICAgIG5pbCkKICAgICA7OyBYaWxpbnggWFNUOgogICAgIDs7IEVSUk9SOkhETFBhcnNlcnM6 MTY0IC0gInRlc3QudmhkIiBMaW5lIDMuIHBhcnNlIGVycm9yCiAgICAgKCJYaWxpbnggWFNUIiAi eGZsb3ciICIiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29y ay8iICJNYWtlZmlsZSIgInhpbGlueCIKLSAgICAgKCJeRVJST1I6SERMUGFyc2VyczpbMC05XSsg LSBcIlxcKFteIFx0XG5dK1xcKVwiIExpbmUgXFwoWzAtOV0rXFwpXFwuIiAxIDIgbmlsKSAoIiIg MCkKKyAgICAgKCJeRVJST1I6SERMUGFyc2VyczpbMC05XSsgLSBcIlxcKFteIFx0XG5dK1xcKVwi IExpbmUgXFwoWzAtOV0rXFwpXFwuIiAxIDIgbmlsIDIpICgiIiAwKQogICAgICBuaWwpCiAgICAg OzsgWGlsaW54IFZpdmFkbzoKICAgICA7OyBFUlJPUjogW1ZSRkMgMTAtMTQxMl0gc3ludGF4IGVy cm9yIG5lYXIgb19pZGxlIFt0ZXN0LnZoZDoyM10KICAgICAoIlhpbGlueCBWaXZhZG8iICJ4dmhk bCIgIiIgIm1ha2UiICItZiBcXDEiCi0gICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrIiAi TWFrZWZpbGUiICJ2aXZhZG8iCisgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1h a2VmaWxlIiAidml2YWRvIgogICAgICAoIl5cXCg/OlxcKD8xOkVSUk9SXFwpXFx8XFwoPzI6V0FS TklOR1xcKVxcfFxcKD8zOklORk9cXClcXCk6IFxcKC4rXFwpIFxcW1xcKD80OlteIFx0XG5dK1xc KTpcXCg/NTpbMC05XStcXClcXF0iIDQgNSBuaWwgKDIgLiAzKSkgKCIiIDApCiAgICAgICgiXFwx L2VudGl0eSIgIlxcMi9cXDEiICJcXDEvY29uZmlndXJhdGlvbiIKICAgICAgICJcXDEvcGFja2Fn ZSIgIlxcMS9ib2R5IiBkb3duY2FzZSkpCkBAIC00MTQsNiArNDE0LDEzIEBAIHZoZGwtY29tcGls ZXItYWxpc3QKICAgRmlsZSBzdWJleHAgaW5kZXg6IGluZGV4IG9mIHN1YmV4cHJlc3Npb24gdGhh dCBtYXRjaGVzIHRoZSBmaWxlIG5hbWUKICAgTGluZSBzdWJleHAgaW5kZXg6IGluZGV4IG9mIHN1 YmV4cHJlc3Npb24gdGhhdCBtYXRjaGVzIHRoZSBsaW5lIG51bWJlcgogICBDb2x1bW4gc3ViZXhw IGlkeDogaW5kZXggb2Ygc3ViZXhwcmVzc2lvbiB0aGF0IG1hdGNoZXMgdGhlIGNvbHVtbiBudW1i ZXIKKyAgVHlwZSBzdWJleHAgICAgICA6IG1lc3NhZ2UgdHlwZSwgY2FuIGJlIDIgZm9yIGEgcmVh bCBlcnJvciwgMSBmb3Igd2FybmluZyBvcgorICAgICAgICAgICAgICAgICAgICAgMCBmb3IgaW5m by4gQ2FuIGFsc28gYmUgb2YgdGhlIGZvcm0gKFdBUk5JTkcgLiBJTkZPKS4gIEluCisgICAgICAg ICAgICAgICAgICAgICB0aGF0IGNhc2UgdGhpcyB3aWxsIGJlIGVxdWl2YWxlbnQgdG8gMSBpZiB0 aGUgV0FSTklOR+KAmXRoCisgICAgICAgICAgICAgICAgICAgICBzdWJleHByZXNzaW9uIG1hdGNo ZWQgb3IgZWxzZSBlcXVpdmFsZW50IHRvIDAgaWYgdGhlCisgICAgICAgICAgICAgICAgICAgICBJ TkZP4oCZdGggc3ViZXhwcmVzc2lvbiBtYXRjaGVkLCBvciBlbHNlIGVxdWl2YWxlbnQgdG8gMiBp ZgorICAgICAgICAgICAgICAgICAgICAgbmVpdGhlciBvZiB0aGVtIG1hdGNoZWQuIFNlZSBhbHNv CisgICAgICAgICAgICAgICAgICAgICBgY29tcGlsYXRpb24tZXJyb3ItcmVnZXhwLWFsaXN0Jy4K IEZpbGUgbWVzc2FnZToKICAgUmVnZXhwICAgICAgICAgICA6IHJlZ3VsYXIgZXhwcmVzc2lvbiB0 byBtYXRjaCBhIGZpbGUgbmFtZSBtZXNzYWdlCiAgIEZpbGUgc3ViZXhwIGluZGV4OiBpbmRleCBv ZiBzdWJleHByZXNzaW9uIHRoYXQgbWF0Y2hlcyB0aGUgZmlsZSBuYW1lCkBAIC00ODMsNyArNDkw LDEyIEBAIHZoZGwtY29tcGlsZXItYWxpc3QKIAkJICAgICAgKGludGVnZXIgOnRhZyAiTGluZSBz dWJleHAgaW5kZXgiKQogCQkgICAgICAoY2hvaWNlICA6dGFnICJDb2x1bW4gc3ViZXhwICAgICIK IAkJCSAgICAgIChpbnRlZ2VyIDp0YWcgIkluZGV4IikKLQkJCSAgICAgIChjb25zdCA6dGFnICJO byBjb2x1bW4gbnVtYmVyIiBuaWwpKSkKKwkJCSAgICAgIChjb25zdCA6dGFnICJObyBjb2x1bW4g bnVtYmVyIiBuaWwpKQorCQkJICAgIChjaG9pY2UgIDp0YWcgIlR5cGUgICAgIgorCQkJICAgICAg KGNvbnN0IDp0YWcgIkluZm8iIDApCisJCQkgICAgICAoY29uc3QgOnRhZyAiV2FybmluZyIgMSkK KwkJCSAgICAgIChjb25zdCA6dGFnICJFcnJvciIgMikKKwkJCSAgICAgIChzZXhwIDp0YWcgIihX QVJOSU5HIC4gSU5GTykiKSkpCiAJCShsaXN0IDp0YWcgIkZpbGUgbWVzc2FnZSIgOmluZGVudCA0 CiAJCSAgICAgIChyZWdleHAgIDp0YWcgIlJlZ2V4cCAgICAgICAgICAgIikKIAkJICAgICAgKGlu dGVnZXIgOnRhZyAiRmlsZSBzdWJleHAgaW5kZXgiKSkKQEAgLTI0NTEsNiArMjQ2MywxNSBAQCB2 aGRsLXByaW50LXdhcm5pbmdzCiAgICAgICAoc2V0cSB0bXAtYWxpc3QgKGNkciB0bXAtYWxpc3Qp KSkpCiAgIChjdXN0b21pemUtc2F2ZS12YXJpYWJsZSAndmhkbC1jb21waWxlci1hbGlzdCB2aGRs LWNvbXBpbGVyLWFsaXN0KSkKIAorOzsgb3B0aW9uIGB2aGRsLWNvbXBpbGVyLWFsaXN0JyBjaGFu Z2VkIGZvcm1hdCAoMy4zOC4xKQorKHdoZW4gKD0gKGxlbmd0aCAobnRoIDExIChjYXIgdmhkbC1j b21waWxlci1hbGlzdCkpKSA0KQorICAobGV0ICgodG1wLWFsaXN0IHZoZGwtY29tcGlsZXItYWxp c3QpKQorICAgICh3aGlsZSB0bXAtYWxpc3QKKyAgICAgIChzZXRjZHIgKG50aGNkciAzIChudGgg MTEgKGNhciB0bXAtYWxpc3QpKSkKKwkgICAgICAnKDIgLiBuaWwpKQorICAgICAgKHNldHEgdG1w LWFsaXN0IChjZHIgdG1wLWFsaXN0KSkpKQorICAoY3VzdG9taXplLXNhdmUtdmFyaWFibGUgJ3Zo ZGwtY29tcGlsZXItYWxpc3QgdmhkbC1jb21waWxlci1hbGlzdCkpCisKIDs7IG9wdGlvbiBgdmhk bC1wcm9qZWN0JzogZW1wdHkgdmFsdWUgY2hhbmdlZCBmcm9tICIiIHRvIG5pbCAoMy4zMS4xKQog KHdoZW4gKGVxdWFsIHZoZGwtcHJvamVjdCAiIikKICAgKHNldHEgdmhkbC1wcm9qZWN0IG5pbCkK --_004_AS4PR10MB611075814258512E3334EBABE3709AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 12:23:06 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 16:23:06 +0000 Received: from localhost ([127.0.0.1]:38284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvhA9-0004Zv-KI for submit@debbugs.gnu.org; Sun, 07 May 2023 12:23:05 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:46139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvhA8-0004ZC-GL for 63251@debbugs.gnu.org; Sun, 07 May 2023 12:23:04 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4eed764a10cso4021098e87.0 for <63251@debbugs.gnu.org>; Sun, 07 May 2023 09:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683476578; x=1686068578; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=WlC48tDM4pNEeH/gX5J50a0OknifAnXn3WUv7wKH+mI=; b=ARWNux4ItuKCdLuo2Kk87p7blhgXbFJc7pyplfuL2Q1DOTY7wDKmsM4GxuP8r4wFWS gL+D6SWx530TN9tvnqT3jnkuPR7exVsGC0WikHB3mac4/gLJhk4luj+LenqaqVM89wee UJ7z2QkbZFwhcj+PO9BIWekCmdRsIhge8BzUjI9ICcg8j3+P5tP9WrsUuHAq0oxVN6md ejzj1IBf9dffhDk9WggCeE7bcnxZFMuUvcQmcFOdWdto57Hc5mj5MSFYwSnLq5SRubaI DqATwAM7xsRBtYMqvPpmpPgYNSu8M4s2fl6pz4CUO3aryPM0H8OR+lKjWf3jfQ7wzdbN Eznw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683476578; x=1686068578; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WlC48tDM4pNEeH/gX5J50a0OknifAnXn3WUv7wKH+mI=; b=LGmRhdXgK7jZ3UZn2GoHuenYRiBktDIkJWe6G8002XeBnJUa0ABoo8CAptHxgWHmtc 5BMbRotLB6/vlOsooL8C6DfRClQ7ey276xM5MKpRlqu2NFXuSkZ0Pb1NvFmNbQ2r2hBn cDRM8bokCpguHM0QAxS3G4Z1JZ4eqMWhXMZBDdCmJEM2O4QBaQrjIFuFh1a0DgzBi2Xr 9E7G+Ylmxn42q6X0aELuqMF3Z6AbzOlcBcEhBYQVeUUlIPRmheSr8HaMNEDvxy6DAdfP oTKbWszgg+Ds85APOZgXVzdX2DIv/cuSR9u1pM/lxeJsIfQHSw+oErY32cjdQnWuJK0b Zqmw== X-Gm-Message-State: AC+VfDy4eax1bIuQKo8i3Goce6kr5cqLGhdaxvMYLKo1ebPfGZxLzc2C VRsGUJQuocblHRTY+mOWgXA= X-Google-Smtp-Source: ACHHUZ5ar4+rjU/z5vleaLyxVGlceWIT6p0eEnpnX16uuZXxDlQp8s7H1VRDOtsY03dP3I8AdQvrcQ== X-Received: by 2002:a19:a40f:0:b0:4f1:4051:d77b with SMTP id q15-20020a19a40f000000b004f14051d77bmr2149134lfc.60.1683476577791; Sun, 07 May 2023 09:22:57 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id z9-20020ac25de9000000b004eff6c7bc08sm1010843lfq.75.2023.05.07.09.22.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 May 2023 09:22:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63251: 28.2; vhdl-mode contribution From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 7 May 2023 18:22:56 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> To: Cyril Arnould X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 7 maj 2023 kl. 17.40 skrev Cyril Arnould : > I had tried (cons =E2=80=A6) instead of (sexp =E2=80=A6), but that = just resulted in > the customization menu breaking again if one of the compilers was set > to a dotted list. Why would they be set to a dotted list? Can you give an example? I tried (cons :tag "Warning and Info" (natnum :tag "Warning subexp index") (natnum :tag "Info subexp index = ")) instead of the (sexp ...) and it seems to work alright. > > Think of what happens if later code performs an in-place change of = that nil you added. > =20 > I am by no means an expert when it comes to elisp, I don=E2=80=99t = know what > kind of problems this could cause. What I meant was that the code (let ((tmp-alist vhdl-compiler-alist)) (while tmp-alist (setcdr (nthcdr 3 (nth 11 (car tmp-alist))) '(2 . nil)) (setq tmp-alist (cdr tmp-alist)))) modifies the existing list structure instead of creating a new one based = on the old. This can lead to surprises if parts of the structure being = mutated is shared with structure elsewhere. Now this code probably does = work, but it's a bit brittle, and it takes some work for the reader to = understand that it's OK. Contrast it to something like (untested!) (setq vhdl-compiler-alist (mapcar (lambda (entry) ;; Add a `2' to the end of the list that is element = #11. (append (take 11 entry) (append (nth 11 entry) (list 2)) (nthcdr 12 entry))) vhdl-compiler-alist)) where there is no mutation of the list structure, nor any sharing of a = program constant whose accidental mutation might have very confusing = consequences. (`take` is new in Emacs 29 but you can work around it by = using `butlast` instead if the code needs to work with older Emacs = versions.) From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 13:48:58 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 17:48:58 +0000 Received: from localhost ([127.0.0.1]:38390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pviVF-00071z-Kv for submit@debbugs.gnu.org; Sun, 07 May 2023 13:48:58 -0400 Received: from mail-he1eur04olkn2106.outbound.protection.outlook.com ([40.92.73.106]:9859 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pviVD-00071i-5M for 63251@debbugs.gnu.org; Sun, 07 May 2023 13:48:56 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8kI0ZMEpb3La/u0Tp9glLTx9tEQgmAGO3cSAV+ESlkT1OZpRxv7A3rtuSD6ldbiXLaw7kTCvxGv6fyHPOtRfjEojHfqjQB1292h3r8AU1nonyS4KSs3RC+bcVvMgT436GL7gsZkCeeahJ9c6okvjdlnuvHUelYBM29PnccmHwWi4a+VMCsLd+6CMojLDpkNCHkEi21DKThOLNdk+N46D3Ph5ttuvjBtS+f7ix6+n17peu1d4Judr6GxNqUfECtsCgzXX7BBwxuaNYPC2orgt5wHK6E54vISP/OI+T5nB5COu8TiZqAASqaDQQYoLZvlZ7R65mC+3u94wWXUxW6log== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2CqGTnJqZ0YHWvdRuLb2CoDJkiuTm4sogP/eEV/Wu54=; b=X24tipPsRNS+Jlu4wxp6XJJOys96dJvXKcU32+UNVNYlbHoZ2dKuvK2/ZeMnBimUGw5MvF36BzvF9JRBBO6xVBUlSFEZjw7PjXdVNkZDZcoVPxx4HveJ0GECKaUQeOYzkaG3azIFXCc26g/y7eQ8Wg9hs8PHojwyxa7W4syAaeYUSV4+ETjtzORPiMhYZhHRqdc+GBHVDaHlRA0pZombOBbNN2cVnuNfWbjvWLL6RW/p1TpM+N0SU8ZNnwIVb9jBZtcUQyojRKX4voxPD7NbrVxmNi5ggI6j/TkqCKFh6bT21WXCBfCCuLGN13fLTb3Iww8vXhWwly1DxwtjUpWw2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2CqGTnJqZ0YHWvdRuLb2CoDJkiuTm4sogP/eEV/Wu54=; b=mUukYIkJ37BQba8aLuq0NnKbXURPsfJIJLJks2cefbuNWJxITrpuGzw3M6IshRr6yBHArc20SSc3NYybbp/ekYus3nba+YOs7rQRqAPWIBNeOBIUIIurN+N+3RFD+JBgAh5FQG167a0HXGbsJLoWau96KI8aavtsRKqYRJocLb05+r/1QhT7R70pBFXmIwb7PpDeuXWGgRylGYuxhXgh0WeBoytuf1wuSy2XQKDrKuZCk/VLC6MDzo9wohjEnGBRyZ2WRNPQ1COuYcrJGY2OKDJ3sixNbATnFxVA0IOn/QAnTZTyTXg7dAsSvahTWY4cy144jfMhqPwUYfPKlj+VKw== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by AS8PR10MB7857.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:636::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Sun, 7 May 2023 17:48:48 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.031; Sun, 7 May 2023 17:48:48 +0000 From: Cyril Arnould To: =?Windows-1252?Q?Mattias_Engdeg=E5rd?= Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj7+AAK+qgIAAAlBPgACFcQCAAAcxaQ== Date: Sun, 7 May 2023 17:48:48 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> In-Reply-To: Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [fAaTcBcxYQGQ2Lm4ChQ9QGW7fLQ1is5I] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|AS8PR10MB7857:EE_ x-ms-office365-filtering-correlation-id: d3f513f9-b760-4d4c-eb03-08db4f234fe2 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o6JOpIp3msshUoVUMYEoIJwysRGkaTxTHReDhNT33j+0sOjRZmex3ZpScjwoyKoBzdofu27FY0B1e1aDQJdH1QoA7ZFB0HGLjcSTxbKTEtG3fUP/RT3Uk6GarO+2YAPU1FPBlYwBkImjdMrZpA3clkQEFa21PbiAml3428dSez/NT5n3yePOtJgYl1lmS4LfuvM09BgW4lUysbQJ43rfdC02j7zrbSc/LdWlCCyYOlW2IDAmrLv6oaqxtMObvzdf4MyVJDInXu7Q8fo1ooKlBOKfQu2q/nyt8jST8GKO3X8009zRiwQTZtwPVPOb9BU3aiZNx8VeDhKkvL6lCkm0Hu7cSw6AhMA5kxTpy2tJDOuQ6zc40ouEQsZwfp91DHKoBzz13ep319cJ2zyduwY4kk93xZIZru0QW/uSGYCAxOMdvH/J9ILxLQHfidMGafTobClSbtJpQQ0DoVkiIfsvJ68PJ0++cOpSSl7kYUZXfJc/4G3fO4IyaTPK3tR2kOX2A/B9mCa7f0Im2lvbtgySI0GsJWw6+DtualWHwHBOIpJytuQ43I59TJS2Hr43gfbw x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?UftqzOq0U3sCbO0Ivx5cOnSKdym4SAcqYzB8T/uwTjs6xawFju3fsTYh?= =?Windows-1252?Q?mYr1qJng+fe27Hyykiv9P4wE/696a1G9XgnJwq8zXfoqwJ3Eh0fL84nJ?= =?Windows-1252?Q?5aVS9n661jS/eQIxprhQZP8zQpZSDYBy99vEhc8n+9LrghVNiP9PEjOw?= =?Windows-1252?Q?Hxo8oqm3R4y/29N9XUotTPIWTGPXLLBBcvgLtOoLIJvoPpIaa+haTF+b?= =?Windows-1252?Q?EJPjKZizv83jkMgzW/pornM9yuMZZlQ01/Mv5JaVPm1FwhplEtjMk8El?= =?Windows-1252?Q?jbJilFpzpMopVv6jafUgxwLHYJpqa8kzcmwzcydnRgowjWKWvyAuyZpy?= =?Windows-1252?Q?4BsMOmzUqn4ywbGNtBXycm0Bs8FRQJgGV+cMAfuIr1wemp1bEupLhTz1?= =?Windows-1252?Q?27PHXWgNsS5bUOuEgENJtL/HFXXl1b93AR47BN9M8RPEzoK60TGZPpcN?= =?Windows-1252?Q?YR97xRUuuswRfeDP6aAScMyHOVH6XsGb2DH2ReXOM4o7otaSJqx7qXDc?= =?Windows-1252?Q?X0PaC1scrTj5mAH7SBuIG/RRm+AzpXcbYcjYCqDNa5wxEva7rnLRVYIv?= =?Windows-1252?Q?QChytOSclEFWGhp4uBpfFjmDIg2Sn4kQsxIQi5YGd8XEM1+aWbXLNxpY?= =?Windows-1252?Q?lnoSPaEfVBl/NVFH5xgW3CR+p5mp5/jtGYP7x1e2+ML4H3kVYI/hVBDa?= =?Windows-1252?Q?1QqJ7qcCpZJbZSy9BydZaAtqBgdDP2mI5xw9/1Ba+h/W4cY1+3/mWASM?= =?Windows-1252?Q?HWIbdnjh9vbFM7hBWO/JNHRGP4YAoKEy3I3/YdTat62osryyTNORgxEV?= =?Windows-1252?Q?ydlTy9gncCLvJh44T/tSvjSxTqtc2g6jOU4sQscze1Vdf1rVbYZUrR4w?= =?Windows-1252?Q?boB6l4P8vc+Iaztr8fvgniNU6Of/VqS4b/ymmeE/5w31XsZpwAl7xHqL?= =?Windows-1252?Q?EnnClVPB1DYDWrHTGb9aQJvNCMGthogQoYI3SMqshKAQpL53WaR242YL?= =?Windows-1252?Q?y1r0d+ZjEkB+wa6hHd9pFSoQmiKZjhH1whFSyYhyCZzE/MXajVDy7uim?= =?Windows-1252?Q?24Wke5AxU4eD9KdgnmoXeMvMfUkWk4o/HSXEn2oL4uCYMoYLve0BcDug?= =?Windows-1252?Q?4wKUgIqOp39abV/1pxv3GHAcDdwNY+q/gxH4gKuMADk1p0wkiTUPJvru?= =?Windows-1252?Q?a4ZcEZNGt1+Vs70iR3CGOQg+axzZDhrI7MveK/ZCs/7rZt4dR3e9RhvY?= =?Windows-1252?Q?qgdXmd1IbIeyr+AO/sYIEHudENgNY2PLbvYc92NkD/l6fVAcwTx7XHKm?= =?Windows-1252?Q?ZccitqRZfq8qjh/9GsuKqy7HKzdeis59KpUnCz5knauURe9Q?= Content-Type: multipart/alternative; boundary="_000_AS4PR10MB6110F3CA3230C0B8815E8BB2E3709AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d3f513f9-b760-4d4c-eb03-08db4f234fe2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 17:48:48.5368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7857 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_000_AS4PR10MB6110F3CA3230C0B8815E8BB2E3709AS4PR10MB6110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable > Why would they be set to a dotted list? Can you give an example? Oh, sorry, I meant dotted pair, not list. So the (2 . 3) from the ModelSim compiler entry, for example. > I tried > > (cons :tag "Warning and Info" > (natnum :tag "Warning subexp index") > (natnum :tag "Info subexp index ")) > > instead of the (sexp ...) and it seems to work alright. I agree, the above code seems to be the better option. I would change the =ABWarning and Info=BB text though, seen as the compilation command can differentiate between Warnings, Infos AND Errors using the expression. Maybe =ABType detection=BB? Or =ABType detection via regexp=BB? > What I meant was that the code > > (let ((tmp-alist vhdl-compiler-alist)) > (while tmp-alist > (setcdr (nthcdr 3 (nth 11 (car tmp-alist))) > '(2 . nil)) > (setq tmp-alist (cdr tmp-alist)))) > > modifies the existing list structure instead of creating a new one based = on the old. This can lead to surprises if parts of the structure being muta= ted is shared with structure elsewhere. Now this code probably does work, b= ut it's a bit brittle, and it takes some work for the reader to understand = that it's OK. Contrast it to something like (untested!) > > (setq vhdl-compiler-alist > (mapcar (lambda (entry) > ;; Add a `2' to the end of the list that is element #11= . > (append (take 11 entry) > (append (nth 11 entry) (list 2)) > (nthcdr 12 entry))) > vhdl-compiler-alist)) > > where there is no mutation of the list structure, nor any sharing of a pr= ogram constant whose accidental mutation might have very confusing conseque= nces. (`take` is new in Emacs 29 but you can work around it by using `butla= st` instead if the code needs to work with older Emacs versions.) I have to admit this is going over my head a bit, but thanks for explaining. I'll let it up to the maintainers to decide upon the backwards compatibility code, I'm fine either way. Couldn't test your changes though as I'm still on Emacs 28.2. Von: Mattias Engdeg=E5rd Gesendet: Sonntag, 7. Mai 2023 18:22 An: Cyril Arnould Cc: 63251@debbugs.gnu.org; Reto Zimmermann; Eli Zaretskii Betreff: Re: bug#63251: 28.2; vhdl-mode contribution 7 maj 2023 kl. 17.40 skrev Cyril Arnould : > I had tried (cons =85) instead of (sexp =85), but that just resulted in > the customization menu breaking again if one of the compilers was set > to a dotted list. Why would they be set to a dotted list? Can you give an example? I tried (cons :tag "Warning and Info" (natnum :tag "Warning subexp index") (natnum :tag "Info subexp index ")) instead of the (sexp ...) and it seems to work alright. > > Think of what happens if later code performs an in-place change of that= nil you added. > > I am by no means an expert when it comes to elisp, I don=92t know what > kind of problems this could cause. What I meant was that the code (let ((tmp-alist vhdl-compiler-alist)) (while tmp-alist (setcdr (nthcdr 3 (nth 11 (car tmp-alist))) '(2 . nil)) (setq tmp-alist (cdr tmp-alist)))) modifies the existing list structure instead of creating a new one based on= the old. This can lead to surprises if parts of the structure being mutate= d is shared with structure elsewhere. Now this code probably does work, but= it's a bit brittle, and it takes some work for the reader to understand th= at it's OK. Contrast it to something like (untested!) (setq vhdl-compiler-alist (mapcar (lambda (entry) ;; Add a `2' to the end of the list that is element #11. (append (take 11 entry) (append (nth 11 entry) (list 2)) (nthcdr 12 entry))) vhdl-compiler-alist)) where there is no mutation of the list structure, nor any sharing of a prog= ram constant whose accidental mutation might have very confusing consequenc= es. (`take` is new in Emacs 29 but you can work around it by using `butlast= ` instead if the code needs to work with older Emacs versions.) --_000_AS4PR10MB6110F3CA3230C0B8815E8BB2E3709AS4PR10MB6110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

> Why would they be set to a dotted list? Can you= give an example?

Oh, sorry, I meant dotted pair, not list. So the (2 = . 3) from the

ModelSim compiler entry, for example.

 

> I tried

>        =             &nb= sp;          (cons :tag "= Warning and Info"

>        =             &nb= sp;            =     (natnum :tag "Warning subexp index")

>        =             &nb= sp;            =     (natnum :tag "Info subexp index   ")= )

> instead of the (sexp ...) and it seems to work = alright.

 

I agree, the above code seems to be the better optio= n. I would

change the =ABWarning and Info=BB text though, seen = as the

compilation command can differentiate between Warnin= gs, Infos AND

Errors using the expression. Maybe =ABType detection= =BB? Or =ABType

detection via regexp=BB?

 

> What I meant was that the code

>   (let ((tmp-alist vhdl-compiler-alis= t))

>     (while tmp-alist

>       (setcdr (nt= hcdr 3 (nth 11 (car tmp-alist)))

>        =        '(2 . nil))

>       (setq tmp-a= list (cdr tmp-alist))))

> modifies the existing list structure instead of= creating a new one based on the old. This can lead to surprises if parts o= f the structure being mutated is shared with structure elsewhere. Now this = code probably does work, but it's a bit brittle, and it takes some work for the reader to understand that it's OK.= Contrast it to something like (untested!)

>   (setq vhdl-compiler-alist

>        = (mapcar (lambda (entry)

>        =            ;; Add a `2' t= o the end of the list that is element #11.

>        =            (append (take = 11 entry)

>        =             &nb= sp;      (append (nth 11 entry) (list 2))

>        =             &nb= sp;      (nthcdr 12 entry)))

>        =          vhdl-compiler-alist))=

> where there is no mutation of the list structur= e, nor any sharing of a program constant whose accidental mutation might ha= ve very confusing consequences. (`take` is new in Emacs 29 but you can work= around it by using `butlast` instead if the code needs to work with older Emacs versions.)

 

I have to admit this is going over my head a bit, bu= t thanks for

explaining. I'll let it up to the maintainers to dec= ide upon the

backwards compatibility code, I'm fine either way. C= ouldn't test

your changes though as I'm still on Emacs 28.2.=

 

 

Von: Mattias Engdeg=E5rd
Gesendet: Sonntag, 7. Mai 2023 18:22
An: Cyril Arnould Cc: 63251@debbugs.gnu.org; Reto Zimmermann; Eli Zaretskii
Betreff: Re: bug#63251: 28.2; vhdl-mode contribution

 

7 maj 2023 kl. 17.40 = skrev Cyril Arnould <cyril.arnould@outlook.com>:

> I had tried (cons =85) instead of (sexp =85), but that just resulted i= n
> the customization menu breaking again if one of the compilers was set<= br> > to a dotted list.

Why would they be set to a dotted list? Can you give an example?
I tried

            &nb= sp;            =      (cons :tag "Warning and Info"
            &nb= sp;            =            (natnum :tag &= quot;Warning subexp index")
            &nb= sp;            =            (natnum :tag &= quot;Info subexp index   "))

instead of the (sexp ...) and it seems to work alright.

> > Think of what happens if later code performs an in-place change o= f that nil you added.

> I am by no means an expert when it comes to elisp, I don=92t know what=
> kind of problems this could cause.

What I meant was that the code

  (let ((tmp-alist vhdl-compiler-alist))
    (while tmp-alist
      (setcdr (nthcdr 3 (nth 11 (car tmp-alist)))<= br>             &nb= sp; '(2 . nil))
      (setq tmp-alist (cdr tmp-alist))))

modifies the existing list structure instead of creating a new one based on= the old. This can lead to surprises if parts of the structure being mutate= d is shared with structure elsewhere. Now this code probably does work, but= it's a bit brittle, and it takes some work for the reader to understand that it's OK. Contrast it to someth= ing like (untested!)

  (setq vhdl-compiler-alist
        (mapcar (lambda (entry)
            &nb= sp;     ;; Add a `2' to the end of the list that is ele= ment #11.
            &nb= sp;     (append (take 11 entry)
            &nb= sp;            = (append (nth 11 entry) (list 2))
            &nb= sp;            = (nthcdr 12 entry)))
            &nb= sp;   vhdl-compiler-alist))

where there is no mutation of the list structure, nor any sharing of a prog= ram constant whose accidental mutation might have very confusing consequenc= es. (`take` is new in Emacs 29 but you can work around it by using `butlast= ` instead if the code needs to work with older Emacs versions.)

 

--_000_AS4PR10MB6110F3CA3230C0B8815E8BB2E3709AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 13:54:12 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 17:54:12 +0000 Received: from localhost ([127.0.0.1]:38399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvia8-0007EB-Re for submit@debbugs.gnu.org; Sun, 07 May 2023 13:54:12 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:46134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvia6-0007Dx-Dm for 63251@debbugs.gnu.org; Sun, 07 May 2023 13:53:58 -0400 Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4eed764a10cso4075975e87.0 for <63251@debbugs.gnu.org>; Sun, 07 May 2023 10:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683482032; x=1686074032; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=98VnmOnueLxpMkpVwGI6H1wSVdASM8LG1VCel3gdiOo=; b=G8gS9QGs2SfpyGexQtlgGWJ6HhBZ/dDBozHP2vNbeMOxSqMqDq/2yqSKl1/EMNq+e/ CNdNmev0h0K6m086lES3Auu3c90WboxOo6S78l7+FIP6vxaDRWZobbdiIX6TrB0KY5Ab Aqg1f2LFvz38Ws9b+5qBl9pfTshJ64QWVdq/iooSNQgrGcZucaGo+nbhzM9ETekIbpBR za0lQk0qO+TmKcIpl5nZ1YIX5fRCWBMotN5eSQb8EtPTIEOMbK1t9fD85wC4BiWVnVJs fin4QGXhIiaUWzlZ6Taorx+6sJEBXRnxN9Vlj1lhyDEZnOv6x/SMcMiOCnRGelR09Db0 wcGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683482032; x=1686074032; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=98VnmOnueLxpMkpVwGI6H1wSVdASM8LG1VCel3gdiOo=; b=FiD5aUVUsXaCutdQPb3Ft7eOSlHkvH12tcydzz8meES3Rsdo+NIRSXO98DC2zQQ5Ba qwV6oAqiF9ZTuoJmSobBA51QojL9TCMSiQt3hqdiYtfBY2l3WBAS1ZtTkVw1YtcNcc/R zY5FFCYzSxYKhoDK7o1D+0/Nhb4d1EYdSdqigEk2Ci363htXJ/GuGKD3F6IhCId2Cgqp 54zhMQK//saGXqA16O46oB2P4PY7e6tzTG7vujPEFbeGgdaD/hCJ+0hqbwbX/L/fqOnb 9vOymY7Z56s33xk0qyxQj1DWfUdrmIcMwKmzAol/GADW9DGVcj1M9bXCFpNclJb47imd bOsQ== X-Gm-Message-State: AC+VfDymg7oXM20Xkoy2u41lxzIsghhiMtbaPgi27Z3vXEsNTE6d+qgU AZHWJ6iHgTg3CzYQM4wlQhY= X-Google-Smtp-Source: ACHHUZ4preF3D29b8rFj8CMzz7ycWWHvcpnuym+ScbD4KSziXidEgssnflFp5+1Pl3nzEHC91TGgwQ== X-Received: by 2002:a05:6512:6a:b0:4e8:5576:98f4 with SMTP id i10-20020a056512006a00b004e8557698f4mr2049698lfo.45.1683482032249; Sun, 07 May 2023 10:53:52 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id z14-20020ac25dee000000b004f1229988ecsm1041179lfq.61.2023.05.07.10.53.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 May 2023 10:53:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63251: 28.2; vhdl-mode contribution From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 7 May 2023 19:53:50 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> To: Cyril Arnould X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 7 maj 2023 kl. 19.48 skrev Cyril Arnould : > I would > change the =C2=ABWarning and Info=C2=BB text though, seen as the > compilation command can differentiate between Warnings, Infos AND > Errors using the expression. Maybe =C2=ABType detection=C2=BB? Or = =C2=ABType > detection via regexp=C2=BB? No opinion here. > Couldn't test your changes though as I'm still on Emacs 28.2. Replace (take 11 entry) with (butlast 3 entry) and it will work with any = Emacs version. From debbugs-submit-bounces@debbugs.gnu.org Sun May 07 14:57:08 2023 Received: (at 63251) by debbugs.gnu.org; 7 May 2023 18:57:08 +0000 Received: from localhost ([127.0.0.1]:38501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvjZD-0000ex-PY for submit@debbugs.gnu.org; Sun, 07 May 2023 14:57:08 -0400 Received: from mail-dbaeur03olkn2091.outbound.protection.outlook.com ([40.92.58.91]:16641 helo=EUR03-DBA-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvjZC-0000eS-86 for 63251@debbugs.gnu.org; Sun, 07 May 2023 14:57:06 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OyYv4FTAl5XoeI9gkNGOiizIfaCVXs7idOR0ASgD4LUsIVJBLKfzUjtHOpfsHTh6C0C5KlXvVtf7iEgkvFsw9h7xBSXXF2pzEPwd8z1J3JGgDyO0pKwcvJCSOppHydv9qNvrBOhHKSChiTcG6Ou7xdNJbh+//Ly2EALdrAX0Wgg4ZIhoMRw63z4CPo8bsE5cWvKJznrOnCWEE3xrEWCiQpV6Kn9QI6yuc6+16/uM1UKAuw+9JG6a/7v9veyUCBBu2pYQl9JQKVUjvwbRKXdXlzwtZyeYJLtEhoXNTLYA6N7PADC8euwv8LVT0sOpN1j1d6TSB6Au6MHnD8uyW5VQPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVLO5zTcshFlLorKO7W86fGTo+6AtEUHaPdN5vvwMDQ=; b=KfR3N79RO6QGJwLgr4mgpBCVIXAu4Qc2Jj+JtDaLi7ww9+KTDDJEdQDsKw56PnHQf7j0cnpCrd+iHDFCgTeLabezqEfjauZ9ougHQ7zq1eFDFy88YZAOcWZAHF6C55u/RgcEJSRA8Q8Ip7H2rC/xCN3FtbZKrSkIEfqJSgpjxrh0Hko3s3x6yWrp3Je1/suXYnmOnaVECIynh4P/AzFVoMdn8UmyDTtkFGDQyq9rFBjRPo5xNYb95zLT0DnNlDqQ8upwY//QXzHBOI8gMlBzjp6Hl2Ltfuy0OVTpS3+2jQGToUt2DuX4pPqanoTym2Cdm6h/UcPdh2E/DqdS8AHrig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVLO5zTcshFlLorKO7W86fGTo+6AtEUHaPdN5vvwMDQ=; b=dnwwx935DIgIKx5cCNiZ3mzvaxM9jkXlxdCC/j09G/AOERL0m1k2nl4TVe4OWq9toqJe1pua5OGeDPrIsn7PyNVEDL45n70nqYdzqP2A+3d25d/7tjTsgiO0Kxiku/Hjd/qxtQcbYT1/Z6F+tSFVUgnpwbMPVZb1u7ZTbUED8AYTu1lS5RsH3cLW+ag01EASlkSKCKt78qqW+hYNiy1RB6taTXDc56aRsdsZXez9CLsGpkzgkS2GErPwjVjYWTGC0P9nFCEdnU3qGyK8olceeDvOWQZMggBT5/olVtZJVFyM7spdpdeZXZf1ycLhipxRI9uP+aWyKEid4feGrgiOYA== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by AS2PR10MB7394.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:605::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29; Sun, 7 May 2023 18:56:59 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.031; Sun, 7 May 2023 18:56:59 +0000 From: Cyril Arnould To: =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj7+AAK+qgIAAAlBPgACFcQCAAAcxaYAAEjUAgAALaBw= Date: Sun, 7 May 2023 18:56:59 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> In-Reply-To: Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [1M98QHAB304kf98kMYEb9cXEX7hlHp+K] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|AS2PR10MB7394:EE_ x-ms-office365-filtering-correlation-id: 39757c82-4d7a-4a7b-c3f9-08db4f2cd657 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EbjaJaqKCrh9bzvkE7rnHV8VONy++tadVzh35lkN2+zIKbdJ9AIsYReiw76hqCpVoFbEznyamzCAH68I0WG9jUVSiBA0yKnK1+PMCLlUn4bYJKr3zqcgu1WMrh1sZZrvR1I1S4MY8RQIHEUw+U9L6LkqkASpaq9I1Sbf1jjh6s030V5MzEhfRdj/iBpJIJau3G9qneGzOPjmKLwX2i9+kN0KKXJd3Om9/RuCu3CGNMIzg2YjR/hhmnftLM8p+WyH2+0hFW/JA5Xk3npkx5OCaFmJo3EqQvL6138hlJYnqkmo1E4DfPuP4htou/UowKmxLsm2Ofwv1q63R2emU1MYrehQXQWS5merOrf4XQNGPWZxh3Z3CQh6tIn+ICVAphQJ82pzOWa85Ygp66PqGlmTVhfEn9RlnfVtVhKmUfcLj8AmLtAmODraFAaQz1rAJuoXQAkrpyItSzL8QSakODOcVkVYRM9xETlumD9TcwXnq/c7kei/+uWiQ9YeXs1gpaloEzipzqPruOOiRzkNkXV6CzUq6tlbnvVnGdQykrvKsbIiSExMlu6o23CsVSPlWyq/ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kr67yW7AbBA2j1YasIlDkaQ1Vu2UIOmG2zlV4MgG6OgrGoX8O1y8EN90pW?= =?iso-8859-1?Q?1dKAJr4xG5rtQVzsksIXRBxBRp58VlqZJ1cI3tRkhzQrezAR1zJ5H3EDZU?= =?iso-8859-1?Q?a0eFS7u3yrYpOBH+q7AycKuJBWjw6VVolu/Su407lIED/WSnGHxHI1MIlA?= =?iso-8859-1?Q?bgC0u+e5Z+f0HOrESGT1Z2qK5e5EOCg3k+v7t7OAFPSXuCSZpmLBDJoVwR?= =?iso-8859-1?Q?+aTcpI8nC5t9dwudjRvHQTpDPc4VVdxSvNEfxDJZ6qTiYCC91S8XRtBBDV?= =?iso-8859-1?Q?M7R2qfgNRDCi+9It7NLwpA3U2J07qdpxlql57/2RR4luE93q5SNq9gaxCr?= =?iso-8859-1?Q?iq7Wwlir5NGs7zTpQIAoyU7jZJxgEt9BNjt/iJ2R0azRsfPleLlHh3j3a5?= =?iso-8859-1?Q?WpN5W7N5ovlGbpfH20nR6IGjH6Ami00BTupJawQc4XfA1q2my31kJN7Hke?= =?iso-8859-1?Q?5zLB441uKL+/tA3qCFVflDRhz8NyXbKfqFxvCULceg7VuJ/6zJP4dq//FB?= =?iso-8859-1?Q?vPhry+OZLUWUQv8Hd1NODKFVWv1yttqZz6V6u56qQSv9xdl7OoSAt9uWWb?= =?iso-8859-1?Q?5aDcxd7e/rj5oJnMY8bwq+9Gorz8b1sXCXHcpzS4ut5Xvu4HKMlTSlBX/k?= =?iso-8859-1?Q?Pegp+rSGcvxFOpsCop0Zu6Kzhj9Q1diMx6wpLFTRJG8m5nUiA1UsG5eEDB?= =?iso-8859-1?Q?GHEQ4wuQvWlvOPxdhsHFwA5TpE9+Vme19W0pKGckGqqqVnw/e3ccXVeTE0?= =?iso-8859-1?Q?qiucD/3Lem27wAIPhAsl2XzQgf8+yFz+idWDphZEiud6QNRtHbmVtgIEWF?= =?iso-8859-1?Q?CtPkcu7fuDoEA8J56lCdHZb43uKJkJ41ZCCRbFZs8jXdeVzQT3I8fn+Hal?= =?iso-8859-1?Q?GhUGD9YYMmElajVcakz5Vx44G+dxtDdpbMxpCtDDg+CQmjj+8g9fU2kwMP?= =?iso-8859-1?Q?Ap/fE25frRMyX3WeVeSN5a2SUCH2wk/Qm02jOLkuHcP1FvT25eAeSPPFrC?= =?iso-8859-1?Q?Eq3cWYqbLGLG5jiYiagfcmbkWWTmwnnHMe+6lskQtuPenE1O8sLkH20+1T?= =?iso-8859-1?Q?Y89mq6PORFG4SSBvL5u/h6WymdcJVtEYzc3IeUZNJA0zeVWUPQ/zbRhg1P?= =?iso-8859-1?Q?0PFa07XctOOUMtE1Y2+NnZEAeFfcZ+SrQO6ZJzPS5O/YBn8aCyziQ66WDs?= =?iso-8859-1?Q?9NuwzQ4cnfLLyssyZDIDWmGr2wq0ddEWPgvALlvCuKOnKSQ9J+5fpflPzF?= =?iso-8859-1?Q?bSDuX+fm1vTAkv/A4C+VMqRCtGkhJULLpggrsezgEpkuyYFGRx0I1Eq8ub?= =?iso-8859-1?Q?T0Ay?= Content-Type: multipart/alternative; boundary="_000_AS4PR10MB61107760A200776CDC787C4BE3709AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 39757c82-4d7a-4a7b-c3f9-08db4f2cd657 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 18:56:59.6057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7394 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_000_AS4PR10MB61107760A200776CDC787C4BE3709AS4PR10MB6110EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I ran into some issues, but got it to work with the following: ;; option `vhdl-compiler-alist' changed format (3.38.1) (when (=3D (length (nth 11 (car vhdl-compiler-alist))) 4) (setq vhdl-compiler-alist (mapcar (lambda (entry) ;; Add a `2' to the end of the list that is element #11. (append (butlast entry 3) (list (append (nth 11 entry) (list 2))) (nthcdr 12 entry))) vhdl-compiler-alist)) (customize-save-variable 'vhdl-compiler-alist vhdl-compiler-alist)) Von: Mattias Engdeg=E5rd Gesendet: Sonntag, 7. Mai 2023 19:53 An: Cyril Arnould Cc: 63251@debbugs.gnu.org; Reto Zimmermann; Eli Zaretskii Betreff: Re: bug#63251: 28.2; vhdl-mode contribution 7 maj 2023 kl. 19.48 skrev Cyril Arnould : > I would > change the =ABWarning and Info=BB text though, seen as the > compilation command can differentiate between Warnings, Infos AND > Errors using the expression. Maybe =ABType detection=BB? Or =ABType > detection via regexp=BB? No opinion here. > Couldn't test your changes though as I'm still on Emacs 28.2. Replace (take 11 entry) with (butlast 3 entry) and it will work with any Em= acs version. --_000_AS4PR10MB61107760A200776CDC787C4BE3709AS4PR10MB6110EURP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

I ran into some issues, but got it to work with the = following:

 

;; option `vhdl-compiler-alist' changed format (3.38= .1)

(when (=3D (length (nth 11 (car vhdl-compiler-alist)= )) 4)

    (setq vhdl-compiler-alist

        (mapcar (= lambda (entry)

        &nbs= p;         ;; Add a `2' to the end = of the list that is element #11.

        &nbs= p;         (append (butlast entry 3= )

        &nbs= p;            &= nbsp;    (list (append (nth 11 entry) (list 2)))

        &nbs= p;            &= nbsp;    (nthcdr 12 entry)))

        &nbs= p;       vhdl-compiler-alist))

  (customize-save-variable 'vhdl-compiler-alist= vhdl-compiler-alist))

 

 

Von: Mattias Engdeg=E5rd
Gesendet: Sonntag, 7. Mai 2023 19:53
An: Cyril Arnould Cc: 63251@debbugs.gnu.org; Reto Zimmermann; Eli Zaretskii
Betreff: Re: bug#63251: 28.2; vhdl-mode contribution

 

7 maj 2023 kl. 19.48 = skrev Cyril Arnould <cyril.arnould@outlook.com>:

> I would
> change the =ABWarning and Info=BB text though, seen as the
> compilation command can differentiate between Warnings, Infos AND
> Errors using the expression. Maybe =ABType detection=BB? Or =ABType > detection via regexp=BB?

No opinion here.

> Couldn't test your changes though as I'm still on Emacs 28.2.

Replace (take 11 entry) with (butlast 3 entry) and it will work with any Em= acs version.

 

--_000_AS4PR10MB61107760A200776CDC787C4BE3709AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 08 04:15:40 2023 Received: (at 63251) by debbugs.gnu.org; 8 May 2023 08:15:40 +0000 Received: from localhost ([127.0.0.1]:39060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvw20-0001DK-E2 for submit@debbugs.gnu.org; Mon, 08 May 2023 04:15:40 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:56501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvw1z-0001D6-8M for 63251@debbugs.gnu.org; Mon, 08 May 2023 04:15:39 -0400 Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2ac80da3443so48089471fa.0 for <63251@debbugs.gnu.org>; Mon, 08 May 2023 01:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683533733; x=1686125733; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=LMMhX1vhulzzNenEJ0BnMrBt4iiF6dtG3aOHcEeak8U=; b=YmCa9fCb3vAmnwPe2jsgX5Cl7je6xU6VBCyDOdZ3uHX/IZpWJidnMDfJhU59lqEEZj uoYDFhaXhqMqp1K3Hw0qcxU0UooDaMPV0mBxgO+/zzbvh55ZsUn6b++jo0v1FLQCwnLO /YLv+jJvsiAWax9hSqC6TM3qncflju9GninmMgzf1tfX6mocLfKBlePfSdPU65ZufjQt ZcsmtI6povGhW2PYj6vobLI99gdixnLIwNSveeEobr0atZazTQan5du2i8kus4OZMwdq 99gfPP9PZRQX7gEgHitlvuv+R1PfWDzU7Xo7gnCRhbUtZVCg+PnKzSOsOLNrJxiW+vC1 s3zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683533733; x=1686125733; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LMMhX1vhulzzNenEJ0BnMrBt4iiF6dtG3aOHcEeak8U=; b=YWAsuH4fK79KD30jp3sx3lOp2DmdbPAJOdvyVGauI94r4AvfwDAGrBrsiiNgAfPMnD l8l+mkrwMla67xY75MUAkXQNfvgWxd9JavxYXom0kK8f3NI5CDyPHLcx4Yl7F5Pe9E3W TPpEOVJIVEApT91NsKIBG5rEPygZ2+vCIgv74lBKvb73msg0ZB9Eohfy5ulHbh9Hb701 yLjZ63/PtCtaJd/3OvYIZ/zfpdPAHvITJAZy1IghzjhBhipII+c9BAlIaVToGnEaOnaR dxYm3qYf+yGe9KZG54LA3Ph9frD8tw5sV79DcA6bcCvIQeCE3yg1ZoyEpkizMrEskf+j tJWQ== X-Gm-Message-State: AC+VfDzKSbPLHRoGJKS0HErVIqM2Wh3BjzR4d+9JyVw/pNQewhXoaOf/ RxS8uymxXrZUfylzOkwAg5c= X-Google-Smtp-Source: ACHHUZ7wxTJo2EcEaoURqc1v1sXjsEEoSdWERpJ17zaauUJPetBIziH/VlbPrsEmYdiLXjyyYrXtUg== X-Received: by 2002:ac2:4e69:0:b0:4f1:4cdc:ec10 with SMTP id y9-20020ac24e69000000b004f14cdcec10mr2049891lfs.28.1683533733149; Mon, 08 May 2023 01:15:33 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id p22-20020ac246d6000000b004eedb66983csm1209344lfo.273.2023.05.08.01.15.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 May 2023 01:15:32 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63251: 28.2; vhdl-mode contribution From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Mon, 8 May 2023 10:15:31 +0200 Content-Transfer-Encoding: 7bit Message-Id: <4FD3B33B-EC2E-4170-8C9F-45DFE8B377D5@gmail.com> References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> To: Cyril Arnould X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 7 maj 2023 kl. 20.56 skrev Cyril Arnould : > I ran into some issues, but got it to work with the following: Cyril, you are already better than me at this! From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 12:16:36 2023 Received: (at 63251) by debbugs.gnu.org; 9 May 2023 16:16:36 +0000 Received: from localhost ([127.0.0.1]:44238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQ0y-0006B0-CV for submit@debbugs.gnu.org; Tue, 09 May 2023 12:16:36 -0400 Received: from mail-vi1eur02olkn2072.outbound.protection.outlook.com ([40.92.48.72]:31072 helo=EUR02-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQ0o-0006AY-GE for 63251@debbugs.gnu.org; Tue, 09 May 2023 12:16:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wi3mucYAT7w+NtYzL37rjWthtLQh5o01vJ0UhygUA54Oq7wNygEyeloL9D89pNdZyvZNlEnoz3d0Opgi/ALWiobo89IBEb1dT5bY1PlDjm0FtXeNj90uVK2mKiFItnHzV29AqdELSZ4ftFn9AOIrHOcMEodpQ/wBO23FDjvUBzd9y2YQS7nM1ql6P8rMk0d+WscFIdIjqwDxE/VX1HSZWG6COgd5NQ8zJVdpo6FzkrM4/KqRNLkMn4wlbgWxbmj820vABTxnq1zQcNvi+zDvEZmyXL4QleaPH30netsj/Bydr5x3+VrnTvl9LlNF8cUZwSfMny8rWSHLt0o7g1ypaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K0ZWxnNrccvtVFw0wDGYyOUOKhBmZE+/9Y1Y8EuuZ7E=; b=nS0YewsUDDDuyHfGR4U/D2RH8Zzs43YqKusxszffhP42ElSBD7mC/1iV89R2JgcaDweOKZRpMx8TdnDc6lNdR2WnWAXBH7RqWehergyIPZ5kAQDpWZyjKjIuLJy+nKTI7v2IC8mCsIWOYpBbh5gy/EtB6vO67+8SA2aC30cNKswpIlFCX+o46lLC/lGkOWR3g6u4VZ8ETpZBTQYIxf/lI9nTOCBe8fP4p3Ib4TZnjfThFQmzha5XvjSlxpkggnKrS4Jbdh8SwEZ5wPS/GDRZXARzh24lJ9MAyUTFbpu1pqwotp5OstRrstyau/mqGEl4SclWh5qaNw4mpiVINcrPLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K0ZWxnNrccvtVFw0wDGYyOUOKhBmZE+/9Y1Y8EuuZ7E=; b=tvfUJw4StDvogNu7i4laQYlhGMxiIHpqO7LIdRsuU8lOr6qqgSpIbpQz49RnOmv4ZFn5oqvwNe3G3BKVAm62wZhuVxAoxDYELMCyQ05gzrM19MNj0IpJtjjffvYdChrScPJfix0GL+2pTzKbPW6zwm8uYvtjneLta4IUVYijLtkVIFw4diosnrQ09AGSQaCWTSh+/SLNBypnnIFIdUJeml/OJDqSkGnVSHIWefGwnUvMfvzl9ZvOm1YDWsIIEOz+krFLmwINW1SAImjQwXyEYkITH+A5ULjKnomyZfblZinXzxhXCt3VcQz2hml3y/Qg/LzWB2HPBCdO7hfvq5LVCg== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by AS8PR10MB7805.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:632::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 16:16:20 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023 16:16:20 +0000 From: Cyril Arnould To: =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj7+AAK+qgIAAAlBPgACFcQCAAAcxaYAAEjUAgAALaByAAOVYgIACFKPR Date: Tue, 9 May 2023 16:16:20 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> <4FD3B33B-EC2E-4170-8C9F-45DFE8B377D5@gmail.com> In-Reply-To: <4FD3B33B-EC2E-4170-8C9F-45DFE8B377D5@gmail.com> Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [hQ3PuVJzT0rG5pZsFSVZcFnsEQhziBbU] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|AS8PR10MB7805:EE_ x-ms-office365-filtering-correlation-id: 7ec331b9-9a33-4b4e-3994-08db50a8b9a2 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: geXt6Nx8CYjyHoYEuY/G85/Jynmndv1jHb58aDlqMMbsE6HUI5wrPnjfOZXGf/Ve4viO5pE2qaCKgfxb1CPQYm9hHJQVvvA0ICRa5WkqKbcd+J4fbVh4AbzkHRdIyEIFRFTSDO/zUbOwa9hhfNaETApBAA9mtGlecH1Z/Wp1qT8TbJgFlhftlC3UD9capIa50blySJ8YoIELsdikhgWa5aMYVKfwAee9bnQQMEy4zo2oUvfRaXqCwnpeJ8+2WN379mnuU8tq7/VgLa6WkU3MxWcdu5Et/qasQ+zGxVPOjdtTffbEaY/Sampa+7dKPUs3n0tOrmu7aKqLT+sbOt+u7UevpTS1rDdzqxaWfhMTxv/jJvyIsdHclpzSHa1+21X5ondAqrWq0KMug8yD7pRMTsTmeHWc4nbT9LOhq0sOxu6o1B29fmiLvOSEbojxLa8aBrT7MHiAMKeFKaVj1hayfXIYsVkmd/p72GPl7AJRivOO8I3ZNhMgQ+QahNKEECa2sT/8mvOfwFzhGUP1TyhN59FwzIZnz9gSkEDeRKDiVrmcwX5EMZUSY1ZxeNG+GFmC x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Q/zSB4zPiR+t0llufvnA8yloPR8ALCHRDTLyW4NDnhLkmEyhfJgSM0lsqD?= =?iso-8859-1?Q?rPxFHPV0w97izaH+zUpf5eC8uez2nTVFbuVlsQzRUutSGkPNNdC2hoSTXx?= =?iso-8859-1?Q?ymvH0zbMXuAWyZjIk4Nzn18K22lh4bDCBFL7JlvNDlBdNvlHxy3A8kq05K?= =?iso-8859-1?Q?kg8E1yn1Db7fiGeDtsKp4bwktyomtETWCtfPrF6NbaXLkCqRRFrUBz/Mff?= =?iso-8859-1?Q?I7Ryfs3V+IxdUZCOHUQbkkjvNd1igiTDVHHrfWsLkcTlowD8w4oMLajkPQ?= =?iso-8859-1?Q?LOZSSb8ZoLuJgIpfQ2Cn+Z4+okoEw0AJlETCTfKo/VTrBYfDmZnPW6Onx8?= =?iso-8859-1?Q?Vj+oPo1M7QSF4kYkuN4BqyrR/PNBGH9hhhdSPqnkZCGxkQNihZXfJU9Jij?= =?iso-8859-1?Q?3A4XscmIUWqnH8p4h58rQCPkH6cODbsUqhkyA4CASJ7/RmAqHoGYFZbyOM?= =?iso-8859-1?Q?YWwaHKWWHvQqQfBZl5KmvyeursfPBpW93c1d3HPfCodAi3jXy5rnxQDaBc?= =?iso-8859-1?Q?ke1qmM5H0Q62ZF6sE4a32QqcWZJsy+SY4BR7FnnQN6fwGoNrxP9igNkJlq?= =?iso-8859-1?Q?v2COOxtJjaBz2JBCHSw9YYwfhM3G0/blz6nDvI+XyZ/O7IpJ3tYg6ud9Yn?= =?iso-8859-1?Q?DLp/ZjG9zih/RapBgTStHixWH5wr53/6/mHeTG3OX5AHOG2naqAJp7xBjk?= =?iso-8859-1?Q?46xzQ2qL2rcEOddHFh9Zx15T6poqoOvZw5UUCgkqWGJwnoKM9RwVNu1f0z?= =?iso-8859-1?Q?a3T4znNSqEJYHrxJ7A3dzVXBwQQ9mzwgaXXzvg1wlJDq3sPrwEmHckbWc3?= =?iso-8859-1?Q?34ZZ3OQV7Qe0/ska4u2LrIUoGJ7CnoU3j/MTusSMxYKA7bXauvCm4+Ebaa?= =?iso-8859-1?Q?DBxq3A/gG2K8uxvCbSc5M7zQNl3JiiNIv9y8edS9VG8BPghtalivpgNQbS?= =?iso-8859-1?Q?y9taRLKwolzDA2pcz8rzLpDLAX2Xa+gPJBkb1lSzQlkX5wp+I2StKqDI+y?= =?iso-8859-1?Q?HPSmVMZ0RJ5gtaJO/ad9hz9SklqEQ1H2sRLEwPjv96XfB0dl0cusNeCwik?= =?iso-8859-1?Q?lhJw4OeIBuNAa4hHSr7fwPUqQEXhs5fgM8yfTP/diEiyKxlC46MpCJ7N8R?= =?iso-8859-1?Q?ZqWT2KOgYQag/gSctghD3LXdlzAZsmWZX3DdYA1tGywVXYpx85nq+yiEJC?= =?iso-8859-1?Q?KigOuseWPf6oNYtAjeL6Jcw4ubTg6p2+NJytQHb3l8bDRhQmYlafD6sP45?= =?iso-8859-1?Q?ZyzdaBl6k+SluSvO36po5+0eE6sOfWGq2Qon1ndC53l3PhB0kBYjRRLWL1?= =?iso-8859-1?Q?zti4?= Content-Type: multipart/mixed; boundary="_004_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec331b9-9a33-4b4e-3994-08db50a8b9a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 16:16:20.1809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7805 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_004_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_ Content-Type: multipart/alternative; boundary="_000_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_" --_000_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Following the discussion on the emacs-devel mailing list, here is the updated patch based on the emacs-29 branch. - Update vhdl-compiler definition and docstring to include the message type. - Increment vhdl-version to 3.38.5 because of the above change. Skip several versions due to divergent development. - Set the type of all other vhdl-compiler-alist entries to nil to explicitly declare them as error messages. - Update the Xilinx Vivado compiler entry's library directory, it must end with '/'. By defining the error message type to be nil rather than 2, we can forego the backwards compatibility code. --_000_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Following the discussion on the emacs-devel mailing = list, here is

the updated patch based on the emacs-29 branch.

 

- Update vhdl-compiler definition and docstring to i= nclude the

  message type.

 

- Increment vhdl-version to 3.38.5 because of the ab= ove

  change. Skip several versions due to divergen= t development.

 

- Set the type of all other vhdl-compiler-alist entr= ies to nil to

  explicitly declare them as error messages.

 

- Update the Xilinx Vivado compiler entry's library = directory, it

  must end with '/'.

 

By defining the error message type to be nil rather = than 2, we

can forego the backwards compatibility code.

--_000_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_-- --_004_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_ Content-Type: application/octet-stream; name="fix-vhdl-compiler-customization-4.patch" Content-Description: fix-vhdl-compiler-customization-4.patch Content-Disposition: attachment; filename="fix-vhdl-compiler-customization-4.patch"; size=11893; creation-date="Tue, 09 May 2023 16:14:48 GMT"; modification-date="Tue, 09 May 2023 16:14:48 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3ZoZGwtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVz L3ZoZGwtbW9kZS5lbAppbmRleCBlZTBlYzYzYjZiYy4uNzdkODYyZjFhMTcgMTAwNjQ0Ci0tLSBh L2xpc3AvcHJvZ21vZGVzL3ZoZGwtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy92aGRsLW1v ZGUuZWwKQEAgLTE2LDcgKzE2LDcgQEAKIDs7IFJldG8gYWxzbyBzYWlkIGluIEFwciAyMDIxIHRo YXQgaGUgcHJlZmVycmVkIHRvIGtlZXAgdGhlIFhFbWFjcwogOzsgY29tcGF0aWJpbGl0eSBjb2Rl LgogCi0oZGVmY29uc3QgdmhkbC12ZXJzaW9uICIzLjM4LjEiCisoZGVmY29uc3QgdmhkbC12ZXJz aW9uICIzLjM4LjUiCiAgICJWSERMIE1vZGUgdmVyc2lvbiBudW1iZXIuIikKIAogKGRlZmNvbnN0 IHZoZGwtdGltZS1zdGFtcCAiMjAxNS0wMy0xMiIKQEAgLTIyOSwyMCArMjI5LDIwIEBAIHZoZGwt Y29tcGlsZXItYWxpc3QKICAgICA7OyBbRXJyb3JdIEFzc2lnbm1lbnQgZXJyb3I6IHZhcmlhYmxl IGlzIGlsbGVnYWwgdGFyZ2V0IG9mIHNpZ25hbCBhc3NpZ25tZW50CiAgICAgKCJBRFZhbmNlIE1T IiAidmFjb20iICItd29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgInZhbGliIFxc MTsgdmFtYXAgXFwyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgImFkbXMiCi0gICAgICgi Xlxccy0rXFwoWzAtOV0rXFwpOlxccy0rIiBuaWwgMSBuaWwpICgiXkNvbXBpbGluZyBmaWxlIFxc KC4rXFwpIiAxKQorICAgICAoIl5cXHMtK1xcKFswLTldK1xcKTpcXHMtKyIgbmlsIDEgbmlsIG5p bCkgKCJeQ29tcGlsaW5nIGZpbGUgXFwoLitcXCkiIDEpCiAgICAgICgiRU5USS9cXDEudmlmIiAi QVJDSC9cXDEtXFwyLnZpZiIgIkNPTkYvXFwxLnZpZiIKICAgICAgICJQQUNLL1xcMS52aWYiICJC T0RZL1xcMS52aWYiIHVwY2FzZSkpCiAgICAgOzsgQWxkZWMKICAgICA7OyBDT01QOTYgRVJST1Ig Q09NUDk2XzAwMTg6ICJJZGVudGlmaWVyIGV4cGVjdGVkLiIgInRlc3QudmhkIiA2NiAzCiAgICAg KCJBbGRlYyIgInZjb20iICItd29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgInZs aWIgXFwxOyB2bWFwIFxcMiBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJhbGRlYyIKLSAg ICAgKCJeLiogRVJST1IgW146XSs6IFwiLipcIiBcIlxcKFteIFx0XG5dK1xcKVwiIFxcKFswLTld K1xcKSBcXChbMC05XStcXCkiIDEgMiAzKSAoIiIgMCkKKyAgICAgKCJeLiogRVJST1IgW146XSs6 IFwiLipcIiBcIlxcKFteIFx0XG5dK1xcKVwiIFxcKFswLTldK1xcKSBcXChbMC05XStcXCkiIDEg MiAzIG5pbCkgKCIiIDApCiAgICAgIG5pbCkKICAgICA7OyBDYWRlbmNlIExlYXBmcm9nOiBjdiAt ZmlsZSB0ZXN0LnZoZAogICAgIDs7IGR1bHV0aDogKkUsNDMwICh0ZXN0LnZoZCwxMyk6IGlkZW50 aWZpZXIgKFBPU0lUSVYpIGlzIG5vdCBkZWNsYXJlZAogICAgICgiQ2FkZW5jZSBMZWFwZnJvZyIg ImN2IiAiLXdvcmsgXFwxIC1maWxlIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBc XDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJsZWFwZnJvZyIKLSAgICAgKCJeZHVsdXRoOiBc XCpFLFswLTldKyAoXFwoW14gXHRcbl0rXFwpLFxcKFswLTldK1xcKSk6IiAxIDIgbmlsKSAoIiIg MCkKKyAgICAgKCJeZHVsdXRoOiBcXCpFLFswLTldKyAoXFwoW14gXHRcbl0rXFwpLFxcKFswLTld K1xcKSk6IiAxIDIgbmlsIG5pbCkgKCIiIDApCiAgICAgICgiXFwxL2VudGl0eSIgIlxcMi9cXDEi ICJcXDEvY29uZmlndXJhdGlvbiIKICAgICAgICJcXDEvcGFja2FnZSIgIlxcMS9ib2R5IiBkb3du Y2FzZSkpCiAgICAgOzsgQ2FkZW5jZSBBZmZpcm1hIE5DIHZoZGw6IG5jdmhkbCB0ZXN0LnZoZApA QCAtMjUwLDcgKzI1MCw3IEBAIHZoZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyAoUExMXzQwMFhf VE9QKSBpcyBub3QgZGVjbGFyZWQgWzEwLjNdLgogICAgICgiQ2FkZW5jZSBOQyIgIm5jdmhkbCIg Ii13b3JrIFxcMSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3 b3JrLyIgIk1ha2VmaWxlIiAibmN2aGRsIgotICAgICAoIl5uY3ZoZGxfcDogXFwqRSxcXHcrIChc XChbXiBcdFxuXStcXCksXFwoWzAtOV0rXFwpfFxcKFswLTldK1xcKSk6IiAxIDIgMykgKCIiIDAp CisgICAgICgiXm5jdmhkbF9wOiBcXCpFLFxcdysgKFxcKFteIFx0XG5dK1xcKSxcXChbMC05XStc XCl8XFwoWzAtOV0rXFwpKToiIDEgMiAzIG5pbCkgKCIiIDApCiAgICAgICgiXFwxL2VudGl0eS9w Yy5kYiIgIlxcMi9cXDEvcGMuZGIiICJcXDEvY29uZmlndXJhdGlvbi9wYy5kYiIKICAgICAgICJc XDEvcGFja2FnZS9wYy5kYiIgIlxcMS9ib2R5L3BjLmRiIiBkb3duY2FzZSkpCiAgICAgOzsgZ2hk bCB2aGRsCkBAIC0yNTgsMjEgKzI1OCwyMSBAQCB2aGRsLWNvbXBpbGVyLWFsaXN0CiAgICAgOzsg YmFkX2NvdW50ZXIudmhkbDoxMzoxNDogb3BlcmF0b3IgIj0iIGlzIG92ZXJsb2FkZWQKICAgICAo IkdIREwiICJnaGRsIiAiLWkgLS13b3JrZGlyPVxcMSAtLWllZWU9c3lub3BzeXMgLWZleHBsaWNp dCAiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8iICJN YWtlZmlsZSIgImdoZGwiCi0gICAgICgiXmdoZGxfcDogXFwqRSxcXHcrIChcXChbXiBcdFxuXStc XCksXFwoWzAtOV0rXFwpfFxcKFswLTldK1xcKSk6IiAxIDIgMykgKCIiIDApCisgICAgICgiXmdo ZGxfcDogXFwqRSxcXHcrIChcXChbXiBcdFxuXStcXCksXFwoWzAtOV0rXFwpfFxcKFswLTldK1xc KSk6IiAxIDIgMyBuaWwpICgiIiAwKQogICAgICAoIlxcMS9lbnRpdHkiICJcXDIvXFwxIiAiXFwx L2NvbmZpZ3VyYXRpb24iCiAgICAgICAiXFwxL3BhY2thZ2UiICJcXDEvYm9keSIgZG93bmNhc2Up KQogICAgIDs7IElCTSBDb21waWxlcgogICAgIDs7IDAwIENPQUNIREwqIHwgW0NDSERMLTFdOiBG aWxlOiBhZGRlci52aGQsIGxpbmUuY29sdW1uOiAxMjAuNgogICAgICgiSUJNIENvbXBpbGVyIiAi ZzJ0dmMiICItc3JjIiAicHJlY29tcCIgIlxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIg IndvcmsvIiAiTWFrZWZpbGUiICJpYm0iCi0gICAgICgiXlswLTldKyBDT0FDSERMLio6IEZpbGU6 IFxcKFteIFx0XG5dK1xcKSwgKmxpbmUuY29sdW1uOiBcXChbMC05XStcXCkuXFwoWzAtOV0rXFwp IiAxIDIgMykgKCIgIiAwKQorICAgICAoIl5bMC05XSsgQ09BQ0hETC4qOiBGaWxlOiBcXChbXiBc dFxuXStcXCksICpsaW5lLmNvbHVtbjogXFwoWzAtOV0rXFwpLlxcKFswLTldK1xcKSIgMSAyIDMg bmlsKSAoIiAiIDApCiAgICAgIG5pbCkKICAgICA7OyBJa29zIFZveWFnZXI6IGFuYWx5emUgdGVz dC52aGQKICAgICA7OyBhbmFseXplIHRlc3QudmhkCiAgICAgOzsgRSBMNC9DNTogICAgICAgIHRo aXMgbGlicmFyeSB1bml0IGlzIGluYWNjZXNzaWJsZQogICAgICgiSWtvcyIgImFuYWx5emUiICIt bCBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8i ICJNYWtlZmlsZSIgImlrb3MiCi0gICAgICgiXkUgTFxcKFswLTldK1xcKS9DXFwoWzAtOV0rXFwp OiIgbmlsIDEgMikKKyAgICAgKCJeRSBMXFwoWzAtOV0rXFwpL0NcXChbMC05XStcXCk6IiBuaWwg MSAyIG5pbCkKICAgICAgKCJeYW5hbHl6ZSArXFwoLisgK1xcKSpcXCguK1xcKSQiIDIpCiAgICAg IG5pbCkKICAgICA7OyBNb2RlbFNpbSwgTW9kZWwgVGVjaG5vbG9neTogdmNvbSB0ZXN0LnZoZApA QCAtMjk0LDcgKzI5NCw3IEBAIHZoZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyB0ZXN0LnZoZDoz NDogZXJyb3IgbWVzc2FnZQogICAgICgiTEVEQSBQcm9WSERMIiAicHJvdmhkbCIgIi13IFxcMSAt ZiIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1h a2VmaWxlIiAicHJvdmhkbCIKLSAgICAgKCJeXFwoW14gXHRcbjpdK1xcKTpcXChbMC05XStcXCk6 ICIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXlxcKFteIFx0XG46XStcXCk6XFwoWzAtOV0rXFwp OiAiIDEgMiBuaWwgbmlsKSAoIiIgMCkKICAgICAgKCJFTlRJL1xcMS52aWYiICJBUkNIL1xcMS1c XDIudmlmIiAiQ09ORi9cXDEudmlmIgogICAgICAgIlBBQ0svXFwxLnZpZiIgIkJPRFkvQk9EWS1c XDEudmlmIiB1cGNhc2UpKQogICAgIDs7IFF1YXJ0dXMgY29tcGlsZXIKQEAgLTMwNSwyMSArMzA1 LDIxIEBAIHZoZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyBXYXJuaW5nOiBWSERMIFByb2Nlc3Mg U3RhdGVtZW50IHdhcm5pbmcgYXQgZHZpMnNkaV90c3QudmhkKDE3Mik6IC4uLgogICAgICgiUXVh cnR1cyIgIm1ha2UiICItd29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGly IFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInF1YXJ0dXMiCi0gICAgICgiXlxcKEVycm9y XFx8V2FybmluZ1xcKTogLiogXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSkiIDIgMyBuaWwp ICgiIiAwKQorICAgICAoIl5cXChFcnJvclxcfFdhcm5pbmdcXCk6IC4qIFxcKFteIFx0XG5dK1xc KShcXChbMC05XStcXCkpIiAyIDMgbmlsIG5pbCkgKCIiIDApCiAgICAgIG5pbCkKICAgICA7OyBR dWlja0hETCwgTWVudG9yIEdyYXBoaWNzOiBxdmhjb20gdGVzdC52aGQKICAgICA7OyBFUlJPUjog dGVzdC52aGQoMjQpOiBuZWFyICJkbmQiOiBleHBlY3Rpbmc6IEVORAogICAgIDs7IFdBUk5JTkdb NF06IHRlc3QudmhkKDMwKTogQSBzcGFjZSBpcyByZXF1aXJlZCBiZXR3ZWVuIC4uLgogICAgICgi UXVpY2tIREwiICJxdmhjb20iICItd29yayBcXDEiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwg Im1rZGlyIFxcMSIgIi4vIiAid29yay8iICJNYWtlZmlsZSIgInF1aWNraGRsIgotICAgICAoIl5c XChFUlJPUlxcfFdBUk5JTkdcXClbXjpdKjogXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSk6 IiAyIDMgbmlsKSAoIiIgMCkKKyAgICAgKCJeXFwoRVJST1JcXHxXQVJOSU5HXFwpW146XSo6IFxc KFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIgMiAzIG5pbCBuaWwpICgiIiAwKQogICAgICAo IlxcMS9fcHJpbWFyeS5kYXQiICJcXDIvXFwxLmRhdCIgIlxcMS9fcHJpbWFyeS5kYXQiCiAgICAg ICAiXFwxL19wcmltYXJ5LmRhdCIgIlxcMS9ib2R5LmRhdCIgZG93bmNhc2UpKQogICAgIDs7IFNh dmFudDogc2NyYW0gLXB1Ymxpc2gtY2MgdGVzdC52aGQKICAgICA7OyB0ZXN0LnZoZDo4NzogX3Nl dF9wYXNzZWRfdGhyb3VnaF9vdXRfcG9ydChJSVJfQm9vbGVhbikgbm90IGRlZmluZWQgZm9yCiAg ICAgKCJTYXZhbnQiICJzY3JhbSIgIi1wdWJsaXNoLWNjIC1kZXNpZ24tbGlicmFyeS1uYW1lIFxc MSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLl9zYXZh bnRfbGliLyIgIk1ha2VmaWxlIiAic2F2YW50IgotICAgICAoIl5cXChbXiBcdFxuOl0rXFwpOlxc KFswLTldK1xcKTogIiAxIDIgbmlsKSAoIiIgMCkKKyAgICAgKCJeXFwoW14gXHRcbjpdK1xcKTpc XChbMC05XStcXCk6ICIgMSAyIG5pbCBuaWwpICgiIiAwKQogICAgICAoIlxcMV9lbnRpdHkudmhk bCIgIlxcMl9zZWNvbmRhcnlfdW5pdHMuX3NhdmFudF9saWIvXFwyX1xcMS52aGRsIgogICAgICAg IlxcMV9jb25maWcudmhkbCIgIlxcMV9wYWNrYWdlLnZoZGwiCiAgICAgICAiXFwxX3NlY29uZGFy eV91bml0cy5fc2F2YW50X2xpYi9cXDFfcGFja2FnZV9ib2R5LnZoZGwiIGRvd25jYXNlKSkKQEAg LTMyNywzOSArMzI3LDM5IEBAIHZoZGwtY29tcGlsZXItYWxpc3QKICAgICA7OyBFcnJvcjogQ1NW SERMMDAwMjogdGVzdC52aGQ6IChsaW5lIDk3KTogSW52YWxpZCBwcmVmaXgKICAgICAoIlNpbWls aSIgInZoZGxwIiAiLXdvcmsgXFwxIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBc XDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJzaW1pbGkiCi0gICAgICgiXlxcKEVycm9yXFx8 V2FybmluZ1xcKTogXFx3KzogXFwoW14gXHRcbl0rXFwpOiAobGluZSBcXChbMC05XStcXCkpOiAi IDIgMyBuaWwpICgiIiAwKQorICAgICAoIl5cXChFcnJvclxcfFdhcm5pbmdcXCk6IFxcdys6IFxc KFteIFx0XG5dK1xcKTogKGxpbmUgXFwoWzAtOV0rXFwpKTogIiAyIDMgbmlsIG5pbCkgKCIiIDAp CiAgICAgICgiXFwxL3ByaW0udmFyIiAiXFwyL19cXDEudmFyIiAiXFwxL3ByaW0udmFyIgogICAg ICAgIlxcMS9wcmltLnZhciIgIlxcMS9fYm9keS52YXIiIGRvd25jYXNlKSkKICAgICA7OyBTcGVl ZHdhdmUgKElubm92ZWRhKTogYW5hbHl6ZSAtbGliZmlsZSB2c3NsaWIuaW5pIC1zcmMgdGVzdC52 aGQKICAgICA7OyAgICAgRVJST1JbMTFdOjpGaWxlIHRlc3QudmhkIExpbmUgMTAwOiBVc2Ugb2Yg dW5kZWNsYXJlZCBpZGVudGlmaWVyCiAgICAgKCJTcGVlZHdhdmUiICJhbmFseXplIiAiLWxpYmZp bGUgdnNzbGliLmluaSAtc3JjIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEi ICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJzcGVlZHdhdmUiCi0gICAgICgiXiAqRVJST1JcXFtb MC05XStdOjpGaWxlIFxcKFteIFx0XG5dK1xcKSBMaW5lIFxcKFswLTldK1xcKToiIDEgMiBuaWwp ICgiIiAwKQorICAgICAoIl4gKkVSUk9SXFxbWzAtOV0rXTo6RmlsZSBcXChbXiBcdFxuXStcXCkg TGluZSBcXChbMC05XStcXCk6IiAxIDIgbmlsIG5pbCkgKCIiIDApCiAgICAgIG5pbCkKICAgICA7 OyBTeW5vcHN5cywgVkhETCBBbmFseXplciAoc2ltKTogdmhkbGFuIC1uYyB0ZXN0LnZoZAogICAg IDs7ICoqRXJyb3I6IHZoZGxhbiw3MDMgdGVzdC52aGQoMjIpOiBPVEhFUlMgaXMgbm90IGxlZ2Fs IGluIHRoaXMgY29udGV4dC4KICAgICAoIlN5bm9wc3lzIiAidmhkbGFuIiAiLW5jIC13b3JrIFxc MSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1h a2VmaWxlIiAic3lub3BzeXMiCi0gICAgICgiXlxcKlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxc KFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIgMSAyIG5pbCkgKCIiIDApCisgICAgICgiXlxc KlxcKkVycm9yOiB2aGRsYW4sWzAtOV0rIFxcKFteIFx0XG5dK1xcKShcXChbMC05XStcXCkpOiIg MSAyIG5pbCBuaWwpICgiIiAwKQogICAgICAoIlxcMS5zaW0iICJcXDJfX1xcMS5zaW0iICJcXDEu c2ltIiAiXFwxLnNpbSIgIlxcMV9fLnNpbSIgdXBjYXNlKSkKICAgICA7OyBTeW5vcHN5cywgVkhE TCBBbmFseXplciAoc3luKTogdmhkbGFuIC1uYyAtc3BjIHRlc3QudmhkCiAgICAgOzsgKipFcnJv cjogdmhkbGFuLDcwMyB0ZXN0LnZoZCgyMik6IE9USEVSUyBpcyBub3QgbGVnYWwgaW4gdGhpcyBj b250ZXh0LgogICAgICgiU3lub3BzeXMgRGVzaWduIENvbXBpbGVyIiAidmhkbGFuIiAiLW5jIC1z cGMgLXdvcmsgXFwxIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEiICIuLyIg IndvcmsvIiAiTWFrZWZpbGUiICJzeW5vcHN5c19kYyIKLSAgICAgKCJeXFwqXFwqRXJyb3I6IHZo ZGxhbixbMC05XSsgXFwoW14gXHRcbl0rXFwpKFxcKFswLTldK1xcKSk6IiAxIDIgbmlsKSAoIiIg MCkKKyAgICAgKCJeXFwqXFwqRXJyb3I6IHZoZGxhbixbMC05XSsgXFwoW14gXHRcbl0rXFwpKFxc KFswLTldK1xcKSk6IiAxIDIgbmlsIG5pbCkgKCIiIDApCiAgICAgICgiXFwxLnN5biIgIlxcMl9f XFwxLnN5biIgIlxcMS5zeW4iICJcXDEuc3luIiAiXFwxX18uc3luIiB1cGNhc2UpKQogICAgIDs7 IFN5bnBsaWZ5OgogICAgIDs7IEBXOiJ0ZXN0LnZoZCI6NTc6ODo1Nzo5fE9wdGltaXppbmcgcmVn aXN0ZXIgYml0IGNvdW50X3goNSkgdG8gYSBjb25zdGFudCAwCiAgICAgKCJTeW5wbGlmeSIgIm4v YSIgIm4vYSIgIm1ha2UiICItZiBcXDEiCiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3Jr LyIgIk1ha2VmaWxlIiAic3lucGxpZnkiCi0gICAgICgiXkBbRVdOXTpcIlxcKFteIFx0XG5dK1xc KVwiOlxcKFswLTldK1xcKTpcXChbMC05XStcXCk6IiAxIDIgMykgKCIiIDApCisgICAgICgiXkBb RVdOXTpcIlxcKFteIFx0XG5dK1xcKVwiOlxcKFswLTldK1xcKTpcXChbMC05XStcXCk6IiAxIDIg MyBuaWwpICgiIiAwKQogICAgICBuaWwpCiAgICAgOzsgVmFudGFnZTogYW5hbHl6ZSAtbGliZmls ZSB2c3NsaWIuaW5pIC1zcmMgdGVzdC52aGQKICAgICA7OyAgICAgQ29tcGlsaW5nICJ0ZXN0LnZo ZCIgbGluZSAxLi4uCiAgICAgOzsgKipFcnJvcjogTElORSA0OSAqKiogTm8gYWdncmVnYXRlIHZh bHVlIGlzIHZhbGlkIGluIHRoaXMgY29udGV4dC4KICAgICAoIlZhbnRhZ2UiICJhbmFseXplIiAi LWxpYmZpbGUgdnNzbGliLmluaSAtc3JjIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2Rp ciBcXDEiICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJ2YW50YWdlIgotICAgICAoIl5cXCpcXCpF cnJvcjogTElORSBcXChbMC05XStcXCkgXFwqXFwqXFwqIiBuaWwgMSBuaWwpCisgICAgICgiXlxc KlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoiIG5pbCAxIG5pbCBuaWwpCiAg ICAgICgiXiAqQ29tcGlsaW5nIFwiXFwoLitcXClcIiAiIDEpCiAgICAgIG5pbCkKICAgICA7OyBW ZXJpQmVzdDogdmMgdmhkbCB0ZXN0LnZoZApAQCAtMzY5LDI2ICszNjksMjYgQEAgdmhkbC1jb21w aWxlci1hbGlzdAogICAgIDs7IFtFcnJvcl0gTmFtZSBCSVRBIGlzIHVua25vd24KICAgICAoIlZl cmlCZXN0IiAidmMiICJ2aGRsIiAibWFrZSIgIi1mIFxcMSIKICAgICAgbmlsICJta2RpciBcXDEi ICIuLyIgIndvcmsvIiAiTWFrZWZpbGUiICJ2ZXJpYmVzdCIKLSAgICAgKCJeICtcXChbMC05XStc XCk6ICtbXiBdIiBuaWwgMSBuaWwpICgiIiAwKQorICAgICAoIl4gK1xcKFswLTldK1xcKTogK1te IF0iIG5pbCAxIG5pbCBuaWwpICgiIiAwKQogICAgICBuaWwpCiAgICAgOzsgVmlld2xvZ2ljOiBh bmFseXplIC1saWJmaWxlIHZzc2xpYi5pbmkgLXNyYyB0ZXN0LnZoZAogICAgIDs7ICAgICBDb21w aWxpbmcgInRlc3QudmhkIiBsaW5lIDEuLi4KICAgICA7OyAqKkVycm9yOiBMSU5FIDQ5ICoqKiBO byBhZ2dyZWdhdGUgdmFsdWUgaXMgdmFsaWQgaW4gdGhpcyBjb250ZXh0LgogICAgICgiVmlld2xv Z2ljIiAiYW5hbHl6ZSIgIi1saWJmaWxlIHZzc2xpYi5pbmkgLXNyYyIgIm1ha2UiICItZiBcXDEi CiAgICAgIG5pbCAibWtkaXIgXFwxIiAiLi8iICJ3b3JrLyIgIk1ha2VmaWxlIiAidmlld2xvZ2lj IgotICAgICAoIl5cXCpcXCpFcnJvcjogTElORSBcXChbMC05XStcXCkgXFwqXFwqXFwqIiBuaWwg MSBuaWwpCisgICAgICgiXlxcKlxcKkVycm9yOiBMSU5FIFxcKFswLTldK1xcKSBcXCpcXCpcXCoi IG5pbCAxIG5pbCBuaWwpCiAgICAgICgiXiAqQ29tcGlsaW5nIFwiXFwoLitcXClcIiAiIDEpCiAg ICAgIG5pbCkKICAgICA7OyBYaWxpbnggWFNUOgogICAgIDs7IEVSUk9SOkhETFBhcnNlcnM6MTY0 IC0gInRlc3QudmhkIiBMaW5lIDMuIHBhcnNlIGVycm9yCiAgICAgKCJYaWxpbnggWFNUIiAieGZs b3ciICIiICJtYWtlIiAiLWYgXFwxIgogICAgICBuaWwgIm1rZGlyIFxcMSIgIi4vIiAid29yay8i ICJNYWtlZmlsZSIgInhpbGlueCIKLSAgICAgKCJeRVJST1I6SERMUGFyc2VyczpbMC05XSsgLSBc IlxcKFteIFx0XG5dK1xcKVwiIExpbmUgXFwoWzAtOV0rXFwpXFwuIiAxIDIgbmlsKSAoIiIgMCkK KyAgICAgKCJeRVJST1I6SERMUGFyc2VyczpbMC05XSsgLSBcIlxcKFteIFx0XG5dK1xcKVwiIExp bmUgXFwoWzAtOV0rXFwpXFwuIiAxIDIgbmlsIG5pbCkgKCIiIDApCiAgICAgIG5pbCkKICAgICA7 OyBYaWxpbnggVml2YWRvOgogICAgIDs7IEVSUk9SOiBbVlJGQyAxMC0xNDEyXSBzeW50YXggZXJy b3IgbmVhciBvX2lkbGUgW3Rlc3QudmhkOjIzXQogICAgICgiWGlsaW54IFZpdmFkbyIgInh2aGRs IiAiIiAibWFrZSIgIi1mIFxcMSIKLSAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsiICJN YWtlZmlsZSIgInZpdmFkbyIKKyAgICAgbmlsICJta2RpciBcXDEiICIuLyIgIndvcmsvIiAiTWFr ZWZpbGUiICJ2aXZhZG8iCiAgICAgICgiXlxcKD86XFwoPzE6RVJST1JcXClcXHxcXCg/MjpXQVJO SU5HXFwpXFx8XFwoPzM6SU5GT1xcKVxcKTogXFwoLitcXCkgXFxbXFwoPzQ6W14gXHRcbl0rXFwp OlxcKD81OlswLTldK1xcKVxcXSIgNCA1IG5pbCAoMiAuIDMpKSAoIiIgMCkKICAgICAgKCJcXDEv ZW50aXR5IiAiXFwyL1xcMSIgIlxcMS9jb25maWd1cmF0aW9uIgogICAgICAgIlxcMS9wYWNrYWdl IiAiXFwxL2JvZHkiIGRvd25jYXNlKSkKQEAgLTQxNCw2ICs0MTQsMTMgQEAgdmhkbC1jb21waWxl ci1hbGlzdAogICBGaWxlIHN1YmV4cCBpbmRleDogaW5kZXggb2Ygc3ViZXhwcmVzc2lvbiB0aGF0 IG1hdGNoZXMgdGhlIGZpbGUgbmFtZQogICBMaW5lIHN1YmV4cCBpbmRleDogaW5kZXggb2Ygc3Vi ZXhwcmVzc2lvbiB0aGF0IG1hdGNoZXMgdGhlIGxpbmUgbnVtYmVyCiAgIENvbHVtbiBzdWJleHAg aWR4OiBpbmRleCBvZiBzdWJleHByZXNzaW9uIHRoYXQgbWF0Y2hlcyB0aGUgY29sdW1uIG51bWJl cgorICBUeXBlIHN1YmV4cCAgICAgIDogbWVzc2FnZSB0eXBlLCBjYW4gYmUgbmlsIGZvciBhIHJl YWwgZXJyb3IsIDEgZm9yIHdhcm5pbmcKKyAgICAgICAgICAgICAgICAgICAgIG9yIDAgZm9yIGlu Zm8uIFR5cGUgY2FuIGFsc28gYmUgZGV0ZWN0ZWQgdXNpbmcgdGhlIGZvcm0KKyAgICAgICAgICAg ICAgICAgICAgIChXQVJOSU5HIC4gSU5GTykuICBJbiB0aGF0IGNhc2UgdGhpcyB3aWxsIGJlIGVx dWl2YWxlbnQgdG8KKyAgICAgICAgICAgICAgICAgICAgIDEgaWYgdGhlIFdBUk5JTkfigJl0aCBz dWJleHByZXNzaW9uIG1hdGNoZWQgb3IgZWxzZQorICAgICAgICAgICAgICAgICAgICAgZXF1aXZh bGVudCB0byAwIGlmIHRoZSBJTkZP4oCZdGggc3ViZXhwcmVzc2lvbiBtYXRjaGVkLCBvcgorICAg ICAgICAgICAgICAgICAgICAgZWxzZSBlcXVpdmFsZW50IHRvIG5pbCBpZiBuZWl0aGVyIG9mIHRo ZW0gbWF0Y2hlZC4gU2VlCisgICAgICAgICAgICAgICAgICAgICBhbHNvIGBjb21waWxhdGlvbi1l cnJvci1yZWdleHAtYWxpc3QnLgogRmlsZSBtZXNzYWdlOgogICBSZWdleHAgICAgICAgICAgIDog cmVndWxhciBleHByZXNzaW9uIHRvIG1hdGNoIGEgZmlsZSBuYW1lIG1lc3NhZ2UKICAgRmlsZSBz dWJleHAgaW5kZXg6IGluZGV4IG9mIHN1YmV4cHJlc3Npb24gdGhhdCBtYXRjaGVzIHRoZSBmaWxl IG5hbWUKQEAgLTQ4Myw3ICs0OTAsMTQgQEAgdmhkbC1jb21waWxlci1hbGlzdAogCQkgICAgICAo aW50ZWdlciA6dGFnICJMaW5lIHN1YmV4cCBpbmRleCIpCiAJCSAgICAgIChjaG9pY2UgIDp0YWcg IkNvbHVtbiBzdWJleHAgICAgIgogCQkJICAgICAgKGludGVnZXIgOnRhZyAiSW5kZXgiKQotCQkJ ICAgICAgKGNvbnN0IDp0YWcgIk5vIGNvbHVtbiBudW1iZXIiIG5pbCkpKQorCQkJICAgICAgKGNv bnN0IDp0YWcgIk5vIGNvbHVtbiBudW1iZXIiIG5pbCkpCisJCQkgICAgKGNob2ljZSAgOnRhZyAi VHlwZSAgICAiCisJCQkgICAgICAoY29uc3QgOnRhZyAiSW5mbyIgMCkKKwkJCSAgICAgIChjb25z dCA6dGFnICJXYXJuaW5nIiAxKQorCQkJICAgICAgKGNvbnN0IDp0YWcgIkVycm9yIiBuaWwpCisJ CQkgICAgICAoY29ucyA6dGFnICJUeXBlIGRldGVjdGlvbiIKKwkJCSAgICAgICAgKG5hdG51bSA6 dGFnICJXYXJuaW5nIHN1YmV4cCBpbmRleCIpCisJCQkgICAgICAgIChuYXRudW0gOnRhZyAiSW5m byBzdWJleHAgaW5kZXggICAiKSkpKQogCQkobGlzdCA6dGFnICJGaWxlIG1lc3NhZ2UiIDppbmRl bnQgNAogCQkgICAgICAocmVnZXhwICA6dGFnICJSZWdleHAgICAgICAgICAgICIpCiAJCSAgICAg IChpbnRlZ2VyIDp0YWcgIkZpbGUgc3ViZXhwIGluZGV4IikpCg== --_004_AS4PR10MB6110C3582AE98538509CD56FE3769AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 12:41:52 2023 Received: (at 63251) by debbugs.gnu.org; 9 May 2023 16:41:52 +0000 Received: from localhost ([127.0.0.1]:44274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQPP-0006tn-T6 for submit@debbugs.gnu.org; Tue, 09 May 2023 12:41:52 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:59736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQPL-0006tX-GI for 63251@debbugs.gnu.org; Tue, 09 May 2023 12:41:50 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f13ef4ad91so7071223e87.3 for <63251@debbugs.gnu.org>; Tue, 09 May 2023 09:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683650501; x=1686242501; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=6QQnDCJtHhXxGgJjmT3ZYorl5CVRuwE/C3aAgq4RLoE=; b=QVWEKT+CskIngSGVG5O41cr/C0IiAXE4MmhqgSpoNh9ulLB2/vO74P++g3gFKs7ro0 uSSbZm2I1M3sDjgermDdWt0ViOiUBfgJLro8GvltiS9PunlIErnR2uSmbwPKVLqWgatt SNDtW+t1/H9/CGPfplbmy4weXtQB4/Vym7gk+i7KeW7zbF7FGlocIqCkk9zS21gL9tKb sVGKJsQvee8ZUQij0zDANp1mE+PTx2mE9QryMuDzL9LbT9iVddPRnbK2owvpJfxDoWP1 g634k2JXoZGBktKpS9g9yHCtokkWb7gG0P7MHw4G6+XWfzlitdEsqLO+Ideey7yC9dQ3 fhXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683650501; x=1686242501; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6QQnDCJtHhXxGgJjmT3ZYorl5CVRuwE/C3aAgq4RLoE=; b=NFmvtqO2Q1jcspAAyCgilAh0SnofUtNqoyaZymkQWXB3Ua8hsTqzjjwtW0hYUv4TVK F4LRwAHKX5KcrHMJXXiaY50ly/LBKhV2xHbbVVSue4TmYwh+ofj6PhuPXxfUveqe1V5s 2vdnZGE9bOQ3g3GsGzQ9sxkzlCXYVLTwBY4sEknK2/w+TmzMk2zFnhFc+7JjqJPaNE2m 30HNQywVwKhVopGF+4RsnU+7TagBbARtqcii3Rxl6iYtOh8UMxkxuPmGrh1ebm5RdlV/ tL46OzWMs4yOCz823Uem2der+VLxzT3ymt9HjrB+IioAnnHCHnY8gYMuZSAOF7/9wNEH Sn+w== X-Gm-Message-State: AC+VfDyYjLRDsM4Npl9tdivwzc3PFFbt88Y6Bm8wmQnMy2bgZ6HjJ4JK R3pk3JCQHzC1HQIJDi8YpXA= X-Google-Smtp-Source: ACHHUZ51Q8lm4E47AcBtYGDI/e18cB+AS5ODOxbE5jcXpDQaWObWY2gR5jlfmH7/p9p9Tc1AGjxcLQ== X-Received: by 2002:ac2:494b:0:b0:4f1:408f:4fa6 with SMTP id o11-20020ac2494b000000b004f1408f4fa6mr823718lfi.49.1683650501231; Tue, 09 May 2023 09:41:41 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id r10-20020ac25a4a000000b004d887e0e9edsm394259lfn.168.2023.05.09.09.41.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2023 09:41:40 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63251: 28.2; vhdl-mode contribution From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Tue, 9 May 2023 18:41:39 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> <4FD3B33B-EC2E-4170-8C9F-45DFE8B377D5@gmail.com> To: Cyril Arnould X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 9 maj 2023 kl. 18.16 skrev Cyril Arnould : > By defining the error message type to be nil rather than 2, we > can forego the backwards compatibility code. > Looks fine (although I had hoped to establish a precedent for less = mutation in the updating code...). Actually there is another argument to include updating code: subsequent = changes will likely rely on existing values to conform strictly to the = previous type and will likely botch any updating of values that don't. For example, if yet another value is added to the entry, then it cannot = just be appended to each entry because that entry might be too short = because of the incomplete previous update. From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 13:12:13 2023 Received: (at 63251) by debbugs.gnu.org; 9 May 2023 17:12:13 +0000 Received: from localhost ([127.0.0.1]:44389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQsi-00083o-TK for submit@debbugs.gnu.org; Tue, 09 May 2023 13:12:13 -0400 Received: from mail-vi1eur05olkn2071.outbound.protection.outlook.com ([40.92.90.71]:44800 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQsc-00083C-OL for 63251@debbugs.gnu.org; Tue, 09 May 2023 13:12:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZuHU3r/wAsda2r2t5RhTgSw7nYDXlD4uYRaoJgCWcst+9xsOXAl0I+boBch+FwkAUmm20IZLJeEox2GeonmR39U+P8x0Ln0uZjAAioXS14V+OeBxxi0SFu9fBO/DQf+ul5BMuPaVymont88v5qKj9UkpKyIcDMRht61GN4+GHFasF6jruKBNANlrnUO2T7KW1Z4HaRry7QEEMGchChTfS2H+TLqa7/oOc+6Nq2iXcBjZNpoxF5FIs8M8lyIVe6KyXrWFWldsGHBVH6HHF2iuQWCI+vya2Hh3kfSGnLitalG+08dU3A0Cod1dhttxJUZvk4FpZw1hdVou5VdgFflmjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L/5PXNDluLKZmqzxLH8/24YXPSxVHWYiAxOH817RJNQ=; b=Vw04dWvk/orBM37ACSacah7hj+++h98yAVgJcl6ok0yBZ8AAsqGgT5v1seTEhFULo25AUhntRuAhnGlhbVyDUJiD3ihgCBSr0upP8kAd8LS4guVxqDsQaJjH5aGr3rDYweLvmBQFsETmyExxg3PJbhBVtf0yqIdj41FsG+FJVRICZ2LlzMHAALdb6UdAHVAfk74Z0Azmkw9/dLW7eyz69pxiBr2dwFlVJVDZcZX/Ru7+iFqLv879tviRegB5IrKzq6zOSN/IM0E2GtIW5HQQabw5Csxv+hzLskmn7UC6w+pYbSjfa8EPRx5sxysrfiWFLjm78CReJV8qyHWtQKvUzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L/5PXNDluLKZmqzxLH8/24YXPSxVHWYiAxOH817RJNQ=; b=ouVp0yrfAPyv43yiSNUWxo/3pX6PgDagAz047jfB4I6BsJeRzX984orDtvbwJM3kOlA/XutYtPFjCy4ze/0k6KWH5djyBmBrKeM2wUabok0RwTBroNFsFvvR2tp7j2G8YW/bGqKkZ5IvmMfUM1M2MwQOw8Hrhrlam6Ym1C+VVuBQj3eAAvfZpMR8FV+lMWDkqDLnQb4btLfXFklZpsrjctAwEsk8NBuuePCUHAl0oYvA32rDKr0g2kwcIfHWYVW38AD2TC/10kjcx7o9rRc1HNpzwF+OQeUnxkuWZrKt3dHnd8pGZ/1c7ybA5NBzw3ydnwryF809bD13tM9aWaKcMQ== Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by AS4PR10MB5576.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4cf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 17:11:56 +0000 Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023 17:11:56 +0000 From: Cyril Arnould To: =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Subject: AW: bug#63251: 28.2; vhdl-mode contribution Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0gACVj7+AAK+qgIAAAlBPgACFcQCAAAcxaYAAEjUAgAALaByAAOVYgIACFKPRgAALHICAAAgt+g== Date: Tue, 9 May 2023 17:11:56 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> <4FD3B33B-EC2E-4170-8C9F-45DFE8B377D5@gmail.com> In-Reply-To: Accept-Language: de-CH, en-US Content-Language: de-CH X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [8Zk/IE1EucDJejGeftjRSsKslMMQv8+J] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|AS4PR10MB5576:EE_ x-ms-office365-filtering-correlation-id: 1e3849e6-166d-4a0c-dba5-08db50b07e38 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MfdqdB62kg+k9KP6JCxo5jIoLH2jl4FswQ0FfSo8utBeSW5WrGN4V2p/HJlq8jubpq2sU0/+zWvjxfUXey/otC+NVZsvGXmoyn2dH8pvU3cIcMMSoeOkEHYqvzvG2K9JoyH3iv9NYiFfQ7mXID86vIFuKamlpX1Vey9PwEBG+xGq2rQFcdis4hIXMGZmSWP461aQT64rVXN67vGRa+szEanEC28ToEHQXJTWTC4VHNh1dClFrRE44vscr+C/MPcZ8e/yMOPSRsg4wt9gIFeJZpCt/w/Qxf1ecn1dx6AbBtwlO4tY6uMH2Vtb0RnZvWaPxGyxvvajT/HDyQ7XBM0O90BR6ujEv/lU7OhLYE/wTIBfTvkoArtRiuDwSrX//CmhKij9LKwwWPQfHLQCWj2RwwzUcEQy0DvZVXZnq9/GYWzezAqp83Whf5RRybqwlHqQQyyBuW1cnGFpEtp92wZc4umnovk6lQ+yiu/ZUUPlTxrJ1hAxHjxBGs0mdMbOkr5Kw/32WzwFE1xtNpw6FApJocnMmYt6tWdjBjydtzVpKsk5c4mryRnHthyExRQCjLCM x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?sqDfySSNR+xvzp7YZ+JFVGqDRvGE6cwqu7fFRxlFL2DUCY4Bimi+VX36MC?= =?iso-8859-1?Q?4wcfF5K2Sg/CTv+XelHneTPHGo+7RvzOZQP2YgujOKYQtaTxENUV3ZGJVS?= =?iso-8859-1?Q?ZE0o0IQniM0WMMQ/z5x0J5Yi6sGL1g6ZvdiYwtlZTl8kziiLve3lr3Fw+H?= =?iso-8859-1?Q?TmDfDWvrLqrMUne4dVDz1CiKzygUNWrmC2Ryzp4+BRNLfsBemGGu7EfSpE?= =?iso-8859-1?Q?Uew+9j40LwstlEyfj7WVD/na4Wj/A2r1fpyNBLAmOAfDSZZEiCTSr8+Txu?= =?iso-8859-1?Q?SzdDL3uzknEtDXNtJbLFvnpWL2qPc0AQ//bdxgYozBVmi3OmoSYBhQ6xU4?= =?iso-8859-1?Q?OWUdtBcLpwHhsiKoAJl0YgXV6uh2H/du0DFg1GjFakCFQp5OuSmo3fYGeM?= =?iso-8859-1?Q?4TzZDnrf9NoF7yQOukoaOvwqcyRDY3Eh0Ji+OYDxXiWBsE+rMixXXe205+?= =?iso-8859-1?Q?BZmMt42Tqgy6i0sF6uOvI94MHAa4DQ/bKyH6iIEZ4ZhCUUqYO3TVYqOoAJ?= =?iso-8859-1?Q?/GYdaItZWP4XEwLX9ee7ETiVIZKFFr9quYhykVqDDvZ+kA3p8LTkYAXuhq?= =?iso-8859-1?Q?nDYYUpZbXlZWNNEL6TflhhRotKepP2L4qLsBm/lGcZhnuzh4Gcz0S8fE+D?= =?iso-8859-1?Q?MwOd9A005zLSNJKhstYz2UKHXHuQQ4llmzXUNj1CieqVXW4JoVE1lfm6G9?= =?iso-8859-1?Q?35aHx5Uf+S8VBynE7MK0ModK1sasQ9r4PmcOrwUc6L3/pFu+4U8qhPci4F?= =?iso-8859-1?Q?eU4hKVd6SEofbYrnBMGKkpz92BoSn7v9JwW724B47dZCQSeg4GPlm7GzuH?= =?iso-8859-1?Q?WW0tTnkGSy8ROpG7bIYU2MPuKT6FEW7lrUAULSYmbwTZL6/0JmnRd3sAqF?= =?iso-8859-1?Q?ZgkY2qlo8NpqMVmIImjA5IkCh5WXC+U8WftJXzIuaF8EcTgWsZUy4M2FgI?= =?iso-8859-1?Q?OsviRZexcF/neUa++qfws++7AWW5M5ZdHS5nNyZvuQ3OHzFIpzhA4mXxk2?= =?iso-8859-1?Q?4D1yLz38H73CPu8tN/kxk9OnVVGFr5v66obX5hwfvBUO4U7X4VUgu4G96n?= =?iso-8859-1?Q?oHQ2O8uRD2jZ4TzVRkEFcUhcvxNEPfdhSXWqALvx8DNNE3QtylN11klgC3?= =?iso-8859-1?Q?17q4dI7Z/PRsqfG4G8qScSWcQ1htVjgGBPBKHYprmfmG600DoPyo+QJULH?= =?iso-8859-1?Q?r44p7bSuDo0LYTug9nzIBJcq4YjEDAoNJQ6Iy+1SWDMKD6nqeitJVFrX55?= =?iso-8859-1?Q?jvXByhX6TE0GsTRPPAzKR0KBORJoVcinHJToXRKMS2JU4bge6OfoO+zwuH?= =?iso-8859-1?Q?/bhJ?= Content-Type: multipart/alternative; boundary="_000_AS4PR10MB61104A1EA1D2CAF172486C21E3769AS4PR10MB6110EURP_" MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3849e6-166d-4a0c-dba5-08db50b07e38 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 17:11:56.4888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5576 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_000_AS4PR10MB61104A1EA1D2CAF172486C21E3769AS4PR10MB6110EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > subsequent changes will likely rely on existing values to conform strictl= y to the previous type and will likely botch any updating of values that do= n't. I've thought about that, since compilation-error-regexp also accepts HYPERLINK and HIGHLIGHT after TYPE. But if we were to implement those in vhdl-mode, I'd say that nil should remain a viable option for them as well, which is what they currently default to. If it does become a problem with future updates anyway, backward compatibility code could still be implemented after the fact. I'd prefer to leave it aside for now if it's not strictly necessary, seen as it could bring more problems than it solves. --_000_AS4PR10MB61104A1EA1D2CAF172486C21E3769AS4PR10MB6110EURP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

> subsequent changes will likely rely on existing= values to conform strictly to the previous type and will likely botch any = updating of values that don't.

 

I've thought about that, since compilation-error-reg= exp also

accepts HYPERLINK and HIGHLIGHT after TYPE. But if w= e were to

implement those in vhdl-mode, I'd say that nil shoul= d remain a

viable option for them as well, which is what they c= urrently

default to.

 

If it does become a problem with future updates anyw= ay, backward

compatibility code could still be implemented after = the fact. I'd

prefer to leave it aside for now if it's not strictl= y necessary,

seen as it could bring more problems than it solves.=

 

--_000_AS4PR10MB61104A1EA1D2CAF172486C21E3769AS4PR10MB6110EURP_-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 09 13:29:10 2023 Received: (at 63251) by debbugs.gnu.org; 9 May 2023 17:29:10 +0000 Received: from localhost ([127.0.0.1]:44402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwR9C-0002Wb-Ar for submit@debbugs.gnu.org; Tue, 09 May 2023 13:29:10 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:62782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwR97-0002W3-P6 for 63251@debbugs.gnu.org; Tue, 09 May 2023 13:29:09 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4f00d41df22so36261316e87.1 for <63251@debbugs.gnu.org>; Tue, 09 May 2023 10:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683653340; x=1686245340; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=FLbY/EMtrVNeDVIIVGECCRznDYkaLfMpBltrXZLtBdY=; b=nv2+sz01QqlnS006Imiyc1zrSq2IMqrPk51rJHfz7V7OUDtdqGsWyjYnKwOENXxQq3 aud31H5vOCtrDPYGrKy9nEweJmLpPsBK1708QbnLzPPl7U3AQkbdzBqsm6gAkOPCKi82 go2HMDr6r/q6hJ53cNgDRTLUnrhsjajrYtSbYWIqMaLO4bELbJ6weDwCRXiFkF62LyBC PQd5ze5DS7dJj0ey4hHzRwHKCITgxl+mR3OC9skvNPlrPYgRI9owmvQLDvjlugbzTTBR J/1wJpQ9os4KXPuXr19FNwKg+yHS+iGppS6exaG40nMeldMdK1G2N/0/LELOfEsUH286 jCKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683653340; x=1686245340; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FLbY/EMtrVNeDVIIVGECCRznDYkaLfMpBltrXZLtBdY=; b=AaBKIWL/b0xldDFplUgKj0GwgOmSRXrT4oXDO7uplUPmCQJnbaTY7p/c0iOHdcFIQ4 OSX9vZPVkGADfjA9wwBlC/jdvFNfxXgVuaAOhJYDZfo6nURqK1ehAvaj1IEI+aYXW05X nJOQb1Zh9009zesrZlq4MkApX7eteaNQE2v9oqBCC62M3Vu/GcvZbCs6hFZ61TqHzdJf m8viVdPLS12xoMy6+r2Pk/Q8ieDid3FS2dlJMIPE1Hdw2c+xarwebsYXNN7+7ZPKMSrZ EyaSnGlwvkDfabeaA+RLLUbJ/J3ckzQ8voSSfh8BXZW2QRuP8osPCbPkO5xDKIlTtbrw SxOg== X-Gm-Message-State: AC+VfDy4DgOhwiCQd+S9a6E7qRDk+gI+WgchDb/CMbjowg262jxsxGpM EtMe4BxRBgf5oUGySH4KFPw= X-Google-Smtp-Source: ACHHUZ7DeRIIneIvfSVSOuNPXJXsHFlszZ1nu2F55RyJ5+Dgbdkqdd0sM1zrDHxdFIfwpnE7gsOdjQ== X-Received: by 2002:ac2:5328:0:b0:4b6:fddc:1fcd with SMTP id f8-20020ac25328000000b004b6fddc1fcdmr813294lfh.23.1683653339680; Tue, 09 May 2023 10:28:59 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id w9-20020a05651204c900b004efee4ff266sm415802lfq.67.2023.05.09.10.28.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2023 10:28:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63251: 28.2; vhdl-mode contribution From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Tue, 9 May 2023 19:28:58 +0200 Content-Transfer-Encoding: 7bit Message-Id: <8E1D520A-E795-40C3-90E3-098D1C50B684@gmail.com> References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> <0E7DAFC0-0F1E-48B7-AC2F-D84D081C05C9@gmail.com> <4FD3B33B-EC2E-4170-8C9F-45DFE8B377D5@gmail.com> To: Cyril Arnould X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63251 Cc: Reto Zimmermann , Eli Zaretskii , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 9 maj 2023 kl. 19.11 skrev Cyril Arnould : > If it does become a problem with future updates anyway, backward > compatibility code could still be implemented after the fact. I'd > prefer to leave it aside for now if it's not strictly necessary, > seen as it could bring more problems than it solves. That's fine. From unknown Thu Aug 14 17:27:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Jun 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator