Subject: Re: bug#63251: 28.2; vhdl-mode contribution

From: Mattias Engdegård <[email-masked]>
Date: Tue, 9 May 2023 18:41:39 +0200

9 maj 2023 kl. 18.16 skrev Cyril Arnould <[email-masked]>:

> By defining the error message type to be nil rather than 2, we
> can forego the backwards compatibility code.
> <fix-vhdl-compiler-customization-4.patch>

Looks fine (although I had hoped to establish a precedent for less mutation in the updating code...).

Actually there is another argument to include updating code: subsequent changes will likely rely on existing values to conform strictly to the previous type and will likely botch any updating of values that don't.

For example, if yet another value is added to the entry, then it cannot just be appended to each entry because that entry might be too short because of the incomplete previous update.