From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 13:06:27 2023 Received: (at submit) by debbugs.gnu.org; 2 May 2023 17:06:27 +0000 Received: from localhost ([127.0.0.1]:44917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pttSN-0002R9-26 for submit@debbugs.gnu.org; Tue, 02 May 2023 13:06:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:40214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pttSJ-0002Qz-BU for submit@debbugs.gnu.org; Tue, 02 May 2023 13:06:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pttSI-0005wA-Qv for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 13:06:23 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pttSE-0007Yq-Bw for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 13:06:22 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-2f55ffdbaedso2489343f8f.2 for ; Tue, 02 May 2023 10:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683047175; x=1685639175; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=+vmDGOAAMDZE6V866AtxthQr0O7roM8PyWD0Wa2H9bU=; b=JX64BsawrKHjFsBR/yWO6s+fVLKowa63qTg/QgKDG1Pqs67RfscD7Cr+P3hSkMYmk4 CjxgcsNh2w1QZy5DojAQ93o/p1l3YvAKFzqut55GDtEp67mouSKXnzjoiB9GbcfoaNLy XaYqkZEi1AwlHh1gRh+Lyn5cgAkNv7Jzc65CMjhZyoNp5+hwPjJ2jGRHv9FBiVLw9isX t1/B5mFhINbb6WIi7uqHpnyDnDbUoXqr8EbpA+GTtOIbOrVPSVFlQxMQa+XVlieQpxhw BeruAhGE/n25MuoCO7LgWuxfV3qhN5bLBdOXEYHVUHeJwur/a7a43vvsz+OHMAAyObfz fbEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683047175; x=1685639175; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+vmDGOAAMDZE6V866AtxthQr0O7roM8PyWD0Wa2H9bU=; b=ZtOQ610A3SOZfBofY/hsBqjKIQIZaSorPjw5NCB724cTvFg00Ke/z5gET7ks5Ti+7G ULs4Di+7QflWgNIUjC0XwI8E6WGPUDbrvH842U3QsyDTJC3PNSyfIa1lsRWso3SYEVwM mgXCMddWrGLjQGh5QeNGcfeX26wXjRfj/we5CiiKEffrJZ2LBonhfDEjkz6YOWF3S5ej McAB0i5lW4lCqsiY/I+KWiniVnlbx2TDRnI1nvfOFbp5rzgF0n3aJJ5PyEJZXpspryaE x+W1o6BZtIVIUj+Zj84RJDHFgocZqeocBF30KN398f1vZeBi4zsMQtAYEpaQknsqQzcR Xsag== X-Gm-Message-State: AC+VfDxEXfZtsc2MrYjQnQJF8h0nGnXg0qN7AJSJGV3qBMQa2YpT2HVO whBBIn8hZKTi2tYIu/liCEBPEXz68/U= X-Google-Smtp-Source: ACHHUZ7hUvyaKIza3PDtZGEeE1P2haY2vl7DS7SwprqqAt3gh9dwTeV2db0AV9ZgotGofaB1g37VNA== X-Received: by 2002:adf:e689:0:b0:304:760c:6474 with SMTP id r9-20020adfe689000000b00304760c6474mr13734670wrm.10.1683047175274; Tue, 02 May 2023 10:06:15 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id w23-20020a05600c099700b003f17af4c4e0sm39239874wmp.9.2023.05.02.10.06.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 10:06:14 -0700 (PDT) From: Robert Pluim To: bug-gnu-emacs@gnu.org Subject: 29.0.90; loaddefs-generate not 100% backwards compatible X-Debbugs-No-Ack: yes Date: Tue, 02 May 2023 19:06:14 +0200 Message-ID: <87cz3ill2x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I attempted to upgrade my packages today using `list-packages', which errored out when regenerating the autoloads for vlf-write.el: Debugger entered--Lisp error: (search-failed "\n\f\n;;;") search-forward("\n\f\n;;;") loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250" "/home/r= pluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list 'load-pat= h (or (and load-file-name (f...") package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-20191126.2= 250") The vlf-autoloads.el file ends like this: --begin-- ;;; Generated autoloads from vlf-tune.el (register-definition-prefixes "vlf-tune" '("vlf-")) ;;; Generated autoloads from vlf-write.el (register-definition-prefixes "vlf-write" '("vlf-")) ;; Local Variables: ;; version-control: never ;; no-byte-compile: t ;; no-update-autoloads: t ;; coding: utf-8 ;; End: ;;; vlf-autoloads.el ends here --end-- which doesn=CA=BCt contain "\n\f\n;;;" after the vlf-write entry. The code in question from loaddefs-gen.el:629 is (when (file-exists-p loaddefs-file) ;; If we're updating an old loaddefs file, then see if ;; there's a section here for this file already. (goto-char (point-min)) (if (not (search-forward head nil t)) ;; It's a new file; put the data at the end. (progn (goto-char (point-max)) (search-backward "\f\n" nil t)) ;; Delete the old version of the section. (delete-region (match-beginning 0) (and (search-forward "\n\f\n;;;") (match-beginning 0))) (forward-line -2))) So it=CA=BCs assuming that the entry ends with ";;;" This is a really old package, and it=CA=BCs probably somewhat obsolete, but perhaps we should support such an old format without erroring anyway. In GNU Emacs 29.0.90 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2023-05-02 built on rltb Repository revision: 16ecbf5af6d4fcb500941ede4d029cffd8eac757 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 System Description: Debian GNU/Linux 11 (bullseye) From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 04:40:38 2023 Received: (at 63236) by debbugs.gnu.org; 3 May 2023 08:40:38 +0000 Received: from localhost ([127.0.0.1]:45533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu82Q-0000cQ-9T for submit@debbugs.gnu.org; Wed, 03 May 2023 04:40:38 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:62894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu82O-0000cC-OH for 63236@debbugs.gnu.org; Wed, 03 May 2023 04:40:37 -0400 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3f315735514so13720205e9.1 for <63236@debbugs.gnu.org>; Wed, 03 May 2023 01:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683103230; x=1685695230; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0QV7oUHWEA/bda+oyfLg2OAH7w/003pTzGIm5Wh3dxc=; b=HYGtZZPyVkzJK1ay1CJS3/uG8TdPAcE+mUjAZUt5YvdhMp3q3UHXWxIsKebthOfolV fTk7Mh1bROdBnzwebkkDGDFt3tnra8IsvCRfuVrfVlo0dK1OqLLzGRXX3iIdNfIjHveM Df8hYoe9VNPGWUP0T+/lKkowKh4kwPouOQzhmWp8EGczRVJfFQWyTclz6jlsWKjv7BFY nouUxt1b2bX7O1/YTftuB1ZZrQXYVQenkMMFuj8a9k3NyDQYiom41lOq6EVFSvEzLLKg M6sVM71A9s+C81+IoklbWiGClE99y3ypti5rxF7nrfeV9/dBl0ccwrIyz1rlf7n29cPe 6oiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683103230; x=1685695230; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0QV7oUHWEA/bda+oyfLg2OAH7w/003pTzGIm5Wh3dxc=; b=DcxTNq1zZeSt7Pq9+U907TP1cX4Do9IomTLZN5FooM/oXEpXVBqr8POZ7c8GCSw7/4 EzekBUiJ6ysQK/oyPuLBhg+3odAqSLfrgXeuR5Nsv4h/JLKpOm3ae27Oe9qMH8wfA8Al KoGg5BXp4AX3RHJUxd27FGR7/+bbtnWdEwPDO1nRL2e1ft+lj37+KRex2ynUs+YXXaXq VL8mTxumqDsJlo/aqj9hgDN6KEpb/rtvfd005aQ3Fj/liyPzmolxW22Tb+S8tfBCZDOa BLkdj3OHyoVTtFmOm213aOeQ4XkNvvSwARgwt81qaBXZfsJpiEQERh0LJIrd7NDZjXcw TZ4w== X-Gm-Message-State: AC+VfDwwFh+b+dYPI8YPeG4+4eA0y1vnwgDXaXdREBsz0cOBqSkkH3bk E9c4tdcksHWmWkPKfa/kfrhbJw+6vjU= X-Google-Smtp-Source: ACHHUZ6kpUQTl/8ArE3ddXQlsZ+ub0rK7RhhC0VdulhZykam6QrKsBywhSZqSSgodJCkCuJUw1tf3A== X-Received: by 2002:a05:600c:5102:b0:3f1:7510:62e8 with SMTP id o2-20020a05600c510200b003f1751062e8mr910469wms.3.1683103230354; Wed, 03 May 2023 01:40:30 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id q3-20020a1cf303000000b003f3157988f8sm1167891wmq.26.2023.05.03.01.40.29 for <63236@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 01:40:29 -0700 (PDT) From: Robert Pluim To: 63236@debbugs.gnu.org Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible In-Reply-To: <87cz3ill2x.fsf@gmail.com> (Robert Pluim's message of "Tue, 02 May 2023 19:06:14 +0200") References: <87cz3ill2x.fsf@gmail.com> Date: Wed, 03 May 2023 10:40:28 +0200 Message-ID: <871qjxlseb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63236 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim s= aid: Robert> I attempted to upgrade my packages today using `list-packages',= which Robert> errored out when regenerating the autoloads for vlf-write.el: Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;") Robert> search-forward("\n\f\n;;;") Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.22= 50" "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-li= st 'load-path (or (and load-file-name (f...") Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vl= f-20191126.2250") The minimal patch I can come up with is this, which seems safe enough but I=CA=BCd appreciate it if someone who knows the code could comment diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen= .el index a966b1e9f40..c25950a1afd 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -637,7 +637,7 @@ loaddefs-generate (search-backward "\f\n" nil t)) ;; Delete the old version of the section. (delete-region (match-beginning 0) - (and (search-forward "\n\f\n;;;") + (and (re-search-forward "\n\f\n;;;?") (match-beginning 0))) (forward-line -2))) (insert head) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 04:49:06 2023 Received: (at 63236) by debbugs.gnu.org; 3 May 2023 08:49:06 +0000 Received: from localhost ([127.0.0.1]:45542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu8Ac-0000vG-AO for submit@debbugs.gnu.org; Wed, 03 May 2023 04:49:06 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:43788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu8AY-0000ue-7K for 63236@debbugs.gnu.org; Wed, 03 May 2023 04:49:04 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A7A7A2248D; Wed, 3 May 2023 08:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683103736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NPsd5IT1wUsRPcZYW5MsNyVlqt4jGU7sbsq/ppL/IGA=; b=MEF0bqUe5GiVt040M7BdpHVocjQIkAIKZ6hivqbFY8IUMPCZ2qfFXc0eBAOrbH55H+X2hs N5EKqy0jGFyY6etZSDlRXHO/J4g6yf+c0sNG9bwIe+J8W43KglvDe4A8qCtHiQkbaLW1nM pWxstttEa5P2E7MwbcEr02Q7vRLWMCA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683103736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NPsd5IT1wUsRPcZYW5MsNyVlqt4jGU7sbsq/ppL/IGA=; b=aR9Ncg3w/ur1VsgiILrpaA0FNpyDigPyGdwV0/dguItm1XoxLCGBDGftg6WM4rCcJ3h9Wk t4ZCtQgu/QDiFLAQ== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 971D02C141; Wed, 3 May 2023 08:48:56 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 867884AAD8C; Wed, 3 May 2023 10:48:56 +0200 (CEST) From: Andreas Schwab To: Robert Pluim Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible In-Reply-To: <871qjxlseb.fsf@gmail.com> (Robert Pluim's message of "Wed, 03 May 2023 10:40:28 +0200") References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> X-Yow: Yow! Maybe I should have asked for my Neutron Bomb in PAISLEY-- Date: Wed, 03 May 2023 10:48:56 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mai 03 2023, Robert Pluim wrote: > diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el > index a966b1e9f40..c25950a1afd 100644 > --- a/lisp/emacs-lisp/loaddefs-gen.el > +++ b/lisp/emacs-lisp/loaddefs-gen.el > @@ -637,7 +637,7 @@ loaddefs-generate > (search-backward "\f\n" nil t)) > ;; Delete the old version of the section. > (delete-region (match-beginning 0) > - (and (search-forward "\n\f\n;;;") > + (and (re-search-forward "\n\f\n;;;?") This is equivalent to (search-forward "\n\f\n;;"). > (match-beginning 0))) -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 07:20:29 2023 Received: (at 63236) by debbugs.gnu.org; 3 May 2023 11:20:29 +0000 Received: from localhost ([127.0.0.1]:45720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puAX6-0005uT-U1 for submit@debbugs.gnu.org; Wed, 03 May 2023 07:20:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puAX1-0005u9-6F for 63236@debbugs.gnu.org; Wed, 03 May 2023 07:20:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAWv-0006Bh-UT; Wed, 03 May 2023 07:20:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZPtzoZAHzkYajmzEi5oswfQeDRP2bGqQ4LxMzbC4Cqk=; b=g2jXGLrOS72O+gGToXOg w6shVX8d+PTSeIkL+YTu3qBPyBs0A4ctHjd81tTBLAQ1bEw2MFRtZ9c3qx6D6H9plb6sQ09Tes1fn 4vWhUhKoUYuuyt6o39B6lUdjTLyvakRT/+iV7wpHhqM7k4/Um+zmLoeTCMdYEKQ/AyxXkn/FOEybL Y+Qywg+QWUsb1TCk/N+1Hiijd3I58xFfHcLA7lYz+q+h/jKtfuy9DNFS1Ac2EgIodY5iPcqhZgj1I uUjYwLO8iMERbzv0jKxkuOeMgNfhO8KOsaEyqB1f82ipqH7V3UFqn8fQNtfHM54dw4O0dLfymukIo 0B6fKnLTwd2wXg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAWv-0006YS-2m; Wed, 03 May 2023 07:20:17 -0400 Date: Wed, 03 May 2023 14:21:05 +0300 Message-Id: <83bkj1mzj2.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <871qjxlseb.fsf@gmail.com> (message from Robert Pluim on Wed, 03 May 2023 10:40:28 +0200) Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Date: Wed, 03 May 2023 10:40:28 +0200 > > >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim said: > > Robert> I attempted to upgrade my packages today using `list-packages', which > Robert> errored out when regenerating the autoloads for vlf-write.el: > > Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;") > Robert> search-forward("\n\f\n;;;") > Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250" "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list 'load-path (or (and load-file-name (f...") > Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250") > > The minimal patch I can come up with is this, which seems safe enough > but Iʼd appreciate it if someone who knows the code could comment Can you describe what was special in your use case, and explain why the original code didn't work in that case? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 09:47:31 2023 Received: (at 63236) by debbugs.gnu.org; 3 May 2023 13:47:31 +0000 Received: from localhost ([127.0.0.1]:45986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puCpO-0004Jm-RZ for submit@debbugs.gnu.org; Wed, 03 May 2023 09:47:31 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:62493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puCpN-0004JT-27 for 63236@debbugs.gnu.org; Wed, 03 May 2023 09:47:29 -0400 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3f315712406so25410895e9.0 for <63236@debbugs.gnu.org>; Wed, 03 May 2023 06:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683121643; x=1685713643; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=w2mJFhCq02OBqsmprabfD3EIf9uuwIsB9l02c8W30Ok=; b=XmvOglj2B3/KWogPnK+p3jYRXhNpiBgUBfCGMqgf9RJf2VFaCvj6WzeYVP05bdMEbm b3eFKPYGe1lNV6z/A/VEue2+aWwqIZKnCIMrmW/cfgBfgZgyolECXWAtoe79xSWq3lKk i3br65Y6ED+onv77qMxGsf2N/wr9n+jmAMaNdZBSoTlI5in9fSVmdl2E0Qqcm51ZGYfx 4J0H3bGcjtKZ3YlPEAJx7af4Kn1Z/x4TujcGVSCClrLD6OJ8TV0foCuNjUy7rupRPvZA YcICgpncTFKbgqnkYz71+4nenk+QQcbCYZinyVhZXNMX+0bZ8UKFa5Uq8qnu047g/0ZD XQZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683121643; x=1685713643; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w2mJFhCq02OBqsmprabfD3EIf9uuwIsB9l02c8W30Ok=; b=cNFG2Oc2EFVWy2uB3Ve4h477IAruwhmcBGjRJ/m9t8/90yCfxg3UoSePC6BaUEbF71 8OdlTMx77/Ywa6KDUfXBaHHHLxFXQ6XOTrV++h7R4bwvLgCezpq4qtRKkboaicRZNJ5q Q2h17VxNJehh+rUffUX7Z5FCyC5weQZkWO2oKzAU9GVdXMq2sRtqOVnKWHJgvruolVCG IHQHys1Zpz7FKArrekyaRVC/tzN9WZub4weJntgK2sZkcchqO5fREkcftyEBUTnzKPxE uICh6eXu/sBoqT4AasPZbruTfcoZO0XL3ZgIn0JW/KkJBnYgnEa5vNEVFR8XWYeqrsMp fYfQ== X-Gm-Message-State: AC+VfDzrX65zZgZham2o9B2cFdEh50cEHtWMlUDKOn4wPFIlil2FYlrk mFOjAn5q0XtYuzAuw7O29zaoRlXEAMA= X-Google-Smtp-Source: ACHHUZ532EwSNke746/elUZIs2aBUNmjj8rfQrFBI9I6wvK5XBbMmaS99CpXOeGeV53v2dxaK3jzlA== X-Received: by 2002:a5d:5689:0:b0:304:7bbf:7c1e with SMTP id f9-20020a5d5689000000b003047bbf7c1emr144483wrv.4.1683121642522; Wed, 03 May 2023 06:47:22 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id m8-20020a7bcb88000000b003f173956a82sm1987222wmi.21.2023.05.03.06.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 06:47:21 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible In-Reply-To: <83bkj1mzj2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 May 2023 14:21:05 +0300") References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> Date: Wed, 03 May 2023 15:47:21 +0200 Message-ID: <87wn1pjzme.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 03 May 2023 14:21:05 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Date: Wed, 03 May 2023 10:40:28 +0200 >>=20 >> >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim said: >>=20 Robert> I attempted to upgrade my packages today using `list-packages',= which Robert> errored out when regenerating the autoloads for vlf-write.el: >>=20 Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;") Robert> search-forward("\n\f\n;;;") Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250= " "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list= 'load-path (or (and load-file-name (f...") Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-= 20191126.2250") >>=20 >> The minimal patch I can come up with is this, which seems safe enough >> but I=CA=BCd appreciate it if someone who knows the code could comme= nt Eli> Can you describe what was special in your use case, and explain why Eli> the original code didn't work in that case? It=CA=BCs not the use case that=CA=BCs special, it=CA=BCs the package I was= installing: The autoloads file shipped with vlf-20191126.2250 didn=CA=BCt have a line starting with ';;;' after the final entry in the file, which is what the code was looking for. Looking at the history, the autoloads generation was rewritten for emacs-29, so this looks like a minor regression. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 11:02:23 2023 Received: (at 63236) by debbugs.gnu.org; 3 May 2023 15:02:23 +0000 Received: from localhost ([127.0.0.1]:47500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puDzr-000753-HO for submit@debbugs.gnu.org; Wed, 03 May 2023 11:02:23 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:56794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puDzp-00074o-BE for 63236@debbugs.gnu.org; Wed, 03 May 2023 11:02:22 -0400 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3063208beedso3012827f8f.1 for <63236@debbugs.gnu.org>; Wed, 03 May 2023 08:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683126135; x=1685718135; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dLiIKjx0ltavekLoQT+hjWTA0MYveLszSOhKQXAqMTw=; b=Tz+fTwRriqR4PILXtpRaKKSIDR+1Q+C3AOy9Gl4UiixhAs7x6gFXGfAoxWN7y3Zdcm NCn5PJfrwui2/cX4vzkkQqZ+Amw0XrEpD0uIFrLfJMlAvqzAQzRnPCKQBkrL9/2jJ1c0 ofAusYIYPh5TFOv3vj0KHpugNo37nGMfNzxtJSQ71AW9HuOzLSzejOMg94W2FnM+kQbD XrCxSrYV2vxgaP4tXoV7iaXsGtk9R/p+YFLwbZP6QCoCWSAWAh060Lruw1tLiNL/IFsi dUVub7BQH07+9iM9wW6M0QuPztTOK0zfsB6L6hkaqdUkyOMXvUE+ZbrihdufBVuCeIBr egkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683126135; x=1685718135; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dLiIKjx0ltavekLoQT+hjWTA0MYveLszSOhKQXAqMTw=; b=c8bBJ6Ftr27Hbest/pSlsGnRirgmpKQc7iPbiBNdhXLLTZDR3KuO6xyZjxBrF0RdWN MDmdJklIOvoTACI+vkta42ZyZt3DvgE9puw2TCfb2oEusvQPe1HMd+18hYeE8EOLg5q5 0Cl+UcqGln6Cm8XZgMelOPw1iMhVg4lY769pspQfNGZG8v2UdYahF29WJpHlyP8rMpDD +nbchhqVCkOvTTaiHStHgK1Llls+ffBIohbQ/VvdSl+Py59xo6Mi4aPjCZuBmqTZYWeU 3A2DZsttVpKgHId1JM66pTUZCe/7ShxHff3sYtTNjqlwc5MRyWkY7VUweLslCr9w+XLg kmvQ== X-Gm-Message-State: AC+VfDybuGEznNLVnijduBXJVlMbHKxLADMMk/E+GZEx+87ALaG90ZoW ngumbj8XVX3vVSJJxsq2cWBSfgWhu9E= X-Google-Smtp-Source: ACHHUZ6s0ev6B1hVE6t2IthpLTL+pvI8tlqpaGSsatxyokWczwPgINEJu5+Oa7bekS4/lqGiCG8n+w== X-Received: by 2002:adf:f952:0:b0:2f1:e162:d48 with SMTP id q18-20020adff952000000b002f1e1620d48mr236216wrr.47.1683126134827; Wed, 03 May 2023 08:02:14 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v22-20020a7bcb56000000b003f1751016desm2165872wmj.28.2023.05.03.08.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 08:02:14 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible In-Reply-To: <87wn1pjzme.fsf@gmail.com> (Robert Pluim's message of "Wed, 03 May 2023 15:47:21 +0200") References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> <87wn1pjzme.fsf@gmail.com> Date: Wed, 03 May 2023 17:02:13 +0200 Message-ID: <87sfcdjw5m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 03 May 2023 15:47:21 +0200, Robert Pluim s= aid: Robert> Looking at the history, the autoloads generation was rewritten = for Robert> emacs-29, so this looks like a minor regression. And I=CA=BCve just tried installing with emacs-26, emacs-27, and emacs-28, and they all work, but none of them produce the format that=CA=BCs in the vlf package itself. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed May 03 11:49:41 2023 Received: (at 63236) by debbugs.gnu.org; 3 May 2023 15:49:41 +0000 Received: from localhost ([127.0.0.1]:47553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puEjd-0008Mn-F8 for submit@debbugs.gnu.org; Wed, 03 May 2023 11:49:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puEjZ-0008MX-Ft for 63236@debbugs.gnu.org; Wed, 03 May 2023 11:49:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puEjU-00030X-4M; Wed, 03 May 2023 11:49:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=EFKfJEF8xNdTeZXL8P2PJKaPrrM/e6xIFWYTvJ9HH9c=; b=B/IJ6h1CYbNHryKOa2oi ts3dpQ+G4glXw19zdBtiHTPPOshoUL1oUHivfa9kniL2x2h/Dti17NgZZ0UDuoSYizVFr7EgpkVrK pswy6c9N1HX+onOJLJ8D0dEwTCv0xO1N0oSmOjA/vCSnvJSJ72VQsHI0d+ZGl56V2S8h2lDiRC55R A9v4weIHTl5Op/yxZcrUT4+Js9v41eyJceJCY6rFHCALvL9jyxzcFFtMOJy9NEKkj/nm/H3jW2Ovk 09u2oI0NNWcD0h/2TvNAcJFpleSAB108HZVk7wf3i4i7IDFa5UKxkYZm7Nmdlz9I6NYnhES3Xufei eXUYD561TMfgJw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puEjT-0006Yf-Cx; Wed, 03 May 2023 11:49:31 -0400 Date: Wed, 03 May 2023 18:50:20 +0300 Message-Id: <83354dmn2b.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87wn1pjzme.fsf@gmail.com> (message from Robert Pluim on Wed, 03 May 2023 15:47:21 +0200) Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> <87wn1pjzme.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 63236@debbugs.gnu.org > Date: Wed, 03 May 2023 15:47:21 +0200 > > >>>>> On Wed, 03 May 2023 14:21:05 +0300, Eli Zaretskii said: > > >> From: Robert Pluim > >> Date: Wed, 03 May 2023 10:40:28 +0200 > >> > >> >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim said: > >> > Robert> I attempted to upgrade my packages today using `list-packages', which > Robert> errored out when regenerating the autoloads for vlf-write.el: > >> > Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;") > Robert> search-forward("\n\f\n;;;") > Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250" "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list 'load-path (or (and load-file-name (f...") > Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250") > >> > >> The minimal patch I can come up with is this, which seems safe enough > >> but Iʼd appreciate it if someone who knows the code could comment > > Eli> Can you describe what was special in your use case, and explain why > Eli> the original code didn't work in that case? > > Itʼs not the use case thatʼs special, itʼs the package I was installing: > The autoloads file shipped with vlf-20191126.2250 didnʼt have a line > starting with ';;;' after the final entry in the file, which is what > the code was looking for. But if the search for "\n\f\n;;;" fails, why should we assume that the search for "\n\f\n;;" will succeed? A broken autoloads file can be broken in a much worse manner, no? Is even a form-feed guaranteed? Maybe we should assume, if the search for the canonical last line fails, that there's no canonical last line, and just insert it ourselves? What did the old code do in these cases? > Looking at the history, the autoloads generation was rewritten for > emacs-29, so this looks like a minor regression. Yes, loaddefs-gen.el is new, so we must fix it on the emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 04:45:49 2023 Received: (at 63236) by debbugs.gnu.org; 4 May 2023 08:45:49 +0000 Received: from localhost ([127.0.0.1]:48538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puUay-0001KS-OX for submit@debbugs.gnu.org; Thu, 04 May 2023 04:45:49 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:51499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puUav-0001KE-UG for 63236@debbugs.gnu.org; Thu, 04 May 2023 04:45:47 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f192c23fffso1307335e9.3 for <63236@debbugs.gnu.org>; Thu, 04 May 2023 01:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683189939; x=1685781939; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1qidapiJEwWSASf3J6qP7LCt4NEN6nt2xxXqwNJT8XU=; b=hrMvTkS4alvjOv9H/OhxCeisXTeCawlD8UwemTz9cYq60icDgLWJojSkxJNV25LtxC 5dVvXKyzIl4uHII04Quh8BJIxMtKwgofWS3t9qQb9tSQFt+FBvwhAmMWVTohLFy7QfP4 g8JnVY/odf+HTfu59ALR5zzpdguZuLTjkjKUYqolaHNr9CH2aQyIr+OO13qCZcjID2sJ +TUsrLXTENV458/wmck5udIyXfKpDmxqJDIzuLW9WL7bBOZXRKnYw+sjrMym3Fu/lMwj 7/WFqHmfY5lOmviiaoRwdGVo//YD43KyM7zbUq6MowZ2wEDlpO2KhobAPd1e4R3CW54b LPFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683189939; x=1685781939; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qidapiJEwWSASf3J6qP7LCt4NEN6nt2xxXqwNJT8XU=; b=gIyrlYvzc+NxtMLQLTknJEljbzlgM0lsZP0jlWnnYgKSwKj567pKNG+Y1yTmsp8biJ kVLpcwcfgi4LoHFxdmS2OmpCduZjej1rCUtvx/GJ5XDDTYJ8TM+/zG5SGkZOOUAAz6mR PlnMhP1XLnaZ28IWdtEl+itaV/MHIsLrDpA6XjmZAwPLzjw4YdX5uFnfi1u+7LknqpbL emF6gKdmcGxw+Nhm3eWwjF69C808xPkJ2uOVPTdJQ5lCkE5T4TbbOwyzEke2RpeJP/bF qOnpsijH/ldA9A3nLR7hoew2MnXXDMqgQlm+MuO63Ytq7nrk6QGIpGe3vwUMGhPSBzZZ W8aw== X-Gm-Message-State: AC+VfDzm7nRD2ghzKgUKcLWvYF+qWHlpcTZnw+76ed9No0rFE1FZJICW Y29OC1gIfdEKnMLMWYcrEIDbWzrRaFM= X-Google-Smtp-Source: ACHHUZ4whZnR0pMm7dFudazKoNHfARZPOJL1Gvc+dFQMQLreLO0DmPKYzaBEBfYsZRoaKlgkQsOEdQ== X-Received: by 2002:a7b:cd18:0:b0:3f1:6fe2:c4b2 with SMTP id f24-20020a7bcd18000000b003f16fe2c4b2mr16479282wmj.23.1683189938550; Thu, 04 May 2023 01:45:38 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id c10-20020adffb0a000000b00306344eaebfsm7677123wrr.28.2023.05.04.01.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 01:45:37 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible In-Reply-To: <83354dmn2b.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 May 2023 18:50:20 +0300") References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> <87wn1pjzme.fsf@gmail.com> <83354dmn2b.fsf@gnu.org> Date: Thu, 04 May 2023 10:45:37 +0200 Message-ID: <87lei4jxhq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 03 May 2023 18:50:20 +0300, Eli Zaretskii said: Eli> But if the search for "\n\f\n;;;" fails, why should we assume that= the Eli> search for "\n\f\n;;" will succeed? A broken autoloads file can be Eli> broken in a much worse manner, no? Is even a form-feed guaranteed? Nothing is guaranteed, but in the only example in the wild I=CA=BCve found = where the emacs-29 code fails, searching for only two ';' works. Eli> Maybe we should assume, if the search for the canonical last line Eli> fails, that there's no canonical last line, and just insert it Eli> ourselves? Yes, but the issue here is that the code is deciding where to end the region that it=CA=BCs deleting from an existing autoloads file. If we don= =CA=BCt do the deletion, we get duplicate entries (or maybe even a broken autoloads file). Eli> What did the old code do in these cases? I=CA=BCm not sure. A quick read of emacs-lisp/autoloads.el in emacs-28 seems to indicate it=CA=BCs looking for ';', but I haven=CA=BCt actually te= sted it. >> Looking at the history, the autoloads generation was rewritten for >> emacs-29, so this looks like a minor regression. Eli> Yes, loaddefs-gen.el is new, so we must fix it on the emacs-29 bra= nch. Then the easiest fix would be to search for two ';' instead of three. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 06:41:36 2023 Received: (at 63236) by debbugs.gnu.org; 4 May 2023 10:41:37 +0000 Received: from localhost ([127.0.0.1]:48643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puWP2-0004oj-K0 for submit@debbugs.gnu.org; Thu, 04 May 2023 06:41:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puWOz-0004oT-L6 for 63236@debbugs.gnu.org; Thu, 04 May 2023 06:41:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWOu-0000bM-E5; Thu, 04 May 2023 06:41:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+8RGCk5DL7EnA2YIu8STjVSFi7Uj4WU0/49/HHlC9aI=; b=FDQzIKxVLziU K8Tz8iSsONkEWlNK1KhXpic1nsF+ySoRj12nalbt8O4/jhqpk4sMvXkKYsJyWPMHNRoLnyui8xUEB aupy1Fz/ZPqwtz3D/GEwUcFQLQANBHf7agTAUvr37e9++4ubNs0+/YzX61iRUUE+ZKY6N1ssr2gKU d+0NGrqP7WO7fHuxCwLjODrfpUXjG1qJLd/H0tzpOmvdLDwkspdFYN1Bs0y/K7Ev9/eUDMBxoI0yc U80neioGP0cfLhb/hXxyuf8npb+yptP8cKnxQvt+ruefO3iSUD4kc8LHb02rf6W3sIi35Xhu5gWMD qJUx4AxgyoPcBeL169hV0Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWOf-0002bI-Sp; Thu, 04 May 2023 06:41:25 -0400 Date: Thu, 04 May 2023 13:42:05 +0300 Message-Id: <837ctol6o2.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87lei4jxhq.fsf@gmail.com> (message from Robert Pluim on Thu, 04 May 2023 10:45:37 +0200) Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> <87wn1pjzme.fsf@gmail.com> <83354dmn2b.fsf@gnu.org> <87lei4jxhq.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 63236@debbugs.gnu.org > Date: Thu, 04 May 2023 10:45:37 +0200 > > >> Looking at the history, the autoloads generation was rewritten for > >> emacs-29, so this looks like a minor regression. > > Eli> Yes, loaddefs-gen.el is new, so we must fix it on the emacs-29 branch. > > Then the easiest fix would be to search for two ';' instead of three. OK, let's do that, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 10:04:26 2023 Received: (at 63236) by debbugs.gnu.org; 4 May 2023 14:04:26 +0000 Received: from localhost ([127.0.0.1]:51612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZZK-0005f7-9d for submit@debbugs.gnu.org; Thu, 04 May 2023 10:04:26 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:47317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZZB-0005ea-V3; Thu, 04 May 2023 10:04:22 -0400 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-2fddb442d47so469516f8f.2; Thu, 04 May 2023 07:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683209051; x=1685801051; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NkNeXpzb8b1ccV0lPLyWJa90hLujwHmDapKtfxfag+8=; b=O4dFMG7Hu6RfVb7hYET0558v4VAUHAorHzRs/teQwSJsfueIR98fz/kmpLmFkML8Bj TWF5pGTEqCw+bBCj6P1rQi1mD/hxO9ClLh2B8gPkAtzTO3bHY+rXY3GYFSJExCdTV57N CdFK1fmwo25TdhMF9vkvd8Iv5UkjvXbRfJoo6A4d78IyHMkntCVTikx9Z9dmG3i7dhaX BS7VhlqanJmSJMyfl0y5e9vfcu5CNWtfRCAKmhll7N8N+7oFC7zcFvmgsYHZjNQqiEOK hMcM4R2Hd236WZvAzeC85qpV6/x21lrB3DAuzHIr3CXmXAVh6O/MtJglt5QWacjvIgMg EV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683209051; x=1685801051; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NkNeXpzb8b1ccV0lPLyWJa90hLujwHmDapKtfxfag+8=; b=Jc8sN1F1ZstyGr+BCVQj9tJKcnuF2cQsxcE+4/eukxWYM271BdnNZFakXrI2JpgSW/ loG7uSel0JaE2tT28ZqxJfHSCTPc+xD7LyVPMQihnFoiTpNeWKDYpewIM4z7rpaEabK3 y9iuwjMKvGWtNruF/AUs0l3Iz5hXreGvVBamLluQ/MIoj2U+2DOBfyaj7K7xQTsVurC9 RDoN1qF4p2ymvIiWq6F4rl0iAaA9emWjfOkXP0rzrb4kfuW+G7Dm64/UP3cAqXQhHJub rzszN9s+cSpLDzr45Ii3HQW6zOFSVFf7fnb46xIZesBY3fCzk2yo5Jvj6AounATkMOog R4jQ== X-Gm-Message-State: AC+VfDz2kyxLd6U7jRJ4uFrPVV8O90HTDPP9xJXneUPD4uF0DCNt44Ha Com3gyivbKm8IGfrdvqoiZkwZpr9PdA= X-Google-Smtp-Source: ACHHUZ5LI0tUxhVt2CtjYJqSFMcfXtN3EKbtHUz+2+Wr1GNW2lYhJ9CLADl0qK/oed+IK0HoSxPMZw== X-Received: by 2002:adf:e883:0:b0:306:2aa7:2ecc with SMTP id d3-20020adfe883000000b003062aa72eccmr2365804wrm.45.1683209051362; Thu, 04 May 2023 07:04:11 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e2-20020a5d5942000000b0030647449730sm3385592wri.74.2023.05.04.07.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 07:04:10 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible In-Reply-To: <837ctol6o2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 May 2023 13:42:05 +0300") References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> <87wn1pjzme.fsf@gmail.com> <83354dmn2b.fsf@gnu.org> <87lei4jxhq.fsf@gmail.com> <837ctol6o2.fsf@gnu.org> Date: Thu, 04 May 2023 16:04:09 +0200 Message-ID: <87zg6knqg6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63236 Cc: 63236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 63236 fixed close 63236 29.1 quit >>>>> On Thu, 04 May 2023 13:42:05 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 63236@debbugs.gnu.org >> Date: Thu, 04 May 2023 10:45:37 +0200 >>=20 >> >> Looking at the history, the autoloads generation was rewritten for >> >> emacs-29, so this looks like a minor regression. >>=20 Eli> Yes, loaddefs-gen.el is new, so we must fix it on the emacs-29 bra= nch. >>=20 >> Then the easiest fix would be to search for two ';' instead of three. Eli> OK, let's do that, and thanks. I=CA=BCve just pushed that. I tested upgrading my packages with the resulting emacs, and nothing broke, as far as I can tell. Closing. Committed as 94e984e6700 Robert --=20 From unknown Mon Jun 23 07:50:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Jun 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator