GNU bug report logs - #63221
30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63221: closed (30.0.50; [PATCH] Eshell should get user (and
 group) IDs in a connection-aware fashion)
Date: Wed, 03 May 2023 04:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 2 May 2023 21:30:14 -0700
with message-id <1460bf56-f93f-3adc-9da2-c0f0f2fc23c2 <at> gmail.com>
and subject line Re: bug#63221: 30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion
has caused the debbugs.gnu.org bug report #63221,
regarding 30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63221: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63221
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Eshell should get user (and group) IDs in a
 connection-aware fashion
Date: Mon, 1 May 2023 22:42:53 -0700

[Message part 3 (text/plain, inline)]

This is sort of a continuation from bug#60722. Eshell gets the user's 
UID/GID in a few places, e.g. to decide when to prompt before deleting a 
file with "rm" (if you're root, it should prompt). However, these aren't 
connection-aware. That means that if you start Emacs as a normal user 
and then run "cd /sudo::", it doesn't recognize that you're now root, so 
it doesn't prompt.

Similarly, Eshell's "ls" implementation doesn't check for the 
connection-aware UID/username for ownership. And likewise for the "U" 
and "G" Eshell predicate operators.

Attached is a patch to fix this, which also adds a new utility function 
'file-group-gid'. Similar to 'file-user-uid' (added in bug#60722), it's 
just a connection-aware version of 'group-gid'.

[0001-Use-connection-aware-functions-when-getting-the-UID-.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63221-done <at> debbugs.gnu.org
Subject: Re: bug#63221: 30.0.50; [PATCH] Eshell should get user (and group)
 IDs in a connection-aware fashion
Date: Tue, 2 May 2023 21:30:14 -0700

On 5/2/2023 11:44 AM, Eli Zaretskii wrote:
> Thanks, LGTM.

Thanks. Merged as 40d66095635; closing this bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.