GNU bug report logs - #63221
30.0.50; [PATCH] Eshell should get user (and group) IDs in a connection-aware fashion

Previous Next

Full log

Message #14 received at 63221 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 63221 <at> debbugs.gnu.org
Subject: Re: bug#63221: 30.0.50; [PATCH] Eshell should get user (and group)
 IDs in a connection-aware fashion
Date: Tue, 02 May 2023 21:44:25 +0300

> Date: Tue, 2 May 2023 11:36:16 -0700
> Cc: 63221 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> > This terse sentence needs to be explained in the rest of the doc
> > string, because, unlike "If non-nil", "When" does not explain itself.
> > The doc string should explain how to specify "when".  It should also
> > explain the different supported values.
> 
> Thanks, fixed.
> 
> >> +  :tag "Query"
> >> +  :type '(choice (const :tag "Never" nil)
> >> +                 (const :tag "Always" t)
> >> +                 (const :tag "When root" root)))
> > 
> > Also, the default value is not one of the possible optional values.
> 
> I changed how this works so now the widget inherits from 'radio' instead 
> of 'lazy', and I think it should work better overall now.
> 
> > Same comment to the other similar defcustoms where you changed a
> > boolean option to something else: their doc strings are now
> > obfuscated.
> 
> Fixed.
> 
> >> +(defun eshell-interactive-query-p (value)
> >> +  "Return non-nil if a command should query the user according to VALUE.
> >> +If VALUE is `root', return non-nil when evaluated as root (see
> >> +`file-user-uid').  Otherwise, simply return VALUE."
> > 
> > You assume here that "evaluated as root" explains itself?  I wouldn't
> > rely on that.
> 
> Also fixed.

Thanks, LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.