From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168297463824645 (code B ref -1); Mon, 01 May 2023 20:58:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 May 2023 20:57:18 +0000 Received: from localhost ([127.0.0.1]:41156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaaE-0006PR-1Z for submit@debbugs.gnu.org; Mon, 01 May 2023 16:57:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:34356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaaA-0006PI-Nz for submit@debbugs.gnu.org; Mon, 01 May 2023 16:57:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaaA-00053w-F0 for guix-patches@gnu.org; Mon, 01 May 2023 16:57:14 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaa7-0001g3-6S for guix-patches@gnu.org; Mon, 01 May 2023 16:57:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LCkuP71cD6ai6gJve04a6jBqppPFjkxFf/r+8pzfM34=; b=KyUwBl8FGwr8UZnFhY6upn1Zb5 D9xY0GJH91S1zC0Lnph2W/yjOXro/q4MT6BRw0k0QwQzYQSi4hNnPo/5nNZpl2qx0ZaKz3uWpZCJ9 fhqo6DA9RUNLRcXVeVUtd+zbKPLzadL9r2CBwNxxrZ13/Fjs9J9dYEz7AQxF2S/anq1p7wJq4ZJqG ITwjL8zCyhU13DWrMklPHrrZpx8DE3L3fc4nLK8EQX8Ua09JTEyzQWO7ooF/7QY8Ebv+Hlrrn7Gr7 UteAujCfLCeDIikaNZP8cg4i4zzxVb3pCgHqxo4WQxt/oV6lXan9kZjQD0p0xPZ8DtTRq5nX8imBK 87n6+jcg==; Received: from [192.168.2.1] (port=48034 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptaZk-000J8n-0n; Mon, 01 May 2023 21:56:48 +0100 From: Arun Isaac Date: Mon, 1 May 2023 21:56:39 +0100 Message-Id: <20230501205639.16201-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, This patchset makes mumi send-email automatically Cc all issue participants. I will push this patchset in a few days unless there are objections. Cheers! Arun Arun Isaac (2): client: Support passing options to git send-email. client: Cc issue participants when sending email. mumi/client.scm | 44 ++++++++++++++++++++++++++++++++++++-------- tests/client.scm | 24 ++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 8 deletions(-) -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 1/2] client: Support passing options to git send-email. References: <20230501205639.16201-1-arunisaac@systemreboot.net> In-Reply-To: <20230501205639.16201-1-arunisaac@systemreboot.net> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 21:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168297493525224 (code B ref 63215); Mon, 01 May 2023 21:03:01 +0000 Received: (at 63215) by debbugs.gnu.org; 1 May 2023 21:02:15 +0000 Received: from localhost ([127.0.0.1]:41162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaf0-0006Yl-NS for submit@debbugs.gnu.org; Mon, 01 May 2023 17:02:14 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:51314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaey-0006YV-Eh for 63215@debbugs.gnu.org; Mon, 01 May 2023 17:02:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GS5z0c4uMKIYg/s/5mo/B0Ggam8gi+s26/147IVrY6U=; b=JCM74dpjyap33AEIhFjiOHNmps tAF7xYCOq11Dw0Qeq+SXEA8peFImG3vRR5Yxgvi5NZoxkPd2ne7KewWf5QqBely5SuwOPaQC7E5/C PFtRPDiM4EQ2tj93iPzmAPe9v4X1X30t/j4nVcslkyDRrqT/hW6uBViIG9R6USkfkKOWO3pvlutKw JAdYZ+2K1j4ekzz6Qe9s5MXnK1Hv9tOd5DrSqH1sG5i9gZtZD9w1OApIXmGLhOifoBeTvRk3bqmjy iiqCVzzJ3sMWZ74S79RZDV0vkJANfwDj8odIjz5oE/g497XgsgB1EM0/GrO6OgkhXo9Ihl/7w85cB tjiuGpdA==; Received: from [192.168.2.1] (port=53838 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptaes-000JAS-1Y; Mon, 01 May 2023 22:02:07 +0100 From: Arun Isaac Date: Mon, 1 May 2023 22:01:50 +0100 Message-Id: <20230501210151.16399-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * mumi/client.scm (git-send-email): Add options optional argument. --- mumi/client.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index b8d588b..2750836 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -207,12 +207,13 @@ arguments." (cut proc port) (cut close-pipe port)))))) -(define (git-send-email to patches) - "Send PATCHES using git send-email to the TO address and return the -message ID of the first email sent." +(define* (git-send-email to patches #:optional (options '())) + "Send PATCHES using git send-email to the TO address with +OPTIONS. Return the message ID of the first email sent." (let ((command (cons* "git" "send-email" (string-append "--to=" to) - patches))) + (append options + patches)))) (display (string-join command)) (newline) (call-with-input-pipe command -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 2/2] client: Cc issue participants when sending email. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168297493525231 (code B ref 63215); Mon, 01 May 2023 21:03:02 +0000 Received: (at 63215) by debbugs.gnu.org; 1 May 2023 21:02:15 +0000 Received: from localhost ([127.0.0.1]:41164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaf0-0006Yn-W9 for submit@debbugs.gnu.org; Mon, 01 May 2023 17:02:15 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:51320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaey-0006YX-EL for 63215@debbugs.gnu.org; Mon, 01 May 2023 17:02:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Nm8dSZW8EJdvciuI5IJBU3IRgGDdbQj+KuXBIgho93E=; b=gpPGl9cIweGEHOLiYp+p0VTHpQ s0/5TYjCmxSb2hwovYiD+JqCLfsiRAJgH4qF5iPHn0wo6xLvoq9dSiTdUITx1Ti/IuOacXZ1msYwa NwMCFB5EYNPqo3xPNTfEdCvUktqHb6KhSRYkKSTDBLo3W1osWyeAEWckSbp2Ug2CHzVE17tuEM8jK m9ZT+aPg7f5dZpfe0TK25/fOCdLlfTJ6L+14qZY5dEAiceODA32F1I7PH9i0IJBg5NZ/J2zXMVkvj kc4xN0rzZ3mGngUp5zrNVVUluZl0xKp8V4PZd50Sk/+UAxwSLXxyv1TQqd27WSms41cZYGo4xqRZJ +UTcJnug==; Received: from [192.168.2.1] (port=53838 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptaeu-000JAS-2H; Mon, 01 May 2023 22:02:09 +0100 From: Arun Isaac Date: Mon, 1 May 2023 22:01:51 +0100 Message-Id: <20230501210151.16399-2-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501210151.16399-1-arunisaac@systemreboot.net> References: <20230501210151.16399-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * mumi/client.scm: Import (srfi srfi-1). (reply-email-headers): New function. (send-email): Call reply-email-headers. * tests/client.scm ("send patches to existing issue", "send single patch to existing issue"): Stub reply-email-headers. ("send patch to existing issue and Cc other participants"): New test. --- mumi/client.scm | 35 +++++++++++++++++++++++++++++++---- tests/client.scm | 24 ++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 4 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index 2750836..0ad49fc 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -18,6 +18,7 @@ (define-module (mumi client) #:use-module (rnrs io ports) + #:use-module (srfi srfi-1) #:use-module (srfi srfi-19) #:use-module (srfi srfi-26) #:use-module (srfi srfi-43) @@ -236,15 +237,41 @@ OPTIONS. Return the message ID of the first email sent." (display (get-string-all port)) message-id))))) +(define (reply-email-headers issue-number) + "Return an association list of email headers when replying to +ISSUE-NUMBER." + (let ((messages + (assoc-ref + (assoc-ref + (graphql-http-get (graphql-endpoint) + `(document + (query (#(issue #:number ,issue-number) + (messages (from name) + date))))) + "issue") + "messages"))) + ;; When sending email to an issue, we Cc all issue participants. + ;; TODO: Also add an In-Reply-To header. + `((cc . ,(delete-duplicates + (map (lambda (message) + (let ((from (assoc-ref message "from"))) + (string-append (assoc-ref from "name") + " <" (assoc-ref from "address") ">"))) + (vector->list messages))))))) + (define (send-email patches) "Send PATCHES via email." (if (current-issue-number) ;; If an issue is current, send patches to that issue's email ;; address. - (git-send-email (string-append (number->string (current-issue-number)) - "@" - (client-config 'debbugs-host)) - patches) + (let ((issue-number (current-issue-number))) + (git-send-email (string-append (number->string issue-number) + "@" + (client-config 'debbugs-host)) + patches + (map (cut string-append "--cc=" <>) + (assq-ref (reply-email-headers issue-number) + 'cc)))) (match patches ;; If it's a single patch, send it to the patch email address ;; and be done with it diff --git a/tests/client.scm b/tests/client.scm index 94c8c5d..f0ff34e 100644 --- a/tests/client.scm +++ b/tests/client.scm @@ -90,6 +90,8 @@ called with." (lambda () (with-variables (list (cons (var@@ (mumi client) current-issue-number) (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const '((cc)))) client-config-stub do-not-poll-server-for-issue-number) (cut (@@ (mumi client) send-email) @@ -116,6 +118,28 @@ called with." (lambda () (with-variables (list (cons (var@@ (mumi client) current-issue-number) (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const '((cc)))) + client-config-stub + do-not-poll-server-for-issue-number) + (cut (@@ (mumi client) send-email) + (list "foo.patch"))))))) + +(test-equal "send patch to existing issue and Cc other participants" + '(("git" "send-email" + "--to=12345@example.com" + "--cc=John Doe " + "--cc=Mary Smith " + "foo.patch")) + (map (match-lambda + ((command _) command)) + (trace-calls (var@@ (mumi client) call-with-input-pipe) + (lambda () + (with-variables (list (cons (var@@ (mumi client) current-issue-number) + (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const `((cc "John Doe " + "Mary Smith ")))) client-config-stub do-not-poll-server-for-issue-number) (cut (@@ (mumi client) send-email) -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH v2 mumi 0/2] Cc all issue participants References: <20230501205639.16201-1-arunisaac@systemreboot.net> In-Reply-To: <20230501205639.16201-1-arunisaac@systemreboot.net> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 22:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16829815375152 (code B ref 63215); Mon, 01 May 2023 22:53:01 +0000 Received: (at 63215) by debbugs.gnu.org; 1 May 2023 22:52:17 +0000 Received: from localhost ([127.0.0.1]:41219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcNU-0001Ky-Lj for submit@debbugs.gnu.org; Mon, 01 May 2023 18:52:16 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:55292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcNS-0001Ki-B7 for 63215@debbugs.gnu.org; Mon, 01 May 2023 18:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RA+VxEMiQB1NtXFArB7OUG/m2h1B5D5gbWPu7m+ccFU=; b=LZho6E3Ew75NrQ/NFhW4ZCMD+/ evsfPsjOf/1ic8Xmz6Q/ymBx+WurMSm0C3Gkzu2xM5fwYWwv1A0hhXgX3G71ovpmEC8fjbGAz5r38 S7jKfujef9gMr3UbVZuoGGqoaQpQ8P6jDzuUMHiCTPieAZYkuR42Sc8zR8O6R+iU1DbvsjXFTggdX hYj4K2hDM8MBuWb6lK70+mU8Oyf2SOAMjMD61IIUWxXYwHKtFoV5KgYo9wlSPEn1E/XHmX7GllYGv Gg3OiDd3R4B+fX0rDaBhJ+I/q0b2+HbjbnkSSP1tI9vHrkLwvVNiXyBMkISJyevgqAi1ISEaUComB g5LTKvmQ==; Received: from [192.168.2.1] (port=48798 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptcNN-000JcC-2V; Mon, 01 May 2023 23:52:10 +0100 From: Arun Isaac Date: Mon, 1 May 2023 23:51:56 +0100 Message-Id: <20230501225158.18612-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I have fixed a bug in the v1 patchset with fetching participants' addresses. Please consider this v2 patchset instead. Arun Isaac (2): client: Support passing options to git send-email. client: Cc issue participants when sending email. mumi/client.scm | 44 ++++++++++++++++++++++++++++++++++++-------- tests/client.scm | 24 ++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 8 deletions(-) -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH v2 mumi 1/2] client: Support passing options to git send-email. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 22:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16829815375158 (code B ref 63215); Mon, 01 May 2023 22:53:02 +0000 Received: (at 63215) by debbugs.gnu.org; 1 May 2023 22:52:17 +0000 Received: from localhost ([127.0.0.1]:41221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcNU-0001L3-U9 for submit@debbugs.gnu.org; Mon, 01 May 2023 18:52:17 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:55306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcNT-0001Kk-Ir for 63215@debbugs.gnu.org; Mon, 01 May 2023 18:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GS5z0c4uMKIYg/s/5mo/B0Ggam8gi+s26/147IVrY6U=; b=pZCeP8B5R/BZNYEh4rd5BfgisW YCu8czduQrBA2Bf5u71ErDznSVVaTEuB3fzS67yRNE4jOMywfXZBBBW5+Vl+VsqnF24KBa4HexNBB EJHWrDqPruaazHhWtKrYZwWStXfdOZ2zsCsljlMsx642YKEXERq2kayot0XEwGD97TKZKzrmnXy/M bCpMDstscEGiY3diZ53FMY7VMs6tfKajkhf/CUo3RCQ+i1YNGEq5u9EpFGRCHj0JL81CgulnPNm8y MxmC0gap64P3wjMw3wrFLBegfoyolKGlLGor94AJtBE1Zm2QgxUNkc2A+X1MV9DbNZ6sxjyxiFz3u uBCH8v7Q==; Received: from [192.168.2.1] (port=48798 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptcNP-000JcC-2l; Mon, 01 May 2023 23:52:12 +0100 From: Arun Isaac Date: Mon, 1 May 2023 23:51:57 +0100 Message-Id: <20230501225158.18612-2-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501225158.18612-1-arunisaac@systemreboot.net> References: <20230501225158.18612-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * mumi/client.scm (git-send-email): Add options optional argument. --- mumi/client.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index b8d588b..2750836 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -207,12 +207,13 @@ arguments." (cut proc port) (cut close-pipe port)))))) -(define (git-send-email to patches) - "Send PATCHES using git send-email to the TO address and return the -message ID of the first email sent." +(define* (git-send-email to patches #:optional (options '())) + "Send PATCHES using git send-email to the TO address with +OPTIONS. Return the message ID of the first email sent." (let ((command (cons* "git" "send-email" (string-append "--to=" to) - patches))) + (append options + patches)))) (display (string-join command)) (newline) (call-with-input-pipe command -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH v2 mumi 2/2] client: Cc issue participants when sending email. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 22:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16829815395172 (code B ref 63215); Mon, 01 May 2023 22:53:02 +0000 Received: (at 63215) by debbugs.gnu.org; 1 May 2023 22:52:19 +0000 Received: from localhost ([127.0.0.1]:41224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcNX-0001LM-8F for submit@debbugs.gnu.org; Mon, 01 May 2023 18:52:19 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:55314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcNV-0001Kx-An for 63215@debbugs.gnu.org; Mon, 01 May 2023 18:52:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I6dK5xkFi83y8Rw3/ebJ1w2FXX451J+2ChasuE9tE/k=; b=O1s6ICjUFZ8fICYxSuGZEK6k/Z vP8ndnofufKcQeAxY1x4C3LvVQ9qRTS3ha2w2nF9g4Tk1bkKsxkJqBHcIxlwB/+sq1sTG5pGW/REV p+ETZKffzAZZgYrSH9G8t2LrASXwqwmeGSqU2EPf3mYHviGdnVIPewiBRq/avGg14PGCWlMURadU1 knQ13XNot5qvFhkzEXfm+FgVfibIbCC4PKEOxSk4CqVEScw9vye7/UXLIzw3a4FfkyXmF1ur4lPzu TXBJbTxxTby5j2fORZtJ2WqPcsMXmntvZ0cYu1yU0t3PC0Rmu1oEHiRvg/p7H/ixUoMP8wGALo2B/ vOICBCew==; Received: from [192.168.2.1] (port=48798 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptcNR-000JcC-34; Mon, 01 May 2023 23:52:14 +0100 From: Arun Isaac Date: Mon, 1 May 2023 23:51:58 +0100 Message-Id: <20230501225158.18612-3-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501225158.18612-1-arunisaac@systemreboot.net> References: <20230501225158.18612-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * mumi/client.scm: Import (srfi srfi-1). (reply-email-headers): New function. (send-email): Call reply-email-headers. * tests/client.scm ("send patches to existing issue", "send single patch to existing issue"): Stub reply-email-headers. ("send patch to existing issue and Cc other participants"): New test. --- mumi/client.scm | 35 +++++++++++++++++++++++++++++++---- tests/client.scm | 24 ++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 4 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index 2750836..f0e4321 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -18,6 +18,7 @@ (define-module (mumi client) #:use-module (rnrs io ports) + #:use-module (srfi srfi-1) #:use-module (srfi srfi-19) #:use-module (srfi srfi-26) #:use-module (srfi srfi-43) @@ -236,15 +237,41 @@ OPTIONS. Return the message ID of the first email sent." (display (get-string-all port)) message-id))))) +(define (reply-email-headers issue-number) + "Return an association list of email headers when replying to +ISSUE-NUMBER." + (let ((messages + (assoc-ref + (assoc-ref + (graphql-http-get (graphql-endpoint) + `(document + (query (#(issue #:number ,issue-number) + (messages (from name address) + date))))) + "issue") + "messages"))) + ;; When sending email to an issue, we Cc all issue participants. + ;; TODO: Also add an In-Reply-To header. + `((cc . ,(delete-duplicates + (map (lambda (message) + (let ((from (assoc-ref message "from"))) + (string-append (assoc-ref from "name") + " <" (assoc-ref from "address") ">"))) + (vector->list messages))))))) + (define (send-email patches) "Send PATCHES via email." (if (current-issue-number) ;; If an issue is current, send patches to that issue's email ;; address. - (git-send-email (string-append (number->string (current-issue-number)) - "@" - (client-config 'debbugs-host)) - patches) + (let ((issue-number (current-issue-number))) + (git-send-email (string-append (number->string issue-number) + "@" + (client-config 'debbugs-host)) + patches + (map (cut string-append "--cc=" <>) + (assq-ref (reply-email-headers issue-number) + 'cc)))) (match patches ;; If it's a single patch, send it to the patch email address ;; and be done with it diff --git a/tests/client.scm b/tests/client.scm index 94c8c5d..f0ff34e 100644 --- a/tests/client.scm +++ b/tests/client.scm @@ -90,6 +90,8 @@ called with." (lambda () (with-variables (list (cons (var@@ (mumi client) current-issue-number) (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const '((cc)))) client-config-stub do-not-poll-server-for-issue-number) (cut (@@ (mumi client) send-email) @@ -116,6 +118,28 @@ called with." (lambda () (with-variables (list (cons (var@@ (mumi client) current-issue-number) (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const '((cc)))) + client-config-stub + do-not-poll-server-for-issue-number) + (cut (@@ (mumi client) send-email) + (list "foo.patch"))))))) + +(test-equal "send patch to existing issue and Cc other participants" + '(("git" "send-email" + "--to=12345@example.com" + "--cc=John Doe " + "--cc=Mary Smith " + "foo.patch")) + (map (match-lambda + ((command _) command)) + (trace-calls (var@@ (mumi client) call-with-input-pipe) + (lambda () + (with-variables (list (cons (var@@ (mumi client) current-issue-number) + (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const `((cc "John Doe " + "Mary Smith ")))) client-config-stub do-not-poll-server-for-issue-number) (cut (@@ (mumi client) send-email) -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 May 2023 02:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168308157926685 (code B ref 63215); Wed, 03 May 2023 02:40:02 +0000 Received: (at 63215) by debbugs.gnu.org; 3 May 2023 02:39:39 +0000 Received: from localhost ([127.0.0.1]:45353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu2P5-0006wL-66 for submit@debbugs.gnu.org; Tue, 02 May 2023 22:39:39 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:55587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu2P1-0006w6-4B for 63215@debbugs.gnu.org; Tue, 02 May 2023 22:39:37 -0400 Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-3f0b30f240eso40481531cf.3 for <63215@debbugs.gnu.org>; Tue, 02 May 2023 19:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683081569; x=1685673569; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bFIXvvkM4ZJe4CYuMlpwfvl/wE2rU8FBH+U0JfdZ+Ko=; b=I1RgsOQerkHQErsV+UDfASpEajaJp5dY9nsdbtxFJMjRkLOBPUNvjMzXwHw/YhLaxS 9YzfyJWi0cOxcmIdP1twfd77YWwKg2AFPKRT6Iz93RGA+wzkXbN38XlYgajScf/QcCVY 0pNAFMPI+c7BpzXIBYsNs8IOCQug2/w1zkv2Gywv6Dj2rIjACZlPqlaXBurcCJZZfoXS 3e71zaOkG/123TXZkG/Zlpft+5eIY1XH9HiOc2N833tS2TzcEqoVL4IbgNu+meJYZl2n OSBp/btacERRJrkv5rTVZi/hNrK5mrDS8GD0/Pp6WgxxWxw+cxiMewzibEDeEdsgfTU5 q2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683081569; x=1685673569; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bFIXvvkM4ZJe4CYuMlpwfvl/wE2rU8FBH+U0JfdZ+Ko=; b=GmRI36P3Os2h/VUv4N6Mqs3OHWCfTgf9c0vErvAoMIjtZVvSERn10Sb3ClAl8LVrtR j3oAFqq17akVZ8xOTRwNatczVsTxPvBDjqXq586YXePmifFnJmNbJSCqVWIiG52BOyWa X9TiLIpff7dj2WbHP0P9dfCk/K4p8EdvueLxBpnNOK0PnC/RzoP0monIW6Ccp4njw6Wf R/7L9/4tw+yFidYa4z7WPyqtsPUNxRfood3AD4vWfAaRwjAR/YRwkAKv8exS2eI/HxX4 Yl1OEO6mXUeiZXAT5DobZrj3M0m7O20m0upeEK0w4y7kFiFhAi6ZSb649gWKYSpJj9Ox flDg== X-Gm-Message-State: AC+VfDyM8rlSkdA5WcSTq+I7rqVsZpnH8XRv/zSDyVPs+yq1WsWlEjH1 wcItqRqO+s0fmJ4/lAz40YRuEN5tsH1OLQ== X-Google-Smtp-Source: ACHHUZ55+4YJimuMUcqr5AClesEOHQ8FBTcJbrldHNuRzoPsw+mV25QKVcpr9abf2Hnetbnty+ok/w== X-Received: by 2002:a05:622a:489:b0:3f0:a108:863b with SMTP id p9-20020a05622a048900b003f0a108863bmr31474568qtx.43.1683081569153; Tue, 02 May 2023 19:39:29 -0700 (PDT) Received: from hurd (dsl-157-118.b2b2c.ca. [66.158.157.118]) by smtp.gmail.com with ESMTPSA id cb7-20020a05622a1f8700b003ee4b5a2dd3sm6511537qtb.21.2023.05.02.19.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 19:39:28 -0700 (PDT) From: Maxim Cournoyer References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> Date: Tue, 02 May 2023 22:39:27 -0400 In-Reply-To: <20230501225158.18612-3-arunisaac@systemreboot.net> (Arun Isaac's message of "Mon, 1 May 2023 23:51:58 +0100") Message-ID: <87y1m6yw80.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Arun, Arun Isaac writes: > * mumi/client.scm: Import (srfi srfi-1). > (reply-email-headers): New function. > (send-email): Call reply-email-headers. > * tests/client.scm ("send patches to existing issue", "send single > patch to existing issue"): Stub reply-email-headers. > ("send patch to existing issue and Cc other participants"): New test. Great series! > --- > mumi/client.scm | 35 +++++++++++++++++++++++++++++++---- > tests/client.scm | 24 ++++++++++++++++++++++++ > 2 files changed, 55 insertions(+), 4 deletions(-) > > diff --git a/mumi/client.scm b/mumi/client.scm > index 2750836..f0e4321 100644 > --- a/mumi/client.scm > +++ b/mumi/client.scm > @@ -18,6 +18,7 @@ > > (define-module (mumi client) > #:use-module (rnrs io ports) > + #:use-module (srfi srfi-1) > #:use-module (srfi srfi-19) > #:use-module (srfi srfi-26) > #:use-module (srfi srfi-43) > @@ -236,15 +237,41 @@ OPTIONS. Return the message ID of the first email sent." > (display (get-string-all port)) > message-id))))) > > +(define (reply-email-headers issue-number) > + "Return an association list of email headers when replying to > +ISSUE-NUMBER." > + (let ((messages > + (assoc-ref > + (assoc-ref > + (graphql-http-get (graphql-endpoint) > + `(document > + (query (#(issue #:number ,issue-number) > + (messages (from name address) > + date))))) > + "issue") > + "messages"))) > + ;; When sending email to an issue, we Cc all issue participants. > + ;; TODO: Also add an In-Reply-To header. > + `((cc . ,(delete-duplicates > + (map (lambda (message) > + (let ((from (assoc-ref message "from"))) > + (string-append (assoc-ref from "name") > + " <" (assoc-ref from "address") ">"))) > + (vector->list messages))))))) > + > (define (send-email patches) > "Send PATCHES via email." > (if (current-issue-number) > ;; If an issue is current, send patches to that issue's email > ;; address. > - (git-send-email (string-append (number->string (current-issue-number)) > - "@" > - (client-config 'debbugs-host)) > - patches) > + (let ((issue-number (current-issue-number))) > + (git-send-email (string-append (number->string issue-number) > + "@" > + (client-config 'debbugs-host)) > + patches > + (map (cut string-append "--cc=" <>) > + (assq-ref (reply-email-headers issue-number) > + 'cc)))) I was thinking looking at this, with X-Debbugs-Cc headers now being added automatically by Git for members of a team, there could be duplication between X-Debbugs-Cc and the participannts retrieved from the messages above. To ensure participants do not receive duplicate replies, it'd be probably best to stick to using X-Debbugs-Cc with all interactions with Debbugs; this way a duplicate header is (hopefully) ignored by Debbugs itself. Does that make sense? -- Thanks, Maxim From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168325204018487 (code B ref 63215); Fri, 05 May 2023 02:01:02 +0000 Received: (at 63215) by debbugs.gnu.org; 5 May 2023 02:00:40 +0000 Received: from localhost ([127.0.0.1]:52553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pukkR-0004o5-TN for submit@debbugs.gnu.org; Thu, 04 May 2023 22:00:40 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:48714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pukkO-0004np-42 for 63215@debbugs.gnu.org; Thu, 04 May 2023 22:00:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HZOc0MnSuh3qrv40YJjvpM/eV1oyolmajSQiVbYwc0A=; b=MBZCZQ1VdYwCAn8nBCFQ31Ho1R FDU+8aNP79J6Sa3ZMO0hM65B2MVxg/ioVBba/T/cHFHYWErr0RDJrCLxpB55vdHkt9e3Z8Qf8i4MF OmwAaxbjFt6jIhi7h6JV965BUz0TpcW064rJ2U1dyEpw2m4KplnaBqH/gv5HjzV7XJv+L2CGp2pfl S9aIN1HlZAOjp5B39e6XVar9w5v7JAoIDSGYEW59sCNsFA0VPMp3a7EYpK0/1NseLp9U3/0pja8Np On3atKmelMEa9ufMcRPR3P+Vnbi9LWem0bLsGdqlO+HoHSaIPybBZIt/71upexbf9dW1x2yqJ38L/ Xyg/Q4Hg==; Received: from [192.168.2.1] (port=51672 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pukkI-0000ca-1R; Fri, 05 May 2023 03:00:31 +0100 From: Arun Isaac In-Reply-To: <87y1m6yw80.fsf_-_@gmail.com> References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> Date: Fri, 05 May 2023 03:00:26 +0100 Message-ID: <87jzxnbkqt.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, > I was thinking looking at this, with X-Debbugs-Cc headers now being > added automatically by Git for members of a team, there could be > duplication between X-Debbugs-Cc and the participannts retrieved from > the messages above. > > To ensure participants do not receive duplicate replies, it'd be > probably best to stick to using X-Debbugs-Cc with all interactions with > Debbugs; this way a duplicate header is (hopefully) ignored by Debbugs > itself. > > Does that make sense? Yes, that makes sense! I will send a new patchset. According to https://www.debian.org/Bugs/Reporting#xcc , if we want to send copies to multiple addresses, we should put them in as a comma-separated list in the same X-Debbugs-Cc header. teams.scm seems to be putting in multiple X-Debbugs-Cc headers. Maybe we should change that? I see mumi as being more widely usable than just for Guix. For example, I wish to use it for skribilo, another Guile project that uses the Debbugs issue tracker. So, in the future, if and when applicable, we might want to move some of teams.scm's functionality into `mumi send-email'. Regards, Arun From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 13:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168329309220410 (code B ref 63215); Fri, 05 May 2023 13:25:01 +0000 Received: (at 63215) by debbugs.gnu.org; 5 May 2023 13:24:52 +0000 Received: from localhost ([127.0.0.1]:53404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puvQZ-0005J8-Ns for submit@debbugs.gnu.org; Fri, 05 May 2023 09:24:51 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:42448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puvQW-0005Is-KK for 63215@debbugs.gnu.org; Fri, 05 May 2023 09:24:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ueDKPrsCtp+ywRt6uAXcMDmshCDKURUlWkULQZHZV/Y=; b=V5JvYAxz3RSo223F0bMEFxOGZU bxc+oZnFNdC5tojYIbB/BJdLoBBelp1tHCvxBV5LK0wVPsCEaPp48cA5u5I0+RtiiFUchVBBAQonX GbPwE7Qlzhl3NysdHBZ7y6yYsWbafHCRw6nJwa991aY7iiVtt7UO4GjxtL0u5Kh3ApaFzEi8Q9+or 98KyBbDHGW875Jw1dQXEzoLZ84QZKfd07bKJ/ylTkjmT8aSUi2llh+HhsNdE2psUjjuUt0RGVkoTQ bzHoE66Sx+OKTPzIbSBzavZOBV/arqciip2TX65xWlMrM52rss0Fm/pYAVttw34cZ3QOtt+h41Ry5 ejBRAOgg==; Received: from [192.168.2.1] (port=36896 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1puvQQ-0001kQ-2I; Fri, 05 May 2023 14:24:43 +0100 From: Arun Isaac In-Reply-To: <87jzxnbkqt.fsf@systemreboot.net> References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> Date: Fri, 05 May 2023 14:24:39 +0100 Message-ID: <87a5yic3mw.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Yes, that makes sense! I will send a new patchset. According to > https://www.debian.org/Bugs/Reporting#xcc , if we want to send copies to > multiple addresses, we should put them in as a comma-separated list in > the same X-Debbugs-Cc header. teams.scm seems to be putting in multiple > X-Debbugs-Cc headers. Maybe we should change that? I just realized that using comma-separated lists calls for the functionality of teams.scm to be moved into `mumi send-email'. If teams.scm and `mumi send-email' remain separate, they will each produce a separate comma-separated list of X-Debbugs-Cc addresses, and we will be back to square one with multiple X-Debbugs-Cc headers. WDYT? What is the best way forward? From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.168330349920421 (code B ref 63215); Fri, 05 May 2023 16:19:01 +0000 Received: (at 63215) by debbugs.gnu.org; 5 May 2023 16:18:19 +0000 Received: from localhost ([127.0.0.1]:57313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puy8R-0005JJ-A3 for submit@debbugs.gnu.org; Fri, 05 May 2023 12:18:19 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:45236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puy8M-0005J3-Tw for 63215@debbugs.gnu.org; Fri, 05 May 2023 12:18:17 -0400 Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-74d2597fdb2so94905485a.2 for <63215@debbugs.gnu.org>; Fri, 05 May 2023 09:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683303489; x=1685895489; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=o/JqXkJZswTFCJj9auh1RKRV0IUVAwQ+6lpvNaFo3QY=; b=GFYvHhFaAwey08k+fE1q2eqG6hUxLgQaiMe7pe74Rxqlyhs7tNlY0ys+XyG9qXhIov HVaytC4VIPZpAxogFpvSOs16lhRZheikLrzwRj5xH9NLmA1FwrnC/KmNS+D6uXztIvdO AO8bbKVb5snLa3JM8BtjTbcnZ0MrHDeOWkO0zKFb+jd7Z8H5/beEE9j/go6JEXn55D0q oSQ1CrvXHuOe0Ox/0YS3vjSQ3raYmaGrGb/Z/JiNBKbvfboMamie3OCVkF/ZnKe7lxpp 6vPMdRYOttXisR6CProh3CgqQOpYRHFMjA7rNspkNUDrSJkzvRfmZvaTy4lfztx4CK6G Y7TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683303489; x=1685895489; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o/JqXkJZswTFCJj9auh1RKRV0IUVAwQ+6lpvNaFo3QY=; b=lRxonsOWoQuKhoq9HL1lD6P8scPwfUnWxobWjSiIb1uyh3vly+EFcFZmuDJZ0Kqk+l YVtJFIiy/EZcSpv1rYgK/j+D8NoT/2wAAmcKuSXnY5zSyyyb56r+amTLrEMbPYja2Mx6 9YzNySN52ROM2jrAfTaBMQoTR9JCWJK/R/YAJKOB6+8sxxP1pHa//BjzptcmX9qrlbdU vU4mmJ4jLnWrvALg+17lnXUIGaJBjbIgRK8VSggrssChLVpOYeVomfNbk/jLJhBcJrvJ HDPPBSbFNkoRqJz6P5ybbuZ6ERKAjTOfCIGLxyQm+zNjPxFmoPjHkDeHwuxOOurwykSt VDPQ== X-Gm-Message-State: AC+VfDyMsdF7E64aRRi4aAQ1TZTCAoQPdpkgOpaf/gbqIvdIUDmefiqf 90SyOL0KXhGQ2gkDhP+x+yrVy6We3Jk= X-Google-Smtp-Source: ACHHUZ50hClgMC4lXJ1wlYo46EZi5NUUGHFGNr/Yiz/0ge3gSO2uRj58N2Yeic/zAEBDg6OCCGZP4A== X-Received: by 2002:a05:622a:452:b0:3ef:3402:dda4 with SMTP id o18-20020a05622a045200b003ef3402dda4mr2910620qtx.32.1683303488909; Fri, 05 May 2023 09:18:08 -0700 (PDT) Received: from hurd (dsl-205-236-230-162.b2b2c.ca. [205.236.230.162]) by smtp.gmail.com with ESMTPSA id ch7-20020a05622a40c700b003e3860f12f7sm717416qtb.56.2023.05.05.09.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 09:18:08 -0700 (PDT) From: Maxim Cournoyer References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> Date: Fri, 05 May 2023 12:18:07 -0400 In-Reply-To: <87a5yic3mw.fsf@systemreboot.net> (Arun Isaac's message of "Fri, 05 May 2023 14:24:39 +0100") Message-ID: <871qju4urk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Arun, Arun Isaac writes: >> Yes, that makes sense! I will send a new patchset. According to >> https://www.debian.org/Bugs/Reporting#xcc , if we want to send copies to >> multiple addresses, we should put them in as a comma-separated list in >> the same X-Debbugs-Cc header. teams.scm seems to be putting in multiple >> X-Debbugs-Cc headers. Maybe we should change that? > > I just realized that using comma-separated lists calls for the > functionality of teams.scm to be moved into `mumi send-email'. If > teams.scm and `mumi send-email' remain separate, they will each produce > a separate comma-separated list of X-Debbugs-Cc addresses, and we will > be back to square one with multiple X-Debbugs-Cc headers. > > WDYT? What is the best way forward? If you meant that it's mumi instead of git that should call etc/teams.scm, it makes sense. I'm not sure the functionality of teams.scm proper should be moved wholesale into mumi, as it's useful outside of mumi (for plain git users, say). Mumi could invoke etc/teams.scm to produce the list of team members for the changes involved, add any missing collaborators retrieved from the message data to the set (avoiding duplicates), then format the 'X-Debbugs-CC' header with comma-separated values. It should then invoke git with the '--no-header-cmd' option to avoid teams.scm being called again. Note that our teams.scm script currently generate distinct X-Debbugs-CC header for each participant. The Debbugs copy used by GNU is the one hosted at [0], which doesn't mention the comma-separated requirement/suggestion, so I think that's currently OK, although I'm not too confident in my reading of the 'process' Perl script [1]. At any rate it'd be easy to adjust in teams.scm. The email specification mentions that some special fields such as To and Cc should be separated by commas, but says nothing about custom fields [2], so in my opinion both forms should be supported by Debbugs (and probably are, although it's hard to say without trying). [0] https://gitlab.com/npostavs/debbugs/-/tree/gnu-reconstruction?ref_type=heads [1] https://gitlab.com/npostavs/debbugs/-/blob/gnu-reconstruction/scripts/process [2] https://datatracker.ietf.org/doc/html/rfc5322#section-3.6 -- Thanks, Maxim From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16834122387484 (code B ref 63215); Sat, 06 May 2023 22:31:01 +0000 Received: (at 63215) by debbugs.gnu.org; 6 May 2023 22:30:38 +0000 Received: from localhost ([127.0.0.1]:35924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQQF-0001wb-EW for submit@debbugs.gnu.org; Sat, 06 May 2023 18:30:38 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:51068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQQ8-0001wH-Ol for 63215@debbugs.gnu.org; Sat, 06 May 2023 18:30:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h54Sj8OYZ1oMyUTxu95DtkzIi6EbtmqPZA97eZHH55E=; b=SMJTPA3U9GTOAicrs8sMLYdTUG T+SIiyu+bDZfhUhcLvmBqtfBmkTLeeRjmN26ltj9DWN8sPRvqdM0kyahEuD0lpvgO0ZEZHGvhHzPh 538D3AVBXQsVCBtBnN9vrp24Q9mwauwiQyjXRNE4k8CrQctth2lRJPKGoyERVfzdPgrrwAui8+E6k X8yWDsLBLExCkYID7I0KmH3vZO3AP7LO3KlU2du5/yHRxzUP2hpS5QtM/bmNtekJ/R3j3Bj3o2sDK ewW7gsIsmxOFJIVFgcha9ASpV4ycA/LBEGzotjRroE0vWQA6j9h8SYZl9FylALDfIcYMrgEWK2hL2 Fc3zoQ7w==; Received: from [192.168.2.1] (port=45284 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pvQQ2-0005Or-2B; Sat, 06 May 2023 23:30:23 +0100 From: Arun Isaac In-Reply-To: <871qju4urk.fsf@gmail.com> References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> <871qju4urk.fsf@gmail.com> Date: Sat, 06 May 2023 23:30:18 +0100 Message-ID: <87zg6h9jph.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, > If you meant that it's mumi instead of git that should call > etc/teams.scm, it makes sense. I'm not sure the functionality of > teams.scm proper should be moved wholesale into mumi, as it's useful > outside of mumi (for plain git users, say). I see your point about keeping things working for plain git users. Makes sense. > Mumi could invoke etc/teams.scm to produce the list of team members for > the changes involved, add any missing collaborators retrieved from the > message data to the set (avoiding duplicates), then format the > 'X-Debbugs-CC' header with comma-separated values. It should then > invoke git with the '--no-header-cmd' option to avoid teams.scm being > called again. mumi invoking etc/teams.scm is not so nice since that means coupling mumi to the specific repository layout of guix. This reduces its generality to other projects, say skribilo. Maybe, let's just keep multiple X-Debbugs-Cc headers for now. Let mumi and teams.scm be unaware of each other for now. We can revisit the question of coupling them later. > Note that our teams.scm script currently generate distinct X-Debbugs-CC > header for each participant. The Debbugs copy used by GNU is the one > hosted at [0], which doesn't mention the comma-separated > requirement/suggestion, so I think that's currently OK, although I'm not > too confident in my reading of the 'process' Perl script [1]. At any > rate it'd be easy to adjust in teams.scm. > > The email specification mentions that some special fields such as To and > Cc should be separated by commas, but says nothing about custom fields [2], > so in my opinion both forms should be supported by Debbugs (and probably > are, although it's hard to say without trying). Fair enough. Let's keep multiple X-Debbugs-Cc headers and hope for the best! :-) A new patchset follows. The only difference between this patchset and the previous one is that we set X-Debbugs-Cc headers instead of Cc headers. Regards, Arun From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH 1/2] client: Support passing options to git send-email. References: <20230501205639.16201-1-arunisaac@systemreboot.net> In-Reply-To: <20230501205639.16201-1-arunisaac@systemreboot.net> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 22:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16834125488012 (code B ref 63215); Sat, 06 May 2023 22:36:02 +0000 Received: (at 63215) by debbugs.gnu.org; 6 May 2023 22:35:48 +0000 Received: from localhost ([127.0.0.1]:35929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQVI-00025A-8L for submit@debbugs.gnu.org; Sat, 06 May 2023 18:35:48 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:45672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQVF-00024s-D5 for 63215@debbugs.gnu.org; Sat, 06 May 2023 18:35:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GS5z0c4uMKIYg/s/5mo/B0Ggam8gi+s26/147IVrY6U=; b=pw50yNxHkhZ+nJsVqu0NPSwQod s5nHpIKuhEvWrD6jQ+udWPGjsD1kdD4soqT7x6IkMaVWC1ZWIA8tXTkbDIZsQoDN/+Ilr45kS7Yts HKGKC1xYYc1ThPioD/oAk3VQ960YRRIEoOCpmEdPV+T4EWJVJJdobdelhNwppimyQY3Vq3Wlro9Cz fOoivemN6m8g0aigAGg5kgXX16+mzXGkPdapgVAQysFK6FBnCUXLNnvQbsv06MQNUIO/mbMjYnF4t AalKVxLUGlx4jmjsJ28fdcXSQnQbcdb+GQT9S7QXP9GaYbhlg48WfOATYu2tlCGmlZg/mIGp9A5xE VTqd7y6A==; Received: from [192.168.2.1] (port=41376 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pvQVB-0005PK-0p; Sat, 06 May 2023 23:35:41 +0100 From: Arun Isaac Date: Sat, 6 May 2023 23:35:19 +0100 Message-Id: <20230506223520.27933-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * mumi/client.scm (git-send-email): Add options optional argument. --- mumi/client.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index b8d588b..2750836 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -207,12 +207,13 @@ arguments." (cut proc port) (cut close-pipe port)))))) -(define (git-send-email to patches) - "Send PATCHES using git send-email to the TO address and return the -message ID of the first email sent." +(define* (git-send-email to patches #:optional (options '())) + "Send PATCHES using git send-email to the TO address with +OPTIONS. Return the message ID of the first email sent." (let ((command (cons* "git" "send-email" (string-append "--to=" to) - patches))) + (append options + patches)))) (display (string-join command)) (newline) (call-with-input-pipe command -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH 2/2] client: Cc issue participants when sending email. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 22:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63215@debbugs.gnu.org Cc: Arun Isaac Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16834125528026 (code B ref 63215); Sat, 06 May 2023 22:36:02 +0000 Received: (at 63215) by debbugs.gnu.org; 6 May 2023 22:35:52 +0000 Received: from localhost ([127.0.0.1]:35931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQVL-00025O-GO for submit@debbugs.gnu.org; Sat, 06 May 2023 18:35:51 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:45686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQVG-00024x-Lo for 63215@debbugs.gnu.org; Sat, 06 May 2023 18:35:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PGDQSYWuAXhby8sUkF9BAE9oxsUFfn28EdmcKc1AP9Q=; b=odEviq/8l8VWadduh1IOmE0Ftx E0qcAIXg6tf0bw90pF1iwQnc3eZQNgJLwllIm8FVKFsHz7u7UL1B9u0gegL62pIFPIJ8zpqhF/J1G 8vTJy8KVln2ZZa8nsXQVX/uyDUzd4GHNGCGEzm+bukTlpk6yRSxYX9TZpm9mzD2diZbZwkRIQ9jR4 seP71e7bmqgnI8tE6burLN03yWkOl/ySJyqyrQ2rEMkXjihq1V0fzY1FgxU475NOzHeJB5I9694jU OAHMu8SFnaha13pwU+oahK3lvaJrRV8ZuEzFV3BbaLkRd7n45p7azXvCY6T5KUz98IdBpzcnp9YG6 ukeKrwPw==; Received: from [192.168.2.1] (port=41376 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pvQVD-0005PK-0x; Sat, 06 May 2023 23:35:43 +0100 From: Arun Isaac Date: Sat, 6 May 2023 23:35:20 +0100 Message-Id: <20230506223520.27933-2-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230506223520.27933-1-arunisaac@systemreboot.net> References: <20230506223520.27933-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * mumi/client.scm: Import (srfi srfi-1). (reply-email-headers): New function. (send-email): Call reply-email-headers. * tests/client.scm ("send patches to existing issue", "send single patch to existing issue"): Stub reply-email-headers. ("send patch to existing issue and Cc other participants"): New test. --- mumi/client.scm | 36 ++++++++++++++++++++++++++++++++---- tests/client.scm | 25 +++++++++++++++++++++++++ 2 files changed, 57 insertions(+), 4 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index 2750836..7ba47e6 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -18,6 +18,7 @@ (define-module (mumi client) #:use-module (rnrs io ports) + #:use-module (srfi srfi-1) #:use-module (srfi srfi-19) #:use-module (srfi srfi-26) #:use-module (srfi srfi-43) @@ -236,15 +237,42 @@ OPTIONS. Return the message ID of the first email sent." (display (get-string-all port)) message-id))))) +(define (reply-email-headers issue-number) + "Return an association list of email headers when replying to +ISSUE-NUMBER." + (let ((messages + (assoc-ref + (assoc-ref + (graphql-http-get (graphql-endpoint) + `(document + (query (#(issue #:number ,issue-number) + (messages (from name address) + date))))) + "issue") + "messages"))) + ;; When sending email to an issue, we Cc all issue participants. + ;; TODO: Also add an In-Reply-To header. + `((x-debbugs-cc + . ,(delete-duplicates + (map (lambda (message) + (let ((from (assoc-ref message "from"))) + (string-append (assoc-ref from "name") + " <" (assoc-ref from "address") ">"))) + (vector->list messages))))))) + (define (send-email patches) "Send PATCHES via email." (if (current-issue-number) ;; If an issue is current, send patches to that issue's email ;; address. - (git-send-email (string-append (number->string (current-issue-number)) - "@" - (client-config 'debbugs-host)) - patches) + (let ((issue-number (current-issue-number))) + (git-send-email (string-append (number->string issue-number) + "@" + (client-config 'debbugs-host)) + patches + (map (cut string-append "--add-header=X-Debbugs-Cc: " <>) + (assq-ref (reply-email-headers issue-number) + 'x-debbugs-cc)))) (match patches ;; If it's a single patch, send it to the patch email address ;; and be done with it diff --git a/tests/client.scm b/tests/client.scm index 94c8c5d..1d40c10 100644 --- a/tests/client.scm +++ b/tests/client.scm @@ -90,6 +90,8 @@ called with." (lambda () (with-variables (list (cons (var@@ (mumi client) current-issue-number) (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const '((x-debbugs-cc)))) client-config-stub do-not-poll-server-for-issue-number) (cut (@@ (mumi client) send-email) @@ -116,6 +118,29 @@ called with." (lambda () (with-variables (list (cons (var@@ (mumi client) current-issue-number) (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const '((x-debbugs-cc)))) + client-config-stub + do-not-poll-server-for-issue-number) + (cut (@@ (mumi client) send-email) + (list "foo.patch"))))))) + +(test-equal "send patch to existing issue and Cc other participants" + '(("git" "send-email" + "--to=12345@example.com" + "--add-header=X-Debbugs-Cc: John Doe " + "--add-header=X-Debbugs-Cc: Mary Smith " + "foo.patch")) + (map (match-lambda + ((command _) command)) + (trace-calls (var@@ (mumi client) call-with-input-pipe) + (lambda () + (with-variables (list (cons (var@@ (mumi client) current-issue-number) + (const 12345)) + (cons (var@@ (mumi client) reply-email-headers) + (const `((x-debbugs-cc + "John Doe " + "Mary Smith ")))) client-config-stub do-not-poll-server-for-issue-number) (cut (@@ (mumi client) send-email) -- 2.39.2 From unknown Sat Jun 21 10:44:13 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 May 2023 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16834264691660 (code B ref 63215); Sun, 07 May 2023 02:28:02 +0000 Received: (at 63215) by debbugs.gnu.org; 7 May 2023 02:27:49 +0000 Received: from localhost ([127.0.0.1]:36078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvU7o-0000Qi-LC for submit@debbugs.gnu.org; Sat, 06 May 2023 22:27:48 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:54352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvU7j-0000QR-Dt for 63215@debbugs.gnu.org; Sat, 06 May 2023 22:27:47 -0400 Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7575d85d562so81012385a.0 for <63215@debbugs.gnu.org>; Sat, 06 May 2023 19:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683426457; x=1686018457; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=T9KvhEGioD8TRASPd00qIjqDYavobD86+OPqsAjT5Cs=; b=IqU/Zlv+1rQP8wIPkFvK5EYzAezUBUBfPpHJFTZuJKo+yI5ZJKGD7d2yc2ukJX7N/E NMhqrS3sZy7J0ww14rK0T4oVzur7cuJ5vvK0IhEiR/lKJu/K1iASAhaV71NEpwqYJi8n z5WtcM3V1I2WWusJLxq03KxUNX4S4+do+VR2zz94aMfjuV77MFhfn0/m8KaOKn4DZNt7 gzDash2Q3IARzpqwKs4TU8lmyrrAQ22SRVv+ExOFdgvhkaNnbdyKQxgeiJDPuRMqh5KF vNA5zr+3+02GDGBVYC/8o5nQ95U0viOuTb+pxRvMBAgq0UcVXnBUZHjy5h29F6hJHOGK 86xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683426457; x=1686018457; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T9KvhEGioD8TRASPd00qIjqDYavobD86+OPqsAjT5Cs=; b=LyvMK9bUMMn0iUZoL2em7fvhBFVxeyg3r/jphQVPXTpW2j/dx5j68zWhJhACux8miw xuTlMjrvj1bjjQ8PEwCHUe4rUfTWU1tpjk6Jnk/lGukjoVaf3HCGDJETbBcCQMt9PJ6b 3KQDkKQJD9+kUXkT9Ni6c44/KeyirW6VfwYr9VNxgebB86j5rFsOdZ5XQsYEaWVwyA8y IcjXkTL9MA2WHa/ujRM0u3nIo46jOgpNocxO1Z7G4ZMBURVq69UtgciUMASblsVfHmAK OPR/MAThjuvdNUAHYvqhkXIKNfEfp9xUuxtxKwlb173z0IvDX/p3LgvGj08njCr/foHd oXWA== X-Gm-Message-State: AC+VfDxyEAtqQyZnMsVBiDSs9/kqX/HaOtwZHQI59k/PTsuB7OHTPoOh 7O68YptfeYHy97bA65bpnMoxo5V9ND0= X-Google-Smtp-Source: ACHHUZ45Niyt+HVKXyi3SyYf+3Cnl32/B7apIubHnyX9zNn2ecoqevUb4Ri5mQBseepop2rFgY3ARw== X-Received: by 2002:a05:6214:2409:b0:61b:5b4b:2a4 with SMTP id fv9-20020a056214240900b0061b5b4b02a4mr10910386qvb.29.1683426457443; Sat, 06 May 2023 19:27:37 -0700 (PDT) Received: from hurd (dsl-205-236-230-162.b2b2c.ca. [205.236.230.162]) by smtp.gmail.com with ESMTPSA id t17-20020a0ce2d1000000b0061b5d3a61aesm1778389qvl.9.2023.05.06.19.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 19:27:36 -0700 (PDT) From: Maxim Cournoyer References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> <871qju4urk.fsf@gmail.com> <87zg6h9jph.fsf@systemreboot.net> Date: Sat, 06 May 2023 22:27:35 -0400 In-Reply-To: <87zg6h9jph.fsf@systemreboot.net> (Arun Isaac's message of "Sat, 06 May 2023 23:30:18 +0100") Message-ID: <87o7mw3mg8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Arun, Arun Isaac writes: > Hi Maxim, > >> If you meant that it's mumi instead of git that should call >> etc/teams.scm, it makes sense. I'm not sure the functionality of >> teams.scm proper should be moved wholesale into mumi, as it's useful >> outside of mumi (for plain git users, say). > > I see your point about keeping things working for plain git users. Makes > sense. > >> Mumi could invoke etc/teams.scm to produce the list of team members for >> the changes involved, add any missing collaborators retrieved from the >> message data to the set (avoiding duplicates), then format the >> 'X-Debbugs-CC' header with comma-separated values. It should then >> invoke git with the '--no-header-cmd' option to avoid teams.scm being >> called again. > > mumi invoking etc/teams.scm is not so nice since that means coupling > mumi to the specific repository layout of guix. This reduces its > generality to other projects, say skribilo. Perhaps it could use the value of `git config sendemail.headerCmd` to figure out which script already produces X-Debbugs-CC headers, if any. > Maybe, let's just keep multiple X-Debbugs-Cc headers for now. Let mumi > and teams.scm be unaware of each other for now. We can revisit the > question of coupling them later. OK, sounds good to me. -- Thanks, Maxim From unknown Sat Jun 21 10:44:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Arun Isaac Subject: bug#63215: closed (Re: bug#63215: [PATCH mumi 0/2] Cc all issue participants when sending email) Message-ID: References: <87mt2g9yaf.fsf@systemreboot.net> <20230501205639.16201-1-arunisaac@systemreboot.net> X-Gnu-PR-Message: they-closed 63215 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63215@debbugs.gnu.org Date: Sun, 07 May 2023 11:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1683458942-29883-1" This is a multi-part message in MIME format... ------------=_1683458942-29883-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63215: [PATCH mumi 0/2] Cc all issue participants when sending email which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63215@debbugs.gnu.org. --=20 63215: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63215 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1683458942-29883-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63215-done) by debbugs.gnu.org; 7 May 2023 11:28:05 +0000 Received: from localhost ([127.0.0.1]:36587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvcYf-0007kM-Ev for submit@debbugs.gnu.org; Sun, 07 May 2023 07:28:05 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvcYb-0007jt-Ga for 63215-done@debbugs.gnu.org; Sun, 07 May 2023 07:28:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eiyZpoC88daz50/bl2zjv2UJdKd9SYR7A3+vzemZ18Y=; b=l6F7h+weZDkhekXSpc/KRtCzdV oz6knvriA4YnNzUZaZZG8SfRkfWPwOFv07kCWbR3svESatOu8or6yJBbdSF9d672P0/6f/qGn2X39 PS10hs8M/lr2Y/EtBF/1X9+YS0ldU/NAv5dOUWYiprJ+kBOc3prQ09NtMA4SlINJVyWiEzBTDWU/D S4ITYBK/p2LHsMVA5Pofk8lpsF3UDYN08A4D1vYJiThItjuG97tJBKllqLrnO9XXyBuDrUo540CVh Unr2PKgGrT1Ul14vEw9PMmRHFfa5gxVnvazvlBc4BJVXIvE+AnwTaqOx6oE+KU9tvR0EC1WYRZc6n x8Gazy0A==; Received: from [192.168.2.1] (port=44364 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pvcYV-000BRQ-1n; Sun, 07 May 2023 12:27:56 +0100 From: Arun Isaac To: Maxim Cournoyer Subject: Re: bug#63215: [PATCH mumi 0/2] Cc all issue participants when sending email In-Reply-To: <87o7mw3mg8.fsf@gmail.com> References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> <871qju4urk.fsf@gmail.com> <87zg6h9jph.fsf@systemreboot.net> <87o7mw3mg8.fsf@gmail.com> Date: Sun, 07 May 2023 12:27:36 +0100 Message-ID: <87mt2g9yaf.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63215-done Cc: 63215-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Perhaps it could use the value of `git config sendemail.headerCmd` to > figure out which script already produces X-Debbugs-CC headers, if any. That's a good idea! We can revisit this later. >> Maybe, let's just keep multiple X-Debbugs-Cc headers for now. Let mumi >> and teams.scm be unaware of each other for now. We can revisit the >> question of coupling them later. > > OK, sounds good to me. Pushed, thanks! ------------=_1683458942-29883-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 May 2023 20:57:18 +0000 Received: from localhost ([127.0.0.1]:41156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaaE-0006PR-1Z for submit@debbugs.gnu.org; Mon, 01 May 2023 16:57:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:34356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaaA-0006PI-Nz for submit@debbugs.gnu.org; Mon, 01 May 2023 16:57:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaaA-00053w-F0 for guix-patches@gnu.org; Mon, 01 May 2023 16:57:14 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaa7-0001g3-6S for guix-patches@gnu.org; Mon, 01 May 2023 16:57:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LCkuP71cD6ai6gJve04a6jBqppPFjkxFf/r+8pzfM34=; b=KyUwBl8FGwr8UZnFhY6upn1Zb5 D9xY0GJH91S1zC0Lnph2W/yjOXro/q4MT6BRw0k0QwQzYQSi4hNnPo/5nNZpl2qx0ZaKz3uWpZCJ9 fhqo6DA9RUNLRcXVeVUtd+zbKPLzadL9r2CBwNxxrZ13/Fjs9J9dYEz7AQxF2S/anq1p7wJq4ZJqG ITwjL8zCyhU13DWrMklPHrrZpx8DE3L3fc4nLK8EQX8Ua09JTEyzQWO7ooF/7QY8Ebv+Hlrrn7Gr7 UteAujCfLCeDIikaNZP8cg4i4zzxVb3pCgHqxo4WQxt/oV6lXan9kZjQD0p0xPZ8DtTRq5nX8imBK 87n6+jcg==; Received: from [192.168.2.1] (port=48034 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptaZk-000J8n-0n; Mon, 01 May 2023 21:56:48 +0100 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH mumi 0/2] Cc all issue participants when sending email Date: Mon, 1 May 2023 21:56:39 +0100 Message-Id: <20230501205639.16201-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, This patchset makes mumi send-email automatically Cc all issue participants. I will push this patchset in a few days unless there are objections. Cheers! Arun Arun Isaac (2): client: Support passing options to git send-email. client: Cc issue participants when sending email. mumi/client.scm | 44 ++++++++++++++++++++++++++++++++++++-------- tests/client.scm | 24 ++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 8 deletions(-) -- 2.39.2 ------------=_1683458942-29883-1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 08 12:25:28 2024 Received: (at control) by debbugs.gnu.org; 8 Feb 2024 17:25:28 +0000 Received: from localhost ([127.0.0.1]:33530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY89Q-0001AM-9M for submit@debbugs.gnu.org; Thu, 08 Feb 2024 12:25:28 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:49244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY89N-0001A7-Af for control@debbugs.gnu.org; Thu, 08 Feb 2024 12:25:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=nJJB8mHFYWalbjw mfEEbIPBAMKWEbS0CXHC6CtAxDCs=; h=date:cc:to:from; d=lease-up.com; b=hM kxXYb93CsyUKdDTDGHvBTkvbpPNbe32kUPrqIt0V3rHFKPW2WY/trk5mJGuM5e0dEN7jX+ kCyYlL8ICYdePuE0hDK7GTPFmy424XJvZ1t885hWFUOF0vYQLup76e/2ytvAnGu4Z3G/Kg gHJnfXpsR4/H1EdUWJkeD6YPMAuzk= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 0323fed3 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Thu, 8 Feb 2024 17:25:09 +0000 (UTC) From: Felix Lechner To: control@debbugs.gnu.org Date: Thu, 08 Feb 2024 09:25:09 -0800 Message-ID: <87plx66f7u.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 49115 reassign 49115 mumi archive 49115 unarchive 41906 reassign 41906 mumi archive 41906 unarchive 60410 reassign 60410 mumi archive 60410 Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unarchive 49115 reassign 49115 mumi archive 49115 unarchive 41906 reassign 41906 mumi archive 41906 unarchive 60410 reassign 60410 mumi archive 60410 unarchive 63215 reassign 63215 mumi archive 63215 unarchive 41098 reassign 41098 mumi archive 41098 thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 23 08:24:11 2024 Received: (at control) by debbugs.gnu.org; 23 Feb 2024 13:24:11 +0000 Received: from localhost ([127.0.0.1]:38392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdVX9-0000M9-9g for submit@debbugs.gnu.org; Fri, 23 Feb 2024 08:24:11 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:52832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdVX7-0000Lx-DD for control@debbugs.gnu.org; Fri, 23 Feb 2024 08:24:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=0PeEJYVffjYOBZE HGZWFMzZuqMQDkikIxyohJDTEc0c=; h=date:cc:to:from; d=lease-up.com; b=hd uWOtzruwXENaYv9M3KDGM1xgXMQYebOROpyi0dQOtUdq2T6NJqybegl/3CYFadl66+XGCW UBykA+2Hr1VxczMBuTammIk7z3rZCtX5l1M2wILplj4MsIJKCrQt59gJs9+QO10yOuBB1/ DQRuB/cf0/1x1pROxNrsDEG9pWvE4= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id ed37bc2b (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Fri, 23 Feb 2024 13:23:44 +0000 (UTC) From: Felix Lechner To: control@debbugs.gnu.org Date: Fri, 23 Feb 2024 05:23:44 -0800 Message-ID: <875xyf1fhb.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 68680 reassign 68680 mumi archive 68680 unarchive 63802 reassign 63802 mumi archive 63802 unarchive 63215 reassign 63215 mumi archive 63215 Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unarchive 68680 reassign 68680 mumi archive 68680 unarchive 63802 reassign 63802 mumi archive 63802 unarchive 63215 reassign 63215 mumi archive 63215 unarchive 61645 reassign 61645 mumi archive 61645 unarchive 60410 reassign 60410 mumi archive 60410 unarchive 60292 reassign 60292 mumi archive 60292 unarchive 60292 reassign 60292 mumi archive 60292 unarchive 58573 reassign 58573 mumi archive 58573 unarchive 54024 reassign 54024 mumi archive 54024 unarchive 49115 reassign 49115 mumi archive 49115 unarchive 48160 reassign 48160 mumi archive 48160 unarchive 47739 reassign 47739 mumi archive 47739 unarchive 47520 reassign 47520 mumi archive 47520 unarchive 47121 reassign 47121 mumi archive 47121 unarchive 45015 reassign 45015 mumi archive 45015 unarchive 43661 reassign 43661 mumi archive 43661 unarchiv 43166 reassign 43166 mumi archive 43166 unarchive 41906 reassign 41906 mumi archive 41906 unarchive 41098 reassign 41098 mumi archive 41098 unarchive 39924 reassign 39924 mumi archive 39924 unarchive 39924 reassign 39924 mumi archive 39924 unarchive 39924 reassign 39924 mumi archive 39924 thanks