From unknown Sat Aug 09 13:08:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6317 <6317@debbugs.gnu.org> To: bug#6317 <6317@debbugs.gnu.org> Subject: Status: [PATCH] tests: remove unnecessary single quotes in perl hash use: ->{'SYM'} Reply-To: bug#6317 <6317@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:08:37 +0000 retitle 6317 [PATCH] tests: remove unnecessary single quotes in perl hash u= se: ->{'SYM'} reassign 6317 coreutils submitter 6317 Jim Meyering severity 6317 normal tag 6317 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 05:02:16 2010 Received: (at submit) by debbugs.gnu.org; 31 May 2010 09:02:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJ0sx-0000e1-Nm for submit@debbugs.gnu.org; Mon, 31 May 2010 05:02:16 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJ0sv-0000dw-CV for submit@debbugs.gnu.org; Mon, 31 May 2010 05:02:14 -0400 Received: from lists.gnu.org ([199.232.76.165]:46375) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OJ0ss-00025I-4L for submit@debbugs.gnu.org; Mon, 31 May 2010 05:02:10 -0400 Received: from [140.186.70.92] (port=56267 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJ0sq-0006cI-Dq for bug-coreutils@gnu.org; Mon, 31 May 2010 05:02:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJ0sn-0001DC-K8 for bug-coreutils@gnu.org; Mon, 31 May 2010 05:02:08 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:55499) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJ0sn-0001Bl-1S for bug-coreutils@gnu.org; Mon, 31 May 2010 05:02:05 -0400 Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp1-g21.free.fr (Postfix) with ESMTP id CD18D940112 for ; Mon, 31 May 2010 11:01:58 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 91D15A02; Mon, 31 May 2010 11:01:57 +0200 (CEST) From: Jim Meyering To: bug-coreutils@gnu.org Subject: [PATCH] tests: remove unnecessary single quotes in perl hash use: ->{'SYM'} Date: Mon, 31 May 2010 11:01:57 +0200 Message-ID: <87bpbwxx4q.fsf@meyering.net> Lines: 147 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) i.e. in Perl code, write $hash{KEY}, not $hash{'KEY'} >From f385d97a4144a30e23bc35ce8ec33c26b6cd84e9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 15 May 2010 17:58:52 +0200 Subject: [PATCH] tests: remove unnecessary single quotes in perl hash use: ->{'SYM'} Run this command: git grep -l "limits->{'" \ | xargs perl -pi -e "s/limits->{'(.*?)'}/limits->{\$1}/g" * cfg.mk (sc_prohibit_perl_hash_quotes): New rule to match. * tests/misc/join: Remove quotes. * tests/misc/sort: Likewise. * tests/misc/sort-merge: Likewise. * tests/misc/test: Likewise. * tests/misc/unexpand: Likewise. * tests/misc/uniq: Likewise. --- cfg.mk | 5 +++++ tests/misc/join | 4 ++-- tests/misc/sort | 4 ++-- tests/misc/sort-merge | 2 +- tests/misc/test | 6 +++--- tests/misc/unexpand | 2 +- tests/misc/uniq | 4 ++-- 7 files changed, 16 insertions(+), 11 deletions(-) diff --git a/cfg.mk b/cfg.mk index ae05f8c..dff5de5 100644 --- a/cfg.mk +++ b/cfg.mk @@ -233,6 +233,11 @@ sc_require_stdio_safer: else :; \ fi +sc_prohibit_perl_hash_quotes: + @prohibit="\{'[A-Z_]+' *[=}]" \ + halt="in Perl code, write \$$hash{KEY}, not \$$hash{'K''EY'}" \ + $(_sc_search_regexp) + # Prefer xnanosleep over other less-precise sleep methods sc_prohibit_sleep: @prohibit='\<(nano|u)?sleep \(' \ diff --git a/tests/misc/join b/tests/misc/join index cef8137..0e34ba8 100755 --- a/tests/misc/join +++ b/tests/misc/join @@ -146,9 +146,9 @@ my @tv = ( t_subst "a:1:2:\nb:1:2:\n", 0], # fields > SIZE_MAX are silently interpreted as SIZE_MAX -['bigfield1', "-1 $limits->{'UINTMAX_OFLOW'} -2 2", +['bigfield1', "-1 $limits->{UINTMAX_OFLOW} -2 2", ["a\n", "b\n"], " a b\n", 0], -['bigfield2', "-1 $limits->{'SIZE_OFLOW'} -2 2", +['bigfield2', "-1 $limits->{SIZE_OFLOW} -2 2", ["a\n", "b\n"], " a b\n", 0], # FIXME: change this to ensure the diagnostic makes sense diff --git a/tests/misc/sort b/tests/misc/sort index 4ca52fe..0b09845 100755 --- a/tests/misc/sort +++ b/tests/misc/sort @@ -353,9 +353,9 @@ my @Tests = {IN=>"a\0z\01\nb\0y\02\n"}, {OUT=>"b\0y\02\na\0z\01\n"}], # fields > SIZE_MAX are silently interpreted as SIZE_MAX -["bigfield1", "-k $limits->{'UINTMAX_OFLOW'}", +["bigfield1", "-k $limits->{UINTMAX_OFLOW}", {IN=>"2\n1\n"}, {OUT=>"1\n2\n"}], -["bigfield2", "-k $limits->{'SIZE_OFLOW'}", +["bigfield2", "-k $limits->{SIZE_OFLOW}", {IN=>"2\n1\n"}, {OUT=>"1\n2\n"}], # Using an old-style key-specifying option like +1 with an invalid diff --git a/tests/misc/sort-merge b/tests/misc/sort-merge index 70fc7b4..c659505 100755 --- a/tests/misc/sort-merge +++ b/tests/misc/sort-merge @@ -34,7 +34,7 @@ my $big_input = "aaa\n" x 1024; # don't need to check for existence, since we're running in a temp dir my $badtmp = 'does/not/exist'; -my $bigint = $limits->{'UINTMAX_OFLOW'}; +my $bigint = $limits->{UINTMAX_OFLOW}; my @Tests = ( diff --git a/tests/misc/test b/tests/misc/test index 799bff0..da33de7 100755 --- a/tests/misc/test +++ b/tests/misc/test @@ -158,19 +158,19 @@ my @Tests = ['eq-3', qw(0 -eq 00)], ['eq-4', qw(8 -eq 9), {EXIT=>1}], ['eq-5', qw(1 -eq 0), {EXIT=>1}], - ['eq-6', "$limits->{'UINTMAX_OFLOW'} -eq 0", {EXIT=>1}], + ['eq-6', "$limits->{UINTMAX_OFLOW} -eq 0", {EXIT=>1}], ['gt-1', qw(5 -gt 5), {EXIT=>1}], ['gt-2', qw(5 -gt 4)], ['gt-3', qw(4 -gt 5), {EXIT=>1}], ['gt-4', qw(-1 -gt -2)], - ['gt-5', "$limits->{'UINTMAX_OFLOW'} -gt $limits->{'INTMAX_UFLOW'}"], + ['gt-5', "$limits->{UINTMAX_OFLOW} -gt $limits->{INTMAX_UFLOW}"], ['lt-1', qw(5 -lt 5), {EXIT=>1}], ['lt-2', qw(5 -lt 4), {EXIT=>1}], ['lt-3', qw(4 -lt 5)], ['lt-4', qw(-1 -lt -2), {EXIT=>1}], - ['lt-5', "$limits->{'INTMAX_UFLOW'} -lt $limits->{'UINTMAX_OFLOW'}"], + ['lt-5', "$limits->{INTMAX_UFLOW} -lt $limits->{UINTMAX_OFLOW}"], ['inv-1', qw(0x0 -eq 00), {EXIT=>2}, {ERR=>"$prog: invalid integer `0x0'\n"}], diff --git a/tests/misc/unexpand b/tests/misc/unexpand index 327db9e..d98da58 100755 --- a/tests/misc/unexpand +++ b/tests/misc/unexpand @@ -78,7 +78,7 @@ my @Tests = # It is debatable whether this test should require an environment # setting of e.g., _POSIX2_VERSION=1. - ['obs-ovflo', "-$limits->{'UINTMAX_OFLOW'}", {IN=>''}, {OUT=>''}, + ['obs-ovflo', "-$limits->{UINTMAX_OFLOW}", {IN=>''}, {OUT=>''}, {EXIT => 1}, {ERR => "$prog: tab stop value is too large\n"}], ); diff --git a/tests/misc/uniq b/tests/misc/uniq index e49fe75..4d1f8a4 100755 --- a/tests/misc/uniq +++ b/tests/misc/uniq @@ -194,8 +194,8 @@ my @Tests = . $try}], # Check that -d and -u suppress all output, as POSIX requires. ['120', qw(-d -u), {IN=>"a\na\n\b"}, {OUT=>""}], - ['121', "-d -u -w$limits->{'UINTMAX_OFLOW'}", {IN=>"a\na\n\b"}, {OUT=>""}], - ['122', "-d -u -w$limits->{'SIZE_OFLOW'}", {IN=>"a\na\n\b"}, {OUT=>""}], + ['121', "-d -u -w$limits->{UINTMAX_OFLOW}", {IN=>"a\na\n\b"}, {OUT=>""}], + ['122', "-d -u -w$limits->{SIZE_OFLOW}", {IN=>"a\na\n\b"}, {OUT=>""}], # Check that --zero-terminated is synonymous with -z. ['123', '--zero-terminated', {IN=>"a\na\nb"}, {OUT=>"a\na\nb\0"}], ['124', '--zero-terminated', {IN=>"a\0a\0b"}, {OUT=>"a\0b\0"}], -- 1.7.1.348.gb26ba From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 03 08:33:56 2010 Received: (at control) by debbugs.gnu.org; 3 Jun 2010 12:33:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OK9cS-0004YZ-DY for submit@debbugs.gnu.org; Thu, 03 Jun 2010 08:33:56 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OK9cP-0004YU-JR for control@debbugs.gnu.org; Thu, 03 Jun 2010 08:33:54 -0400 Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp1-g21.free.fr (Postfix) with ESMTP id C7C53940114 for ; Thu, 3 Jun 2010 14:33:43 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 040A9DE32; Thu, 3 Jun 2010 14:33:42 +0200 (CEST) From: Jim Meyering To: control@debbugs.gnu.org Subject: control In-Reply-To: <87d3wkot6w.fsf@meyering.net> (Jim Meyering's message of "Tue, 25 May 2010 18:13:43 +0200") References: <87d3wkot6w.fsf@meyering.net> Date: Thu, 03 Jun 2010 14:33:41 +0200 Message-ID: <87ljaw70t6.fsf@meyering.net> Lines: 7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) close 6270 close 6169 close 6317 close 6329 close 6293 tags 5962 + wishlist From unknown Sat Aug 09 13:08:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Jul 2010 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator