From unknown Sun Jul 27 00:55:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Apr 2023 21:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63159 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63159@debbugs.gnu.org Cc: Brian Cully X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16827171376164 (code B ref -1); Fri, 28 Apr 2023 21:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Apr 2023 21:25:37 +0000 Received: from localhost ([127.0.0.1]:34648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVaz-0001bL-9v for submit@debbugs.gnu.org; Fri, 28 Apr 2023 17:25:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:52796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVax-0001bC-LF for submit@debbugs.gnu.org; Fri, 28 Apr 2023 17:25:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psVav-0000gG-CE for guix-patches@gnu.org; Fri, 28 Apr 2023 17:25:34 -0400 Received: from coleridge.kublai.com ([166.84.7.167] helo=mail.spork.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psVat-0004GI-NO for guix-patches@gnu.org; Fri, 28 Apr 2023 17:25:33 -0400 Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id B545E923E; Fri, 28 Apr 2023 17:25:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1682717129; bh=JK2v5lzbMOFOsM77kVIx5xyomcesSxS7fJW6/Ja10go=; h=From:To:Cc:Subject:Date; b=IzksRu/HPpfzMMK9LU6i2k8ZzyzYlENWAwx+0/tJhtZfzTJQFXq5zBUmvNrITYvYn vBT2QiZkaPAU36AcMn6/KPrDYfyUdQt043JbCBTTWGhm0Jbl/VR8g3jmp8G0fKve2R Agb9qjlgGwmdTlpIqegRSU4QD3qheor5UXu9gJK0= From: Brian Cully Date: Fri, 28 Apr 2023 17:25:22 -0400 Message-Id: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=166.84.7.167; envelope-from=bjc@spork.org; helo=mail.spork.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) GCC-11 sniffed out a long-standing bug where a pointer was being tested for a negative value, which is impossible. Instead, check for NULL, which is how the error result is actually returned. See https://github.com/iwamatsu/slim/issues/14 for details. * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new phase --- gnu/packages/display-managers.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm index b0d388f1bc..c1a08e8553 100644 --- a/gnu/packages/display-managers.scm +++ b/gnu/packages/display-managers.scm @@ -475,7 +475,11 @@ (define-public slim ;; The build system's logic here is: if "Linux", then ;; "systemd". Strip that. "")) - #t))) + #t)) + (add-before 'configure 'fix-0-pointer-comparison + (lambda _ + (substitute* "panel.cpp" + (("WinGC < 0") "WinGC == NULL"))))) #:configure-flags '("-DUSE_PAM=yes" "-DUSE_CONSOLEKIT=no") #:tests? #f)) -- 2.39.2 From unknown Sun Jul 27 00:55:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63159] [PATCH 2/2] gnu: slim: Update homepage. Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Apr 2023 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63159 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63159@debbugs.gnu.org Cc: Brian Cully Received: via spool by 63159-submit@debbugs.gnu.org id=B63159.16827172716490 (code B ref 63159); Fri, 28 Apr 2023 21:28:02 +0000 Received: (at 63159) by debbugs.gnu.org; 28 Apr 2023 21:27:51 +0000 Received: from localhost ([127.0.0.1]:34666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVd9-0001gc-CW for submit@debbugs.gnu.org; Fri, 28 Apr 2023 17:27:51 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:53439 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVd7-0001gU-EG for 63159@debbugs.gnu.org; Fri, 28 Apr 2023 17:27:50 -0400 Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id E70EF923F; Fri, 28 Apr 2023 17:27:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1682717269; bh=VJj7ro4pjffnGP/YRNlO1/Yw8uCGRpp+mQC8WypQjf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HbmsOD2tIdmRwicwC/c3r6jUMlSPKgwUQzP393zc1fjKQDiI4YCvLUWCYATFMqk0i aQ2PvihxKWlKapw0zr61MrQATwy35+GvaQFPCn3b5VYbAdF8rySAotOvN0f13YNo0o ur8uqOhHnySUL4rx5sGBNt4kS/jfI5VjSHqgFMyw= From: Brian Cully Date: Fri, 28 Apr 2023 17:27:38 -0400 Message-Id: <355b5c4bb290bf0d01b36919346f605e8c458001.1682717258.git.bjc@spork.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717258.git.bjc@spork.org> References: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717258.git.bjc@spork.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Moved to github, according to https://www.berlios.de/software/slim/. * gnu/packages/display-managers.scm (slim) [home-page]: update URL. --- gnu/packages/display-managers.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm index c1a08e8553..9ddcef7021 100644 --- a/gnu/packages/display-managers.scm +++ b/gnu/packages/display-managers.scm @@ -485,7 +485,7 @@ (define-public slim #:tests? #f)) ;; This used to be at . - (home-page "https://sourceforge.net/projects/slim.berlios/") + (home-page "https://github.com/iwamatsu/slim") (synopsis "Desktop-independent graphical login manager for X11") (description "SLiM is a Desktop-independent graphical login manager for X11, derived -- 2.39.2 From unknown Sun Jul 27 00:55:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Apr 2023 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63159 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63159@debbugs.gnu.org Received: via spool by 63159-submit@debbugs.gnu.org id=B63159.16827173436652 (code B ref 63159); Fri, 28 Apr 2023 21:30:02 +0000 Received: (at 63159) by debbugs.gnu.org; 28 Apr 2023 21:29:03 +0000 Received: from localhost ([127.0.0.1]:34670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVeI-0001jE-QW for submit@debbugs.gnu.org; Fri, 28 Apr 2023 17:29:02 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:63077 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVeH-0001is-Tr for 63159@debbugs.gnu.org; Fri, 28 Apr 2023 17:29:02 -0400 Received: from psyduck (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id B11DB914C for <63159@debbugs.gnu.org>; Fri, 28 Apr 2023 17:29:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1682717341; bh=p0y4ZPacEC46OLKIRHowFupTB1wNooh5xllJhr0V+G8=; h=From:To:Subject:References:Date:In-Reply-To; b=Syir6v3aMhEO/Ytlm+5H4FMitYPx6FTWiZLxv4AyhxXGNrHkWn+kBO68YKZLfcjfn i19g0JgxaxTH2XBKSU1kcexqSKsqOKKFuUVsUBBhy+aQYJO36qmQii1h5OYc1ZNAN2 ng11GDvFUK7MJo0jdHYvmHwIRgbZy9W2PI980YpY= From: Brian Cully References: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> Date: Fri, 28 Apr 2023 17:28:57 -0400 In-Reply-To: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> (Brian Cully's message of "Fri, 28 Apr 2023 17:25:22 -0400") Message-ID: <87fs8jpug6.fsf@psyduck.jhoto.kublai.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This patch fixes #63155 -bjc From unknown Sun Jul 27 00:55:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Brian Cully Subject: bug#63159: closed (Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11) Message-ID: References: <875y9doytq.fsf@gnu.org> <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> X-Gnu-PR-Message: they-closed 63159 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63159@debbugs.gnu.org Date: Sun, 30 Apr 2023 21:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1682889422-27232-1" This is a multi-part message in MIME format... ------------=_1682889422-27232-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63159@debbugs.gnu.org. --=20 63159: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63159 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1682889422-27232-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63159-done) by debbugs.gnu.org; 30 Apr 2023 21:16:44 +0000 Received: from localhost ([127.0.0.1]:38485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptEPU-00074G-1I for submit@debbugs.gnu.org; Sun, 30 Apr 2023 17:16:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptEPR-00073t-Lj; Sun, 30 Apr 2023 17:16:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptEPM-0001hM-F8; Sun, 30 Apr 2023 17:16:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=hdEbSB60Hke/X3TX0TgSzv1CPsDeuUW/J04ao0sBj+Q=; b=CNfzj8ci0UpbBAddzHnZ aHbDYmVCL33L4Ea95c0Vvy/bsYD+twR6qNSsNMc0GsM2qLggIS1VcnntgrIgyeVDZQBcGwaV77Lrv XD6lXJMXU2MwgA7w8BB9g2IwV5TNZlseC7Th90EzPLq2SP7Bsz/qKqxzm8JgWO3wnunYarVgTrkFD xSCUS66PIeFR6/vLYzWiN/RNo02uhtvr7npJnS4b7Xog7cnJx0h6lqdiAkZEKFgfglOhnZlkC57gy dzw/hOO6wB2yV5TbWBzOtExTcQAAg1NRo7C+dmLrjcifKTJ/j39uOObtbRS0GZ3LYXwNnpI/2LnQ+ fUjsjbdddmCKuw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptEPL-0007S7-OA; Sun, 30 Apr 2023 17:16:35 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brian Cully Subject: Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 References: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> Date: Sun, 30 Apr 2023 23:16:33 +0200 In-Reply-To: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> (Brian Cully's message of "Fri, 28 Apr 2023 17:25:22 -0400") Message-ID: <875y9doytq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63159-done Cc: 63159-done@debbugs.gnu.org, 63155-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Brian Cully skribis: > GCC-11 sniffed out a long-standing bug where a pointer was being tested f= or a > negative value, which is impossible. Instead, check for NULL, which is ho= w the > error result is actually returned. > > See https://github.com/iwamatsu/slim/issues/14 for details. > > * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new > phase [...] > Moved to github, according to https://www.berlios.de/software/slim/. > > * gnu/packages/display-managers.scm (slim) [home-page]: update URL. Applied, thanks! Ludo=E2=80=99. ------------=_1682889422-27232-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Apr 2023 21:25:37 +0000 Received: from localhost ([127.0.0.1]:34648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVaz-0001bL-9v for submit@debbugs.gnu.org; Fri, 28 Apr 2023 17:25:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:52796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psVax-0001bC-LF for submit@debbugs.gnu.org; Fri, 28 Apr 2023 17:25:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psVav-0000gG-CE for guix-patches@gnu.org; Fri, 28 Apr 2023 17:25:34 -0400 Received: from coleridge.kublai.com ([166.84.7.167] helo=mail.spork.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psVat-0004GI-NO for guix-patches@gnu.org; Fri, 28 Apr 2023 17:25:33 -0400 Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id B545E923E; Fri, 28 Apr 2023 17:25:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1682717129; bh=JK2v5lzbMOFOsM77kVIx5xyomcesSxS7fJW6/Ja10go=; h=From:To:Cc:Subject:Date; b=IzksRu/HPpfzMMK9LU6i2k8ZzyzYlENWAwx+0/tJhtZfzTJQFXq5zBUmvNrITYvYn vBT2QiZkaPAU36AcMn6/KPrDYfyUdQt043JbCBTTWGhm0Jbl/VR8g3jmp8G0fKve2R Agb9qjlgGwmdTlpIqegRSU4QD3qheor5UXu9gJK0= From: Brian Cully To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 Date: Fri, 28 Apr 2023 17:25:22 -0400 Message-Id: <70e16c55304b4235a9d72913a2c9bd8e6a3d0da0.1682717123.git.bjc@spork.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=166.84.7.167; envelope-from=bjc@spork.org; helo=mail.spork.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Brian Cully X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) GCC-11 sniffed out a long-standing bug where a pointer was being tested for a negative value, which is impossible. Instead, check for NULL, which is how the error result is actually returned. See https://github.com/iwamatsu/slim/issues/14 for details. * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new phase --- gnu/packages/display-managers.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm index b0d388f1bc..c1a08e8553 100644 --- a/gnu/packages/display-managers.scm +++ b/gnu/packages/display-managers.scm @@ -475,7 +475,11 @@ (define-public slim ;; The build system's logic here is: if "Linux", then ;; "systemd". Strip that. "")) - #t))) + #t)) + (add-before 'configure 'fix-0-pointer-comparison + (lambda _ + (substitute* "panel.cpp" + (("WinGC < 0") "WinGC == NULL"))))) #:configure-flags '("-DUSE_PAM=yes" "-DUSE_CONSOLEKIT=no") #:tests? #f)) -- 2.39.2 ------------=_1682889422-27232-1--