GNU bug report logs - #63159
[PATCH 1/2] gnu: slim: Fix build failure with GCC-11

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63159 in the body.
You can then email your comments to 63159 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: guix-patches <at> gnu.org
Cc: Brian Cully <bjc <at> spork.org>
Subject: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
Date: Fri, 28 Apr 2023 17:25:22 -0400

GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
negative value, which is impossible. Instead, check for NULL, which is how the
error result is actually returned.

See https://github.com/iwamatsu/slim/issues/14 for details.

* gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
phase
---
 gnu/packages/display-managers.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index b0d388f1bc..c1a08e8553 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -475,7 +475,11 @@ (define-public slim
                ;; The build system's logic here is: if "Linux", then
                 ;; "systemd".  Strip that.
                 ""))
-             #t)))
+             #t))
+         (add-before 'configure 'fix-0-pointer-comparison
+           (lambda _
+             (substitute* "panel.cpp"
+               (("WinGC < 0") "WinGC == NULL")))))
        #:configure-flags '("-DUSE_PAM=yes"
                            "-DUSE_CONSOLEKIT=no")
        #:tests? #f))
-- 
2.39.2

Message #8 received at 63159 <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: 63159 <at> debbugs.gnu.org
Cc: Brian Cully <bjc <at> spork.org>
Subject: [PATCH 2/2] gnu: slim: Update homepage.
Date: Fri, 28 Apr 2023 17:27:38 -0400

Moved to github, according to https://www.berlios.de/software/slim/.

* gnu/packages/display-managers.scm (slim) [home-page]:  update URL.
---
 gnu/packages/display-managers.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index c1a08e8553..9ddcef7021 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -485,7 +485,7 @@ (define-public slim
        #:tests? #f))
 
     ;; This used to be at <http://slim.berlios.de/>.
-    (home-page "https://sourceforge.net/projects/slim.berlios/")
+    (home-page "https://github.com/iwamatsu/slim")
     (synopsis "Desktop-independent graphical login manager for X11")
     (description
      "SLiM is a Desktop-independent graphical login manager for X11, derived
-- 
2.39.2

Message #11 received at 63159 <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: 63159 <at> debbugs.gnu.org
Subject: Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
Date: Fri, 28 Apr 2023 17:28:57 -0400

This patch fixes #63155

-bjc

Message #16 received at 63159-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brian Cully <bjc <at> spork.org>
Cc: 63159-done <at> debbugs.gnu.org, 63155-done <at> debbugs.gnu.org
Subject: Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
Date: Sun, 30 Apr 2023 23:16:33 +0200

Hi,

Brian Cully <bjc <at> spork.org> skribis:

> GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> negative value, which is impossible. Instead, check for NULL, which is how the
> error result is actually returned.
>
> See https://github.com/iwamatsu/slim/issues/14 for details.
>
> * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> phase

[...]

> Moved to github, according to https://www.berlios.de/software/slim/.
>
> * gnu/packages/display-managers.scm (slim) [home-page]:  update URL.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.