GNU bug report logs - #63155
slim fails to build

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63155 in the body.
You can then email your comments to 63155 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julian Flake <flake <at> uni-koblenz.de>
To: bug-guix <at> gnu.org
Subject: slim fails to build
Date: Fri, 28 Apr 2023 21:23:16 +0200

compilation error is:

/tmp/guix-build-slim-1.3.6.drv-0/slim-1.3.6/panel.cpp: In 
constructor ‘Panel::Panel(Display*, int, Window, Cfg*, const 
string&, Panel::PanelType)’:
/tmp/guix-build-slim-1.3.6.drv-0/slim-1.3.6/panel.cpp:51:27: 
error: ordered comparison of pointer with integer zero (‘GC’ {aka 
‘_XGC*’} and ‘int’)
  51 |                 if (WinGC < 0) {
     |                     ~~~~~~^~~
make[2]: *** [CMakeFiles/libslim.dir/build.make:121: 
CMakeFiles/libslim.dir/panel.cpp.o] Error 1

Message #10 received at 63155-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brian Cully <bjc <at> spork.org>
Cc: 63159-done <at> debbugs.gnu.org, 63155-done <at> debbugs.gnu.org
Subject: Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
Date: Sun, 30 Apr 2023 23:16:33 +0200

Hi,

Brian Cully <bjc <at> spork.org> skribis:

> GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> negative value, which is impossible. Instead, check for NULL, which is how the
> error result is actually returned.
>
> See https://github.com/iwamatsu/slim/issues/14 for details.
>
> * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> phase

[...]

> Moved to github, according to https://www.berlios.de/software/slim/.
>
> * gnu/packages/display-managers.scm (slim) [home-page]:  update URL.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.