GNU bug report logs - #63145
[PATCH 1/3] gnu: maven-*-*: Fix - add missing shebang to the sisu.sh.

Previous Next

Full log

Message #14 received at 63145 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 63145 <at> debbugs.gnu.org
Subject: Re: bug#63145: [PATCH 1/3] gnu: maven-*-*: Fix - add missing
 shebang to the sisu.sh.
Date: Fri, 28 Apr 2023 22:30:53 +0200

Hi Rostislav,

I pushed patches minutes ago fixing the same thing:

  https://issues.guix.gnu.org/63094

They lack the nice factorization that you add, but they use
‘substitute*’ instead of calling out to ‘sed’, which is the preferred
way to do it.

We could definitely factorize along the lines of what you propose.
Would you like to update these two patches?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.