GNU bug report logs - #63142
30.0.50; QUOTING_STYLE can break dired

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ruijie Yu <ruijie <at> netyu.xyz>
Cc: wavexx <at> thregr.org, 63142 <at> debbugs.gnu.org
Subject: bug#63142: 30.0.50; QUOTING_STYLE can break dired
Date: Sat, 29 Apr 2023 18:16:05 +0300

> From: Ruijie Yu <ruijie <at> netyu.xyz>
> Cc: Yuri D'Elia <wavexx <at> thregr.org>, 63142 <at> debbugs.gnu.org
> Date: Sat, 29 Apr 2023 23:05:27 +0800
> 
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Does the patch below give good results?
> >
> > diff --git a/lisp/dired.el b/lisp/dired.el
> > index d1471e9..e3a9d7b 100644
> > --- a/lisp/dired.el
> > +++ b/lisp/dired.el
> > @@ -1653,7 +1653,10 @@ dired-insert-directory
> >  see `dired-use-ls-dired' for more details.")
> >  		       nil))
> >  	       dired-use-ls-dired)))
> > -	(setq switches (concat "--dired " switches)))
> > +        ;; Use -N with --dired, to countermand possible non-default
> > +        ;; quoting style, in particular via the environment variable
> > +        ;; QUOTINTG_STYLE.
> > +	(setq switches (concat "--dired -N " switches)))
> >      ;; Expand directory wildcards and fill file-list.
> >      (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir)))
> >        (cond (dir-wildcard
> 
> Do we need to prevent "wild" users from setting a conflicting quoting
> style in `switches'

Why would we want to do that?  If they think they know what they are
doing, let them live with the consequences.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.