From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 05:46:25 2023 Received: (at submit) by debbugs.gnu.org; 28 Apr 2023 09:46:25 +0000 Received: from localhost ([127.0.0.1]:60489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psKgL-00053s-2G for submit@debbugs.gnu.org; Fri, 28 Apr 2023 05:46:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:39966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psKgG-00053g-T2 for submit@debbugs.gnu.org; Fri, 28 Apr 2023 05:46:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psKgE-0001Hj-AY for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2023 05:46:19 -0400 Received: from erc.thregr.org ([2001:41c9:1:41f::63]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psKgC-00081L-Ho for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2023 05:46:18 -0400 Received: from [37.161.199.69] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1psKg8-000VdY-12 (envelope-from ) for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2023 11:46:12 +0200 User-agent: mu4e 1.11.3; emacs 30.0.50 From: Yuri D'Elia To: bug-gnu-emacs@gnu.org Subject: 30.0.50; QUOTING_STYLE can break dired Date: Fri, 28 Apr 2023 11:35:09 +0200 Message-ID: <87o7n81grh.fsf@wavexx.thregr.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:41c9:1:41f::63; envelope-from=wavexx@thregr.org; helo=erc.thregr.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) If the environment variable QUOTING_STYLE is set, GNU "ls" can return a format that dired doesn't like. QUOTING_STYLE=shell will quote files with spaces such as 'a b', and trying to interact with these files with dired results in: dired-get-file-for-visit: File no longer exists; type g to update Dired buffer Interestingly, even using "ls --dired" does the same if QUOTING_STYLE is set. Should dired handle QUOTING_STYLE (looking at the coreutils manual it seems that other tools besides ls handle it) or should dired actively suppress the quoting mode? From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 06:28:17 2023 Received: (at 63142) by debbugs.gnu.org; 28 Apr 2023 10:28:17 +0000 Received: from localhost ([127.0.0.1]:60524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLKr-0006ay-68 for submit@debbugs.gnu.org; Fri, 28 Apr 2023 06:28:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLKo-0006af-SG for 63142@debbugs.gnu.org; Fri, 28 Apr 2023 06:28:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psLKi-0007BN-Rn; Fri, 28 Apr 2023 06:28:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hA35tto6PTvyJx8PAfs3Hg+bHQZ7AJeSD59Wrn/QmhU=; b=ZH6hnhUbMrx5 SWEEphagEqFyd35i6/wsJLVJpE+Kez/9DiKo/8RC9h7k+Jr0byTJKH2oGZwcaFwAmtWeMmLQoOouy 7YJ1iTObjN/TlQHnbvG4N4f3NUOk8z7Y610vJsvMyQ0xVEgx8fJh7PQtpwBGpdL2+09FFALWgcJUi E/nGp7Y6PWcy8geziSkBVqx/+m56A/7+3OgI4I2PBk8lheuyc4HZVOVFhflkDroj62Gda2t+p5jQO jX6NY9nFd/+3p0xktKS07qdvXD1gkSXjeB4VkGj+yezXYP9lzxe8VOG1oGjtfU4Ova4rnBZYGgryg q/cypqN2TlsD237foaTI2Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psLKh-0004Lk-TV; Fri, 28 Apr 2023 06:28:08 -0400 Date: Fri, 28 Apr 2023 13:28:42 +0300 Message-Id: <83zg6sqp0l.fsf@gnu.org> From: Eli Zaretskii To: Yuri D'Elia In-Reply-To: <87o7n81grh.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Fri, 28 Apr 2023 11:35:09 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <87o7n81grh.fsf@wavexx.thregr.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142 Cc: 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuri D'Elia > Date: Fri, 28 Apr 2023 11:35:09 +0200 > > > If the environment variable QUOTING_STYLE is set, GNU "ls" can return a > format that dired doesn't like. > > QUOTING_STYLE=shell will quote files with spaces such as 'a b', and > trying to interact with these files with dired results in: > > dired-get-file-for-visit: File no longer exists; type g to update Dired buffer > > Interestingly, even using "ls --dired" does the same if QUOTING_STYLE is > set. > > Should dired handle QUOTING_STYLE (looking at the coreutils manual it > seems that other tools besides ls handle it) or should dired actively > suppress the quoting mode? I'd suggest first to report this to Coreutils maintainers: it makes little sense to me to honor QUOTING_STYLE when --dired is specified. If the Coreutils folks decline to handle this, then I guess we will have to. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 06:29:58 2023 Received: (at submit) by debbugs.gnu.org; 28 Apr 2023 10:29:58 +0000 Received: from localhost ([127.0.0.1]:60535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLMU-0006eW-4I for submit@debbugs.gnu.org; Fri, 28 Apr 2023 06:29:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:51704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLMS-0006eM-3O for submit@debbugs.gnu.org; Fri, 28 Apr 2023 06:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psLMR-0007kq-Lh for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2023 06:29:55 -0400 Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psLMQ-0007SS-09 for bug-gnu-emacs@gnu.org; Fri, 28 Apr 2023 06:29:55 -0400 Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id fee9eb57 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 28 Apr 2023 10:29:50 +0000 (UTC) References: <87o7n81grh.fsf@wavexx.thregr.org> User-agent: mu4e 1.9.22; emacs 30.0.50 From: Ruijie Yu To: Yuri D'Elia Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Fri, 28 Apr 2023 18:27:56 +0800 In-reply-to: <87o7n81grh.fsf@wavexx.thregr.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Yuri D'Elia writes: > If the environment variable QUOTING_STYLE is set, GNU "ls" can return a > format that dired doesn't like. > > QUOTING_STYLE=shell will quote files with spaces such as 'a b', and > trying to interact with these files with dired results in: > > dired-get-file-for-visit: File no longer exists; type g to update Dired buffer > > Interestingly, even using "ls --dired" does the same if QUOTING_STYLE is > set. Are you suggesting that for ls, passing --dired should also override the quoting style? Either way, we can also pass --quoting-style onto the command line to override it to something dired can play with. > Should dired handle QUOTING_STYLE (looking at the coreutils manual it > seems that other tools besides ls handle it) or should dired actively > suppress the quoting mode? -- Best, RY [Please note that this mail might go to spam due to some misconfiguration in my mail server -- still investigating.] From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 06:39:11 2023 Received: (at 63142) by debbugs.gnu.org; 28 Apr 2023 10:39:11 +0000 Received: from localhost ([127.0.0.1]:60541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLVP-0006wV-62 for submit@debbugs.gnu.org; Fri, 28 Apr 2023 06:39:11 -0400 Received: from erc.thregr.org ([46.43.2.63]:48020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLVM-0006wI-G1 for 63142@debbugs.gnu.org; Fri, 28 Apr 2023 06:39:09 -0400 Received: from [37.161.199.69] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1psLVL-000Vy0-0H (envelope-from ); Fri, 28 Apr 2023 12:39:07 +0200 References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> User-agent: mu4e 1.11.3; emacs 30.0.50 From: Yuri D'Elia To: Eli Zaretskii Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Fri, 28 Apr 2023 12:37:38 +0200 In-reply-to: <83zg6sqp0l.fsf@gnu.org> Message-ID: <87jzxw1eba.fsf@wavexx.thregr.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Apr 28 2023, Eli Zaretskii wrote: >> Should dired handle QUOTING_STYLE (looking at the coreutils manual it >> seems that other tools besides ls handle it) or should dired actively >> suppress the quoting mode? > > I'd suggest first to report this to Coreutils maintainers: it makes > little sense to me to honor QUOTING_STYLE when --dired is specified. > If the Coreutils folks decline to handle this, then I guess we will > have to. What sort of output should ls use in --dired mode? literal? >From the documentation it seems that '-b' should be used to interact with newlines, so some form of quoting might still be wanted? From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 06:45:48 2023 Received: (at 63142) by debbugs.gnu.org; 28 Apr 2023 10:45:48 +0000 Received: from localhost ([127.0.0.1]:60555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLbo-00078n-8M for submit@debbugs.gnu.org; Fri, 28 Apr 2023 06:45:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psLbm-00078Y-B6 for 63142@debbugs.gnu.org; Fri, 28 Apr 2023 06:45:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psLbh-0002VZ-2m; Fri, 28 Apr 2023 06:45:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7XzWoiC7QIAbaoRHbp6CmZYOzXUmpQWjWPXCZF4EXXU=; b=TXPS864k7Nw0 a0s/Y4WnLzFOG/7FRb81JyOvHl06UKsc+nVtc6ekM3uyOkhDBzLj7EhujU9C8bNZ2nmqy/dhyHVQU J/lKfr07xc3D5Q33iA2v0rS/ppGS7vq7ZASWFZN0YO+7L1OX4Kz0s4suZnzvZphP9cX9pf6sy9vLH 8YsAIingggP0c8ZpgaVsZwtBFjq0XBWzKP7Vs3vcMLyI2A5ZJmv//MszTnF5+haTtjb1kmV082+MN d4TGe7Hv1FE7MMHRir2ps2EgL9Y0DqUviMYHYuYZqOqN5+NroiKsLEeeIC9sfyYThj56ZpbkbUqgB STlVvcXNOdFHvvUw52SfcQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psLbg-0000OR-Jl; Fri, 28 Apr 2023 06:45:40 -0400 Date: Fri, 28 Apr 2023 13:46:15 +0300 Message-Id: <83v8hgqo7c.fsf@gnu.org> From: Eli Zaretskii To: Yuri D'Elia In-Reply-To: <87jzxw1eba.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Fri, 28 Apr 2023 12:37:38 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142 Cc: 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuri D'Elia > Cc: 63142@debbugs.gnu.org > Date: Fri, 28 Apr 2023 12:37:38 +0200 > > On Fri, Apr 28 2023, Eli Zaretskii wrote: > >> Should dired handle QUOTING_STYLE (looking at the coreutils manual it > >> seems that other tools besides ls handle it) or should dired actively > >> suppress the quoting mode? > > > > I'd suggest first to report this to Coreutils maintainers: it makes > > little sense to me to honor QUOTING_STYLE when --dired is specified. > > If the Coreutils folks decline to handle this, then I guess we will > > have to. > > What sort of output should ls use in --dired mode? The default one, I think. --dired already produces the information which tells where each file name begins and ends, so any quoting sounds redundant, no? From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 14:03:43 2023 Received: (at 63142) by debbugs.gnu.org; 28 Apr 2023 18:03:43 +0000 Received: from localhost ([127.0.0.1]:34430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psSRb-0003me-0A for submit@debbugs.gnu.org; Fri, 28 Apr 2023 14:03:43 -0400 Received: from erc.thregr.org ([46.43.2.63]:55110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psSRW-0003mT-Hq for 63142@debbugs.gnu.org; Fri, 28 Apr 2023 14:03:42 -0400 Received: from [37.161.199.69] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1psSRU-000YVQ-2q (envelope-from ); Fri, 28 Apr 2023 20:03:37 +0200 References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> User-agent: mu4e 1.11.3; emacs 30.0.50 From: Yuri D'Elia To: Eli Zaretskii Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Fri, 28 Apr 2023 20:01:01 +0200 In-reply-to: <83v8hgqo7c.fsf@gnu.org> Message-ID: <87fs8j28aw.fsf@wavexx.thregr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Apr 28 2023, Eli Zaretskii wrote: >> > I'd suggest first to report this to Coreutils maintainers: it makes >> > little sense to me to honor QUOTING_STYLE when --dired is specified. >> > If the Coreutils folks decline to handle this, then I guess we will >> > have to. >> >> What sort of output should ls use in --dired mode? > > The default one, I think. --dired already produces the information > which tells where each file name begins and ends, so any quoting > sounds redundant, no? So searching through coreutils I find this old report: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23024 | On further analysis I see that --dired mode already distinguishes | the quoting-style in its output. Also we had already documented | that --dired should specify a --quoting-style to get consistent output. Which huh, does mention this in the ls manual: | If you use a quoting style like =E2=80=98--quoting-style=3Dc=E2=80=99 (= =E2=80=98-Q=E2=80=99) that | adds quote marks, then the offsets include the quote marks. So | beware that the user may select the quoting style via the | environment variable =E2=80=98QUOTING_STYLE=E2=80=99. Hence, applicatio= ns using | =E2=80=98--dired=E2=80=99 should either specify an explicit | =E2=80=98--quoting-style=3Dliteral=E2=80=99 (=E2=80=98-N=E2=80=99) optio= n on the command line, or | else be prepared to parse the escaped names. Then it references a commit mentioning an emacs fix: https://github.com/emacs-mirror/emacs/commit/e4adb6 which however seems to apply to tramp only. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 06:46:28 2023 Received: (at 63142) by debbugs.gnu.org; 29 Apr 2023 10:46:28 +0000 Received: from localhost ([127.0.0.1]:35298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psi60-0007eK-9U for submit@debbugs.gnu.org; Sat, 29 Apr 2023 06:46:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psi5w-0007e5-Q2 for 63142@debbugs.gnu.org; Sat, 29 Apr 2023 06:46:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psi5q-000178-0c; Sat, 29 Apr 2023 06:46:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IZKsMCIhOPhZt0R9YyLH+A7gSLoQPQ2inMtkJFBa59k=; b=UlBijL3Let9P4ykl6lla n5MR6drZm3UuoWmhFze5NnuzgZmcPKfdV0UeHWpAqhGfmLX1JgMDCvBjADN3IaRhcFs+1LpS2ZSSO 4u6xnyXBHvaq/DJWUM1PTYx1NyhsgImdykg0vOdqK6P2qBiJcZCRM6GcJHVSk278Kib49sdNnSEE9 Itzgsts+9vgWWqz2QkHLiDD8peZCG/whb28M0ZwgyukRqv188xj2tRrvEHXZxrDOnygNPEgwvaMoN vxTzQIfOorzLQs8Q8BloAc7YKkvDsMSKR5TIv/VfndN5iEE/z0SZ8eFkn70Npaq++R3skXhTCkvzZ OnQ1G87HbboAaw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psi5p-0004Mc-3v; Sat, 29 Apr 2023 06:46:17 -0400 Date: Sat, 29 Apr 2023 13:46:54 +0300 Message-Id: <83v8hfoti9.fsf@gnu.org> From: Eli Zaretskii To: Yuri D'Elia In-Reply-To: <87fs8j28aw.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Fri, 28 Apr 2023 20:01:01 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142 Cc: 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuri D'Elia > Cc: 63142@debbugs.gnu.org > Date: Fri, 28 Apr 2023 20:01:01 +0200 > > So searching through coreutils I find this old report: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23024 > > | On further analysis I see that --dired mode already distinguishes > | the quoting-style in its output. Also we had already documented > | that --dired should specify a --quoting-style to get consistent output. > > Which huh, does mention this in the ls manual: > > | If you use a quoting style like ‘--quoting-style=c’ (‘-Q’) that > | adds quote marks, then the offsets include the quote marks. So > | beware that the user may select the quoting style via the > | environment variable ‘QUOTING_STYLE’. Hence, applications using > | ‘--dired’ should either specify an explicit > | ‘--quoting-style=literal’ (‘-N’) option on the command line, or > | else be prepared to parse the escaped names. > > Then it references a commit mentioning an emacs fix: > > https://github.com/emacs-mirror/emacs/commit/e4adb6 > > which however seems to apply to tramp only. Does the patch below give good results? diff --git a/lisp/dired.el b/lisp/dired.el index d1471e9..e3a9d7b 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1653,7 +1653,10 @@ dired-insert-directory see `dired-use-ls-dired' for more details.") nil)) dired-use-ls-dired))) - (setq switches (concat "--dired " switches))) + ;; Use -N with --dired, to countermand possible non-default + ;; quoting style, in particular via the environment variable + ;; QUOTINTG_STYLE. + (setq switches (concat "--dired -N " switches))) ;; Expand directory wildcards and fill file-list. (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir))) (cond (dir-wildcard From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 11:07:57 2023 Received: (at 63142) by debbugs.gnu.org; 29 Apr 2023 15:07:57 +0000 Received: from localhost ([127.0.0.1]:36369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psmB2-00025T-R1 for submit@debbugs.gnu.org; Sat, 29 Apr 2023 11:07:57 -0400 Received: from netyu.xyz ([152.44.41.246]:60136 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psmAx-00025E-EI for 63142@debbugs.gnu.org; Sat, 29 Apr 2023 11:07:55 -0400 Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id f7b7bd89 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 29 Apr 2023 15:07:49 +0000 (UTC) References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> <83v8hfoti9.fsf@gnu.org> User-agent: mu4e 1.9.22; emacs 30.0.50 From: Ruijie Yu To: Eli Zaretskii Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Sat, 29 Apr 2023 23:05:27 +0800 In-reply-to: <83v8hfoti9.fsf@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: Yuri D'Elia , 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > Does the patch below give good results? > > diff --git a/lisp/dired.el b/lisp/dired.el > index d1471e9..e3a9d7b 100644 > --- a/lisp/dired.el > +++ b/lisp/dired.el > @@ -1653,7 +1653,10 @@ dired-insert-directory > see `dired-use-ls-dired' for more details.") > nil)) > dired-use-ls-dired))) > - (setq switches (concat "--dired " switches))) > + ;; Use -N with --dired, to countermand possible non-default > + ;; quoting style, in particular via the environment variable > + ;; QUOTINTG_STYLE. > + (setq switches (concat "--dired -N " switches))) > ;; Expand directory wildcards and fill file-list. > (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir))) > (cond (dir-wildcard Do we need to prevent "wild" users from setting a conflicting quoting style in `switches', in which case we should swap the two arguments to `concat'? -- Best, RY [Please note that this mail might go to spam due to some misconfiguration in my mail server -- still investigating.] From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 11:15:39 2023 Received: (at 63142) by debbugs.gnu.org; 29 Apr 2023 15:15:39 +0000 Received: from localhost ([127.0.0.1]:36377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psmIU-0002Is-PP for submit@debbugs.gnu.org; Sat, 29 Apr 2023 11:15:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psmIS-0002Ie-22 for 63142@debbugs.gnu.org; Sat, 29 Apr 2023 11:15:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psmIK-0004FY-Mg; Sat, 29 Apr 2023 11:15:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FYdUA6RcJ1unzJz6DKZDxzQR8Luti3YSUEl5inUbN5M=; b=bJgNFlNd7vsC iWqxWNMO0vpbIDoe6sHfOjVzUl15nhkXmaV70nvS5XDeKkQLqfX4apXdv5bzTu3/Q0oq7HvvAiall KedPGuL6XW4sBgyk/1jkGJBne+LV62h0c+V+Ug2oj1KwodUQYyH4VSqGl2WUYzOo6JF8oe1earEUr Te41Hw2AmQPC9qkYFyu9hvUzuNduH4DPtGR7TXD3dlrkTjJWJRpbuGBw/GN7dUbcEIFH2IlCRRgbB K8BDxsD/lz1NXJlRDzFrJptYybgYNTqvZ7gJpWrBnm7NpOqO1S1SPro4l+aBfQvL5vrv3r6EzMGQn 8fbQfUxlEpyxvhrjWojdhQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psmIJ-0005kQ-Fd; Sat, 29 Apr 2023 11:15:27 -0400 Date: Sat, 29 Apr 2023 18:16:05 +0300 Message-Id: <83o7n6pvm2.fsf@gnu.org> From: Eli Zaretskii To: Ruijie Yu In-Reply-To: (message from Ruijie Yu on Sat, 29 Apr 2023 23:05:27 +0800) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> <83v8hfoti9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ruijie Yu > Cc: Yuri D'Elia , 63142@debbugs.gnu.org > Date: Sat, 29 Apr 2023 23:05:27 +0800 > > > Eli Zaretskii writes: > > > Does the patch below give good results? > > > > diff --git a/lisp/dired.el b/lisp/dired.el > > index d1471e9..e3a9d7b 100644 > > --- a/lisp/dired.el > > +++ b/lisp/dired.el > > @@ -1653,7 +1653,10 @@ dired-insert-directory > > see `dired-use-ls-dired' for more details.") > > nil)) > > dired-use-ls-dired))) > > - (setq switches (concat "--dired " switches))) > > + ;; Use -N with --dired, to countermand possible non-default > > + ;; quoting style, in particular via the environment variable > > + ;; QUOTINTG_STYLE. > > + (setq switches (concat "--dired -N " switches))) > > ;; Expand directory wildcards and fill file-list. > > (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir))) > > (cond (dir-wildcard > > Do we need to prevent "wild" users from setting a conflicting quoting > style in `switches' Why would we want to do that? If they think they know what they are doing, let them live with the consequences. From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 05:36:26 2023 Received: (at 63142) by debbugs.gnu.org; 2 May 2023 09:36:26 +0000 Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptmQs-0002VH-7g for submit@debbugs.gnu.org; Tue, 02 May 2023 05:36:26 -0400 Received: from erc.thregr.org ([46.43.2.63]:51236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptmQp-0002V5-Ho for 63142@debbugs.gnu.org; Tue, 02 May 2023 05:36:25 -0400 Received: from [37.163.72.216] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1ptmQm-0010Uv-2g (envelope-from ); Tue, 02 May 2023 11:36:21 +0200 References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> <83v8hfoti9.fsf@gnu.org> <83o7n6pvm2.fsf@gnu.org> User-agent: mu4e 1.11.3; emacs 30.0.50 From: Yuri D'Elia To: Eli Zaretskii Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Tue, 02 May 2023 11:35:13 +0200 In-reply-to: <83o7n6pvm2.fsf@gnu.org> Message-ID: <874jov13e5.fsf@wavexx.thregr.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: Ruijie Yu , 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Apr 29 2023, Eli Zaretskii wrote: >> > + (setq switches (concat "--dired -N " switches))) >> > ;; Expand directory wildcards and fill file-list. >> > (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir))) >> > (cond (dir-wildcard >> >> Do we need to prevent "wild" users from setting a conflicting quoting >> style in `switches' > > Why would we want to do that? If they think they know what they are > doing, let them live with the consequences. It's always a good idea to actually have the possibility to override flags as an escape hatch. From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 08:18:23 2023 Received: (at 63142) by debbugs.gnu.org; 2 May 2023 12:18:23 +0000 Received: from localhost ([127.0.0.1]:41891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptoxa-0001L7-Vs for submit@debbugs.gnu.org; Tue, 02 May 2023 08:18:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptoxX-0001Ku-RA for 63142@debbugs.gnu.org; Tue, 02 May 2023 08:18:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptoxR-00056I-D3; Tue, 02 May 2023 08:18:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Xh++1KseROm6KtKsfWt7h1VLkdZyK6xd/sNwqrB7NaE=; b=R6awLdLI+Hdf dJxkDDP/SH/fV2I589L/Y5JqcDmjmuw8ol2tTgptbX9GCwWWs9tZLZd6qtVinE44u0+ktGwh0KjGa Km0HnmZuakxQTnYeBmRchlvgpIGmouKCJsImG0jaD5pk4mcD1n8F6xJ2E5NRfUbHlPhxcxnO9Jz6j 015WEO+hjUzK1QV/2OSdLGzoDnRAO5kJ0AiV2MVm2vfFmJFTyyjVC5a0IEZXNGm6OG4rygedar46K pvSknHKjGRLiJ3kOYL27l79gJUdReaiuAyad9602DoXCriELG+vCt58EmSvR7SH1TfMOJhdmghHlq Rw3bH+8ugqkiX1abmGfmUw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptoxO-0006L8-6p; Tue, 02 May 2023 08:18:12 -0400 Date: Tue, 02 May 2023 15:18:56 +0300 Message-Id: <834jovncy7.fsf@gnu.org> From: Eli Zaretskii To: Yuri D'Elia In-Reply-To: <874jov13e5.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Tue, 02 May 2023 11:35:13 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> <83v8hfoti9.fsf@gnu.org> <83o7n6pvm2.fsf@gnu.org> <874jov13e5.fsf@wavexx.thregr.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142 Cc: ruijie@netyu.xyz, 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuri D'Elia > Cc: Ruijie Yu , 63142@debbugs.gnu.org > Date: Tue, 02 May 2023 11:35:13 +0200 > > On Sat, Apr 29 2023, Eli Zaretskii wrote: > >> > + (setq switches (concat "--dired -N " switches))) > >> > ;; Expand directory wildcards and fill file-list. > >> > (let ((dir-wildcard (insert-directory-wildcard-in-dir-p dir))) > >> > (cond (dir-wildcard > >> > >> Do we need to prevent "wild" users from setting a conflicting quoting > >> style in `switches' > > > > Why would we want to do that? If they think they know what they are > > doing, let them live with the consequences. > > It's always a good idea to actually have the possibility to override > flags as an escape hatch. I agree. What about the patch I proposed: does it give good results? From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 12:04:20 2023 Received: (at 63142) by debbugs.gnu.org; 2 May 2023 16:04:20 +0000 Received: from localhost ([127.0.0.1]:44880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptsUG-0000bN-K0 for submit@debbugs.gnu.org; Tue, 02 May 2023 12:04:20 -0400 Received: from erc.thregr.org ([46.43.2.63]:37678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptsUB-0000bA-DX for 63142@debbugs.gnu.org; Tue, 02 May 2023 12:04:19 -0400 Received: from [37.161.97.213] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1ptsU7-0016gt-0c (envelope-from ); Tue, 02 May 2023 18:04:11 +0200 References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> <83v8hfoti9.fsf@gnu.org> <83o7n6pvm2.fsf@gnu.org> <874jov13e5.fsf@wavexx.thregr.org> <834jovncy7.fsf@gnu.org> User-agent: mu4e 1.11.4; emacs 30.0.50 From: Yuri D'Elia To: Eli Zaretskii Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Tue, 02 May 2023 17:57:50 +0200 In-reply-to: <834jovncy7.fsf@gnu.org> Message-ID: <87h6suyb2f.fsf@wavexx.thregr.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: ruijie@netyu.xyz, 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, May 02 2023, Eli Zaretskii wrote: > What about the patch I proposed: does it give good results? Working as intended. From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 13:48:11 2023 Received: (at 63142-done) by debbugs.gnu.org; 2 May 2023 17:48:11 +0000 Received: from localhost ([127.0.0.1]:44963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptu6l-0003Vw-Ba for submit@debbugs.gnu.org; Tue, 02 May 2023 13:48:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptu6i-0003Ux-5L for 63142-done@debbugs.gnu.org; Tue, 02 May 2023 13:48:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptu6c-00074D-6L; Tue, 02 May 2023 13:48:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2WOoWFg1nP5sa9EHBw6PPU87ik/WhQA+RwI4kjk+wyA=; b=kjk8gZeWzKll tURuPYhHQ55BI2IhB2+lWp2uf77Oqvfc9Fj9d2FtcUBey/u/9jERZzNRhoS9agWfrGTMUriYy6IkG RT+hSQyQcVFelz1xITF/yrS2Ac195i9mVl/vfCQGxrJjjpynNeW/NLAQBYsIJyx9LVbRVaorFd4yt lsm24ZjIXdfojSWVqLysMtN4Zfx5gJl7fiS82/RTgOKaZ4lIATH0d43r9QCr8hcD4kv59ZagxyKNR 6E3qyiwaQmlBJGnsS/URyOmKd+eweAHrbKnI7TjrDlgjgN4Ol9gnsQZtnxP//rl9ERcMyUKrFm2DV TBg2alTlLzMcEksckJKhVA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptu6b-0001a7-Gm; Tue, 02 May 2023 13:48:01 -0400 Date: Tue, 02 May 2023 20:48:47 +0300 Message-Id: <83o7n2mxog.fsf@gnu.org> From: Eli Zaretskii To: Yuri D'Elia In-Reply-To: <87h6suyb2f.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Tue, 02 May 2023 17:57:50 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <87o7n81grh.fsf@wavexx.thregr.org> <83zg6sqp0l.fsf@gnu.org> <87jzxw1eba.fsf@wavexx.thregr.org> <83v8hgqo7c.fsf@gnu.org> <87fs8j28aw.fsf@wavexx.thregr.org> <83v8hfoti9.fsf@gnu.org> <83o7n6pvm2.fsf@gnu.org> <874jov13e5.fsf@wavexx.thregr.org> <834jovncy7.fsf@gnu.org> <87h6suyb2f.fsf@wavexx.thregr.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142-done Cc: ruijie@netyu.xyz, 63142-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuri D'Elia > Cc: ruijie@netyu.xyz, 63142@debbugs.gnu.org > Date: Tue, 02 May 2023 17:57:50 +0200 > > On Tue, May 02 2023, Eli Zaretskii wrote: > > What about the patch I proposed: does it give good results? > > Working as intended. Thanks, so I've now installed it on the master branch, and I'm closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 07:05:05 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 11:05:06 +0000 Received: from localhost ([127.0.0.1]:53249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putFJ-0002LE-KT for submit@debbugs.gnu.org; Fri, 05 May 2023 07:05:05 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:49407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putFH-0002Kd-SD for 63142@debbugs.gnu.org; Fri, 05 May 2023 07:05:04 -0400 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ac8091351eso17650311fa.2 for <63142@debbugs.gnu.org>; Fri, 05 May 2023 04:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683284698; x=1685876698; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=BH/Xe73Yy9YKq8iA4jNffnh2HnHrDmbzxj5JZ4DN2N0=; b=b1rD+ZepN1dli2vQQAT7sWxwfFCVVakkz1SfMdyR+2HT3fnLS30R5qTOo2eyAtC1oL WWufF/e2fEgQ1xSRxkXUsWlGCAUTHnu5UMnihyBufQVcPXjM+8BQk7XeEL1z5KwTUc2B mkbErjpCyVQ7lhJfXHcJSi9CDf5w8NK733fJ+32iyld/zhb7YoP2QdXMWsAiGHQDS5Hp 88CAUT6ELtw/nEu6efplp7xiqeG2ExBOYd2vnJ49T5dUG82WIl1aJ2wNuTujJdME3A9/ 6QdaFjPk1e9y7A0ZkLjm2jgQF7fU4KRSdPsIe7ZID6xpbfzIQtGpvB8FyCydtHp4fQr0 kpmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683284698; x=1685876698; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BH/Xe73Yy9YKq8iA4jNffnh2HnHrDmbzxj5JZ4DN2N0=; b=UjuC6jVySAxzg6Yat6NxzbYL1BRuUD7JtoznUGu+PAib7LIdoS+9HfbbPBP8S2Im53 uJXy5/KKWUr1vpUae3Qnk3evRLRnu9ascmQojb093dRiZO+atr0ZAqAatkLpsbNwH6ui 8P+ae7LsD4WHudVuQdEBsScYWm/3dCD5+ge0GcxU4KJpP6JMjWLXvcYjPmRWCD7ycKji de7ht9VUPjrgIx+l04N4bkOzKvohiAzZ9hubDBNFtywB6kHHU2OcaXblVklubgVetViF 3juhtuyDXwyHy487MDc6abNmMjkqc4EmOSBcMV6A7DLgzZIyPu50ES/QPU6jhaQi1035 Bumw== X-Gm-Message-State: AC+VfDxgsstB4I/+LDH6XqQw9p2hoqsOe+1cTikEnUJnnHBu07BcnhBw 1wvKR5JDjP2qmadnbODqFDY= X-Google-Smtp-Source: ACHHUZ63c/1DglfsIIthW0aF9F6vJ84N+7fCqHRC3mJDjtloBWEJdhkNJPxom7uEPlIlJbSm4EZCDA== X-Received: by 2002:a2e:908c:0:b0:2ab:2184:a9cf with SMTP id l12-20020a2e908c000000b002ab2184a9cfmr362888ljg.53.1683284697750; Fri, 05 May 2023 04:04:57 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id l19-20020a2e7013000000b002ab309da60fsm267851ljc.103.2023.05.05.04.04.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2023 04:04:57 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_B506513F-4DB8-4008-817D-DC2172AD9B2B" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#63142: 30.0.50; QUOTING_STYLE can break dired Message-Id: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> Date: Fri, 5 May 2023 13:04:56 +0200 To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: Yuri D'Elia , ruijie@netyu.xyz, 63142@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_B506513F-4DB8-4008-817D-DC2172AD9B2B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This change breaks tramp-tests on MacOS (and, I presume, BSDs) where = `ls` accepts neither `--dired` nor `-N`. see appended test log. In fact even ls-lisp doesn't seem to accept `-N`, or at least do = anything with it. Not sure if that is a problem or not. Should we reopen this bug or open a new one? --Apple-Mail=_B506513F-4DB8-4008-817D-DC2172AD9B2B Content-Disposition: attachment; filename=tramp-tests.log Content-Type: application/octet-stream; x-unix-mode=0644; name="tramp-tests.log" Content-Transfer-Encoding: 7bit Running 57 tests (2023-05-04 17:59:47+0200, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))') Remote directory: `/mock::/var/folders/qy/zstv16390nlcs47kz8nff_mm0000gn/T/' passed 1/57 tramp-test00-availability (0.196691 sec) passed 2/57 tramp-test01-file-name-syntax (0.024810 sec) passed 3/57 tramp-test02-file-name-dissect (0.012798 sec) passed 4/57 tramp-test03-file-name-defaults (0.013957 sec) passed 5/57 tramp-test03-file-name-host-rules (0.135664 sec) passed 6/57 tramp-test03-file-name-method-rules (0.267525 sec) passed 7/57 tramp-test04-substitute-in-file-name (0.016100 sec) passed 8/57 tramp-test05-expand-file-name (0.000603 sec) passed 9/57 tramp-test05-expand-file-name-relative (0.250355 sec) passed 10/57 tramp-test05-expand-file-name-top (0.246213 sec) passed 11/57 tramp-test06-directory-file-name (0.211605 sec) passed 12/57 tramp-test07-abbreviate-file-name (0.863962 sec) passed 13/57 tramp-test07-file-exists-p (0.623836 sec) passed 14/57 tramp-test08-file-local-copy (0.796964 sec) passed 15/57 tramp-test09-insert-file-contents (1.054375 sec) Wrote /mock:stanniol.local:/var/folders/qy/zstv16390nlcs47kz8nff_mm0000gn/T/tramp-testTgbUDR Wrote /mock:stanniol.local:/var/folders/qy/zstv16390nlcs47kz8nff_mm0000gn/T/tramp-testTgbUDR Wrote /mock:stanniol.local:/var/folders/qy/zstv16390nlcs47kz8nff_mm0000gn/T/tramp-testTgbUDR passed 16/57 tramp-test10-write-region (1.979867 sec) passed 17/57 tramp-test10-write-region-file-precious-flag (1.285421 sec) skipped 18/57 tramp-test10-write-region-other-file-name-handler (0.023221 sec) passed 19/57 tramp-test11-copy-file (3.803086 sec) passed 20/57 tramp-test12-rename-file (4.470811 sec) passed 21/57 tramp-test13-make-directory (0.435704 sec) passed 22/57 tramp-test14-delete-directory (0.686477 sec) passed 23/57 tramp-test15-copy-directory (2.086941 sec) passed 24/57 tramp-test16-directory-files (1.464579 sec) passed 25/57 tramp-test16-file-expand-wildcards (0.728717 sec) Test tramp-test17-dired-with-wildcards backtrace: re-search-forward("tramp-testxyIR7k") apply(re-search-forward "tramp-testxyIR7k") #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name tramp-test17-dired-with-wildcards :do ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":../../emacs/test" "-l" "ert" "-l" "lisp/net/t command-line() normal-top-level() Test tramp-test17-dired-with-wildcards condition: (search-failed "tramp-testxyIR7k") FAILED 26/57 tramp-test17-dired-with-wildcards (0.618446 sec) at ../../emacs/test/lisp/net/tramp-tests.el:3316 passed 27/57 tramp-test17-insert-directory (0.626790 sec) Test tramp-test17-insert-directory-one-file backtrace: signal(ert-test-failed (((should-not (eobp)) :form (eobp) :value t)) ert-fail(((should-not (eobp)) :form (eobp) :value t)) #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name tramp-test17-insert-directory-one-fil ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":../../emacs/test" "-l" "ert" "-l" "lisp/net/t command-line() normal-top-level() Test tramp-test17-insert-directory-one-file condition: (ert-test-failed ((should-not (eobp)) :form (eobp) :value t)) FAILED 28/57 tramp-test17-insert-directory-one-file (0.518754 sec) at ../../emacs/test/lisp/net/tramp-tests.el:3431 passed 29/57 tramp-test18-file-attributes (1.514951 sec) passed 30/57 tramp-test19-directory-files-and-attributes (0.780391 sec) passed 31/57 tramp-test20-file-modes (0.496595 sec) passed 32/57 tramp-test21-file-links (1.986896 sec) passed 33/57 tramp-test22-file-times (0.677137 sec) passed 34/57 tramp-test23-visited-file-modtime (0.486873 sec) skipped 35/57 tramp-test24-file-acl (0.170199 sec) skipped 36/57 tramp-test25-file-selinux (0.211741 sec) passed 37/57 tramp-test26-file-name-completion (1.384207 sec) passed 38/57 tramp-test26-interactive-file-name-completion (2.009675 sec) passed 39/57 tramp-test27-load (0.838852 sec) passed 40/57 tramp-test33-environment-variables-and-port-numbers (0.771784 sec) passed 41/57 tramp-test35-exec-path (1.303049 sec) passed 42/57 tramp-test35-remote-path (3.657313 sec) passed 43/57 tramp-test37-make-auto-save-file-name (0.594019 sec) passed 44/57 tramp-test38-find-backup-file-name (0.781815 sec) passed 45/57 tramp-test39-detect-external-change (3.815419 sec) passed 46/57 tramp-test39-make-lock-file-name (4.178823 sec) passed 47/57 tramp-test40-make-nearby-temp-file (1.329095 sec) passed 48/57 tramp-test41-special-characters (2.279381 sec) passed 49/57 tramp-test42-utf8 (6.554795 sec) passed 50/57 tramp-test43-file-system-info (0.164572 sec) passed 51/57 tramp-test44-file-user-group-ids (0.276660 sec) skipped 52/57 tramp-test46-dired-compress-dir (0.099935 sec) skipped 53/57 tramp-test46-dired-compress-file (0.219227 sec) passed 54/57 tramp-test48-auto-load (0.544248 sec) passed 55/57 tramp-test48-delay-load (0.299999 sec) passed 56/57 tramp-test48-recursive-load (0.676982 sec) passed 57/57 tramp-test48-remote-load-path (0.252166 sec) Ran 57 tests, 50 results as expected, 2 unexpected, 5 skipped (2023-05-04 18:00:49+0200, 62.139392 sec) 2 unexpected results: FAILED tramp-test17-dired-with-wildcards FAILED tramp-test17-insert-directory-one-file --Apple-Mail=_B506513F-4DB8-4008-817D-DC2172AD9B2B-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 07:07:11 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 11:07:11 +0000 Received: from localhost ([127.0.0.1]:53253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putHL-0002OV-3R for submit@debbugs.gnu.org; Fri, 05 May 2023 07:07:11 -0400 Received: from erc.thregr.org ([46.43.2.63]:32820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putHK-0002OO-3u for 63142@debbugs.gnu.org; Fri, 05 May 2023 07:07:10 -0400 Received: from [37.160.221.44] (helo=localhost) by erc.thregr.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1putHF-001Szl-2V (envelope-from ); Fri, 05 May 2023 13:07:05 +0200 References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> User-agent: mu4e 1.11.4; emacs 30.0.50 From: Yuri D'Elia To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Fri, 05 May 2023 13:06:21 +0200 In-reply-to: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> Message-ID: <87ild7nijt.fsf@wavexx.thregr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: ruijie@netyu.xyz, Eli Zaretskii , 63142@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, May 05 2023, Mattias Engdeg=C3=A5rd wrote: > This change breaks tramp-tests on MacOS (and, I presume, BSDs) where > `ls` accepts neither `--dired` nor `-N`. see appended test log. Considering -N was added where --dired was already being used, I'm kind of surprised? From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 07:24:36 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 11:24:37 +0000 Received: from localhost ([127.0.0.1]:53276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putYC-0005IM-HL for submit@debbugs.gnu.org; Fri, 05 May 2023 07:24:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1putY8-0005I7-PY for 63142@debbugs.gnu.org; Fri, 05 May 2023 07:24:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1putY1-00059b-Ua; Fri, 05 May 2023 07:24:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=sHS0D4US0BJwL77QiLI8IOIARQa8RhypJhUEPgnMM4Y=; b=cGCcZfe14FB6/mYeig1G rhxZGqrzz5qxL46NSIQdB1+KmE4Nc/Mg1Zn8eDCYnNwu5te0i/7rXW4ElJE5bSkwB3x6sf9g1NwYs s0F+yxty1e2RM8Irdw941pheCZQ2IyLqfih4OgcVi5Mpfu4MXRKPPlTilNShCjUKKwCRWaN+C9OKf xXF40qKcDWljP0S8ZqjjyXWxRC3fLbNOdoWgMF1dVqVq2S7d+p9AioYqSE6JwOSDRxVsbikJagBK1 rR2uIpAGykKAGlto5IROeTcF+bh8EacfJs4HeUt9H6IJldvXNR8sieM62+BS7nZM4L+Pm7fLR6Yb9 W7S743P8ei6m8w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1putY1-0002Rj-9i; Fri, 05 May 2023 07:24:25 -0400 Date: Fri, 05 May 2023 14:25:18 +0300 Message-Id: <83lei3hvfl.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Fri, 5 May 2023 13:04:56 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, ruijie@netyu.xyz, 63142@debbugs.gnu.org, michael.albinus@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Fri, 5 May 2023 13:04:56 +0200 > Cc: Michael Albinus , > Yuri D'Elia , > ruijie@netyu.xyz, > 63142@debbugs.gnu.org > > This change breaks tramp-tests on MacOS (and, I presume, BSDs) where `ls` accepts neither `--dired` nor `-N`. see appended test log. Sorry, I don't understand. The change added -N only where we previously had --dired in the 'ls' switches. Are you saying that we somehow now pass "--dired -N" where previously we didn't pass "--dired"? AFAIU, we should use --dired only when 'ls' supports it, and we now use -N under the same conditions. Is that not what happens? > In fact even ls-lisp doesn't seem to accept `-N`, or at least do anything with it. Not sure if that is a problem or not. This should not be used when ls-lisp is in use, see the line emphasized below: (if (and ;; Don't try to invoke `ls' if we are on DOS/Windows where ;; ls-lisp emulation is used, except if they want to use `ls' ;; as indicated by `ls-lisp-use-insert-directory-program'. (not (and (featurep 'ls-lisp) <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< (null ls-lisp-use-insert-directory-program))) ;; FIXME: Big ugly hack for Eshell's eshell-ls-use-in-dired. (not (bound-and-true-p eshell-ls-use-in-dired)) (or (file-remote-p dir) (if (eq dired-use-ls-dired 'unspecified) ;; Check whether "ls --dired" gives exit code 0, and ;; save the answer in `dired-use-ls-dired'. (or (setq dired-use-ls-dired (eq 0 (call-process insert-directory-program nil nil nil "--dired"))) (progn (message "ls does not support --dired; \ see `dired-use-ls-dired' for more details.") nil)) dired-use-ls-dired))) ;; Use -N with --dired, to countermand possible non-default ;; quoting style, in particular via the environment variable ;; QUOTING_STYLE. (setq switches (concat "--dired -N " switches))) So once again, I don't understand what you are saying. In any case, I've just tried "C-x d" on MS-Windows, where ls-lisp is used by default, and saw no problems. What am I missing? > Should we reopen this bug or open a new one? I'd like Michael to chime in first. From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 08:03:26 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 12:03:26 +0000 Received: from localhost ([127.0.0.1]:53339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puu9l-0002yW-OB for submit@debbugs.gnu.org; Fri, 05 May 2023 08:03:26 -0400 Received: from mout.gmx.net ([212.227.17.20]:36565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puu9h-0002yF-8J for 63142@debbugs.gnu.org; Fri, 05 May 2023 08:03:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1683288194; i=michael.albinus@gmx.de; bh=diW45rYjUSlK0W/Wa/BkrsvmDZxjbXwrMP2F4fHznTc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=e8o90XZ0SOkknULbQCaC3GzjMJ6herQ0w3TsK/mhcMMKhTtqQb/mpMrYciaozsk9m 3j+aTn23D4yOZbUVxVf36GFBLqhV/Qt40MNX5B39tw7yuN5/MWBeWhtAoFJwPxvxPD 3xKQHxQf0WrUKymMzVf7ntYLNF/5x1vxAh61Nr594YCtt34g8+KfjvKO0MSPbXHUfC OtpjogciAvbO65VPXrkcrHKqXoyli/UwE9GPIeg6HOXterhXaVmoW/Z7FpbRr+Fg5W EIOIRxVPs1RPp9OEv/eZN6KiH/ERpmP7vZZ0ZZzfTaj1Dm5qjDF7ugJCpJO4qv3Isw O0qb810YE0YWg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MzQkK-1q7sdW1jLE-00vT0W; Fri, 05 May 2023 14:03:14 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired In-Reply-To: <83lei3hvfl.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 May 2023 14:25:18 +0300") References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> <83lei3hvfl.fsf@gnu.org> Date: Fri, 05 May 2023 14:03:13 +0200 Message-ID: <878re3ouim.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:slkZLfppYoPMQnSD86V/ICcZgx66dEe63YqTewuQC7IoNPBD3IL AF5vaWhLw0oDW/kitKQfzsIIwhoARouHn0LJ9AezMGbMpzXeUuaT/yNv25YrCHliPDsoaNv PxcsrGmtmNdhVNwIzmbPBPorux+cYDNbiTDNzyPRyjRaUbrDMtBbVHclMr7U0DN3hKLHHYx 5HSUZ03osc4AIYaKFZZJw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QqeJBxqBgl8=;ENVB5KKK2DxUH71cG7qOxuNm2Rn pT+wfgjTclQALrmzaNVl8fMB31Pcs1CFD6TbSd2HmZTLmtK2CiVGZV3M25HKfFZ7rQmFKt/WL F4bvSSHyfpvI0owpAqJFwsrcYMpcD6IqfXqHQjTkb5BtNHW1ZiJD2ZUvzcVHo0O5hUza/gLzi 3sp2CvQUzlbDgcH63dPmR0Qo0wxOfrphFOfDO1b8KyztPYZsxguelbVYugOJx2iimcXLsUAOC wWgPXBTxIgP1qfaQNE1wh6bS2uqQvN0o7686lWEX0N2RCICJ7nBBYQGhDCDJUoKMakSoE15nW Ha11w9yY3pcUBAOUtuvBOyT+yZ4CsuRPwz7LHwjqr3Ii4aFQctcM4TAHmLfrEh09nrwilFG9k Vv1+02WR8/4BIWRdBIxpmoas5ZJQyP8+zDnJAIM6Z3W3Orw1FoXbOjMFPrjv8xI9oL6xFj0sj LNvbmxfLJ9WfK5R1ValtYzbKs3nAo3OtgPOnNdFOuiV71PNvdXP+uK4MbL74TtY3IbtfMfBIO YTEaLdqfO5ckSqnqzglu/GnUuQxEP93T8SlQ5MR8MoZy5WfXJQjDLNe7dykpO4XiQeZO/hBnp 06/GQdfrcsNMTSpYZ2cT9PH8r1i+hwpfM20VOESgc4JcfVr/Zlzemc55rln8kIj20ef3EV27z N83YPfA4ZDB50LLg8x1XM2HsUtZFZUkh8tnm9QUZl5RTGlC5f7Uu0z5JTdyylt1WWW255u728 LA5L0vecBW8HsGlo9ueRlfYF8IapwfviQ2/TC2MwXMT2q99Bbk45cLmFwMyRcVWnsKFLErN8m xaSM9CDnvFu5f8YEtkDRmG0eRFgU5kX4sQKaHfaVLvubrjLQ7s6+MEgOd/Z6nBo4yUhbcJzh2 Q8XiAsMHfE0DNCQ3IBi62c+bAf0QKQl3qSqOGbMrCGWcMdS5bp5P6qXeh+53u4cUKmb1kJhR1 w8c9jw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, ruijie@netyu.xyz, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi, >> This change breaks tramp-tests on MacOS (and, I presume, BSDs) where `ls` accepts neither `--dired` nor `-N`. see appended test log. > > AFAIU, we should use --dired only when 'ls' supports it, and we now > use -N under the same conditions. Is that not what happens? This still happens. >> Should we reopen this bug or open a new one? > > I'd like Michael to chime in first. Well, we're speaking about tramp-sh-handle-insert-directory. This does the following: - Check, whether the remote ls command supports "--quoting-style=literal --show-control-chars" or "-w" (for *BSD). If yes, add this to SWITCHES. - Check, whether the remote ls command supports "--dired". If not, remove "--dired" from SWITCHES. It doesn't know anything about "-N". So I propose to remove "-N" from switches unconditionally in Tramp. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 08:12:08 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 12:12:08 +0000 Received: from localhost ([127.0.0.1]:53358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puuIC-0003Bi-CK for submit@debbugs.gnu.org; Fri, 05 May 2023 08:12:08 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:53613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puuI8-0003BB-A3 for 63142@debbugs.gnu.org; Fri, 05 May 2023 08:12:06 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4eff055d4d3so1885104e87.3 for <63142@debbugs.gnu.org>; Fri, 05 May 2023 05:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683288718; x=1685880718; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=SQWkzP2ipSUpiHPGEheq5Bipelyj72qRsdZ9EPZco4k=; b=IeEQ0kYxuCDJ6Y9lHXvXCmN2qs+XqaENhbpqco8IEvmpBE1Z49jfngQUFPqYmlAlGf s1gjeeLJ541ftzX78qp1RC7s4rfxP2BrwKl1R+clwjQRoDSG1w0aIrMC2LGEmr3JdPv5 VduqGYKaPcbpd84uoNsrnBnVqN+l0BSOLMWioPsJUbHArtWQCq1Ven+XUJfjcezWmpjM STQXQauGmgx8XP/OebyYB5q8yWR+anX60tXT5Dv0F8jIIXh33OFvloMM4D6cvTdCbEiu aFJqxYHkZ1ZEx5Q28qSO4f3A8twZdb5DpNCwXoQklZ/lSsQ+PAmUqaf5VzopbtvDNxIC HoxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683288718; x=1685880718; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SQWkzP2ipSUpiHPGEheq5Bipelyj72qRsdZ9EPZco4k=; b=aHRqoflqpOvrfsprxU0FK9lxhp0VG6xbhgRwf+jrFnBSs2NlkDOPdAihDT0q3f1hVx 3Uu0dX9mMOjRHvQTNftda8RA8BFM9MiT3YAsOzFU2WqA/keZTqspAU8dJ73B3UecjDbU 9it0zpJPFCAzydskLOhHlCCxRYZ7qthGUIsw3pEeOXkcd7BY+u93csulHOMV/JoQQlBv 0fUn9hEQ9gkFwzTQ7PdFOPIffeXxnwVTX9DxLKiLS6qCa88G7UTOYoxGy4qTiDHYgO/Y 5TFPk3ZVa3LGIwXdZZ4lyU6azRIQPgp0KYN4nm/bbGGav8ldDrrNVpSuRGCqAQJqBe3l giGQ== X-Gm-Message-State: AC+VfDxYLMgzPcdwK9MyBioJoQSi4OXwn9uorcZjE4MHtpsvLuYY1rRt ioC4DjIQmh4NRL6zHWb9zOY= X-Google-Smtp-Source: ACHHUZ45jL0rz48xMzpATQkEHBApfK1FeLaHewupa2/C4RO+fKNiD/0qElTT8I7X48Ea98Tjhlb0zQ== X-Received: by 2002:ac2:4c90:0:b0:4f1:37db:667 with SMTP id d16-20020ac24c90000000b004f137db0667mr464826lfl.52.1683288717999; Fri, 05 May 2023 05:11:57 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id r28-20020ac252bc000000b004eb00c0d417sm261857lfm.130.2023.05.05.05.11.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2023 05:11:57 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <2E4CD047-BE55-4B62-A00E-84473AA09B71@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_E44E9CFE-B219-4D15-8266-0ED33B4C03EF" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired Date: Fri, 5 May 2023 14:11:56 +0200 In-Reply-To: <878re3ouim.fsf@gmx.de> To: Michael Albinus References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> <83lei3hvfl.fsf@gnu.org> <878re3ouim.fsf@gmx.de> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, ruijie@netyu.xyz, Eli Zaretskii , 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_E44E9CFE-B219-4D15-8266-0ED33B4C03EF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 5 maj 2023 kl. 14.03 skrev Michael Albinus : > It doesn't know anything about "-N". So I propose to remove "-N" from > switches unconditionally in Tramp. Yes, I found that out the hard way and can confirm that the patch below = makes tramp-tests pass again. Whether it's the right course of action, or requires more work = elsewhere, I leave to you and Eli. --Apple-Mail=_E44E9CFE-B219-4D15-8266-0ED33B4C03EF Content-Disposition: attachment; filename=bsd-ls-N.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="bsd-ls-N.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/dired.el b/lisp/dired.el index 1c8d011d765..e70467ca53b 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1647,9 +1647,9 @@ dired-insert-directory ;; save the answer in `dired-use-ls-dired'. (or (setq dired-use-ls-dired (eq 0 (call-process insert-directory-program - nil nil nil "--dired"))) + nil nil nil "--dired" "-N"))) (progn - (message "ls does not support --dired; \ + (message "ls does not support --dired -N; \ see `dired-use-ls-dired' for more details.") nil)) dired-use-ls-dired))) @@ -1665,7 +1665,7 @@ dired-insert-directory ;; "--dired", so we cannot add it to the `process-file' ;; call for wildcards. (when (file-remote-p dir) - (setq switches (string-replace "--dired" "" switches))) + (setq switches (string-replace "--dired -N" "" switches))) (let* ((default-directory (car dir-wildcard)) (script (format "ls %s %s" switches (cdr dir-wildcard))) (remotep (file-remote-p dir)) diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el index 94fbc588b5d..d020615af07 100644 --- a/lisp/net/tramp-sh.el +++ b/lisp/net/tramp-sh.el @@ -2566,7 +2566,7 @@ tramp-sh-handle-insert-directory (setq switches (append switches (split-string (tramp-sh--quoting-style-options v)))) (unless (tramp-get-ls-command-with v "--dired") - (setq switches (delete "--dired" switches))) + (setq switches (delete "-N" (delete "--dired" switches)))) (when wildcard (setq wildcard (tramp-run-real-handler #'file-name-nondirectory (list localname))) --Apple-Mail=_E44E9CFE-B219-4D15-8266-0ED33B4C03EF-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 09:27:42 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 13:27:42 +0000 Received: from localhost ([127.0.0.1]:53410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puvTH-0005Ob-8R for submit@debbugs.gnu.org; Fri, 05 May 2023 09:27:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puvT1-0005O0-7q for 63142@debbugs.gnu.org; Fri, 05 May 2023 09:27:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvSs-0000x4-NY; Fri, 05 May 2023 09:27:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=pb6r7ZgK6IgZYo1uNj7g1Z1sxavlmk68B13zxYzoTaY=; b=Ew8AIUbzkVmVCCGjmAAu 9e/A30I+sDlQ1UvcEFHl1/vIBWopFTVSVH6jRuW+s7TcpZpkJLUh/bZ7fSTQyJfZaigAf4HQAWlBH cME3O9jDwgSX2eLRFtVTHayfqv/boYTyB8Odv3uJ8dkFjAD9xdEqWPLx0jMLKDxgZDnj+AY8sDDRO xJ6lIpYqzUs6BZgSNOeqHOjSw118YmZzV3R1EEDJfpSSjOKQbvpT03uypNEZ3VKjPfqdHBKhp93x8 5yeowKp7+D8hJc2wR29NuX+TXtXAWDMDiE6WeHYP+6OIvdbH9B+bCzj6IO43y7nQAMw7+LIxPcl98 Ur+ffRuI/bgffA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puvSs-0000lr-5P; Fri, 05 May 2023 09:27:14 -0400 Date: Fri, 05 May 2023 16:28:07 +0300 Message-Id: <83fs8aj4bc.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <878re3ouim.fsf@gmx.de> (message from Michael Albinus on Fri, 05 May 2023 14:03:13 +0200) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> <83lei3hvfl.fsf@gnu.org> <878re3ouim.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, ruijie@netyu.xyz, mattias.engdegard@gmail.com, 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Mattias Engdegård , > wavexx@thregr.org, > ruijie@netyu.xyz, 63142@debbugs.gnu.org > Date: Fri, 05 May 2023 14:03:13 +0200 > > Eli Zaretskii writes: > > >> Should we reopen this bug or open a new one? > > > > I'd like Michael to chime in first. > > Well, we're speaking about tramp-sh-handle-insert-directory. This does > the following: > > - Check, whether the remote ls command supports "--quoting-style=literal > --show-control-chars" or "-w" (for *BSD). If yes, add this to SWITCHES. > > - Check, whether the remote ls command supports "--dired". If not, remove > "--dired" from SWITCHES. > > It doesn't know anything about "-N". So I propose to remove "-N" from > switches unconditionally in Tramp. SGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 10:44:18 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 14:44:18 +0000 Received: from localhost ([127.0.0.1]:57230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puwfS-0002ht-0j for submit@debbugs.gnu.org; Fri, 05 May 2023 10:44:18 -0400 Received: from mout.gmx.net ([212.227.17.20]:43151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puwfM-0002hb-Uk for 63142@debbugs.gnu.org; Fri, 05 May 2023 10:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1683297846; i=michael.albinus@gmx.de; bh=NAcMOAvp/Ks9fRr38ci/aUm+9d6r3akk6WkwwVN/APk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=omEjoqViRCPXQnLXtGuBwsz29y5E/kAi0qR5rCuV/wZBSGe2ADbkqHyHW0XQ6QIFC gnHMIql47XRjYKEFRtJ9gtXOI3EWaKyQW+YrkhIs3/O+Kbpu9aiyeZq4ZmagK7HHSU 9jxpFbemEWUveys81yVlDTaVg1zfJscDVYvAhf+RqSXeJ+y9W0MimrLgbl1RfcmAVP GcxnvaPPpE5WIH4/QoepNCH6SUSIf8WrWnGMW7KutmAtLCqkDaspODGS8ORXQ5EB/7 4I/oOnX6tsp+lf5GFm8w8WXVoyJ7kvRl9OPgkOKVBELRjSFVaZ5g32zJFFf4T3gjku KciO4zCOLj3ng== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmDEm-1qd7Ac0vRo-00iAdc; Fri, 05 May 2023 16:44:06 +0200 From: Michael Albinus To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired In-Reply-To: <2E4CD047-BE55-4B62-A00E-84473AA09B71@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 5 May 2023 14:11:56 +0200") References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> <83lei3hvfl.fsf@gnu.org> <878re3ouim.fsf@gmx.de> <2E4CD047-BE55-4B62-A00E-84473AA09B71@gmail.com> Date: Fri, 05 May 2023 16:44:05 +0200 Message-ID: <874joqq1my.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:PZf3/wiFQBi8Wv8c2pCH57W+n+m5CeEjv/M3GeNlCo7bcYC7MUw rERce5Lp0nmTBs5O+r6pVoOOPalSw1RZmiugAXW02xc2Vtb5oO17nRdkmCBza3J+Mfnd/9O 29gx7lgXaAUTZuzPNfMjKVdfZvwSTiKsrGjPbLpZbLOlsd1UTuO5GGHcBqmXi07zwoIVRBo 9GGY9RNwFwUzXzGlJjwaw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fo2fH+UP+Iw=;r8a6RmG15WL609Yp6gYLkA7Tz/u KHf4mrBHLFDKZKrp6Q6y6bdUJQ87wc01eYr8S2VfePdXpueJ6vA2aWdZ2yD4jE2lhdbnINCfx DNFMFRtcRfnJVKjdtBqqgQiPMajBMbFbrtfHdSFiKQ32UHBaFYxkLHX1l6vNtN4cQpPsRO0hZ zglSoAJGvImJYCPfRDN6q/NjTEx8kIlDb9WUrC3l3yrVuGUU7gHRDCQHKYH3bKHVz2oKz82ZP J3Y2tAgPsfaqt5BjoCIfMDFanhQcTjnfN+2c43yP2ZxzwjA8FJiQ3intCx9vWqOVVZJodCE23 4c5IJAyssDZHJ5NbuaWfkVzsJ8zTKBF0MIrSs96G2JxtJS3nJlN0RaG9tAcyd+IloN6d5rDJ7 txzgHDXEm5Ks39OoDKPK5YssOdPfZPkXhelKz2uM2mz60yK9GzSuTgWZvRo7jolLzqfY9V142 hT45FOzlWhzzWsgto72NxmCQoT9g6CBBMe7HaO4kY2CjPpMdVXNIFeqXFCD2ogyuufSe+4z3y Dcu/1JJoc8vnWj1hZWQ6gK/Od7UaNPiHxM0Rr3iJxp0hlofMgLPMjrZyVaEuTJDfAvHi3Tcil MIN9PFZoOqg1QjnF2V/ctF2lLFAySz9WrQsdZOFk8V0RTIq6oqeNGiQchifD6hAuOwIFOaHnH sqF2nYFrnYUIGSuSYUuGBS51Md/YL4Rh/vTnQZYPQ6C+wAaxHqiOPjy683T4RuoWGG1cB5G1G +Sv0OQUmf6tIJ9kMAw+RmUbByJY7FSoSgzOjhAwXUaJuKif1vu2STCneBMnL9T60ZhZJ9RqPf wbb6L7gJfL3LtRTWYnFREvDRB7mZ1BlpPCK1O+rhX+6Z0YRxwu82rZsJeVzSvP2G84gilRf8d dZBPk5A6jITn5w6/g88BmMSJeUKeyaNwUO4HFYSyddoT3LZuHZn3MJGxwlFo46kHpd23McrdT g4QaBg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, ruijie@netyu.xyz, Eli Zaretskii , 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Yes, I found that out the hard way and can confirm that the patch below m= akes tramp-tests pass again. > Whether it's the right course of action, or requires more work elsewhere,= I leave to you and Eli. Thanks. LGTM, so you might push it. It doesn't handle the case that somebody uses switches like "-alN". But this would be intentional by the user, and we don't need to care about. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri May 05 13:27:05 2023 Received: (at 63142) by debbugs.gnu.org; 5 May 2023 17:27:05 +0000 Received: from localhost ([127.0.0.1]:57366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puzCy-0007JI-Qs for submit@debbugs.gnu.org; Fri, 05 May 2023 13:27:05 -0400 Received: from mail-lj1-f180.google.com ([209.85.208.180]:48480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puzCs-0007Ie-OO for 63142@debbugs.gnu.org; Fri, 05 May 2023 13:27:03 -0400 Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ac82b07eb3so17794831fa.1 for <63142@debbugs.gnu.org>; Fri, 05 May 2023 10:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683307613; x=1685899613; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=TuxxnSRRokoDnagJS54mAyq6qxPea2uJMBxiha3RIRs=; b=fGGYrVrBPg8orwCDT3NfDZUXUmiA6YDF08p1+8Yvk4hlnJEddPcA+1OXJJjkBpvqcP r7iwWoeibF17Q3asT2/+Ko9dgFsDIBKjv4pQfOGEprjbmIJAFSfBPJ7E74najDHBPNdC j5a5W6NRy3B5edm6qvE7UQmHwTNJhGRPAWCNUM/KAecDxYY5C5KLiit1pcBTyedmYt8F 8N3hxfZAfkxsJAeilY222XZG/IgxDckP5InERAZ/hBcBWpKyWjaMLOhmd0Vj1TK9ury0 emOz5TaBPapUzN+uxstK5n3d9zULJy/fl6W5zz5uhuNQVuaKMitHkOUybsXJfOgPrMDU SmHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683307613; x=1685899613; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TuxxnSRRokoDnagJS54mAyq6qxPea2uJMBxiha3RIRs=; b=f38E+d147fZQUGsfvtsZYcNP3sBCWp6TUmGxO2ULeEmrsrjKldunrrVzpDF1xL+w/Q ho4zMivGqOD1gUcAR1GMakA0e+IjbHZYYMcnSZRMIrSOG5v/txIJe5dUhq65jxsF4x5a MSAd+8VOJ4raTwb3g7KsoiG7B/w3AJntdyskRuGlCSQNexBMKG9wbmR8Fk3QYkDHwNhf 2mnqr4FEGrhkwGTSYppxbuNGodkWhetRzV3mL+jpBTZi7jUE85J38fRS6dEVSzp5v8h3 GSrmNVwowlWHG+sc/tPSycE68KCf7bmzyf31gZIz8dVMpShXkUk+cnCs/Mie4GaS2RZx bA7w== X-Gm-Message-State: AC+VfDy+tK5n5jlioeAUgBFg3lZ1Vu6NpwltiBdw5kHr45dDDHBY18DG m1uiNw2Pv3IXKtg7tLIAOxw= X-Google-Smtp-Source: ACHHUZ66FYGdfHfTsRLOus2U+UIRVXPAmD/lnJtQF5HRSaBAHmQwbFiyb2DyHelgSKdt1DxCl0dY0w== X-Received: by 2002:a2e:82c6:0:b0:2a7:9690:ca01 with SMTP id n6-20020a2e82c6000000b002a79690ca01mr712305ljh.18.1683307612571; Fri, 05 May 2023 10:26:52 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id t9-20020a2e9d09000000b002ac78893a9csm47084lji.72.2023.05.05.10.26.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2023 10:26:52 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63142: 30.0.50; QUOTING_STYLE can break dired From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <874joqq1my.fsf@gmx.de> Date: Fri, 5 May 2023 19:26:51 +0200 Content-Transfer-Encoding: 7bit Message-Id: <43BA37F6-94F2-412E-BCBB-F7174DA6BC32@gmail.com> References: <77165503-2688-47E9-8C41-0FF728B5FD67@gmail.com> <83lei3hvfl.fsf@gnu.org> <878re3ouim.fsf@gmx.de> <2E4CD047-BE55-4B62-A00E-84473AA09B71@gmail.com> <874joqq1my.fsf@gmx.de> To: Michael Albinus X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63142 Cc: wavexx@thregr.org, ruijie@netyu.xyz, Eli Zaretskii , 63142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 5 maj 2023 kl. 16.44 skrev Michael Albinus : > Thanks. LGTM, so you might push it. Thank you, now on master. From unknown Sat Jun 21 03:30:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Jun 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator