Subject: Re: [bug#63138] [PATCH] gnu: Add chatgpt-shell.

From: Nicolas Goaziou <[email-masked]>
Date: Wed, 03 May 2023 14:50:29 +0200

Hello,

Dakota Logan <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-chatgpt-shell, emacs-shell-maker):
> New variables.

Thank you. Some comments follow.

> +(define-public emacs-shell-maker
> +(package
> +    (name "emacs-shell-maker")
> +    (version "20230427.808")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://melpa.org/packages/shell-maker-"
> +                                  version ".el"))

These URI are not stable. You should use GitHub as upstream. Moreover,
MELPA versionning is fancy. According to source, version is "0.18.1"

> +              (sha256
> +               (base32
> +                "19qamx8rkll2xmkp85dx9qxvlbmcj8d35fksjssa1s05y1akmwad"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/xenodium/chatgpt-shell")
> +    (synopsis "Emacs wraparound for comint-mode for creating local and cloud shells")
> +    (description "@code{emacs-shell-maker} is a library building on Emacs comint-mode.  It allows users to conveniently create shells for local and cloud LLM services, such as ChatGPT.")

Shell Maker is a library... on Emacs Comint mode...

> +    (license license:gpl3+)))
> +
> +(define-public emacs-chatgpt-shell

The repository provides two library, so one single package is necessary.
You'll need to expound the description, tho.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou