From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 13:34:29 2023 Received: (at submit) by debbugs.gnu.org; 27 Apr 2023 17:34:30 +0000 Received: from localhost ([127.0.0.1]:59729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps5Vl-0004oO-Hx for submit@debbugs.gnu.org; Thu, 27 Apr 2023 13:34:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:58616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps5Vj-0004oG-OQ for submit@debbugs.gnu.org; Thu, 27 Apr 2023 13:34:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps5Vh-0005Jp-So for guix-patches@gnu.org; Thu, 27 Apr 2023 13:34:26 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps5VZ-0001hW-RS for guix-patches@gnu.org; Thu, 27 Apr 2023 13:34:24 -0400 Date: Thu, 27 Apr 2023 17:34:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1682616847; x=1682876047; bh=yuYXHS1kutKEHH8sAscAeMWsIh0OH7TrgtdW9knQCWk=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Vd1GoMjcuSOx0Af5dHOf9HKYeLNYFKYM5y7BKdwwpxxoJjRUTkmxFrYDehdFd2WoN d76ZGi00V1rPuvkD4/r+qzqwQ+UsB4pDTFGgQh96xZ4G2BBVFP4OM9kHKnCn+7/4H0 LyG0BGrRMVGbOp36XyAOTm0oRbwqw05aaOluqncZoCs9USurrjo22N0gZQ/5XeqS7E +YSgZ3ZkzLd3WNyM0aTbgxD4bAfRytTVR2o3ZBTZpn02k8N8+uA+dWyVY0kD6sV7Mr KF5HETxfkc8WH73rnUBRh3+8Nq7D5h931jYvtiik9QwREUTYKw6xhX2HkYiFRuCot7 vzpptr2DjQ9kQ== To: guix-patches@gnu.org From: Kaelyn Takata Subject: [PATCH 0/2] Fix building OpenMW after the core-updates merge. Message-ID: Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.131; envelope-from=kaelyn.alexi@protonmail.com; helo=mail-40131.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Kaelyn Takata X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, This pair of patches fixes building OpenMW and its dependency recastnavigat= ion on master after the merge of core-updates. For both packages, the build failures were due to SIGSTKSZ no longer being a constant in glibc 2.34 and newer. recastnavigation is fixed by updating the package to the latest comm= it (as of this writing). OpenMW has also been fixed upstream since the 0.47 release, but building using the openmw-48-rc9 tag results in OpenMW crashin= g for me while loading the main menu. I have tested this patch set in conjunction with the updated openmw-openscenegraph in https://issues.guix.gnu.org/62728 and have successfully loaded a saved game with the I Heart Vanilla modlist (https://modding-openmw.com/lists/i-heart-vanilla/) installed and walked around the starting town a bit, including talking to people. Cheers, Kaelyn Kaelyn Takata (2): gnu: recastnavigation: Update to commit 6d1f971. gnu: openmw: Fix build on glibc 2.34 and newer. gnu/local.mk | 1 + gnu/packages/game-development.scm | 9 +++-- .../openmw-assume-nonconst-SIGSTKSZ.patch | 39 +++++++++++++++++++ 3 files changed, 45 insertions(+), 4 deletions(-) create mode 100644 gnu/packages/patches/openmw-assume-nonconst-SIGSTKSZ.pa= tch base-commit: 297805b1f83aa58ba9fc775c203373338aafd5ac -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 13:39:02 2023 Received: (at 63126) by debbugs.gnu.org; 27 Apr 2023 17:39:02 +0000 Received: from localhost ([127.0.0.1]:59737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps5aA-0004vl-AX for submit@debbugs.gnu.org; Thu, 27 Apr 2023 13:39:02 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:22923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps5a8-0004vQ-D0 for 63126@debbugs.gnu.org; Thu, 27 Apr 2023 13:39:00 -0400 Date: Thu, 27 Apr 2023 17:38:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1682617134; x=1682876334; bh=7EqLYV1IBc+jXJPfuOFvVD1zDBRrSsFuZwZM1GHdK/s=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=j/I4SG9rjrgN3BqkksyIvVfLCav8AszReowJiE8PIQQWNS/yXJrLIzrao+UnmWgk7 7ye3EzbKl96nksnyEiYQ+kK2H/6DljM/FgPE8ji/6LPQzJ3t15qwuw5DhqwFAhVJAX mkq21KB6K4h64MR3rMr72i4LCqjSgK2MSzaesJyiBGmRciYjscTxdaXdweg7dGVfsM CRXC+En3c8AJIjkqnsTCg7uW5SkHCjfPman1KIKpwnvfTFFNtxRj6MmoBiMWTZEYEF KIfpL/7/WOopl+cOv0SkBGGXNlQVw7GFkFoA7N/VGO3xdrJdcgVEsLch4iYVJUSpdH xPUbQQW31v4MQ== To: 63126@debbugs.gnu.org From: Kaelyn Takata Subject: [PATCH 1/2] gnu: recastnavigation: Update to commit 6d1f971. Message-ID: <8ac77bf58b6dfa95626b21010f89a2505e9e5411.1682611459.git.kaelyn.alexi@protonmail.com> In-Reply-To: References: Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63126 Cc: Kaelyn Takata X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/game-development.scm (recastnavigation): Update to commit 6d= 1f971. --- gnu/packages/game-development.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-developm= ent.scm index 844ce935ae..a3a331c290 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2803,8 +2803,8 @@ (define-public tesseract-engine (define-public recastnavigation ;; We follow master since there hasn't been a release since 1.5.1 in 201= 6. - (let ((commit "c5cbd53024c8a9d8d097a4371215e3342d2fdc87") - (revision "1")) + (let ((commit "6d1f9711b3b71f28c2c1c0742d76e0ef8766cf91") + (revision "2")) (package (name "recastnavigation") (version (git-version "1.5.1" revision commit)) @@ -2816,7 +2816,7 @@ (define-public recastnavigation (file-name (git-file-name name version)) (sha256 (base32 - "034bm47gc3r285w1pnvkhmm74zz99d204b1r865gisaiq4qfbza0"))= )) + "0cqp0sbm0ixqnxqz6gf2gybh5l4az91mdsd8b5bgxs1wpl2jmnga"))= )) (build-system cmake-build-system) (arguments `(#:configure-flags (list "-DBUILD_SHARED_LIBS=3DON" -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 27 13:39:09 2023 Received: (at 63126) by debbugs.gnu.org; 27 Apr 2023 17:39:09 +0000 Received: from localhost ([127.0.0.1]:59741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps5aG-0004wE-J4 for submit@debbugs.gnu.org; Thu, 27 Apr 2023 13:39:08 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:30789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps5aD-0004vX-Ve for 63126@debbugs.gnu.org; Thu, 27 Apr 2023 13:39:06 -0400 Date: Thu, 27 Apr 2023 17:38:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1682617140; x=1682876340; bh=A/ZwrgK55mI45VI3kePB9cGkT4gBdUZijE2HZA+nBBE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Z93pbTofKAZCgI37cp6SuQJxM5O73Byh0WlXo05Dc0WJlDCJiN6Oj20XQgTc8cNZn agflWSASYxwMnxDg4ozohwyf0PMaPMcoCN3TsROtJQILhj068tN+abwIT9eafXBG7n RJzy+z67BN1vhq1wxQWuxsmDA0SaxfDymZ08g6caOkVDwf7pB52M/xGhr1OeNyMo7i 2A5DPJPU4bwwXgFKblHfzlTZR9eDqxrLvRFKD6v9bzNkM4GhRk+sPaNJJPEvTh0CDq VjgKSs4BOS2A7JEooSCNmeeN62eiTiGNy3AhLlCOQvk+Nnu4BtwP9F0I/3rW01ZxeM rEEQvXrvY73Pg== To: 63126@debbugs.gnu.org From: Kaelyn Takata Subject: [PATCH 2/2] gnu: openmw: Fix build on glibc 2.34 and newer. Message-ID: In-Reply-To: References: Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63126 Cc: Kaelyn Takata X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/patches/openmw-assume-nonconst-SIGSTKSZ.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it here. * gnu/packages/game-development.scm (openmw)[source]: Use it here. --- gnu/local.mk | 1 + gnu/packages/game-development.scm | 3 +- .../openmw-assume-nonconst-SIGSTKSZ.patch | 39 +++++++++++++++++++ 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/openmw-assume-nonconst-SIGSTKSZ.pa= tch diff --git a/gnu/local.mk b/gnu/local.mk index c0a5c721fc..448c9d8139 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1640,6 +1640,7 @@ dist_patch_DATA =3D=09=09=09=09=09=09\ %D%/packages/patches/openjdk-10-setsignalhandler.patch \ %D%/packages/patches/openjdk-15-xcursor-no-dynamic.patch=09\ %D%/packages/patches/openmpi-mtl-priorities.patch=09=09\ + %D%/packages/patches/openmw-assume-nonconst-SIGSTKSZ.patch \ %D%/packages/patches/openssh-hurd.patch=09=09=09\ %D%/packages/patches/openssh-trust-guix-store-directory.patch=09\ %D%/packages/patches/openresolv-restartcmd-guix.patch=09\ diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-developm= ent.scm index a3a331c290..c22b33e177 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1775,7 +1775,8 @@ (define-public openmw (file-name (git-file-name name version)) (sha256 (base32 - "19mcbnjl4279qalb97msf965bjax48mx1r1qczyvwhn28h6n3bsy")))) + "19mcbnjl4279qalb97msf965bjax48mx1r1qczyvwhn28h6n3bsy")) + (patches (search-patches "openmw-assume-nonconst-SIGSTKSZ.patch")))= ) (build-system cmake-build-system) (arguments `(#:tests? #f ; No test target diff --git a/gnu/packages/patches/openmw-assume-nonconst-SIGSTKSZ.patch b/g= nu/packages/patches/openmw-assume-nonconst-SIGSTKSZ.patch new file mode 100644 index 0000000000..ff0080e28a --- /dev/null +++ b/gnu/packages/patches/openmw-assume-nonconst-SIGSTKSZ.patch @@ -0,0 +1,39 @@ +From 98a7d90ee258ceef9c70b0b2955d0458ec46f048 Mon Sep 17 00:00:00 2001 +From: elsid +Date: Fri, 24 Sep 2021 19:40:29 +0200 +Subject: [PATCH] Assume SIGSTKSZ is not a constant + +SIGSTKSZ is not defined as constant since glibc 2.34: +https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3D6c57d320484988e87= e446e2e60ce42816bf51d53 +--- + components/crashcatcher/crashcatcher.cpp | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +diff --git a/components/crashcatcher/crashcatcher.cpp b/components/crashca= tcher/crashcatcher.cpp +index 86571e1e3a..c828e1ca81 100644 +--- a/components/crashcatcher/crashcatcher.cpp ++++ b/components/crashcatcher/crashcatcher.cpp +@@ -56,8 +56,6 @@ static const char exec_err[] =3D "!!! Failed to exec deb= ug process\n"; + + static char argv0[PATH_MAX]; + +-static char altstack[SIGSTKSZ]; +- + + static struct { + int signum; +@@ -475,9 +473,10 @@ int crashCatcherInstallHandlers(int argc, char **argv= , int num_signals, int *sig + + /* Set an alternate signal stack so SIGSEGVs caused by stack overflow= s + * still run */ ++ static char* altstack =3D new char [SIGSTKSZ]; + altss.ss_sp =3D altstack; + altss.ss_flags =3D 0; +- altss.ss_size =3D sizeof(altstack); ++ altss.ss_size =3D SIGSTKSZ; + sigaltstack(&altss, nullptr); + + memset(&sa, 0, sizeof(sa)); +-- +GitLab + -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Fri May 19 10:31:15 2023 Received: (at 63126-done) by debbugs.gnu.org; 19 May 2023 14:31:16 +0000 Received: from localhost ([127.0.0.1]:57038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q018V-0007tv-LG for submit@debbugs.gnu.org; Fri, 19 May 2023 10:31:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q018T-0007tj-Up for 63126-done@debbugs.gnu.org; Fri, 19 May 2023 10:31:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q018O-0008FY-IV; Fri, 19 May 2023 10:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=QrXG137bW2zOIQGbKbF/PM/dLKyTVI5v2DOime0pCsg=; b=RR9uEyO67o6QztF1YhPq /FBC3D6BB+lw81LVt+Ifp+FcpqZKkXSnlug38DeQQE3fATwg0miMW/U2+OJDp8Ghqb+XBGtq+3Rg6 l7dML2Sg9jpuudmWNRVSX4CiI+kl0/834cof96xre7tAQDGeYgdVlBtqc24WJsxR6PPYCF6SD/EXZ mfoeWAQbpZakewZMoEmZXqhcTYsGs8/uOxGbvvMHGpI9JVoqxn8DWsC3QDUtrGLaN4ydXHVr+g0iB kZOXl301JRdINAk73HLmO038eMYhsRz6z5s6B/Z124pb7f5NghhRTF+Tam9fWFS/19KAkvGk4Xxvd 5PSzORcKAMcxbw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q018O-0000Hl-5A; Fri, 19 May 2023 10:31:08 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Kaelyn Takata Subject: Re: bug#63126: [PATCH 0/2] Fix building OpenMW after the core-updates merge. References: Date: Fri, 19 May 2023 16:31:05 +0200 In-Reply-To: (Kaelyn Takata's message of "Thu, 27 Apr 2023 17:34:01 +0000") Message-ID: <87a5y0z93q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63126-done Cc: 63126-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Kaelyn Takata skribis: > gnu: recastnavigation: Update to commit 6d1f971. > gnu: openmw: Fix build on glibc 2.34 and newer. Applied, thanks! Ludo=E2=80=99. From unknown Sat Aug 16 22:45:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Jun 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator