GNU bug report logs - #63123
[PATCH] Make vc-hg-annotate-command async

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> janestreet.com>

Date: Thu, 27 Apr 2023 16:13:02 UTC

Severity: normal

Tags: patch

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63123: closed ([PATCH] Make vc-hg-annotate-command async)
Date: Thu, 04 May 2023 23:45:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 5 May 2023 02:43:53 +0300
with message-id <0d15138a-9659-4063-264b-3137354a2406 <at> gutov.dev>
and subject line Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
has caused the debbugs.gnu.org bug report #63123,
regarding [PATCH] Make vc-hg-annotate-command async
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63123: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63123
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make vc-hg-annotate-command async
Date: Thu, 27 Apr 2023 12:12:08 -0400
[Message part 3 (text/plain, inline)]
Tags: patch





In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-03-13 built on
 igm-qws-u22796a
Repository revision: e759905d2e0828eac4c8164b09113b40f6899656
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-x-toolkit=lucid --with-modules
 --with-gif=ifavailable'

[0001-Make-vc-hg-annotate-command-async.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63123-done <at> debbugs.gnu.org, sbaugh <at> janestreet.com
Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
Date: Fri, 5 May 2023 02:43:53 +0300
On 04/05/2023 08:39, Eli Zaretskii wrote:
>> Date: Thu, 4 May 2023 02:03:03 +0300
>> From: Dmitry Gutov <dmitry <at> gutov.dev>
>>
>> On 27/04/2023 19:12, Spencer Baugh wrote:
>>> -  (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n"
>>> +  (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n"
>>
>> Looking good, thanks.
>>
>> Eli, is this for master only?
> 
> Yes, it's a new feature.

All right.

>> It might not really be a "fix" (an improvement rather), but it seems
>> obviously correct: vc-git-annotate-command does this already.
> 
> Is it really awfully important to do this ASAP for Mercurial?

No, probably not.

Pushed to master and closing. Thanks all!


This bug report was last modified 2 years and 15 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.