From unknown Tue Jun 17 22:27:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63123: [PATCH] Make vc-hg-annotate-command async Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 63123@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16826119389547 (code B ref -1); Thu, 27 Apr 2023 16:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Apr 2023 16:12:18 +0000 Received: from localhost ([127.0.0.1]:59613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps4EE-0002Tu-2b for submit@debbugs.gnu.org; Thu, 27 Apr 2023 12:12:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:59022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps4E8-0002Tk-Nu for submit@debbugs.gnu.org; Thu, 27 Apr 2023 12:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps4E8-0006Vn-9B for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 12:12:12 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps4E6-0001xf-Ql for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 12:12:12 -0400 From: Spencer Baugh Date: Thu, 27 Apr 2023 12:12:08 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-03-13 built on igm-qws-u22796a Repository revision: e759905d2e0828eac4c8164b09113b40f6899656 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: CentOS Linux 7 (Core) Configured using: 'configure --with-x-toolkit=lucid --with-modules --with-gif=ifavailable' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-vc-hg-annotate-command-async.patch >From 7a9da5d6a08153e36bbf9ee3e29ef2442735d65f Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Thu, 27 Apr 2023 12:11:45 -0400 Subject: [PATCH] Make vc-hg-annotate-command async There's no benefit in this running the process synchrounously, and it's annoying for it to block the Emacs UI. * lisp/vc/vc-hg.el (vc-hg-annotate-command): Run asynchronously. --- lisp/vc/vc-hg.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index f64c342f99c..78231a0c954 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -578,7 +578,7 @@ vc-hg-revision-completion-table (defun vc-hg-annotate-command (file buffer &optional revision) "Execute \"hg annotate\" on FILE, inserting the contents in BUFFER. Optional arg REVISION is a revision to annotate from." - (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n" + (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n" (append (vc-switches 'hg 'annotate) (if revision (list (concat "-r" revision)))))) -- 2.30.2 --=-=-=-- From unknown Tue Jun 17 22:27:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63123: [PATCH] Make vc-hg-annotate-command async Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 07:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Spencer Baugh Cc: 63123@debbugs.gnu.org Received: via spool by 63123-submit@debbugs.gnu.org id=B63123.168292545830328 (code B ref 63123); Mon, 01 May 2023 07:18:01 +0000 Received: (at 63123) by debbugs.gnu.org; 1 May 2023 07:17:38 +0000 Received: from localhost ([127.0.0.1]:38851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptNn0-0007t6-EF for submit@debbugs.gnu.org; Mon, 01 May 2023 03:17:38 -0400 Received: from mout02.posteo.de ([185.67.36.66]:47927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptNmu-0007sq-NO for 63123@debbugs.gnu.org; Mon, 01 May 2023 03:17:36 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BA34B2401A8 for <63123@debbugs.gnu.org>; Mon, 1 May 2023 09:17:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682925446; bh=amw9bighM0Ebh8eRHZGTNyAUatszcvKcduA/e8gy7vQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=WaRMK8y95SMJLyFKX27wLBXIXdqxEJYKF+296Snr2zC3sW9i0Rw/HeuvyeQrK+mUg ZOixP53ibe5W392sdl7dklZJAPNCdbobhxL6Dp1ctz5mzDsUFcK45Se22T9sm1hcEz Z7kLIpj9bEcVZRJxp3X2NYU3p/k9GpA/3ptaYafOjlQI93/ZAEQNx5v1ycRQ9p1BHh lhuMT1NT9QlkZnvId1X8eb8+IXt87NaFYiLprMTzH5Qiv5UxMkB5MG/CfGddobQKxu fCVxKjW3pMBOEJUN1UCNWLSHqXkui94gL692bCqtmOgD0K00CHrH4FWBu1S3L+cFTa 378Ih1y+TF+WA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q8vft1RD0z6txN; Mon, 1 May 2023 09:17:26 +0200 (CEST) From: Philip Kaludercic In-Reply-To: (Spencer Baugh's message of "Thu, 27 Apr 2023 12:12:08 -0400") References: Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 01 May 2023 07:17:58 +0000 Message-ID: <87bkj48qqh.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This should be fine, do you have any larger mercurial repositories that could be used to test the async behaviour? From unknown Tue Jun 17 22:27:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63123: [PATCH] Make vc-hg-annotate-command async Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 May 2023 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 63123@debbugs.gnu.org, Spencer Baugh Received: via spool by 63123-submit@debbugs.gnu.org id=B63123.168303529215090 (code B ref 63123); Tue, 02 May 2023 13:49:02 +0000 Received: (at 63123) by debbugs.gnu.org; 2 May 2023 13:48:12 +0000 Received: from localhost ([127.0.0.1]:42038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptqMV-0003vH-GC for submit@debbugs.gnu.org; Tue, 02 May 2023 09:48:11 -0400 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:27284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptqMT-0003uO-Jt for 63123@debbugs.gnu.org; Tue, 02 May 2023 09:48:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=ZS0udfKNjjjz/omDCnQ9YYUEVXeIQF3MGrVtZFALsD8=; b=ksjd3StWu4uk04IY7fi7rcwD/6qKWADSrVy1socep3E5lFywGf/PglPKCDTE/0IkYS4f +ipE8mc7MSDxL9X/ehYbuVhzMnL0blhtgx7zRJ1/FmHzIqWshyytPcPCldyD+ga+WwrmSF a8Yn5qrHmsNsuwuJd5eHZZkQofIVpohiesWIErLIs3sb1YvIgGsGdIBGfJlWb5Jg0mlk7C Ssvs7rjfq/u1DEWvagZyZBeLN79LqHv7CYhfLNbmZ/+nyGLp+L5eWcxA+OVhPpIrAwdE00 0uVnf/F7atUSytBVJLh19hKaVOOx9GyqhbxP1wUbp9GzML36BS7u48j6ZFC6/fjw== Received: by filterdrecv-59cb65cf6d-lt5nr with SMTP id filterdrecv-59cb65cf6d-lt5nr-1-64511493-64 2023-05-02 13:48:03.888423189 +0000 UTC m=+6012898.673516094 Received: from earth.catern.com (unknown) by geopod-ismtpd-16 (SG) with ESMTP id bCYT3UqqQKqqOMYuJv05vA Tue, 02 May 2023 13:48:03.746 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 292C060084; Tue, 2 May 2023 09:48:03 -0400 (EDT) From: sbaugh@catern.com In-Reply-To: <87bkj48qqh.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 01 May 2023 07:17:58 +0000") References: <87bkj48qqh.fsf@posteo.net> Date: Tue, 02 May 2023 13:48:03 +0000 (UTC) Message-ID: <874joulu98.fsf@catern.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbIap+CaSKeVlm88qmQe+p+rSUcfeqRorzJdqsrD+SIBo3njLkbBMzjKKqRAdG3LjzrBqcxNnOKU0DwocGTb/rtPWDU0eMOjRyXO5NIEX3J9BkZPzEsjD41OQFkbuEgZez4MZylCd/FYgftlllbuVG4w3Ea4TB0OJfho3v/1oRx5OA== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Philip Kaludercic writes: > This should be fine, do you have any larger mercurial repositories that > could be used to test the async behaviour? I don't, but at least running C-x v g on setup.py in https://www.mercurial-scm.org/repo/hg there's a perceptible delay which is no longer present when it's async. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [149.72.123.24 listed in wl.mailspike.net] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Philip Kaludercic writes: > This should be fine, do you have any larger mercurial repositories that > could be used to test the async behaviour? I don't, but at least running C-x v g on setup.py in https://www.mercurial-scm.org/repo/hg there's a perceptible delay which is no longer present when it's async. From unknown Tue Jun 17 22:27:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63123: [PATCH] Make vc-hg-annotate-command async Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 May 2023 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Spencer Baugh , 63123@debbugs.gnu.org, Eli Zaretskii Received: via spool by 63123-submit@debbugs.gnu.org id=B63123.16831549945118 (code B ref 63123); Wed, 03 May 2023 23:04:01 +0000 Received: (at 63123) by debbugs.gnu.org; 3 May 2023 23:03:14 +0000 Received: from localhost ([127.0.0.1]:48063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puLVB-0001KU-RS for submit@debbugs.gnu.org; Wed, 03 May 2023 19:03:14 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:60797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puLVA-0001K5-Ln for 63123@debbugs.gnu.org; Wed, 03 May 2023 19:03:13 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id B662F3200AC4; Wed, 3 May 2023 19:03:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 03 May 2023 19:03:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1683154985; x=1683241385; bh=LXjeJArRYuS/O6+rd5z2YR38Rs2p5KFVkED FL4fZU2U=; b=Q0e7kTklJkWxCgRH2QQkoNBoI4tRKWZd0USDULdD+o5k58PaET9 gFRPkqnVmxWTQ1h4NbxqI95+7UtUTB20q7zl9SlZeR86/1dLiC4oD75W810gGW0f raGrcweWZA4poJqo4TuztWhUNa5FbodQG+cPBC9F7QPygiiALk7te8bZT0v2mW60 rUXnB/Eykxvl3BHM1lWeJmKTDON0iS0y4sKHPb1nKrqqFJVrtOLQdZqYsfHNn4Su MtSkKULSoRoCPUWHIp+DMe4bpr/OC2bb9LAdROWmy2jN11CsRfK2VyBk0MLQDeLZ 2czk+T90Sd/Csb6aYY3OoLwzJokz8Y5zhHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683154985; x= 1683241385; bh=LXjeJArRYuS/O6+rd5z2YR38Rs2p5KFVkEDFL4fZU2U=; b=R L9Yxk3NKgpQRR7mpE0SP5ZEeTKEkSxjDCbupD0+Kz+AJr2HDnOZ471nGID0M9a8E n0rW27ftvAV5xMHe7Gprv0XsMJ7AAkS6qjnPuCQHsuN+3Wgp6TYIlJolqMv94rzO lNVnFeQnSm/FRUvMUnpCl04uwuAd5dP4UuGHTG/BmUFU5e/yEVi2iXMIrmAdWuDd lxbBPj+vohN7YqyoWM5V+phcblqrkby3SnAzfvm2Zf5OdXcJt8M4+XMlwv4dj730 /mGuNXoYaVZHtOsxfH1YUcN1yU9eU7AOB7EXHL2NWZzjwxBEWuy5cm8olZDk5ioT tnwMZL1iF8YC+8dXyrQFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvledgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeghedthedujeeiteeutddtjeekheejteeukeehffdutdejuedvfeevueeviedu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 May 2023 19:03:04 -0400 (EDT) Message-ID: <4ab231d7-3f55-87f1-4d5a-69e476122635@gutov.dev> Date: Thu, 4 May 2023 02:03:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Hi! On 27/04/2023 19:12, Spencer Baugh wrote: > - (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n" > + (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n" Looking good, thanks. Eli, is this for master only? It might not really be a "fix" (an improvement rather), but it seems obviously correct: vc-git-annotate-command does this already. From unknown Tue Jun 17 22:27:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63123: [PATCH] Make vc-hg-annotate-command async Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 05:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: 63123@debbugs.gnu.org, sbaugh@janestreet.com Received: via spool by 63123-submit@debbugs.gnu.org id=B63123.168317871216690 (code B ref 63123); Thu, 04 May 2023 05:39:02 +0000 Received: (at 63123) by debbugs.gnu.org; 4 May 2023 05:38:32 +0000 Received: from localhost ([127.0.0.1]:48235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puRfk-0004L8-6B for submit@debbugs.gnu.org; Thu, 04 May 2023 01:38:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puRfh-0004Kv-Ra for 63123@debbugs.gnu.org; Thu, 04 May 2023 01:38:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRfc-0001N8-AG; Thu, 04 May 2023 01:38:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tqkqZ3Abu++/6KDdVI/GjD9NfX2wLkhm3LUkMbT0nI8=; b=k56ticpLLb7I Xe62dq4LqDBMIrm2fvnvwiQ7mXZOSIacYUTAwXswBjtNJvc/1/4ldRG+ERaaohPC2UBfNlRSil1+1 ZTJl8eNO4s3n6fyW+rohQqxprtnJVkNIOB/qUryjPE82zaINQCERRqa9C5AoBthwyiFuZcgjDAdir qxG+DtO7WS4NPOWq3jPOVpCHO/fOwmm04+blJZErijFg7QVPZD7LO3rR6Kh98cIMcUytcpErYUUl4 r/lKHX/wlcfe035bneHdXB/XNa+5/ns6IRVTs8Q3aSiI2Lnrcp1H8CozcCkrZHnGLkfzEHs3tvY4k vd2yFS6dtWdfwYWUi7tnrA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRfa-0000Xx-2H; Thu, 04 May 2023 01:38:22 -0400 Date: Thu, 04 May 2023 08:39:12 +0300 Message-Id: <83h6sslkov.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <4ab231d7-3f55-87f1-4d5a-69e476122635@gutov.dev> (message from Dmitry Gutov on Thu, 4 May 2023 02:03:03 +0300) References: <4ab231d7-3f55-87f1-4d5a-69e476122635@gutov.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 4 May 2023 02:03:03 +0300 > From: Dmitry Gutov > > On 27/04/2023 19:12, Spencer Baugh wrote: > > - (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n" > > + (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n" > > Looking good, thanks. > > Eli, is this for master only? Yes, it's a new feature. > It might not really be a "fix" (an improvement rather), but it seems > obviously correct: vc-git-annotate-command does this already. Is it really awfully important to do this ASAP for Mercurial? From unknown Tue Jun 17 22:27:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Spencer Baugh Subject: bug#63123: closed (Re: bug#63123: [PATCH] Make vc-hg-annotate-command async) Message-ID: References: <0d15138a-9659-4063-264b-3137354a2406@gutov.dev> X-Gnu-PR-Message: they-closed 63123 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 63123@debbugs.gnu.org Date: Thu, 04 May 2023 23:45:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1683243902-821-1" This is a multi-part message in MIME format... ------------=_1683243902-821-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63123: [PATCH] Make vc-hg-annotate-command async which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63123@debbugs.gnu.org. --=20 63123: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63123 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1683243902-821-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63123-done) by debbugs.gnu.org; 4 May 2023 23:44:06 +0000 Received: from localhost ([127.0.0.1]:52322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puicH-0000Bo-Q4 for submit@debbugs.gnu.org; Thu, 04 May 2023 19:44:06 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puicE-0000B1-Iw for 63123-done@debbugs.gnu.org; Thu, 04 May 2023 19:44:04 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3994D5C00E1; Thu, 4 May 2023 19:43:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 04 May 2023 19:43:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1683243837; x=1683330237; bh=p9uE5WMWdl+z0KXOqZNNRzKwqa5f4vl85SS 5X3jiIXw=; b=dhvoSBswPwjG15Vgv3FOqfz+Lnp6poDw95zF0o3uRRUtsg4DBHg 2gc8hblR88ufvNc0DS1w1uvRADwsZnrYoyWLLJFkCZm8yumrwjwKq4QCA7Rbxo0P 1LTf8r3K0njKLTVgGBJ5SHwoUOd2lpbrDA7GNobpbfI9TevCoUZXr/bRH0TKtqYj NZjLRrGbE+0fE4Z9Esmu/Pf0BX/hdcKvv4ihxqycKy/HyZxSfAKTe44D2jzCrEdw us6Kvx03NTlb7q1TRIxdN/QUcmHENWbntGGGQXlQcm6P6noUjQLihcR0iI7x+YIB uivwIfDeNDAAC3eOueFIbntDJ+6xnqo1cpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683243837; x=1683330237; bh=p9uE5WMWdl+z0KXOqZNNRzKwqa5f4vl85SS 5X3jiIXw=; b=ReM45Cj+mfsBoy78Qc0ivvqwWsBTQddXYn+tkWpO9sgl2G4BU3K SeAOTCGxoLg04Pk5rAaemvkTaA0So9/o1TVIKZ+umudcmQNkTMlTrujB2lfeQjWl es7w0UsBJ7TH1ygmYh4Oti9Hw+zVuMrr8nO3BWgEALO2M8z755REnc4Lq1LP5j+1 K9CTAkwqwHwAMW45+xyW7MFSi0WaldBVZnVmr0Yh1/3c4BFQcaY9Mibc5nlxVEFy 9lqInohmh4ynR1mDokqMOyFMjGxbUAAtDCcGVLg4jtN6dizzpSscnwIT6z0nYmE0 tvXPpNg6f5Kd27XmVGkZiJf3FraxKJBXgqw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefuddgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 May 2023 19:43:55 -0400 (EDT) Message-ID: <0d15138a-9659-4063-264b-3137354a2406@gutov.dev> Date: Fri, 5 May 2023 02:43:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async Content-Language: en-US To: Eli Zaretskii References: <4ab231d7-3f55-87f1-4d5a-69e476122635@gutov.dev> <83h6sslkov.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83h6sslkov.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63123-done Cc: 63123-done@debbugs.gnu.org, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 04/05/2023 08:39, Eli Zaretskii wrote: >> Date: Thu, 4 May 2023 02:03:03 +0300 >> From: Dmitry Gutov >> >> On 27/04/2023 19:12, Spencer Baugh wrote: >>> - (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n" >>> + (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n" >> >> Looking good, thanks. >> >> Eli, is this for master only? > > Yes, it's a new feature. All right. >> It might not really be a "fix" (an improvement rather), but it seems >> obviously correct: vc-git-annotate-command does this already. > > Is it really awfully important to do this ASAP for Mercurial? No, probably not. Pushed to master and closing. Thanks all! ------------=_1683243902-821-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Apr 2023 16:12:18 +0000 Received: from localhost ([127.0.0.1]:59613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps4EE-0002Tu-2b for submit@debbugs.gnu.org; Thu, 27 Apr 2023 12:12:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:59022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps4E8-0002Tk-Nu for submit@debbugs.gnu.org; Thu, 27 Apr 2023 12:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps4E8-0006Vn-9B for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 12:12:12 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps4E6-0001xf-Ql for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 12:12:12 -0400 From: Spencer Baugh To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make vc-hg-annotate-command async Date: Thu, 27 Apr 2023 12:12:08 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-03-13 built on igm-qws-u22796a Repository revision: e759905d2e0828eac4c8164b09113b40f6899656 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: CentOS Linux 7 (Core) Configured using: 'configure --with-x-toolkit=lucid --with-modules --with-gif=ifavailable' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-vc-hg-annotate-command-async.patch >From 7a9da5d6a08153e36bbf9ee3e29ef2442735d65f Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Thu, 27 Apr 2023 12:11:45 -0400 Subject: [PATCH] Make vc-hg-annotate-command async There's no benefit in this running the process synchrounously, and it's annoying for it to block the Emacs UI. * lisp/vc/vc-hg.el (vc-hg-annotate-command): Run asynchronously. --- lisp/vc/vc-hg.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index f64c342f99c..78231a0c954 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -578,7 +578,7 @@ vc-hg-revision-completion-table (defun vc-hg-annotate-command (file buffer &optional revision) "Execute \"hg annotate\" on FILE, inserting the contents in BUFFER. Optional arg REVISION is a revision to annotate from." - (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n" + (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n" (append (vc-switches 'hg 'annotate) (if revision (list (concat "-r" revision)))))) -- 2.30.2 --=-=-=-- ------------=_1683243902-821-1--